Gerhard Schlager
f0fea5991f
FIX: Latest Selenium gem broke Google Groups import script
...
Selenium uses Keep-Alive since version 3.141, so the net-http-persistent gem shouldn't be needed anymore.
2019-07-10 09:45:33 +02:00
Robin Ward
629bb8adf2
SECURITY: XSS with title selector on preferences page
...
Note this is very low severity as the group needs to be created with a
default title that contains HTML, and group creation is restricted to
staff members right now.
2019-07-09 15:49:24 -04:00
Neil Lalonde
6e22499e5f
Remove unused file resubscribe.html.erb
2019-07-09 15:17:33 -04:00
Dan Ungureanu
ab6ad220c7
DEV: Fix user simulator script.
2019-07-09 18:52:08 +03:00
Gerhard Schlager
5f0d38341e
FIX: Remapping during restore was wrong for CDN URLs
2019-07-09 17:34:41 +02:00
Gerhard Schlager
4c1b8c7559
FIX: Remap differently when backup comes from multisite
2019-07-09 16:11:32 +02:00
Gerhard Schlager
a65a9a85d5
FEATURE: Remap uploads during restore when S3 or CDN changes
...
In order for this to work the Backuper stores a couple of site settings
in the new backup_metadata table, because the old setting values might
not be available on restore anymore.
2019-07-09 14:04:16 +02:00
Gerhard Schlager
5ffb722999
DEV: Less verbose remapping
...
It's hard to see which columns have been remapped when remapping prints
lots of "0 rows affected" lines. This changes it to output the row count
only for affected columns.
2019-07-09 14:04:16 +02:00
Gerhard Schlager
f2dc59d61f
FEATURE: Add hidden setting to include S3 uploads in backups
2019-07-09 14:04:16 +02:00
Dan Ungureanu
9f5cfa192e
FEATURE: Allow Markdown in post notices. ( #7864 )
2019-07-09 14:42:02 +03:00
Daniel Waterworth
6b0cc9e22e
Marked flaky test
2019-07-09 10:45:11 +01:00
Daniel Waterworth
c3db5925a8
FIX: Turbo tests exit codes
2019-07-09 08:51:23 +01:00
Arpit Jalan
f0f271cd5f
Bump onebox version.
...
- remove additional whitespace from Twitter onebox
2019-07-09 13:12:03 +05:30
Penar Musaraj
f4dc6de9f1
FIX: Clear theme editor content on switching tabs
...
Issue happens when sending a null value to ACE Editor.
Fixed by sending an empty string to ACE instead of null.
2019-07-08 20:06:56 -04:00
Arpit Jalan
324e182842
FEATURE: show login and signup button on no-ember layout ( #7867 )
2019-07-09 04:51:19 +05:30
Penar Musaraj
7b0517895e
FEATURE: Add "Group owners" to posting options for groups
...
Context: https://meta.discourse.org/t/121589
This new setting option lets group owners message/mention large groups
without granting that privilege to all members.
2019-07-08 17:14:11 -04:00
Neil Lalonde
9cd3f96dee
FIX: Remap shouldn't try to change read-only columns
...
Read-only columns are obsolete and not used in the code anymore.
Previously, remap would fail when trying to update a read-only column.
2019-07-08 16:52:52 -04:00
Penar Musaraj
b690fc3d98
FEATURE: Add new group visibility option for "logged on users" ( #7814 )
...
Groups can now be marked as visible to "logged on users". All automatic groups (except `everyone`) are now visible to "logged on users", previously they were marked as public but suppressed in the group page for non-staff.
2019-07-08 15:09:50 -04:00
Penar Musaraj
befcf67c90
DEV: run db:create and db:migrate on turbo specs
...
This ensures multisite specs run correctly when running ./bin/turbo_rspec
2019-07-08 14:27:51 -04:00
Arpit Jalan
bb8cf81089
Bump onebox version.
...
- better placeholders for audio/video/trello/typeform oneboxes
- added CSS for audio/video/trello/typeform onebox placeholders
2019-07-08 21:40:33 +05:30
Joe
e49b5fa30c
UX: expand-post button alignment fix ( #7865 )
2019-07-08 14:36:15 +08:00
Arpit Jalan
2cd4e95d82
FIX: show category name in title for crawler view
...
Show category name in title for crawler view despite presence of `short_site_description`.
Bug reported here: https://meta.discourse.org/t/short-site-description-break-category-title-for-crawler-or-its-the-expected-behavior/122109/
2019-07-08 11:42:39 +05:30
Robin Ward
3132a9007b
FIX: Use correct timezone for manual SQL
2019-07-06 15:14:07 -04:00
Robin Ward
a075fd46fd
FIX: Don't use exceptions to catch conflicts
...
If a database exception is raised ActiveRecord will always rollback
even if caught.
Instead we build the query in manual SQL and DO NOTHING when there's a
conflict. If we detect nothing was done, perform an update.
2019-07-06 14:43:56 -04:00
Arpit Jalan
feb828172b
Bump onebox version.
...
- improved spacing for quoted twitter onebox
2019-07-06 09:41:01 +05:30
Kris
a9982b5aa2
UX: Make default site logo height an even 40px
2019-07-05 23:46:43 -04:00
Robin Ward
de6edf9e4e
FIX: Back button would go to previous topic instead of list
...
See related topic:
https://meta.discourse.org/t/back-button-history-not-properly-working/122183
The issue here is the transition was not completing properly which meant
if you backed out of a topic quickly and entered a new one, hitting back
in the second topic would sometimes take you to the previous one instead
of back to the topic list.
2019-07-05 15:53:14 -04:00
Robin Ward
66214eee85
SECURITY: Strip HTML from invite emails
...
We also strip new lines from the emails because it ruins the markdown
formatting which expects a one line message.
2019-07-05 14:57:11 -04:00
Régis Hanol
155cad8b85
FIX: only add image size when with & height are in pixels
2019-07-05 20:34:11 +02:00
Kris
589351d996
UX: Give badge icons width to accommodate for dimensionless SVGs
2019-07-05 12:37:18 -04:00
Penar Musaraj
7c130990e9
FIX: IE grid layout issue on user's own activity page
2019-07-05 12:05:58 -04:00
Robin Ward
c2c169f5b7
FIX: Fail if none of our tags could be updated
...
For example, if a category has a tag restriction and the API tries to
attempt to update it but cannot.
See:
https://meta.discourse.org/t/unallowed-tag-in-conversation-returns-200/122170
2019-07-05 11:40:18 -04:00
Arpit Jalan
5494e17c71
UX: improve twitter status onebox with line breaks
2019-07-05 20:37:08 +05:30
Arpit Jalan
5bc1fd23b0
Bump onebox version.
...
- update HTML for twitter quoted onebox
- updated CSS for twitter quoted onebox
2019-07-05 19:35:36 +05:30
Arpit Jalan
b6605749a0
DEV: clarify purpose of topic_page_title_includes_category site setting
2019-07-05 15:36:56 +05:30
Arpit Jalan
bd084b2147
FIX: do not show invite button if local logins are disabled
2019-07-05 15:16:20 +05:30
Joffrey JAFFEUX
f140c4d499
FIX: ensures routing to / with query string works ( #7859 )
2019-07-05 09:40:19 +02:00
Vinoth Kannan
1bb258ab49
DEV: use upload short-url in html to markdown conversion if 'base62-sha1' data attr available.
2019-07-05 10:06:41 +05:30
Osama Sayegh
65a6f3080e
FIX: don't disable download_remote_images_to_local if site uses S3 ( #7861 )
2019-07-05 13:36:03 +10:00
Sam Saffron
b9a2a4d904
DEV: Avoid emoji for symbols
...
Rake task needs to work across a wide variety of terminal emulators.
Requiring an emoji font is superflous.
2019-07-05 09:41:15 +10:00
Ralph Rooding
1318e0b288
FEATURE: Rake themes installer ( #7848 )
...
* Delete remote_theme when deleting the theme
* Install themes and theme components through rake
* Removed unnecessary test
2019-07-04 14:33:05 -04:00
Robin Ward
72bac61c90
FIX: Upsert a custom field if a unique constraint fails
2019-07-04 13:26:25 -04:00
Penar Musaraj
c78634284c
UI: when in a different topic context, allow dismissing draft without destroying it
...
This changes the label and behaviour of the "No, keep" button in the confirmation modal when user cancels a draft while on a different topic. The new button label is "No, save draft", and when clicked, the composer will be dismissed without destroying the draft.
2019-07-04 11:45:57 -04:00
Penar Musaraj
03805e5a76
FIX: Ensure lightbox image download has correct content disposition in S3 ( #7845 )
2019-07-04 11:32:51 -04:00
Joffrey JAFFEUX
e9bb13c630
DEV: updates jquery-color to prevent it to pull old jquery version ( #7857 )
2019-07-04 15:03:21 +02:00
AhmadF.Cheema
bfbd97d3b5
Remove extra whitespaces from locale files
...
Co-authored-by: Gerhard Schlager <mail@gerhard-schlager.at>
2019-07-04 13:48:17 +02:00
Mario Santos
c5625b70f1
FIX: Prevent emoji-picker from not showing ( #7856 )
...
If an external plugin inserts an element with class "emoji-picker", something probable if they extend EmojiPicker, it could cause troubles as css is added depending on the emoji-picker height. Just by adding a class of a parent <div> as could be d-editor, we prevent this from happening.
2019-07-04 11:46:21 +02:00
Gerhard Schlager
a5e80079d6
FEATURE: Add Belarusian language
2019-07-04 11:37:37 +02:00
Gerhard Schlager
26b843e5e8
Correct typo in spec name
2019-07-04 11:37:37 +02:00
David Taylor
2063d20e9a
Revert "DEV: Let OmniAuth strategies return auth result. ( #7833 )"
...
This reverts commit dc5eb76551
2019-07-04 10:06:18 +01:00
