github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2024-11-29 01:54:12 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity
28,341 Commits 214 Branches 500 Tags 960 MiB
94ae89f61f
Commit Graph

16917 Commits

Author SHA1 Message Date
Sam
89ad2b5900 DEV: Rails 5.2 upgrade and global gem upgrade 
This updates tests to use latest rails 5 practice
and updates ALL dependencies that could be updated

Performance testing shows that performance has not regressed
if anything it is marginally faster now.
 2018-06-07 14:21:33 +10:00
Joe
56dbbfbd2a
FIX: user-fields layout in mobile create account form 2018-06-06 21:02:35 +08:00
Vinoth Kannan
d8e641cd98 FIX: avatar_url includes upload_path twice when local storage used 2018-06-06 18:27:30 +05:30
Guo Xiang Tan
a83ab01264 REFACTOR: Remove extra param for group mentionable and messableable route. 2018-06-06 09:42:09 +08:00
Arpit Jalan
ccbaa719ee
Merge pull request #5923 from techAPJ/group-messageable 
FIX: do not verify group visibility when checking for mentionable/messageable
 2018-06-06 06:45:22 +05:30
Neil Lalonde
9ba9ff187c Add plugin outlet to admin plugins index 2018-06-05 17:47:30 -04:00
Arpit Jalan
f8d82f135f FIX: do not verify group visibility when checking for mentionable/messageable 2018-06-05 16:59:21 +05:30
Guo Xiang Tan
d600e71b3d FIX: Clean up stale UserExport records daily. 
* Add tests for `UserExport.remove_old_exports`
 2018-06-05 09:43:40 +08:00
Rafael dos Santos Silva
74c33a5316
Merge pull request #5915 from jjaffeux/sharing-macos-chrome 
FIX: sharing popup not showing on macos/chrome
 2018-06-04 20:38:10 -03:00
Joffrey JAFFEUX
40b3efacaa FIX: sharing popup not showing on macos/chrome 
Despite `navigator.share` being defined the call was failing with this error:

```
sharing DOMException: Internal error: could not connect to Web Share interface.
```
 2018-06-05 01:18:57 +02:00
Robin Ward
fab59c66f0 FIX: Protection against dangling category group records 2018-06-04 15:43:26 -04:00
Régis Hanol
6024fb84cc make rubocop happy 2018-06-04 19:06:52 +02:00
Régis Hanol
ab8cdd6b5b
Upload.url can't be NULL 2018-06-04 18:43:00 +02:00
Régis Hanol
085eaaf18d
FIX: always delete invalid upload records 2018-06-04 18:40:57 +02:00
Arpit Jalan
46fc57222f FEATURE: improve handling of site setting secrets 2018-06-04 21:31:34 +05:30
Arpit Jalan
36f9af4fa4 minor optimizations for post rejected logs 2018-06-02 09:44:55 +05:30
Robin Ward
597ffd7e3f FIX: Keyboard shortcuts didn't work on subfolders 2018-06-01 14:38:09 -04:00
Arpit Jalan
89eca87f16 FEATURE: add staff action log for post rejections 2018-06-01 21:48:27 +05:30
Kris
41999b9949 Limiting history modal height and width 2018-06-01 11:59:29 -04:00
Gerhard Schlager
b970b072f6 FIX: User merge should not fail when primary email address is missing 
The merge process might move all email addresses of the source user to the target user. Destroying the source user failed in that case.
 2018-06-01 16:23:21 +02:00
Joe
560a950da9
FIX: alignment for instructions on change email and 2FA fields 2018-06-01 09:51:46 +08:00
Guo Xiang Tan
9ef61e0af5 PERF: Prefer exists? instead of loading AR object. 2018-06-01 09:44:14 +08:00
Kris
ba7aff62db safety so pre blocks can't break modal width 2018-05-31 18:19:27 -04:00
Kris
6c15effca2 envelope missing on invite page, long pre lines making modals wide 2018-05-31 18:11:24 -04:00
Guo Xiang Tan
95f9b72351 FIX: Update activation email route was returning a generic json error. 2018-05-31 14:19:43 +08:00
Kris
3e9f1d5cf6 Few small modal fixes 2018-05-30 23:24:43 -04:00
Kris
57cef06192 incoming email modal width too narrow 2018-05-30 15:28:29 -04:00
Joffrey JAFFEUX
8128cbd7db
UX: adds subtitle support for modals 2018-05-30 17:14:00 +02:00
Joffrey JAFFEUX
43b1768987
UX: ceil dahsboard values 2018-05-30 16:32:43 +02:00
Arpit Jalan
704cca3de2 FIX: add proper search context for personal messages 2018-05-30 14:47:46 +05:30
Guo Xiang Tan
21e9315416 FIX: Use user account email instead of auth email when totp is enabled. 
https://meta.discourse.org/t/github-2fa-flow-broken/88674
 2018-05-30 12:15:12 +08:00
Gerhard Schlager
864ada835b FEATURE: Add Bulgarian language 2018-05-29 21:07:17 +02:00
Kris
7483805f0c Increasing min-width of modals for larger screens 2018-05-29 13:13:35 -04:00
Neil Lalonde
e26a14dc29 FIX: error when flagging to notify moderators because message title is too long 2018-05-29 12:21:47 -04:00
Joffrey JAFFEUX
ee8cda691d
FIX: simplifies and corrects new collection header tag/drop behaviour 2018-05-29 17:34:34 +02:00
Gerhard Schlager
ce687f334b UX: The "enable 2FA" string was hard to translate 2018-05-29 16:25:43 +02:00
Joffrey JAFFEUX
a8079ab679
FIX: show none/all on cat/tag drop only when needed 2018-05-29 16:08:31 +02:00
Joffrey JAFFEUX
597095f56f
UX: adds visual feedback when hovering info 2018-05-29 13:31:57 +02:00
Joffrey JAFFEUX
87edde3113
UX: improves dashboard UI for RTL locales 2018-05-29 10:22:31 +02:00
Arpit Jalan
277e216d25 FIX: link to pm tags when searching in personal messages 2018-05-29 12:32:20 +05:30
Sam
df815d6c0e DEV: prefer using ordering in relation over default scope 2018-05-29 09:34:12 +10:00
Joffrey JAFFEUX
16d0ab5654 Revert "UX: localizes titles in dashboard table reports" 
This reverts commit 409c0ddf85.
 2018-05-28 20:35:22 +02:00
Joffrey JAFFEUX
409c0ddf85
UX: localizes titles in dashboard table reports 2018-05-28 20:03:05 +02:00
Joffrey JAFFEUX
4b9c713581
FIX: avoids hidding mobile keyboard on each keystroke 2018-05-28 16:18:25 +02:00
Joffrey JAFFEUX
a585c19f2e
FIX: prevents collection header from going under rows 2018-05-28 15:47:07 +02:00
Arpit Jalan
8d9c77e113 optimize group invitation code 2018-05-28 17:59:14 +05:30
Joffrey JAFFEUX
478ccb6698
UX: lower no-change trend emphasis in charts 2018-05-28 13:55:25 +02:00
Arpit Jalan
c8bc942333 FIX: do not add invited user to automatic groups 2018-05-28 17:17:48 +05:30
Gerhard Schlager
ed2ae3cb0a FIX: Load post revisions in correct order 2018-05-28 11:25:24 +02:00
Joffrey JAFFEUX
82e5727287
UX: -2/+2% change in stats should be no-change in dashboard 2018-05-28 10:55:42 +02:00
Guo Xiang Tan
754458e6a2 PERF: Minor but we can just pass a hash to where. 
```
Warming up --------------------------------------
          4 x .where     1.040k i/100ms
          1 x .where     1.677k i/100ms
Calculating -------------------------------------
          4 x .where     10.321k (± 5.2%) i/s -     52.000k in
5.053803s
          1 x .where     17.117k (± 3.8%) i/s -     85.527k in
5.004107s

Comparison:
          1 x .where:    17117.1 i/s
          4 x .where:    10321.3 i/s - 1.66x  slower
```
 2018-05-28 16:41:38 +08:00
Arpit Jalan
54338cfdcb FEATURE: add support for group_name parameter in /new-message route 2018-05-28 13:26:41 +05:30
Guo Xiang Tan
a081771950
Merge pull request #5872 from OsamaSayegh/users-controller-specs-to-request 
REFACTOR: users contollers specs => request specs
 2018-05-28 13:32:37 +08:00
Guo Xiang Tan
0b55416742 UX: Don't display all groups option if group directory is disabled.a 
https://meta.discourse.org/t/all-groups-option-leads-to-access-denied-page/88464
 2018-05-28 11:32:55 +08:00
Sam
5a32a70d6c FIX: ColorScheme color missing was returning "nil" 2018-05-28 11:46:00 +10:00
Kris
4bd24e78fc padding fix, small phone fix 2018-05-26 01:12:33 -04:00
OsamaSayegh
449399bef3 return 403 forbidden when local logins disabled 2018-05-26 05:18:19 +03:00
Régis Hanol
5b2e7c8d10 fix the build 2018-05-26 03:11:10 +02:00
Régis Hanol
338d39265a FIX: don't publish notifications_state when user has been deleted 2018-05-26 02:27:54 +02:00
Régis Hanol
d23229df85 Let's use the same method 2018-05-26 02:16:53 +02:00
Régis Hanol
f988fa31aa FIX: ensure 'notifications_state' is up to date after creating a notification 2018-05-26 02:09:48 +02:00
Kris
cc0a5f4526 login fixes, auth message and alignment 2018-05-25 19:15:39 -04:00
Kris
6fc292fef5 reducing some specificty 2018-05-25 17:33:45 -04:00
Robin Ward
587a9c82f5 FIX: Use the username formatter when updating cooked usernames 2018-05-25 17:29:06 -04:00
Kris
3b2af4b91f Adjustments and fixes to updated login design 2018-05-25 16:44:44 -04:00
Robin Ward
4195c7c9ea FEATURE: Ability to clear a user's penalty history 
You can do this manually if you want to allow them to reach TL3 without
their penalty history counting against them.
 2018-05-25 12:54:22 -04:00
Robin Ward
c658fb6e31 Move some display logic out of model, upgrade old code patterns 2018-05-25 12:54:22 -04:00
Neil Lalonde
fdce116838 UX: mobile watched words UI in admin needs a way to see all word lists 2018-05-25 11:13:38 -04:00
Robin Ward
3c8369def6 The isSilenced and isSuspended aliases were useless 
We already had `silenced` and `suspended` on the model with the same
effect!
 2018-05-25 10:29:26 -04:00
Joe
4a2931f43d
FEATURE: New login / create account form layout 2018-05-25 20:16:38 +08:00
Joe
1948a9912c
FEATURE: Horizontal login / create accout layout 2018-05-25 20:15:34 +08:00
Joe
7f6f61cff2
FIX: Move tips into instructions div 2018-05-25 20:13:06 +08:00
Joe
1a9aeca93b
FIX: Move tips into instructions div 2018-05-25 20:12:08 +08:00
Joe
9e546e9ddc
FIX: Move tips into instructions div 2018-05-25 20:11:22 +08:00
Joffrey JAFFEUX
a8901efafe
FIX: flags report is now a lower is better kind of report 2018-05-25 12:59:39 +02:00
Joffrey JAFFEUX
acc5e42066
removes logging 2018-05-25 12:12:28 +02:00
Joffrey JAFFEUX
e67ac93e6c
UX: makes table report trend icons as charts 
This commit will also reverse icon orientation if higher_is_better = false
 2018-05-25 12:09:30 +02:00
Gerhard Schlager
20b94bc714 FIX: Extraction of quoted posts failed in some cases 
* It stored only oneboxed "quotes" when [quote] and links to topics or posts were mixed.
* Revising a post didn't add or remove records from the quoted_posts table.
 2018-05-25 12:00:17 +02:00
riking
501bc0e9af FIX: UserProfileView: Do not log IP of logged-in users 2018-05-25 15:54:14 +10:00
Guo Xiang Tan
9d307a9977 FIX: Destroy notifications and sync notifications count in transaction. 
* Seeing errors where the user is destroyed right when the call to
  reload is made.
 2018-05-25 12:01:36 +08:00
Guo Xiang Tan
755b511b5c PERF: Destroy collapsed notifications in 1 query instead of 3. 2018-05-25 12:01:36 +08:00
Guo Xiang Tan
569f63b8a2
Merge pull request #5825 from featheredtoast/extend-service-worker-cache 
FIX: update cache times for service workers
 2018-05-25 09:28:17 +08:00
Joffrey JAFFEUX
1be76d066c
FIX: forces boolean when content is only "true" && "false" 2018-05-24 23:41:39 +02:00
Robin Ward
a31a458a67 Trivially fix some odd whitespace, indentation 2018-05-24 12:29:55 -04:00
Régis Hanol
bb8f0087f4 Add a warning when PostAlerter isn't running in sidekiq 2018-05-24 17:52:59 +02:00
Régis Hanol
71f66cd679 FIX: ensure PostAlerter is always run in sidekiq 2018-05-24 17:27:43 +02:00
Kris
c5dbfe1886 liked icon should use d-icon 2018-05-24 11:08:13 -04:00
Arpit Jalan
cafd1241b9 FIX: make report data export more resilient to inconsistent date format 
The DAU/MAU report export was failing because of date being a string
and not a valid Date value
 2018-05-24 17:14:08 +05:30
Guo Xiang Tan
3bfd9698c7 PERF: Avoid running the same query twice in TopicViewSerializer#details. 2018-05-24 16:46:13 +08:00
Joe
5ec896d163
FIX: align categories with menu panel links 2018-05-24 16:15:57 +08:00
Guo Xiang Tan
0e284e54f3
Merge pull request #5832 from featheredtoast/safari-no-serviceworkers 
Fix: Safari failing to download backups from email links
 2018-05-24 15:44:51 +08:00
Guo Xiang Tan
43f7cb05c9 FIX: Broken ping event for web hooks due to missing payload. 2018-05-24 15:16:52 +08:00
Guo Xiang Tan
b3860c82da FIX: Don't enqueue web hooks inside a deferred queue. 
* The deferred queue is meant for short lived jobs
  and does not guarantee execution. We need to ensure
  that web hooks are always run.
 2018-05-24 15:03:17 +08:00
Guo Xiang Tan
8a1aab4e8a PERF: Select distinct active web hooks at the db level. 2018-05-24 14:56:40 +08:00
Sam
4fef9e95d2 should not be a const 2018-05-24 15:42:00 +10:00
Sam
53b97b28f0 FIX: in rare conditions post timing would miss the user 2018-05-24 15:38:33 +10:00
Sam
70179290f3 clean up callbacks during acceptance tests 2018-05-24 15:28:54 +10:00
Sam
4194886b62 correct failing test 2018-05-24 13:02:20 +10:00
Sam
ed08545d1f FEATURE: allow searching in title in advanced search 
Add UI for matching in title only in advanced search options
 2018-05-24 12:34:53 +10:00
Sam
11b544ef4e DEV: add support for custom post message callbacks 
Allows for cleaner subscription to changes by plugins, polls will move to
it.
 2018-05-24 12:34:53 +10:00