Commit Graph

31835 Commits

Author SHA1 Message Date
Kris
61fff098ed minor email/whisper icon alignment fix 2019-01-18 20:59:52 -05:00
Kris
3b7ac3f6eb UX: We don't have bulk select on mobile, so we should hide the button 2019-01-18 20:26:58 -05:00
Kris
df0303c912 UX: Improve button alignment, fix invite header 2019-01-18 20:08:52 -05:00
Kris
e6e4a073a5 alignment fix due to font-size bump 2019-01-18 16:24:27 -05:00
Kris
4f897dde50 UX: Improve alignment of new post badge on mobile 2019-01-18 16:17:24 -05:00
Kris
247ab4a830 Align notification in unread education message 2019-01-18 15:40:07 -05:00
David Taylor
59028035df FIX: Update about/license URLs when updating theme from remote source 2019-01-18 17:46:57 +00:00
Joffrey JAFFEUX
95f9a369a5
FIX: ensures visits reports are correcttly differencing mobile/all (#6905) 2019-01-18 17:24:18 +01:00
Joffrey JAFFEUX
7908a522a0
FIX: postLabel was not working for totals (#6904) 2019-01-18 17:06:43 +01:00
David Taylor
0b6be2cebc FIX: Correct deprecated theme settings in handlebars templates
Was overriding the incorrect `themeSetting.blah` syntax, instead of `themeSettings.blah`
2019-01-18 15:39:50 +00:00
Bianca Nenciu
b9b5527c63 DEV: Remove Job stub. 2019-01-18 17:35:45 +02:00
David Taylor
b1b8c37e62 FIX: Correctly import theme assets with spaces in filename
This issue is caused by the filename restrictions in `OptimizedImage#ensure_safe_paths!`. Difficult to add a test for this because image optimization is bypassed in test mode.
2019-01-18 15:20:11 +00:00
Maja Komel
45f66826ee PERF: delete potentially large associated tables before user_destroyer.destroy transaction 2019-01-18 16:10:03 +01:00
Claas Augner
78362448bc I18n: fix typo (#6903)
In site_settings.likes_notification_consolidation_window_mins
2019-01-18 10:01:41 -05:00
Penar Musaraj
f8f281cdad UI: update "latest" canvas layout in wizard 2019-01-18 09:56:39 -05:00
Gerhard Schlager
457e6c7b37 FIX: Mods weren't able to see emails in admin user list 2019-01-18 15:37:30 +01:00
David Taylor
f774f08d5f DEV: Remove theme_var fields from import spec 2019-01-18 12:27:25 +00:00
David Taylor
f40c97c367 Remove support for theme_var and theme_color_var fields
These are remnants of the old 'customization' system, and have been superseded by theme settings
2019-01-18 12:04:23 +00:00
Joffrey JAFFEUX
b520d0efad
pull last Chart.js file (#6902) 2019-01-18 12:25:34 +01:00
Joffrey JAFFEUX
3c4e6da391
DEV: bump Chart.js lib to 2.7.3 (#6901) 2019-01-18 12:03:59 +01:00
Gerhard Schlager
197e3fd722 FIX: Keep original subject in emails to staged users
Renaming a topic shouldn't be visibile to staged users when the topic was created via email.
2019-01-18 11:07:54 +01:00
Gerhard Schlager
15d1e981c8 DEV: Improve specs
* notifications were created for the wrong user
* notifications didn't have a correct data attribute
2019-01-18 11:07:53 +01:00
Joffrey JAFFEUX
b20ad9d684
FIX: since Ember 3 interceptClick was not working on buffered links (#6898) 2019-01-18 11:01:19 +01:00
Guo Xiang Tan
ee7ab3e2ec Pause MiniScheduler when Sidekiq is paused. 2019-01-18 17:50:24 +08:00
tshenry
1e5ddb007f Add brief section on bounce handling to email doc (#6900) 2019-01-18 01:02:05 -08:00
Guo Xiang Tan
95e3841974 FIX: Remove old reference and use MiniScheduler::Stat. 2019-01-18 16:36:11 +08:00
Guo Xiang Tan
f89a32e759 FIX: Text logo does not show up on non ember pages. 2019-01-18 15:11:42 +08:00
Rishabh
a827e2afe3 UX: correct innacurate descriptions for short_title, pwa_config_title_warning
follow-up on 1a39f6fd
2019-01-18 11:29:16 +05:30
Bianca Nenciu
cf6223226d DEV: Do the draft conflict check async. (#6895) 2019-01-18 15:51:56 +11:00
Gerhard Schlager
1d0ee6fa8d UX: Remove unused translations (#6885)
These messages aren't needed any more since bb93a345eb
2019-01-18 12:09:20 +08:00
Penar Musaraj
2274d6d7ac FIX: refresh "/categories" on logo click (#6891)
* FIX: refresh discovery categories on logo click

* Fix prettier offence
2019-01-18 12:08:42 +08:00
Kris
9f52306861 Keep avatar image at native size for normal font-size, remove unneeded clearfix 2019-01-17 21:54:22 -05:00
Sam
a7628c1d74 FIX: use ordered_posts for last post check, not the posts relation
The `posts` relation on `Topic` is not ordered. Using `Topic.posts.first`
is basically the same as asking for a random post, it will depend on DB
order. This breaks on Topic merge and split for example.

Additionally, a huge problem with that is that it forces active record down
a slow path. `Topic.posts.first` is extremely slow on giant topics, since
it has no default ordering it appears AR materializes the entire set prior
to doing `first`.

This commit also illustrates the importance of testing, initially I only
fixed the second instance of the problem in `post_validator.rb` but testing
revealed that the problem was repeated at the top of the file.

Longer term we should consider a larger change of default ordering the posts
relations so people do not fall down this trap anymore.
2019-01-18 13:18:40 +11:00
Kris
8c5c4200ec prettier 2019-01-17 21:13:52 -05:00
Kris
5307e9337f HACK: Reduce icon jitter while scrolling with composer open in iOS 2019-01-17 21:04:05 -05:00
Jeff Atwood
b2a12de8a1 remove out of date copy on category desc 2019-01-17 16:54:52 -08:00
Daniel Bachhuber
05f63db82c Update README license year from 2018 to 2019 (#6896) 2019-01-18 08:15:57 +08:00
Kris
d5d994e24a UX: Improving user stream alignment and spacing 2019-01-17 17:29:27 -05:00
Kris
43bb16de27 Prevent header icons from overflowing with long title present 2019-01-17 16:11:40 -05:00
Régis Hanol
1e67bcb456
PERF: bulk feature topic users & reset topic counters after an import 2019-01-17 21:48:23 +01:00
Kris
7401901939 UX: Badge alignment adjustments 2019-01-17 15:46:55 -05:00
Vinoth Kannan
2818afb267 FIX: Do not hide posts automatically when flagged by staff user 2019-01-18 01:33:55 +05:30
Kris
3c987132cb Prevent placeholder text from being cut-off 2019-01-17 14:39:28 -05:00
Penar Musaraj
78730062de Fix prettier offence in local-dates plugin 2019-01-17 14:22:35 -05:00
Penar Musaraj
020e0d623a DEV: run "yarn install" before lint tests 2019-01-17 14:17:44 -05:00
Penar Musaraj
3501533a2b DEV: unpin Prettier version, apply to YAML files
We had Prettier pinned because of https://github.com/prettier/prettier/issues/5529. Since that bug is fixed, unpinning.

Prettier now supports YAML, so this applies Prettier to all .yml except for translations, which should not be edited directly anyway.
2019-01-17 13:05:39 -05:00
Penar Musaraj
77fda4dc00 Code styling fix
See 1c1fd2051f (r31953997)
2019-01-17 12:40:05 -05:00
Kris
b664674d2b make smaller text size bigger 2019-01-17 12:11:31 -05:00
Vinoth Kannan
b9215ddaea FIX: Navigate to full page search when enter key used in topic 2019-01-17 22:34:23 +05:30
Kris
b9355f316a Minor size/alignment fixes for font size increase 2019-01-17 11:42:03 -05:00