github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2024-12-12 10:53:42 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity
28,087 Commits 214 Branches 500 Tags 960 MiB
95f9b72351
Commit Graph

16843 Commits

Author SHA1 Message Date
Neil Lalonde
0e2584b841 fix cursor on disabled composer 2018-04-12 11:32:13 -04:00
Gerhard Schlager
f042a9529b FIX: users shouldn't get notifications about mentions from system users 
(unless the mentioned users are participants in a PM with the system user)
 2018-04-12 16:19:44 +02:00
Joffrey JAFFEUX
5fc2eadd09
FIX: adds ellipsis on name of dropdown-select-box row 2018-04-12 11:39:45 +02:00
Guo Xiang Tan
a389baeb07 FIX: Group pages should work when group name contains periods. 
https://meta.discourse.org/t/group-name-cant-have-dot-inside/48658
 2018-04-12 17:11:36 +08:00
Joffrey JAFFEUX
deab0486fa
FIX: apply fa-fw on class instead of icon name 2018-04-12 10:56:32 +02:00
Guo Xiang Tan
6e46f81123 Add a distributed mutex around user creation via SSO. 
* When two SSO requests containing the same email in the payload are
  sent at the same time, it would sometimes result in two users
  being created but one without an email record. Investigations
  points to ActiveRecord not generating the right statements but
  we have no figured out the reproduction steps yet. We should review
  this after upgrading to Rails 5.2.
 2018-04-12 16:18:49 +08:00
Kris
7ff78cc013 docked topic progress indicator too wide 2018-04-11 23:52:32 -04:00
Guo Xiang Tan
c0595ebe99 FIX: Disable save button when new group form is empty. 
https://meta.discourse.org/t/adding-owners-members-ux-is-inconsistent-and-misleading/58084/26?u=tgxworld
 2018-04-12 10:29:36 +08:00
Régis Hanol
1a9271dd2f add a warning in robots.txt when using subfolder 2018-04-12 00:00:15 +02:00
Régis Hanol
062bf8bad3 add back missing 'group-edit' plugin outlet 2018-04-11 22:43:48 +02:00
Régis Hanol
df7970a6f6 prefix the robots.txt rules with the directory when using subfolder 2018-04-11 22:05:02 +02:00
Neil Lalonde
fcd20a70d7 FIX: allow lists in summary email post excerpts 2018-04-11 14:16:08 -04:00
Joffrey JAFFEUX
d16c4b0677
FIX: adds incorrectly removed context checkbox 2018-04-11 16:57:34 +02:00
Kris
be72d65355 Mobile upload modal alignment 2018-04-11 10:24:58 -04:00
Vinoth Kannan
19e8f9af13 Remove support for theme settings in raw handlebar templates 2018-04-11 18:21:04 +05:30
Sam
b05ada3208 Avoid console error in tests 2018-04-11 16:11:53 +10:00
Sam
489c22d93c FEATURE: Disallow tags and categories rss feeds 
This stops crawlers from hitting tags and category rss feeds to discover
new content, instead they should focus on latest/posts if they need to
consume something regular
 2018-04-11 14:36:10 +10:00
Arpit Jalan
c0a0b81335
Merge pull request #5730 from techAPJ/enforce-tagging 
FEATURE: enforce tagging on categories
 2018-04-11 09:44:33 +05:30
Guo Xiang Tan
3b9a656439 FIX: An option in aliasLevelOptions was accidentally removed. 2018-04-11 11:03:44 +08:00
Guo Xiang Tan
9176b2591d UX: Replace route when users try to access invalid group management page. 
https://meta.discourse.org/t/unable-to-save-changes-to-a-group/84954
 2018-04-11 10:55:45 +08:00
Sam
f40f10240c FEATURE: remove topic rss from robots 
Crawlers love hitting the rss feeds (confirmed that both Google and Bing do)

Experimenting with the impact of blocking these feeds and forcing Crawlers to hit
the content direct. It is better if they hit the actual page to start with as opposed to

1. Hit RSS feed
2. Find new content
3. Hit post link
4. Get canonical
5. Hit canonical

Lots of pointless work.

We do not know for sure what impact this will have on newsreader apps,
we will listen for feedback.
 2018-04-11 11:57:52 +10:00
Arpit Jalan
48d43b33cc add client side validation for category minimum_required_tags 2018-04-11 07:17:52 +05:30
Arpit Jalan
9ca6ebe8fe FEATURE: enforce tagging on categories 2018-04-11 07:15:24 +05:30
Jeff Wong
4c6d2ed59a
Merge pull request #5749 from featheredtoast/service-worker-registration-fixes 
Fix - service worker registrations
 2018-04-10 16:37:06 -07:00
Neil Lalonde
6e6892c88e FEATURE: when uncategorized topics are not allowed, disable the post input until a category is chosen 2018-04-10 19:31:28 -04:00
Jeff Wong
32f919ea34 Fix - service worker registrations 
* register service workers in a development env

* register service worker from ember initialize fn
 2018-04-10 15:17:32 -07:00
Neil Lalonde
d389d66f8d FIX: remove duplicates in available titles 2018-04-10 12:02:05 -04:00
Joffrey JAFFEUX
11c47f57f9
FIX: prevents keyboard from appearing on android when expanding 2018-04-10 16:25:05 +02:00
Vinoth Kannan
4822b77b49 Exclude available_groups from category web hooks 2018-04-10 16:46:22 +05:30
Vinoth Kannan
96867743c8 Exclude suggested topics from topic view web hook 2018-04-10 16:38:48 +05:30
Arpit Jalan
3a86a2588c FIX: bulk append/replace tags was not working 2018-04-10 13:01:03 +05:30
Guo Xiang Tan
867f327055 Remove horizontal padding for group navigation links. 2018-04-10 14:22:57 +08:00
Guo Xiang Tan
874003b7b1 FIX: Group can't be deleted if certain users are demoted. 2018-04-10 14:19:35 +08:00
Guo Xiang Tan
9df4f7bf8e UX: Move group delete button to details container. 2018-04-10 14:19:35 +08:00
Sam
fe37ce165d correct issue where groups was never being blanked 2018-04-10 15:30:18 +10:00
Sam
5925a581db array is not supported here, use a simple comma delimited list 2018-04-10 14:37:10 +10:00
Sam
afaeb20f27 FEATURE: Add option to have sso synchronize group membership 
In some cases add_groups and remove_groups is too much work, some sites
may wish to simply synchronize group membership based on a list.

When sso_overrides_groups is on all not automatic group membership is
sourced from SSO. Note if you omit to specify groups, they will be cleared
out.
 2018-04-10 13:17:23 +10:00
Guo Xiang Tan
ffb7ec2543 Fix the build. 2018-04-10 09:50:00 +08:00
Guo Xiang Tan
d9d86577ff FIX: Staff users are not affected by enable_group_directory site setting. 2018-04-10 09:22:01 +08:00
Neil Lalonde
d7ea6f93e7 FIX: preference page error when badges are disabled 2018-04-09 14:27:00 -04:00
Kris
affb935760 Cleaning up secondary stats on user profile 2018-04-09 14:02:43 -04:00
Régis Hanol
d19bbfc7f8 UX: ensure the topic progress indicator is never overlapping with post controls 2018-04-09 19:44:35 +02:00
Joffrey JAFFEUX
bd7100a062 FEATURE: revamp full-page-search UI (#5703) 
This is the first iteration of this revamp, a following iteration will focus on improving the controls in the advanced search sidebar.
 2018-04-09 11:51:09 -04:00
Régis Hanol
41150fc0cd FIX: J/K keyboard shortcut misbehaving 2018-04-09 17:28:43 +02:00
Gerhard Schlager
62aacce8f4 FEATURE: Notify flaggers when flagged post is edited by author 2018-04-09 16:45:33 +02:00
Kris
0e9ec237a2 Adding top margin to mobile user profile 2018-04-09 10:14:52 -04:00
Guo Xiang Tan
c82b2dcc24 Remove admin group management pages. 2018-04-09 15:14:50 +08:00
Guo Xiang Tan
4319273cf5 UX: Split up group form into smaller sections. 2018-04-09 15:14:50 +08:00
Arpit Jalan
185d6ac747 FIX: use safe navigation operator when checking for totp_enabled 2018-04-09 12:33:41 +05:30
osamasayegh
fe8301007c Add spec + make it work with .raw templates 2018-04-09 16:47:28 +10:00
osamasayegh
ce1a6f2fd8 FEATURE: Theme settings in handlerbars templates 2018-04-09 16:47:28 +10:00
David Taylor
ad7f2b7dc6 Allow import and keyGen URLs to be overridden in import modal 2018-04-09 16:42:47 +10:00
David Taylor
a17cb11dc3 Allow adminCustomizeThemes.edit route name to be overridden in themes-show 2018-04-09 16:42:47 +10:00
David Taylor
37fe1c76b9 Allow FIELDS_IDS to be overridden 2018-04-09 16:42:47 +10:00
David Taylor
70e60f4afe Allow adminCustomizeThemes.edit route name to be overridden 2018-04-09 16:42:47 +10:00
David Taylor
7426e63c30 Allow theme asset upload url to be overridden 2018-04-09 16:42:47 +10:00
Arpit Jalan
f5febe5843 FIX: date range was inconsistent for admin dashboard reports 2018-04-08 16:49:41 +05:30
Jeff Wong
641276af46 more consistent colors for dark themes on hover (#5743) 2018-04-06 22:44:51 -04:00
Neil Lalonde
e33aef729f FIX: unable to save groups with mixed case names 2018-04-06 16:12:35 -04:00
Neil Lalonde
f6cfff3cea UX: user preferences allows users to choose which title to use from their badges and groups 2018-04-06 14:34:36 -04:00
Guo Xiang Tan
a2b9a55036 FIX: Binding style attributes need to be escaped. 
See http://emberjs.com/deprecations/v1.x/#toc_binding-style-attributes
 2018-04-06 14:58:38 +08:00
Guo Xiang Tan
63ac34ed79 Move official plugin icon under own header. 2018-04-06 12:44:31 +08:00
Joshua Rosenfeld
8da296ce12
FIX: Broken PM title line wrapping 2018-04-06 00:03:54 -04:00
Guo Xiang Tan
0623785f69 FIX: Prevent group owners from editing admin only settings. 2018-04-06 11:44:58 +08:00
Guo Xiang Tan
2ddcdf8704 UX: Add an icon to indicate if a plugin is official. 
https://meta.discourse.org/t/improving-admin-plugins/84585
 2018-04-06 10:54:58 +08:00
Kris
50257ebfb1 adding margin to PM glyph on mobile 2018-04-05 22:33:58 -04:00
Guo Xiang Tan
e4a9242ada FIX: Can't upload backup. 
* Regression introduced in 142571bba0
 2018-04-06 10:14:17 +08:00
Sam
3a7b696703 FEATURE: allow for setting crawl delay per user agent 
Also moved to default crawl delay bing so no more than a req every 5 seconds is allowed

New site settings:

"slow_down_crawler_user_agents" - list of crawlers that will be slowed down
"slow_down_crawler_rate" - how many seconds to wait between requests

Not enforced server side yet
 2018-04-06 10:15:23 +10:00
Joffrey JAFFEUX
f0fe16d824
FEATURE: implements minimum selection for select-kit 2018-04-05 16:45:19 +02:00
Gerhard Schlager
cd6a99a027 FEATURE: Send a different PM when a post has been hidden more than once 2018-04-05 14:03:21 +02:00
Gerhard Schlager
35efdb39b3 FEATURE: Show the current reply count of the flagged post 2018-04-05 14:03:02 +02:00
Gerhard Schlager
f2d00e5eff FEATURE: Use Message-ID for detecting email replies to group 
Ignores the site setting "find_related_post_with_key" and always tries to honor the `In-Reply-To` and `References` header for emails sent to a group.

The senders email address must be included in the `To` or `CC` header of a previous email sent to the group and the `Message-ID` of that email must be included in the current email's `In-Reply-To` or `References` header.
 2018-04-05 11:00:38 +02:00
Guo Xiang Tan
e36e9de28a Allow admin to view logs of automatic groups. 2018-04-05 16:31:55 +08:00
Régis Hanol
d5412cff4e FIX: scrolling was off sometimes 
Also changed "Jump To Post" to go to the post index in the stream rather than the post number
 2018-04-05 10:08:48 +02:00
Guo Xiang Tan
a26d3fc2de Missing save button when editing automatic groups. 2018-04-05 15:25:39 +08:00
Guo Xiang Tan
d7943cc3db Make eslint happy. 2018-04-05 15:21:11 +08:00
Sam
f8637ed616 FIX: if a message is *partially* archived consider it not archived 2018-04-05 17:17:47 +10:00
Guo Xiang Tan
85bcda120a Basic UX improvements to the group profile management page. 2018-04-05 14:59:04 +08:00
Guo Xiang Tan
8760c4d68c Fix GroupsController#group_params to allow more group attributes to be updated. 2018-04-05 13:53:00 +08:00
Robin Ward
17f12c0ce4 Add new plugin outlet below admin user names 2018-04-04 15:47:14 -04:00
Vinoth Kannan
434cbc649f FEATURE: Webhook for tag events 2018-04-04 17:49:20 +05:30
Arpit Jalan
c36e201eb3 FIX: update categories topic_count when converting topic to a PM and vice versa 2018-04-04 12:01:56 +05:30
Guo Xiang Tan
e6d07fa6d8 UX: Allow admins to manage automatic groups on group page. 2018-04-04 11:07:11 +08:00
Joffrey JAFFEUX
b1cc368da8
FIX: regression where tag could not be deleted with click 2018-04-04 00:56:45 +02:00
Arpit Jalan
88e4c0ec3a FIX: new/unread tabs should re-appear dynamically 2018-04-04 00:08:31 +05:30
Neil Lalonde
b7ecdb72d6 FIX: update Google Tag Manager javascript 2018-04-03 14:22:06 -04:00
Robin Ward
76d734ea6e A more extensible way to disable expanding/contracting of user profiles 2018-04-03 14:19:56 -04:00
Robin Ward
0188cbb650 UX: New dropdowns work well on mobile for category notifications 2018-04-03 12:09:00 -04:00
Robin Ward
a383b368c6 FIX: The order of import globbing is not deterministic 
Using a wildcard would load in a different order on some installs
resulting in unpredictable behavior (for example, `is-hidden` being
displayed due to a `display: flex` in a different file.)
 2018-04-03 11:40:53 -04:00
Guo Xiang Tan
6f32de186a UX: Add a "add members" button on group page. 2018-04-03 17:35:18 +08:00
Joffrey JAFFEUX
61812b52e7
FIX: more conservative refactoring to avoid regressions in customisations 2018-04-03 10:35:22 +02:00
Arpit Jalan
54819d72c9 UX: show users who liked the post when expanding post actions 2018-04-03 08:24:09 +05:30
Joffrey JAFFEUX
d54da517d9
FIX: more resilient focus filter or header 2018-04-02 22:50:20 +02:00
Joffrey JAFFEUX
017f5c1aee
FIX: regression preventing backspace to work on mini-tag-chooser 2018-04-02 22:42:20 +02:00
Robin Ward
58c81db279 Apply a 'no-group' class to quotes for styling 2018-04-02 14:02:16 -04:00
Robin Ward
90d3544db8 UX: Add a class we can use to target quotes without groups 2018-04-02 14:02:16 -04:00
Guo Xiang Tan
00d879ec63 Fix the build. 2018-04-03 00:44:12 +08:00
Guo Xiang Tan
2498403bc3 Revert "FIX: Username uniqueness check should not happen to current user_id" 
This reverts commit f71a18facd.
 2018-04-03 00:44:04 +08:00
Joffrey JAFFEUX
5685b45fa6
FIX: manually adds tag if existing but not in returned matches 2018-04-02 18:33:46 +02:00
Vinoth Kannan
f71a18facd FIX: Username uniqueness check should not happen to current user_id 2018-04-02 21:59:11 +05:30
Kris
2eec572159 minor alignment fix on new like button 2018-04-02 12:17:50 -04:00
Joffrey JAFFEUX
8f2b305b9a
FIX: calling incorrect method 2018-04-02 18:02:45 +02:00
Arpit Jalan
5e4dd20795 Revert "Prevent robots from indexing uploads" 
This reverts commit 0fd622e5d1.
 2018-04-02 21:29:29 +05:30
Robin Ward
23e97a3c3a UX: Add classes for extensibility 2018-04-02 11:55:25 -04:00
Joffrey JAFFEUX
a828da33aa
FIX: regression preventing addition of multiple tags in a group 2018-04-02 17:54:40 +02:00
Vinoth Kannan
16341219ab Log exception if remote theme importing failed 2018-04-02 20:10:18 +05:30
Guo Xiang Tan
221503cd10 FIX: Add server side uniqueness validations for Group#name and User#username. 
https://meta.discourse.org/t/groups-can-be-given-same-name-as-existing-username/74010
 2018-04-02 18:19:18 +08:00
Guo Xiang Tan
d2a8f40fb0
Merge pull request #5711 from Supermathie/learn_cdn_url_hostname 
FIX: CDN_URL hostname should be in GlobalSetting.hostnames
 2018-04-02 16:39:24 +08:00
Guo Xiang Tan
d4ebbd12a6
Merge pull request #5723 from featheredtoast/topic-list-item-unread-classnames 
Feature: Add unseen-topic and new-posts classnames to topic list items
 2018-04-02 16:35:19 +08:00
Guo Xiang Tan
142571bba0 Remove use of rescue nil. 
* `rescue nil` is a really bad pattern to use in our code base.
  We should rescue errors that we expect the code to throw and
  not rescue everything because we're unsure of what errors the
  code would throw. This would reduce the amount of pain we face
  when debugging why something isn't working as expexted. I've
  been bitten countless of times by errors being swallowed as a
  result during debugging sessions.
 2018-04-02 13:52:51 +08:00
Vinoth Kannan
efb19dbdaf
Merge pull request #5705 from discourse/new_webhooks 
FEATURE: Webhook for group and category events
 2018-04-02 10:53:21 +05:30
Guo Xiang Tan
87e3779085
Merge pull request #5702 from kevinelliott/feature/20180323-fix-mass-assignment 
20180323 Fix Mass Assignment Warning
 2018-04-02 10:19:25 +08:00
Arpit Jalan
82b1dc6934 UX: consistent spacing for like button on mobile 2018-04-01 07:18:07 +05:30
Jeff Wong
03b2590036 Add unseen-topic and new-posts classnames to topic lists 
Adds classname descriptions for new, unread posts, and closed statuses on topic-list-items.

Allows for new/unread/closed topic-list-items to be targeted with css directly.
 2018-03-31 11:57:03 -07:00
Arpit Jalan
cddaad7a55 UX: hide empty 'new' and 'unread' tabs for tl1 and above 2018-03-31 11:42:20 +05:30
Arpit Jalan
9df7fd4f30 FIX: discourse-solved plugin controls (buttons) should be in first place 2018-03-31 07:42:54 +05:30
Arpit Jalan
9815f301cc UX: alignment was off on likes for your own post 2018-03-31 07:21:18 +05:30
Blake Erickson
31ce955487 Add destroy rake task 
Adds several rake tasks to delete users, topics, pm's and site stats so
that you can have a fresh site but maintain site settings and category
structure.
 2018-03-30 18:32:21 -06:00
Kris
4fcbe9128e Minor color/alignment adjustment on like button 2018-03-30 16:46:37 -04:00
Arpit Jalan
4760f0e7a9 UX: better like button 
Co-authored-by: jjaffeux <j.jaffeux@gmail.com>
 2018-03-30 22:45:51 +05:30
Arpit Jalan
67efdaea40 FIX: properly hide nav items 2018-03-30 12:32:29 +05:30
Arpit Jalan
15945bcf15 UX: when there is nothing new or unread to show, remove those options from the top nav. 2018-03-30 11:38:44 +05:30
Arpit Jalan
bf41010ac3 UX: make own post heart glyph grey 2018-03-30 10:35:54 +05:30
Arpit Jalan
fe17ee6924 UX: own post likes glyph margin was off 2018-03-30 10:10:55 +05:30
Arpit Jalan
a55b458e56 UX: show heart glyph on your own likes count 2018-03-30 09:06:57 +05:30
Jeff Atwood
131b19c26b move like count a tad closer to like glyph 2018-03-29 16:36:59 -07:00
Arpit Jalan
629ad48621 UX: better likes count margin 2018-03-30 03:02:56 +05:30
Arpit Jalan
9bf87f3665 UX: remove word "likes" from first post 2018-03-30 02:45:32 +05:30
Robin Ward
22b631510c FIX: Silenced user wasn't being linked properly 2018-03-29 17:07:09 -04:00
Robin Ward
e4298a91b8 Pass silenced_by through to DiscourseEvent 2018-03-29 16:44:18 -04:00
Arpit Jalan
ef07045aca fix the build 2018-03-30 02:09:48 +05:30
Arpit Jalan
6bef0428cc UX: remove the word 'likes' from the like counters on posts within topic 2018-03-30 01:46:00 +05:30
Arpit Jalan
fda8b3d879 UX: updated 'new dot' styling 2018-03-30 01:25:39 +05:30
Neil Lalonde
73c1d3e7fe FIX: tag notification preferences were being cleared when other preferences were changed 2018-03-29 15:08:32 -04:00
Robin Ward
ec6bbe2af0 FIX: Show error if dashboard can't load 2018-03-29 14:12:29 -04:00
Robin Ward
e4a5b0c39a
Merge pull request #5715 from jjaffeux/remove-title-user-notifications 
FIX: remove unneeded and uninformative title on user notifications list
 2018-03-29 09:23:09 -04:00
Joffrey JAFFEUX
99cf091774
FIX: do not lighten color when no selection for cat and tag drops 2018-03-29 15:20:47 +02:00
Joffrey JAFFEUX
3287ac77e0
FIX: reverts combobox placeholder and introduces noneLabel 
noneLabels works almost like none but instead of actually adding a row in the list, it will only change the text displayed in the header, when there's no selection.
 2018-03-29 13:42:00 +02:00
Guo Xiang Tan
125434dcdf Minor style tweak on groups page. 2018-03-29 18:14:17 +08:00
Guo Xiang Tan
52e75eaee9 UX: Tweaks to group pages. 2018-03-29 17:04:48 +08:00
Guo Xiang Tan
27f06505b1 Allow placeholder to be configured for combo-box. 2018-03-29 17:04:48 +08:00
Joffrey JAFFEUX
a64cc9a990
FEATURE: allow users to collapse profile after expanding it 2018-03-29 10:53:57 +02:00
Joffrey JAFFEUX
9260969101
FIX: correctly shows education text for categories 2018-03-29 10:33:44 +02:00
Guo Xiang Tan
3b3e6ed23f Fix deprecation warnings in Ember. 
See https://emberjs.com/deprecations/v2.x/#toc_ember-router-router-renamed-to-ember-router-_routermicrolib
 2018-03-29 10:01:29 +08:00
Guo Xiang Tan
90f91bf017 Fix regression due to ee69d58a59. 2018-03-29 10:01:29 +08:00
Kris
6e569e5bfd X button for mobile edits in composer 2018-03-28 20:47:56 -04:00
Kris
cf3c670cb7 Fixing table top-border alignment issue 2018-03-28 18:49:19 -04:00
Robin Ward
eab64710ff FIX: Shared draft performance fix + missing avatars 2018-03-28 16:11:43 -04:00
Robin Ward
4b5977aa6a Revert "PERF: Don't join on shared drafts unless you have to" 
This reverts commit efedd9745f.
 2018-03-28 15:35:13 -04:00
Robin Ward
efedd9745f PERF: Don't join on shared drafts unless you have to 2018-03-28 13:57:39 -04:00
Régis Hanol
fa608f2bb4 FIX: ensure theme variables are unique when adding an upload 2018-03-28 18:57:11 +02:00
Robin Ward
31d0998506 FIX: Don't allow links with no href 2018-03-28 12:32:16 -04:00
Joffrey JAFFEUX
466f09bbc4 FIX: remove uneeded and uninformative title on user notifications list 2018-03-28 17:05:42 +02:00
Vinoth Kannan
dc33f2d071 Add new web hook serializers 2018-03-28 17:40:29 +05:30
Joffrey JAFFEUX
e5dc8ab5c1
FIX: correctly localizes period chooser row title 2018-03-28 13:19:25 +02:00
Joffrey JAFFEUX
334a611e13
FIX: adds spacing between category name and text in topic timers 2018-03-28 13:08:47 +02:00
Arpit Jalan
70c4630320 FEATURE: show sub navigation for selected PM tag 2018-03-28 13:08:01 +05:30
Guo Xiang Tan
ee69d58a59 FIX: Tests could get stucked in infinite loop if it fails to resolve IP of a hostname. 2018-03-28 14:49:05 +08:00
Arpit Jalan
03725c7c8a FIX: add reserved usernames for ‘/u/’ static routes 2018-03-28 11:15:38 +05:30
Guo Xiang Tan
347e4eadbc Don't retry trying to download a file in test. 2018-03-28 12:54:11 +08:00
Guo Xiang Tan
21ae49ab92 Simplify log in for request specs. 2018-03-28 11:32:47 +08:00
Guo Xiang Tan
70be8124a3 SECURITY: Don't expose development route in production. 2018-03-28 11:32:47 +08:00
Guo Xiang Tan
baa383b7f1 Fix the build. 2018-03-28 09:42:12 +08:00
Guo Xiang Tan
8bc5da57b0 No need to default aria-label to label. 2018-03-28 09:11:50 +08:00
Guo Xiang Tan
08d68e846c UX: Don't default title to label text for buttons. 2018-03-28 09:03:35 +08:00
Neil Lalonde
90c0198a57 FIX: watched word counts always show as 0 2018-03-27 17:27:00 -04:00
Robin Ward
ddefc29c4e FIX: Lint error 2018-03-27 17:19:38 -04:00
Robin Ward
05dc1f65ab UX: Editing a shared draft was confusing in the composer 
Now when you edit a shared draft it looks like creating one, where the
destination category id appears in the dropdown.
 2018-03-27 17:11:21 -04:00
Neil Lalonde
c9216626d8
Merge pull request #5688 from discourse/fix-embed-comments-template-error 
FIX: Make sure a post has replies before accessing the reply_id
 2018-03-27 15:30:53 -04:00
Michael Brown
976d6b290c FIX: CDN_URL hostname should be in GlobalSetting.hostnames 2018-03-27 15:20:22 -04:00
Neil Lalonde
eb714d8ae3 FIX: application request count keys not expiring in redis 2018-03-27 15:12:39 -04:00
Neil Lalonde
2bd44bbf13 WebCrawlerRequest.clear_cache needs to clear user agent list too 2018-03-27 15:11:48 -04:00
Neil Lalonde
7311023a52
Merge pull request #5700 from discourse/crawl-block 
FEATURE: control web crawlers access with white/blacklist
 2018-03-27 15:06:03 -04:00
Neil Lalonde
3fab5267be fix web crawler stats sorted in reverse 2018-03-27 14:10:39 -04:00
Neil Lalonde
df345d80f9 fix wrong case 2018-03-27 13:53:47 -04:00
Neil Lalonde
4d12ff2e8a when writing cache, remove elements from the user agents list. also return a message and content type when blocking a crawler. 2018-03-27 13:44:14 -04:00
Joffrey JAFFEUX
15aa712227
fix category-row regressions 2018-03-27 14:11:05 +02:00
Vinoth Kannan
ff9d7a9bfb FIX: authComplete query param should carry-forward to login page 2018-03-27 17:22:07 +05:30
Arpit Jalan
518f7ba91b FIX: show private message topic count on admin dashboard reports 2018-03-27 17:10:33 +05:30
Guo Xiang Tan
94deb482ae Don't show cancel button on edit page. 2018-03-27 19:31:53 +08:00
Guo Xiang Tan
b06104a1da Missing trust level options on group form. 2018-03-27 19:30:53 +08:00
Guo Xiang Tan
757dd1032d Incorrect save label for group form. 2018-03-27 19:29:00 +08:00
Guo Xiang Tan
f6b6ddd73c REFACTOR: Extract group form into a component. 2018-03-27 19:26:05 +08:00
Joffrey JAFFEUX
f81af74ad8
FIX: makes sure category desc is displayed as row title when possible 2018-03-27 12:25:05 +02:00
Guo Xiang Tan
7edab1c0b9 UX: Add groups/custom/new route for admins to create a new group. 2018-03-27 17:39:05 +08:00
Gerhard Schlager
558914b986 Fix random spec errors 2018-03-27 11:14:06 +02:00
Vinoth Kannan
e7407d0adc FEATURE: Webhook for group and category events 2018-03-27 11:53:35 +05:30
Guo Xiang Tan
68ae009f98 Update group navigation link style. 2018-03-27 13:52:28 +08:00
Guo Xiang Tan
2ecd234e27 UX: Consolidation group manangement into a single tab. 2018-03-27 13:34:46 +08:00
Neil Lalonde
f2c060bdf2 FEATURE: option for tags in a tag group to be visible only to staff 2018-03-26 17:05:09 -04:00
Kris
09b9b56091 adding a class to post activity link 2018-03-26 14:04:42 -04:00
Kris
2aca08b75e Adding data-category-id to category page for mobile 2018-03-26 10:00:43 -04:00
Guo Xiang Tan
dcd1d422d1 UX: Allow admins to set users as owners while adding users. 
https://meta.discourse.org/t/adding-owners-members-ux-is-inconsistent-and-misleading/58084/9
 2018-03-26 17:33:50 +08:00
Guo Xiang Tan
35745166b5 UX: New group membership management workflow. 
https://meta.discourse.org/t/adding-owners-members-ux-is-inconsistent-and-misleading/58084
 2018-03-26 16:15:02 +08:00
Guo Xiang Tan
3d18cd1d9d Raise error when timestamp is invalid when creating topic timers. 
https://meta.discourse.org/t/topic-timer-doesnt-work-for-fa-ir-locale/83702
 2018-03-26 11:33:52 +08:00
Guo Xiang Tan
252e58dfe9 FIX: Could not create topic timers for certain locales. 
https://meta.discourse.org/t/topic-timer-doesnt-work-for-fa-ir-locale/83702/2
 2018-03-26 10:51:49 +08:00
Guo Xiang Tan
2f61780a49 Remove file that is no longer used. 2018-03-26 10:27:28 +08:00
Régis Hanol
9d6d8631ad Revert "FIX: remove scrolling jankiness" 
This reverts commit b1a799b526.
Was not working properly on mobile...
 2018-03-24 03:53:28 +01:00
Régis Hanol
c5c1d8e180 Add support for the '/p/:post_id' route on the client-side 2018-03-24 02:44:39 +01:00
Régis Hanol
3a58dc0858 Add new 'jumpToPostId' plugin API method 2018-03-24 02:43:39 +01:00
Régis Hanol
f56a746d71 Add baseUri to site model 2018-03-24 02:43:19 +01:00
Régis Hanol
b1a799b526 FIX: remove scrolling jankiness 2018-03-24 02:39:36 +01:00
Blake Erickson
9fdf139235 Add tests for Site Settings import/export 
- extracted out site settings rake task to a class
- added tests for import and export of site settings
 2018-03-23 14:55:17 -06:00
Kevin Elliott
fa0868fc3f Explicit param permit and assignment cleanup. 2018-03-23 09:59:31 -07:00
Robin Ward
5f19ad9507 FIX: allow destination categories to be set if not at first 2018-03-23 11:33:02 -04:00
Robin Ward
38af67eb73 Update the destination category id when a user changes it 2018-03-23 11:12:56 -04:00
Kris
6e4b8901ce Removing extra margin on tag-chooser 2018-03-23 10:32:27 -04:00
Sam
62f09af1c2 UX: occasionally getting scrollbar while loading notifications 2018-03-23 18:19:28 +11:00
Guo Xiang Tan
c294798561 Fix alignment of groups filter inputs on FF. 2018-03-23 13:46:02 +08:00
Guo Xiang Tan
3f59ba20ec Align .control-labels with input field. 2018-03-23 13:42:17 +08:00
Guo Xiang Tan
7a4b70ef58 UX cleanup changes to 2FA flow. 2018-03-23 11:05:36 +08:00
Sam
0db13f62eb FIX: unable to remove tags from topics in quick save 2018-03-23 13:55:24 +11:00
Kris
803b53f2e3
Adding space before URL click-counter for improved copy & paste-ability (#5698) 2018-03-22 21:27:08 -04:00
Arpit Jalan
9a184b355d
Merge pull request #5696 from techAPJ/instagram-aspect-image 
UX: wrap instagram images with aspect ratio
 2018-03-23 04:00:52 +05:30
Neil Lalonde
ced7e9a691 FEATURE: control which web crawlers can access using a whitelist or blacklist 2018-03-22 15:41:02 -04:00
Joffrey JAFFEUX
cbbeedf53b
FIX: fires onExpand/onCollapse when using arrows 2018-03-22 18:35:46 +01:00
Joffrey JAFFEUX
841e2ba723
FIX: prevents multiple search call when destroying multiple tags 2018-03-22 18:11:47 +01:00
Joffrey JAFFEUX
037cc63b91
FIX: minor alignments improvements to select-kit 2018-03-22 17:17:28 +01:00
Arpit Jalan
33c1aeb2ac UX: wrap instagram images with aspect ratio 2018-03-22 21:35:10 +05:30
Arpit Jalan
4a6fb242bd UX: correct styling for Instagram onebox 2018-03-22 21:11:47 +05:30
Joffrey JAFFEUX
4f61f5db27
FIX: event is not present here 
TODO: make event accessible everywhere and in a more consitent way.
 2018-03-22 16:17:23 +01:00
Guo Xiang Tan
16c6af2ab0 Focus on input when showing 2FA form in login modal. 2018-03-22 21:45:28 +08:00
Guo Xiang Tan
62ee332efa Fix lint. 2018-03-22 21:12:41 +08:00
Guo Xiang Tan
0a567d0176 UX: Add mobile template for group members page. 2018-03-22 20:59:30 +08:00
Joffrey JAFFEUX
d48542796e
FIX: select-kit refactoring 
- improve mini-tag-chooser keyboard behavior
- all multil select now respond to select all and left/right arrows
- improve events handling
- many minor tweaks
 2018-03-22 11:29:55 +01:00
Jeff Atwood
d7c2d2edb8 remove extraneous "click to show" copy 2018-03-22 02:19:57 -07:00
Guo Xiang Tan
fa95699fde Fix the build. 2018-03-22 14:20:27 +08:00
Arpit Jalan
3a62eba299 bump onebox version 2018-03-22 11:38:01 +05:30
Guo Xiang Tan
f3b402ffd5 UX: Allow users to filter members on group page. 
* Only admins are allowed to filter users by email.
 2018-03-22 14:02:41 +08:00
Guo Xiang Tan
1cc0961566 FEATURE: Allow admin to manage group owners on group page. 2018-03-22 12:33:42 +08:00
Guo Xiang Tan
bfe38b2118 FIX: limit wasn't correctly applied to Upload.migrate_to_new_scheme. 2018-03-22 10:56:06 +08:00
Guo Xiang Tan
ae6be6e364 Fix alignment of filter inputs on groups page. 2018-03-22 09:45:24 +08:00
Guo Xiang Tan
0e973ef219 FIX: Group members dropdown not displaying when switching between groups. 2018-03-22 08:01:37 +08:00
Arpit Jalan
d96c1058a2 FEATURE: add staff action log for 'restore topic' 2018-03-21 18:04:13 +05:30
Guo Xiang Tan
6381bc6ce1 Improve description for removing a group member. 2018-03-21 18:37:13 +08:00
Guo Xiang Tan
be866dbe6e UX: Allow group owners to manage members from group members page. 2018-03-21 18:22:55 +08:00
Guo Xiang Tan
a23509cbf3 UX: Limit the number of group names displayed on user page. 2018-03-21 16:38:33 +08:00
Guo Xiang Tan
dda78f2fd0 UX: Improve layout of groups filter on groups page. 2018-03-21 14:22:34 +08:00
Guo Xiang Tan
9f216ac182 FIX: Infinite loading more on groups page. 2018-03-21 09:25:42 +08:00
Robin Ward
651015fb9b FIX: Linter 2018-03-20 18:07:33 -04:00
Robin Ward
b9abd7dc9e FEATURE: Shared Drafts 
This feature can be enabled by choosing a destination for the
`shared drafts category` site setting.

* Staff members can create shared drafts, choosing a destination
category for the topic when it is published.

* Shared Drafts can be viewed in their category, or above the
topic list for the destination category where it will end up.

* When the shared draft is ready, it can be published to the
appropriate category by clicking a button on the topic view.

* When published, Drafts change their timestamps to the current
time, and any edits to the original post are removed.
 2018-03-20 17:15:26 -04:00
scossar
f213dea529 Make sure a post has replies before accessing the reply id 2018-03-20 12:13:41 -07:00
Arpit Jalan
dcbd9635f4 UX: indicate active tag sorting method 2018-03-21 00:35:16 +05:30
Robin Ward
70c41e067b FIX: Don't apply tags to the plugin outlet in the admin menu pills 2018-03-20 09:54:35 -04:00
Robin Ward
b39fbf7187 A staff member can hide another staff's member's post by flagging 2018-03-20 09:38:23 -04:00
Guo Xiang Tan
d0e7898fa0 Build primary_email association directly in DiscourseSingleSignOn. 2018-03-20 19:36:35 +08:00
Guo Xiang Tan
6771df128e Fix the build. 2018-03-20 18:02:48 +08:00
Guo Xiang Tan
15bcfcd182 UX: Allow users to filter by different group types on groups page. 2018-03-20 17:38:11 +08:00
Guo Xiang Tan
69a53210d3 Improve UserEmail#email validation to use the index. 2018-03-20 10:22:06 +08:00
Kris
42e49f6c7b Trying a trash icon on mobile composer cancel 2018-03-19 16:35:38 -04:00
Neil Lalonde
a9de712eed FIX: not found message when trying to log in with a link, even though the email with the link was successfully sent 2018-03-19 16:08:10 -04:00
Neil Lalonde
4d44024c82 FIX: error when trying to block an IP address. Return a message when IP address matches an existing screened IP address, including ranges. 2018-03-19 14:34:43 -04:00
Neil Lalonde
b9b4d9a8f7 FIX: regression in tag group UI which prevented creating new tags 2018-03-19 10:45:27 -04:00
Guo Xiang Tan
19a93b0e95 UX: Improve groups page on mobile. 2018-03-19 18:48:12 +08:00
Guo Xiang Tan
2b7fb43d84 Fix the build. 2018-03-19 18:47:17 +08:00
Guo Xiang Tan
41b0fbe001 UX: Indicate user's group membership on groups page. 2018-03-19 18:29:30 +08:00
Guo Xiang Tan
05ea034490 UX: Allow groups page to be searchable. 2018-03-19 17:16:51 +08:00
Guo Xiang Tan
0522aabaab UX: Allow user_count on groups page to be sortable. 2018-03-19 16:15:13 +08:00
Arpit Jalan
3e32ab1523 UX: css for Instagram onebox 2018-03-19 13:32:36 +05:30
Guo Xiang Tan
c1bf707e7d PERF: N+1 queries on badges page. 2018-03-19 14:36:09 +08:00
Guo Xiang Tan
9e8d10f711 Fix the build. 2018-03-19 12:34:21 +08:00
Guo Xiang Tan
52b9af10a1 PERF: PG queries for the UserEmail#email column was not using the index. 2018-03-19 11:31:14 +08:00
Arpit Jalan
f053e4cf37
Merge pull request #5682 from techAPJ/allowed-tags-page 
FIX: show only allowed tags on PM tags page and display correct count
 2018-03-17 08:29:00 +05:30
Régis Hanol
89f5c90ce0 FIX: show an error page on click tracking error 2018-03-17 00:33:11 +01:00
Gerhard Schlager
864bdbd9b6 Fix the build 2018-03-16 22:55:42 +01:00
Gerhard Schlager
6c736a1fa4 FIX: Translation overrides for flag types didn't expire cache 2018-03-16 22:10:19 +01:00
Kris
90ab42b9bf Safari uploading progress indicator missing a space 2018-03-16 16:10:01 -04:00
Arpit Jalan
e9bc763440 FIX: show only allowed tags on PM tags page and display correct count 
FIX: tags page should link to user profile we are browsing
 2018-03-17 00:17:48 +05:30
Neil Lalonde
cc16a64ad1 UX: on topic list page for a tag, show the Create Topic button to admins too 2018-03-16 13:43:25 -04:00
Joffrey JAFFEUX
cb49dc6448
FIX: use right caret for collapse state of tag and category drops 2018-03-16 10:52:15 +01:00
Guo Xiang Tan
215d955e30 UX: Add a back link to groups page on group page. 2018-03-16 16:58:42 +08:00
Guo Xiang Tan
7138f6dd69 Fix incorrect condition while re-routing from group messages. 2018-03-16 16:39:02 +08:00
Guo Xiang Tan
19d6b9cb36 Redirect to group members tab if user cannot see messages tab. 2018-03-16 16:30:08 +08:00
Guo Xiang Tan
c85e1fdb50 Revert "PERF: Query for email was not using index." 
This reverts commit 65eb046e69.
 2018-03-16 15:31:39 +08:00
Guo Xiang Tan
65eb046e69 PERF: Query for email was not using index. 2018-03-16 15:19:35 +08:00
Guo Xiang Tan
7e3e09d0ea Fix group messages style on mobile. 2018-03-16 14:56:10 +08:00
Guo Xiang Tan
5fec9a4dfe Fix incorrect CSS class on group messages. 2018-03-16 13:45:03 +08:00
Guo Xiang Tan
fe96ef6ed2 UX: Use topic list for displaying group messages on group page. 
https://meta.discourse.org/t/group-inbox-on-a-groups-page-mockup/71319
 2018-03-16 11:56:40 +08:00
Guo Xiang Tan
937372df02
Merge pull request #5677 from jjaffeux/fix-ruby-warning-keyword 
FIX: prevents ruby warning with circular reference
 2018-03-16 09:31:54 +08:00
Sam
5474635361 add more safety 2018-03-16 11:19:06 +11:00
Joffrey JAFFEUX
d3943b97df
FIX: align suggested messages 2018-03-15 17:51:19 +01:00
Joffrey JAFFEUX
c0a986c181 FIX: prevents ruby warning with circular reference 2018-03-15 15:48:40 +01:00
Sam
c589564f6a FIX: color schemes not updating when remote saves 2018-03-15 18:26:54 +11:00
Sam
ba15273d3f FEATURE: maintain preview theme, while previewing 
This means you can browse around in preview mode without losing the theme.
At any point you can refresh page and maintain the preview theme.
 2018-03-15 16:17:22 +11:00
Rafael dos Santos Silva
2097f5330c FIX: Login redirect path was broken in subfolder installs 2018-03-15 11:49:35 +08:00
Guo Xiang Tan
a35227918f UX: Display group topics in a topic list. 2018-03-15 11:37:55 +08:00
Blake Erickson
d3f5b4e4b0 FIX: envelope link on suggested topics 2018-03-14 16:04:03 -06:00
Neil Lalonde
5ce8177662 FIX: unable to delete user belonging to a group that grants a trust level 2018-03-14 15:12:11 -04:00
Robin Ward
135195363b FIX: Not logging old post contents properly 2018-03-14 15:01:36 -04:00
Robin Ward
d31dfe0e84 FIX: Silencing / Suspending a user should not send a hidden message 2018-03-14 14:39:52 -04:00
Arpit Jalan
b83ba97675 FIX: explicity set username when creating new message via URL 2018-03-14 23:04:18 +05:30
Robin Ward
23e690d0c2 Add extensiblity point for discourse-tooltips 2018-03-14 12:46:32 -04:00
Joffrey JAFFEUX
19177c89e8
remove unused const 2018-03-14 16:37:48 +01:00
Joffrey JAFFEUX
2d0537b593
FIX: correct messages displayed when reseting password 2018-03-14 16:33:09 +01:00
Joffrey JAFFEUX
fd7308e7f6
FIX: share selected tags between tag-chooser in preferences 2018-03-14 16:01:44 +01:00
Joffrey JAFFEUX
3ab58ac881
FEATURE: no category description in category-drop for staff or TL > 0 2018-03-14 11:12:57 +01:00
Joffrey JAFFEUX
d2a7a4916a
FIX: do not show emoji menu when : has a letter before 2018-03-14 10:28:57 +01:00
Arpit Jalan
c5fa452f00 UX: set pmView for PM tags page 2018-03-14 13:37:48 +05:30
Michael Brown
1b5549df58 FIX: my sso_overrides_username assumed username was passed 2018-03-13 18:29:11 -04:00
Kris
16d43e3abc Removing overscroll-y prevention on mobile 2018-03-13 14:40:11 -04:00
Arpit Jalan
b18fec4d5d UX: move Impersonate to the bottom of page 2018-03-14 00:06:40 +05:30
Robin Ward
31a0c4a9be FEATURE: Add quote-modified class if a quote has been modified 2018-03-13 13:41:06 -04:00
Kyle Zhao
f7bd05e534 FEATURE: set 'Retry-After' header for 429 responses (#5659) 2018-03-13 23:12:41 +08:00
Arpit Jalan
7d375690c1
Merge pull request #5667 from techAPJ/pm-tags-page 
FEATURE: replace PM tags dropdown with a dedicated tags page
 2018-03-13 13:08:21 +05:30
Arpit Jalan
24338fbbe8 FEATURE: replace PM tags dropdown with a dedicated tags page 2018-03-13 13:06:58 +05:30
Sam
f11f3f4c5b remove stray console.log 2018-03-13 17:39:53 +11:00
Guo Xiang Tan
1c208ef3f0 FIX: Suspended login error message not showing. 2018-03-13 11:28:59 +08:00
Sam
8c1d145f0e FIX: when visiting post on mobile it is not selected 2018-03-13 14:06:08 +11:00
Kris
64e30d799e UX: Use the full word "cancel" on desktop composer, "X" on mobile. 2018-03-12 22:33:44 -04:00
Guo Xiang Tan
d5c828213f FIX: Circular references warning in TopicTrackingState. 2018-03-13 08:35:15 +08:00
Neil Lalonde
ab2f3e43eb FIX: excerpts in summary email are too short when there are images or links 2018-03-12 18:12:09 -04:00
Varun A
5f133e20f2 FEATURE - Prevent unnecessary refreshes with overscroll-behavior-y (#5662) 2018-03-12 13:59:19 -04:00
Robin Ward
65ac80b014 FEATURE: Log Staff edits in Staff Action Logs 
Why? Some edits by staff are not tracked. For example, during the grace
period, or via the flags/silence dialog.

If a staff member is editing someone else's post, it now goes into the
Staff Action Logs so it can be audited by other staff members.
 2018-03-12 13:51:40 -04:00
Arpit Jalan
82143a421c FIX: max topic invitations per day should apply on PM invites as well 
FIX: do not apply `max topic invitations per day` on email invites
 2018-03-12 23:17:58 +05:30
Kris
2cb6fcb3d6 Lighter cancel button in composer 2018-03-12 09:34:11 -04:00
Gerhard Schlager
243ee565dc Reset widget decorators after each test 2018-03-12 14:22:50 +01:00
Sam
758b9a7dda FEATURE: prototype of local theme directory watcher 
(note this will be documented a bit late)
 2018-03-12 18:36:06 +11:00
Guo Xiang Tan
74ce2220a7 Make rubocop happy. 2018-03-12 09:48:41 +08:00
Leo McArdle
89f41f8236 FIX: error when group_in_subject enabled but no group in pm 2018-03-11 12:22:11 +00:00
Arpit Jalan
12706c4b29 FEATURE: support markdown rendering for embedded posts 2018-03-11 08:00:48 +05:30
Kris
257950e8bd UX: Replace composer cancel and upload with icons 2018-03-09 22:29:42 -05:00
Jeff Atwood
9522469f6a
Merge pull request #5664 from dbnicholson/robots-no-uploads 
Prevent robots from indexing uploads
 2018-03-09 13:33:34 -08:00
Michael Brown
3c3d205180 FIX: sso_overrides_username may inappropriately change the username if the case changed 2018-03-09 16:06:55 -05:00
Kris
0f07999c11 FIX: Safari flexbox bug in header dropdowns 2018-03-09 15:58:53 -05:00
Arpit Jalan
aac7796124 FIX: do not show tags with 0 count on /tags page 2018-03-09 20:57:31 +05:30
Dan Nicholson
0fd622e5d1 Prevent robots from indexing uploads 
Although most user uploads are probably harmless, it's possible someone
has (either maliciously or not) uploaded sensitive information. Prevent
robots from indexing the uploads route.
 2018-03-09 05:51:55 -06:00
Gerhard Schlager
dc77cce8d9 FIX: Create notifications for mentions in PMs 2018-03-09 11:04:29 +01:00
Guo Xiang Tan
0e1b896821 Explicitly assign primary_email record when creating a user 
* This looks like we're doing the same thing but
  we're debugging a race condition where a user
  can be created without an email record. Therefore,
  we prefer the more obvious method of assigning an
  association.
 2018-03-09 15:59:46 +08:00
Sam
7c0e6b820e move key so it does not interfere with other errors 2018-03-09 16:42:11 +11:00
Sam
39e679d3cb FEATURE: allow themes to live in private git repos 
This feature allows themes sourced from git to live on private
servers, it automatically generates key pairs.
 2018-03-09 16:14:38 +11:00
Neil Lalonde
34a0e79bec FIX: use digest_min_excerpt_length site setting in summary emails 2018-03-08 23:35:10 -05:00
Guo Xiang Tan
a89f3160a5 Add new config to ensure backup/restore connects to PG directly. 
* In `pg_dump` 10.3+ and 9.5.12+, in
  it does a `SELECT pg_catalog.set_config('search_path', '', false)`
  which changes the state of the current connection. This is known
  to be problematic with Pgbouncer which reuses connections. As such,
  we'll always try to connect directly to PG directly during
  the backup/restore process.
 2018-03-09 10:28:03 +08:00
Sam
9a4a7422f5 FIX: not loading more messages when username has a . 2018-03-09 11:01:46 +11:00
Sam
5ff857d770 remove theme yaml from UI, it only causes troubles 2018-03-09 11:01:46 +11:00
Robin Ward
6385c7fcb3 UX: Don't let topic progress widget dangle when preview is disabled 2018-03-08 16:34:19 -05:00
Arpit Jalan
4ad3a258d1 FIX: tag filter was not selected on page load 2018-03-08 20:09:31 +05:30
Arpit Jalan
4b23634092 FIX: converting topic to message for a second time was broken 2018-03-08 17:59:04 +05:30
Arpit Jalan
0c2be8b775
Merge pull request #5655 from techAPJ/pm-tags-dropdown 
FEATURE: filter personal messages by tags
 2018-03-08 16:30:38 +05:30
Arpit Jalan
a8149f8969 FIX: user should not be able to invite to PM if trust level requirment not met 
FIX: when personal messages are disabled let user invite to a public topic
 2018-03-08 14:59:04 +05:30
Arpit Jalan
c29660c8f1 FEATURE: filter personal messages by tags 2018-03-08 14:42:07 +05:30
Sam
86c00ac6ad stop using deprecated size() 2018-03-08 15:26:29 +11:00
Simon Cossar
88fdc926d1 Move external_id from UserSerializer to CurrentUserSerializer (#5658) 2018-03-07 22:54:31 -05:00
Sam
7a831857fc remove deprecated method 2018-03-08 14:53:09 +11:00
Neil Lalonde
873feb7b7c
Merge pull request #5654 from tshenry/user-profile-avatar-flair-plugin-outlet 
FEATURE: Add user-profile-avatar-flair plugin outlet
 2018-03-07 17:04:20 -05:00
Régis Hanol
b5b5b68972 Add proper error message when SCSS variable name is invalid when uploading a theme file 2018-03-07 21:37:22 +01:00
Neil Lalonde
1093dacc03 FIX: bulk importers need to create category description topics 2018-03-07 12:10:22 -05:00
Joffrey JAFFEUX
90a1b48503
FIX: correctly allow tag creation if this.site.get("can_create_tag") 2018-03-07 16:06:56 +01:00
Taylor Henry
8c0369e86f FEATURE: Add user-profile-avatar-flair plugin outlet 
Adds a plugin outlet in the user profile for avatar flair.
 2018-03-07 02:38:08 -08:00
Guo Xiang Tan
e7cc2e6d33 FIX: loadBefore should include current params as well. 2018-03-07 16:57:06 +08:00
Guo Xiang Tan
c6cb7f6693 UX: Add title to user messages page. 2018-03-07 15:24:11 +08:00
Guo Xiang Tan
3045c589f6 FIX: Publish live messages to both team inbox and archive on update. 2018-03-07 14:01:20 +08:00
Guo Xiang Tan
5169be6080 FIX: User archiving message should also publish to sent section. 2018-03-07 11:39:23 +08:00
Guo Xiang Tan
bef35f7be5 FIX: User archive messages should only publish to the user. 2018-03-07 11:28:29 +08:00
Guo Xiang Tan
82619c2445 FIX: Missing messages incoming indicator for mobile. 2018-03-07 10:27:18 +08:00
Neil Lalonde
2e5c18d130
Merge pull request #5652 from majakomel/add-slovenian-locale 
Add Slovenian locale files
 2018-03-06 15:59:01 -05:00
Joffrey JAFFEUX
187fdb9799
FIX: do not show read-only cursor on mini-tag-chooser (#5653) 2018-03-06 21:21:24 +01:00
Maja Komel
e2a441ade9 Add Slovenian translations 2018-03-06 20:51:41 +01:00
Robin Ward
81780d8607 Merge remote-tracking branch 'origin/analyze-code-fix' 2018-03-06 13:16:37 -05:00
Gerhard Schlager
07649cd42d FIX: email_domains_whitelist prevented creation of anonymous users 2018-03-06 18:14:53 +01:00
Robin Ward
c74d10cf34 FIX: Consider live links in <code> as links when counting 2018-03-06 11:46:12 -05:00
Guo Xiang Tan
8f5349eaa1 FIX: Only unsubscribe channel if it was subscribed. 2018-03-06 21:39:30 +08:00
Guo Xiang Tan
e09a4a353e FIX: Incorrectly deleting channel preventing us from unsubscribing MB. 2018-03-06 19:52:00 +08:00
Guo Xiang Tan
1365bab0d7 FEATURE: Live updates for user's messages page. 
https://meta.discourse.org/t/group-inbox-messages-not-updated-for-new-posts/38189
 2018-03-06 18:15:21 +08:00
Guo Xiang Tan
13764b31ec Remove unnecessary attribute in topic tracking payload. 2018-03-06 17:37:53 +08:00
Guo Xiang Tan
d576056cff REFACTOR: Add basic tests for TopicTrackingState#publish_*. 
* Ensure we don't publish events for PMs.
 2018-03-06 17:37:53 +08:00
Guo Xiang Tan
821f3d0c15 REFACTOR: Remove code duplication. 2018-03-06 17:37:53 +08:00
Sam
0134e41286 FEATURE: detect when client thinks user is logged on but is not 
This cleans up an error condition where UI thinks a user is logged on
but the user is not. If this happens user will be prompted to refresh.
 2018-03-06 16:49:31 +11:00
Sam
f0d5f83424 FEATURE: limit assets less that non asset paths 
By default assets can be requested up to 200 times per 10 seconds
from the app, this includes CSS and avatars
 2018-03-06 15:20:39 +11:00
Gerhard Schlager
8e48b339fa Drop unused tables (#5630) 2018-03-05 17:27:30 -05:00
OsamaSayegh
adc46ac56c UX: Improvements for theme UI (#5650) 
* Don't display "Settings: YAML" in Custom CSS/HTML section

* Don't show the settings tab for remote/imported themes
 2018-03-05 17:26:50 -05:00
Robin Ward
0f66a99eb2 Setting to prevent logging details when anonymizing 2018-03-05 14:38:18 -05:00
Arpit Jalan
003b03d939 allow staff to delete user if posts are 5 or less irrespective of delete_user_max_post_age 2018-03-05 23:31:29 +05:30
Kris
62d1ba4fdb Menu fix for iOS 2018-03-05 11:32:43 -05:00
Joffrey JAFFEUX
057fa049e6
FIX: display keyboard on mobile when focusing mini-tag-chooser 2018-03-05 10:55:20 +01:00
Guo Xiang Tan
2f65393706 REFACTOR: Use Topic#private_message? to reduce duplication. 2018-03-05 15:39:22 +08:00
Guo Xiang Tan
07f1d90b88 FIX: Inviting a group that I am part of creates a notification. 
https://meta.discourse.org/t/inviting-a-group-to-a-message-does-not-trigger-a-notification-mail/50509/10?u=tgxworld
 2018-03-05 13:51:32 +08:00
Guo Xiang Tan
42e0aaed61 FIX: Set first visit PM notification level to group default notification level. 
https://meta.discourse.org/t/notifications-not-received-for-private-messages-im-invited-to/71577/21?u=tgxworld
 2018-03-05 13:39:00 +08:00
Sam
9331b4849d FEATURE: we need access to settings in theme js 2018-03-05 15:35:41 +11:00
Sam
95555b5ec8 If there are no settings do now show section 2018-03-05 11:11:21 +11:00
Sam
2c25b9ae12 annotate 2018-03-05 11:06:45 +11:00
OsamaSayegh
282f53f0cd FEATURE: Theme settings (2) (#5611) 
Allows theme authors to specify custom theme settings for the theme. 

Centralizes the theme/site settings into a single construct
 2018-03-04 19:04:23 -05:00
Arpit Jalan
322618fc34 FIX: capital bbcode tags were broken 2018-03-04 22:10:54 +05:30
Joffrey JAFFEUX
a15b2fdeca
FIX: make it possible to edit tags on topics on mobile 2018-03-04 13:47:25 +01:00
Robin Ward
13eda41ff5 Fix lint errors 2018-03-03 14:34:19 -05:00
Robin Ward
31e3bf6d8d FEATURE: New "Categories and Top" homepage style 
Select this option if you want to show top topics on the homepage
instead of latest topics.
 2018-03-03 14:26:57 -05:00
Joffrey JAFFEUX
5e323139ae
FIX: makes sure we recompute shouldDisplayCreateRow after request 2018-03-03 11:42:44 +01:00
Kris
6d359ca823 Z-index fix for hidden posts 2018-03-02 22:41:10 -05:00
Robin Ward
b11dd21356 FIX: Translate the hover text or emoji categories 2018-03-02 18:28:06 -05:00
Kris
c684843c53 Improving title selection on badge pages 2018-03-02 16:15:58 -05:00
Neil Lalonde
dda248f5df FIX: tag input in composer was not respecting tag group rules 2018-03-02 15:56:24 -05:00
Kris
efb0bf6b16 Categories in hamburger menu were misaligned in Firefox 2018-03-02 15:04:55 -05:00
Kris
5e11bc79ff Fixing some regressions for profile badges 2018-03-02 14:43:54 -05:00
Kris
70acfa47d7 FIX: In some instances expanding hamburger menu broke layout in iOS 2018-03-02 14:13:43 -05:00
Kris
0783f8b9e6 Fixing badge detail positioning 2018-03-02 13:21:36 -05:00
Robin Ward
730201d423 New interface to upsert custom fields 2018-03-02 12:45:52 -05:00
Kris
0ec1dc9237 UX: Improving badge page layout 2018-03-02 12:43:01 -05:00
Neil Lalonde
5833d00739 SECURITY: sanitize topic title when staff is viewing a user's past flagged posts and deleted topics 2018-03-02 11:58:11 -05:00
Arpit Jalan
334ed74346
Merge pull request #5635 from techAPJ/invite-muted 
FIX: do not allow invite notifications from muted user/topic
 2018-03-02 18:10:17 +04:00
Guo Xiang Tan
6b59a2827d Add more information to SSO user creation logging. 2018-03-02 18:27:15 +08:00
Joffrey JAFFEUX
6d4ff05cf0
FIX: makes sure [999500..999999] is correctly shown as 999k 2018-03-02 11:00:48 +01:00
Guo Xiang Tan
642c60c310 Rename variable so that it is clearer which variable is being referred. 2018-03-02 16:41:02 +08:00
Arpit Jalan
2e202495a3 FIX: do not allow invite notifications from muted user/topic 2018-03-02 12:24:51 +05:30
Guo Xiang Tan
d9b4b12694 UX: Display warning message about social logins disabled when 2FA is enabled. 2018-03-02 14:22:52 +08:00
Guo Xiang Tan
50eb582fb2 Remove cas oauth login method that is no longer used. 2018-03-02 14:22:52 +08:00
Sam
d39d2b9352 FEATURE: whitelist data for themes 2018-03-02 14:52:09 +11:00
Guo Xiang Tan
939180efa8 FIX: Missing 2FA guards when sso is enabled or when local login is disabled. 2018-03-02 10:39:10 +08:00
Sam
e19ae6c55e FEATURE: disallow groups from being indexed 2018-03-02 13:38:30 +11:00
Sam
185507d072 UX: remove fast scroll which is leading to bugs 2018-03-02 12:58:38 +11:00
Sam
75172024ca SECURITY: ensure users have permission when moving categories 2018-03-02 12:13:27 +11:00
Régis Hanol
25d80aabce remove 'puts' 2018-03-02 01:50:24 +01:00
Gerhard Schlager
80e85e0d8f FIX: Sidekiq job has wrong data when post owner changes within transaction 2018-03-01 18:00:18 +01:00
Gerhard Schlager
79590e4bec FIX: Merging users shouldn't add more than 1 secondary email 2018-03-01 17:50:13 +01:00
Gerhard Schlager
a7c50039de FIX: Allow changing post owner even when topic validations fail 2018-03-01 17:31:58 +01:00
Gerhard Schlager
7a2183e8ab FEATURE: rake task for merging users 2018-03-01 12:28:12 +01:00
Gerhard Schlager
fffd1a6602 FIX: Associated Instagram account was missing at some places 2018-03-01 12:26:40 +01:00
Joffrey JAFFEUX
7ae1c5a663
FIX: emoji search was not finding aliases 2018-03-01 12:11:52 +01:00
Joffrey JAFFEUX
c9cb6920dc
FIX: category drop header padding when using category box style 2018-03-01 11:59:13 +01:00
Joffrey JAFFEUX
460c905dc6
FIX: improves positioning of select-kit body 2018-03-01 11:53:14 +01:00
Guo Xiang Tan
674239718c UX: Hide social login buttons when requesting for 2FA token. 2018-03-01 15:52:09 +08:00
Guo Xiang Tan
fb75f188ba FEATURE: Disallow login via omniauth when user has 2FA enabled. 2018-03-01 15:47:07 +08:00
Guo Xiang Tan
947b6fdf46 FIX: Incorrect rate limit applied to topics invitation flow. 2018-03-01 12:50:00 +08:00
Guo Xiang Tan
5a462b930d REFACTOR: Prefer exists? over present. 2018-03-01 10:22:41 +08:00
Kris
4b17b39e73 Remove unnedded padding 2018-02-28 15:07:08 -05:00
Kris
f375731278 About page layout improvements 2018-02-28 15:03:12 -05:00
Robin Ward
b283bb2ba7 FIX: Don't include unlisted topic in groups/posts 2018-02-28 14:40:18 -05:00
Kris
6c50ef9b5d font-sizes on body-pages were too large due to nesting 2018-02-28 13:23:43 -05:00
Guo Xiang Tan
e7a7356986 Remove ancient votes code that is no longer used. 2018-02-28 14:37:22 +08:00
Neil Lalonde
764b6c005c FIX: don't show Other Tags on /tags if there aren't any to show 2018-02-27 22:30:46 -05:00
Guo Xiang Tan
902c5d11cf FIX: Don't allow other flag actions after notify_moderator has happened. 
https://meta.discourse.org/t/receiving-sorry-an-error-has-occurred-during-flagging-step-of-discobot-tutorial/77233/5
 2018-02-28 11:27:56 +08:00
scossar
51544047dc Add external_id to User Serializer 2018-02-28 10:13:27 +08:00
Kris
b832c3d885 Glyph wasn't wrapping properly with long categories 2018-02-27 17:10:02 -05:00
Kris
be63b08c36 Truncate long category names in subcategory boxes 2018-02-27 16:48:20 -05:00
Joffrey JAFFEUX
8ca1b1ab0b
FIX: load tag_groups and not tags 2018-02-27 21:10:57 +01:00
Kris
e32691a3e9 Simplifying category overflow on category pages 2018-02-27 13:11:22 -05:00
Joffrey JAFFEUX
9b680fc45c
FIX: prevents create row to be displayed if term is in displayed list 2018-02-27 18:31:58 +01:00
Joffrey JAFFEUX
ba2f01c0bd
FIX: prevents selected value from hiding one item of the list 2018-02-27 18:31:51 +01:00
Kris
96b4617094 Fixing category title with logo image layout 2018-02-27 10:47:05 -05:00
Gerhard Schlager
c22e56499a FIX: Allow changing post owner even when validations fail 2018-02-27 15:46:20 +01:00
Arpit Jalan
4010d8d9f9 FEATURE: show "edit message" button on message footer for staff 
Show "Edit Message" button on personal message footer for staff if PM tagging is enabled.
 2018-02-27 14:22:03 +05:30
Joffrey JAFFEUX
410b90dde0
FIX: mini-tag-chooser was not returning a correct list of tags 
Should also fix an issue where it validates the creation of an existing tag.
 2018-02-27 08:47:44 +01:00
Guo Xiang Tan
486bbe9cc2 FIX: Auto re-opened topics should restore category auto close settings. 
https://meta.discourse.org/t/topic-closed-temporarily-due-to-community-flags-overwrites-category-auto-close-timer/77421
 2018-02-27 15:33:31 +08:00
Joffrey JAFFEUX
83e8ab5274
FIX: header icon out of bounds in tag-drop on some browsers 2018-02-27 08:33:06 +01:00
Guo Xiang Tan
519026a31f Trim attributes that are not useful from WebHookTopicViewSerializer. 2018-02-27 11:28:31 +08:00
Guo Xiang Tan
66d620f7b1 FEATURE: Trigger topic webhook when topic status is updated. 2018-02-27 11:07:37 +08:00
Guo Xiang Tan
104df3126b UX: Incorrect width for webhook events. Take 2. 2018-02-27 10:34:46 +08:00
Guo Xiang Tan
8d16ca2af2 UX: Incorrect width for webhook events. 2018-02-27 10:32:11 +08:00
Guo Xiang Tan
24f3b78548 Fix incorrect ids for 2FA inputs. 2018-02-27 10:12:22 +08:00
Guo Xiang Tan
70f14da732 UX: Use 'tel' input type for 2FA token inputs. 2018-02-27 09:30:44 +08:00
Robin Ward
8296f493ed add class to easier targetting 2018-02-26 19:03:21 -05:00
Robin Ward
c7a37f391a New event when a flag is handled 2018-02-26 18:51:51 -05:00
Kris
382dbfbb8a Fix for categories with icons not wrapping properly 2018-02-26 17:00:03 -05:00
Neil Lalonde
8f27456acb UX: Move 'show words' checkbox close to the words in the Watched Words UI 2018-02-26 16:35:52 -05:00
Kris
436d2b57c9 Fixing categories not wrapping properly 2018-02-26 16:33:24 -05:00
Neil Lalonde
3313072957 Remove censored_pattern site setting, which is replaced by watched words 2018-02-26 16:29:27 -05:00
Gerhard Schlager
5ca5817902 FIX: Only likes should change the given daily likes 2018-02-26 22:27:18 +01:00
Kris
e2a524550c Prevent long category names from breaking topic/category list layouts 2018-02-26 14:21:28 -05:00
Robin Ward
f8856f3d7a FIX: Anonymous users shouldn't see the link to new in the footer 2018-02-26 13:46:50 -05:00
Joffrey JAFFEUX
ac701696b3
FEATURE: replaces tag-chooser/tag-group-chooser with select-kit component 
These component were also the last using select2. As a consequence select2 is removed from Discourse in this commit.
 2018-02-26 11:42:57 +01:00
Guo Xiang Tan
a9699da672 UX: Specify pattern and maxlength for 2FA input fields. 2018-02-26 18:29:46 +08:00
Guo Xiang Tan
c1f53e1ece UX: Invited users should watch PM topic once topic has been visited. 
https://meta.discourse.org/t/notifications-not-received-for-private-messages-im-invited-to/71577/11
 2018-02-26 17:58:58 +08:00
Guo Xiang Tan
982e5bae3a Update annotations. 2018-02-26 15:32:04 +08:00
Guo Xiang Tan
6a88f7db61 Notification created for wrong user after invite. 
Introduced in c64f09b6b7
 2018-02-26 13:21:19 +08:00
Guo Xiang Tan
31242335a6 Revert "Fix the build." 
This reverts commit 07f928e05e.
 2018-02-26 13:08:10 +08:00
Guo Xiang Tan
07f928e05e Fix the build. 2018-02-26 12:42:55 +08:00
Guo Xiang Tan
c64f09b6b7 REFACTOR: Simplify and DRY Group#invite. 2018-02-26 11:59:07 +08:00
Guo Xiang Tan
3e1afbedc5 FIX: Missing translation for non-admin when editing a group. 
https://meta.discourse.org/t/text-glitch-on-group-admin-page/77303
 2018-02-26 10:11:18 +08:00
Guo Xiang Tan
616d210911
Merge pull request #5614 from nbianca/fix_period 
Try extracting time period only when the filter is 'top'.
 2018-02-26 09:38:33 +08:00
Régis Hanol
0559a4736a FIX: don't double request when downloading a file 2018-02-24 12:35:57 +01:00
Kris
b731d5d9b5 Removing unneeded and duplicate styles 2018-02-23 21:43:05 -05:00
Kris
bd892199e7 Increasing topic-admin menu width to prevent wrapping on mobile 2018-02-23 13:51:06 -05:00
Kris
de30f3515b Updating modal headers to flexbox for better alignment 2018-02-23 13:14:32 -05:00
Kris
d001183828 Prevent timestamp modal calendar from overflowing container 2018-02-23 11:44:49 -05:00
Vinoth Kannan
43f0884660 PERF: Remove N+1 queries on topic list page. 2018-02-23 20:05:51 +05:30
Arpit Jalan
709f201bd4 FIX: update group user count when bulk adding users 2018-02-23 14:29:56 +05:30
Guo Xiang Tan
4791b39773 UX: Add reset password email button when confirming password before enabling 2FA. 2018-02-23 15:37:17 +08:00
Sam
a94dc0c731 Revert "FIX: preview theme not working consistently" 
This reverts commit 845cec3ba0.
was not a needed change, but was elsewhere
 2018-02-23 17:59:00 +11:00
Sam
6f076963f2 FIX: incorrect caching of theme keys 2018-02-23 17:58:13 +11:00
Guo Xiang Tan
4250ab522a UX: Don't show admin 2FA edit icon on profile of other users. 2018-02-23 13:51:02 +08:00
Sam
845cec3ba0 FIX: preview theme not working consistently 
Avoid flash, this makes debugging much simpler as well.

Additionally URL now clearly shows you are previewing a theme.
 2018-02-23 15:25:35 +11:00
Guo Xiang Tan
1f74509a75 FIX: 2FA prompt incorrectly displayed on admin login page. 2018-02-23 11:05:39 +08:00
Guo Xiang Tan
e137b7f836 UX: Improve indication of 2FA status in user's preferences. 2018-02-23 10:36:48 +08:00
Guo Xiang Tan
5e60f6b533 UX: Don't disable submit button before transitioning in 2FA flow. 2018-02-23 10:36:48 +08:00
Guo Xiang Tan
2e2da3a6e2 Update copy for 2FA. 2018-02-23 10:36:48 +08:00
Robin Ward
ee9be65b2c FIX: Show names when available 2018-02-22 20:06:53 -05:00
Guo Xiang Tan
9f5bc7a5ee
Merge pull request #5605 from nbianca/favorites 
Added the required hooks for discourse-favorites plugin.
 2018-02-23 07:12:09 +08:00
Guo Xiang Tan
18c1d1565c UX: Fix missing css styles on invite modal. 2018-02-23 07:08:19 +08:00
Guo Xiang Tan
dd26bbe868
Merge pull request #5610 from discourse/pm-tags 
FEATURE: Allow staffs to tag PMs
 2018-02-23 07:07:41 +08:00
Bianca Nenciu
184d521fc9 Added the required hooks for discourse-favorites plugin. 2018-02-22 23:58:53 +02:00
Bianca Nenciu
0e3e5f25a6 Try extracting time period only when the filter is 'top'. 2018-02-22 23:56:37 +02:00
Régis Hanol
0210a7f2bf FIX: social login buttons were not working 2018-02-22 18:06:28 +01:00
Vinoth Kannan
7cbda949f1 REFACTOR: New spec tests and code improvement 2018-02-22 20:27:02 +05:30
Guo Xiang Tan
862e83287e
Merge pull request #5575 from featheredtoast/tab-index-composer-actions 
tab index composer actions
 2018-02-22 15:16:41 +08:00
Maja Komel
76a2fc3d07 UX: Add og metadata for groups. 
https://meta.discourse.org/t/onebox-for-groups/79155
 2018-02-22 15:03:41 +08:00
Guo Xiang Tan
7bcc0c1da9 FIX: Login buttons not working on sign up modal. 2018-02-22 14:01:07 +08:00
Guo Xiang Tan
ae2d7ba857 Partially revert d170c8fccc to bring back 3df0626aa5. 2018-02-22 13:42:04 +08:00
Arpit Jalan
d170c8fccc Revert 'Accessibility: focus management in topics' 
reverts:

- 3df0626aa5
- 3212cdda78
- 59b7760e2e
- bfc1301823
 2018-02-22 10:32:37 +05:30
Kane York
bfc1301823 UX: Remove default focus styling from posts & topic list items 
The styling is superseded by the .selected management
 2018-02-22 12:21:23 +08:00
Kane York
59b7760e2e UX: Make the .selected class follow focus 2018-02-22 12:20:47 +08:00
Kane York
3212cdda78 UX: Use focus as the first selector for J/K navigation 2018-02-22 11:55:36 +08:00
Kane York
3df0626aa5 UX: Apply hover styling to post actions on focus 2018-02-22 11:55:36 +08:00