Commit Graph

793 Commits

Author SHA1 Message Date
Sam
9c16dee843 Merge pull request #2742 from riking/patch-1
UX: Change Impersonate to btn-danger
2014-09-03 22:18:19 +10:00
Sam
d4f08f442c FIX: correct template for search in post (regression) 2014-09-03 17:09:01 +10:00
riking
8979020b9d Clean up unused translations 2014-09-02 15:40:23 -07:00
Sam
e0c8abc911 Merge pull request #2717 from riking/badge-solid
Admin badge interface improvements
2014-09-02 08:21:06 +10:00
Sam
202656a679 Merge pull request #2725 from cpradio/german-keyboard-support
FIX: Support J/K bindings on German Keyboards
2014-09-02 08:02:10 +10:00
Jeff Atwood
7ef056810c minor copy update 2014-08-31 23:32:41 -07:00
cpradio
6234284243 FIX: Remove the old keyboard bindings for next/prev section, update client.en.yml to reflect the new bindings 2014-08-31 21:42:03 -04:00
riking
1833b43ae2 FEATURE: Badge query validation, preview results, and EXPLAIN
Upon saving a badge or requesting a badge result preview,
BadgeGranter.contract_checks! will examine the provided badge SQL for
some contractual obligations - namely, the returned columns and use of
trigger parameters.

Saving the badge is wrapped in a transaction to make this easier, by
raising ActiveRecord::Rollback on a detected violation.

On the client, a modal view is added for the badge query sample run
results, named admin-badge-preview.
The preview action is moved up to the route.
The save action, on failure, triggers a 'saveError' action (also in the
route).

The preview action gains a new parameter, 'explain', which will give the
output of an EXPLAIN query for the badge sql, which can be used by forum
admins to estimate the cost of their badge queries.
The preview link is replaced by two links, one which omits (false) and
includes (true) the EXPLAIN query.

The Badge.save() method is amended to propogate errors.

Badge::Trigger gets some utility methods for use in the
BadgeGranter.contract_checks! method.

Additionally, extra checks outside of BadgeGranter.contract_checks! are
added in the preview() method, to cover cases of null granted_at
columns.

An uninitialized variable path is removed in the backfill() method.

TODO - it would be nice to be able to get the actual names of all
columns the provided query returns, so we could give more errors
2014-08-31 11:25:44 -07:00
Jeff Atwood
9aac004c0a minor copy update, Omit Needless Words 2014-08-31 04:47:27 -07:00
Jeff Atwood
6221a84ce8 minor copy updates 2014-08-31 04:46:20 -07:00
Arpit Jalan
82d4c29c88 TRIVIAL: add line break before time for post navigator 2014-08-30 16:14:00 +05:30
Arpit Jalan
289d9e4fe1 FIX: use short date format for topic summary 2014-08-30 12:07:43 +05:30
Jeff Atwood
7a50ba600a Merge pull request #2726 from techAPJ/patch-4
FIX: use short date format for post navigator
2014-08-29 23:11:31 -07:00
Arpit Jalan
3c005557e6 FIX: use short date format for post navigator 2014-08-30 11:34:33 +05:30
Jeff Atwood
70dbad16dc UX: simplify copy for summarize topic mode 2014-08-29 22:59:39 -07:00
cpradio
2e200ffbf0 Merge remote-tracking branch 'origin/master' into keyboard-binding-incoming-updated-topics
Conflicts:
	config/locales/client.en.yml
2014-08-29 20:05:59 -04:00
cpradio
875b39fb5f Merge remote-tracking branch 'origin/master' into keyboard-binding-incoming-updated-topics 2014-08-29 19:56:39 -04:00
Jeff Atwood
cb45d5fa25 Merge pull request #2724 from cpradio/key-binding-reply-new-topic
UX: Add keyboard binding for reply as new topic
2014-08-29 16:46:34 -07:00
Jeff Atwood
d74f94afa1 Merge pull request #2722 from cpradio/dismiss-keyboard-bindings
UX: Add key-bindings for Dismiss New, Dismiss Posts, and Dismiss Topics
2014-08-29 16:28:25 -07:00
cpradio
68e807f791 UX: Add keyboard binding for reply as new topic 2014-08-29 19:14:42 -04:00
Jeff Atwood
0eb367f9c3 UX: rename "Leader" to "Veteran" (first steps) 2014-08-29 15:57:13 -07:00
Jeff Atwood
72293073f6 UX: better copy on mailing_list_mode pref 2014-08-29 13:07:36 -07:00
cpradio
5ca96e741d UX: Add keyboard bidning for incoming/updated topics 2014-08-29 09:44:26 -04:00
cpradio
096bc0c0ae Merge branch 'keyboard-binding-new-topics-banner' into dismiss-keyboard-bindings
Conflicts:
	app/assets/javascripts/discourse/lib/keyboard_shortcuts.js
2014-08-29 09:36:34 -04:00
cpradio
3f085c3fd3 Change the Dismiss keybindings to use 'x' instead of 'd' 2014-08-29 09:22:47 -04:00
cpradio
ede9d1e057 Change the Dismiss keybindings to use 'x' instead of 'd' 2014-08-29 08:46:35 -04:00
cpradio
e4ce995369 FIX: Changed Dismiss New and Dismiss Posts to use d + r because p is reserved for the profile menu and n is reserved for the notifications menu 2014-08-29 08:11:23 -04:00
cpradio
ed8d828ff1 FIX: Added keyboard bindings for dismiss buttons 2014-08-29 08:04:57 -04:00
Arpit Jalan
3a76f9e79f FIX: allow localization in timestamp 2014-08-27 20:57:06 +05:30
Jeff Atwood
fa10aa4945 COPY: add quotes around badge for clarity 2014-08-26 23:54:13 -07:00
Jeff Atwood
d50b34b825 "earned" vs "you were granted" 2014-08-26 23:46:48 -07:00
cpradio
1678a91a60 Add shortcuts for Profile Menu and Hamburger Menu
Added shortcuts of p and = for the profile and hamburger menu
https://meta.discourse.org/t/keyboard-shortcuts-wish-list/15952
2014-08-26 20:30:20 -04:00
Robin Ward
105959c402 Merge pull request #2696 from riking/errors
Fix "Server Error: [missing {{code}} value]" page
2014-08-26 11:14:57 -04:00
Jeff Atwood
d63c6292b3 change "Visit Profile" to just "Profile" 2014-08-26 00:37:10 -07:00
riking
5261f2e751 Fix "Server Error: [missing {{code}} value]" page
The translation was expecting a non-existent parameter.
2014-08-25 17:20:48 -07:00
Jeff Atwood
024c503870 mobile login tweaks 2014-08-25 12:38:27 -07:00
Sam
e0a74e336a Add SSO diagnostics 2014-08-23 10:34:48 +10:00
Neil Lalonde
bbb358b356 Add likes given and likes received requirement for being TL3. Configure with site settings leader_requires_likes_given and leader_requires_likes_received. 2014-08-22 17:33:39 -04:00
Jeff Atwood
f171af5fe5 minor copyedit 2014-08-22 12:49:02 -07:00
Neil Lalonde
00c28f2391 Show total likes given. Put likes given/received and flags given/received together. 2014-08-22 15:23:19 -04:00
Neil Lalonde
dafc63e3a0 Show how many likes users received in the last 100 days on their admin profile page 2014-08-22 14:37:07 -04:00
Sam
136169bc73 Merge pull request #2676 from riking/logster-link
Add link to Logster in "Logs" tab of admin panel
2014-08-22 10:21:04 +10:00
riking
50d4e283dc Add link to Logster in "Logs" tab of admin panel 2014-08-20 14:40:16 -07:00
Jeff Atwood
21b18b1253 remove the "view all {number}.." from mobile cat 2014-08-20 13:51:10 -07:00
Régis Hanol
8a20d05ba5 FEATURE: backup without uploads 2014-08-20 18:53:58 +02:00
Robin Ward
2b5feda625 FIX: You need to be logged in to edit wiki posts. 2014-08-20 11:04:45 -04:00
Jeff Atwood
9c7bc57121 clarify on flag reply "more" indicator 2014-08-19 12:40:39 -07:00
Robin Ward
96afbd6656 TRIVIAL: Don't show 06 Aug, show 6 Aug 2014-08-19 14:46:35 -04:00
Jeff Atwood
107ac88f15 add back in "by default" on new/latest edu 2014-08-18 15:01:09 -07:00
Robin Ward
14c765ef11 UX: Tweak logic for showing times in topic entrance popup 2014-08-18 17:14:50 -04:00