github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2024-12-15 14:23:55 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity
34,189 Commits 214 Branches 500 Tags 960 MiB
9cfe3f9948
Commit Graph

13401 Commits

Author SHA1 Message Date
Guo Xiang Tan
8d1709f6b9 FIX: Disable buttons when loading more results on full page search. 
Follow up to d50deac676.
 2019-03-20 17:20:34 +08:00
tshenry
cc8082138f
Fix typos 2019-03-20 00:06:12 -07:00
Sam Saffron
d46ce0cb21 DEV: speed up ember acceptance tests 
## Before

```
Acceptance: Composer::Image resizing buttons: 7985ms
Acceptance: Composer::Edit the first post: 3854ms
Acceptance: Composer::Composer with dirty edit can toggle to another edit: 3707ms
Acceptance: Composer::Composer can toggle between edit and reply: 3704ms
Acceptance: Composer::Tests the Composer controls: 3685ms
Acceptance: Composer::Composer draft with dirty reply can toggle to edit: 3670ms
Acceptance: Composer::Composer can toggle layouts (open, fullscreen and draft): 3278ms
Acceptance: Composer::Switching composer whisper state: 3266ms
Acceptance: Composer::Create a topic with server side errors: 3253ms
Acceptance: Composer::Composer with dirty reply can toggle to edit: 3189ms
Acceptance: Composer::Create a Topic: 3168ms
Acceptance: Composer::Create an enqueued Topic: 2767ms
Acceptance: Composer::Posting on a different topic: 2394ms
Acceptance: Composer::Composer can switch between edits: 2318ms
Acceptance: Composer::Create an enqueued Reply: 2317ms
Acceptance: Composer::Create a Reply: 2292ms
Acceptance: Composer::Checks for existing draft: 1696ms
Acceptance: Composer::Composer can toggle between reply and createTopic: 1415ms
Acceptance: Composer::Composer can toggle whispers: 1296ms
Acceptance: Composer::Loading draft also replaces the recipients: 594ms
```

## After

```
Acceptance: Composer::Composer can toggle layouts (open, fullscreen and draft): 2305ms
Acceptance: Composer::Switching composer whisper state: 2205ms
Acceptance: Composer::Composer draft with dirty reply can toggle to edit: 2185ms
Acceptance: Composer::Composer can toggle between edit and reply: 1719ms
Acceptance: Composer::Composer with dirty edit can toggle to another edit: 1682ms
Acceptance: Composer::Composer with dirty reply can toggle to edit: 1657ms
Acceptance: Composer::Composer can toggle between reply and createTopic: 1412ms
Acceptance: Composer::Posting on a different topic: 1341ms
Acceptance: Composer::Edit the first post: 1327ms
Acceptance: Composer::Create an enqueued Reply: 1306ms
Acceptance: Composer::Composer can toggle whispers: 1265ms
Acceptance: Composer::Composer can switch between edits: 1260ms
Acceptance: Composer::Create a Reply: 1259ms
Acceptance: Composer::Create a topic with server side errors: 1183ms
Acceptance: Composer::Checks for existing draft: 1172ms
Acceptance: Composer::Create a Topic: 1130ms
Acceptance: Composer::Image resizing buttons: 921ms
Acceptance: Composer::Create an enqueued Topic: 731ms
Acceptance: Composer::Tests the Composer controls: 654ms
Acceptance: Composer::Loading draft also replaces the recipients: 540ms

```


That is not a typo... image resizing button went from 8 seconds to 1 second
 2019-03-20 16:44:00 +11:00
Guo Xiang Tan
d50deac676 FIX: Search spinners hides all results when loading more. 
Regression from bc81f64a64.
 2019-03-20 13:34:56 +08:00
Bianca Nenciu
50e9a66e89 FIX: Improve UX for second factor enforcement. (#7207) 2019-03-20 15:40:25 +11:00
Kris
c72a60896c FIX: New account modal too narrow in Safari 2019-03-19 15:13:04 -04:00
Kris
955c8cb330 FIX: Login modal too narrow in Safari 2019-03-19 15:07:35 -04:00
Joe
ac4470cd56
UX: Hide mobile header notification badges if title is visible 2019-03-20 01:43:23 +08:00
Joe
533fb0019a fully hide header buttons if topic is visible (#7203) 2019-03-19 15:31:45 +01:00
Vinoth Kannan
0861ca7764 FIX: Don't push browser state if navigated from root url to home page url and vice versa 2019-03-19 19:22:06 +05:30
Dan Ungureanu
bdcb0e1efd
UX: Set color to gray for old post notices. 2019-03-19 15:47:47 +02:00
Régis Hanol
6fb49e74a1
Revert "UX: Better emoji escaping for topic title (#7176)" (#7201) 
This reverts commit 0d9bc0aaa6.
 2019-03-19 12:02:47 +01:00
Joe
6d7c0c8f13
REFACTOR: scroll-based mobile header switch 
This refactor addresses the following issues:

1- Moves all relevant logic to the discourse-topic component (matches desktop)
2- Fixes the flicker issue discussed here
3- Fixes a rare occurring issue where tags wrap to a third line if a topic has long category names and lots of tags
4- Fixes header icon jitter on iOS
5- Fixes an issue where sliding out user / hamburger menus on Android leaves the user in a mid-state with half a title and the header panel visible - swiping will now open the menus but have no effect on the header.
6- adds min-width to the small-logo to act as placeholder so that the title doesn't shift if the logo takes a while to load.

Other than that, everything should look and act the same.
 2019-03-19 18:39:38 +08:00
Tim Lange
0d9bc0aaa6 UX: Better emoji escaping for topic title (#7176) 2019-03-19 09:33:10 +01:00
Guo Xiang Tan
dd142eec03 UX: Don't reload page after saving settings when editing category. 2019-03-19 16:08:32 +08:00
Guo Xiang Tan
bc81f64a64 UX: Show spinner when searching on full page search. 2019-03-19 15:23:27 +08:00
Gerhard Schlager
3fd04df781
FEATURE: Locale support for seeded categories and topics (#7110) 2019-03-18 21:09:13 +01:00
Maja Komel
5d20d02ffc UX: add tag classes to topics in topics list view (#7198) 2019-03-18 13:58:29 -04:00
David Taylor
e2d6edd5ff DEV: Correct email disabled banner tests 
Followup to acc121fd27
 2019-03-18 17:06:29 +00:00
Dan Ungureanu
976ea160e9
FEATURE: Post notices become old after 14 days. (#7197) 2019-03-18 18:20:49 +02:00
Gerhard Schlager
c0a7b06777 Make eslint happy 2019-03-18 16:48:09 +01:00
David Taylor
acc121fd27 FIX: Show 'emails disabled' to staff users when disabled for non-staff (#7187) 2019-03-18 16:26:18 +01:00
Tim Lange
22c75e1c04 FIX: Fixed edit category description redirecting without saving (#7192) 2019-03-18 16:14:17 +01:00
Tim Lange
298f18cf70 UX: Enabled pinch to zoom for lightbox (#7161) 
* UX: Enabled pinch to zoom for lightbox

* FIX: Prettier for lightbox.js

* FIX: Only change content of meta tag
 2019-03-18 10:57:24 -04:00
venarius
3dfa22b55a FIX: Prettified code 2019-03-18 10:54:20 -04:00
venarius
4af0a2f00b FIX: Made reorder more convenient by clamping the entered number 2019-03-18 10:54:20 -04:00
venarius
ad363f45f0 FIX: Fixed reorder categories by number not working correctly 2019-03-18 10:54:20 -04:00
David Taylor
4e8c174ee5
FEATURE: Display notification count in title for logged in users (#7184) 
This replaces the 'contextual' counters for logged in users. We will still use the old method for anon users
 2019-03-18 12:59:47 +00:00
Arpit Jalan
0c01cb2cf3 UX: add instructions to update email when sso_overrides_email is enabled 2019-03-18 16:52:40 +05:30
Guo Xiang Tan
5e410dc5e0
FEATURE: Ability to exclude category from search results. (#7194) 
This commit also adds `Category#search_priority` which sets the ground
work to enable prioritizing of posts for certain categories when searching.
 2019-03-18 15:25:45 +08:00
Joffrey JAFFEUX
de6a7e32bd
FIX: brings back [+ New Topic] btn from share-popup post action (#7182) 2019-03-18 07:30:10 +01:00
Sam Saffron
c47b0a8bee Revert "UX: Added tooltips to topic admin menu (#7146)" 
This reverts commit d1c4981f65.

Per discussion with @coding-horror it was decided this change is to
far reaching.

Instead we will make smaller strategic changes to tooltips that add
value.
 2019-03-18 11:50:18 +11:00
Joffrey JAFFEUX
bc488c8dc0
FIX: prevents overflow on emoji picker on mobile (#7189) 2019-03-16 10:59:02 +01:00
Kris
b12ef793b7 minor button alignment fix 2019-03-15 19:25:51 -04:00
Kris
95e8c935c5 UX: Update brand color, some login adjustments 2019-03-15 17:20:52 -04:00
Joffrey JAFFEUX
e76b598e0f
FIX: ensures add/remove btn is shown if you can only invite (#7185) 2019-03-15 20:20:42 +01:00
Joffrey JAFFEUX
aa4b84925a FEATURE: updates emoji to latest 12.0 version (#7095) 
* improved emoji support

- always optimize images as part of the task
- use the unicode standard ordering/naming for sections

* UX: more height for when there are recently used
 2019-03-15 16:12:07 +01:00
Penar Musaraj
9334d2f4f7
FEATURE: add more granular user option levels for email notifications (#7143) 
Migrates email user options to a new data structure, where `email_always`, `email_direct` and `email_private_messages` are replace by

* `email_messages_level`, with options: `always`, `only_when_away` and `never` (defaults to `always`)
* `email_level`, with options: `always`, `only_when_away` and `never` (defaults to `only_when_away`)
 2019-03-15 10:55:11 -04:00
Régis Hanol
a6a52d1523 FIX: images:compress rake task 
Optimized a few unoptimized PNGs.
 2019-03-15 15:23:57 +01:00
Tarek Khalil
f8480ed911
FEATURE: Exposing a way to add a generic report filter (#6816) 
* FEATURE: Exposing a way to add a generic report filter

## Why do we need this change?

Part of the work discussed [here](https://meta.discourse.org/t/gain-understanding-of-file-uploads-usage/104994), and implemented a first spike [here](https://github.com/discourse/discourse/pull/6809), I am trying to expose a single generic filter selector per report.

## How does this work?

We basically expose a simple, single generic filter that is computed and displayed based on backend values passed into the report.

This would be a simple contract between the frontend and the backend.

**Backend changes:** we simply need to return a list of dropdown / select options, and enable the report's newly introduced `custom_filtering` property.

For example, for our [Top Uploads](https://github.com/discourse/discourse/pull/6809/files#diff-3f97cbb8726f3310e0b0c386dbe89e22R1423) report, it can look like this on the backend:

```ruby
report.custom_filtering = true
report.custom_filter_options = [{ id: "any", name: "Any" }, { id: "jpg", name: "JPEG" } ]
```

In our javascript report HTTP call, it will look like:

```js
{
  "custom_filtering": true,
  "custom_filter_options": [
    {
      "id": "any",
      "name": "Any"
    },
    {
      "id": "jpg",
      "name": "JPG"
    }
  ]
}
```

**Frontend changes:** We introduced a generic `filter` param and a `combo-box` which hooks up into the existing framework for fetching a report.

This works alright, with the limitation of being a single custom filter per report. If we wanted to add, for an instance a `filesize filter`, this will not work for us. _I went through with this approach because it is hard to predict and build abstractions for requirements or problems we don't have yet, or might not have._

## How does it look like?

![a1ktg1odde](https://user-images.githubusercontent.com/45508821/50485875-f17edb80-09ee-11e9-92dd-1454ab041fbb.gif)

## More on the bigger picture

The major concern here I have is the solution I introduced might serve the `think small` version of the reporting work, but I don't think it serves the `think big`, I will try to shed some light into why.

Within the current design, It is hard to maintain QueryParams for dynamically generated params (based on the idea of introducing more than one custom filter per report).

To allow ourselves to have more than one generic filter, we will need to:

a. Use the Route's model to retrieve the report's payload (we are now dependent on changes of the QueryParams via computed properties)
b. After retrieving the payload, we can use the `setupController` to define our dynamic QueryParams based on the custom filters definitions we received from the backend
c. Load a custom filter specific Ember component based on the definitions we received from the backend
 2019-03-15 12:15:38 +00:00
Bianca Nenciu
d352baa1a2
FEATURE: Enforce two-factor authentication. (#6348) 2019-03-15 13:09:37 +02:00
Joffrey JAFFEUX
e711d3cb3a
FIX: prevents quote shortcut key to show in composer before quote (#7177) 2019-03-15 12:01:38 +01:00
Tim Lange
37c613dde2 FIX: Outsourced erb part from emoji.js.es6 (#7168) 2019-03-15 15:44:49 +11:00
Vinoth Kannan
bec3956f7f
FIX: Topic filters persist when navigating to home page (#7175) 
* FIX: Topic filters persist when navigating to home page

* remove the line which no longer needed
 2019-03-15 09:45:17 +05:30
Rafael dos Santos Silva
fb8bcd7469
FEATURE: Enable experimental Badging API (#7173) 2019-03-14 18:16:16 -03:00
Gerhard Schlager
c34a6ba674 REFACTOR: Rename site settings to make them less confusing 2019-03-14 13:40:14 +01:00
Guo Xiang Tan
b9ab393d70 Fix favicon not updating on the client side when changed. 
Regression from 1c6a2262b3.

Documented the rational for include the url since we can't really test
this properly.
 2019-03-14 15:37:43 +08:00
Guo Xiang Tan
1c6a2262b3
FIX: StaticController#favicon reads from disk when using local store. (#7160) 
Since uploads site settings are now backed by an actual upload, we don't
have to reach over the network just to fetch the favicon. Instead, we
can just read the upload directly from disk.
 2019-03-14 04:17:36 +08:00
Dan Ungureanu
81bf4df1a5
DEV: Fix lint. 2019-03-13 21:32:28 +02:00
Dan Ungureanu
18ff790e79
FIX: Use prioritize_username_in_ux in post notices. 2019-03-13 21:17:41 +02:00
Roman Rizzi
77931b70c3
Revert "DEV: Upgrade to Ember 3.7.0 (#6977)" (#7165) 
This reverts commit 3eebf8be73.
 2019-03-13 15:49:47 -03:00
Kris
4178578e09 UX: Adhere to Facebook & Twitter brand guidelines for share icon colors 2019-03-13 13:42:11 -04:00
Maja Komel
65f3ed0689 UX: make name optional for confirmation user field (#7149) 2019-03-13 18:40:43 +01:00
Maja Komel
12c37ada2e UX: focus on search box when emoji picker is opened (#7098) 2019-03-13 17:48:40 +01:00
Dan Ungureanu
91bd0becaa DEV: Allow topics to register default topic order criteria. (#7158) 2019-03-13 16:44:08 +01:00
Vinoth Kannan
c773f82ba1 DEV: Added qunit test functions and did minor refactoring 
135191d1d1
 2019-03-13 18:38:27 +05:30
Joffrey JAFFEUX
d32557ea32 Revert "FIX: Better emoji escaping for topic title" 
This reverts commit 35426b5ad6.
 2019-03-13 13:02:56 +01:00
Maja Komel
3eebf8be73
DEV: Upgrade to Ember 3.7.0 (#6977) 
* Upgrade to Ember 3.7.0

* use ember source 3.7.0.2

* fix mobile header

* fix navigation
 2019-03-13 12:16:06 +01:00
Vinoth Kannan
1b454c73ae FIX: 'topic' can have null value 2019-03-13 16:34:47 +05:30
Tim Lange
35426b5ad6 FIX: Better emoji escaping for topic title 
This commit also puts emojiVersion in its own erb file.
 2019-03-13 11:17:59 +01:00
Vinoth Kannan
135191d1d1 DEV: Option to add extra topic status icons in its widget and component 
and did some refactoring
 2019-03-13 15:17:26 +05:30
Guo Xiang Tan
b0c8fdd7da FIX: Properly support defaults for upload site settings. 2019-03-13 16:36:57 +08:00
Tim Lange
d1c4981f65 UX: Added tooltips to topic admin menu (#7146) 
* UX: Added tooltips to topic admin menu

* FIX: Prettyfied code

* FIX: Fixed typo

* Update config/locales/client.en.yml

Co-Authored-By: venarius <tim.lange@online.de>
 2019-03-13 17:11:36 +11:00
Joffrey JAFFEUX
edc6d87862 FIX: invite-panels regressions on private topics (#7157) 2019-03-13 16:34:23 +11:00
Tarek Khalil
db08b59eb2
UX: Change ignore button color (#7150) 2019-03-12 11:10:18 +00:00
Joffrey JAFFEUX
90965e1c18
FIX: error with two inputs having the same id (#7147) 2019-03-12 09:46:58 +01:00
Bianca Nenciu
e6c2faf186 FIX: Disable 'Create Topic' button if tag is staff-only. (#6984) 
* FIX: Disable 'Create Topic' button if tag is staff-only.

* FIX: Staff-only tags should always return 404.
 2019-03-12 19:23:36 +11:00
venarius
95dc52e15e FIX: Changed warning css class 2019-03-11 12:56:15 -04:00
venarius
dc4541a95c FIX: Text content search warning if more than 50 results 2019-03-11 12:56:15 -04:00
Robin Ward
da7406e567 Update app/assets/javascripts/discourse/controllers/full-page-search.js.es6 
Co-Authored-By: venarius <tim.lange@online.de>
 2019-03-11 11:33:24 -04:00
venarius
5f00624814 FIX: Fixed vanishing select boxes on full search as new content loads 2019-03-11 11:33:24 -04:00
Neil Lalonde
cbc8236288 UX: add a paragraph description on the tags tab of the category settings 2019-03-08 16:46:32 -05:00
Kris
c29ff3d2d5 UX: style adjustments for post notice feature 2019-03-08 16:02:51 -05:00
Kris
e3e681ebf7 UX: better handling of width and overflow for login/signup 2019-03-08 11:14:52 -05:00
Dan Ungureanu
ac8425ad30
FIX: Date format and styling for post notices 
Follow-up to 35942f7.
 2019-03-08 12:25:03 +02:00
Régis Hanol
7ff994b6ea
UX: post-notice max width on desktop 2019-03-08 10:52:47 +01:00
Régis Hanol
2434e48d4d
UX: Fix post notice on mobile 2019-03-08 10:50:33 +01:00
Dan Ungureanu
35942f7c7c
FEATURE: Special call-out for new / returning posters. (#7115) 2019-03-08 10:48:35 +02:00
Simon Cossar
65464969cd Change searchTearm to searchTerm (#7130) 2019-03-08 09:24:14 +01:00
Joffrey JAFFEUX
3acf8a95f3
UX: various tweaks to search-menu (#7114) 2019-03-08 09:23:44 +01:00
Joffrey JAFFEUX
c90267db52
FIX: do not display add/remove participants if you can’t actually do it (#7125) 2019-03-08 09:23:26 +01:00
Kris
cd94ac9453 FIX: remove padding from onebox site icon in composer preview 2019-03-07 22:32:27 -05:00
Kris
6e26358380 REFACTOR: streamline like button styles, clarify for themeing, enable tab focus 2019-03-07 21:09:57 -05:00
Kris
ccff1d2dbb prettier 2019-03-07 13:30:39 -05:00
Kris
837452794b Target active nav pill with single style 2019-03-07 13:21:42 -05:00
Joffrey JAFFEUX
a2fdd4089c
FIX: nav-pills not highlighted on user preferences page (#7126) 2019-03-07 13:40:12 +01:00
Arpit Jalan
2c8e1d3578 FEATURE: remove all expired invitations by default 2019-03-07 15:28:39 +05:30
Arpit Jalan
caef0a56d1 FEATURE: create a new message via URL without specifying user or group 2019-03-07 11:30:24 +05:30
Kris
9d3c7d7b25 prettier 2019-03-06 19:52:34 -05:00
Kris
e233a69db0 Customize nav pill fix 2019-03-06 19:42:44 -05:00
Kris
7d2cc33013 prettier 2019-03-06 17:37:59 -05:00
Kris
a917a93990 fix active class, remove style 2019-03-06 17:29:19 -05:00
Kris
536952f194 adding back active nav pill 2019-03-06 17:14:02 -05:00
Bianca Nenciu
733deba585 FIX: Loading draft also replaces the recipients (#7122) 2019-03-07 08:14:55 +11:00
Kris
078c02cd24 UX: More consistent structure for active nav-pill 2019-03-06 16:10:22 -05:00
Vinoth Kannan
5ba2ef4274 UX: Display error message if no time frame selected in topic status update 2019-03-07 02:17:29 +05:30
Kris
2db3652338 UX: Fix redeemed invite table layout 2019-03-06 11:05:45 -05:00
Kris
5cf63e43c6 FEATURE: Add about-after-description plugin outlet 2019-03-06 10:26:34 -05:00
Tarek Khalil
0a9a11094d
FEATURE: Save ignored usernames in user preferences (#7117) 
* FEATURE: Save ignored usernames in user preferences
 2019-03-06 11:21:58 +00:00
Joffrey JAFFEUX
974e756369
FIX: bugs in safari where select-kit is not expanding on iOS (#7118) 2019-03-06 11:29:45 +01:00
Tarek Khalil
b58eea1fcb
FEATURE: Hide ignored user's Original Post content (#7113) 
* FEATURE: Hide ignored user's Original Post content
 2019-03-06 09:20:45 +00:00
Arpit Jalan
05ebb52ec4
FEATURE: defer flags when deleting child replies (#7111) 2019-03-06 14:32:25 +05:30
Kris
86f9ace0ea UX: Previous positioning was better for the image resizer 2019-03-05 22:10:12 -05:00
Kris
b5804c410e UX: Add slash to mobile category page totals 2019-03-05 20:16:12 -05:00
Kris
2ea77073ae prettier 2019-03-05 15:12:10 -05:00
Kris
84892429ed UX: Improve layout of invite table 2019-03-05 14:50:27 -05:00
Gerhard Schlager
671cec4bd2 DEV: Use Discourse.getURL for creating URL 
follow-up to ccb48bef75
 2019-03-05 17:52:18 +01:00
Tarek Khalil
190b19f3c2
FEATURE: Add ignored user list to the User's preference page (#7107) 
* FEATURE: Add ignored user list to the User's preference page

## Why?

Part of: https://meta.discourse.org/t/ability-to-ignore-a-user/110254

We want to add list of Ignored users under or along with the muted users preferences section.
This way Users can find and update their list of ignored users.

## UI


![gif](https://user-images.githubusercontent.com/45508821/53746179-8e9b3c00-3e98-11e9-9e90-94b8520896a6.gif)

## Open questions

Two of many options to represent a list of ignored users is that we can:

1. We can represent the ignored user list as a table with the ability to `un-ignore` but NOT to add new ignored users.
2. We can keep it functioning as the `muted user list` where you can `un-ignore` or `ignore` users.
 2019-03-05 14:47:51 +00:00
Tarek Khalil
f19d36cbba
REFACTOR: Change watch wording to unignore (#7112) 
* REFACTOR: Change `watch` wording to `unignore`
 2019-03-05 14:40:31 +00:00
Gerhard Schlager
ccb48bef75 UX: Make Uncategorized category less confusing 
* Adds warnings to the "Edit Category" dialog
* Doesn't hide the "Security" tab on the "Edit Category" dialog anymore. Instead, it shows an explanation why permissions can't be changed.
* Makes the category name translatable
* Hides the category name from the edit dialog (it can be customized by overriding the translation)
* Creates a translation override if the category has been renamed in the past
 2019-03-05 14:42:41 +01:00
Gerhard Schlager
68e4aba369 UX: Don't concatenate title on "Edit Category" dialog 2019-03-05 14:42:41 +01:00
Kris
73e4204d20 UX: Image preview resizer style 2019-03-04 21:59:58 -05:00
Tarek Khalil
079b0f4bff
FIX: Remove ignore user feature from user-card-contents component (#7104) 
Based on our discussions, we want to have the `Ignore button will ONLY be on the User’s profile page`.
 2019-03-04 15:21:45 +00:00
Joffrey JAFFEUX
2e881adb6e
FIX: select-kit perf and positioning improvements (#7093) 2019-03-04 10:30:22 +01:00
Joffrey JAFFEUX
dc4001370c
FEATURE: displays groups in menu search (#7090) 2019-03-04 10:30:09 +01:00
Joffrey JAFFEUX
075b264338
DEV: replaces DOMNodeInserted by the better MutationObserver (#6884) 2019-03-04 10:28:59 +01:00
Arpit Jalan
824d9402a4 FIX: pending counts were not shown on invites tab 2019-03-04 14:14:13 +05:30
Joffrey JAFFEUX
bb39a6f7d7 REFACTOR: topic-list-header-column (#7099) 2019-03-04 14:45:52 +11:00
Jeff Atwood
9585e2dff2 change separator from | to • for editor image sizing 2019-03-03 17:55:21 -08:00
Gerhard Schlager
14f9e55977 FIX: Error when filtering site settings 
Happened only when none of the logo settings had an image assigned.
 2019-03-03 20:43:22 +01:00
Dan Ungureanu
fd9671f7fe
DEV: Minor code improvements. 2019-03-02 19:07:54 +02:00
Sam
03a70ef69c FIX: allow underscore and dash in username search 
_ and - are technically punctuations, but we allow them in usernames so
accept them in search
 2019-03-01 15:23:45 +11:00
Sam
cdf34657f6 FEATURE: focus on composer TEXTAREA when iPad has a physical keyboard 
This disables a bunch of hacks that bypassed "focus" on iOS (cause focus
events that involve a virtual keyboard on iOS cause browser havoc unless
a physical keyboard is attached)

Also will focus on title on new topic
 2019-03-01 11:31:52 +11:00
Dan Ungureanu
6bc8382555 FEATURE: Use smooth scrolling for J/K keyboard shortcuts. (#7084) 2019-03-01 09:31:40 +11:00
Vinoth Kannan
be436066ff FIX: Prevent default event and stop bubbling up when card popup is closed in mobile 2019-03-01 01:42:17 +05:30
Penar Musaraj
64a3d63ddc DEV: Rename some icons with deprecated names 2019-02-28 13:03:14 -05:00
Maja Komel
612a0be085 FIX: don't add bottom padding for avatars in composer preview 2019-02-28 18:03:38 +01:00
David Taylor
e67474daf4 UX: Don't link to theme source unless it's http(s) 2019-02-28 17:01:59 +00:00
Joffrey JAFFEUX
1cd64f68f1
FIX: staff/admin shouldn’t be able to create uncategorized topics (#7077) 2019-02-28 15:51:13 +01:00
David Taylor
3517103398 UX: Correct locale key for theme compatibility error 2019-02-28 14:40:33 +00:00
Arpit Jalan
c02956e29c
FIX: when posts are moved to a message then small action post should not be publicly visible (#7085) 
This fix is inspired from what we do in discourse-assigned plugin.
https://github.com/discourse/discourse-assign/blob/master/lib/topic_assigner.rb#L184
https://github.com/discourse/discourse-assign/blob/master/assets/javascripts/discourse-assign/initializers/extend-for-assigns.js.es6#L125-L133
 2019-02-28 19:49:26 +05:30
Maja Komel
bb5119b88f FIX: only profile owner can see links to watched/tracked/muted topics (#7083) 2019-02-28 14:58:49 +01:00
Joffrey JAFFEUX
883a18547e
FIX: shows invite panel on mobile from topic footer buttons (#7080) 2019-02-28 14:56:22 +01:00
David Taylor
6296554ed1 DEV: Add additional hook for theme-creator 2019-02-28 10:48:30 +00:00
Vinoth Kannan
0cc636f648 UX: Don't add padding bottom for emojis in composer preview 2019-02-28 15:53:21 +05:30
Maja Komel
97c0fd0909 FIX: styling for resizable image wrapper in editor preview 2019-02-28 10:24:43 +01:00
Sam
06abecdb41 FEATURE: on iPad bluetooth keyboard use ALT-ENTER for post submit 
Command and Control can not be properly detected via JavaScript so lean on
Alt that can be detected.
 2019-02-28 16:41:31 +11:00
Sam
0b86a99c39 FEATURE: allow iPad users to specify they have a physical keyboard 
Sadly there is no clean way of detecting a keyboard is connected to an iPad

If the keyboard is connected we want to disable all the touch related hacks
on iOS

This allows iPad users to specify they have a keyboard connected. Setting
is per device.
 2019-02-28 15:59:44 +11:00
Kris
cafbb3aea7 UX: Use official Facebook logo 2019-02-27 09:52:06 -05:00
Tarek Khalil
986cc8a0fb FEATURE: Introduce Ignore user (#7072) 2019-02-27 14:49:07 +01:00
Joffrey JAFFEUX
5c476f639c
REFACTOR: user-invited-show (#7078) 2019-02-27 12:59:57 +01:00
Joffrey JAFFEUX
8ff3fc20a6
REFACTOR: tags-show (#7079) 2019-02-27 12:59:39 +01:00
Maja Komel
7d2ea2d4dd FEATURE: image resizing discoverability (#6804) 2019-02-27 11:46:16 +01:00
Maja Komel
6f427589b2 FIX: make it possible to use backup code everywhere where 2FA required (#7010) 2019-02-27 10:37:33 +01:00
Erick Guan
e1d1073273 FIX: use * when apply italics in the editor instead of _ (#7063) 2019-02-27 10:36:14 +01:00
Kris
ef9b249cd2 UX: More consistent table header styles, removing duplicate styles 2019-02-26 21:40:17 -05:00
Kris
1d4e9b08ad UX: Don't override unset flair color 2019-02-26 12:49:54 -05:00
Vinoth Kannan
59c66fd226
REFACTOR: Improve the readability of code (#7076) 2019-02-26 23:03:49 +05:30
Joffrey JAFFEUX
fbedaea5ed
FIX: prevents double network calls and other quirks on admin emails (#7074) 2019-02-26 17:53:52 +01:00
Joffrey JAFFEUX
8c706b0ff7
fix tests (#7073) 2019-02-26 16:49:29 +01:00
Joffrey JAFFEUX
2a8da03951
FIX: prevents autocomplete from going over search input (#7075) 2019-02-26 15:48:02 +01:00
Joffrey JAFFEUX
d04c4bf8e7
UX: puts back share-panel as floating pane on post actions (#7066) 2019-02-26 14:15:25 +01:00
Arpit Jalan
6ea9f5c9c5 FIX: do not update tag name on /tags/intersection 2019-02-26 16:43:39 +05:30
Joffrey JAFFEUX
1cee8a86f6
fix prettier (#7071) 2019-02-26 11:24:02 +01:00
Joffrey JAFFEUX
a206c7f5d5
FIX: attempts to fix an error with EXTEND_PROTOTYPES (#7067) 2019-02-26 11:04:05 +01:00
Joffrey JAFFEUX
71360436ff
FIX: users list show was loading multiple times with different params (#7058) 
A first load was happening in route, which was setting properties on controller. These properties were observed on the controller and were triggering a reload of the AdminUser model.

Not only was it doing loading two times it was also sometimes resulting on the controller model refresh end to happen after route has been changed, resulting in a wrong model.
 2019-02-26 10:43:24 +01:00
Vinoth Kannan
ed0120171c FIX: Hide 'show associated accounts' button if moderators can't see emails 
And minor prettier code alignments
 2019-02-26 13:49:27 +05:30
Simon Cossar
c742d42031 FIX: rtl topic progress wrapper position (#7070) 
* Set left/right topic-progress-wrapper CSS from text-direction

* Remove unnecessary CSS rule
 2019-02-25 20:56:52 -05:00
Kris
d6875a77fb UX: Apply new-user color to full name and username 2019-02-25 17:09:41 -05:00
Kris
34d0cc6ad5 UX: Better alignment of similar topics in composer 2019-02-25 17:04:11 -05:00
Osama Sayegh
d5efe2d7ee UX: make composer resize work on touch devices (#7068) 
* UX: make composer resize work on touch devices

This also replaces a vendor dependency with a small built-in resize mechanism.

* Make blue bar's larger padding specific to touch devices
 2019-02-26 08:04:14 +11:00
Joffrey JAFFEUX
5952a6c0ad
DEV: uses find() helper instead of this.$() in js tests (#7062) 2019-02-25 16:04:55 +01:00
Joffrey JAFFEUX
c0dd171cf1
REFACTOR: bread-crumbs (#7064) 2019-02-25 14:51:14 +01:00
Joffrey JAFFEUX
6930706830
REFACTOR: new message route (#7061) 2019-02-25 14:01:00 +01:00
Arpit Jalan
91e771ece6 FIX: send test email doesn't show a status 2019-02-25 17:42:58 +05:30
Joffrey JAFFEUX
900e187627
DEV: removing blank files (#7057) 2019-02-25 09:52:44 +01:00
Joffrey JAFFEUX
919839fd97
FIX: allows {{d-button}} to set a form attribute (#7056) 
This attribute is used when a submit button is out of a form. It makes it explicit which form this button is submitting.

It's currently used in our login modal form.
 2019-02-25 09:49:49 +01:00
Kris
2d031a1beb UX: Improve moderator icon alignment 2019-02-22 21:29:39 -05:00
Joffrey JAFFEUX
87f4ee13ef
UX: puts more emphasis on the shared url on share panel (#7055) 2019-02-22 23:22:11 +01:00
Jeff Wong
8be7878656 FEATURE: add ability to clear previously set mobile_view with mobile_view=auto 2019-02-22 10:44:49 -08:00
Joffrey JAFFEUX
8aca26cce3
FIX: allows right-click on post-date sharing link (#7054) 2019-02-22 15:18:05 +01:00
Vinoth Kannan
d1bad881ea
FEATURE: Allow moderators to change topic timestamps (#7053) 2019-02-22 14:33:52 +05:30
Kris
87b5003453 UX: Increase width of hamburger menu to 320px 2019-02-21 21:52:21 -05:00
Kris
f44ef82b53 UX: Better wrapping of group header elements 2019-02-21 21:42:39 -05:00
Sam
31d41f532e PERF: do not include suggested topics when loading new posts 
When a new post is triggered via message bus post stream will attempt to load
it, previously the `/topic/TOPIC_ID/posts.json` would unconditionally include
suggested topics, this caused excessive load on the server.

New pattern defaults to exclude suggested and related topics from this API
unless people explicitly ask for suggested.
 2019-02-22 10:37:18 +11:00
Penar Musaraj
74ed72e825 DEV: Remove d-checkbox component 
Replaces the last occurrence of `d-checkbox` with a regular input element.

Includes a minor refactor of admin site text search.
 2019-02-21 09:54:54 -05:00
Guo Xiang Tan
1dee71d760 UX: Disabled lightbox expand button when loading image meta. 2019-02-21 22:30:57 +08:00
Joffrey JAFFEUX
090acb5b11
FIX: s/isMessage/isPM (#7048) 
Regression due to refactoring
 2019-02-21 13:53:50 +01:00
Joffrey JAFFEUX
8d779db270
FIX: allows invite modal from topic-map post-actions (#7047) 2019-02-21 13:48:03 +01:00
Guo Xiang Tan
46e62c0d22
UX: Default user facing routes to /g instead of /groups. (#7042) 2019-02-21 13:44:25 +08:00
Sam
07b856700d REFACTOR: remove disallowEmails option from user-selector 
Negative option was leading to a fair amount of confusion, going forward
if we want to allow selection of emails from user selector it must be
supplied with `allowEmails=true`

This corrects a regression in 1f4ace4f which broke invite by emails and
start PM to email
 2019-02-21 16:37:26 +11:00
Sam
79841cf7dd FEATURE: add missing autocomplete suppressions 
Following 1f4ace4f add a couple more autocomplete suppressions (in polls
and invite ui)
 2019-02-21 16:37:26 +11:00
Guo Xiang Tan
d3cd314a98 Make eslint happy. 2019-02-21 10:26:56 +08:00
Guo Xiang Tan
58b0e945bd
UX: Lightbox support for image uploader. (#7034) 2019-02-21 10:13:37 +08:00
Penar Musaraj
cc1f9e7be6 Fix share button in post menu 2019-02-20 16:27:59 -05:00
Joffrey JAFFEUX
353eeef72a
fix prettier offense (#7041) 2019-02-20 22:22:38 +01:00
Penar Musaraj
cafe637407
UX: List popular themes and components in admin panel (#6997) 
Reorganizes theme create/upload flows into one install flow
Adds quick list of popular themes/components with one-click installation
 2019-02-20 14:58:31 -05:00
Penar Musaraj
4955ab1689 DEV: add replaceTagRenderer to pluginApi 2019-02-20 14:52:56 -05:00
Joffrey JAFFEUX
18296b4211
FIX: more reliable native sharing (#7039) 2019-02-20 20:43:48 +01:00
Joffrey JAFFEUX
9618300d69
s/share/nativeShare (#7038) 2019-02-20 20:03:30 +01:00
Joffrey JAFFEUX
994a09e5e8
FIX: stricter window.navigator.share check (#7037) 2019-02-20 19:40:51 +01:00
Joffrey JAFFEUX
2e0342dba7
UX: more spacing between social links (#7036) 2019-02-20 19:37:08 +01:00
Joffrey JAFFEUX
28c24631b8
FIX: ensures panel's shareUrl is not erased by topic's shareUrl (#7035) 2019-02-20 19:33:54 +01:00
Joffrey JAFFEUX
04a63cfaaa
[WIP] FEATURE: merge share and invite actions together (#7021) 
This commit also:
- removes [+ New Topic] behaviour from share, this feature has been duplicated in composer actions, months ago
- introduces our new experimental spacing standard for css: eg: `s(2)`
- introduces a new panel UI for modals
 2019-02-20 15:42:44 +01:00
Gerhard Schlager
6a8007e5fb FEATURE: Improve handling of backup storage errors 2019-02-20 15:16:49 +01:00
Guo Xiang Tan
31ffa5f64e
UX: Allow users to see filename in image-uploader component. (#7022) 
https://meta.discourse.org/t/downsides-of-the-new-logo-ui-in-site-settings/102247/23?u=tgxworld
 2019-02-20 13:55:55 +08:00
Sam
1f4ace4f56 FEATURE: autocomplete usernames early in topic based on participation 
Following this change when a user hits `@` and is replying to a topic they
will see usernames of people who were last seen and participated in the topic

This is somewhat experimental, we may tweak this, or make it optional.

Also, a regression in a423a938 where hitting TAB would eat a post you were writing:

Eg this would eat a post:

``` text
@hello, testing 123 <tab>
```
 2019-02-20 13:34:43 +11:00
Sam
918a0ea3a4 FIX: use autocomplete="discourse" to disable Chrome address autofill 
https://stackoverflow.com/a/47822599/17174

Chrome 63 and up start ignoring `autofill="off"`

Per: https://bugs.chromium.org/p/chromium/issues/detail?id=468153#c164

> The tricky part here is that somewhere along the journey of the web autocomplete=off become a default for many form fields, without any real thought being given as to whether or not that was good for users. This doesn't mean there aren't very valid cases where you don't want the browser autofilling data (e.g. on CRM systems), but by and large, we see those as the minority cases. And as a result, we started ignoring autocomplete=off for Chrome Autofill data

So to work around this decision we now explicitly say: autocomplete="discourse"
when we don't want Chrome to randomly fill in addressed (aka. always)
 2019-02-20 10:15:59 +11:00
Jeff Wong
246997dbd9 FIX: an <a> with a target of _blank wants a new window 2019-02-19 14:44:30 -08:00
David Taylor
49e7073438 FIX: Hide advanced theme fields behind a flag, pending UI improvement 2019-02-19 22:25:00 +00:00
David Taylor
d08939ab05 FIX: Should be possible to save an empty theme_field in the editor 
Removing the theme_field JS object when the value was empty caused the server to maintain the previous value, making it impossible to delete the content of a field.
 2019-02-19 21:49:31 +00:00
David Taylor
dbcf05d62c DEV: Code style improvements following review 
Followup to 05ee1d1aba
 2019-02-19 20:02:29 +00:00
David Taylor
7878e5007a
FIX: Refactor to prevent themes affecting core stylesheets (#7029) 
If a theme setting contained invalid SCSS, it would cause an error 500 on the site, with no way to recover. This commit stops loading theme settings in the core stylesheets, and instead only loads the color scheme variables. This change also makes `common/foundation/variables.scss` available to themes without an explicit import.
 2019-02-19 15:55:59 +00:00
Joffrey JAFFEUX
9ade04b709
FIX: removes legacy browsers-refresh button (#7028) 2019-02-19 16:38:21 +01:00
David Taylor
05ee1d1aba
FEATURE: Added settings/translations support to theme editor UI (#7026) 
- These advanced fields are hidden behind an 'advanced' button, so will not affect normal use
- The editor has been refactored into a component, and styling cleaned up so menu items do not overlap on small screens
- Styling has been added to indicate which fields are in use for a theme
- Icons have been added to identify which fields have errors
 2019-02-19 12:56:01 +00:00
Joffrey JAFFEUX
0616837a5d
UX: moves wizard's "Finish" button to the left of back and next (#7027) 
This was done to avoid clicking finish when clicking fast on next.
 2019-02-19 13:32:01 +01:00
Joffrey JAFFEUX
8a4cd15e46
REFACTOR: topic model (#7020) 2019-02-19 10:13:46 +01:00
Joffrey JAFFEUX
15fd875855
REFACTOR: color-scheme-color model (#7019) 2019-02-19 09:31:26 +01:00
Joffrey JAFFEUX
cba0dd33ee
REFACTOR: admin-customize-color (#7018) 2019-02-19 09:31:11 +01:00
Joffrey JAFFEUX
2c6bf184bc
REFACTOR: admin-badge-preview (#7017) 2019-02-19 09:30:52 +01:00
Joffrey JAFFEUX
3bf61fca66
REFACTOR: admin-user-field-item (#7016) 2019-02-19 09:30:38 +01:00
Joffrey JAFFEUX
ee692414ce
REFACTORING: admin-edit-badge-groupings (#7015) 2019-02-19 09:30:24 +01:00
Kris
4f5aebc338 UX: reduce subcategory badge spacing 2019-02-18 19:04:36 -05:00
Arpit Jalan
50f833def0 fix the build 
JsPrettier on Sublime was failing because: https://github.com/jonlabelle/SublimeJsPrettier/issues/157#issuecomment-458175837
 2019-02-18 11:52:11 +05:30
Arpit Jalan
dc2776bcdd FIX: do not show "move to new PM" option to moderators 2019-02-18 11:35:00 +05:30
Jeff Atwood
052eaed16a lighten embed blockquote style for consistency 2019-02-17 21:00:46 -08:00
Jeff Atwood
dfba36fdca remove bgcolor from embed quotes for consistency 2019-02-17 20:57:27 -08:00
peterlamber
159dd69fcb UX: make adding permissions more visible and intuitive to click. (#6999) 2019-02-15 12:01:10 -05:00
Dan Ungureanu
a423a9383f FIX: Stop autocomplete for invalid usernames. (#7005) 2019-02-15 11:29:26 +11:00
Kris
3d11064a33 UX: Reduce font size on about pages 2019-02-14 11:01:17 -05:00
Maja Komel
39522659a6 FIX: validate parent category/subcategories permissions 
See: https://meta.discourse.org/t/subcategories-do-not-inherit-permissions-from-parent-category/17174/23 for more details

This ensures users with access to child category can always at least see parent
 2019-02-14 16:38:52 +11:00
Penar Musaraj
090e9c8432
FIX: make composer full screen shortcut work when inputs have focus (#6907) 
- Uses a Mousetrap plugin for global shortcuts
- Implemented for search `ctrl+alt+f` and composer fullscreen `shift+f11` shortcuts
 2019-02-14 00:19:27 -05:00
Kris
37666c3d18 UX: Signup form labels were too constrained, minor cleanup 2019-02-13 21:07:34 -05:00
Régis Hanol
0476169692 make prettier happy 2019-02-13 22:16:38 +01:00
Régis Hanol
94fe0af900 FIX: upload emojis sequentially to prevent rate limit 2019-02-13 22:07:37 +01:00
Joffrey JAFFEUX
560cc4e73e
FIX: sets categoryId but do not scope when replying as new topic (#7002) 2019-02-13 15:19:58 +01:00
Jeff Wong
1328a127ee FIX: translate bootbox confirmation dialog (#6981) 2019-02-13 14:04:56 +11:00
Jeff Wong
467cfc9e08 FIX: remove extra periods (#6998) 
Periods are belong in the translation files not in our templates, if we have them in the templates sentences can not be localized properly.
 2019-02-13 12:54:34 +11:00
Joffrey JAFFEUX
47fe34d794 FEATURE: makes create-account userfields using dropdowns accessible (#6991) 2019-02-13 12:52:55 +11:00
Kris
3da35081e5 UX: Embedded post collapse button hover color fix 2019-02-12 17:21:33 -05:00
David Taylor
59640ef373 DEV: Add additional hooks for theme-creator plugin 2019-02-12 14:17:34 +00:00
Régis Hanol
b8b1759de9 UX: show envelope when tag is only used in PM 
UX: use regular envelope instead of solid envelope

REFACTOR: %s/enveloppe/envelope/g
 2019-02-12 11:34:25 +01:00
Jeff Wong
d997b01a24 FIX: Scale down swipe in detection to 20px from edge of the screen 
...and slightly increase velocity required for menu actions
 2019-02-11 21:22:50 -08:00
Jeff Wong
c3cbff55be FIX: only respond to menu open swipes on Andorid 2019-02-11 20:56:25 -08:00
Penar Musaraj
c50db76f5d FIX: do not treat TIFF, BMP, WEBP as images 
Treating TIFF and BMP as images cause us to add them to IMG tags, this is very inconsistent across browsers.

You can still upload these files they will simply not be displayed in IMG tags.
 2019-02-11 16:28:43 +11:00
David Taylor
60fa4fe692 DEV: Make interface route/controller more resilient to missing values 2019-02-08 16:54:15 +00:00
Kris
0d1fa54957 compensate for border overhang in category list alignment 2019-02-08 11:49:06 -05:00
Kris
7c55de6e6f UX: Alignment fix for names with emoji 2019-02-08 11:07:04 -05:00
David Taylor
747fea8458 DEV: Remove unused import 2019-02-08 16:05:39 +00:00
David Taylor
95eb4c67f2 FIX: Allow reverting theme/text settings from cookie back to default 2019-02-08 15:39:44 +00:00
Penar Musaraj
62043e6904 UX: Hide branch/private repo options in admin theme import modal 2019-02-08 10:17:29 -05:00
Joffrey JAFFEUX
44d9bc12c9
FEATURE: color-palettes component (#6992) 2019-02-08 14:01:14 +01:00
David Taylor
babd80dfd1 FIX: Allow subexpressions in raw handlebars helpers 
Helpers registered via `registerUnbound` did not receive parameters if they were subexpressions.
For example: `{{helper1 key=(helper2 value)}}`
 2019-02-08 12:58:10 +00:00
Joffrey JAFFEUX
e3324737ee
FIX: position invite footer button before archive (#6990) 2019-02-08 12:21:51 +01:00
Joffrey JAFFEUX
8a152566e3
FIX: improves positioning of footer buttons on mobile (#6989) 2019-02-08 12:09:56 +01:00
Joffrey JAFFEUX
e54612c914
fix tests (#6987) 2019-02-08 11:38:15 +01:00
Kris
f849169619 UX: Modifications to admin/customize layout 2019-02-07 22:27:35 -05:00
Penar Musaraj
2a007bafa2 FEAT: Allow image resize by width or height 
`|150x` resizes to 150px wide + auto-height. `x150` resizes to 150px tall and auto-width.

Resize value can be from 1 to 999 (incl. for percentages).
 2019-02-07 15:04:39 -05:00
Joffrey JAFFEUX
c0ccf21970
FIX: hides topic-footer-mobile-dropdown when no content (#6985) 2019-02-07 18:37:20 +01:00
Joffrey JAFFEUX
6c195640b9
FEATURE: adds an API to register topic footer buttons 2019-02-07 14:43:33 +01:00
Joffrey JAFFEUX
92c52c0724
FEATURE: displays report description when hovering activity metrics (#6983) 2019-02-07 13:33:05 +01:00
Kris
1cacfddda4 Prevent usercard badge section from overflowing 2019-02-06 22:39:10 -05:00
Kris
984f1d96b0 Add max-width so long badges don't force short badges to truncate 2019-02-06 20:51:54 -05:00
Kris
94f8c4ecac UX: Truncate (don't wrap) badges in user cards if the text is long 2019-02-06 20:18:12 -05:00
Dan Ungureanu
fc4c015bee FEATURE: Shortcut 'g s' goes to first suggested topic 2019-02-07 08:43:07 +11:00
Kris
56a9f777cb UX: Turn off autocomplete on composer title 2019-02-06 14:37:29 -05:00
Robin Ward
ca03b2ff30 Move SCSS variables for topic post width 
This allows them to be re-used by other components, for example the
upcoming review queue.
 2019-02-06 11:37:59 -05:00
Régis Hanol
057d1dc077 UX: disable browser's autocomplete in search menu 2019-02-06 17:06:23 +01:00
Kris
1a72242746 line-height adjustment 2019-02-05 21:44:06 -05:00
Kris
a52b2c9625 UX: Moving the create theme buttons, adding buttons to theme index 2019-02-05 21:40:17 -05:00
Dan Ungureanu
31ffcf989c
UX: Use translatedLabel for aria-label in buttons. 2019-02-05 13:11:07 +02:00
Dan Ungureanu
2c222e16fe FEATURE: Returning falsy value from upload handler stops upload. (#6969) 2019-02-05 10:54:11 +01:00
Kris
b6e3ef4a90 Minor icon color fix 2019-02-04 22:14:18 -05:00
Kris
58d5fc3632 UX: Minor button icon color fixes 2019-02-04 12:46:12 -05:00
Jeff Wong
9de906ddab
FIX: Register pan events for touch only 
* touch events - only register touch, not pointer events
* immediately request redraw frame, do not wait for after render to fire.
 2019-02-04 08:27:40 -08:00
Bianca Nenciu
e0e91fad87 FIX: Fix delete button for Tag Groups. (#6965) 2019-02-04 12:46:39 +01:00
Kris
2a2be093ca UX: checkboxes were too close to other inputs 2019-02-01 21:07:57 -05:00
Kris
37c28cf0b7 UX: Header icon color fix 2019-02-01 09:51:12 -05:00
David Taylor
eb617dea4b DEV: Run prettier on report.js.es6 
The prettier version I was running was different to the CI pipeline
 2019-02-01 13:22:31 +00:00
David Taylor
5c9426be48 SECURITY: Escape HTML in dashboard report tables 2019-02-01 13:10:59 +00:00
David Taylor
925606f8b1 FIX: Login button icons should be white 2019-02-01 11:01:59 +00:00
Kris
bbaa3e9166 Header icon focus color fix 2019-01-31 19:31:09 -05:00
Kris
95e16ab0a6 UX: Badge checkmarks should be round 2019-01-31 15:27:46 -05:00
Kris
6141290399 FIX: Mobile button colors 2019-01-31 15:13:54 -05:00
Penar Musaraj
3500acf2f6 FIX: refresh admin/customize/themes route after import 
Fixes an issue where the imported color schemes of a theme were not available immediately in the UI.
 2019-01-31 14:29:09 -05:00
Kris
0dfcbdeb54 ok/cancel button fix 2019-01-31 14:20:27 -05:00
Kris
3d394a6144 prettier 2019-01-31 14:06:32 -05:00
Kris
3eb000a968 UX: Overflow hidden was causing some icons to be cropped 2019-01-31 14:03:11 -05:00
Kris
94f16ba931 UX: Make button icons use lighter color instead of opacity 2019-01-31 13:59:49 -05:00
Arpit Jalan
4786b7ff81 FEATURE: when only option is "existing topic", autofocus input field 2019-01-31 11:23:04 +05:30
Jeff Wong
4763d6c9d7 FEATURE: add the show user action to the user-card-after-username plugin outlet 2019-01-30 14:56:14 -08:00
Robin Ward
bb8808985a REFACTOR: Remove a couple more self uses 2019-01-30 14:41:49 -05:00
Robin Ward
dca5486b78 REFACTOR: Prefer this over self 2019-01-30 14:29:45 -05:00
Penar Musaraj
c02e81fe01 FIX: regression with composer warnings 
Fixes composer warnings when: a) mentioning groups ("By mentioning @group, you are about to notify x people...") and b) mentioning users in a PM ("You mentioned @user but they won`t be notified...")
 2019-01-30 11:37:16 -05:00
Vinoth Kannan
096974d178 FIX: user_id attribute not found in posters array 2019-01-30 15:28:03 +05:30
Jeff Wong
fc5b2de85d FEATURE: add topic list before status plugin outlet for mobile 2019-01-29 17:15:31 -08:00
Joffrey JAFFEUX
0d0303e7ea
FIX: more resilient lookup in plugin-api (#6961) 
Ember3 is more picky about having a container being destroyed and it's easier to cause exceptions, especially in tests.

This fix has been initially created for an exception occuring in tests when running discourse-code-review and discourse-polls tests at the same time. `getCurrentUser` method body was failing as the container was destroyed.

Original  stacktrace:

```
"Error: Assertion Failed: expected container not to be destroyed
    at new EmberError (ember:2929:31)
    at assert (ember:1793:23)
    at Container.lookup (ember:17736:64)
    at PluginApi.getCurrentUser (discourse/lib/plugin-api:56:31)
    at allowUser (javascripts/discourse/initializers/init-code-review:38:29)
    at eval (javascripts/discourse/initializers/init-code-review:78:11)
    at eval (select-kit/mixins/plugin-api:86:19)
    at Array.forEach (<anonymous>)
    at eval (select-kit/mixins/plugin-api:85:44)
    at Array.forEach (<anonymous>)"
```
 2019-01-29 16:54:04 +01:00
Sam Saffron
32f9fd1e51 FIX: add autocomplete=off to composer textarea 
Somehow a plugin or some new Chrome bug is causing its heuristic to detect
our textarea for the composer as a target for address autocomplete

This is likely a chrome bug but this change is very safe regardless.
 2019-01-29 15:05:29 +02:00
Kris
f7deb52c90 FIX: Class name for external-link on customize page 2019-01-28 17:15:36 -05:00
Vinoth Kannan
62a0f88e97 FIX: More link in topic page search shouldn't navigate to full page result 2019-01-29 02:26:55 +05:30
David Taylor
aca0b32fda
FEATURE: Allow overriding text size from a different device (#6955) 
This brings the feature in line with the theme selection system
 2019-01-28 11:19:50 +00:00
Vinoth Kannan
7e4edcfae8 FIX: Convert lightbox html into proper image markdown 2019-01-27 01:21:56 +05:30
Neil Lalonde
cd3a167c63 FIX: javascript error when opening rename tag modal 2019-01-25 17:34:05 -05:00
Kris
94e2b77c5f Fix theme component name's color when theme is selected 2019-01-25 17:25:12 -05:00
Penar Musaraj
84a3da4b18 FIX: match drafts using key when deleting 
Using "sequence" when removing drafts was buggy, it would remove more than one draft from the stream sometimes.
 2019-01-25 13:55:40 -05:00
Joffrey JAFFEUX
0e1862013a
FIX: prevents race condition where the same report is loaded multiple times (#6953) 2019-01-25 19:29:45 +01:00
Joffrey JAFFEUX
7caa28cf45
FIX: ensures ordering set in tags-show queryString works at first load (#6951) 2019-01-25 16:48:20 +01:00
David Taylor
d338e54f59
FEATURE: Allow setting font size per-device using a cookie (#6947) 2019-01-25 15:06:06 +00:00
Vinoth Kannan
65caf04ddc clean up unused code 
Unused PM topic list column 'Users' is removed
 2019-01-25 20:13:54 +05:30
David Taylor
a48731e359
FEATURE: Support additional metadata in theme about.json (#6944) 
New `about.json` fields (all optional):
 - `authors`: An arbitrary string describing the theme authors
 - `theme_version`: An arbitrary string describing the theme version
 - `minimum_discourse_version`: Theme will be auto-disabled for lower versions. Must be a valid version descriptor.
 - `maximum_discourse_version`: Theme will be auto-disabled for lower versions. Must be a valid version descriptor.

A localized description for a theme can be provided in the language files under the `theme_metadata.description` key

The admin UI has been re-arranged to display this new information, and give more prominence to the remote theme options.
 2019-01-25 14:19:01 +00:00
Vinoth Kannan
2d6aa2aea2 FEATURE: Add recipient avatars in PM topic list even if they not yet replied 2019-01-25 19:41:49 +05:30
Kris
868528f862 Slight shadow adjustment to hide overflow 2019-01-24 14:49:39 -05:00
Robin Ward
a518950e52 FIX: Use context sensitive "create topic" via keyboard if possible 2019-01-24 13:20:33 -05:00
Kris
8e795d82f9 UX: Bump up notification panel width to accommodate larger text 2019-01-24 12:48:48 -05:00
Penar Musaraj
755b47b4bc UX: change topic reminder notification icon 2019-01-24 10:07:24 -05:00
Joffrey JAFFEUX
e5765fe1f5
FIX: ensures correct scroll position of textarea after autocomplete (#6942) 2019-01-24 15:19:19 +01:00
Vinoth Kannan
c88fd49591 DEV: refactor user preferences path method 2019-01-24 18:39:13 +05:30
Vinoth Kannan
b9bf751b88 FIX: link to the user preferences page is incorrect in user admin page 2019-01-24 18:31:00 +05:30
Joe
dda918f862
UX: removes width constraint in user-card badge section 2019-01-24 20:53:14 +08:00
Angus McLeod
b1297a5f5a FIX: replaces inline button message with d-button 2019-01-24 13:19:52 +01:00
Joffrey JAFFEUX
1f8ff85ff9
FIX: displays user-card when clicking on avatar of post small action (#6941) 2019-01-24 10:46:06 +01:00
Joe
22f43abb0e
UX: protection for very wide category-logo images on narrow screens 2019-01-24 17:16:18 +08:00
Kris
12df8c5c82 General style cleanup, removing unused styles 2019-01-23 21:37:39 -05:00
Kris
7d92fa3a5e Mobile SCSS cleanup and removing unused styles 2019-01-23 14:36:53 -05:00
Daniel
48c9234545 FIX: Lazy Loading: copy only present srcset 
When showing a lazy-loaded image, copy the `srcset` property only when
it is actually set. `copyImg.srcset = copyImg.srcset` is not actually a
noop but creates an empty `srcset`, changing content security rules on
the image.
 2019-01-23 14:04:43 -05:00
Joe
a9734eef81
UX: removes margins from categories in suggested topics message 2019-01-24 02:12:16 +08:00
Joffrey JAFFEUX
bd31423137
DEV: refactoring admin-logs-screened-ip-addresses (#6932) 2019-01-23 17:40:37 +01:00
Joffrey JAFFEUX
0aa049791e
DEV: refactoring admin-backups-index (#6933) 2019-01-23 17:40:24 +01:00
Joffrey JAFFEUX
60974932c4
DEV: refactoring api-keys (#6931) 2019-01-23 17:40:05 +01:00
Kris
9a594fed01 Removing unused bootstrap.scss file 2019-01-23 11:22:23 -05:00
Kris
5feeac221e Groups on user profile missing margin 2019-01-23 10:10:17 -05:00
David Taylor
afd449089f
FEATURE: Import and export themes in a .tar.gz format (#6916) 2019-01-23 14:40:21 +00:00
Joffrey JAFFEUX
d0129b85f4
FIX: stop propagating keyboard event when replying to topic/post (#6930) 2019-01-23 14:38:20 +01:00
Joe
d720215183 UX: admin badge page improvements 2019-01-23 11:29:51 +01:00
David Taylor
2e59a37687
FEATURE: List unused theme components (#6924) 2019-01-23 09:20:13 +00:00
Joe
b21266ed6f
FIX: corrects selector for move-to modal styles 2019-01-23 16:18:38 +08:00
Penar Musaraj
9886934ef5 DEV: fix some deprecated SVG icon refs 2019-01-22 14:42:00 -05:00
Kris
62adc2eb98 User admin page button height fix 2019-01-22 14:00:38 -05:00
Kris
66f6382090 FIX: Icon missing due to typo 2019-01-22 13:01:21 -05:00
Kris
f0fd875918 UX: Improving aligment within topic timer modal 2019-01-22 12:33:46 -05:00
Robin Ward
a834245683 FIX: Keep tags when switching to shared draft 2019-01-22 11:26:52 -05:00
Joffrey JAFFEUX
fc710de3ab
DEV: refactoring admin user index (#6927) 2019-01-22 16:44:55 +01:00
Joffrey JAFFEUX
31a700daf8
DEV: refactoring emoji-uploader (#6926) 2019-01-22 16:44:40 +01:00
Joffrey JAFFEUX
bce9c37f15
DEV: refactoring permalink-form (#6925) 2019-01-22 15:09:21 +01:00
Joffrey JAFFEUX
ea8373351b
DEV: refactoring ip-lookup (#6923) 2019-01-22 15:09:04 +01:00
Joffrey JAFFEUX
80d42b4ea2
icons deprecations fixes (#6920) 2019-01-22 12:02:02 +01:00
Joffrey JAFFEUX
ea0e188c8f
FIX: improves stacked-chart layout on ie11 (#6922) 2019-01-22 11:47:54 +01:00
Joffrey JAFFEUX
9148f7675b
FIX: better handling of resizing in stacked charts (#6921) 2019-01-22 11:20:50 +01:00
Joffrey JAFFEUX
7161304842
minor cosmetic improvements to charts (#6919) 2019-01-22 10:22:41 +01:00
Joffrey JAFFEUX
b1b27d9f7b
FEATURE: add total on stacked-chart tooltip (#6917) 2019-01-22 09:57:34 +01:00
Kris
fe6d571021 FIX: Alignment for small-actions, gap, removing unneeded clearfix 2019-01-21 17:57:47 -05:00
Kris
4ddc28f194 FIX: Whitespace breaks activity column in Firefox 2019-01-21 16:26:34 -05:00
Kris
8546f0020e UX: Invert pikaday png for dark themes 2019-01-21 13:47:46 -05:00
Penar Musaraj
ba5e17a7a9 FIX: IE11 layout glitches 
IE11 requires a unit on the third parameter (flex-basis) of the flex property
 2019-01-21 13:40:55 -05:00
Kris
ec71091216 FIX: Don't override user flair styles in topic map 2019-01-21 12:37:49 -05:00
Penar Musaraj
916219f48e Remove "Users" heading in wizard homepage preview 2019-01-21 11:31:00 -05:00
Joffrey JAFFEUX
3e1e9fce7e
FIX: better legend labels for stacked-charts (#6914) 2019-01-21 17:10:10 +01:00
Joffrey JAFFEUX
a9edcb2e10
fixes few icons deprecations warnings (#6915) 2019-01-21 16:56:05 +01:00
Joffrey JAFFEUX
b95165b838
FEATURE: adds a new chart report to track pageviews (#6913) 2019-01-21 15:17:04 +01:00
Joffrey JAFFEUX
52f2e0d6b9
SECURITY: fix possible XSS with badges (#6912) 2019-01-21 13:08:26 +01:00
Joffrey JAFFEUX
502b1316d0
DEV: s/this._super()/this._super(...arguments) (#6908) 2019-01-19 10:05:51 +01:00
Kris
61fff098ed minor email/whisper icon alignment fix 2019-01-18 20:59:52 -05:00
Kris
3b7ac3f6eb UX: We don't have bulk select on mobile, so we should hide the button 2019-01-18 20:26:58 -05:00
Kris
df0303c912 UX: Improve button alignment, fix invite header 2019-01-18 20:08:52 -05:00
Kris
e6e4a073a5 alignment fix due to font-size bump 2019-01-18 16:24:27 -05:00
Kris
4f897dde50 UX: Improve alignment of new post badge on mobile 2019-01-18 16:17:24 -05:00
Kris
247ab4a830 Align notification in unread education message 2019-01-18 15:40:07 -05:00
Joffrey JAFFEUX
7908a522a0
FIX: postLabel was not working for totals (#6904) 2019-01-18 17:06:43 +01:00
Penar Musaraj
f8f281cdad UI: update "latest" canvas layout in wizard 2019-01-18 09:56:39 -05:00
Joffrey JAFFEUX
b20ad9d684
FIX: since Ember 3 interceptClick was not working on buffered links (#6898) 2019-01-18 11:01:19 +01:00
Bianca Nenciu
cf6223226d DEV: Do the draft conflict check async. (#6895) 2019-01-18 15:51:56 +11:00
Penar Musaraj
2274d6d7ac FIX: refresh "/categories" on logo click (#6891) 
* FIX: refresh discovery categories on logo click

* Fix prettier offence
 2019-01-18 12:08:42 +08:00
Kris
9f52306861 Keep avatar image at native size for normal font-size, remove unneeded clearfix 2019-01-17 21:54:22 -05:00
Kris
8c5c4200ec prettier 2019-01-17 21:13:52 -05:00
Kris
5307e9337f HACK: Reduce icon jitter while scrolling with composer open in iOS 2019-01-17 21:04:05 -05:00
Kris
d5d994e24a UX: Improving user stream alignment and spacing 2019-01-17 17:29:27 -05:00
Kris
43bb16de27 Prevent header icons from overflowing with long title present 2019-01-17 16:11:40 -05:00
Kris
7401901939 UX: Badge alignment adjustments 2019-01-17 15:46:55 -05:00
Kris
3c987132cb Prevent placeholder text from being cut-off 2019-01-17 14:39:28 -05:00
Penar Musaraj
3501533a2b DEV: unpin Prettier version, apply to YAML files 
We had Prettier pinned because of https://github.com/prettier/prettier/issues/5529. Since that bug is fixed, unpinning.

Prettier now supports YAML, so this applies Prettier to all .yml except for translations, which should not be edited directly anyway.
 2019-01-17 13:05:39 -05:00
Kris
b664674d2b make smaller text size bigger 2019-01-17 12:11:31 -05:00
Vinoth Kannan
b9215ddaea FIX: Navigate to full page search when enter key used in topic 2019-01-17 22:34:23 +05:30
Kris
b9355f316a Minor size/alignment fixes for font size increase 2019-01-17 11:42:03 -05:00
Kris
675bf94133 UX: Bump up base font size 1px, add smaller text size option 2019-01-17 10:30:34 -05:00
David Taylor
880311dd4d
FEATURE: Support for localized themes (#6848) 
- Themes can supply translation files in a format like `/locales/{locale}.yml`. These files should be valid YAML, with a single top level key equal to the locale being defined. For now these can only be defined using the `discourse_theme` CLI, importing a `.tar.gz`, or from a GIT repository.

- Fallback is handled on a global level (if the locale is not defined in the theme), as well as on individual keys (if some keys are missing from the selected interface language).

- Administrators can override individual keys on a per-theme basis in the /admin/customize/themes user interface.

- Theme developers should access defined translations using the new theme prefix variables:
  JavaScript: `I18n.t(themePrefix("my_translation_key"))`
  Handlebars: `{{theme-i18n "my_translation_key"}}` or `{{i18n (theme-prefix "my_translation_key")}}`

- To design for backwards compatibility, theme developers can check for the presence of the `themePrefix` variable in JavaScript

- As part of this, the old `{{themeSetting.setting_name}}` syntax is deprecated in favour of `{{theme-setting "setting_name"}}`
 2019-01-17 11:46:11 +00:00
Joffrey JAFFEUX
740d047365
FIX: regression lead to a 404 when trying to filter user posts (#6893) 2019-01-17 11:31:23 +01:00
Kris
e7d2a0d42f UX: Larger/Largest font-sizes should be 1px larger on mobile 2019-01-16 20:59:31 -05:00
Jeff Atwood
1d4d4b81e6 remove stray chars 2019-01-16 15:05:43 -08:00
Jeff Atwood
f0999f27a7 UX: soften the "problems" alert on dashboard 2019-01-16 14:58:19 -08:00
Robin Ward
16a7102dad FIX: Ember.warn needs an id 
This way errors can be customized/silenced in the console.
 2019-01-16 14:53:13 -05:00
David Taylor
98f26bcaf5 Revert "FIX: makes click-interceptor working with touchstart (#6890)" 
This reverts commit fd2dd8d67d.
 2019-01-16 17:47:40 +00:00
Joffrey JAFFEUX
fd2dd8d67d
FIX: makes click-interceptor working with touchstart (#6890) 
Probable regression due to the removal of Modernizr.
 2019-01-16 17:56:43 +01:00
Penar Musaraj
18055f5e37 DEV: show remote theme repository URL 2019-01-16 11:09:16 -05:00
Joffrey JAFFEUX
1ac4dc5b73
FIX: makes whisper state more resilient (#6889) 
This commit also moves some logic from model to controller.
 2019-01-16 15:23:06 +01:00
Angus McLeod
54f95bb335 rm period (#6886) 2019-01-16 10:58:43 +01:00
Joffrey JAFFEUX
486df57a23
FIX: tweaking topic footer dropdowns (#6882) 
- no description on mobile for notifications
- better reason text positioning
 2019-01-16 10:27:27 +01:00
Guo Xiang Tan
f8db93df5f FIX: Consolidated like notifications links to wrong user on user page. 2019-01-16 15:55:18 +08:00
Penar Musaraj
71a69c1976 Revert "FIX: refresh topic list on logo click" 
This reverts commit 037776881b.
 2019-01-15 22:54:53 -05:00
Arpit Jalan
1591c42a06 FIX: profile picture not showing up on user admin page 2019-01-16 09:21:11 +05:30
Guo Xiang Tan
40533bc570 REFACTOR: filterBy in UserStream. 
Follow up to ebe65577ed.
 2019-01-16 10:53:44 +08:00
Guo Xiang Tan
ebe65577ed
FEATURE: Consolidate likes notifications. (#6879) 2019-01-16 10:40:16 +08:00
Penar Musaraj
037776881b FIX: refresh topic list on logo click 
Fixes a regression where, when homepage is set to "categories", clicking on logo would no longer reload topic list.
 2019-01-15 17:01:09 -05:00
David Taylor
b69e57e2f3 FIX: Prevent layout changes while images are lazy-loading 
This commit moves the temporary image to be adjacent to the original image in the DOM. Previously the temporary image was appended to the parent element. Normally this makes no difference because the temporary element has position:absolute. However, if the `:last-child` selector is being used on the parent, it can cause layout changes during loading.
 2019-01-15 17:35:55 +00:00
Gerhard Schlager
70cdb42173 FIX: Tooltip for unlisted topics wasn't shown in topic list 
The locale key had to be renamed, because this key is also used as CSS class.
The "invisible" CSS class makes the icon invisible. "unlisted" doesn't have that effect.
 2019-01-15 16:13:06 +01:00
Arpit Jalan
c4422fdc13 UX: sort admins and moderators by last seen date on /about page 
UX: only show active admins and moderators on /about page
 2019-01-15 17:26:11 +05:30
Robin Ward
f75915efa4 FIX: expandAllPinned was not resetting after visiting a category 
This resulted in a bug where if you saw a pinned topic in a category,
then went back to latest, the same topic would show an excerpt even
though it shouldn't on the latest view.

See:
https://meta.discourse.org/t/pinned-post-excerpt-no-longer-appears-after-refreshing-the-page/106222
 2019-01-14 13:02:25 -05:00
David Taylor
1ebd3dbbd0
FEATURE: Allow the base font size to be changed on a per-user basis (#6859) 2019-01-14 13:21:46 +00:00
Arpit Jalan
59e3eecfa6 FEATURE: allow staff to select existing message via ID or URL 2019-01-14 15:29:05 +05:30
Arpit Jalan
a121d40771
FIX: do not show PM topics when moving posts to an existing public topic (#6876) 2019-01-14 15:00:45 +05:30
David Taylor
49593d1a00 FIX: Fix registration dialog popup for 'full screen' social logins 
Regression following the ember3 upgrade. In addition to fixing, this commit consolidates our social registration logic into one place, and adds tests for the behaviour.
 2019-01-12 12:08:13 +00:00
Joffrey JAFFEUX
dcdcaebd0f
FIX: checkEmail was calling itself (#6878) 2019-01-12 11:12:17 +01:00
Kris
8176d26dbd UX: Reducing usage of btn-small, simplifying styles 2019-01-11 19:41:09 -05:00
Kris
e4c593f1e7 removing some dupe styles, adding button class 2019-01-11 15:41:51 -05:00
Kris
83f0afbec9 Usercards sometimes not wrapping correctly in Safari 2019-01-11 12:50:16 -05:00
Joffrey JAFFEUX
1a3655b787
DEV: s/Em/Ember (#6874) 2019-01-11 17:54:23 +01:00
Guo Xiang Tan
0fa92699e2 UX: Don't save automatically when resetting site settings in admin page. 2019-01-11 16:39:21 +08:00
Guo Xiang Tan
2956c52e57 FIX: Show title as home logo if title has been set and logo is blank. 
https://meta.discourse.org/t/default-text-logo-not-working/103936
 2019-01-11 15:46:58 +08:00
Kris
29ff184508 d60b9df fix, was too broad 2019-01-10 21:50:00 -05:00
Kris
d60b9dfba4 UX: Close button shouldn't get :visited color 2019-01-10 21:47:38 -05:00
Joffrey JAFFEUX
9f39ac8366
FIX: ember3 regression, uses model as bufferedProperty for badges (#6875) 2019-01-11 00:46:03 +01:00
Penar Musaraj
49e3a83062 FIX: minor regression when acting on queued post 2019-01-10 15:32:33 -05:00
Vinoth Kannan
0744e84604 UX: always scope the composer categories dropdown to current category 2019-01-11 01:07:23 +05:30
Vinoth Kannan
a8ff4a8a78 UX: search all categories even if category-chooser is scoped to particular category 2019-01-10 21:19:53 +05:30
Joffrey JAFFEUX
f9648de897
DEV: upgrades from Ember 2.13 to Ember 3.5.1 (#6808) 
Co-Authored-By: Bianca Nenciu <nbianca@users.noreply.github.com>
Co-Authored-By: David Taylor <david@taylorhq.com>
 2019-01-10 11:06:01 +01:00
Angus McLeod
798e98a7cc remove safari check from isAppleDevice (#6869) 2019-01-10 13:02:55 +11:00
Maja Komel
51b13ec86f FIX: show lock glyph to a user without permissions to see quote (#6854) 2019-01-10 09:48:05 +08:00
Robin Ward
312e282b6a FIX: Apply classes when lazily loading images 
If an image had extra classes (for example oneboxes), then while loading
the copy of the image would lose those classes and look differently
until the image had loaded fully.

This fix copies the classes while loading.
 2019-01-09 12:56:25 -05:00
Jeff Wong
439eff4709 revert null checking around interceptClick 2019-01-09 09:44:30 -08:00
David Taylor
2d3e50ae7c FIX: Match default <code> padding to highlightjs padding 
Without this, the height of posts changes once highlightjs is lazy-loaded, potentially causing scrolling issues
 2019-01-09 17:36:51 +00:00
Robin Ward
8b3ddcf646 FIX: Add topic status to flagged topics list 
Previously at a glance it was impossible to tell if a topic was closed
before digging deeper.
 2019-01-09 10:59:35 -05:00
Vinoth Kannan
1f12a377fa minor refactoring of card-contents-base mixin 2019-01-09 19:32:30 +05:30
Vinoth Kannan
b7c501bf52 FIX: full page search results are unclickable 
data-ember-action can have empty value in favor of data-ember-action-ID attribute
 2019-01-09 10:59:37 +05:30
Zach Whitehead
2748822576 FEATURE: Remove option for Google Plus sharing (#6864) 
* Remove option for Google Plus sharing

* remove google+ share translations
 2019-01-09 10:17:50 +08:00
Joffrey JAFFEUX
25269a37aa FIX: do not show #uncategorized in category drop if setting is disabled (#6856) 2019-01-09 09:44:24 +08:00
Jeff Wong
09cbd08c64 FIX: ensure ember transitions do not get hijacked by discourse intercept-click 
explicit null checks as a blank string evaluates to false
 2019-01-08 15:38:13 -08:00
Jeff Wong
d75262046d Revert "FIX: ensure ember transitions do not get hijacked by discourse intercept-click" 
This reverts commit a2cb2f2366.
 2019-01-08 15:37:10 -08:00
Jeff Wong
a2cb2f2366 FIX: ensure ember transitions do not get hijacked by discourse intercept-click 
explicit null checks as a blank string evaluates to false
 2019-01-08 15:09:50 -08:00
Kris
cfb8e157a2 Fixing tag alignment 2019-01-08 16:25:11 -05:00
Kris
4a01fee41b UX: use default H2 and H3 sizes on user profiles for better hierarchy 2019-01-08 13:07:29 -05:00
David Taylor
fe20cb4b56 FIX: Enforce a fixed height on generic oneboxed videos 
This prevents 'jumping' as the video loads. This change will require posts to be rebaked before it takes effect.
 2019-01-08 16:22:03 +00:00
Joe
a2d1babac6
UX: tag container should wrap if there's a large number of tags 2019-01-08 23:33:47 +08:00
Joe
3457395f75
UX: moves topic-list excerpts out of category / tag div 2019-01-08 14:55:15 +08:00
Arpit Jalan
4ebf170fe4 DEV: no need for conditional redirect in invites 2019-01-08 11:34:26 +05:30
Guo Xiang Tan
ef72a9a1fe UX: Default search log index to yearly. 2019-01-08 13:40:38 +08:00
Arpit Jalan
e0bc82657b FIX: better accept invite flow when user is invited via a link 2019-01-07 14:22:08 +05:30
Joe
effb3262a1
UX: no need for margin if participants is first-child 2019-01-06 00:11:53 +08:00
Joe
3a9fea4409
align and truncate header tags and participants 2019-01-05 23:09:44 +08:00
Vinoth Kannan
046e4ab413 FIX: Improve topic small header alignment in mobile 
Force topic-header-extra height to 20px
 2019-01-05 14:06:06 +05:30
Vinoth Kannan
3589f3e023 UX: Display user and group cards over the small PM header 2019-01-05 04:58:56 +05:30
Vinoth Kannan
aba18a42a7 UX: Improve PM small header alignment with recipient avatars 2019-01-05 03:51:15 +05:30
Régis Hanol
5ac1e3d4cd FIX: emojis are hard 🤷 2019-01-04 17:21:16 +01:00
Penar Musaraj
f400830575 DEV: Remove old _firefoxPastingHack 2019-01-04 11:14:35 -05:00
Régis Hanol
95e5f8380d FEATURE: Allow plugins to add custom emoji translations 
FIX: buildTranslationTree was erroring when translations overlapped (ie. ":-)" and ":-))")
FIX: emoji translations wasn't working properly when translations overlapped
 2019-01-04 15:27:46 +01:00
David Taylor
5bf16d7d10 FEATURE: Topic timer for bumping a topic in the future 2019-01-04 13:08:04 +00:00
Joe
3a04e04ccb UX: excerpts don't wrap on IE11 (#6847) 2019-01-04 15:11:42 +11:00
Kris
a2f1d47506 Slightly better alignment of PM participants in header 2019-01-03 22:47:56 -05:00
Sam
d0f38dbb07 FIX: image rendered temporarily in wrong position while loading 
Previously non lightboxed images would render in the wrong spot while loading.

We assumed the image we were rendering while loading was at 0,0 position.
This is not the case on non-lightboxed images cause they have no surrounding
DIV.
 2019-01-04 11:50:44 +11:00
Vinoth Kannan
385829d7be FEATURE: Display error message when category restriction is applied for tags 2019-01-04 00:29:13 +05:30
Penar Musaraj
a953b71797 FEATURE: allow custom HighlightJS languages 
Adds pluginApi function that allows themes and plugins to register languages for HighlightJS.
 2019-01-02 19:07:36 -05:00
Kris
4af7471ead Better contrast ratio match between dark and light themes 2019-01-02 17:54:22 -05:00
Jeff Wong
49fbedc445
FIX: make full height menu and cloak respect custom headers (#6845) 2019-01-02 14:18:14 -08:00
Sam
0c11caf796 UX: remove gray background from lighbox 
This avoids a 3 way transition when loading images

- grey
- ultra low res
- full image

Instead we go

- ultra low res
- full image
 2019-01-03 08:16:33 +11:00
Jeff Wong
e8a75628fd Revert "FIX: make full height menu and cloak respect custom headers" 
This reverts commit a61d9deba1.
 2019-01-02 11:51:03 -08:00
Gerhard Schlager
dc477d1228 FIX: "Toggle topic bump" wasn't visible for TL4 users 2019-01-02 20:16:55 +01:00
Jeff Wong
a61d9deba1 FIX: make full height menu and cloak respect custom headers 2019-01-02 11:05:44 -08:00
Gerhard Schlager
c30996129f FEATURE: Allow TL4 users to reset bump date 2019-01-02 16:57:05 +01:00
Vinoth Kannan
0884cd218d UX: Add group name next to PM recipient avatar 
Also changed group icon color and did minor refactoring
 2019-01-02 15:26:42 +05:30
David Taylor
27ed60bad0 FIX: Quote selection in IE11 2018-12-31 13:54:05 +00:00
Arpit Jalan
70fdc10365
FEATURE: move posts to new/existing PM (#6802) 2018-12-31 17:17:22 +05:30
Saurabh Patel
0fca3205b5 FIX: show error msg on grant badge if message available from backend (#6801) 2018-12-31 10:46:39 +01:00
Arpit Jalan
1381dc603d UX: show generic message when reloading 'activation email resent' page 2018-12-31 13:12:37 +05:30
Joe
6fb421312e
UX: aligns categories and tags in topic lists 
History:

https://meta.discourse.org/t/minor-visual-weirdness-on-topic-listing-category-and-tags/105268
 2018-12-31 14:38:33 +08:00
Joe
55d745f03b
UX: header needs a bit of padding on narrow screens 
A bit of history

https://meta.discourse.org/t/header-on-responsive-window/105204
 2018-12-31 14:33:02 +08:00
Vinoth Kannan
021f11b68e FEATURE: Display avatars of PM recepients in small topic header when scrolling down 2018-12-30 20:10:40 +05:30
Joffrey JAFFEUX
e7cf642b1f
FIX: reports issues with ie11 (#6828) 2018-12-28 21:32:07 +01:00
Joffrey JAFFEUX
9a8db2748a
FIX: composer css fixes for ie11 (#6827) 2018-12-28 20:52:21 +01:00
Joffrey JAFFEUX
f1269fa807
FEATURE: Add Top Uploads report (#6825) 
Co-Authored-By: I am very Pro-Grammer. <khalilovcmded@users.noreply.github.com>
 2018-12-28 20:48:54 +01:00
Joffrey JAFFEUX
608abd4c08
FIX: uses flex: 1 0 0; instead of flex: 1; for better browser compat (#6826) 2018-12-28 20:21:32 +01:00
Joffrey JAFFEUX
7b15b87cf5
FIX: better left/right positioning in select-kit components (#6824) 2018-12-28 19:46:31 +01:00
Joffrey JAFFEUX
0f09cb50e9
FIX: less fancy pages computation for browser compatibility (#6823) 2018-12-28 19:07:29 +01:00
Penar Musaraj
4f6ca66df5 FIX: routeToTag mini-fix for IE11 
skip "a.host" for IE11 since IE11 does not support URL interface
 2018-12-28 11:49:51 -05:00
Penar Musaraj
fdfb7ed764 FIX: Limit previous IE SVG click event fix 
Fixes issues with clicking SVG icons in Safari, IE11, Edge
 2018-12-28 10:18:53 -05:00
Joe
74f0bd08c0
UX: removes unnecessary margin in header tag wrapper 
This margin is not needed and doesn't exist in the mobile view. 

It causes a bit of a problem in desktop topics with no categories and more prominently in PMs in the desktop view.

There's a small TODO here where the rest of the extra-info-wrapper styles should all be moved to header sylesheets.
 2018-12-28 21:31:41 +08:00
Joffrey JAFFEUX
942114b34c
FIX: optimize collapse/expand select-kit codepath (#6818) 2018-12-27 23:38:01 +01:00
Joffrey JAFFEUX
695894d458 FIX: delete dataset doesn’t work on safari 2018-12-27 06:49:49 +02:00
Vinoth Kannan
2076f371b3 FIX: Hashtags should work for non-english characters 2018-12-26 22:12:40 +05:30
Joffrey JAFFEUX
0402f0f357
UX: new site setting to define activity metrics displayed on dashboard 2018-12-26 10:29:07 +01:00
Sam Saffron
69aa8f18c2 FEATURE: allow for custom excerpt BBCODE 
This allows fidelity in controlling excerpt (text that shows up when you pin a topic or link to it externally):

```
I am some text

[excerpt]
This is some **custom** markdown that should be the excerpt
[/excerpt]

More text
```

Previous solution relied on DIVs, unfortunately DIVs do not play well,
by design with mixing markdown unless you have a preceding newline eg:

```
<div class='hello'>

this will be treated properly as markdown

</div>
```

This extra newline is not desirable.

I am also considering adding

```
[div class=excerpt]
[/div]
```

This would offer lots of flexibility to themes and plugins that do not want the extra annoying newline.
 2018-12-25 17:02:28 +02:00
Arpit Jalan
1e2b81991f fix the build 2018-12-25 10:27:51 +05:30
Jeff Atwood
a74e49c87c use proper typographical × instead of x 2018-12-24 20:33:17 -08:00
Vinoth Kannan
b3df4bee9c FIX: Hide group membership request button for existing members 2018-12-24 13:49:05 +05:30
Saurabh Patel
f4d8a330c3 Merge pull request #6761 from mrfinch/saurabh/show-popup 
FIX:show popup before bulk invite
 2018-12-21 21:36:17 +01:00
Robin Ward
0e710dc573 Improvements to Lazy Loading 
- Now applied to all images over 150x150px

- Stores the width and height in the WeakMap rather than using
percentages for accuracy

- When oneboxed images are hidden, they are given a subtle border for better
visibility.

- Don't apply when in the composer. Causes flickering.
 2018-12-21 11:31:27 -05:00
Robin Ward
a2ae67509d Don't use getAttribute if we don't need to 2018-12-20 16:41:04 -05:00
Kris
816acc6984 Improving color contrast of $danger-low for dark themes 2018-12-20 14:46:13 -05:00
Penar Musaraj
28283c2396 FIX: Workaround for Edge issue with clicks on SVGs 
- Related Edge issue at https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/10583086/
 2018-12-20 11:13:55 -05:00
Sam Saffron
400eea4d13 UX: show lazy loaded images while they are downloading 
Also shows fuzzy image right away prior to it being downloaded
 2018-12-20 22:04:30 +08:00
Joe
d7466156ae UX: adds missing wizard icons 
With our recent move to SVG icons, the font file does not work in the wizard. I've opted for path2D, which accepts an SVG path

Path2D is not supported by IE11 but the chances of admins running the wizard on IE11 are practically none. 

https://caniuse.com/#feat=path2d
 2018-12-20 14:55:40 +02:00
Rishabh
3d2c72dd33 UX: Switch placeholder to an SSH url if importing a private theme 2018-12-20 17:01:50 +05:30
Vinoth Kannan
dc292d4598 FIX: Use one-way binding to prevent unnecessary updates in site.periods 2018-12-20 03:39:05 +05:30
Joffrey JAFFEUX
e655e1863f
UX: Adding reports dashboard tab, new layout, report descriptions (#6790) 
Co-Authored-By: Kris  <shout@k-ris.com>
 2018-12-19 14:44:43 +01:00
Penar Musaraj
f5c4ab0573 Add category link renderer to plugin API (#6787) 
* Add category link renderer to plugin API

- lets themes/plugins override the category link display

- planning to use this in a "category icons" theme component

* small code review fix

* Code review refactor
 2018-12-19 10:26:09 +01:00
Bianca Nenciu
7050ce4638 FIX: Bypass draft check when switching to shared draft. (#6782) 2018-12-19 10:25:33 +01:00
Maja Komel
0ce5f05b2a FIX: hide emails on admin user list for moderators (#6781) 2018-12-19 10:24:57 +01:00
Kris
41e06efb94 Adding padding to mobile that was removed in 3710b016 2018-12-18 22:20:02 -05:00
Kris
3710b01660 Header was 16px too narrow due to border-box and padding 2018-12-18 20:38:43 -05:00
Kris
5b9c1bcf59 User page button style fix 2018-12-18 20:36:42 -05:00
Neil Lalonde
6774b64aef FEATURE: add /conduct as an alias for /guidelines 2018-12-18 16:40:24 -05:00
Robin Ward
662cfc416b FEATURE: Show a blurry preview when lazy loading images 
This generates a 10x10 PNG thumbnail for each lightboxed image.
If Image Lazy Loading is enabled (IntersectionObserver API) then
we'll load the low res version when offscreen. As the image scrolls
in we'll swap it for the high res version.

We use a WeakMap to track the old image attributes. It's much less
memory than storing them as `data-*` attributes and swapping them
back and forth all the time.
 2018-12-19 01:57:30 +08:00
Gerhard Schlager
32784ad11a FIX: Disable multipart backup uploads to S3 
Multipart upload from within the browser result in corrupt files on S3.
 2018-12-18 16:01:15 +01:00
Gerhard Schlager
081aa6ad2b UX: Use new FA5 icons on Backups tab 2018-12-18 16:01:14 +01:00
Vinoth Kannan
341a6bd78a
REFACTOR: Calculate CTR in SearchLog model and hide unique column (#6791) 2018-12-18 19:13:46 +05:30
Maja Komel
98d09c90ac Current user serializer groups (ef7f84b follow-up) 2018-12-18 09:05:45 +01:00
Kris
2a518c88d0 Prevent bullet badge from shrinking/growing as flex item 2018-12-17 21:05:32 -05:00
Kris
7d7b6baab9 Topic-list category width restriction no longer needed 2018-12-17 21:01:04 -05:00
Vinoth Kannan
ece44a44f8 UX: Change default date range of dashboard trending search report to a month 2018-12-18 03:00:30 +05:30
Bianca Nenciu
f0027961c7 FIX: Properly reset controller of admin-user-index. (#6760) 2018-12-17 15:28:29 +01:00
Joffrey JAFFEUX
22cea9ce90
FIX: adusts select-kit position even if not expanded (#6785) 2018-12-17 12:29:51 +01:00
Joffrey JAFFEUX
6ee3900791
FIX: ensures nothing is triggering rendering loop in after render (#6784) 2018-12-17 12:15:03 +01:00
Gerhard Schlager
1a8ca68ea3 FEATURE: Improve backup stats on admin dashboard 
* Dashboard doesn't timeout anymore when Amazon S3 is used for backups
* Storage stats are now a proper report with the same caching rules
* Changing the backup_location, s3_backup_bucket or creating and deleting backups removes the report from the cache
* It shows the number of backups and the backup location
* It shows the used space for the correct backup location instead of always showing used space on local storage
* It shows the date of the last backup as relative date
 2018-12-17 11:35:11 +01:00
Maja Komel
040ddec63d Fix avatar flair styles 2018-12-17 10:44:34 +01:00
Saurabh Patel
ed1a309fe4 FIX: use new key for delete topic to make it lowercased as all other buttons label around it (#6778) 2018-12-17 10:55:19 +08:00
Joffrey JAFFEUX
d803dfc14a
FIX: makes more resilient select-kit positioning (#6776) 2018-12-15 16:23:23 +01:00
Kris
6213e020e6 Improving usercard badge alignment 2018-12-14 22:16:18 -05:00
Penar Musaraj
a19f69590a DEV: add "topic-list-before-relative-date" plugin outlet 2018-12-14 10:39:22 -05:00
Kris
2f70bd83a3 Increase contrast of pinned excerpt for dark themes 2018-12-14 10:04:44 -05:00
Joffrey JAFFEUX
03014b0d05
FEATURE: adds security tab to dashboard (#6768) 
This commit also includes the new staff_logins report
 2018-12-14 13:47:59 +01:00
Maja Komel
9f89aadd33 FIX: delete all posts in batches without hijack (#6747) 2018-12-14 11:04:18 +01:00
Guo Xiang Tan
05104600ea FIX: Incorrect translation key on admin search logs. 2018-12-14 17:12:33 +08:00
Kris
6553744e50 Fixing topic status alignment in search 2018-12-13 21:49:43 -05:00
Kris
6cbcd58603 Lighten lazyload placeholder background 2018-12-13 15:38:33 -05:00
Joffrey JAFFEUX
afdd244486
UX: removes superfluous posters column header (#6765) 2018-12-13 21:29:00 +01:00
Kris
60189e8c92 Mobile alignment fixes 2018-12-13 15:26:52 -05:00
Joffrey JAFFEUX
bcf4a17751
FIX: apply original margin-bottom to fix position placeholder (#6764) 2018-12-13 18:21:12 +01:00
Joffrey JAFFEUX
5cb99d08ed
FIX: define actions on connector class early (#6763) 
This would prevent failure with connectors templates defining actions as closures. In this case action existence is checked at compile time and not runtime.
 2018-12-13 15:43:30 +01:00
Joe
8ef2085585
UX: increase selector specificity so that "inline" lightboxes in quotes don't get backgrounds 
When a quote is not expanded and it contains lightboxes, those lightboxes are not displayed and instead we show a link that looks like this `[image_title]` 

These still have the lightbox CSS class and so they still get the backgrounds we add to lightboxes while they load. Increasing the selector specificity prevents that from happening.
 2018-12-13 15:17:08 +08:00
Kyle Zhao
92df7b212c rename visible to visibleSiteSettings 2018-12-13 13:00:13 +11:00
Kyle Zhao
c9279a118e FIX: always show filtered site settings 2018-12-13 13:00:13 +11:00
Joffrey JAFFEUX
793f1274d1
FIX: makes charts more resilient to resizing (#6758) 2018-12-12 11:11:56 +01:00
Joffrey JAFFEUX
3a799ed922
FEATURE: Check if draft exists before starting a new one (#6755) 
Co-Authored-By: Bianca Nenciu <nbianca@users.noreply.github.com>
Co-Authored-By: zogstrip <regis@hanol.fr>
 2018-12-12 10:21:51 +01:00
Sam
0ca61242b8 FEATURE: polyfill intersection observer for IE11 / iOS Safari 
This feature is used for defer loading of images and in future for post cloaking

This gives us a polyfill so we can safely use the feature in problem browsers

The polyfill supports "polling" but it does not appear we need it yet.

If we discover anything odd here, consider setting poll interval per:

https://github.com/w3c/IntersectionObserver/tree/master/polyfill

```
var io = new IntersectionObserver(callback);
io.POLL_INTERVAL = 100; // Time in milliseconds.
```

Keeping the mutation observer cause we often mutate the DOM
 2018-12-12 15:36:08 +11:00
Kris
6d353a1e47 Alignment & spacing fix for quote controls 2018-12-11 21:17:31 -05:00
Robin Ward
6797a710aa FEATURE: Lazily Load Images as they scroll into the viewport. 
This feature uses the Intersection Observer API

https://developer.mozilla.org/en-US/docs/Web/API/Intersection_Observer_API

It should be compatible with all modern browsers. Non-Edge IE is *NOT*
supported, so in that particular browser images are loaded by default.
 2018-12-12 10:12:49 +11:00
Jeff Wong
5358f25fc6 FIX: Support RTL languages in header menu 2018-12-11 10:33:56 -08:00
Jeff Wong
d2569f8e77 make linter happy 2018-12-11 09:41:40 -08:00
Jeff Wong
71d8807fec
Full height swipe-able menus (#6566) 
* Feature: Full height swipe enabled menus

support pan events on iphone
 2018-12-11 09:15:20 -08:00
Kris
8c227715ae $primary-high contrast reduction for dark themes 2018-12-11 10:08:00 -05:00
Kris
4cc0a3503b Adding space between badges for medium-sized viewports 2018-12-11 09:45:49 -05:00
David Taylor
c7c56af397
FEATURE: Allow connecting associated accounts when two-factor is enabled (#6754) 
Previously the 'reconnect' process was a bit magic - IF you were already logged into discourse, and followed the auth flow, your account would be reconnected and you would be 'logged in again'.

Now, we explicitly check for a reconnect=true parameter when the flow is started, store it in the session, and then only follow the reconnect logic if that variable is present. Setting this parameter also skips the 'logged in again' step, which means reconnect now works with 2fa enabled.
 2018-12-11 13:19:00 +00:00
Maja Komel
2ee2e5c981 UX: fix cropped image thumbnails 2018-12-11 12:23:39 +01:00
Sam Saffron
bb4ef644bf UX: reduce show dismiss.. at top of unread/new to 15 
Previously we would require 30 unread or new topic to show the button at the top.
 2018-12-11 14:11:54 +11:00
Kris
73d2fc194d UX: More consistent category lock and topic-status styles 2018-12-10 16:06:26 -05:00
David Taylor
071bd15463 FIX: Redirect to default homepage when visiting /login 
Previously this was hard-coded to redirect to `/latest`
 2018-12-10 15:39:05 +00:00
Joffrey JAFFEUX
e06a8980fb
FIX: category-drop initial state was incorrect (#6743) 2018-12-10 14:05:00 +01:00
Penar Musaraj
7f361a546e UX: Add styling for updated twitter status icons in onebox 
Minor adjustments needed by onebox version 1.8.69
 2018-12-09 21:58:02 -05:00
Kris
c84b837d50 category badge alignment fix 2018-12-08 22:33:11 -05:00
Gerhard Schlager
0f41770547 Make Danger happy by running prettier 2018-12-08 02:59:09 +01:00
Kris
050c02228e UX: Globally dim categories slightly 2018-12-07 20:01:38 -05:00
Penar Musaraj
67450ba402 UX: when composer is minimized, let user open composer in regular size instead of full screen 2018-12-07 17:45:13 -05:00
Jeff Wong
ccd80a8b14 update png assets for push notification images 2018-12-07 14:00:39 -08:00
Kris
b26d0f20cc Fixing slight misalignment of login/signup buttons 2018-12-07 13:56:54 -05:00
Kris
d16a4b895f only dim categories, not all topic stats per 547eaa6 2018-12-07 13:35:57 -05:00
Kris
98c18f8349 button and alignment fixes for mobile user page 2018-12-07 12:34:37 -05:00
Kris
547eaa6060 UX: Dim visited post info along with title 2018-12-07 11:09:56 -05:00
Kris
031c252cd3 Slight alignment follow-up to db32d29 2018-12-06 20:01:38 -05:00
Kris
db32d29eaa UX: Refactoring topic statuses for consistent icon sizes & colors 2018-12-06 19:22:04 -05:00
Penar Musaraj
06d1b19ca2 FIX: Refactor lightbox mobile icon 
- Fixes a performance issue on a site with lots of images in posts

- turns out that "filter: invert(100%)" performs very poorly on Safari/iPhone

- also disables transition on the element on mobile
 2018-12-06 15:32:26 -05:00
Kris
b54b4d05c5 UX: improve code highlighting diffs for dark themes 2018-12-06 10:54:30 -05:00
Gerhard Schlager
4300ac0f4a UX: Show smaller Emojis within some HTML elements 2018-12-06 15:13:16 +01:00
Xiao Guan
7ec124fc89 FEATURE: Improved deprecation warnings (#6722) 
* FEATURE: Discourse.deprecate can report version

* Ember counterpart for deprecation
 2018-12-06 11:38:01 +00:00
Maja Komel
1d649e147b FEATURE: show avatar flair on group, badges and directory pages (#6732) 2018-12-06 12:18:52 +01:00
Kris
a88f931d6f UX: Moving categories under topic title in topic list, removing category column (#6731) 
* Starting to remove category column from topic list

* stacked nav alignment adjustment

* Revert "stacked nav alignment adjustment"

This reverts commit 98800c7058.

* remove comment

* removing function
 2018-12-05 16:12:26 -08:00
Bianca Nenciu
a8e8473ea5 DEV: Apply code review. 2018-12-05 21:58:55 +01:00
Bianca Nenciu
79d987e483 FEATURE: Show autocomplete when enable_inline_emoji_translation is true. 2018-12-05 21:58:55 +01:00
Bianca Nenciu
e9bbdef156 FEATURE: Add support for inline emoji translation. 2018-12-05 21:58:55 +01:00
Bianca Nenciu
0c88052641 UX: Wrap pre element. 2018-12-05 21:56:18 +01:00
Bianca Nenciu
b585f7f336 DEV: Apply code review. 2018-12-05 21:56:18 +01:00
Bianca Nenciu
56890efd7a FEATURE: Add 'Advanced Test' for admin panel. 2018-12-05 21:56:18 +01:00
David Taylor
8aff99761a FIX: Ignore query parameters when displaying counter on internal links 
This matches the server-side behaviour, so that the links display counters correctly
 2018-12-05 18:29:54 +00:00
Guo Xiang Tan
978f0db109 SECURITY: Require groups to be given when inviting to a restricted category. (#6715) 2018-12-05 16:43:07 +01:00
Kyle Zhao
97e6e3b133 DEV: duplicate and unreachable code after return 2018-12-05 09:17:20 -05:00
Vinoth Kannan
d33d031742
FEATURE: Filter topic and post web hook events by tags (#6726) 
* FEATURE: Filter topic and post web hook events by tags

* Add a spec test with unmatched tags
 2018-12-05 14:44:06 +05:30
Vinoth Kannan
ec26a59eac FIX: variable name typo in subcategory image 2018-12-05 10:41:06 +05:30
Kris
e0aac75607 Restrict width of category heading to prevent mobile overflow 2018-12-04 19:01:27 -05:00
Kris
28ddaf80d2 Adding max-width to category logos 2018-12-04 13:01:27 -05:00
Joe
72bd388ff7
UX: truncate long topic tiles to prevent badges and date from wrapping 2018-12-04 15:27:23 +08:00
Sam
5c17e46274 FEATURE: allow advanced specification of excerpts for posts 
Previously users could control excerpt with `<span class='excerpt'>`
in Markdown, this is somewhat limited for plugins that need to define this
across a section. This adds support for DIV as well
 2018-12-04 15:13:34 +11:00
Penar Musaraj
56948896ff UX: replace FA5 compress/expand icons 
Adds a new SVG sprite file that contains non-FontAwesome 5 icons to our subset.

Adds the FontAwesome 4.7.0 icons for expand / collapse.
 2018-12-03 22:29:20 -05:00
Penar Musaraj
923692d45a FIX: tooltip regression in admin dashboard 
- adds registerHoverTooltip in tooltip qunit test
 2018-12-03 11:15:31 -05:00
Maja Komel
142361d6da FIX: don't steal focus when text in editor is replaced (#6712) 2018-12-03 09:49:17 +01:00
Sam
cc04c86859 UX: do not restrict width of category image, only height 
This was a recent visual regression which caused a fair amount of pain.
Previously we only restricted height
 2018-12-03 09:35:16 +11:00
Kris
26e9b628b8 post-infos alignment fix 2018-11-30 21:31:36 -05:00
Kris
a113777003 Extra margin isn't needed on mobile 2018-11-30 19:49:26 -05:00
Penar Musaraj
bbd33de05b FIX: lightbox expand icon on mobile 2018-11-30 14:35:45 -05:00
Penar Musaraj
7dec963f2e FIX: add vkontakte icon alias 2018-11-30 08:50:38 -05:00
Arpit Jalan
40f10855c6
FIX: defer flags (only) when handling a flag and deleting replies (#6702) 2018-11-29 22:44:18 +05:30
Maja Komel
4a8f21d387 FIX: prevent minimum_required_tags on category being set to null (#6703) 
* FIX: prevent minimum_required_tags on category being set to null

* add migration for NOT_NULL constraint for minimum_required_tags

* add specs
 2018-11-29 18:10:14 +01:00
Penar Musaraj
5b6c1b1670 SCSS refactoring 
followup on c388cac
 2018-11-29 12:02:11 -05:00
Joffrey JAFFEUX
4f24d7dec8
FIX: more resilient whisper state between composer states (#6687) 2018-11-29 16:16:34 +01:00
Joffrey JAFFEUX
8da8f5d0f7
FIX: call onSelect plugin callbacks for noop rows (#6682) 2018-11-29 15:56:19 +01:00
Joffrey JAFFEUX
4c7dfed32e
FIX: error with tags enabled and no tags created (#6701) 2018-11-29 10:39:09 +01:00
Vinoth Kannan
5db50d6cdc UX: Use aspect ratio to calculate width and height precisely 
Followup on 1da265d
 2018-11-29 09:32:03 +05:30
Penar Musaraj
c388cacb81 UX: Style group flair in /groups same as in topic avatars 2018-11-28 16:02:49 -05:00
Penar Musaraj
6568832235 FIX: map discord/patreon FA5 icons for login buttons correctly 2018-11-28 14:36:36 -05:00
Kris
6027e7ba3d FIX: Restrict logo width for small screens 2018-11-28 13:27:56 -05:00
Saurabh Patel
49c3cf9c75 UX: Topic stats were hard to translate 2018-11-28 14:25:22 +01:00
Sam
912a7105d2 DEV: polyfill Object.values and use where needed 
We now have polyfills for `values` IE and `entries` IE

This commit uses values where appropriate to eliminate an extra lookup
This simplifies the code a bit.

Followup to: 7f089f07a7
 2018-11-28 10:07:05 +11:00
Sam
3cb88bc566 DEV: Run file through prettier 
We only alert on .js.es6 this is a js file so it is bypassed
 2018-11-28 10:03:54 +11:00
Joffrey JAFFEUX
7f089f07a7
FIX: better fix for #ca84c06 (#6684) 2018-11-27 16:12:07 +01:00
David Taylor
f993aca363 FIX: Fix editing built-in badges after removing _.include 
We want to send the unprotected fields to the server. Corrects 4c8cfe0f
 2018-11-27 15:01:02 +00:00