Vinoth Kannan
27e7f2bee0
DEV: call 'enqueue_hooks' method only if active webhooks exist
2019-02-19 12:43:08 +05:30
Vinoth Kannan
f2c3415548
FIX: Should not generate payload until active webhooks are exist
2019-02-19 12:23:42 +05:30
Guo Xiang Tan
8cd4ceba49
DEV: Remove unnecessary Sidekiq.unpause!
during backup.
2019-02-19 14:01:13 +08:00
Guo Xiang Tan
adbc87857e
DEV: Fix randomly failing test.
...
Even if a thread is alive in the loop check, it may be dead by the
time `Thread#wakeup` is called on it.
2019-02-19 13:34:52 +08:00
Sam Saffron
83f13ecf82
FEATURE: bump onebox dependency
...
- Adds support of kaltura oneboxes
- Adds support for typeform oneboxes
2019-02-19 15:22:43 +11:00
Guo Xiang Tan
bf21ebaecc
DEV: Allow custom value when pausing sidekiq to aid in debugging.
...
Sometimes, it is useful to know what caused Sidekiq to be paused.
2019-02-19 10:55:53 +08:00
Guo Xiang Tan
c29076152d
PERF: Reduce hit to Redis server when keeping a site in reaonly mode.
2019-02-19 10:29:08 +08:00
Guo Xiang Tan
86a2172bda
DEV: Fix heisentest.
...
Unpause sidekiq before clearning up all threads.
2019-02-19 08:21:51 +08:00
Kris
4f5aebc338
UX: reduce subcategory badge spacing
2019-02-18 19:04:36 -05:00
Joffrey JAFFEUX
c08b2ddecf
FIX: stricter matching on local-dates ( #7023 )
2019-02-18 22:39:45 +01:00
Gerhard Schlager
08ae73f868
Fix typo
2019-02-18 16:51:57 +01:00
Gerhard Schlager
99ad61afb7
FEATURE: Trigger an event after a backup restore
2019-02-18 11:48:03 +01:00
Arpit Jalan
50f833def0
fix the build
...
JsPrettier on Sublime was failing because: https://github.com/jonlabelle/SublimeJsPrettier/issues/157#issuecomment-458175837
2019-02-18 11:52:11 +05:30
Arpit Jalan
dc2776bcdd
FIX: do not show "move to new PM" option to moderators
2019-02-18 11:35:00 +05:30
Jeff Atwood
052eaed16a
lighten embed blockquote style for consistency
2019-02-17 21:00:46 -08:00
Jeff Atwood
dfba36fdca
remove bgcolor from embed quotes for consistency
2019-02-17 20:57:27 -08:00
Arpit Jalan
a960cbd97f
fix the build ❤️
2019-02-18 10:00:17 +05:30
Arpit Jalan
7cb194f2db
Add more specs for word watcher service.
2019-02-18 09:55:16 +05:30
Sam
0e6d0b0f8e
FEATURE: always update docker image for dev prior to launching
...
Previously people could stay stuck on old dev images, this ensures they
are always on latest when booting
2019-02-18 13:12:00 +11:00
Guo Xiang Tan
7da7a30e02
PERF: Restore exists?
in favor of blank?
.
...
Regression from dcd7b92532
.
2019-02-18 10:04:21 +08:00
Gerhard Schlager
24369a8166
Improve phpBB3 importer
...
* Log errors when mapping of posts, messages, etc. fails
* Allow permalink normalizations for old subfolder installation
* Disable importing of polls for now. It's broken.
2019-02-17 23:20:20 +01:00
Gerhard Schlager
8d5dfe1e01
FIX: Don't import parts of the email address as name
2019-02-17 22:59:18 +01:00
David Taylor
f04471e422
REFACTOR: Proxy letter avatars in rails instead of nginx
...
Co-authored-by: Sam Saffron <sam.saffron@gmail.com>
Co-authored-by: David Taylor <david@taylorhq.com>
This gives more control over the request. In particular we can easily
lookup DNS dynamically, instead of only upon NGINX startup.
Previously, NGINX was looking up IP for the letter avatar service and
caching the CDN IP address, this caused issues if CDN changed IP, in
which letter avatars would be broken till a container restarted.
NGINX config has been updated to add caching. This change will require
a container rebuild.
The proxy will now function in development environments, so the patch
for `letter_avatar_proxy` has been removed.
2019-02-18 08:46:56 +11:00
Bianca Nenciu
944f8249a3
FIX: Add missing translation. ( #7014 )
2019-02-18 08:28:32 +11:00
Simon Cossar
a76d6eb186
Replace 'topics' with 'messages' in group notification level copy ( #7013 )
2019-02-15 16:08:37 -08:00
Gerhard Schlager
b0862bd15d
FIX: Push notifications could fail with UnauthorizedRegistration
...
The webpush gem by default sets the expiration date of the JWT token to exactly 24 hours in the future. That's not really needed because the token isn't reused. And it might cause UnauthorizedRegistration if the server's clock isn't 100% correct, because the maximum allowed value is 24 hours.
2019-02-15 21:12:09 +01:00
Gerhard Schlager
17f1a76570
FIX: Delete push subscription on MismatchSenderId error
...
This should prevent repeated MismatchSenderId warnings when the VAPID keys have changed.
2019-02-15 21:12:09 +01:00
peterlamber
159dd69fcb
UX: make adding permissions more visible and intuitive to click. ( #6999 )
2019-02-15 12:01:10 -05:00
Arpit Jalan
99c6db21e6
FEATURE: allow blocking emojis ( #7011 )
...
https://meta.discourse.org/t/blocking-emojis-wont-work/105853
2019-02-15 20:55:48 +05:30
Dan Ungureanu
a423a9383f
FIX: Stop autocomplete for invalid usernames. ( #7005 )
2019-02-15 11:29:26 +11:00
Sam
f8b70f4ca3
FIX: unable to create new categories
...
Previous attempt at 70adb940
missed the critical "everyone" group from
staff, leading to a case where staff was no longer able to create categories
2019-02-15 10:24:29 +11:00
Vinoth Kannan
0472bd4adc
FIX: Remove 'backfill_etags' keyword argument from 'uploads:missing' rake task
...
And etags backfilling code is optimized
2019-02-15 00:34:35 +05:30
Penar Musaraj
e55c19d8ce
DEV: update ACE Editor to 1.4.2
...
Remove duplicate "src-min" folder and fix rake task
Remove unused "snippets" folder
2019-02-14 11:05:28 -05:00
Kris
3d11064a33
UX: Reduce font size on about pages
2019-02-14 11:01:17 -05:00
Bianca Nenciu
e2b8fbee12
DEV: Improve test.
2019-02-14 17:53:26 +02:00
Bianca Nenciu
7003ea96be
FIX: Fix failing test.
2019-02-14 16:56:06 +02:00
Bianca Nenciu
70adb94008
SECURITY: Do not leak private group names. ( #7008 )
2019-02-14 15:35:58 +01:00
Vinoth Kannan
b5fbd7385f
FIX: run the rake task only for uploads created before a day from inventory date
2019-02-14 17:53:08 +05:30
Régis Hanol
fc14847c14
PERF: only require aws-sdk-sns gem when it's being used
2019-02-14 11:08:21 +01:00
Régis Hanol
a3e9b809b2
Update aws-sdk-* gems to latest versions
2019-02-14 11:04:35 +01:00
Vinoth Kannan
f7d03b2406
Stop the automatic creation of inventory 'gz' file in fixtures
2019-02-14 14:25:45 +05:30
Sam
f52378ca5f
Make rubocop happy
...
oops I forgot a newline
2019-02-14 18:06:06 +11:00
Sam
ebd4140492
FIX: logspam due to 404s on CSS files
...
We had a missing formats: string on our render partial that caused logs to
spam when CSS files got 404s.
Due to magic discourse_public_exceptions.rb was actually returning the
correct 404 cause it switched format when rendering the error.
2019-02-14 17:58:16 +11:00
Maja Komel
39522659a6
FIX: validate parent category/subcategories permissions
...
See: https://meta.discourse.org/t/subcategories-do-not-inherit-permissions-from-parent-category/17174/23 for more details
This ensures users with access to child category can always at least see parent
2019-02-14 16:38:52 +11:00
Penar Musaraj
090e9c8432
FIX: make composer full screen shortcut work when inputs have focus ( #6907 )
...
- Uses a Mousetrap plugin for global shortcuts
- Implemented for search `ctrl+alt+f` and composer fullscreen `shift+f11` shortcuts
2019-02-14 00:19:27 -05:00
Saurabh Patel
ed6f4dfc40
FEATURE: trigger user profile create and update event ( #6958 )
...
Adds `user_profile_created` DiscourseEvent on profile creation and `user_profile_updated` on profile update
2019-02-14 15:45:12 +11:00
Arpit Jalan
b651605d6e
FIX: tags added while editing a pending approval topic do not show up ( #6959 )
2019-02-14 15:42:40 +11:00
Sam
74d2d4f658
FEATURE: add APIS for unpausing all sites
...
This adjusts 53d592ad
by @tgxworld
- Adds Sidekiq.upause_all! to unpause all sites
- Adds Sidekiq.paused_dbs to list dbs that are currently paused
- Handles some edge cases where unpause thread could extend expiry on
sites that were unpaused from a different process
- Ensures tests always terminates background thread used for pause
keepalive
2019-02-14 13:34:20 +11:00
Kris
37666c3d18
UX: Signup form labels were too constrained, minor cleanup
2019-02-13 21:07:34 -05:00
Guo Xiang Tan
53d592ad3b
FIX: Add multisite support to Sidekiq::Pausable. ( #6960 )
...
Having a global Sidekiq pause switch is problematic because a site in
the cluster can pause Sidekiq for the entire cluster.
2019-02-14 12:22:40 +11:00