Alan Guo Xiang Tan
322a3be2db
DEV: Remove logical OR assignment of constants ( #29201 )
...
Constants should always be only assigned once. The logical OR assignment
of a constant is a relic of the past before we used zeitwerk for
autoloading and had bugs where a file could be loaded twice resulting in
constant redefinition warnings.
2024-10-16 10:09:07 +08:00
Gerhard Schlager
82c62fe44f
DEV: Correctly pluralize error messages ( #26469 )
2024-04-04 15:02:09 +02:00
Gerhard Schlager
01dc461cc2
FIX: Disallow invisible Unicode characters in usernames ( #21331 )
...
The list of excluded characters is based on https://invisible-characters.com/ and the list of invisible characters used by Visual Studio Code (https://github.com/hediet/vscode-unicode-data )
2023-05-02 17:34:53 +10:00
Daniel Waterworth
666536cbd1
DEV: Prefer \A and \z over ^ and $ in regexes ( #19936 )
2023-01-20 12:52:49 -06:00
David Taylor
5a003715d3
DEV: Apply syntax_tree formatting to app/*
2023-01-09 14:14:59 +00:00
Gerhard Schlager
b0ea919b09
FIX: Use cached RegEx instead of recreating RegEx on every usage
2022-11-09 14:27:55 +01:00
Krzysztof Kotlarek
e0d9232259
FIX: use allowlist and blocklist terminology ( #10209 )
...
This is a PR of the renaming whitelist to allowlist and blacklist to the blocklist.
2020-07-27 10:23:54 +10:00
Krzysztof Kotlarek
427d54b2b0
DEV: Upgrading Discourse to Zeitwerk ( #8098 )
...
Zeitwerk simplifies working with dependencies in dev and makes it easier reloading class chains.
We no longer need to use Rails "require_dependency" anywhere and instead can just use standard
Ruby patterns to require files.
This is a far reaching change and we expect some followups here.
2019-10-02 14:01:53 +10:00
Sam Saffron
30990006a9
DEV: enable frozen string literal on all files
...
This reduces chances of errors where consumers of strings mutate inputs
and reduces memory usage of the app.
Test suite passes now, but there may be some stuff left, so we will run
a few sites on a branch prior to merging
2019-05-13 09:31:32 +08:00
Guo Xiang Tan
152238b4cf
DEV: Prefer public_send over send.
2019-05-07 09:33:21 +08:00
Gerhard Schlager
a7bc1ecbae
FEATURE: Add support for Unicode usernames and group names
...
Co-authored-by: Joffrey JAFFEUX <j.jaffeux@gmail.com>
2019-04-23 13:00:27 +02:00
Guo Xiang Tan
2498403bc3
Revert "FIX: Username uniqueness check should not happen to current user_id"
...
This reverts commit f71a18facd
2018-04-03 00:44:04 +08:00
Vinoth Kannan
f71a18facd
FIX: Username uniqueness check should not happen to current user_id
2018-04-02 21:59:11 +05:30
Guo Xiang Tan
13c6191e89
FIX: Don't allow invalid email to be saved.
2016-12-21 17:47:11 +08:00
Régis Hanol
e204144a58
UsernameValidator error messages weren't matching the code
2016-02-18 23:19:14 +01:00
Régis Hanol
c2c01cdb5d
FIX: username suggester to account for the more relaxed username rules ( closes #3907 )
2016-01-20 15:37:34 +01:00
Régis Hanol
c5f9ae0de1
FIX: username mentions weren't working when immediately followed by a dot
2016-01-07 22:23:01 +01:00
Régis Hanol
bebeeffc30
FIX: ico are images too
2015-12-31 11:40:23 +01:00
Robin Ward
b3d2982be7
FIX: Allow trailing _ because we used to.
2015-09-09 14:06:36 -04:00
Sam
262f561a87
FEATURE: relax username rules to allow - and . and leading _
...
This relaxes our very strict username rules to allow for some long asked for requests
- leading _ is now allowed
- . is allowed except for trailing char and confusing extensions like .gif .json
- dash (-) is now permitted
2015-09-02 12:13:44 +10:00
Régis Hanol
2ef53f89f4
[0] is shorter than [0,1] :)
2013-12-17 16:30:25 +01:00
Juan de Dios Herrero
27b038cd40
Refactored username validations to avoid repeated code
2013-07-07 13:05:18 +02:00
Gosha Arinich
6e5399d544
minor cleanup, using AR querying DSL over raw SQL in some places
2013-02-28 21:54:12 +03:00
Neil Lalonde
ce7088f081
check_username api now returns correct error message for invalid lengths etc
2013-02-08 14:12:48 -05:00
Cyril Mougel
84191802df
Extract the validation of Username format in own class to avoid
...
complexity in user model object
2013-02-08 12:54:47 -05:00
