OsamaSayegh
f75d1e958d
REFACTOR: extra locales controller specs to requests
2018-06-07 12:34:39 +08:00
Sam
f331d2603d
DEV: improve design of site setting default provider
...
This refactors it so "Defaults provider" is only responsible for "defaults"
Locale handling and management of locale settings is moved back into
SiteSettingExtension
This eliminates complex state management using DistributedCache and makes
it way easier to test SiteSettingExtension
2018-06-07 14:33:41 +10:00
OsamaSayegh
d2880246cd
REFACTOR: steps controller specs to requests
2018-06-07 12:31:13 +08:00
Guo Xiang Tan
47ddb3a7ca
Merge branch 'wizard-controller' of https://github.com/OsamaSayegh/discourse into OsamaSayegh-wizard-controller
2018-06-07 12:27:48 +08:00
OsamaSayegh
600ff85ecd
REFACTOR: draft controller specs to requests ( #5942 )
2018-06-07 12:24:20 +08:00
OsamaSayegh
f5178ded56
REFACTOR: offline controller spec to requests ( #5943 )
2018-06-07 12:24:05 +08:00
Sam
89ad2b5900
DEV: Rails 5.2 upgrade and global gem upgrade
...
This updates tests to use latest rails 5 practice
and updates ALL dependencies that could be updated
Performance testing shows that performance has not regressed
if anything it is marginally faster now.
2018-06-07 14:21:33 +10:00
Guo Xiang Tan
2bd905c632
Revert "Upgrade Rails to 5.1.6."
...
This reverts commit ab66215f5c
.
2018-06-07 09:49:38 +08:00
Guo Xiang Tan
01f126e38f
Simplify unicorn config.
2018-06-07 09:03:16 +08:00
Guo Xiang Tan
78c705f5de
Remove migration code that is no longer valid.
2018-06-07 08:57:01 +08:00
Guo Xiang Tan
cb9596e196
Remove invalid hosted-site
plugin.
2018-06-07 08:49:19 +08:00
Guo Xiang Tan
ab66215f5c
Upgrade Rails to 5.1.6.
2018-06-07 08:34:36 +08:00
Joffrey JAFFEUX
a58fb817c0
FIX: removes buggy/unnecessary local-dates margin
2018-06-06 15:28:56 +02:00
Joe
56dbbfbd2a
FIX: user-fields layout in mobile create account form
2018-06-06 21:02:35 +08:00
Vinoth Kannan
d8e641cd98
FIX: avatar_url includes upload_path twice when local storage used
2018-06-06 18:27:30 +05:30
OsamaSayegh
3244fb8959
REFACTOR: wizard controller specs to requests
2018-06-06 12:07:55 +03:00
Guo Xiang Tan
a50cd8675a
FIX: Permalink route matcher should always be last.
2018-06-06 14:55:22 +08:00
Guo Xiang Tan
a4e6662833
FIX: Disconnects all connections in the pool before forking.
...
* We were leaking connections as a result. Connections opened
before the fork were never closed.
2018-06-06 14:45:05 +08:00
Guo Xiang Tan
aa5805e8b0
Revert "Initialize the v8 context after forking."
...
This reverts commit 41c4e32e64
.
2018-06-06 14:33:20 +08:00
Guo Xiang Tan
a83ab01264
REFACTOR: Remove extra param for group mentionable and messableable route.
2018-06-06 09:42:09 +08:00
Arpit Jalan
d069f4ecba
Revert "Revert "allow codepen iframe by default""
...
This reverts commit 174bf98572
.
2018-06-06 06:48:08 +05:30
Arpit Jalan
ccbaa719ee
Merge pull request #5923 from techAPJ/group-messageable
...
FIX: do not verify group visibility when checking for mentionable/messageable
2018-06-06 06:45:22 +05:30
Neil Lalonde
9ba9ff187c
Add plugin outlet to admin plugins index
2018-06-05 17:47:30 -04:00
Régis Hanol
127398c68e
FIX: import comments of 1st post in SE importer
2018-06-05 18:22:42 +02:00
Régis Hanol
dc61eaad37
FEATURE: new 'min ratio to crop' site setting
2018-06-05 17:13:00 +02:00
Régis Hanol
f05ca02f13
FIX: unable to add new poll to post with a public poll
2018-06-05 15:49:21 +02:00
Arpit Jalan
174bf98572
Revert "allow codepen iframe by default"
...
This reverts commit dc00089ab2
.
2018-06-05 18:21:21 +05:30
Arpit Jalan
dc00089ab2
allow codepen iframe by default
2018-06-05 18:17:23 +05:30
Arpit Jalan
f8d82f135f
FIX: do not verify group visibility when checking for mentionable/messageable
2018-06-05 16:59:21 +05:30
Guo Xiang Tan
bc7d9c61e6
Revert smoke test accidentally default to non headless mode.
2018-06-05 19:21:46 +08:00
Guo Xiang Tan
a276ffc7b3
Run smoke test without sandbox for now.
2018-06-05 19:08:36 +08:00
Guo Xiang Tan
32c0ff4831
DEV: Install dependencies before running smoke test.
2018-06-05 18:46:41 +08:00
Guo Xiang Tan
478c86e0a4
DEV: Update preview step to be more reliable.
2018-06-05 16:58:15 +08:00
OsamaSayegh
d3e610eed9
REFACTOR: topic controller (2) specs to requests ( #5911 )
2018-06-05 12:03:49 +08:00
Guo Xiang Tan
41c4e32e64
Initialize the v8 context after forking.
2018-06-05 11:36:38 +08:00
OsamaSayegh
475d944d74
REFACTOR: onebox controller specs to requests ( #5914 )
2018-06-05 11:36:08 +08:00
OsamaSayegh
22fcc04d38
REFACTOR: user badges controller specs to requests ( #5912 )
2018-06-05 10:59:01 +08:00
OsamaSayegh
79dcd79470
REFACTOR: email controller specs to requests ( #5917 )
2018-06-05 10:57:11 +08:00
Guo Xiang Tan
c27863aad2
DEV: Better output when assertion fails in smoke test.
2018-06-05 10:54:56 +08:00
Guo Xiang Tan
a508e6a5f6
DEV: Stablize requests/search_controller_spec
.
2018-06-05 10:07:05 +08:00
Guo Xiang Tan
aaea24448e
DEV: Add specs for 085eaaf18d
.
2018-06-05 10:03:26 +08:00
Guo Xiang Tan
d600e71b3d
FIX: Clean up stale UserExport
records daily.
...
* Add tests for `UserExport.remove_old_exports`
2018-06-05 09:43:40 +08:00
Guo Xiang Tan
dcba320bf6
Remove spec that isn't testing for anything.
2018-06-05 09:30:02 +08:00
Rafael dos Santos Silva
74c33a5316
Merge pull request #5915 from jjaffeux/sharing-macos-chrome
...
FIX: sharing popup not showing on macos/chrome
2018-06-04 20:38:10 -03:00
Joffrey JAFFEUX
40b3efacaa
FIX: sharing popup not showing on macos/chrome
...
Despite `navigator.share` being defined the call was failing with this error:
```
sharing DOMException: Internal error: could not connect to Web Share interface.
```
2018-06-05 01:18:57 +02:00
Robin Ward
fab59c66f0
FIX: Protection against dangling category group records
2018-06-04 15:43:26 -04:00
Régis Hanol
6024fb84cc
make rubocop happy
2018-06-04 19:06:52 +02:00
Régis Hanol
ab8cdd6b5b
Upload.url can't be NULL
2018-06-04 18:43:00 +02:00
Régis Hanol
085eaaf18d
FIX: always delete invalid upload records
2018-06-04 18:40:57 +02:00
Arpit Jalan
46fc57222f
FEATURE: improve handling of site setting secrets
2018-06-04 21:31:34 +05:30