github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2024-12-03 01:03:40 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity
39,547 Commits 214 Branches 500 Tags 960 MiB
a47c8f0585
Commit Graph

39547 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Neil Lalonde
f1743ff69c
FIX: error "unknown attribute verified" in uploads rake tasks 
The new column is verification_status.
verified: nil is now verification_status: unchecked
 2020-09-21 10:47:52 -04:00
Jarek Radosz
1db8315a8b UX: Remove the post number from a composer label 
It didn't provide much value to users as it often didn't match the number visible in the topic timeline. That's because `postNumber` is an implementation detail, while the timeline counts only full visible posts (no whispers, topic action notices, etc.)
 2020-09-21 14:47:36 +02:00
Jarek Radosz
b2adbead59 DEV: Apply unselectable style consistently 2020-09-21 13:32:46 +02:00
Jarek Radosz
fc299bed0d UX: Replace "Loading..." in quotes with a spinner 2020-09-21 13:26:19 +02:00
Arpit Jalan
376255ed84 UX: add width and height to GitHub onebox inline avatar in emails. 2020-09-21 11:47:09 +05:30
Vinoth Kannan
6b818fb855 FIX: use normal logo in published pages if small not available. 
It was returning an error if small logo is not available. If both logos are not available then it will be hidden now.
 2020-09-21 09:20:39 +05:30
Sam Saffron
dce518477c
FIX: if no group is found, raise correct error 
Previously missing group could lead to an error cause can_see_group_messages
expects a group.
 2020-09-21 10:27:08 +10:00
Sam Saffron
cba5baa427
FIX: compensate for typographer 
typographer can change " to ” leading to breakages in parser

At least codify this. Longer term we want to re-prioritize typographer so
it always runs after bbcode parsing.
 2020-09-21 09:44:37 +10:00
Sam Saffron
a91ee45de9
FIX: Nested quotes in BBCode 
Previously attributes such as `[test a='a"a' b="a'a"]` were not correctly
handled.

This amends the regex parser to ensure it correctly parses attributes
without breaking incorrectly on the first nested quote
 2020-09-21 08:56:25 +10:00
Joffrey JAFFEUX
50647366ed
FIX: NotificationLevels import was incorrect (#10709) 
This was causing NotificationLevels.muted to be undefined.
 2020-09-19 11:27:20 +02:00
Joffrey JAFFEUX
f785b04dc0
FIX: missing / after basePath was causing the URL to be relative (#10708) 2020-09-19 11:27:03 +02:00
David Taylor
fe932eb644
FIX: Ensure multisite DB is set correctly when spawning backup process 
Followup to 76477a1c8b
 2020-09-18 20:06:49 +01:00
Penar Musaraj
c664ba8fa8
DEV: Fix flaky UploadSecurity spec 2020-09-18 14:36:41 -04:00
dependabot-preview[bot]
f6c5fb21bd Build(deps): Bump rubocop-ast from 0.4.1 to 0.4.2 
Bumps [rubocop-ast](https://github.com/rubocop-hq/rubocop-ast) from 0.4.1 to 0.4.2.
- [Release notes](https://github.com/rubocop-hq/rubocop-ast/releases)
- [Changelog](https://github.com/rubocop-hq/rubocop-ast/blob/master/CHANGELOG.md)
- [Commits](https://github.com/rubocop-hq/rubocop-ast/compare/v0.4.1...v0.4.2)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
 2020-09-18 14:23:35 -04:00
Anthony Dillon
01afcf30cc
FIX: Whitelist marker elements when uploading SVGs (#10703) 2020-09-18 14:13:07 -04:00
Robin Ward
9c1e21b874 REFACTOR: Remove dead code (mouseMove) 
We don't delegate `mouseMove` so this code has not been called in a long
time. It also seems that `screenX`/`screenY`/`lastX`/`lastY` was never
used so they were removed too.
 2020-09-18 13:57:12 -04:00
Robin Ward
ba3014f9f9 REFACTOR: Do not rely on module order for discourse-markdown loading 
Before this patch, discourse-markdown depended on the modules in its
bundle being defined in a specific order or it wouldn't load properly.

Now, any file in the bundle can export a `priority` const (default 0)
and files will be loaded in order of ascending priority instead. This
allows us to use a bundle packaged in any order we want.
 2020-09-18 13:31:55 -04:00
Penar Musaraj
23abd0d953
UX: Update dark mode styling of new user overlay (#10694) 2020-09-18 12:02:28 -04:00
Penar Musaraj
fec6411fbf
UX: Landscape spacing in iOS devices with a notch 
Avoids some content being covenred by the notch in some iOS devices.
 2020-09-18 11:59:40 -04:00
Roman Rizzi
f85f73be88
FEATURE: Review posts with media. (#10693) 
To check if a post contains any embedded media, we look if the "image_sizes" attribute is present in the new post manager arguments.

We want to see one boxed links, but we only store the raw content of the post. To work around this, I extracted the onebox logic from the composer editor into a module.
 2020-09-18 12:45:09 -03:00
Robin Ward
f3156a6478 REFACTOR: Move the discourse-markdown engine out of the addon repo 
The reasoning here is that we want to make a unique bundle for this
folder and the default approach is to include everything in `addon`.
 2020-09-18 11:42:22 -04:00
Gerhard Schlager
76477a1c8b FIX: Forking prevented notifications from being sent after backup 
This is a workaround for https://github.com/rubyjs/mini_racer/issues/175
 2020-09-18 17:35:17 +02:00
Joffrey JAFFEUX
cc2a306936
FIX: hidden was defined as static instead of relying on attribute (#10701) 
This commit also:
- deprecate an old way of using actions for future removal
- removes all the hidden/block/... logic, as we just rely on parent being displayed or not
 2020-09-18 15:11:34 +02:00
David Taylor
ce686a008f
DEV: Refresh site settings on Redis fallback (#10700) 
This ensures that all app instances have up-to-date data, even if they missed a message-bus update during the failover
 2020-09-18 11:44:25 +01:00
Guo Xiang Tan
d83d9ec408
DEV: Clear all DistributedCache on Redis fallback. 2020-09-18 11:31:49 +08:00
dependabot-preview[bot]
a957a980e2 Build(deps-dev): Bump better_errors from 2.8.0 to 2.8.1 
Bumps [better_errors](https://github.com/BetterErrors/better_errors) from 2.8.0 to 2.8.1.
- [Release notes](https://github.com/BetterErrors/better_errors/releases)
- [Commits](https://github.com/BetterErrors/better_errors/commits)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
 2020-09-18 09:58:32 +08:00
dependabot-preview[bot]
b125acf251 Build(deps): Bump crack from 0.4.3 to 0.4.4 
Bumps [crack](https://github.com/jnunemaker/crack) from 0.4.3 to 0.4.4.
- [Release notes](https://github.com/jnunemaker/crack/releases)
- [Changelog](https://github.com/jnunemaker/crack/blob/master/History)
- [Commits](https://github.com/jnunemaker/crack/compare/v0.4.3...v0.4.4)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
 2020-09-18 09:58:09 +08:00
Martin Brennan
14b324e5ed
FIX: Provide better API for registering custom upload public types (#10697) 
With secure media and the UploadSecurity class, we need a nice way for plugins to register custom upload types that should be considered public and never secure.
 2020-09-18 11:54:33 +10:00
dependabot-preview[bot]
22181f59ab
Build(deps): Bump puma from 4.3.6 to 5.0.0 (#10692) 
Bumps [puma](https://github.com/puma/puma) from 4.3.6 to 5.0.0.
- [Release notes](https://github.com/puma/puma/releases)
- [Changelog](https://github.com/puma/puma/blob/master/History.md)
- [Commits](https://github.com/puma/puma/compare/v4.3.6...v5.0.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
 2020-09-17 14:06:49 -04:00
Penar Musaraj
3d39b4bbb5
FIX: Do not downcase group name in current user serializer 2020-09-17 13:03:42 -04:00
Penar Musaraj
dbdb5b9a47
DEV: Use border-box sizing for admin controls 
Fixes floating issues in admin site settings on screen widths between
768 and 880 pixels. This also cleans up spacing on mobile.
 2020-09-17 11:49:41 -04:00
Jordan Vidrine
931d8725de
FEATURE: Diffrentiate between group + individual mentions (#10691) 
* FEATURE: Diffrentiate between group + individual mentions

This commit adds the necessary code for Discorse core to differentiate between group + individual mentions in the notification user panel and notification page.

It changes the group mention icon from `at` to `users` as well as adds context as to which group was mentioned in the topic.
 2020-09-17 10:23:19 -05:00
Osama Sayegh
a92d88747e
DEV: Add ENV variable for enabling MiniProfiler snapshots (#10690) 
* DEV: Add ENV variable for enabling MiniProfiler snapshots

* MiniProfiler is not loaded in test env
 2020-09-17 18:18:35 +03:00
Daniel Waterworth
6e69c25134 FIX: Use asset_hostnames in rails_multisite 
We want to respond to the x-forwarded-for host from the CDN too.
 2020-09-17 10:32:43 +01:00
Guo Xiang Tan
b47b640598
FEATURE: Hidden SiteSetting.keep_old_ip_address_count to track IP history. 2020-09-17 12:50:39 +08:00
Martin Brennan
c2a660ead3
FIX: Fix verification_status migration for uploads 
* Missing ELSE 1 even though there is a default on the
  column.
 2020-09-17 14:23:37 +10:00
Martin Brennan
49bd066037
FEATURE: Default allow embed secure images in email to true (#10688) 
We are making the changes from the PR #10563 the default behaviour. Now, if secure media is enabled, secure images will be embedded in emails by default instead of redacting them and displaying a message. This will be a nicer overall experience by default, and for forums that want to be super strict with redaction this setting can always be disabled.
 2020-09-17 14:15:02 +10:00
Martin Brennan
80268357e7
DEV: Change upload verified column to be integer (#10643) 
Per review https://review.discourse.org/t/dev-add-verified-to-uploads-and-fill-in-s3-inventory-10406/14180

Change the verified column for Upload to a verified_status integer column, to avoid having NULL as a weird implicit status.
 2020-09-17 13:35:29 +10:00
dependabot-preview[bot]
e313aa5a6e Build(deps): Bump rack-mini-profiler from 2.0.4 to 2.1.0 
Bumps [rack-mini-profiler](https://github.com/MiniProfiler/rack-mini-profiler) from 2.0.4 to 2.1.0.
- [Release notes](https://github.com/MiniProfiler/rack-mini-profiler/releases)
- [Changelog](https://github.com/MiniProfiler/rack-mini-profiler/blob/master/CHANGELOG.md)
- [Commits](https://github.com/MiniProfiler/rack-mini-profiler/compare/v2.0.4...v2.1.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
 2020-09-17 08:53:27 +08:00
dependabot-preview[bot]
19b9a1159c
Build(deps-dev): Bump parallel_tests from 3.2.0 to 3.3.0 (#10684) 
Bumps [parallel_tests](https://github.com/grosser/parallel_tests) from 3.2.0 to 3.3.0.
- [Release notes](https://github.com/grosser/parallel_tests/releases)
- [Changelog](https://github.com/grosser/parallel_tests/blob/master/CHANGELOG.md)
- [Commits](https://github.com/grosser/parallel_tests/compare/v3.2.0...v3.3.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
 2020-09-16 16:55:22 -04:00
dependabot-preview[bot]
bc2b9f4ea2
Build(deps): Bump rubocop-ast from 0.4.0 to 0.4.1 (#10683) 
Bumps [rubocop-ast](https://github.com/rubocop-hq/rubocop-ast) from 0.4.0 to 0.4.1.
- [Release notes](https://github.com/rubocop-hq/rubocop-ast/releases)
- [Changelog](https://github.com/rubocop-hq/rubocop-ast/blob/master/CHANGELOG.md)
- [Commits](https://github.com/rubocop-hq/rubocop-ast/compare/v0.4.0...v0.4.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
 2020-09-16 16:41:22 -04:00
Neil Lalonde
b207842720
FIX: group tag notifications included for all users 
Regression from my last commit
 2020-09-16 16:02:28 -04:00
Neil Lalonde
04be39ed46
FIX: don't show Tags tab in group management if tags are disabled 2020-09-16 15:43:11 -04:00
Neil Lalonde
8333872e88
FIX: N+1 for admins viewing groups page 
Groups page was loading fields that are only used on the group show
page, so move those fields to the GroupShowSerializer.
Also only fetch the default category and tag notifications once.
 2020-09-16 14:58:52 -04:00
Joffrey JAFFEUX
28cd1aaf8e
FIX: uses get() on properties of groups/badges which could be POJOs (#10682) 2020-09-16 16:45:11 +02:00
Joffrey JAFFEUX
02dec8c209
UI: minor size/spacing inconsistencies in search advanced options (#10681) 2020-09-16 15:05:19 +02:00
Discourse Translator Bot
6734a82260 Update translations 2020-09-16 10:17:56 +00:00
Joffrey JAFFEUX
4af48f7998
FIX: attempts to make autofocus more resilient in modals (#10680) 
The current situation could cause a transition on the button to end after/during modal has shown and causing the button to get focus again. Browsers would then refuse to switch focus.

This is a kinda convulted solution, but it's a general purpose solution which doesn't involve changing anything in plugins/themes or core templates.
 2020-09-16 11:05:02 +02:00
Arpit Jalan
32d6286bea FIX: category slug route was not working for subfolder setup 
https://meta.discourse.org/t/relative-url-root-issues-incorrect-latest-link-incorrect-redirect/163266

URLs like `/forum/c/staff` (subfolder setup) were landing on
`/forum/forum/c/staff/3`. Note the extra "/forum". This commit
strips the redundant subfolder path from category URL.
 2020-09-16 12:09:16 +05:30
Guo Xiang Tan
ddcf0d7d01
Update rails_failover to 0.5.7. 2020-09-16 13:53:45 +08:00