1638 Commits

Author	SHA1	Message	Date
Robin Ward	1f14350220	Rename "Blocked" to "Silenced"	2017-11-10 14:10:27 -05:00
Neil Lalonde	16ff2a4715	FIX: topic counts after converting topic to/from public and private	2017-11-09 15:33:44 -05:00
Arpit Jalan	b21d5d3633	FIX: SSO email match should be case insensitive	2017-11-08 20:37:41 +05:30
Guo Xiang Tan	6090994cdf	FEATURE: Retain the latest 30 days of WebHookEvent records by default.	2017-11-08 14:11:01 +08:00
Neil Lalonde	c7d7cb940c	FIX: dashboard posts report was including posts in daily data, but not in totals	2017-11-02 18:46:28 -04:00
Guo Xiang Tan	edf4af608e	FIX: Better match when searching for groups.	2017-11-02 10:20:14 +08:00
Guo Xiang Tan	401fbdbfe7	FIX: Topic#title were being parameterized when encoded slug is ... enabled.	2017-10-27 11:02:47 +08:00
Guo Xiang Tan	f1615c2148	Merge pull request #5263 from tgxworld/improve_pattern ... REFACTOR: Always validate email by default.	2017-10-26 14:34:09 +08:00
Guo Xiang Tan	defea6245c	REFACTOR: Always validate email by default.	2017-10-25 13:48:34 +08:00
Sam	1db4c2d1a0	moving redis to readonly mode destablizes the test suite	2017-10-25 14:39:49 +11:00
Sam	0d816302e2	Explicitly avoid all readonly protection and scoping	2017-10-25 13:31:44 +11:00
Sam	7ca8853861	don't risk being stuck in readonly	2017-10-25 13:22:50 +11:00
Sam	877b7be579	FIX: in readonly mode don't double count pages	2017-10-25 13:19:43 +11:00
Neil Lalonde	4452d67a23	Revert "FIX: TL0 users' messages to moderators were not being posted when flagging private messages"	2017-10-23 18:17:53 -04:00
Guo Xiang Tan	19f3b81161	Revert "FIX: always trigger the ':user_updated' event" ... This reverts commit 519b70ea46. https://meta.discourse.org/t/creating-a-topic-or-a-post-sends-the-user-updated-webhook/71643	2017-10-23 11:44:22 +08:00
Gerhard Schlager	4205c1ad2b	FIX: postprocessing ignored cook method	2017-10-20 10:26:45 +02:00
Robin Ward	838568cbc3	Refactor flag types for more customization	2017-10-19 13:55:23 -04:00
Gerhard Schlager	1cae875146	FIX: topic link extraction shouldn't fail when the parsed URL has no path	2017-10-19 15:26:37 +02:00
Gerhard Schlager	3cd73cdf18	FIX: fancy topic title must fit into column	2017-10-19 14:34:30 +02:00
Guo Xiang Tan	22ba70fb01	Merge pull request #5226 from tgxworld/allow_user_to_disable_private_messages ... FEATURE: Allow users to disable new PMs.	2017-10-19 16:46:18 +08:00
Guo Xiang Tan	5b9ddaf972	FIX: Topic#fancy_title should not write in readonly mode.	2017-10-19 16:07:03 +08:00
Guo Xiang Tan	25c25ae423	FEATURE: Allow user to leave a PM.	2017-10-19 12:32:55 +08:00
Sam	229a10e142	Missed a whitelist, compensate for strict classes	2017-10-16 10:46:01 +11:00
Neil Lalonde	b124e5f19f	FIX: TL0 users' messages to moderators were not being posted when flagging private messages	2017-10-13 11:55:49 -04:00
Arpit Jalan	a2183c3f1d	SECURITY: verify that inviter can invite new user to a topic	2017-10-09 15:59:41 +05:30
Sam	4ea87b5ab8	Merge branch 's3_refactor'	2017-10-09 10:27:52 +11:00
Sam	70bb2aa426	FEATURE: allow specifying s3 config via globals ... This refactors handling of s3 so it can be specified via GlobalSetting This means that in a multisite environment you can configure s3 uploads without actual sites knowing credentials in s3 It is a critical setting for situations where assets are mirrored to s3.	2017-10-06 16:20:01 +11:00
Guo Xiang Tan	b0557c6692	UX: Allow users to remove a remind me topic timer.	2017-10-05 11:50:08 +08:00
Neil Lalonde	f5a2ed99b0	FIX: deleting category background images sometimes has no effect	2017-10-04 17:04:37 -04:00
Régis Hanol	e212435545	FIX: redirect to top wasn't working	2017-10-04 22:08:41 +02:00
Guo Xiang Tan	1310181664	FIX: Adding a public topic timer deletes a private topic timer.	2017-10-04 16:31:40 +08:00
Guo Xiang Tan	c872225762	Improve MessageBus.track_publish to allow filter by channel.	2017-10-02 11:34:57 +08:00
Arpit Jalan	d64853dfa0	FIX: update group.has_messages field weekly	2017-09-29 08:23:07 +05:30
Guo Xiang Tan	c37598ddbc	Merge pull request #5200 from gschlager/embed ... FIX: do not escape already escaped chars in URL	2017-09-26 09:07:57 +08:00
Guo Xiang Tan	88555f32cf	Improve specs.	2017-09-25 13:49:00 +08:00
Guo Xiang Tan	e542884b00	FIX: Incorrect notification state being published.	2017-09-25 13:48:59 +08:00
Guo Xiang Tan	77d4c4d8dc	Fix all the errors to get our tests green on Rails 5.1.	2017-09-25 13:48:58 +08:00
Gerhard Schlager	6f6b47f096	FIX: do not escape already escaped chars in URL	2017-09-22 17:36:44 +02:00
Gerhard Schlager	1a435414d5	FIX: handle URL encoded email addresses	2017-09-22 14:26:06 +02:00
Lidiane Taquehara	66ed7195d6	Add spec to cover Badge Type has many Badges relation ... Also: fix filename. `_spec` suffix was missing. By default, RSpec ignores files in this situation. Ref: https://github.com/rspec/rspec-core/issues/642	2017-09-20 00:51:32 -03:00
Gerhard Schlager	f3d3129113	FIX: Use default locale for edit reason when owner of post gets changed	2017-09-14 17:17:37 +02:00
Gerhard Schlager	efef422416	FIX: Use default locale for moderator post when posts are moved	2017-09-14 17:17:37 +02:00
Neil Lalonde	d7d9923b8e	FIX: display email validation error messages	2017-09-11 13:22:14 -04:00
Joffrey JAFFEUX	caedefd675	FIX: correctly resets user_themes template ... This commit adds tests for this behaviour and also adds support for reseting cache when updating a theme name and destroying a theme.	2017-09-04 13:27:58 +02:00
Arpit Jalan	70d4c39bcd	SECURITY: do not include links from whispers in topic summary map ... https://meta.discourse.org/t/staff-whispers-links-in-whispers-showing-up-publicly-in-topics-summary/69134?u=techapj	2017-09-01 00:25:49 +05:30
Arpit Jalan	66f2925348	SECURITY: do not include links from whispers in topic summary map ... https://meta.discourse.org/t/staff-whispers-links-in-whispers-showing-up-publicly-in-topics-summary/69134?u=techapj	2017-08-31 23:44:54 +05:30
Guo Xiang Tan	5f0351348b	FIX: Group name was being reverted to non-localized version. ... https://meta.discourse.org/t/localized-staff-group-names-changed/65360/16	2017-08-29 14:42:07 +08:00
Bianca Nenciu	6bc74ceb50	Split alias levels in mentionable and messageable levels. (#5065) ... * Split alias levels in mentionable and messageable levels. * Fixed some tests. * Set messageable level to everyone by default. * By defaults, groups are not mentionable or messageable. * Made staff groups messageable by the system.	2017-08-28 12:32:08 -04:00
Neil Lalonde	398604ac71	FEATURE: set purge_unactivated_users_grace_period_days to 0 to disable purging unactivated users	2017-08-25 15:20:06 -04:00
Sam	bcbee91f0c	lint	2017-08-24 13:24:52 -04:00
Sam	f60a1b0275	correct erratic spec	2017-08-24 13:19:26 -04:00
Sam	f766ea4257	Correct short url decoding for sha1s leading with zero ... This was picked up cause we had a flaky test!	2017-08-23 11:08:18 -04:00
Neil Lalonde	224796a7d4	FIX: wrongs counts on tags with deleted topics	2017-08-22 16:55:05 -04:00
Sam	bcf7dc38c2	FEATURE: server side support for upload:// markdown ... This allows uploads to be specified using short sha1 hash instead of full URL Client side change is pending	2017-08-22 11:46:23 -04:00
Arpit Jalan	b00747fd49	FIX: do not create topic link reflection for unlisted topics	2017-08-22 14:28:01 +05:30
Guo Xiang Tan	bc3e43b496	FIX: Topic timers being incorrectly trashed!. ... https://meta.discourse.org/t/temporary-timed-closure-of-topic-not-re-opening-topic/67877	2017-08-22 15:23:09 +09:00
Guo Xiang Tan	87994a86ce	FIX: Don't set topic timer for close topics when changing category. ... https://meta.discourse.org/t/moving-a-topic-after-closure-reopens-topic/67659/4	2017-08-22 12:54:34 +09:00
Sam	c2a6616035	Correct erratic spec failure	2017-08-17 15:26:31 -04:00
Robin Ward	b78958fbfc	Silence CSS logging in development - it's way too noisy	2017-08-16 10:59:56 -04:00
Guo Xiang Tan	b77aa29e71	Merge pull request #5013 from LeoMcA/alternate-emails-phase-1.5 ... FIX: add additional email to tests and clean up resulting mess	2017-08-16 16:19:28 +09:00
Guo Xiang Tan	ed851dbfff	FIX: Avoid publishing a gigantic payload. ... * Certain sites have way too many categories.	2017-08-16 11:38:30 +09:00
Joffrey JAFFEUX	506572bf04	FIX: display emojis (set, custom and native) in bio excerpt	2017-08-15 10:05:09 +02:00
Neil Lalonde	94d8f6d734	FIX: digest emails should not include posts that are still in the edit grace period	2017-08-14 12:47:33 -04:00
Neil Lalonde	9813f9f0f8	FIX: more cases of case sensitive group membership in sso	2017-08-11 18:09:29 -04:00
Neil Lalonde	15a74d6d3e	FIX: don't enforce newuser_spam_host_threshold on private messages	2017-08-10 17:19:08 -04:00
Guo Xiang Tan	b404a4b97c	Merge pull request #5034 from tgxworld/fix_staged_primary_email ... FIX: Staged users are still missing primary email.	2017-08-10 10:30:51 +09:00
Neil Lalonde	ca1609c821	FIX: user directory didn't update stats of users with no recent activity	2017-08-09 15:57:42 -04:00
Guo Xiang Tan	90d7dd1f05	FIX: Ensure that post action moderation post uses the site's default locale. ... https://meta.discourse.org/t/a-post-in-looking-for-someone-to-customize-discourse-to-create-a-forum-site-requires-staff-attention/67468/5?u=tgxworld	2017-08-09 18:20:20 +09:00
Guo Xiang Tan	0bc690ed11	FIX: Staged users are still missing primary email.	2017-08-09 12:03:49 +09:00
Régis Hanol	519b70ea46	FIX: always trigger the ':user_updated' event ... We don't always use the UserUpdated class to update a user's record	2017-08-04 18:12:10 +02:00
Guo Xiang Tan	40fc6c429a	Merge pull request #5018 from discourse/wekbit-embedded-referer ... FIX: First load of embed comments would always fail on WebKit	2017-08-04 14:12:26 +09:00
Rafael dos Santos Silva	57a214e920	FIX: First load of embed comments would always fail on WebKit	2017-08-02 17:43:31 -03:00
Neil Lalonde	3de45ce0cd	FIX: use case insensitive group name search when applying group rules from SSO	2017-08-02 11:30:37 -04:00
Régis Hanol	e43799134c	fix the regexp used to valide user's website	2017-08-02 10:19:24 +02:00
Leo McArdle	836dee1120	FIX: add additional email to tests and clean up resulting mess	2017-07-31 22:27:29 +00:00
Neil Lalonde	5d528f0d15	Merge pull request #4958 from dmacjam/search_posts_by_filetype ... FEATURE: Search posts by filetype	2017-07-31 11:55:34 -04:00
Guo Xiang Tan	305b9b2da0	Add spec to ensure that even staged users contain a primary email.	2017-07-31 12:16:08 +09:00
Guo Xiang Tan	24e0e000b9	FIX: Always validate presence of user's primary_email.	2017-07-31 11:47:29 +09:00
Guo Xiang Tan	4620dfe92d	FEATURE: Add group settngs to allow users to leave a group freely. ... https://meta.discourse.org/t/split-join-leave-freely-setting-on-groups/65565	2017-07-28 15:00:25 +09:00
Guo Xiang Tan	5012d46cbd	Add rubocop to our build. (#5004)	2017-07-28 10:20:09 +09:00
Guo Xiang Tan	2442bba131	UX: Better group creation workflow. ... * Owners and users can now be added to a group during creation. https://meta.discourse.org/t/you-cannot-allow-membership-requests-without-any-owners/64760/3	2017-07-27 16:12:42 +09:00
Neil Lalonde	24cb950432	FEATURE: Watched Words: when posts contain words, do one of flag, require approval, censor, or block	2017-07-26 11:01:09 -04:00
Neil Lalonde	d8c27e3871	Merge branch 'master' into search_posts_by_filetype	2017-07-25 14:41:20 -04:00
Sam Saffron	045a2abcec	FEATURE: remove the timecop gem ... We should only have one way of mocking time, misuse of timecop was causing build stability issues	2017-07-24 12:11:10 -04:00
Guo Xiang Tan	6b17178533	Validate uniquness of api_key.	2017-07-24 21:46:08 +09:00
Guo Xiang Tan	fa09a02201	Fix specs.	2017-07-24 15:56:08 +09:00
Guo Xiang Tan	381a2a55be	Clear the cache after each test otherwise we are leaking state.	2017-07-24 11:41:37 +09:00
Leo McArdle	d0b027d88d	FEATURE: phase 1 of supporting multiple email addresses	2017-07-20 11:22:27 +09:00
Robin Ward	21e02d6969	Include the search_log_id in search results	2017-07-17 12:10:32 -04:00
Sam Saffron	d0c5205a52	Feature: Change markdown engine to markdown it ... This commit removes the old evilstreak markdownjs engine. - Adds specs to WhiteLister and changes it to stop using globals (Fixes large memory leak) - Fixes edge cases around bbcode handling - Removes mdtest which is no longer valid (to be replaced with CommonMark) - Updates MiniRacer to correct minor unmanaged memory leak - Fixes plugin specs	2017-07-17 11:41:34 -04:00
Robin Ward	6b6ad9391b	Clean up job for search logs	2017-07-14 14:30:58 -04:00
Robin Ward	97e211f837	FEATURE: Log Search Queries	2017-07-14 14:30:58 -04:00
Guo Xiang Tan	9792e03c63	FIX: Group name was being reverted to non-localized version. ... https://meta.discourse.org/t/localized-staff-group-names-changed/65360/16	2017-07-14 14:15:33 +09:00
Sam	3613ebee5b	Revert "correct specs" ... This reverts commit 2c6284ece3.	2017-07-12 18:09:57 -04:00
Sam	2c6284ece3	correct specs	2017-07-12 18:03:56 -04:00
Arpit Jalan	76981605fa	FIX: don't raise error when inviting existing user to private topic via email ... https://meta.discourse.org/t/inviting-existing-user-to-a-private-topic-message-via-email-shows-error-message/65994	2017-07-12 21:51:21 +05:30
Guo Xiang Tan	f529cb1674	Remove validation for invalid interpolation keys. ... * Our codebase currently supports custom interpolations keys that are not present in the original translation. The proper fix should be to make `TranslateOverride` aware of such keys.	2017-07-11 11:12:11 +09:00
Guo Xiang Tan	c5b1317a15	Remove code that is no longer being used.	2017-07-11 11:11:51 +09:00
Régis Hanol	c66b9dcdbd	add 'us-east-2' S3 region	2017-07-10 15:36:38 +02:00
Guo Xiang Tan	a338a7a53e	Fix the build.	2017-07-10 11:12:21 +09:00
Guo Xiang Tan	13f3de4bf6	Nuke all SiteSetting.stubs from our codebase.	2017-07-07 15:09:14 +09:00
Guo Xiang Tan	e7e16de3e0	Remove use of stubs in specs.	2017-07-07 13:18:53 +09:00
Jakub Macina	8c445e9f17	Fix backend code for searching by a filetype as a combination of uploads and topic links. Add rspec test for extracting file extension in upload.	2017-07-06 19:19:31 +02:00
Neil Lalonde	fcb2f68565	FIX: duplicate topics and posts in summary email because user has muted tags and topics contain multiple tags	2017-07-04 16:12:10 -04:00
Neil Lalonde	3964929c75	FIX: summary email excludes all untagged topics if user has muted some tags	2017-07-04 12:52:25 -04:00
Sam	845170bd6b	FEATURE: add support for group visibility level ... There are 4 visibility levels - public (default) - members only - staff - owners Note, admins and group owners ALWAYS have visibility to groups Migration treated old "non public" as "members only"	2017-07-03 15:26:57 -04:00
Sam	c79418d334	DEV: Move RTL into lib where it belongs	2017-07-03 15:26:57 -04:00
Arpit Jalan	984778d3ac	FIX: handle moving first post to a closed/archived topic	2017-07-03 21:21:20 +05:30
Arpit Jalan	e7b9b1312e	FEATURE: remove all invites ... https://meta.discourse.org/t/remove-all-invitations-button-for-the-admin-panel/65207	2017-06-29 22:30:10 +05:30
Guo Xiang Tan	5e156fbe85	FIX: Group.search should look up Group#full_name too. ... https://meta.discourse.org/t/mentioning-group-by-full-name-doesnt-work/63437/3	2017-06-29 16:37:59 +09:00
Robin Ward	b93edc9945	FIX: Make sure censored words are on boundaries in topic titles	2017-06-28 13:13:40 -04:00
Guo Xiang Tan	80e348d226	PERF: Speed up slow tests in our test suite. ... Before ``` Finished in 7 minutes 23 seconds (files took 4.15 seconds to load) 7145 examples, 0 failures, 10 pending ``` After ``` Finished in 6 minutes 12 seconds (files took 4.41 seconds to load) 7145 examples, 0 failures, 10 pending ```	2017-06-22 11:23:31 +09:00
Guo Xiang Tan	4c98bd9d5f	FIX: Can't update status_type of topic timers. ... https://meta.discourse.org/t/topic-timers-internal-error-500/64805	2017-06-21 15:31:15 +09:00
Jakub Macina	eaf46431d4	Add extraction of file extension in TopicLink and related rspec tests.	2017-06-19 17:09:54 +02:00
Guo Xiang Tan	b5ec241716	FIX: Validate interpolation keys used in translation overrides. ... https://meta.discourse.org/t/discobot-translation-missing-error/64429/6?u=tgxworld	2017-06-16 08:54:48 +09:00
Régis Hanol	d6c63cc5b2	FIX: user's default group should only be set once ... Setting a user's default groups based on their email address should only be done once, ie. when they confirm their email address. Previously we were doing this everytime we'd save a user record 🤷	2017-06-14 19:20:18 +02:00
Guo Xiang Tan	69dc8188e3	UX: Don't send emails for discobot notifications.	2017-06-14 21:09:47 +09:00
Guo Xiang Tan	2fdf9068eb	FIX: Create notification for group users when group has been invited. ... https://meta.discourse.org/t/inviting-a-group-to-a-message-does-not-trigger-a-notification-mail/50509	2017-06-14 14:53:49 +09:00
Joffrey JAFFEUX	299339a373	Fixes emoji name to code missing tones	2017-06-13 14:10:26 -04:00
Arpit Jalan	b9c94aa234	FEATURE: add required user fields to invite accept form ... UX: make "accept invitation" page consistent with sign up modal	2017-06-12 20:43:07 +05:30
Guo Xiang Tan	e888369f51	UX: Don't send emails for discobot notifications.	2017-06-12 17:00:27 +09:00
Guo Xiang Tan	5794ff53a1	FIX: Copy custom fields when moving first post of a topic. ... https://meta.discourse.org/t/transfer-poll-votes-when-moving-a-topic-into-an-existing-one/63678	2017-06-07 19:04:48 +09:00
Guo Xiang Tan	ac6c1acbed	FIX: Groups that do not have any owners should not allow membership requests.	2017-06-05 10:02:37 +09:00
Sam	096177d0d5	confirm we notify on the destination, not source	2017-06-02 11:20:40 -04:00
Guo Xiang Tan	af3dc4e537	FIX: Publish group's categories to user when adding user to group. ... https://meta.discourse.org/t/joining-a-group-doesnt-take-effect-unless-the-browser-is-hard-refreshed/57357/11?u=tgxworld	2017-06-02 17:38:14 +09:00
Sam	a7fc93acac	FIX: post mover not clearing reply_to_user_id	2017-06-01 18:00:14 -04:00
Guo Xiang Tan	bd486100c0	Remove stubs on DiscourseEvent in tests.	2017-06-01 16:21:00 +09:00
Guo Xiang Tan	b0dd05fdc6	FIX: Inherit topic auto close when changing topic's category.	2017-05-31 17:40:21 +09:00
Sam	0aed2533ac	Revert unread optimisation, has too many edge cases	2017-05-26 09:04:13 -04:00
Guo Xiang Tan	e57d2f5cb8	FIX: Don't do anything if avatar url returns an invalid status code.	2017-05-26 13:02:40 +08:00
Sam	29fac1ac18	PERF: improve performance of unread queries ... Figuring out what unread topics a user has is a very expensive operation over time. Users can easily accumulate 10s of thousands of tracking state rows (1 for every topic they ever visit) When figuring out what a user has that is unread we need to join the tracking state records to the topic table. This can very quickly lead to cases where you need to scan through the entire topic table. This commit optimises it so we always keep track of the "first" date a user has unread topics. Then we can easily filter out all earlier topics from the join. We use pg functions, instead of nested queries here to assist the planner.	2017-05-25 15:07:30 -04:00
Guo Xiang Tan	76229535ac	Remove old test case.	2017-05-22 18:23:09 +08:00
Guo Xiang Tan	08c36fa968	REFACTOR: Clean up some code associated with topic timers.	2017-05-22 18:10:29 +08:00
Neil Lalonde	cbe8e05f79	disable test that fails randomly	2017-05-17 12:46:50 -04:00
Sam	763f156d91	FIX: require re-activation if SSO changes email and updates it	2017-05-16 16:18:18 -04:00
Neil Lalonde	7821400141	FEATURE: staff can set a timer to remind them about a topic	2017-05-16 14:49:50 -04:00
Sam	44d7fe89ed	FIX: unescape emoji in pretty title ... This makes emoji in title consistent, it is later escaped back when needed	2017-05-15 10:28:05 -04:00
Neil Lalonde	55b61e9bea	rename topic_status_update to topic_timer	2017-05-11 18:27:53 -04:00
Régis Hanol	9641d2413d	REFACTOR: upload workflow creation into UploadCreator ... - Automatically convert large-ish PNG/BMP to JPEG - Updated fast_image to latest version	2017-05-11 00:16:57 +02:00
Sam	7d9b5514ba	FIX: correctly invalidate theme css cache on scheme change	2017-05-10 15:47:11 -04:00
Sam	04b5516bf2	improve upload functionality	2017-05-10 15:47:11 -04:00
Sam	27362c5a4b	improve spec	2017-05-10 15:47:11 -04:00
Sam	bc0b9af576	FEATURE: support uploads for themes ... This allows themes to bundle various assets	2017-05-10 15:47:11 -04:00
Sam	f709899a1d	Allow theme field object model to support uploads	2017-05-10 15:46:42 -04:00
Robin Ward	96c59c5b82	FIX: Don't notify or return flags on system users	2017-05-08 13:13:35 -04:00
Sam	257c0dea70	Merge pull request #4852 from tgxworld/pull_the_plug_on_daily_mailing_list ... Remove daily mailing mode option as it doesn't scale.	2017-05-08 09:10:46 -04:00
Guo Xiang Tan	e61959e6a8	FIX: CustomEmoji may contain an invalid upload_id. ... https://meta.discourse.org/t/white-screen-after-deleting-custom-emoji/61608	2017-05-05 14:53:38 +08:00
Guo Xiang Tan	71a266b673	Remove daily mailing mode option as it doesn't scale. ... https://meta.discourse.org/t/daily-updates-option-for-mailing-list-mode/45029/14?u=tgxworld	2017-05-05 12:21:50 +08:00
Guo Xiang Tan	441e0059af	Fix tests that was testing the wrong class.	2017-05-05 10:59:07 +08:00
Sam	4ebbad991e	FIX: properly clean up related color schemes on delete	2017-05-04 14:03:17 -04:00
Sam	342ef5f81a	FEATURE: out-of-the-box dark/light user selectable themes	2017-05-03 11:31:33 -04:00
Arpit Jalan	75300b6356	improve specs	2017-05-03 17:48:33 +05:30
Arpit Jalan	86f1cc8c92	FIX: don't apply max_emails_per_day_per_user on critical emails	2017-05-03 17:07:39 +05:30
Arpit Jalan	cdce060a38	FIX: don't apply max emails per day per user to forgot password	2017-05-03 14:02:37 +05:30
Sam	946f25098f	Refactor theme fields so they support custom theme defined vars ... This paves the way to allowing themes to specify uploads and so on.	2017-05-02 16:02:14 -04:00
Arpit Jalan	77a8cae094	FIX: rescue specific errors on invite failure	2017-05-02 15:13:33 +05:30
Guo Xiang Tan	59b906ab0d	FEATURE: Disable minimum post length check when in PM with non human users. ... https://meta.discourse.org/t/discourse-narrative-bot-beta-feedback/58621/65?u=tgxworld	2017-04-27 16:00:22 +08:00
Arpit Jalan	aeead60036	FIX: make TopicEmbed trashable	2017-04-25 18:40:39 +05:30
Sam	aec73d4003	correct the spec again	2017-04-20 17:41:35 -04:00
Sam	47b99e0922	group is now default watched	2017-04-20 17:38:46 -04:00
Sam	5365973c0a	FIX: detection of error changed, so you can clear errors	2017-04-20 16:55:18 -04:00
Sam	7a9eee1b71	FEATURE: default notification level for group messages ... also fixes it so staff can amend other user's group notification level	2017-04-20 15:47:35 -04:00
Sam	7eabb90b71	FEATURE: added error messages for bad theme CSS / JS	2017-04-19 16:46:46 -04:00
cpradio	2dccaff25d	FIX: Correct behavior of auto-notification state updating to exclude when the topic already has a state of normal/muted	2017-04-19 06:29:35 -04:00
Arpit Jalan	f968b4e662	Fix the build	2017-04-18 16:34:58 +05:30
Arpit Jalan	1c23aedccf	FIX: always send password reset email when accepting invite if password is not set	2017-04-18 14:37:06 +05:30
Arpit Jalan	8dea70d354	Revert "FIX: User website allows new TLDs"	2017-04-18 13:18:51 +05:30
Rafael dos Santos Silva	4289dbe3e5	FIX: User website allows new TLDs	2017-04-18 00:30:37 -03:00
Sam	5e3a0846f7	FEATURE: allow themes to share color schemes	2017-04-17 15:56:24 -04:00
Arpit Jalan	7389831961	Fix the build	2017-04-15 15:52:35 +05:30
Arpit Jalan	0954367bf4	FIX: send activation email when accepting invite if password is set	2017-04-15 14:59:50 +05:30
Guo Xiang Tan	04016f0dec	Support Ruby 2.4.	2017-04-15 12:29:00 +08:00
cpradio	e3ad50de05	Add spec for auto notification update ... It should update the topic subscription so long as what is being requested is higher than what is currently set for the user and the given topic It should not update the topic subscription if the requested subscription is less than what is currently set for the user and given topic	2017-04-14 18:30:01 -04:00
Sam	def7348777	FIX: display custom sections with default theme ... also cleans up mechanism for previewing themes, cleans up naming, gets rid of old janky "preview_style", secures local theme key	2017-04-14 13:35:12 -04:00
Guo Xiang Tan	bda20cc44a	FIX: Don't enqueue topic status update job if topic is deleted.	2017-04-13 12:02:35 +08:00
Guo Xiang Tan	57788200ec	REFACTOR: Add User.reserved_username?.	2017-04-13 10:44:26 +08:00
Sam	a7ed8a0310	correct theme importer to support embedded.scss	2017-04-12 11:30:16 -04:00
Sam	95d095c97d	test should be configuring git info	2017-04-12 11:19:47 -04:00
Sam	a3e8c3cd7b	FEATURE: Native theme support ... This feature introduces the concept of themes. Themes are an evolution of site customizations. Themes introduce two very big conceptual changes: - A theme may include other "child themes", children can include grand children and so on. - A theme may specify a color scheme The change does away with the idea of "enabled" color schemes. It also adds a bunch of big niceties like - You can source a theme from a git repo - History for themes is much improved - You can only have a single enabled theme. Themes can be selected by users, if you opt for it. On a technical level this change comes with a whole bunch of goodies - All CSS is now compiled using a custom pipeline that uses libsass see /lib/stylesheet - There is a single pipeline for css compilation (in the past we used one for customizations and another one for the rest of the app - The stylesheet pipeline is now divorced of sprockets, there is no reliance on sprockets for CSS bundling - CSS is generated with source maps everywhere (including themes) this makes debugging much easier - Our "live reloader" is smarter and avoid a flash of unstyled content we run a file watcher in "puma" in dev so you no longer need to run rake autospec to watch for CSS changes	2017-04-12 10:53:49 -04:00
Dean Taylor	1a9afa976d	FEATURE: Add AWS S3 EU (London) "eu-west-2" region	2017-04-12 10:38:17 -04:00
Guo Xiang Tan	7cb389a235	Add DiscourseEvent trigger when user's topic notification level changes.	2017-04-12 11:56:50 +08:00
Arpit Jalan	8fb41bf5fb	FIX: update timestamp when resending invite	2017-04-11 20:02:32 +05:30
Guo Xiang Tan	73180c8a19	FIX: Private message can be set to publish in the future.	2017-04-11 20:44:25 +08:00
Robin Ward	e2ff06ce02	FIX: rounding error in spec	2017-04-07 17:44:02 -04:00
Robin Ward	40cee37bcc	FIX: Don't insert topic status messages unless the status changes	2017-04-07 17:10:43 -04:00
Guo Xiang Tan	71501feaf3	Improve validation for TopicStatusUpdate.	2017-04-07 15:32:00 +08:00
David Rodríguez	934bff43d9	FIX: Copy post actions when moving a topic.	2017-04-06 12:16:22 +08:00
Guo Xiang Tan	ad44d2a400	Merge pull request #4790 from tgxworld/add_publish_to_topic_status_update ... FEATURE: Allow admins to schedule a topic to be published in the future.	2017-04-04 11:18:53 +08:00
Guo Xiang Tan	f4758a4c4d	FEATURE: Allow admins to schedule a topic to be published in the future.	2017-04-04 11:16:05 +08:00
Arpit Jalan	5ff29ce321	add test case for topic status update based on last post	2017-04-03 22:35:56 +05:30
Guo Xiang Tan	5cf75c67df	FIX: Callback undefined error when topic has been deleted.	2017-04-03 09:06:15 +08:00
Guo Xiang Tan	ed577fbff8	FEATURE: Pause a topic instead of permanently closing when flag threshold is reached.	2017-03-31 14:35:05 +08:00
Guo Xiang Tan	34b7bee568	FEATURE: Allow admin to auto reopen at topic. ... * This commit also introduces a `TopicStatusUpdate` model to support other forms of deferred topic status update in the future.	2017-03-31 11:14:18 +08:00
Robin Ward	7b6242bfbb	Minor cleanup of /users/ rename	2017-03-30 10:23:24 -04:00
Robin Ward	14410b71fb	Convert server side paths to use /u/	2017-03-30 10:23:24 -04:00
Robin Ward	45a257815a	Convert front end paths from /users/ to /u/	2017-03-30 10:23:24 -04:00
Guo Xiang Tan	7cf0f39066	Require Sidekiq::Testing in rails helper.	2017-03-29 11:10:25 +08:00
Arpit Jalan	4812417192	FIX: do not add user to group based on email domain unless email is confirmed	2017-03-28 15:02:40 +05:30
Arpit Jalan	3378e2d49f	FIX: update topic fancy title when updating category name	2017-03-26 12:29:53 +05:30
Arpit Jalan	295cf8839e	FIX: better error message when invited user already exists	2017-03-22 13:55:28 +05:30
Arpit Jalan	8cbfa24ca2	Fix failing test	2017-03-20 20:14:25 +05:30
Arpit Jalan	521c88fe58	FIX: enqueue activation email for invited user that has password set	2017-03-20 17:13:21 +05:30
Guo Xiang Tan	6057e17ae7	Fix weird test failure.	2017-03-20 12:06:37 +08:00
Robin Ward	fd591257a8	Merge pull request #4759 from kennym/support-ports-for-ip-addresses-in-embedding ... FIX: Allow ports for embed host IPs	2017-03-16 11:23:42 -04:00
Guo Xiang Tan	bf78c228f4	FIX: User created web hook being enqueued before record has been saved. ... * Improve web hook tests as well.	2017-03-16 14:44:09 +08:00
Erick Guan	cfbfea0596	FEATURE: Allow easier customization to the web hook event serialization.	2017-03-16 10:09:05 +08:00
Kenny Meyer	ae957bca25	Allow ports for embed host IPs	2017-03-15 18:16:34 -03:00
Guo Xiang Tan	d173473509	Fix randomly failing specs.	2017-03-14 14:43:48 +08:00
Sam	64680286f4	correct logic, so revalidation is reset ... correct test so it can run at any point	2017-03-13 10:47:43 -04:00
Sam	ef24fd54ba	FEATUE: automatically validate token is stored in redis ... This ensures we have some handling for redis flushall We attempt to recover our in-memory session token once every 30 seconds Code is careful to only set the token if it is nil, to allow for manual cycling to remain safe if needed	2017-03-13 10:19:02 -04:00
Guo Xiang Tan	4d4a1a1552	Add scope for human users.	2017-03-11 14:25:09 +08:00
Sam	99f4d5082b	FIX: Improve token rotation and increase logging ... - avoid access denied on bad cookie, instead just nuke it - avoid marking a token unseen for first minute post rotation - log path in user auth token logs	2017-03-07 13:27:43 -05:00
Robin Ward	dad57fa033	FIX: More errors with non-ascii URLs	2017-03-07 11:21:41 -05:00
Guo Xiang Tan	d1e587c10a	Merge pull request #4737 from oblakeerickson/approve_invited_user ... FIX: approve invited user	2017-03-07 21:14:34 +08:00
Guo Xiang Tan	7d82a53dfe	FIX: Group#name is case insensitive.	2017-03-06 17:24:03 +08:00
Guo Xiang Tan	8aea3caf00	FIX: Ensure that we only move posts that belong to the original topic.	2017-03-06 15:04:10 +08:00
Blake Erickson	dbb3ddc7a6	FIX: approve invited user ... This commit fixes the case where invited users who typed in a password would not be approved by default. Because we moved the user create logic for an invited user there was a clash with the `save` in the user model and the `save` in the invite_redeemer class. - added approve logic into invite_redeemer class. - added tests to verify that the user is approved - added a check to see if must_approve_users is on - added a check to see if the inviter is staff - go ahead and approve the user if must_approve_users is off - keep existing User.approve workflow if user exists - improve if/else logic to remove duplicate code - use `Time.zone.now`	2017-03-05 06:58:23 -07:00
Guo Xiang Tan	bcf634ca85	Merge pull request #4728 from nbianca/username-regex ... Add support for username regex.	2017-03-03 22:59:23 +08:00
Bianca Nenciu	30909ec54e	Add support for username regex.	2017-03-02 13:53:45 +02:00
Neil Lalonde	262016604d	FEATURE: each category can control how many topics to show on categories page	2017-03-01 15:12:57 -05:00
Sam	3ac4709903	FIX: on initial token issue stop unmarking token as unseen ... prev and current are the same so we need special logic to bypass	2017-02-28 10:38:22 -05:00
Robin Ward	bf9626d031	FIX: Embedding was broken with non-english URLs and ports	2017-02-27 12:17:52 -05:00
Sam Saffron	7e8f0dc967	FIX: attempt to handle ios edge case where token is seen but unsaved ... This relaxes our security in the following way - prev auth token is always accepted as long as rotation date is within our window of SiteSetting.maximum_session_age.hours (previously old token expired within a minute of new one being seen) - new auth token is marked unseen if we are presented with an old token after we already saw new one This attempts to fix an issue where ios webkit is not committing new cookies	2017-02-26 17:09:57 -05:00
Neil Lalonde	c94fdcea38	FIX: admin dashboard posts count should not include system posts and whispers	2017-02-21 14:45:41 -05:00
Régis Hanol	cb99f59ec3	reset bounce score when email is successfully changed	2017-02-20 10:37:01 +01:00
Robin Ward	e62c0a42fa	FIX: Support multiple embeddable host records with the same host	2017-02-17 12:41:34 -05:00
Neil Lalonde	c0e1722ca6	fix intermittent spec failure due to Time comparison with TimeWithZone	2017-02-17 10:30:29 -05:00
Neil Lalonde	3fb50d587d	FIX: invited users and new TL1 users will see their first notification highlighted	2017-02-17 10:30:29 -05:00
Neil Lalonde	4b28bfaa15	Merge pull request #4710 from ento/fix-s3-config-check ... FIX: admin dashboard shouldn't complain when using IAM profile for S3 access	2017-02-15 17:02:07 -05:00
Neil Lalonde	d0fbb27f3e	FEATURE: new invite acceptance page, where username can be chosen and password can be set	2017-02-15 16:51:57 -05:00
Sam	9c51e3e8e7	amend preloader api to supply topic list	2017-02-15 12:04:02 -05:00
Sam	2c59ffeb2c	FIX: token rotation not accounting for overlapping tokens correctly ... also... freeze_time has no block form, correct all usages and specs	2017-02-15 10:58:18 -05:00
Marica Odagaki	af9c97ec43	Add failing tests	2017-02-15 00:05:58 -08:00
Marica Odagaki	2c1279b740	Fix typo to be more consistent with other test descriptions	2017-02-15 00:04:10 -08:00
Sam	f2099c3811	adjust API	2017-02-14 16:32:33 -05:00
Sam	89d5e8ab4b	FEATURE: allow plugins to preload data in topic list	2017-02-14 16:29:06 -05:00
Sam	0ab96a7691	FEATURE: add hidden setting for verbose auth token logging ... This is only needed to debug auth token issues, will result in lots of logging	2017-02-13 14:01:09 -05:00
Robin Ward	e1d358ffbf	FIX: Don't clear the login hint when the system user is saved	2017-02-13 10:54:20 -05:00
Jeff Atwood	3ee7a9266c	Merge pull request #4686 from tgxworld/group_is_visible_if_user_is_group_owner ... FIX: Show groups that user is owner of on groups page.	2017-02-11 22:18:44 -08:00
Sam Saffron	4332f0dde1	FEATURE: allow user search API to restrict to group	2017-02-09 18:45:39 -05:00
Sam	49e7124a5e	clarify override semantics in spec	2017-02-07 10:41:27 -05:00
Sam	f34907b523	Merge pull request #4681 from vietqhoang/feature/add-user-title-to-sso-payload ... FEATURE: Add user title to SSO payload	2017-02-07 10:25:32 -05:00
Sam	ff49f72ad9	FEATURE: per client user tokens ... Revamped system for managing authentication tokens. - Every user has 1 token per client (web browser) - Tokens are rotated every 10 minutes New system migrates the old tokens to "legacy" tokens, so users still remain logged on. Also introduces weekly job to expire old auth tokens.	2017-02-07 09:22:16 -05:00
Régis Hanol	84af84dc52	prevent inactive & staged users from being automatically added to a group	2017-02-06 17:49:27 +01:00
Robin Ward	b251d11518	FIX: If you make a new banner, clear the old dismissed values	2017-02-03 15:07:38 -05:00
Guo Xiang Tan	61111a3f9b	FIX: Show groups that user is owner of on groups page.	2017-02-03 16:51:32 +08:00
Arpit Jalan	6b8691ecea	Merge pull request #4685 from techAPJ/approve-users-invite-fix ... FIX: allow existing users to be invited to topic/message when must_approve_users is enabled	2017-02-03 13:22:18 +05:30
Arpit Jalan	dc2171960b	FIX: allow existing users to be invited to topic/message when must_approve_users is enabled	2017-02-03 13:01:23 +05:30
Guo Xiang Tan	c392994793	Fix specs.	2017-02-03 08:38:19 +08:00
Neil Lalonde	b91cb92af0	FIX: reports for time to first reply and topics without replies were counting whispers and moderator actions	2017-02-02 17:27:41 -05:00
Guo Xiang Tan	3c28d94706	FIX: Don't configure Redis connector if Redis slave config is not set.	2017-02-02 13:48:55 +08:00
Viet Hoang	40164ccd4a	Add user title to SSO payload	2017-01-31 16:42:27 -08:00
Rimian Perkins	25516874b5	FIX: Escape regexp chars in SiteSetting.censored_words.	2017-01-31 10:14:51 +08:00
Guo Xiang Tan	0e5d490b05	No need for special helper to reset SiteSetting state. ... * SiteSetting in tests uses a local provider that resets it.	2017-01-28 10:55:49 +08:00
Neil Lalonde	7ead3e1f18	fix failing specs	2017-01-27 16:17:10 -05:00
Robin Ward	496682c442	Merge pull request #4662 from tgxworld/fix_localized_group_name_change ... Fix localized group name change	2017-01-26 10:50:00 -05:00
Guo Xiang Tan	ce07da1d8b	UX: Only display the words that fails censored words validations.	2017-01-24 13:11:05 +08:00
Guo Xiang Tan	59dfb51a35	FIX: Don't change automatic group name if localized name has been taken.	2017-01-18 12:20:23 +08:00
Guo Xiang Tan	63954c1b33	FIX: Same user record being saved twice causing validation to fail.	2017-01-16 16:41:03 +08:00
Guo Xiang Tan	e3b6f9b8ae	FIX: Do not update user stats like counts for private messages.	2017-01-16 11:07:53 +08:00
Guo Xiang Tan	ed5fa20b0c	Revert "FIX: error during signup saying "Password is the same as your current password" due to automatic group membership granting a trust level" ... This reverts commit 9c40657ba4. Calling this whenever a user is initialize is hurting us bad on performance.	2017-01-16 09:44:10 +08:00
Régis Hanol	887e9af84f	FEATURE: new 'max_image_megapixels' site setting	2017-01-11 23:37:12 +01:00
Guo Xiang Tan	3d21ccd4a5	FIX: Add validation to disallow censored words in topic title.	2017-01-09 16:55:41 +08:00
Guo Xiang Tan	f1beef43a8	Merge pull request #4618 from tgxworld/fix_invalid_emails ... FIX: Don't allow invalid email to be saved.	2016-12-30 07:11:48 +08:00
Neil Lalonde	9c40657ba4	FIX: error during signup saying "Password is the same as your current password" due to automatic group membership granting a trust level	2016-12-28 17:36:04 -05:00
Arpit Jalan	d72cbcb2a4	FEATURE: new setting to validate user website	2016-12-26 21:29:27 +05:30
Sam	c531f4ded5	remove rails-observers ... Rails yanked out observers many many years ago, instead the functionality was yanked out to a gem that is very lightly maintained. For example: if we want to upgrade to rails 5 there is no published gem Internally the usage of observers had quite a few problem. The series of refactors renamed a bunch of classes to give us more clarity and removed some magic.	2016-12-22 16:46:53 +11:00
Sam	019f1a1d06	UserEmailObserver is now removed ... no big surprises here was pretty straightforward after_commit semantics sure are weird though	2016-12-22 16:46:53 +11:00
Sam	2f6a4cc6de	remove UserActionObserver, replace with after_save and service ... interestingly there was some left over dead code from when stars existed in the topic_users table	2016-12-22 16:46:53 +11:00
Sam	0a78ae739d	Remove SearchObserver, aim is to remove all observers ... rails-observers gem is mostly unmaintained and is a pain to carry forward new implementation contains significantly less magic as a bonus	2016-12-22 13:13:14 +11:00
Guo Xiang Tan	13c6191e89	FIX: Don't allow invalid email to be saved.	2016-12-21 17:47:11 +08:00
Guo Xiang Tan	5d7f3223f0	SECURITY: Users can only bookmark posts which they can see.	2016-12-21 12:01:26 +08:00
Neil Lalonde	74956694e5	If summary email finds no topics, show topics more than 1 day old from new users	2016-12-19 14:54:08 -05:00
Neil Lalonde	923cf73c6e	Topic Featured Links: move data from custom fields to topics and categories tables. Invert behaviour of topic_featured_link_allowed checkbox. Fix a bug with invalid topic records due to changing that category checkbox.	2016-12-19 14:54:07 -05:00
Sam	eb2db23b40	FEATURE: remove email_token_grace_period_hours ... The site setting email_token_grace_period_hours just causes confusion and should not be used anyway. Out of the box, tokens stop working once confirmed, no need to add complexity here	2016-12-19 17:15:20 +11:00
Sam	15b5fddd49	SECURITY: protect upload params, only allow very strict filenames	2016-12-19 10:16:18 +11:00
Guo Xiang Tan	69330f8bc2	Add user_updated event to webhooks.	2016-12-13 11:26:26 +08:00
Guo Xiang Tan	9a800107cb	FIX: Associate category logo and background to uploads record.	2016-12-12 17:37:28 +08:00
Guo Xiang Tan	05f55dbc10	FEATURE: Group logs.	2016-12-12 17:29:54 +08:00
Neil Lalonde	24d2973108	enable featured links by default	2016-12-09 16:08:17 -05:00
Sam	846597f563	FIX: staff tags are stripped by non-staff	2016-12-09 17:24:26 +11:00
Erick Guan	52763f5115	FEATURE: Allow posting a link with topics	2016-12-05 17:20:54 +01:00
Régis Hanol	06469ef0ce	FIX: don't extract links from .elided parts	2016-12-05 15:19:15 +01:00
Guo Xiang Tan	adb7fcb6b3	FEATURE: Add bio to group page.	2016-12-05 16:58:04 +08:00
Sam	33d0a23d84	Merge branch 'fix_whisper'	2016-12-05 10:01:03 +11:00
Guo Xiang Tan	3971f96aa6	Merge pull request #4536 from fantasticfears/webhooks-edit ... FIX: missing post and topic edited webhooks	2016-12-02 10:16:19 +01:00
Sam	9b885c039a	Merge branch 'master' into fix_whisper	2016-12-02 17:44:05 +11:00
Sam	c04d4171ff	FIX: whisper no longer experimental ... - Regular users are not notified of whispers - Regular users no longer have "stuck" topics in unread - Additional tracking for staff highest post number - Remove a bunch of unused columns in topics table	2016-12-02 17:03:31 +11:00
Erick Guan	8c8549b27b	FIX: missing post and topic edited webhooks	2016-11-30 20:49:45 +01:00
Régis Hanol	dec8a861f0	FIX: don't raise exception when a quote was already extracted	2016-11-30 17:18:34 +01:00
Guo Xiang Tan	b889bfefbb	PERF: Don't calculate the same query twice.	2016-11-24 14:05:26 +08:00
Arpit Jalan	2d0c99636a	do not add rel noreferrer	2016-11-20 18:19:14 +05:30
Arpit Jalan	7cb76f7333	FIX: add rel noopener and noreferrer in addition to nofollow	2016-11-20 17:07:27 +05:30
Guo Xiang Tan	8c6d8c85db	Stop showing first notification prompt once user sees the notification.	2016-11-17 09:44:00 +08:00
Guo Xiang Tan	98c1e0832c	FIX: Track first notification read using Redis.	2016-11-16 16:20:38 +08:00
Guo Xiang Tan	16fdcdfc00	FIX: Add conditions on when to show first pm notification.	2016-11-16 14:17:47 +08:00
Leo McArdle	784366f1a0	FIX: display only 1 trust level badge on user card ... refactoring graciously provided by @xfalcox	2016-11-14 20:53:24 +00:00
Sam	3d76ce1421	FEATURE: SSO support for adding and removing a user to groups ... Use: add_groups with a comma delimited list to ensure a user is in groups (using group names) Use: remove_groups with a comma delimited list to ensure a user is removed from groups (using group names)	2016-11-11 16:57:31 +11:00
Arpit Jalan	9e69798285	FEATURE: watch first post default site setting	2016-11-10 00:09:52 +05:30
Guo Xiang Tan	b18439a1e2	Fix build.	2016-11-08 17:00:44 +08:00