Commit Graph

16411 Commits

Author SHA1 Message Date
Guo Xiang Tan
e6d07fa6d8 UX: Allow admins to manage automatic groups on group page. 2018-04-04 11:07:11 +08:00
Joffrey JAFFEUX
b1cc368da8
FIX: regression where tag could not be deleted with click 2018-04-04 00:56:45 +02:00
Arpit Jalan
88e4c0ec3a FIX: new/unread tabs should re-appear dynamically 2018-04-04 00:08:31 +05:30
Neil Lalonde
b7ecdb72d6 FIX: update Google Tag Manager javascript 2018-04-03 14:22:06 -04:00
Robin Ward
76d734ea6e A more extensible way to disable expanding/contracting of user profiles 2018-04-03 14:19:56 -04:00
Robin Ward
0188cbb650 UX: New dropdowns work well on mobile for category notifications 2018-04-03 12:09:00 -04:00
Robin Ward
a383b368c6 FIX: The order of import globbing is not deterministic
Using a wildcard would load in a different order on some installs
resulting in unpredictable behavior (for example, `is-hidden` being
displayed due to a `display: flex` in a different file.)
2018-04-03 11:40:53 -04:00
Guo Xiang Tan
6f32de186a UX: Add a "add members" button on group page. 2018-04-03 17:35:18 +08:00
Joffrey JAFFEUX
61812b52e7
FIX: more conservative refactoring to avoid regressions in customisations 2018-04-03 10:35:22 +02:00
Arpit Jalan
54819d72c9 UX: show users who liked the post when expanding post actions 2018-04-03 08:24:09 +05:30
Joffrey JAFFEUX
d54da517d9
FIX: more resilient focus filter or header 2018-04-02 22:50:20 +02:00
Joffrey JAFFEUX
017f5c1aee
FIX: regression preventing backspace to work on mini-tag-chooser 2018-04-02 22:42:20 +02:00
Robin Ward
58c81db279 Apply a 'no-group' class to quotes for styling 2018-04-02 14:02:16 -04:00
Robin Ward
90d3544db8 UX: Add a class we can use to target quotes without groups 2018-04-02 14:02:16 -04:00
Guo Xiang Tan
00d879ec63 Fix the build. 2018-04-03 00:44:12 +08:00
Guo Xiang Tan
2498403bc3 Revert "FIX: Username uniqueness check should not happen to current user_id"
This reverts commit f71a18facd.
2018-04-03 00:44:04 +08:00
Joffrey JAFFEUX
5685b45fa6
FIX: manually adds tag if existing but not in returned matches 2018-04-02 18:33:46 +02:00
Vinoth Kannan
f71a18facd FIX: Username uniqueness check should not happen to current user_id 2018-04-02 21:59:11 +05:30
Kris
2eec572159 minor alignment fix on new like button 2018-04-02 12:17:50 -04:00
Joffrey JAFFEUX
8f2b305b9a
FIX: calling incorrect method 2018-04-02 18:02:45 +02:00
Arpit Jalan
5e4dd20795 Revert "Prevent robots from indexing uploads"
This reverts commit 0fd622e5d1.
2018-04-02 21:29:29 +05:30
Robin Ward
23e97a3c3a UX: Add classes for extensibility 2018-04-02 11:55:25 -04:00
Joffrey JAFFEUX
a828da33aa
FIX: regression preventing addition of multiple tags in a group 2018-04-02 17:54:40 +02:00
Vinoth Kannan
16341219ab Log exception if remote theme importing failed 2018-04-02 20:10:18 +05:30
Guo Xiang Tan
221503cd10 FIX: Add server side uniqueness validations for Group#name and User#username.
https://meta.discourse.org/t/groups-can-be-given-same-name-as-existing-username/74010
2018-04-02 18:19:18 +08:00
Guo Xiang Tan
d2a8f40fb0
Merge pull request #5711 from Supermathie/learn_cdn_url_hostname
FIX: CDN_URL hostname should be in GlobalSetting.hostnames
2018-04-02 16:39:24 +08:00
Guo Xiang Tan
d4ebbd12a6
Merge pull request #5723 from featheredtoast/topic-list-item-unread-classnames
Feature: Add unseen-topic and new-posts classnames to topic list items
2018-04-02 16:35:19 +08:00
Guo Xiang Tan
142571bba0 Remove use of rescue nil.
* `rescue nil` is a really bad pattern to use in our code base.
  We should rescue errors that we expect the code to throw and
  not rescue everything because we're unsure of what errors the
  code would throw. This would reduce the amount of pain we face
  when debugging why something isn't working as expexted. I've
  been bitten countless of times by errors being swallowed as a
  result during debugging sessions.
2018-04-02 13:52:51 +08:00
Vinoth Kannan
efb19dbdaf
Merge pull request #5705 from discourse/new_webhooks
FEATURE: Webhook for group and category events
2018-04-02 10:53:21 +05:30
Guo Xiang Tan
87e3779085
Merge pull request #5702 from kevinelliott/feature/20180323-fix-mass-assignment
20180323 Fix Mass Assignment Warning
2018-04-02 10:19:25 +08:00
Arpit Jalan
82b1dc6934 UX: consistent spacing for like button on mobile 2018-04-01 07:18:07 +05:30
Jeff Wong
03b2590036 Add unseen-topic and new-posts classnames to topic lists
Adds classname descriptions for new, unread posts, and closed statuses on topic-list-items.

Allows for new/unread/closed topic-list-items to be targeted with css directly.
2018-03-31 11:57:03 -07:00
Arpit Jalan
cddaad7a55 UX: hide empty 'new' and 'unread' tabs for tl1 and above 2018-03-31 11:42:20 +05:30
Arpit Jalan
9df7fd4f30 FIX: discourse-solved plugin controls (buttons) should be in first place 2018-03-31 07:42:54 +05:30
Arpit Jalan
9815f301cc UX: alignment was off on likes for your own post 2018-03-31 07:21:18 +05:30
Blake Erickson
31ce955487 Add destroy rake task
Adds several rake tasks to delete users, topics, pm's and site stats so
that you can have a fresh site but maintain site settings and category
structure.
2018-03-30 18:32:21 -06:00
Kris
4fcbe9128e Minor color/alignment adjustment on like button 2018-03-30 16:46:37 -04:00
Arpit Jalan
4760f0e7a9 UX: better like button
Co-authored-by: jjaffeux <j.jaffeux@gmail.com>
2018-03-30 22:45:51 +05:30
Arpit Jalan
67efdaea40 FIX: properly hide nav items 2018-03-30 12:32:29 +05:30
Arpit Jalan
15945bcf15 UX: when there is nothing new or unread to show, remove those options from the top nav. 2018-03-30 11:38:44 +05:30
Arpit Jalan
bf41010ac3 UX: make own post heart glyph grey 2018-03-30 10:35:54 +05:30
Arpit Jalan
fe17ee6924 UX: own post likes glyph margin was off 2018-03-30 10:10:55 +05:30
Arpit Jalan
a55b458e56 UX: show heart glyph on your own likes count 2018-03-30 09:06:57 +05:30
Jeff Atwood
131b19c26b move like count a tad closer to like glyph 2018-03-29 16:36:59 -07:00
Arpit Jalan
629ad48621 UX: better likes count margin 2018-03-30 03:02:56 +05:30
Arpit Jalan
9bf87f3665 UX: remove word "likes" from first post 2018-03-30 02:45:32 +05:30
Robin Ward
22b631510c FIX: Silenced user wasn't being linked properly 2018-03-29 17:07:09 -04:00
Robin Ward
e4298a91b8 Pass silenced_by through to DiscourseEvent 2018-03-29 16:44:18 -04:00
Arpit Jalan
ef07045aca fix the build 2018-03-30 02:09:48 +05:30
Arpit Jalan
6bef0428cc UX: remove the word 'likes' from the like counters on posts within topic 2018-03-30 01:46:00 +05:30
Arpit Jalan
fda8b3d879 UX: updated 'new dot' styling 2018-03-30 01:25:39 +05:30
Neil Lalonde
73c1d3e7fe FIX: tag notification preferences were being cleared when other preferences were changed 2018-03-29 15:08:32 -04:00
Robin Ward
ec6bbe2af0 FIX: Show error if dashboard can't load 2018-03-29 14:12:29 -04:00
Robin Ward
e4a5b0c39a
Merge pull request #5715 from jjaffeux/remove-title-user-notifications
FIX: remove unneeded and uninformative title on user notifications list
2018-03-29 09:23:09 -04:00
Joffrey JAFFEUX
99cf091774
FIX: do not lighten color when no selection for cat and tag drops 2018-03-29 15:20:47 +02:00
Joffrey JAFFEUX
3287ac77e0
FIX: reverts combobox placeholder and introduces noneLabel
noneLabels works almost like none but instead of actually adding a row in the list, it will only change the text displayed in the header, when there's no selection.
2018-03-29 13:42:00 +02:00
Guo Xiang Tan
125434dcdf Minor style tweak on groups page. 2018-03-29 18:14:17 +08:00
Guo Xiang Tan
52e75eaee9 UX: Tweaks to group pages. 2018-03-29 17:04:48 +08:00
Guo Xiang Tan
27f06505b1 Allow placeholder to be configured for combo-box. 2018-03-29 17:04:48 +08:00
Joffrey JAFFEUX
a64cc9a990
FEATURE: allow users to collapse profile after expanding it 2018-03-29 10:53:57 +02:00
Joffrey JAFFEUX
9260969101
FIX: correctly shows education text for categories 2018-03-29 10:33:44 +02:00
Guo Xiang Tan
3b3e6ed23f Fix deprecation warnings in Ember.
See https://emberjs.com/deprecations/v2.x/#toc_ember-router-router-renamed-to-ember-router-_routermicrolib
2018-03-29 10:01:29 +08:00
Guo Xiang Tan
90f91bf017 Fix regression due to ee69d58a59. 2018-03-29 10:01:29 +08:00
Kris
6e569e5bfd X button for mobile edits in composer 2018-03-28 20:47:56 -04:00
Kris
cf3c670cb7 Fixing table top-border alignment issue 2018-03-28 18:49:19 -04:00
Robin Ward
eab64710ff FIX: Shared draft performance fix + missing avatars 2018-03-28 16:11:43 -04:00
Robin Ward
4b5977aa6a Revert "PERF: Don't join on shared drafts unless you have to"
This reverts commit efedd9745f.
2018-03-28 15:35:13 -04:00
Robin Ward
efedd9745f PERF: Don't join on shared drafts unless you have to 2018-03-28 13:57:39 -04:00
Régis Hanol
fa608f2bb4 FIX: ensure theme variables are unique when adding an upload 2018-03-28 18:57:11 +02:00
Robin Ward
31d0998506 FIX: Don't allow links with no href 2018-03-28 12:32:16 -04:00
Joffrey JAFFEUX
466f09bbc4 FIX: remove uneeded and uninformative title on user notifications list 2018-03-28 17:05:42 +02:00
Vinoth Kannan
dc33f2d071 Add new web hook serializers 2018-03-28 17:40:29 +05:30
Joffrey JAFFEUX
e5dc8ab5c1
FIX: correctly localizes period chooser row title 2018-03-28 13:19:25 +02:00
Joffrey JAFFEUX
334a611e13
FIX: adds spacing between category name and text in topic timers 2018-03-28 13:08:47 +02:00
Arpit Jalan
70c4630320 FEATURE: show sub navigation for selected PM tag 2018-03-28 13:08:01 +05:30
Guo Xiang Tan
ee69d58a59 FIX: Tests could get stucked in infinite loop if it fails to resolve IP of a hostname. 2018-03-28 14:49:05 +08:00
Arpit Jalan
03725c7c8a FIX: add reserved usernames for ‘/u/’ static routes 2018-03-28 11:15:38 +05:30
Guo Xiang Tan
347e4eadbc Don't retry trying to download a file in test. 2018-03-28 12:54:11 +08:00
Guo Xiang Tan
21ae49ab92 Simplify log in for request specs. 2018-03-28 11:32:47 +08:00
Guo Xiang Tan
70be8124a3 SECURITY: Don't expose development route in production. 2018-03-28 11:32:47 +08:00
Guo Xiang Tan
baa383b7f1 Fix the build. 2018-03-28 09:42:12 +08:00
Guo Xiang Tan
8bc5da57b0 No need to default aria-label to label. 2018-03-28 09:11:50 +08:00
Guo Xiang Tan
08d68e846c UX: Don't default title to label text for buttons. 2018-03-28 09:03:35 +08:00
Neil Lalonde
90c0198a57 FIX: watched word counts always show as 0 2018-03-27 17:27:00 -04:00
Robin Ward
ddefc29c4e FIX: Lint error 2018-03-27 17:19:38 -04:00
Robin Ward
05dc1f65ab UX: Editing a shared draft was confusing in the composer
Now when you edit a shared draft it looks like creating one, where the
destination category id appears in the dropdown.
2018-03-27 17:11:21 -04:00
Neil Lalonde
c9216626d8
Merge pull request #5688 from discourse/fix-embed-comments-template-error
FIX: Make sure a post has replies before accessing the reply_id
2018-03-27 15:30:53 -04:00
Michael Brown
976d6b290c FIX: CDN_URL hostname should be in GlobalSetting.hostnames 2018-03-27 15:20:22 -04:00
Neil Lalonde
eb714d8ae3 FIX: application request count keys not expiring in redis 2018-03-27 15:12:39 -04:00
Neil Lalonde
2bd44bbf13 WebCrawlerRequest.clear_cache needs to clear user agent list too 2018-03-27 15:11:48 -04:00
Neil Lalonde
7311023a52
Merge pull request #5700 from discourse/crawl-block
FEATURE: control web crawlers access with white/blacklist
2018-03-27 15:06:03 -04:00
Neil Lalonde
3fab5267be fix web crawler stats sorted in reverse 2018-03-27 14:10:39 -04:00
Neil Lalonde
df345d80f9 fix wrong case 2018-03-27 13:53:47 -04:00
Neil Lalonde
4d12ff2e8a when writing cache, remove elements from the user agents list. also return a message and content type when blocking a crawler. 2018-03-27 13:44:14 -04:00
Joffrey JAFFEUX
15aa712227
fix category-row regressions 2018-03-27 14:11:05 +02:00
Vinoth Kannan
ff9d7a9bfb FIX: authComplete query param should carry-forward to login page 2018-03-27 17:22:07 +05:30
Arpit Jalan
518f7ba91b FIX: show private message topic count on admin dashboard reports 2018-03-27 17:10:33 +05:30
Guo Xiang Tan
94deb482ae Don't show cancel button on edit page. 2018-03-27 19:31:53 +08:00
Guo Xiang Tan
b06104a1da Missing trust level options on group form. 2018-03-27 19:30:53 +08:00
Guo Xiang Tan
757dd1032d Incorrect save label for group form. 2018-03-27 19:29:00 +08:00
Guo Xiang Tan
f6b6ddd73c REFACTOR: Extract group form into a component. 2018-03-27 19:26:05 +08:00
Joffrey JAFFEUX
f81af74ad8
FIX: makes sure category desc is displayed as row title when possible 2018-03-27 12:25:05 +02:00
Guo Xiang Tan
7edab1c0b9 UX: Add groups/custom/new route for admins to create a new group. 2018-03-27 17:39:05 +08:00
Gerhard Schlager
558914b986 Fix random spec errors 2018-03-27 11:14:06 +02:00
Vinoth Kannan
e7407d0adc FEATURE: Webhook for group and category events 2018-03-27 11:53:35 +05:30
Guo Xiang Tan
68ae009f98 Update group navigation link style. 2018-03-27 13:52:28 +08:00
Guo Xiang Tan
2ecd234e27 UX: Consolidation group manangement into a single tab. 2018-03-27 13:34:46 +08:00
Neil Lalonde
f2c060bdf2 FEATURE: option for tags in a tag group to be visible only to staff 2018-03-26 17:05:09 -04:00
Kris
09b9b56091 adding a class to post activity link 2018-03-26 14:04:42 -04:00
Kris
2aca08b75e Adding data-category-id to category page for mobile 2018-03-26 10:00:43 -04:00
Guo Xiang Tan
dcd1d422d1 UX: Allow admins to set users as owners while adding users.
https://meta.discourse.org/t/adding-owners-members-ux-is-inconsistent-and-misleading/58084/9
2018-03-26 17:33:50 +08:00
Guo Xiang Tan
35745166b5 UX: New group membership management workflow.
https://meta.discourse.org/t/adding-owners-members-ux-is-inconsistent-and-misleading/58084
2018-03-26 16:15:02 +08:00
Guo Xiang Tan
3d18cd1d9d Raise error when timestamp is invalid when creating topic timers.
https://meta.discourse.org/t/topic-timer-doesnt-work-for-fa-ir-locale/83702
2018-03-26 11:33:52 +08:00
Guo Xiang Tan
252e58dfe9 FIX: Could not create topic timers for certain locales.
https://meta.discourse.org/t/topic-timer-doesnt-work-for-fa-ir-locale/83702/2
2018-03-26 10:51:49 +08:00
Guo Xiang Tan
2f61780a49 Remove file that is no longer used. 2018-03-26 10:27:28 +08:00
Régis Hanol
9d6d8631ad Revert "FIX: remove scrolling jankiness"
This reverts commit b1a799b526.
Was not working properly on mobile...
2018-03-24 03:53:28 +01:00
Régis Hanol
c5c1d8e180 Add support for the '/p/:post_id' route on the client-side 2018-03-24 02:44:39 +01:00
Régis Hanol
3a58dc0858 Add new 'jumpToPostId' plugin API method 2018-03-24 02:43:39 +01:00
Régis Hanol
f56a746d71 Add baseUri to site model 2018-03-24 02:43:19 +01:00
Régis Hanol
b1a799b526 FIX: remove scrolling jankiness 2018-03-24 02:39:36 +01:00
Blake Erickson
9fdf139235 Add tests for Site Settings import/export
- extracted out site settings rake task to a class
- added tests for import and export of site settings
2018-03-23 14:55:17 -06:00
Kevin Elliott
fa0868fc3f Explicit param permit and assignment cleanup. 2018-03-23 09:59:31 -07:00
Robin Ward
5f19ad9507 FIX: allow destination categories to be set if not at first 2018-03-23 11:33:02 -04:00
Robin Ward
38af67eb73 Update the destination category id when a user changes it 2018-03-23 11:12:56 -04:00
Kris
6e4b8901ce Removing extra margin on tag-chooser 2018-03-23 10:32:27 -04:00
Sam
62f09af1c2 UX: occasionally getting scrollbar while loading notifications 2018-03-23 18:19:28 +11:00
Guo Xiang Tan
c294798561 Fix alignment of groups filter inputs on FF. 2018-03-23 13:46:02 +08:00
Guo Xiang Tan
3f59ba20ec Align .control-labels with input field. 2018-03-23 13:42:17 +08:00
Guo Xiang Tan
7a4b70ef58 UX cleanup changes to 2FA flow. 2018-03-23 11:05:36 +08:00
Sam
0db13f62eb FIX: unable to remove tags from topics in quick save 2018-03-23 13:55:24 +11:00
Kris
803b53f2e3
Adding space before URL click-counter for improved copy & paste-ability (#5698) 2018-03-22 21:27:08 -04:00
Arpit Jalan
9a184b355d
Merge pull request #5696 from techAPJ/instagram-aspect-image
UX: wrap instagram images with aspect ratio
2018-03-23 04:00:52 +05:30
Neil Lalonde
ced7e9a691 FEATURE: control which web crawlers can access using a whitelist or blacklist 2018-03-22 15:41:02 -04:00
Joffrey JAFFEUX
cbbeedf53b
FIX: fires onExpand/onCollapse when using arrows 2018-03-22 18:35:46 +01:00
Joffrey JAFFEUX
841e2ba723
FIX: prevents multiple search call when destroying multiple tags 2018-03-22 18:11:47 +01:00
Joffrey JAFFEUX
037cc63b91
FIX: minor alignments improvements to select-kit 2018-03-22 17:17:28 +01:00
Arpit Jalan
33c1aeb2ac UX: wrap instagram images with aspect ratio 2018-03-22 21:35:10 +05:30
Arpit Jalan
4a6fb242bd UX: correct styling for Instagram onebox 2018-03-22 21:11:47 +05:30
Joffrey JAFFEUX
4f61f5db27
FIX: event is not present here
TODO: make event accessible everywhere and in a more consitent way.
2018-03-22 16:17:23 +01:00
Guo Xiang Tan
16c6af2ab0 Focus on input when showing 2FA form in login modal. 2018-03-22 21:45:28 +08:00
Guo Xiang Tan
62ee332efa Fix lint. 2018-03-22 21:12:41 +08:00
Guo Xiang Tan
0a567d0176 UX: Add mobile template for group members page. 2018-03-22 20:59:30 +08:00
Joffrey JAFFEUX
d48542796e
FIX: select-kit refactoring
- improve mini-tag-chooser keyboard behavior
- all multil select now respond to select all and left/right arrows
- improve events handling
- many minor tweaks
2018-03-22 11:29:55 +01:00
Jeff Atwood
d7c2d2edb8 remove extraneous "click to show" copy 2018-03-22 02:19:57 -07:00
Guo Xiang Tan
fa95699fde Fix the build. 2018-03-22 14:20:27 +08:00
Arpit Jalan
3a62eba299 bump onebox version 2018-03-22 11:38:01 +05:30
Guo Xiang Tan
f3b402ffd5 UX: Allow users to filter members on group page.
* Only admins are allowed to filter users by email.
2018-03-22 14:02:41 +08:00
Guo Xiang Tan
1cc0961566 FEATURE: Allow admin to manage group owners on group page. 2018-03-22 12:33:42 +08:00
Guo Xiang Tan
bfe38b2118 FIX: limit wasn't correctly applied to Upload.migrate_to_new_scheme. 2018-03-22 10:56:06 +08:00
Guo Xiang Tan
ae6be6e364 Fix alignment of filter inputs on groups page. 2018-03-22 09:45:24 +08:00