Blake Erickson
a900c99993
DEV: Add external_id to notification payload
...
If sso is enabled the notification payload will now include the
external_id for the user.
This was requested on meta: https://meta.discourse.org/t/-/129052/10
2020-07-13 12:07:39 -06:00
dependabot-preview[bot]
33554e5cbc
Build(deps): Bump cose from 1.1.0 to 1.2.0 ( #10223 )
...
Bumps [cose](https://github.com/cedarcode/cose-ruby ) from 1.1.0 to 1.2.0.
- [Release notes](https://github.com/cedarcode/cose-ruby/releases )
- [Changelog](https://github.com/cedarcode/cose-ruby/blob/master/CHANGELOG.md )
- [Commits](https://github.com/cedarcode/cose-ruby/compare/v1.1.0...v1.2.0 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-07-13 12:30:39 -04:00
Dan Ungureanu
cf02c518b9
DEV: Merge category and tag hashtags code paths ( #10216 )
...
Category and tag hashtags used to be handled differently even though
most of the code was very similar. This design was the root cause of
multiple issues related to hashtags.
This commit reduces the number of requests (just one and debounced
better), removes the use of CSS classes which marked resolved hashtags,
simplifies a lot of the code as there is a single source of truth and
previous race condition fixes are now useless.
It also includes a very minor security fix which let unauthorized users
to guess hidden tags.
2020-07-13 19:13:17 +03:00
dependabot-preview[bot]
c5da813ff5
Build(deps): Bump rubocop-rspec from 1.41.0 to 1.42.0 ( #10207 )
...
Bumps [rubocop-rspec](https://github.com/rubocop-hq/rubocop-rspec ) from 1.41.0 to 1.42.0.
- [Release notes](https://github.com/rubocop-hq/rubocop-rspec/releases )
- [Changelog](https://github.com/rubocop-hq/rubocop-rspec/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop-hq/rubocop-rspec/compare/v1.41.0...v1.42.0 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-07-13 12:01:43 -04:00
Bianca Nenciu
6c6c56613d
FIX: Check if last poster exists before using it
...
There was a problem when admins viewed topics where the last poster was
deleted.
2020-07-13 18:55:14 +03:00
dependabot-preview[bot]
c8856c7a43
Build(deps): Bump rake-compiler from 1.1.0 to 1.1.1 ( #10206 )
...
Bumps [rake-compiler](https://github.com/luislavena/rake-compiler ) from 1.1.0 to 1.1.1.
- [Release notes](https://github.com/luislavena/rake-compiler/releases )
- [Changelog](https://github.com/rake-compiler/rake-compiler/blob/master/History.txt )
- [Commits](https://github.com/luislavena/rake-compiler/compare/v1.1.0...v1.1.1 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-07-13 11:52:56 -04:00
Jarek Radosz
a96ff82e53
FIX: Set the lang/xml:lang html attrs in emails ( #10218 )
...
In some rare cases emails are incorrectly sent out with lang placeholders in body (`xml:lang="%{html_lang}"`)
2020-07-13 16:39:40 +02:00
Arpit Jalan
8e2f57a498
Fix the build.
2020-07-13 18:52:04 +05:30
Arpit Jalan
7532f24668
UX: better error message if moderator is not allowed to invite to group
...
UX: do not show invite to group option if mod is not owner of any group
2020-07-13 18:09:36 +05:30
Arpit Jalan
ba57dc57cc
DEV: use group_ids instead of group_names in invite params
2020-07-13 17:37:04 +05:30
Jarek Radosz
eb73048b0f
DEV: Allow displaying both title and panels in modals ( #10220 )
2020-07-13 12:43:06 +02:00
Bianca Nenciu
4492718864
FIX: Skip whisper posts when updating topic like count ( #10157 )
2020-07-13 16:30:00 +10:00
Guo Xiang Tan
54d002f7db
DEV: Fix error introduced in d5c56a846.
2020-07-13 10:13:37 +08:00
Guo Xiang Tan
753477e684
FIX: Slightly reduce fake delay of discobot user.
...
Previously it would sleep for either 2 or 3 seconds instead of sleeping
between a range of 2 to 3 seconds. Also, 2 to 3 seconds seems to be
excessivly long when I tried out discobot again.
2020-07-13 09:08:31 +08:00
Krzysztof Kotlarek
180494185c
FIX: last visit bar regression ( #10224 )
...
Last visit regression bar is missing because of that change https://github.com/discourse/discourse/commit/9b7000dbf10
Order property was changed from "default" to null and it was picked by guard condition
2020-07-13 10:42:05 +10:00
Jarek Radosz
6c91f795d0
DEV: widget-dropdown CSS tweaks ( #10219 )
...
* DEV: Remove the margin from widget-dropdown
Generic components should not have a margin. Those should be styled in the place where they are used.
* DEV: Remove margin from the dropdown body
It triggered a warning in popper and was effectively a no-op as popper positions dropdowns on its own using `position: fixed` and `top/right/bottom/left` properties.
2020-07-13 01:27:31 +02:00
Jarek Radosz
942cc9b57a
DEV: Add rawTitle property support to modal-tab ( #10221 )
...
```js
const panels = [
{ id: "test1", rawTitle: "Test 1" },
{ id: "test2", rawTitle: "Test 2" }
];
showModal("a-modal", { panels }));
```
2020-07-13 01:26:45 +02:00
Blake Erickson
544a9865c6
DEV: Add more API Doc specs for topic endpoints
...
Added some more specs that will be used to auto generate the api docs.
Added timed topic and update timestamp endpoints.
2020-07-10 12:08:09 -06:00
David Taylor
fbf29443bd
FIX: Allow signup when auth provider supplies no email
2020-07-10 17:56:33 +01:00
Bianca Nenciu
275b748016
FIX: Replace links to removed uploads from reviewables with a placeholder ( #10180 )
2020-07-10 17:57:06 +03:00
David Taylor
4b0d86d8d3
FIX: Do not display enabled inputs when username/name are locked
2020-07-10 10:49:32 +01:00
Dan Ungureanu
c72bc27888
FEATURE: Implement support for IMAP and SMTP email protocols. ( #8301 )
...
Co-authored-by: Joffrey JAFFEUX <j.jaffeux@gmail.com>
2020-07-10 12:05:55 +03:00
Dan Ungureanu
e88b17c044
FIX: Sync client and server side behavior for category hashtag lookup
...
Category.query_from_hashtag_slug is the only source of truth.
2020-07-10 10:45:39 +03:00
Martin Brennan
56f42d89c5
FIX: Post menu bookmark icon and attributes not refreshing on notification click ( #10214 )
...
When creating a bookmark reminder that deletes the bookmark on reminder, if the user clicked on the notification and got taken to the post in the topic the bookmark icon still showed as blue with the reminder clock indicator. This was because the response JSON for reloading a topic post was not including the bookmark attributes, not even the bookmarked boolean.
We now return the correct attributes in the serializer, and if bookmarked is false we clear all the bookmark related attributes on the post for the notification to make sure nothing of the old bookmark remains in the UI.
This was only a problem if the user did not refresh the app completely inbetween setting the reminder and receiving the notification.
2020-07-10 14:35:53 +10:00
Martin Brennan
9a2955d471
FIX: Migrate topic_users.bookmarked to false when it is incorrectly true ( #10211 )
...
Follow up to https://github.com/discourse/discourse/pull/10188/files
There are still TopicUser records where bookmarked is true even though there are no Bookmark or PostAction records with the type of bookmark for the associated topic and user. This migration corrects this issue by setting bookmarked to false for these cases.
2020-07-10 12:22:15 +10:00
Penar Musaraj
37f7e41e60
DEV: Remove Google+ icon from sprite
2020-07-09 21:29:39 -04:00
Kris
706f1a6294
DEV: Remove text-ellipsis component and use CSS line-clamp instead ( #10196 )
2020-07-09 20:51:43 -04:00
Rafael dos Santos Silva
831f3cab56
DEV: Fix search rate limit tests
2020-07-09 20:44:17 -03:00
Blake Erickson
e74817cbb9
DEV: Document set notification level endpoint
...
Another commit using rswag to document the api so that the api docs can
be automatically generated.
2020-07-09 17:41:11 -06:00
Rafael dos Santos Silva
e866e3d609
FEATURE: Add global rate limit for anon searches ( #10208 )
2020-07-10 09:08:34 +10:00
Kane York
79b52b1e9a
DEV: Add SVG tests for 31e31ef44 ( #10205 )
2020-07-09 14:02:25 -07:00
Mark VanLandingham
bfde665e76
DEV: Classes and plugin-outlet in admin user-list nav ( #10204 )
2020-07-09 15:10:25 -05:00
Robin Ward
5b276af921
Remove Discourse.SiteSettings from tests ( #10193 )
...
* Remove unused Discourse.SiteSettings
* Remove `Discourse.SiteSettings` from many tests
* REFACTOR: `lib:formatter` was using a lot of leaky state
* Remove more `Discourse.SiteSettings` from tests
* More SiteSettings removed from tests
2020-07-09 15:54:53 -04:00
Robin Ward
b1c6ff9e1c
FIX: Test output related to Discourse::VERSION
...
It's a little awkward to test constants by re-assigning them so
I've added a new parameter to `Discourse.find_compatible_resource`
which can be used by tests.
2020-07-09 14:57:27 -04:00
Robin Ward
c2ce7f2673
FIX: Flaky test
...
The previous solution was not always working, I believe this one
will be consistent.
2020-07-09 14:48:49 -04:00
dependabot-preview[bot]
dadf08fb3b
Build(deps): Bump cose from 1.0.0 to 1.1.0 ( #10203 )
...
Bumps [cose](https://github.com/cedarcode/cose-ruby ) from 1.0.0 to 1.1.0.
- [Release notes](https://github.com/cedarcode/cose-ruby/releases )
- [Changelog](https://github.com/cedarcode/cose-ruby/blob/master/CHANGELOG.md )
- [Commits](https://github.com/cedarcode/cose-ruby/compare/v1.0.0...v1.1.0 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-07-09 14:13:32 -04:00
Robin Ward
10384bcdf4
FIX: Flaky tests
...
Locally I was getting a lot of failures from discourse-encrypt due to
leaky state in composer actions. This fixes it.
2020-07-09 12:58:57 -04:00
Mark VanLandingham
52f8eecbb9
FIX: Incorrect fix for invites breaking when no group is selected ( #10202 )
2020-07-09 11:58:29 -05:00
Mark VanLandingham
9d74cf6a63
FIX: Invites when no group is selected ( #10201 )
2020-07-09 11:41:17 -05:00
David Taylor
cb1f891392
Revert "FIX: Incorrect search blurb when advanced search filters are used."
...
This change was causing advanced search filters to disappear from the search input
This reverts commit 2e1eafae06
2020-07-09 16:19:18 +01:00
Daniel Waterworth
8d5750d90a
FIX: Catch all kinds of exceptions when processing email
2020-07-09 13:41:51 +01:00
Daniel Waterworth
3b368a48d1
Revert "DEV: Add logging for stack level too deep exception in HtmlToMarkdown"
...
We can do this in a better way by storing an IncomingEmail record.
Follow-up-to: 4a9ee25c56
2020-07-09 13:41:33 +01:00
Jarek Radosz
32ee9fae40
FIX: Short URL resolution in cook-text ( #10200 )
...
Regressed in 3b51e05de2
2020-07-09 14:39:13 +02:00
Daniel Waterworth
4a9ee25c56
DEV: Add logging for stack level too deep exception in HtmlToMarkdown
2020-07-09 12:25:00 +01:00
Martin Brennan
e0713455ca
PERF: Load topic bookmarks for the user in user_post_bookmarks ( #10197 )
...
Instead of loading all of the user bookmarks using all the post IDs in a topic, load all the bookmarks for a user using the topic ID. This eliminates a costly WHERE ID IN query.
2020-07-09 15:46:52 +10:00
Guo Xiang Tan
d5c56a846a
DEV: Only failover the entire cluster when the default db goes down.
2020-07-09 11:49:03 +08:00
Martin Brennan
31e31ef449
SECURITY: Add content-disposition: attachment for SVG uploads
...
* strip out the href and xlink:href attributes from use element that
are _not_ anchors in svgs which can be used for XSS
* adding the content-disposition: attachment ensures that
uploaded SVGs cannot be opened and executed using the XSS exploit.
svgs embedded using an img tag do not suffer from the same exploit
2020-07-09 13:31:48 +10:00
Guo Xiang Tan
fd38c2fac3
FIX: Force ActiveRecord reading role if Redis is down take 2.
...
follow-up f03c7a1ba1
2020-07-09 11:14:19 +08:00
Guo Xiang Tan
f03c7a1ba1
FIX: Force ActiveRecord reading role if Redis is down.
2020-07-09 11:13:02 +08:00
Guo Xiang Tan
cbe1dd8ec7
Revert "FIX: Delete related search data when record has been deleted."
...
This reverts commit ecc799ab56
2020-07-09 10:08:35 +08:00
