7 Commits

Author	SHA1	Message	Date
Joffrey JAFFEUX	0d3d2c43a0	DEV: s/\$redis/Discourse\.redis (#8431) ... This commit also adds a rubocop rule to prevent global variables.	2019-12-03 10:05:53 +01:00
Sam Saffron	4ea21fa2d0	DEV: use #frozen_string_literal: true on all spec ... This change both speeds up specs (less strings to allocate) and helps catch cases where methods in Discourse are mutating inputs. Overall we will be migrating everything to use #frozen_string_literal: true it will take a while, but this is the first and safest move in this direction	2019-04-30 10:27:42 +10:00
Guo Xiang Tan	685c26961f	Fix randomly failing specs.	2017-03-14 16:28:05 +08:00
Guo Xiang Tan	e3e31441b8	FIX: Random Redis connection timeout failure in Travis.	2016-05-18 10:42:40 +08:00
Guo Xiang Tan	b4e0c5afe0	FIX: Fetch stats if it has not been cached.	2016-04-21 14:50:25 +08:00
Andy Waite	3e50313fdc	Prepare for separation of RSpec helper files ... Since rspec-rails 3, the default installation creates two helper files: * `spec_helper.rb` * `rails_helper.rb` `spec_helper.rb` is intended as a way of running specs that do not require Rails, whereas `rails_helper.rb` loads Rails (as Discourse's current `spec_helper.rb` does). For more information: https://www.relishapp.com/rspec/rspec-rails/docs/upgrade#default-helper-files In this commit, I've simply replaced all instances of `spec_helper` with `rails_helper`, and renamed the original `spec_helper.rb`. This brings the Discourse project closer to the standard usage of RSpec in a Rails app. At present, every spec relies on loading Rails, but there are likely many that don't need to. In a future pull request, I hope to introduce a separate, minimal `spec_helper.rb` which can be used in tests which don't rely on Rails.	2015-12-01 20:39:42 +00:00
Guo Xiang Tan	b0ea6764e0	PERF: Cache About#stats.	2015-07-20 22:45:05 +08:00