110 Commits

Author	SHA1	Message	Date
Sam Saffron	704c579550	FIX: do not allow unbound membership lookups ... Previously we would allow looking up membership limits in an unbound way via the API, this introduces an upper limit of 1000 per page.	2019-06-17 15:32:06 +10:00
Roman Rizzi	c3a38d2304	DEV: Make groups/new extensible by plugins (#7642) ... * Expose a new plugin outlet. Pass group model to the group-member-dropdown so it can be accessed by plugins * Added controller tests for group custom fields. update custom fields when updating a group	2019-06-06 12:05:33 +10:00
Robin Ward	d26c4509ea	FIX: Adding a user to a group twice under concurrency ... This prevents an error from being raised / logged.	2019-05-27 15:42:40 -04:00
Penar Musaraj	dfcc2e7ad8	Revert "FEATURE: Send notification when member was accepted to group. (#7503)" ... This reverts commit 42c82d544e.	2019-05-27 15:19:59 -04:00
Bianca Nenciu	42c82d544e	FEATURE: Send notification when member was accepted to group. (#7503)	2019-05-27 17:28:41 +03:00
Sam Saffron	30990006a9	DEV: enable frozen string literal on all files ... This reduces chances of errors where consumers of strings mutate inputs and reduces memory usage of the app. Test suite passes now, but there may be some stuff left, so we will run a few sites on a branch prior to merging	2019-05-13 09:31:32 +08:00
Guo Xiang Tan	dca7f8ecf2	FIX: Loading more broken on groups page. ... Regressed in 1f17d52f55.	2019-04-30 10:35:17 +08:00
Bianca Nenciu	9050b1bf5a	FIX: Add unique index on group_requests(group_id, user_id). (#7399)	2019-04-23 12:51:30 +10:00
Maja Komel	1f17d52f55	UX: new layout for groups page, allow changes to automatic group bio (#7350)	2019-04-17 22:44:30 -04:00
Bianca Nenciu	a9798f0c47	FEATURE: Add page for all group membership requests. (#6909)	2019-03-27 13:30:59 +02:00
Blake Erickson	de47b35b2d	FIX: user_id handling on remove user from group ... Under some conditions it was possible to pass in a user_id as an integer, but we would try and parse it as a comma delimited string resulting in an error. This has been fixed so that we are no longer mapping the user_id param to user_ids.	2019-01-24 17:40:48 -07:00
Maja Komel	1d649e147b	FEATURE: show avatar flair on group, badges and directory pages (#6732)	2018-12-06 12:18:52 +01:00
Sam	ceafcbc898	FEATURE: show added date when looking at group members	2018-11-01 15:33:28 +11:00
Blake Erickson	93485facaf	FIX: lowercase username for add/rem group members ... This fix searches for users based on the downcased username so that if you pass in usernames to add/remove from a group and you don't have the casing just right it will still find the correct users. I updated the tests to add a username that has a mix of upper and lowercase letters to verify this functionality.	2018-10-18 13:17:24 -06:00
Blake Erickson	13b3cead06	FEATURE: Allow bulk removing users from a group ... This change maintains backwards compatibility to allow you to remove a single user from a group but allows you to specify a comma separated list of users for bulk removal from a group. Also it extracts out common functionality for fetching users from params used in bulk adding users so it can also be used for removing users.	2018-10-11 15:30:54 -06:00
Kyle Zhao	7b19ed06c1	reworked specs of existing group behavior	2018-09-17 17:46:43 +10:00
Guo Xiang Tan	b4f92a05b3	FIX: Load more on groups page does not account for params. ... https://meta.discourse.org/t/cant-scroll-through-list-of-users-groups-if-more-than-one-page/92259	2018-08-20 17:08:50 +08:00
Guo Xiang Tan	919e8db686	FIX: Check for group name availability should skip reserved usernames.	2018-08-01 11:09:33 +08:00
Sam	6a54da0902	FIX: raise invalid params for bad callback ... Corrects it so we raise a 400 instead of logged 500 error	2018-06-29 10:43:33 +10:00
Sam	982df3c17b	FIX: return status 400 for invalid member params ... previously error returned was a 500 which is not ideal and is logged	2018-06-29 10:15:17 +10:00
Guo Xiang Tan	a83ab01264	REFACTOR: Remove extra param for group mentionable and messableable route.	2018-06-06 09:42:09 +08:00
Arpit Jalan	f8d82f135f	FIX: do not verify group visibility when checking for mentionable/messageable	2018-06-05 16:59:21 +05:30
Guo Xiang Tan	467d91347a	Missing specs for Group, Tag, Category and Flag web hooks.	2018-05-21 17:29:58 +08:00
Guo Xiang Tan	70d181bff8	FIX: Better error message in GroupsController#add_members. ... https://meta.discourse.org/t/cant-add-members-to-a-group/85738?u=tgxworld	2018-04-20 10:28:52 +08:00
Guo Xiang Tan	d9d86577ff	FIX: Staff users are not affected by enable_group_directory site setting.	2018-04-10 09:22:01 +08:00
Guo Xiang Tan	c82b2dcc24	Remove admin group management pages.	2018-04-09 15:14:50 +08:00
Guo Xiang Tan	0623785f69	FIX: Prevent group owners from editing admin only settings.	2018-04-06 11:44:58 +08:00
Guo Xiang Tan	e36e9de28a	Allow admin to view logs of automatic groups.	2018-04-05 16:31:55 +08:00
Guo Xiang Tan	8760c4d68c	Fix GroupsController#group_params to allow more group attributes to be updated.	2018-04-05 13:53:00 +08:00
Vinoth Kannan	efb19dbdaf	Merge pull request #5705 from discourse/new_webhooks ... FEATURE: Webhook for group and category events	2018-04-02 10:53:21 +05:30
Guo Xiang Tan	52e75eaee9	UX: Tweaks to group pages.	2018-03-29 17:04:48 +08:00
Guo Xiang Tan	7edab1c0b9	UX: Add groups/custom/new route for admins to create a new group.	2018-03-27 17:39:05 +08:00
Gerhard Schlager	558914b986	Fix random spec errors	2018-03-27 11:14:06 +02:00
Vinoth Kannan	e7407d0adc	FEATURE: Webhook for group and category events	2018-03-27 11:53:35 +05:30
Guo Xiang Tan	2ecd234e27	UX: Consolidation group manangement into a single tab.	2018-03-27 13:34:46 +08:00
Guo Xiang Tan	35745166b5	UX: New group membership management workflow. ... https://meta.discourse.org/t/adding-owners-members-ux-is-inconsistent-and-misleading/58084	2018-03-26 16:15:02 +08:00
Guo Xiang Tan	f3b402ffd5	UX: Allow users to filter members on group page. ... * Only admins are allowed to filter users by email.	2018-03-22 14:02:41 +08:00
Guo Xiang Tan	a23509cbf3	UX: Limit the number of group names displayed on user page.	2018-03-21 16:38:33 +08:00
Guo Xiang Tan	9f216ac182	FIX: Infinite loading more on groups page.	2018-03-21 09:25:42 +08:00
Guo Xiang Tan	15bcfcd182	UX: Allow users to filter by different group types on groups page.	2018-03-20 17:38:11 +08:00
Guo Xiang Tan	41b0fbe001	UX: Indicate user's group membership on groups page.	2018-03-19 18:29:30 +08:00
Guo Xiang Tan	05ea034490	UX: Allow groups page to be searchable.	2018-03-19 17:16:51 +08:00
Guo Xiang Tan	0522aabaab	UX: Allow user_count on groups page to be sortable.	2018-03-19 16:15:13 +08:00
Guo Xiang Tan	fe96ef6ed2	UX: Use topic list for displaying group messages on group page. ... https://meta.discourse.org/t/group-inbox-on-a-groups-page-mockup/71319	2018-03-16 11:56:40 +08:00
Guo Xiang Tan	a35227918f	UX: Display group topics in a topic list.	2018-03-15 11:37:55 +08:00
Maja Komel	76a2fc3d07	UX: Add og metadata for groups. ... https://meta.discourse.org/t/onebox-for-groups/79155	2018-02-22 15:03:41 +08:00
Sam	41986cdb2f	Refactor requires login logic, reduce duplicate code ... This also corrects the positioning in the chain of the check and removes misuse of prepend_before_action	2018-02-01 15:17:59 +11:00
Sam	f2e7b74d88	FIX: don't return 200s when login is required to paths ... When running `ensure_login_required` it should always happen prior to `check_xhr` cause check xhr will trigger a 200 response	2018-02-01 12:26:45 +11:00
Robin Ward	74b9828731	FIX: Remove mentions filters from user and groups ... Additionally return no data if disabled	2017-12-07 16:29:02 -05:00
Guo Xiang Tan	ab2a5cef38	FIX: Can't edit membership request template on group page.	2017-11-02 08:51:43 +08:00