Joffrey JAFFEUX
067d454937
FIX: makes sur we have polls before validating
2017-12-05 12:07:21 -05:00
Joffrey JAFFEUX
1e0bfa1d97
FIX: poll new_post_manager spec
2017-12-04 16:12:40 +01:00
Joffrey JAFFEUX
63bab32816
FEATURE: introduces minimum trust level for polls ( #5391 )
...
* FEATURE: introduces minimum trust level for polls
This commit makes `poll_enabled` less misleading and introduces `poll_minimum_trust_level_to_create`. If poll are enabled they will always be cooked, and if you have the required trust level you can create polls. As a side effect, it also fixes a bug where rebaking a post created by staff member when `poll_enabled=false` would end up not cooking it.
It also adds more tests to ensure settings are respected.
* admins should be whitelisted
* checks for admin in post validation
* test for >= instead of == trust level
2017-12-04 14:47:11 +01:00
Guo Xiang Tan
77d4c4d8dc
Fix all the errors to get our tests green on Rails 5.1.
2017-09-25 13:48:58 +08:00
Sam
43c0111ca1
FIX: multichoice poll with more than 25 votes
...
In the past we would double up on avatars due to incorrect logic for
handling offset
2017-08-14 15:33:59 -04:00
Régis Hanol
80daa7006c
use new reload-friendly API
2017-08-12 04:22:44 +02:00
Guo Xiang Tan
5012d46cbd
Add rubocop to our build. ( #5004 )
2017-07-28 10:20:09 +09:00
Sam
8317fb12e0
FIX: don't escape html of poll options
2017-07-25 13:38:19 -04:00
Sam
93e5112dfa
correct poll specs
2017-07-18 14:31:22 -04:00
Guo Xiang Tan
112ca20c96
Merge pull request #4675 from tgxworld/fix_polls_forever_broken_if_approval_required
...
FIX: Polls permanently broken if post requires approval.
2017-03-01 12:56:03 +08:00
Guo Xiang Tan
8bd8f07ce0
FIX: Public polls should not make a request per option.
2017-01-31 17:27:43 +08:00
Guo Xiang Tan
bed11dfa0e
FIX: Polls permanently broken if post requires approval.
2017-01-26 13:29:43 +08:00
Guo Xiang Tan
f9ef1e1997
Opps this broke polls.
2016-07-29 14:28:09 +08:00
Guo Xiang Tan
6538363c18
PERF: Reduce the number of queries when voting.
2016-07-29 14:02:48 +08:00
Guo Xiang Tan
c3cab98998
FEATURE: Admins should be able to create polls even when plugin is disabled.
2016-07-13 18:05:19 +08:00
Robin Ward
a546395397
REFACTOR: Migrate markdown functionality in ES6
2016-07-11 12:57:05 -04:00
Guo Xiang Tan
8d46727d67
FEATURE: Poll UI Builder.
2016-06-15 11:14:24 +08:00
Guo Xiang Tan
a36203ff78
PERF: Paginate public polls.
2016-06-12 16:14:53 +08:00
Guo Xiang Tan
8ecde35df3
FEATURE: Add public type to polls.
2016-06-08 16:19:13 +08:00
Guo Xiang Tan
a849fae5ee
Add specs for polls ( #4246 )
...
* Extract validation logic into a service object.
* Extract logic for updating polls custom fields into a service object.
* Use `strip_heredoc` instead.
* FIX: Polls do not update when configuration has been changed.
2016-06-06 17:04:56 +02:00
Gerhard Schlager
f1bc7de541
Adds support for anonymous votes to the poll plugin
2016-04-23 22:44:09 +02:00
Robin Ward
e91379916b
FIX: Provide the ability to reduce cooked content
...
This allows us to strip polls from the group posts page.
2016-04-13 13:25:18 -04:00
Régis Hanol
b575f97ece
FIX: allows polls on closed topics
2016-03-21 12:12:25 +01:00
Sam Saffron
57944a0694
PERF: only subscribe to a topic once for polls
...
in the past as views were created and destroyed poll subscriptions would change
this caused a lot of load on messaging bus and uneeded traffic
2016-01-06 20:36:09 +11:00
Régis Hanol
72e7271687
FIX: '.intersect?' isn't available in older version of ruby
2015-12-02 17:25:01 +01:00
Régis Hanol
f4184aea33
FIX: properly re-compute # of voters in multiple-choice polls
2015-12-02 12:33:34 +01:00
Régis Hanol
96cd36e86d
FIX: properly compute the number of voters using only valid options
2015-11-30 11:23:38 +01:00
Régis Hanol
515fc49727
FIX: replace polls with a link in emails
2015-10-22 19:10:07 +02:00
Régis Hanol
8f2b002203
FIX: a poll option cannot be voted more than 100% of the time
2015-10-16 17:18:22 +02:00
Gerhard Schlager
bb52042b46
FIX: Add missing pluralization keys to poll plugin locale
2015-09-27 21:36:57 +02:00
Régis Hanol
2e76c9165a
FIX: polls are always editable until the first vote
2015-09-25 18:54:15 +02:00
Régis Hanol
60bbd81607
FIX: polls with votes were preventing users from updating the post
2015-09-14 19:27:54 +02:00
Kane York
af042ffe5e
FEATURE: Per-plugin settings buttons, "Enabled" column
...
Also, added enabled_site_setting to the Poll plugin so it shows up properly.
2015-07-02 10:59:06 -07:00
Régis Hanol
c240a8bd80
FIX: make sure we can't vote on deleted polls
2015-06-01 22:31:47 +02:00
Régis Hanol
f736b6face
FIX: validate poll parameters when type=multiple
2015-06-01 19:28:05 +02:00
Régis Hanol
3a9907f392
FIX: prevent self-xss in poll attributes
2015-05-11 20:09:17 +02:00
riking
7238c43018
SECURITY: XSS in poll errors dialog
2015-05-08 19:28:04 -07:00
Régis Hanol
875a013ec7
FIX: poll design on mobile
2015-05-07 19:49:06 +02:00
Régis Hanol
c1bb7bc7cc
clarify copy when editing a poll after the first 5 minutes
2015-05-07 17:24:35 +02:00
Régis Hanol
033761d2f6
FIX: reset all votes when the # of options changes
2015-05-06 18:52:09 +02:00
Régis Hanol
86d7412f30
REFACTOR: rename "total_votes" poll field to the more accurate "voters"
...
FEATURE: automagically load plugin's migrations
2015-05-04 16:01:57 +02:00
Sam
c3e3afcb2c
PERF: eliminate N+1 query due to polls
2015-05-04 16:12:03 +10:00
Sam
803feefd54
MessageBus handles readonly redis now, no need to wrap it
2015-05-04 12:21:00 +10:00
Gerhard Schlager
9bc750e43d
Extract the parsing of polls
2015-05-02 23:44:45 +02:00
Régis Hanol
2954c99a1e
FEATURE: new 'poll_maximum_options' site setting to limit the number of options in a poll
2015-05-01 16:44:51 +02:00
Régis Hanol
f83638c154
FIX: check the selected options when casting a vote
2015-05-01 16:33:24 +02:00
Régis Hanol
202b442b86
FEATURE: new 'poll:migrate_old_polls' rake task
2015-04-29 23:34:40 +02:00
Régis Hanol
6af71bd601
FIX: polls requires a refresh to work when inserted in the stream
2015-04-27 18:59:29 +02:00
Régis Hanol
10270593a4
FIX: remove links in poll email notification
2015-04-26 00:37:27 +02:00
Régis Hanol
8dc8aaaeb0
fix build
2015-04-26 00:22:29 +02:00
