github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2024-12-16 04:03:46 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity
30,001 Commits 214 Branches 500 Tags 960 MiB
abc39c492a
Commit Graph

1525 Commits

Author SHA1 Message Date
Joffrey JAFFEUX
c754ece8f5
FEATURE: drops with-email-link and replaces it by with-email-button 2018-07-02 14:35:50 +02:00
Maja Komel
3ddfc12307 unify user preferences views 2018-07-02 15:38:36 +10:00
Guo Xiang Tan
d1c3eb6bfa FIX: Recovering a post does not insert it back into the stream correctly. 2018-06-29 11:41:44 +08:00
Joffrey JAFFEUX
9f4e814dbc
tests for XSS injection in tooltips 2018-06-28 14:24:21 +02:00
Maja Komel
ec3e6a81a4 FEATURE: Second factor backup 2018-06-28 10:12:32 +02:00
Jeff Atwood
7dce8290ed copyedit on category drop down 2018-06-26 12:43:45 -07:00
OsamaSayegh
d81f8ea378
fix prettier 2018-06-26 15:31:43 +03:00
OsamaSayegh
bfe0178270 FIX: use the correct notification levels titles for PMs 2018-06-26 14:01:52 +02:00
Joffrey JAFFEUX
eb9b99e519
FIX: makes select-kit match searches with accents (filter and content) 2018-06-26 12:19:14 +02:00
Joffrey JAFFEUX
f2dbe66367
FEATURE: adds a /admin/reports route to list all reports 2018-06-18 12:31:56 +02:00
Joffrey JAFFEUX
60ff0e9b8c
missing prettified files 2018-06-15 18:42:20 +02:00
Joffrey JAFFEUX
2268e29c26
fix linting removed by prettier 2018-06-15 18:18:45 +02:00
Joffrey JAFFEUX
03a7d532cf
DEV: introduces prettier for es6 files 2018-06-15 17:03:24 +02:00
OsamaSayegh
629a2fbc2b add JS tests 2018-06-15 14:04:14 +10:00
Joffrey JAFFEUX
eddcb07f03 FEATURE: adds plugin sharing api 2018-06-13 13:25:51 +02:00
Joffrey JAFFEUX
3381a0a42a
UX: reworks dashboard problems section to be in line with new style 2018-06-12 12:47:03 +02:00
kleinfreund
4ce1d230c7 Prefer throwing a new Error object instead of just a string expression 2018-06-12 12:56:22 +10:00
Jeff Wong
b7d92061e2 FEATURE: add an option to create undismissable modals 2018-06-07 20:49:33 -07:00
Joffrey JAFFEUX
1071aa21ab
FIX: slightly safer rounding 2018-06-07 10:59:17 +02:00
Joffrey JAFFEUX
ab089cd68b
FIX: makes format number round the value before using parseInt 2018-06-07 10:44:21 +02:00
Guo Xiang Tan
bc7d9c61e6 Revert smoke test accidentally default to non headless mode. 2018-06-05 19:21:46 +08:00
Guo Xiang Tan
a276ffc7b3 Run smoke test without sandbox for now. 2018-06-05 19:08:36 +08:00
Guo Xiang Tan
478c86e0a4 DEV: Update preview step to be more reliable. 2018-06-05 16:58:15 +08:00
Guo Xiang Tan
c27863aad2 DEV: Better output when assertion fails in smoke test. 2018-06-05 10:54:56 +08:00
Joffrey JAFFEUX
43b1768987
UX: ceil dahsboard values 2018-05-30 16:32:43 +02:00
Guo Xiang Tan
db4af262dc DEV: Create smoke test screenshot directory in rake task. 2018-05-30 16:20:18 +08:00
Guo Xiang Tan
fe5a48997c DEV: Store smoke tests failure image in a dedicated tmp folder. 2018-05-30 15:59:07 +08:00
Guo Xiang Tan
30279a4843 DEV: Allow smoke test failure screenshot path to be configured. 2018-05-30 15:42:46 +08:00
Joffrey JAFFEUX
82e5727287
UX: -2/+2% change in stats should be no-change in dashboard 2018-05-28 10:55:42 +02:00
Guo Xiang Tan
9788ea9cb7 DEV: Write into Rails's tmp instead of system tmp for somke test screenshot. 2018-05-28 16:14:22 +08:00
Guo Xiang Tan
9d6d161628 DEV: Take screenshot when smoke test fails. 2018-05-28 14:19:43 +08:00
Guo Xiang Tan
0b55416742 UX: Don't display all groups option if group directory is disabled.a 
https://meta.discourse.org/t/all-groups-option-leads-to-access-denied-page/88464
 2018-05-28 11:32:55 +08:00
Guo Xiang Tan
857a4e0006 FIX: Viewport in smoke test configured incorrectly. 2018-05-28 10:58:36 +08:00
Joffrey JAFFEUX
1be76d066c
FIX: forces boolean when content is only "true" && "false" 2018-05-24 23:41:39 +02:00
Sam
70179290f3 clean up callbacks during acceptance tests 2018-05-24 15:28:54 +10:00
Sam
4194886b62 correct failing test 2018-05-24 13:02:20 +10:00
Joffrey JAFFEUX
db91d71bf1
fix category chooser spec 2018-05-23 21:07:39 +02:00
Joffrey JAFFEUX
ae004d8b2b
attempts of making composer actions test more resilient 2018-05-23 19:57:12 +02:00
Joffrey JAFFEUX
7232a6e5a9
FIX: do not show composer actions if irrelevant 2018-05-23 18:25:58 +02:00
Joffrey JAFFEUX
d2efd338e6
rewrites all composer actions tests using await 2018-05-23 15:52:15 +02:00
Joffrey JAFFEUX
dd76ba90b3
FIX: bbcode regex was greedy and preventing quotes 2018-05-23 11:55:02 +02:00
Sam
930ebb5684 skip failing test 2018-05-23 13:26:42 +10:00
Sam
41d37fd498 improve erratic test 2018-05-23 10:16:52 +10:00
Sam
8e9531657a skip erratic test 2018-05-23 08:28:00 +10:00
Joffrey JAFFEUX
a0c5b48558
fix failing spec 2018-05-22 10:50:54 +02:00
Sam
9e2131ace8 improve erratic test 2018-05-22 13:58:12 +10:00
Sam
99088f4d77 skip slow erratic test 2018-05-22 13:03:26 +10:00
Jeff Atwood
4329b484e8 minor copyedit on dashboard chart title 2018-05-18 16:04:33 -07:00
Joffrey JAFFEUX
af548c23c4
new dashboard quality pass (code, tests and UI) 2018-05-17 22:44:33 +02:00
Guo Xiang Tan
3f8e3a6f73 Don't intercept requests in smoke tests. 2018-05-17 16:56:39 +08:00
Sam
17a7bb8e23 use async test 2018-05-17 17:18:22 +10:00
Sam
441a52ad17 DEV: add more information about failed smoke test 
log the http status code and path that failed
 2018-05-17 16:43:00 +10:00
Régis Hanol
674318e127 UX: don't show 'auto delete' option for TL4 2018-05-17 00:42:48 +02:00
Régis Hanol
938934f5e9 FIX: keep '<kbd>' formatting when quoting posts 2018-05-16 17:40:45 +02:00
Joffrey JAFFEUX
9554d9c56a
UX: tooltips and improvements to new dashboard 
- tooltips
- revert chart title UI
- reduce period chooser font-size
- localize dates of data points
- fix a bug where multiple reports were loaded at the same time
- fix a bug where % was not showing anymore
- remove spacing at the top
- remove loadingTitle feature (Loading...%report name%) incompatible with new hijack design
 2018-05-16 16:45:21 +02:00
Joe Buhlig
3cd4c82c49 Allow parameters for group and username filters on directory (#5815) 2018-05-16 16:20:17 +02:00
Sam
f08ff84c5c missing a fixture for acceptance test 2018-05-15 15:34:40 +10:00
Joffrey JAFFEUX
e474351ae4
inactive users report is not used anymore 2018-05-14 21:31:14 +02:00
Régis Hanol
b004503c62 fix the build 2018-05-14 20:07:00 +02:00
Sam
e1d7f3bb94 correct fixture 2018-05-14 15:46:58 +10:00
Sam
a6aa986d3b correct spec 2018-05-14 15:41:19 +10:00
Régis Hanol
81f4da7dd2 FIX: remove unneeded escape when building a Quote 2018-05-12 01:16:05 +02:00
Sam
8a783412b7 UX: improvements to new dashboard 
- remove inactive user report and replace with posts
- clean up internals so grouping by week happens on client
- when switching periods old report was not destroyed leading to bugs
- calculate trend based on previous interval ... not previous 30 days
- show percentages for mau/dau
- be more careful about utc date usage
- show uniqu and click through rate on search panel
- publish key of report with report so we only load the correct one
- subscribe earlier in channel in case of concurrency issues
 2018-05-11 13:30:32 +10:00
Régis Hanol
deaf3682e9 FIX: clicking a group mention on mobile was 404ing 
(cc @featheredtoast)
 2018-05-09 17:27:59 +02:00
Régis Hanol
3483c7bc58 FIX: supports user/group mentions and category hashtags when quoting posts 2018-05-09 12:42:12 +02:00
Guo Xiang Tan
32147d4ff9 FIX: Search term scoped to topic should be highlighted in widget dom era. 
https://meta.discourse.org/t/highlight-the-search-results/10322/4?u=tgxworld
 2018-05-07 15:17:34 +08:00
Neil Lalonde
3a145b7551 fix group-test.js 2018-05-03 16:00:56 -04:00
Joffrey JAFFEUX
980972182f
dashboard next: caching, mobile support and new charts 2018-05-03 15:41:41 +02:00
Joffrey JAFFEUX
37a0ceb4e7
Adds fixture for new contributors 2018-04-26 17:39:00 +02:00
Joffrey JAFFEUX
a9c3437d51
dashboard next: adds basic spec 2018-04-25 10:28:41 +02:00
Joffrey JAFFEUX
59d4123316
PERFORMANCE: disables jquery animations during testing 2018-04-24 18:29:26 +02:00
Joffrey JAFFEUX
7466769b67
PERF: disables composer transitions in tests 2018-04-23 10:23:11 +02:00
Sam
54d153068a DEV: remove qunit rails fork and add a couple of async tests 2018-04-23 16:42:40 +10:00
Jeff Wong
252dd32895 show card on preview panel. 
refactor user and group cards

refactor userLoading to loading

add logic to display cards above mentions for fixed placements
 2018-04-20 12:28:24 -07:00
Guo Xiang Tan
6cce839f0a FIX: Missing action to trigger add group members modal for group owners. 
https://meta.discourse.org/t/unable-to-add-members-to-a-group-as-group-owner-who-is-not-staff/85346?u=tgxworld
 2018-04-16 09:09:47 +08:00
Neil Lalonde
0e2584b841 fix cursor on disabled composer 2018-04-12 11:32:13 -04:00
Guo Xiang Tan
a389baeb07 FIX: Group pages should work when group name contains periods. 
https://meta.discourse.org/t/group-name-cant-have-dot-inside/48658
 2018-04-12 17:11:36 +08:00
Guo Xiang Tan
c0595ebe99 FIX: Disable save button when new group form is empty. 
https://meta.discourse.org/t/adding-owners-members-ux-is-inconsistent-and-misleading/58084/26?u=tgxworld
 2018-04-12 10:29:36 +08:00
Guo Xiang Tan
66abd340db Fix randomly failing JS build. 
For some reason, the test rack server would block on
a `/letter_avatar_proxy` route causing ajax requests to
stack up.
 2018-04-11 22:23:49 +08:00
Neil Lalonde
6e6892c88e FEATURE: when uncategorized topics are not allowed, disable the post input until a category is chosen 2018-04-10 19:31:28 -04:00
Joffrey JAFFEUX
d9ac0152e4
fixes search-full-test for revamped search page 2018-04-10 09:59:24 +02:00
Neil Lalonde
d7ea6f93e7 FIX: preference page error when badges are disabled 2018-04-09 14:27:00 -04:00
Régis Hanol
1b351a3355 disable full page search acceptance tests (cc @jjaffeux) 2018-04-09 20:14:57 +02:00
Guo Xiang Tan
c82b2dcc24 Remove admin group management pages. 2018-04-09 15:14:50 +08:00
Guo Xiang Tan
4319273cf5 UX: Split up group form into smaller sections. 2018-04-09 15:14:50 +08:00
Claas Augner
ba905b24ca FIX: differentiate one/other select-kit maximumLabel/minimumLabel 2018-04-09 09:12:01 +02:00
Joffrey JAFFEUX
f0fe16d824
FEATURE: implements minimum selection for select-kit 2018-04-05 16:45:19 +02:00
Guo Xiang Tan
e36e9de28a Allow admin to view logs of automatic groups. 2018-04-05 16:31:55 +08:00
Robin Ward
895bca5f5b FIX: Broken JS tests 2018-04-02 14:18:10 -04:00
Joffrey JAFFEUX
3287ac77e0
FIX: reverts combobox placeholder and introduces noneLabel 
noneLabels works almost like none but instead of actually adding a row in the list, it will only change the text displayed in the header, when there's no selection.
 2018-03-29 13:42:00 +02:00
Guo Xiang Tan
52e75eaee9 UX: Tweaks to group pages. 2018-03-29 17:04:48 +08:00
Guo Xiang Tan
baa383b7f1 Fix the build. 2018-03-28 09:42:12 +08:00
Joffrey JAFFEUX
15aa712227
fix category-row regressions 2018-03-27 14:11:05 +02:00
Guo Xiang Tan
f6b6ddd73c REFACTOR: Extract group form into a component. 2018-03-27 19:26:05 +08:00
Guo Xiang Tan
bc4de7b5ec Make eslint happy. 2018-03-27 17:44:04 +08:00
Guo Xiang Tan
7edab1c0b9 UX: Add groups/custom/new route for admins to create a new group. 2018-03-27 17:39:05 +08:00
Guo Xiang Tan
2ecd234e27 UX: Consolidation group manangement into a single tab. 2018-03-27 13:34:46 +08:00
Guo Xiang Tan
dcd1d422d1 UX: Allow admins to set users as owners while adding users. 
https://meta.discourse.org/t/adding-owners-members-ux-is-inconsistent-and-misleading/58084/9
 2018-03-26 17:33:50 +08:00
Guo Xiang Tan
27e60c78d4 Remove obsolete JS tests. 2018-03-26 16:26:42 +08:00
Guo Xiang Tan
35745166b5 UX: New group membership management workflow. 
https://meta.discourse.org/t/adding-owners-members-ux-is-inconsistent-and-misleading/58084
 2018-03-26 16:15:02 +08:00
Joffrey JAFFEUX
d48542796e
FIX: select-kit refactoring 
- improve mini-tag-chooser keyboard behavior
- all multil select now respond to select all and left/right arrows
- improve events handling
- many minor tweaks
 2018-03-22 11:29:55 +01:00
Guo Xiang Tan
f3b402ffd5 UX: Allow users to filter members on group page. 
* Only admins are allowed to filter users by email.
 2018-03-22 14:02:41 +08:00
Guo Xiang Tan
be866dbe6e UX: Allow group owners to manage members from group members page. 2018-03-21 18:22:55 +08:00
Robin Ward
b9abd7dc9e FEATURE: Shared Drafts 
This feature can be enabled by choosing a destination for the
`shared drafts category` site setting.

* Staff members can create shared drafts, choosing a destination
category for the topic when it is published.

* Shared Drafts can be viewed in their category, or above the
topic list for the destination category where it will end up.

* When the shared draft is ready, it can be published to the
appropriate category by clicking a button on the topic view.

* When published, Drafts change their timestamps to the current
time, and any edits to the original post are removed.
 2018-03-20 17:15:26 -04:00
Neil Lalonde
a9de712eed FIX: not found message when trying to log in with a link, even though the email with the link was successfully sent 2018-03-19 16:08:10 -04:00
Guo Xiang Tan
2b7fb43d84 Fix the build. 2018-03-19 18:47:17 +08:00
Guo Xiang Tan
fe96ef6ed2 UX: Use topic list for displaying group messages on group page. 
https://meta.discourse.org/t/group-inbox-on-a-groups-page-mockup/71319
 2018-03-16 11:56:40 +08:00
Guo Xiang Tan
a35227918f UX: Display group topics in a topic list. 2018-03-15 11:37:55 +08:00
Gerhard Schlager
243ee565dc Reset widget decorators after each test 2018-03-12 14:22:50 +01:00
Sam
b57d4c87a4 FEATURE: update CommonMark to version 0.28 2018-03-08 12:19:53 +11:00
Gerhard Schlager
8e48b339fa Drop unused tables (#5630) 2018-03-05 17:27:30 -05:00
Joffrey JAFFEUX
6d4ff05cf0
FIX: makes sure [999500..999999] is correctly shown as 999k 2018-03-02 11:00:48 +01:00
Guo Xiang Tan
b9ff6d60b9 Fix the build. 2018-03-02 14:43:02 +08:00
Guo Xiang Tan
d9b4b12694 UX: Display warning message about social logins disabled when 2FA is enabled. 2018-03-02 14:22:52 +08:00
Arpit Jalan
841e58fc46 delete extra blank lines 2018-02-27 15:51:50 +05:30
Arpit Jalan
ec8cc833c6 fix the build 2018-02-27 15:48:36 +05:30
Arpit Jalan
4010d8d9f9 FEATURE: show "edit message" button on message footer for staff 
Show "Edit Message" button on personal message footer for staff if PM tagging is enabled.
 2018-02-27 14:22:03 +05:30
Guo Xiang Tan
24bd310d7b Fix the build. 2018-02-27 10:15:13 +08:00
Neil Lalonde
3313072957 Remove censored_pattern site setting, which is replaced by watched words 2018-02-26 16:29:27 -05:00
Joffrey JAFFEUX
ac701696b3
FEATURE: replaces tag-chooser/tag-group-chooser with select-kit component 
These component were also the last using select2. As a consequence select2 is removed from Discourse in this commit.
 2018-02-26 11:42:57 +01:00
Joffrey JAFFEUX
6f5acfe783 Login with email/forget password UI refactoring 
* move button into login modal with social buttons
* adds email link next to login field when filling it
* adds proper validation messages
* improves forgot password flash clearing
* more tests
 2018-02-22 08:06:15 +08:00
Guo Xiang Tan
14f3594f9f Review Changes for f4f8a293e7. 2018-02-21 14:55:49 +08:00
Jeff Wong
f4f8a293e7 FEATURE: Implement 2factor login TOTP 
implemented review items.

Blocking previous codes - valid 2-factor auth tokens can only be authenticated once/30 seconds.
I played with updating the “last used” any time the token was attempted but that seemed to be overkill, and frustrating as to why a token would fail.
Translatable texts.
Move second factor logic to a helper class.
Move second factor specific controller endpoints to its own controller.
Move serialization logic for 2-factor details in admin user views.
Add a login ember component for de-duplication
Fix up code formatting
Change verbiage of google authenticator

add controller tests:
second factor controller tests
change email tests
change password tests
admin login tests

add qunit tests - password reset, preferences

fix: check for 2factor on change email controller
fix: email controller - only show second factor errors on attempt
fix: check against 'true' to enable second factor.

Add modal for explaining what 2fa with links to Google Authenticator/FreeOTP

add two factor to email signin link

rate limit if second factor token present

add rate limiter test for second factor attempts
 2018-02-21 09:04:07 +08:00
OsamaSayegh
f3815cd785 FEATURE: New site setting for additional allowed filetypes for staff (#5364) 
* FEATURE: New site setting for additional allowed filetypes for staff

* Problematic variable name

* feedback

* small issues

* fix indentation

* failing tests

* Remove message bus and fix minor issues

* Missed this message bus
 2018-02-19 10:44:24 +01:00
Joffrey JAFFEUX
25dd8ff62a
FIX: broken composer-actions spec 2018-02-14 11:32:20 +01:00
Erick Guan
03b3e57a44 FEATURE: login by a link from email 
Co-authored-by: tgxworld <tgx@discourse.org>
 2018-02-13 16:14:39 +08:00
Sam
b34b1b6fe3 FIX: invite to message was not allowing groups 
Previously we were incorrectly checking mentionable instead of messageable

Also fix edge case where multiple groups sharing a name mean that exact match override is not working

Also cleans up params sent to user selector
 2018-02-13 13:28:46 +11:00
Vinoth Kannan
91beedd0ca FEATURE: Composer HTML pasting ul tag support for MS Word 2018-02-10 01:18:56 +05:30
Joffrey JAFFEUX
190d208631
FEATURE: improves composer-actions toggle menu 
* only toggles
* fix a bug with presence
* more tests
* do not duplicate `continuing discussion...` text
* persist state to allow switching between toggles
 2018-02-08 11:46:55 +01:00
Robin Ward
80ea2e5107 FIX: Enable personal messages in tests 2018-02-02 17:06:02 -05:00
Robin Ward
8ff4104555 Many enhancements to the flagging / suspending interface. 2018-02-01 17:13:02 -05:00
Joffrey JAFFEUX
f7df68c9a3
FIX: makes composer-actions toggling whisper instead of replying 2018-02-01 23:07:37 +01:00
Joffrey JAFFEUX
97ddaeeae8
FIX: use css instead of js to fix select-kit-collection max-height 2018-02-01 16:56:07 +01:00
Joffrey JAFFEUX
9923829402
FEATURE: Menu toggle for different reply modes 
Allow users to access different reply modes from the composer.

Actions introduced:

- reply_as_new_topic
- reply_as_private_message
- reply_to_topic
- reply_as_whisper/not
 2018-02-01 16:42:56 +01:00
Robin Ward
96710754d9
Merge pull request #5540 from discourse/mixed-text-direction-support 
FEATURE: Mixed text direction support
 2018-02-01 07:29:15 -08:00
Arpit Jalan
49424fd798 rename private to personal 2018-02-01 13:25:29 +05:30
Arpit Jalan
ff0376a80b rename 'enable_private_messages' to 'enable_personal_messages' 2018-02-01 13:25:29 +05:30
Arpit Jalan
25ec077eca rename 'min_private_message_{post/title}_length' to 'min_personal_message_{post/title}_length' 2018-02-01 13:25:29 +05:30
Sam
187b0031c5 correct specs 2018-02-01 16:16:14 +11:00
Vinoth Kannan
10ed4c0078 FEATURE: Composer HTML pasting support for complex table formats 2018-01-31 01:39:11 +05:30
scossar
843d88c5d0 Remove unused imports 2018-01-29 20:11:12 -08:00
scossar
5d18f72b8c Add tests for text-direction functions 2018-01-29 19:16:35 -08:00
scossar
41f1e7430c Refactor code; add tests 2018-01-29 17:42:19 -08:00
Gerhard Schlager
eb52c5469e FEATURE: Allow plugins to register a new locale 2018-01-25 14:57:41 +01:00
Neil Lalonde
dc97239040 FIX: censored regex words were replacing other text that shouldn't be censored 2018-01-24 12:33:47 -05:00
Sam
3b083ca0bd correct spec 2018-01-24 13:23:27 +11:00
Vinoth Kannan
86e142b39f UX: Copy selected text to the link building modal 2018-01-24 02:02:12 +05:30
Régis Hanol
c425a2d335 fix js suite 2018-01-22 17:48:03 +01:00
Kyle Zhao
83c549bd31 FEATURE: grant badges in post admin wrench (#5498) 
* FEATURE: grant badges in post admin wrench

* only grant manually grantable badges

* extract GrantBadgeController mixin
 2018-01-22 14:10:53 +11:00
Régis Hanol
f674b9e86e FIX: encode image filename so '[', ']' and '|' doesn't break the markdown 2018-01-19 19:52:03 +01:00