Gerhard Schlager
16974df1e9
FIX: Resetting site setting didn't remove "overriden" state
2018-09-01 02:09:23 +02:00
Joffrey JAFFEUX
ceae3d0a93
fix js tests ( #6343 )
2018-08-30 15:09:08 +02:00
Guo Xiang Tan
f39c38d281
DEV: Support stable branch tests for discourse-spoiler
.
2018-08-30 17:20:42 +08:00
Guo Xiang Tan
0f812aa768
Make prettier happy.
2018-08-30 15:56:30 +08:00
Vinoth Kannan
092fb0c170
Merge pull request #6333 from vinothkannans/rich-text-pasting
...
FIX: Use tight list format for GDocs html to markdown
2018-08-30 12:14:50 +05:30
Bianca Nenciu
c1a5a7504e
FIX: Reset email preferences controller. ( #6316 )
2018-08-29 23:10:56 +02:00
Vinoth Kannan
4c99acea1b
FIX: Use tight list format for GDocs html to markdown
2018-08-29 16:21:31 +00:00
Kris
afec673c2b
Fixing test
2018-08-29 11:44:04 -04:00
Vinoth Kannan
26f17150e1
Merge pull request #6327 from vinothkannans/rich-text-pasting
...
FIX: Keep emojis and remove clicks count on html to markdown
2018-08-29 13:38:55 +05:30
Vinoth Kannan
fb35b0b3c3
FIX: Keep emojis and remove clicks count
2018-08-29 07:26:25 +00:00
Sam
9ab1fb7dfc
FEATURE: correctly store width and height on uploads
...
Previously we used width and height for thumbnails, new code ensures
1. We auto correct width and height
2. We added extra columns for thumbnail_width and height, this is determined
by actual upload and no longer passed in as a side effect
3. Optimized Image now stores filesize which can be used for analysis, decisions
Also
- fixes Android image manifest as a side effect
- fixes issue where a thumbnail generated that is smaller than the upload is no longer used
2018-08-28 12:59:22 +10:00
Kris
faf09bb8c8
Replacing default brown category color
2018-08-24 14:18:14 -04:00
Joffrey JAFFEUX
82dcc5cbfa
FEATURE: makes reports loadable in bulk ( #6309 )
2018-08-24 15:28:01 +02:00
Osama Sayegh
e0cc29d658
FEATURE: themes and components split
...
* FEATURE: themes and components split
* two seperate methods to switch theme type
* use strict equality operator
2018-08-24 11:30:00 +10:00
Arpit Jalan
7a91df3248
Merge pull request #6290 from techAPJ/latest-full-name
...
UX: show full name on /latest page
2018-08-23 17:34:54 +05:30
Arpit Jalan
1a7cd6648b
UX: show full name on /latest page
2018-08-23 14:41:06 +05:30
Joffrey JAFFEUX
07e11a223c
FIX: prefills username for new message on first post ( #6305 )
2018-08-23 11:09:35 +02:00
Guo Xiang Tan
bd66fbef7f
FIX: Post time query filter not set correctly when loaded from params.
...
https://meta.discourse.org/t/before-and-after-are-not-implemented-right-in-search/92515
2018-08-23 14:06:28 +08:00
James Kiesel
b2ce33be26
FIX: tag intersection not populating ( #6296 )
...
* Fix for tag intersection not populating
* Fix prettier
* Add acceptance test for tags intersection
2018-08-23 14:22:47 +10:00
Joffrey JAFFEUX
87d443f070
FIX: counters were showing future instead of past ( #6299 )
2018-08-22 12:37:05 +02:00
Joffrey JAFFEUX
599cebf8ad
FIX: better message if request for report is rate limited ( #6298 )
2018-08-22 11:25:12 +02:00
Sam
5d96809abd
FIX: improve support for subfolder S3 CDN
2018-08-22 12:31:13 +10:00
Guo Xiang Tan
de2243319e
Fix the build.
2018-08-20 16:25:59 +08:00
Guo Xiang Tan
658b55c406
FIX: Search does not retrigger when context has changed. Take 2.
...
https://meta.discourse.org/t/using-the-search-this-topic-check-box-blocks-search-on-other-pages/56832/6?u=tgxworld
2018-08-20 15:46:02 +08:00
Guo Xiang Tan
9c3ba98ef1
FIX: User can't save gravatar as profile picture after refresh.
...
https://meta.discourse.org/t/gravatar-issue-cant-save-changes/95076
2018-08-20 10:29:50 +08:00
Joffrey JAFFEUX
37d4f27c44
FIX: quality/bugfix dashboard/reports pass ( #6283 )
2018-08-17 16:19:25 +02:00
Joffrey JAFFEUX
edf26a0931
uses emoji version for tests ( #6277 )
2018-08-16 14:06:56 +02:00
Gerhard Schlager
448e95b97d
UX: Show anchor icon instead of text when topic bump is disabled
2018-08-11 21:51:13 +02:00
Gerhard Schlager
ef4b9f98c1
FEATURE: Allow admins to reply without topic bump
2018-08-10 10:48:30 +10:00
Neil Lalonde
f7b4a2b3ba
FIX: ensure URLs include subfolder in admin emails UI
2018-08-08 16:48:03 -04:00
Joffrey JAFFEUX
7f2f3b8b22
FIX: improves reports resilience ( #6239 )
...
This commit makes most of the reports now lazy loaded, and making them benefits from graceful failures.
2018-08-06 16:57:40 -04:00
Joffrey JAFFEUX
c301111461
FIX: display select kit body if no choices ( #6237 )
2018-08-06 11:22:48 -04:00
David Taylor
812add18bd
REFACTOR: Serve auth provider information in the site serializer.
...
At the moment core providers are hard-coded in Javascript, and plugin providers get added to the JS payload at compile time. This refactor means that we only ship enabled providers to the client.
2018-08-06 09:25:48 +01:00
Joffrey JAFFEUX
066010db7d
FEATURE: introduces list/compact_list components
2018-08-03 16:41:37 -04:00
Joffrey JAFFEUX
9073e11943
FIX: improves number/percent support in reports
2018-08-01 18:40:59 -04:00
Penar Musaraj
1f45215537
FEATURE: Drafts view in user profile
...
* add drafts.json endpoint, user profile tab with drafts stream
* improve drafts stream display in user profile
* truncate excerpts in drafts list, better handling for resume draft action
* improve draft stream SQL query, add rspec tests
* if composer is open, quietly close it when user opens another draft from drafts stream; load PM draft only when user is in /u/username/messages (instead of /u/username)
* cleanup
* linting fixes
* apply prettier styling to modified files
* add client tests for drafts, includes a fixture for drafts.json
* improvements to code following review
* refresh drafts route when user deletes a draft open in the composer while being in the drafts route; minor prettier scss fix
* added more spec tests, deleted an acceptance test for removing drafts that was too finicky, formatting and code style fixes, added appEvent for draft:destroyed
* prettier, eslint fixes
* use "username_lower" from users table, added error handling for rejected promises
* adds guardian spec for can_see_drafts, adds improvements following code review
* move DraftsController spec to its own file
* fix failing drafts qunit test, use getOwner instead of deprecated this.container
* limit test fixture for draft.json testing to new_topic request only
2018-08-01 16:34:54 +10:00
Guo Xiang Tan
b6939093eb
Fix JS tests.
2018-08-01 11:21:46 +08:00
Joffrey JAFFEUX
2b2a506a7b
FIX: makes dashboard more resilient to errors ( #6217 )
...
This commit is an attempt to limit cases where the dashboard will generate a full exception page and also make it easier to track the error.
2018-07-31 21:23:28 -04:00
Joffrey JAFFEUX
0715aa18da
UI: uses tiny avatars for reports ( #6215 )
2018-07-31 18:57:00 -04:00
Joffrey JAFFEUX
37252c1a5e
UI: improves dashboard table reports
...
- support for avatars
- support for topic/post/user type in reports
- improved totals row UI
- minor css tweaks
2018-07-31 17:35:13 -04:00
Vinoth Kannan
ece3cb73df
Rename humburger_menu_categories_count site setting to header_dropdown_category_count
2018-07-31 09:12:30 +05:30
Vinoth Kannan
b852275ced
Test method for site categories random order fix
2018-07-31 01:36:37 +05:30
Vinoth Kannan
c54b5824d4
REFACTOR: Prioritize unread categories in hamburger menu
2018-07-30 20:20:10 +05:30
Maja Komel
c7c84606d9
fix prettier offense
2018-07-30 12:43:10 +02:00
Maja Komel
04baddf731
DEV: migrate tests to async/await
2018-07-30 12:21:05 +02:00
Vinoth Kannan
249b16e8e3
FIX: Hide muted categories from hamburger menu top categories block
2018-07-30 15:37:41 +05:30
Vinoth Kannan
78d91b1daf
UX: Changes in top categories of hamburger menu ( #6200 )
2018-07-30 14:13:00 +05:30
Arpit Jalan
fc3b904e1f
remove "track external right clicks" feature
2018-07-29 15:01:33 +05:30
Vinoth Kannan
dac29b5ebc
UX: Display only top categories in hamburger menu ( #6146 )
2018-07-27 12:11:07 +05:30
Joffrey JAFFEUX
330cf78c83
FIX: don’t break browser history on dashboard visit ( #6186 )
2018-07-26 14:59:28 -04:00
Maja Komel
a89dd51cae
DEV: migrate acceptance tests to async/await
2018-07-26 12:51:16 +02:00
Kyle Zhao
1ed3a89ac9
UX: clear topic timer text when manually closing/opening ( #6123 )
...
* UX: clear topic timer text when manually closing/opening
* added test for clearing topic timer status text
2018-07-26 11:48:38 +10:00
Joffrey JAFFEUX
ad95c24307
FEATURE: displays a notice if report has no data ( #6178 )
2018-07-25 14:28:41 -04:00
Régis Hanol
637850d867
REFACTOR: new 'show-avatar-select' app event to trigger the avatar selector modal
2018-07-25 12:38:15 +02:00
Dan Ungureanu
44a5c29d42
Clear old text and URL when showing up the "Insert Hyperink" modal. ( #6138 )
2018-07-25 17:12:49 +10:00
Maja Komel
3a52c2fa64
DEV: migrate widgets tests to async/await
2018-07-24 23:22:03 +02:00
Maja Komel
d16a2c776a
DEV: migrate components tests to async/await
2018-07-24 22:41:14 +02:00
Sam
95720e3873
lint files
2018-07-24 10:57:16 +10:00
Kyle Zhao
c9d4288214
UX: auto fix order when reordering categories ( #6149 )
...
* set correct position number when moving up/down
* UX: drop 'fix order' and auto re-order subcategory
- auto "fix position" on save
- place subcategories after parent category and maintain the relative
positions on save
2018-07-24 10:25:40 +10:00
David Taylor
eda1462b3b
FEATURE: List, revoke and reconnect associated accounts. Phase 1 ( #6099 )
...
Listing connections is supported for all built-in auth providers. Revoke and reconnect is currently only implemented for Facebook.
2018-07-23 16:51:57 +01:00
Joffrey JAFFEUX
9ed4071713
fixes dashboard next spec ( #6132 )
2018-07-21 10:29:58 -04:00
Guo Xiang Tan
863de8cb76
Make prettier happy.
2018-07-21 18:03:39 +08:00
Guo Xiang Tan
096e8ee21c
Disable broken JS test for now.
2018-07-21 17:48:20 +08:00
Arpit Jalan
44e7f63d65
temporarily disable test for new-topic page
2018-07-20 17:49:16 +05:30
Joffrey JAFFEUX
194844fc66
fixes tests
2018-07-19 14:44:42 -04:00
Joffrey JAFFEUX
1a78e12f4e
FEATURE: part 2 of dashboard improvements
...
- moderation tab
- sorting/pagination
- improved third party reports support
- trending charts
- better perf
- many fixes
- refactoring
- new reports
Co-Authored-By: Simon Cossar <scossar@users.noreply.github.com>
2018-07-19 14:33:11 -04:00
Maja Komel
73739060f3
DEV: migrate acceptance tests to async await - plugin, reports, user, topic
2018-07-19 16:40:12 +02:00
Maja Komel
2e96646659
DEV: migrate acceptance tests to async await - invite, login, mobile
2018-07-19 16:38:37 +02:00
Joffrey JAFFEUX
a2281fbb19
FEATURE: allows to jump to a date in a topic
2018-07-19 16:00:13 +02:00
Maja Komel
7f7944bc3a
DEV: migrate acceptance tests to async await - dashboard, emoji, group
2018-07-19 14:00:03 +02:00
Maja Komel
e36d1c72f1
DEV: migrate acceptance tests to async await - badges, category, composer, customHTML
2018-07-19 13:52:48 +02:00
Maja Komel
6aa2eb19d4
DEV: migrate acceptance tests to async await - admin, about, account created ( #6111 )
2018-07-19 17:35:10 +08:00
Maja Komel
fa38891a98
FEATURE: show modal when user without permissions tries to delete their own topic ( #6086 )
2018-07-18 23:31:37 +02:00
Neil Lalonde
afc94ac9e4
FEATURE: add a Top Categories section to the user summary page, showing the categories in which a user has the most activity
2018-07-18 16:39:16 -04:00
Régis Hanol
f55ac892e4
make code prettier 🎀
2018-07-18 13:09:16 +02:00
Régis Hanol
6d6e026e3c
FEATURE: selectable avatars
2018-07-18 12:57:43 +02:00
Philipp Rudloff
79b08b2679
Set result.target for update (matching _saveNew) ( #6094 )
...
* Set result.target for update (matching _saveNew)
* Add tests for update result including a target property
2018-07-17 11:56:32 -04:00
Sam
e7102c73fb
correct test and move to async
2018-07-17 09:10:55 +10:00
Sam
ac0053f491
FEATURE: navigate to first post and auto bump category settings
...
### navigate_to_first_post_after_read setting for categories
When enabled on categories logged on users will return to OP after
reading the entire category. (useful for documentation categories)
### num_auto_bump_daily
Set a number of topics that will automatically bump daily on a category.
- Every 15 minutes we will check if any category has this setting
- Categories with the setting are shuffled
- We exclude pinned, closed, category description and archived topics
- Maximum of 1 topic for the list of categories is bumped till limit reached per category
- We always try to bump oldest first
- Limit is elastic using a RateLimiter that ensures that we only bump N per day
Also some minor organisation on category settings
Froze strings on category.rb
2018-07-16 18:10:35 +10:00
Guo Xiang Tan
767395449f
Make prettier happy.
2018-07-16 11:31:23 +08:00
Leo McArdle
21ebb1cd54
FEATURE: Secondary emails support.
2018-07-16 11:09:49 +08:00
Neil Lalonde
8ceed642cb
FIX: wrong url for default logos in header on subfolder installs
2018-07-13 14:21:15 -04:00
Guo Xiang Tan
711371e8c8
FIX: Select+below will ask server for post ids on megatopics.
2018-07-13 15:10:39 +08:00
Guo Xiang Tan
409a30ce1c
FIX: Selecting & moving posts not working on megatopics.
2018-07-13 11:16:43 +08:00
Guo Xiang Tan
18e281606a
UX: Clicking admin menu does not hide select posts box.
2018-07-13 10:56:14 +08:00
Sam
1f0bbca87e
FIX: on initial load category subcategories were not mapped correctly
2018-07-12 17:59:56 +10:00
Guo Xiang Tan
258e9e35ca
PERF: Make mega topics work without a stream.
...
There are tradeoffs that we took here. For the complete
story see
https://meta.discourse.org/t/performance-improvements-on-long-topics/30187/27?u=tgxworld .
2018-07-12 12:46:12 +08:00
OsamaSayegh
f13a7226db
FIX: display tables in posts history diff ( #6032 )
2018-07-12 14:13:52 +10:00
Guo Xiang Tan
8f4cb1a742
UX: Timeline lookup on mega topics should use date of current post.
2018-07-10 16:43:20 +08:00
Sam
d9a9682f72
FIX: also count sub categories in hamburger when needed
...
previously there were cases where we suppress subcategories yet don't count them
this leads to confusion
2018-07-09 16:52:55 +10:00
Maja Komel
7cba4cbcc6
FEATURE: allow selecting a tag when moving posts to a new topic ( #6074 )
2018-07-06 18:21:00 +02:00
Joe
98478d78d7
FIX: update test to match new admin layout
2018-07-03 17:03:43 +08:00
Joe
9834263687
FIX: update test to match admin layout changes
2018-07-03 16:28:57 +08:00
Joffrey JAFFEUX
c754ece8f5
FEATURE: drops with-email-link and replaces it by with-email-button
2018-07-02 14:35:50 +02:00
Maja Komel
3ddfc12307
unify user preferences views
2018-07-02 15:38:36 +10:00
Guo Xiang Tan
d1c3eb6bfa
FIX: Recovering a post does not insert it back into the stream correctly.
2018-06-29 11:41:44 +08:00
Joffrey JAFFEUX
9f4e814dbc
tests for XSS injection in tooltips
2018-06-28 14:24:21 +02:00
Maja Komel
ec3e6a81a4
FEATURE: Second factor backup
2018-06-28 10:12:32 +02:00
Jeff Atwood
7dce8290ed
copyedit on category drop down
2018-06-26 12:43:45 -07:00
OsamaSayegh
d81f8ea378
fix prettier
2018-06-26 15:31:43 +03:00
OsamaSayegh
bfe0178270
FIX: use the correct notification levels titles for PMs
2018-06-26 14:01:52 +02:00
Joffrey JAFFEUX
eb9b99e519
FIX: makes select-kit match searches with accents (filter and content)
2018-06-26 12:19:14 +02:00
Joffrey JAFFEUX
f2dbe66367
FEATURE: adds a /admin/reports route to list all reports
2018-06-18 12:31:56 +02:00
Joffrey JAFFEUX
60ff0e9b8c
missing prettified files
2018-06-15 18:42:20 +02:00
Joffrey JAFFEUX
2268e29c26
fix linting removed by prettier
2018-06-15 18:18:45 +02:00
Joffrey JAFFEUX
03a7d532cf
DEV: introduces prettier for es6 files
2018-06-15 17:03:24 +02:00
OsamaSayegh
629a2fbc2b
add JS tests
2018-06-15 14:04:14 +10:00
Joffrey JAFFEUX
eddcb07f03
FEATURE: adds plugin sharing api
2018-06-13 13:25:51 +02:00
Joffrey JAFFEUX
3381a0a42a
UX: reworks dashboard problems section to be in line with new style
2018-06-12 12:47:03 +02:00
kleinfreund
4ce1d230c7
Prefer throwing a new Error object instead of just a string expression
2018-06-12 12:56:22 +10:00
Jeff Wong
b7d92061e2
FEATURE: add an option to create undismissable modals
2018-06-07 20:49:33 -07:00
Joffrey JAFFEUX
1071aa21ab
FIX: slightly safer rounding
2018-06-07 10:59:17 +02:00
Joffrey JAFFEUX
ab089cd68b
FIX: makes format number round the value before using parseInt
2018-06-07 10:44:21 +02:00
Joffrey JAFFEUX
43b1768987
UX: ceil dahsboard values
2018-05-30 16:32:43 +02:00
Joffrey JAFFEUX
82e5727287
UX: -2/+2% change in stats should be no-change in dashboard
2018-05-28 10:55:42 +02:00
Guo Xiang Tan
0b55416742
UX: Don't display all groups
option if group directory is disabled.a
...
https://meta.discourse.org/t/all-groups-option-leads-to-access-denied-page/88464
2018-05-28 11:32:55 +08:00
Joffrey JAFFEUX
1be76d066c
FIX: forces boolean when content is only "true" && "false"
2018-05-24 23:41:39 +02:00
Sam
70179290f3
clean up callbacks during acceptance tests
2018-05-24 15:28:54 +10:00
Sam
4194886b62
correct failing test
2018-05-24 13:02:20 +10:00
Joffrey JAFFEUX
db91d71bf1
fix category chooser spec
2018-05-23 21:07:39 +02:00
Joffrey JAFFEUX
ae004d8b2b
attempts of making composer actions test more resilient
2018-05-23 19:57:12 +02:00
Joffrey JAFFEUX
7232a6e5a9
FIX: do not show composer actions if irrelevant
2018-05-23 18:25:58 +02:00
Joffrey JAFFEUX
d2efd338e6
rewrites all composer actions tests using await
2018-05-23 15:52:15 +02:00
Joffrey JAFFEUX
dd76ba90b3
FIX: bbcode regex was greedy and preventing quotes
2018-05-23 11:55:02 +02:00
Sam
930ebb5684
skip failing test
2018-05-23 13:26:42 +10:00
Sam
41d37fd498
improve erratic test
2018-05-23 10:16:52 +10:00
Sam
8e9531657a
skip erratic test
2018-05-23 08:28:00 +10:00
Joffrey JAFFEUX
a0c5b48558
fix failing spec
2018-05-22 10:50:54 +02:00
Sam
9e2131ace8
improve erratic test
2018-05-22 13:58:12 +10:00
Sam
99088f4d77
skip slow erratic test
2018-05-22 13:03:26 +10:00
Jeff Atwood
4329b484e8
minor copyedit on dashboard chart title
2018-05-18 16:04:33 -07:00
Joffrey JAFFEUX
af548c23c4
new dashboard quality pass (code, tests and UI)
2018-05-17 22:44:33 +02:00
Sam
17a7bb8e23
use async test
2018-05-17 17:18:22 +10:00
Régis Hanol
674318e127
UX: don't show 'auto delete' option for TL4
2018-05-17 00:42:48 +02:00
Régis Hanol
938934f5e9
FIX: keep '<kbd>' formatting when quoting posts
2018-05-16 17:40:45 +02:00
Joffrey JAFFEUX
9554d9c56a
UX: tooltips and improvements to new dashboard
...
- tooltips
- revert chart title UI
- reduce period chooser font-size
- localize dates of data points
- fix a bug where multiple reports were loaded at the same time
- fix a bug where % was not showing anymore
- remove spacing at the top
- remove loadingTitle feature (Loading...%report name%) incompatible with new hijack design
2018-05-16 16:45:21 +02:00
Joe Buhlig
3cd4c82c49
Allow parameters for group and username filters on directory ( #5815 )
2018-05-16 16:20:17 +02:00
Sam
f08ff84c5c
missing a fixture for acceptance test
2018-05-15 15:34:40 +10:00
Joffrey JAFFEUX
e474351ae4
inactive users report is not used anymore
2018-05-14 21:31:14 +02:00
Régis Hanol
b004503c62
fix the build
2018-05-14 20:07:00 +02:00
Sam
e1d7f3bb94
correct fixture
2018-05-14 15:46:58 +10:00
Sam
a6aa986d3b
correct spec
2018-05-14 15:41:19 +10:00
Régis Hanol
81f4da7dd2
FIX: remove unneeded escape when building a Quote
2018-05-12 01:16:05 +02:00
Sam
8a783412b7
UX: improvements to new dashboard
...
- remove inactive user report and replace with posts
- clean up internals so grouping by week happens on client
- when switching periods old report was not destroyed leading to bugs
- calculate trend based on previous interval ... not previous 30 days
- show percentages for mau/dau
- be more careful about utc date usage
- show uniqu and click through rate on search panel
- publish key of report with report so we only load the correct one
- subscribe earlier in channel in case of concurrency issues
2018-05-11 13:30:32 +10:00
Régis Hanol
deaf3682e9
FIX: clicking a group mention on mobile was 404ing
...
(cc @featheredtoast)
2018-05-09 17:27:59 +02:00
Régis Hanol
3483c7bc58
FIX: supports user/group mentions and category hashtags when quoting posts
2018-05-09 12:42:12 +02:00
Guo Xiang Tan
32147d4ff9
FIX: Search term scoped to topic should be highlighted in widget dom era.
...
https://meta.discourse.org/t/highlight-the-search-results/10322/4?u=tgxworld
2018-05-07 15:17:34 +08:00
Neil Lalonde
3a145b7551
fix group-test.js
2018-05-03 16:00:56 -04:00
Joffrey JAFFEUX
980972182f
dashboard next: caching, mobile support and new charts
2018-05-03 15:41:41 +02:00
Joffrey JAFFEUX
37a0ceb4e7
Adds fixture for new contributors
2018-04-26 17:39:00 +02:00
Joffrey JAFFEUX
a9c3437d51
dashboard next: adds basic spec
2018-04-25 10:28:41 +02:00
Joffrey JAFFEUX
59d4123316
PERFORMANCE: disables jquery animations during testing
2018-04-24 18:29:26 +02:00
Sam
54d153068a
DEV: remove qunit rails fork and add a couple of async tests
2018-04-23 16:42:40 +10:00
Jeff Wong
252dd32895
show card on preview panel.
...
refactor user and group cards
refactor userLoading to loading
add logic to display cards above mentions for fixed placements
2018-04-20 12:28:24 -07:00
Guo Xiang Tan
6cce839f0a
FIX: Missing action to trigger add group members modal for group owners.
...
https://meta.discourse.org/t/unable-to-add-members-to-a-group-as-group-owner-who-is-not-staff/85346?u=tgxworld
2018-04-16 09:09:47 +08:00
Neil Lalonde
0e2584b841
fix cursor on disabled composer
2018-04-12 11:32:13 -04:00
Guo Xiang Tan
a389baeb07
FIX: Group pages should work when group name contains periods.
...
https://meta.discourse.org/t/group-name-cant-have-dot-inside/48658
2018-04-12 17:11:36 +08:00
Guo Xiang Tan
c0595ebe99
FIX: Disable save button when new group form is empty.
...
https://meta.discourse.org/t/adding-owners-members-ux-is-inconsistent-and-misleading/58084/26?u=tgxworld
2018-04-12 10:29:36 +08:00
Guo Xiang Tan
66abd340db
Fix randomly failing JS build.
...
For some reason, the test rack server would block on
a `/letter_avatar_proxy` route causing ajax requests to
stack up.
2018-04-11 22:23:49 +08:00
Neil Lalonde
6e6892c88e
FEATURE: when uncategorized topics are not allowed, disable the post input until a category is chosen
2018-04-10 19:31:28 -04:00
Joffrey JAFFEUX
d9ac0152e4
fixes search-full-test for revamped search page
2018-04-10 09:59:24 +02:00
Neil Lalonde
d7ea6f93e7
FIX: preference page error when badges are disabled
2018-04-09 14:27:00 -04:00
Régis Hanol
1b351a3355
disable full page search acceptance tests (cc @jjaffeux)
2018-04-09 20:14:57 +02:00
Guo Xiang Tan
c82b2dcc24
Remove admin group management pages.
2018-04-09 15:14:50 +08:00
Guo Xiang Tan
4319273cf5
UX: Split up group form into smaller sections.
2018-04-09 15:14:50 +08:00
Claas Augner
ba905b24ca
FIX: differentiate one/other select-kit maximumLabel/minimumLabel
2018-04-09 09:12:01 +02:00
Joffrey JAFFEUX
f0fe16d824
FEATURE: implements minimum selection for select-kit
2018-04-05 16:45:19 +02:00
Guo Xiang Tan
e36e9de28a
Allow admin to view logs of automatic groups.
2018-04-05 16:31:55 +08:00
Robin Ward
895bca5f5b
FIX: Broken JS tests
2018-04-02 14:18:10 -04:00
Joffrey JAFFEUX
3287ac77e0
FIX: reverts combobox placeholder and introduces noneLabel
...
noneLabels works almost like none but instead of actually adding a row in the list, it will only change the text displayed in the header, when there's no selection.
2018-03-29 13:42:00 +02:00
Guo Xiang Tan
52e75eaee9
UX: Tweaks to group pages.
2018-03-29 17:04:48 +08:00
Guo Xiang Tan
baa383b7f1
Fix the build.
2018-03-28 09:42:12 +08:00
Joffrey JAFFEUX
15aa712227
fix category-row regressions
2018-03-27 14:11:05 +02:00
Guo Xiang Tan
f6b6ddd73c
REFACTOR: Extract group form into a component.
2018-03-27 19:26:05 +08:00
Guo Xiang Tan
bc4de7b5ec
Make eslint happy.
2018-03-27 17:44:04 +08:00
Guo Xiang Tan
7edab1c0b9
UX: Add groups/custom/new
route for admins to create a new group.
2018-03-27 17:39:05 +08:00
Guo Xiang Tan
2ecd234e27
UX: Consolidation group manangement into a single tab.
2018-03-27 13:34:46 +08:00
Guo Xiang Tan
dcd1d422d1
UX: Allow admins to set users as owners while adding users.
...
https://meta.discourse.org/t/adding-owners-members-ux-is-inconsistent-and-misleading/58084/9
2018-03-26 17:33:50 +08:00
Guo Xiang Tan
27e60c78d4
Remove obsolete JS tests.
2018-03-26 16:26:42 +08:00
Guo Xiang Tan
35745166b5
UX: New group membership management workflow.
...
https://meta.discourse.org/t/adding-owners-members-ux-is-inconsistent-and-misleading/58084
2018-03-26 16:15:02 +08:00
Joffrey JAFFEUX
d48542796e
FIX: select-kit refactoring
...
- improve mini-tag-chooser keyboard behavior
- all multil select now respond to select all and left/right arrows
- improve events handling
- many minor tweaks
2018-03-22 11:29:55 +01:00
Guo Xiang Tan
f3b402ffd5
UX: Allow users to filter members on group page.
...
* Only admins are allowed to filter users by email.
2018-03-22 14:02:41 +08:00
Guo Xiang Tan
be866dbe6e
UX: Allow group owners to manage members from group members page.
2018-03-21 18:22:55 +08:00
Robin Ward
b9abd7dc9e
FEATURE: Shared Drafts
...
This feature can be enabled by choosing a destination for the
`shared drafts category` site setting.
* Staff members can create shared drafts, choosing a destination
category for the topic when it is published.
* Shared Drafts can be viewed in their category, or above the
topic list for the destination category where it will end up.
* When the shared draft is ready, it can be published to the
appropriate category by clicking a button on the topic view.
* When published, Drafts change their timestamps to the current
time, and any edits to the original post are removed.
2018-03-20 17:15:26 -04:00
Neil Lalonde
a9de712eed
FIX: not found message when trying to log in with a link, even though the email with the link was successfully sent
2018-03-19 16:08:10 -04:00
Guo Xiang Tan
2b7fb43d84
Fix the build.
2018-03-19 18:47:17 +08:00
Guo Xiang Tan
fe96ef6ed2
UX: Use topic list for displaying group messages on group page.
...
https://meta.discourse.org/t/group-inbox-on-a-groups-page-mockup/71319
2018-03-16 11:56:40 +08:00
Guo Xiang Tan
a35227918f
UX: Display group topics in a topic list.
2018-03-15 11:37:55 +08:00
Gerhard Schlager
243ee565dc
Reset widget decorators after each test
2018-03-12 14:22:50 +01:00
Sam
b57d4c87a4
FEATURE: update CommonMark to version 0.28
2018-03-08 12:19:53 +11:00
Gerhard Schlager
8e48b339fa
Drop unused tables ( #5630 )
2018-03-05 17:27:30 -05:00
Joffrey JAFFEUX
6d4ff05cf0
FIX: makes sure [999500..999999] is correctly shown as 999k
2018-03-02 11:00:48 +01:00
Guo Xiang Tan
b9ff6d60b9
Fix the build.
2018-03-02 14:43:02 +08:00
Guo Xiang Tan
d9b4b12694
UX: Display warning message about social logins disabled when 2FA is enabled.
2018-03-02 14:22:52 +08:00
Arpit Jalan
841e58fc46
delete extra blank lines
2018-02-27 15:51:50 +05:30
Arpit Jalan
ec8cc833c6
fix the build
2018-02-27 15:48:36 +05:30
Arpit Jalan
4010d8d9f9
FEATURE: show "edit message" button on message footer for staff
...
Show "Edit Message" button on personal message footer for staff if PM tagging is enabled.
2018-02-27 14:22:03 +05:30
Guo Xiang Tan
24bd310d7b
Fix the build.
2018-02-27 10:15:13 +08:00
Neil Lalonde
3313072957
Remove censored_pattern site setting, which is replaced by watched words
2018-02-26 16:29:27 -05:00
Joffrey JAFFEUX
ac701696b3
FEATURE: replaces tag-chooser/tag-group-chooser with select-kit component
...
These component were also the last using select2. As a consequence select2 is removed from Discourse in this commit.
2018-02-26 11:42:57 +01:00
Joffrey JAFFEUX
6f5acfe783
Login with email/forget password UI refactoring
...
* move button into login modal with social buttons
* adds email link next to login field when filling it
* adds proper validation messages
* improves forgot password flash clearing
* more tests
2018-02-22 08:06:15 +08:00
Guo Xiang Tan
14f3594f9f
Review Changes for f4f8a293e7
.
2018-02-21 14:55:49 +08:00
Jeff Wong
f4f8a293e7
FEATURE: Implement 2factor login TOTP
...
implemented review items.
Blocking previous codes - valid 2-factor auth tokens can only be authenticated once/30 seconds.
I played with updating the “last used” any time the token was attempted but that seemed to be overkill, and frustrating as to why a token would fail.
Translatable texts.
Move second factor logic to a helper class.
Move second factor specific controller endpoints to its own controller.
Move serialization logic for 2-factor details in admin user views.
Add a login ember component for de-duplication
Fix up code formatting
Change verbiage of google authenticator
add controller tests:
second factor controller tests
change email tests
change password tests
admin login tests
add qunit tests - password reset, preferences
fix: check for 2factor on change email controller
fix: email controller - only show second factor errors on attempt
fix: check against 'true' to enable second factor.
Add modal for explaining what 2fa with links to Google Authenticator/FreeOTP
add two factor to email signin link
rate limit if second factor token present
add rate limiter test for second factor attempts
2018-02-21 09:04:07 +08:00
OsamaSayegh
f3815cd785
FEATURE: New site setting for additional allowed filetypes for staff ( #5364 )
...
* FEATURE: New site setting for additional allowed filetypes for staff
* Problematic variable name
* feedback
* small issues
* fix indentation
* failing tests
* Remove message bus and fix minor issues
* Missed this message bus
2018-02-19 10:44:24 +01:00
Joffrey JAFFEUX
25dd8ff62a
FIX: broken composer-actions spec
2018-02-14 11:32:20 +01:00
Erick Guan
03b3e57a44
FEATURE: login by a link from email
...
Co-authored-by: tgxworld <tgx@discourse.org>
2018-02-13 16:14:39 +08:00
Sam
b34b1b6fe3
FIX: invite to message was not allowing groups
...
Previously we were incorrectly checking mentionable instead of messageable
Also fix edge case where multiple groups sharing a name mean that exact match override is not working
Also cleans up params sent to user selector
2018-02-13 13:28:46 +11:00
Vinoth Kannan
91beedd0ca
FEATURE: Composer HTML pasting ul tag support for MS Word
2018-02-10 01:18:56 +05:30
Joffrey JAFFEUX
190d208631
FEATURE: improves composer-actions toggle menu
...
* only toggles
* fix a bug with presence
* more tests
* do not duplicate `continuing discussion...` text
* persist state to allow switching between toggles
2018-02-08 11:46:55 +01:00
Robin Ward
80ea2e5107
FIX: Enable personal messages in tests
2018-02-02 17:06:02 -05:00
Robin Ward
8ff4104555
Many enhancements to the flagging / suspending interface.
2018-02-01 17:13:02 -05:00
Joffrey JAFFEUX
f7df68c9a3
FIX: makes composer-actions toggling whisper instead of replying
2018-02-01 23:07:37 +01:00
Joffrey JAFFEUX
97ddaeeae8
FIX: use css instead of js to fix select-kit-collection max-height
2018-02-01 16:56:07 +01:00
Joffrey JAFFEUX
9923829402
FEATURE: Menu toggle for different reply modes
...
Allow users to access different reply modes from the composer.
Actions introduced:
- reply_as_new_topic
- reply_as_private_message
- reply_to_topic
- reply_as_whisper/not
2018-02-01 16:42:56 +01:00
Robin Ward
96710754d9
Merge pull request #5540 from discourse/mixed-text-direction-support
...
FEATURE: Mixed text direction support
2018-02-01 07:29:15 -08:00
Arpit Jalan
49424fd798
rename private to personal
2018-02-01 13:25:29 +05:30
Arpit Jalan
ff0376a80b
rename 'enable_private_messages' to 'enable_personal_messages'
2018-02-01 13:25:29 +05:30
Arpit Jalan
25ec077eca
rename 'min_private_message_{post/title}_length' to 'min_personal_message_{post/title}_length'
2018-02-01 13:25:29 +05:30
Sam
187b0031c5
correct specs
2018-02-01 16:16:14 +11:00
Vinoth Kannan
10ed4c0078
FEATURE: Composer HTML pasting support for complex table formats
2018-01-31 01:39:11 +05:30
scossar
843d88c5d0
Remove unused imports
2018-01-29 20:11:12 -08:00
scossar
5d18f72b8c
Add tests for text-direction functions
2018-01-29 19:16:35 -08:00
scossar
41f1e7430c
Refactor code; add tests
2018-01-29 17:42:19 -08:00
Gerhard Schlager
eb52c5469e
FEATURE: Allow plugins to register a new locale
2018-01-25 14:57:41 +01:00
Neil Lalonde
dc97239040
FIX: censored regex words were replacing other text that shouldn't be censored
2018-01-24 12:33:47 -05:00
Sam
3b083ca0bd
correct spec
2018-01-24 13:23:27 +11:00
Vinoth Kannan
86e142b39f
UX: Copy selected text to the link building modal
2018-01-24 02:02:12 +05:30
Régis Hanol
c425a2d335
fix js suite
2018-01-22 17:48:03 +01:00
Kyle Zhao
83c549bd31
FEATURE: grant badges in post admin wrench ( #5498 )
...
* FEATURE: grant badges in post admin wrench
* only grant manually grantable badges
* extract GrantBadgeController mixin
2018-01-22 14:10:53 +11:00
Régis Hanol
f674b9e86e
FIX: encode image filename so '[', ']' and '|' doesn't break the markdown
2018-01-19 19:52:03 +01:00
Jeff Atwood
7ed41fae2b
Merge pull request #5493 from notriddle/home_logo_h1
...
Change the text-only home logo to an H1
2018-01-18 16:14:36 -08:00
Arpit Jalan
79eb9d7086
FEATURE: show header search results on search log term details page
2018-01-17 12:47:16 +05:30
Arpit Jalan
bd7e21fa99
fix the build
2018-01-15 14:35:11 +05:30
Arpit Jalan
785d063a6b
Merge pull request #5496 from techAPJ/admin-graphs
...
FIX: graphs should go to zero for missing dates
2018-01-15 11:10:29 +05:30
Arpit Jalan
b7ba490df7
FIX: graphs should go to zero for missing dates
2018-01-15 10:16:34 +05:30
Michael Howell
f29d233287
Fix test case for site logo as <h2>
2018-01-12 23:34:31 +00:00
Neil Lalonde
2493648f9c
PERF: calculate topic_counts for tags in an async job so tag queries that include counts are much faster
2018-01-12 11:03:03 -05:00
Joffrey JAFFEUX
e9fd4f271a
FIX: fix category-link spec failure
2018-01-11 13:43:05 +01:00
Joffrey JAFFEUX
3ee7b18886
FIX: disable by default limitMatches
2018-01-11 09:54:39 +01:00
Joffrey JAFFEUX
3ec2024466
select-kit refactoring
...
* improve events naming/handling
* do not explicitly check for true/Fasle
* make sure header is re-computed on toggle
2018-01-11 09:39:51 +01:00
Neil Lalonde
edb3a7f646
FIX: support for watched_words_regular_expressions when censoring words
2018-01-10 14:11:23 -05:00
Neil Lalonde
ad62f1099c
FIX: censored words should support * as wildcard
2018-01-09 15:53:40 -05:00
Joffrey JAFFEUX
c9921869f1
FIX: adds select-kit api to modify header computed content ( #5476 )
...
This api would allow to simply modify header text or icons, eg:
```
api.modifySelectKit("select-kit")
.modifyHeaderComputedContent((context, computedContent) => {
computedContent.title = "Not so evil";
return computedContent;
});
```
2018-01-09 10:52:32 +01:00
Robin Ward
fb863e18ec
FIX: Broken test
2018-01-08 17:22:53 -05:00
Vinoth Kannan
d18c42abd5
FIX: Ignore if the default localization node is not an object ( #5439 )
2017-12-27 16:53:53 +11:00
Vinoth Kannan
035f96d25f
Allow linked images inside table cells in HTML to Markdown conversion
2017-12-23 22:48:39 +05:30
Vinoth Kannan
3ae9d91d86
UX: Use tight list by default in HTML to Markdown conversion
2017-12-22 21:34:55 +05:30
Vinoth Kannan
ac1e93e82a
Minor fix to correctly trim spaces in HTML to Markdown conversion
2017-12-22 19:05:40 +05:30
Joffrey JAFFEUX
315b9d796d
select-kit refactoring
...
* better test helper
* more reliable tests
* more consistent use of data-value/data-name/title/aria-label everywhere: header and rows
2017-12-22 13:08:12 +01:00
Vinoth Kannan
4935ae4338
Remove unwanted spaces between HTML tags and support Word documents
2017-12-22 09:28:24 +05:30
Sam
ab2215e629
fix broken test
2017-12-21 20:19:15 +11:00
Vinoth Kannan
129d924c0d
Dont support single row or column tables in HTML to Markdown conversion
2017-12-21 12:58:57 +05:30
Vinoth Kannan
ac1d3a761e
Support for table & ol tags for HTML pasting in composer
2017-12-20 19:24:55 +05:30
Guo Xiang Tan
87c334c063
Fix randomly failing JS acceptance tests.
2017-12-20 11:04:47 +08:00
Arpit Jalan
eab66065d1
FEATURE: search log term details page ( #5445 )
2017-12-20 13:41:31 +11:00
Vinoth Kannan
6272f35eec
blockquote tag support for HTML pasting in composer
2017-12-19 20:59:55 +05:30
Guo Xiang Tan
dfed56cb57
Disable JS test that fails in headless mode.
2017-12-19 20:50:39 +08:00
Guo Xiang Tan
6a4f391e38
Switch to chrome headless mode instead of phantomjs.
2017-12-19 16:00:43 +08:00
Vinoth Kannan
ad41523895
FEATURE: Converting code tags to Markdown while pasting
2017-12-18 22:12:05 +05:30
Vinoth Kannan
0588edbc96
FEATURE: Keep supported HTML tags in HTML to Markdown conversion
2017-12-18 12:48:17 +05:30
Vinoth Kannan
4f2f42d710
PERF: Better handling of headings in HTML inline pasting
2017-12-17 00:45:21 +05:30
Vinoth Kannan
dc159d7fa6
Grab dimention of the clipboard images
2017-12-15 17:28:38 +05:30
Guo Xiang Tan
0f011e1c1c
Update fixtures to fix JS test.
2017-12-15 13:42:17 +08:00
Vinoth Kannan
f0497ee9c4
FEATURE: HTML to Markdown conversion using native JavaScript ES6 classes ( #5425 )
2017-12-15 10:28:20 +05:30
Régis Hanol
2f792bc59f
FIX: a topic should be visited when you've read everything and there's deleted posts at the end
2017-12-15 00:00:48 +01:00
Régis Hanol
cad122993a
eslint 😲 🔫
2017-12-13 22:24:02 +01:00
Régis Hanol
1b4483c942
FEATURE: Added 'select +below' and 'select +all replies' options to selecting posts
2017-12-13 22:12:06 +01:00
Joffrey JAFFEUX
c1c31b99ce
Replaces toolbar popup-menu with select-kit
2017-12-13 10:49:32 +01:00
Robin Ward
74b9828731
FIX: Remove mentions filters from user and groups
...
Additionally return no data if disabled
2017-12-07 16:29:02 -05:00
Joffrey JAFFEUX
fd99e1ef56
FEATURE: site setting enable_mentions to turn on/off mentions
2017-12-07 16:27:58 -05:00
Neil Lalonde
23ea4b6739
FIX: don't create featured link if title includes more than a url
2017-12-04 14:21:08 -05:00
Neil Lalonde
fb08441802
Revert "FIX: don't create featured link if title includes more than a url"
2017-12-04 12:53:12 -05:00
Neil Lalonde
cde42c3f69
FIX: don't create featured link if title includes more than a url
2017-12-04 12:03:41 -05:00
Joffrey JAFFEUX
dbadebacd1
FIX: allows select-kit to search by null value
2017-12-01 20:02:00 +01:00
Arpit Jalan
496cd3b4df
Merge pull request #5385 from techAPJ/search-logs-improvements
...
FEATURE: support search click through tracking for user, category and tags
2017-12-01 12:08:38 +05:30
Arpit Jalan
e3925278e2
FEATURE: support search click through tracking for user, category and tags
...
https://meta.discourse.org/t/search-logs-page/73281/11?u=techapj
This commit adds following features:
- support for tracking click through to user, tag and category
- new filter for search type (header, full page)
This commit also removes "most viewed topic" field from search logs page because we are now tracking multiple click through entities, so topic is not a special entity anymore. This also improves query perf. The query now takes `20.5ms` to runs, as opposed to `655.9ms` previously.
2017-12-01 12:04:55 +05:30
Arpit Jalan
fb735d78ef
fix the build
2017-11-30 17:28:36 +05:30
Sam
610d7a9412
teach acceptance test to work on the last day of the month
2017-11-30 13:20:04 +11:00
Gerhard Schlager
41e70c410c
FEATURE: replace GUID in image name uploaded from iOS ( #5370 )
2017-11-28 11:05:34 +01:00
Joffrey JAFFEUX
49b1df40fc
FIX: various issues when editing category permissions
...
This commit also adds multiple tests
2017-11-27 19:50:04 +01:00
Joffrey JAFFEUX
87ada55e67
FIX: avoids test failing at some times of the day
2017-11-27 10:49:35 +01:00
Joffrey JAFFEUX
96cdc4e66e
FIX: makes allowInitialValueMutation more restrictive
2017-11-24 13:15:02 +01:00
Joffrey JAFFEUX
63307c303a
FIX: regression preventing to set number of hours before closing
...
This commit also adds a full test suite for editing topic timer.
2017-11-24 02:48:45 +01:00
Joffrey JAFFEUX
9208909b26
tweak icon-library generation
2017-11-23 18:24:26 +01:00
Neil Lalonde
ac4b4e30dc
remove the test that only works in a browser
2017-11-22 15:23:06 -05:00
Neil Lalonde
6c86e0c94a
FEATURE: remove the featured link by editing the topic
2017-11-22 14:53:35 -05:00
Joffrey JAFFEUX
b14d9529b8
FIX: adds support for name changes tracking
2017-11-22 13:49:45 +01:00
Joffrey JAFFEUX
b2b565c2fb
select-kit initial plugin api implementation (0.8.13)
...
```
api.modifySelectKit("identifier-of-the-select-targeted")
.modifyContent((context, existingContent) => {})
.appendContent(() => {})
.prependContent(() => {})
.onSelect((context, val) => {});
```
2017-11-22 10:34:12 +01:00
Neil Lalonde
33feb62673
FIX: times showing as < 1m instead of blank
2017-11-21 14:33:49 -05:00
Robin Ward
7533e5b541
UX: Use date picker on full page search
2017-11-21 12:52:23 -05:00
Joffrey JAFFEUX
39f3dbd945
Introduces select-kit
...
* renames `select-box-kit` into `select-kit`
* introduces `single-select` and `multi-select` as base components
* introduces {{search-advanced-category-chooser}} as a better component for selecting category in advanced search
* improves events handling in select-kit
* recreates color selection inputs using {{multi-select}} and a custom {{selected-color}} component
* replaces category-selector by a component using select-kit and based on multi-select
* improves positioning of wrapper
* removes the need for offscreen, and instead use `select-kit-header` as a base focus point for all select-kit based components
* introduces a formal plugin api for select-kit based components
* introduces a formal pattern for loading and updating select-kit based components:
```
computeValue()
computeContent()
mutateValue()
```
2017-11-21 11:53:09 +01:00
Guo Xiang Tan
edc4b30f82
Remove tests that are no longer being used.
2017-11-21 18:07:23 +08:00
Robin Ward
b9595966d4
FIX: Error applying quotes with blank lines in front
2017-11-20 13:46:19 -05:00
Neil Lalonde
b37e40eea9
FEATURE: show read time in last 60 days
2017-11-16 15:46:51 -05:00
Arpit Jalan
3831663fea
FEATURE: search logs page ( #5313 )
2017-11-15 11:13:50 +11:00
Joffrey JAFFEUX
680696fc04
Replaces delete flag modal by a dropdown
2017-11-14 07:55:08 -08:00
Sam
38c103c75e
correct spec
2017-11-13 18:09:24 +11:00
Robin Ward
1f14350220
Rename "Blocked" to "Silenced"
2017-11-10 14:10:27 -05:00
Joffrey JAFFEUX
6d3ed966cd
FEATURE: replace admin flags modal by a select-box
2017-11-09 12:33:36 -08:00
Michael Howell
38b8d68c68
FEATURE: Allow the user to select a custom home page ( #5268 )
...
* Add user_home configuration option
* Use the new user_home preference to actually show the right home page
* Fix trailing whitespace
* Update user_option_serializer.rb
* Fix JavaScript default homepage tests
* Use an object instead of a giant switch
* Remove trailing whitespace
* Make the default `user_home` set to `null` instead of `0`
* Rename user_home to homepage_id
2017-11-10 06:45:19 +11:00