11 Commits

Author	SHA1	Message	Date
Guo Xiang Tan	010fe479cb	Fix linting.	2018-08-17 17:34:25 +08:00
Guo Xiang Tan	16c0ebe8a8	Fix the build.	2018-08-17 16:53:07 +08:00
Guo Xiang Tan	a26ef7738f	FIX: FileHelper#download should return nil if max size is exceeded.	2018-08-17 16:19:59 +08:00
Guo Xiang Tan	d1860a4f7d	DEV: Fix test to use an actual PNG instead of a GIF.	2018-08-07 12:02:35 +08:00
Guo Xiang Tan	b94633e844	FIX: FileHelper should prioritize response content-type. ... Request to a URL with `.png` extension may return a jpg instead causing us to attach the wrong extension to an upload.	2018-07-30 10:54:36 +08:00
Régis Hanol	0559a4736a	FIX: don't double request when downloading a file	2018-02-24 12:35:57 +01:00
Sam	8ecf313a81	FIX: correctly raise errors when downloads fail ... This corrects an issue where we are hitting Gravatar for 404 over and over Also ensures file download properly reports errors	2017-09-28 16:35:43 +10:00
Guo Xiang Tan	56f98de7b2	Use webmock to stub external web requests.	2017-05-26 15:19:09 +08:00
Robin Ward	cdbe027c1c	Refactor FileHelper to use keyword arguments.	2017-05-24 13:54:26 -04:00
Robin Ward	36e477750c	FIX: Use same code path for downloading images	2017-05-23 14:51:30 -04:00
Robin Ward	dd0cb6a117	FIX: Add missing test	2017-05-15 16:57:09 -04:00