Commit Graph

17152 Commits

Author SHA1 Message Date
Sam
574d447254 FIX: don't attempt to bump draft sequence if no editor
Rare case on old installs
2018-07-11 17:06:49 +10:00
Sam
0c59346478 PERF: reduce querying when creating notifications
also style avoid shadowing of vars
2018-07-11 12:38:11 +10:00
Maja Komel
0942e2c795 allow adding tags as a custom subject format for emails (#5846)
allow adding tags as a custom subject format for emails
2018-07-11 12:24:07 +10:00
Guo Xiang Tan
a17f5052a3 FIX: ignored_columns was called twice. 2018-07-11 09:52:37 +08:00
Kris
6a530b8949 Prevent long strings from overflowing bulk buttons 2018-07-10 17:05:27 -04:00
Neil Lalonde
1021bc5640 FIX: invisible images and incorrect css on password reset and accept invite pages 2018-07-10 11:18:12 -04:00
Neil Lalonde
3b7acbd086 FIX: broken image on password reset page on subfolder installs 2018-07-10 11:10:06 -04:00
Guo Xiang Tan
8f4cb1a742 UX: Timeline lookup on mega topics should use date of current post. 2018-07-10 16:43:20 +08:00
OsamaSayegh
f2cc05c6c6 FIX: ignore self-quotes from the same post when saving (#6082) 2018-07-10 16:17:28 +08:00
Maja Komel
ba7a8db0e8 UX: show custom footer on user activity and preferences pages (#6080) 2018-07-10 16:14:26 +08:00
Joe
59950b0f95
UX: category description display issue
html tags like `<strong>` are displayed on separate lines inside a flexbox with `flex-wrap`
2018-07-10 13:51:46 +08:00
Guo Xiang Tan
5374a0e720 Fix the build. 2018-07-10 09:48:57 +08:00
Jordan Seanor
10bc69a62f FEATURE: Event on topic merge (#6057) 2018-07-10 09:28:57 +08:00
Canapin
6cc860be09 Update user.scss (#6079)
Prevent user custom fields new lines going under the user avatar on the profile page when the user has no bio.
2018-07-10 08:03:18 +08:00
Guo Xiang Tan
4172e1dd52
FIX: Rename User#usernames that clashes with Group#name. (#6069) 2018-07-09 16:54:57 +08:00
Guo Xiang Tan
96aca6d7e6
Remove legacy vote post action code. (#6009) 2018-07-09 16:54:18 +08:00
Sam
d9a9682f72 FIX: also count sub categories in hamburger when needed
previously there were cases where we suppress subcategories yet don't count them
this leads to confusion
2018-07-09 16:52:55 +10:00
Sam
330e848d4a FIX: if s3 set via global setting bypass config check in UI 2018-07-09 15:38:06 +10:00
David Taylor
9a813210b9 SECURITY: Do not allow authentication with disabled plugin-supplied a… (#6071)
Do not allow authentication with disabled plugin-supplied auth providers
2018-07-09 14:25:58 +10:00
michael@discoursehosting.com
81188060d6 Add S3 region eu-west-3 (Paris) 2018-07-09 14:18:35 +10:00
Joe
d36c260dd0
UX: adds flexbox to topic user name fields on mobile 2018-07-09 11:45:00 +08:00
Guo Xiang Tan
6d0732f7b4 Disable service worker on Apple devices for now.
The service worker is not used for any features
on Apple devices and we've received multiple reports
of service workers causing problems.
2018-07-09 11:34:16 +08:00
Guo Xiang Tan
0ab42e9185 Revert "DEV: Add param that allows service worker to be removed."
This reverts commit cb12f462a2.
2018-07-09 11:29:09 +08:00
Guo Xiang Tan
cb12f462a2 DEV: Add param that allows service worker to be removed. 2018-07-09 11:24:06 +08:00
Joffrey JAFFEUX
9f558d7e74
FIX: mixed texts when mixing rtl/ltr text in topic tile on categories page 2018-07-08 08:37:12 +02:00
Joe
4852e5df34
FIX: mobile /admin/users style fixes 2018-07-07 12:28:04 +08:00
Andrew Schleifer
dba22bbde2 rollback changes
This reverts:
* 1baba84c438e "fix s3 subfolders harder"
* ea5e57938edf "fix test for absolute_base_url change"
2018-07-06 17:16:40 -05:00
Andrew Schleifer
52e9f49ec1 fix s3 subfolders harder
specifically, include the folder in absolute_base_url
2018-07-06 16:28:40 -05:00
Maja Komel
18f5f646b1 FEATURE: allow selecting a tag when moving posts to a new topic (#6072) 2018-07-06 18:21:32 +02:00
Maja Komel
7cba4cbcc6 FEATURE: allow selecting a tag when moving posts to a new topic (#6074) 2018-07-06 18:21:00 +02:00
Guo Xiang Tan
875008522d FIX: Discourse.S3BaseUrl did not account for subfolder bucket names. 2018-07-06 15:53:57 +08:00
Guo Xiang Tan
73e30ff4c2 Revert "Rename s3 vars, change condition when displaying s3 uploads"
The new variables do not reflect that they represent S3 settings.

This reverts commit 24dfa1b657.
2018-07-06 15:53:57 +08:00
Guo Xiang Tan
7163bf9323 FIX: Upload.get_from_url not respective subfolder in s3 bucket names. 2018-07-06 11:37:11 +08:00
Neil Lalonde
eabc8f7fbd
Merge pull request #6023 from misaka4e21/only-staff-can-create-tag
FEATURE: Support disabling tag creation for non-staff users.
2018-07-05 11:12:44 -04:00
Patrick Gansterer
28dd7fb562 FEATURE: Create hidden posts for received spam emails (#6010)
* Add possibility to add hidden posts with PostCreator

* FEATURE: Create hidden posts for received spam emails

Spamchecker usually have 3 results: HAM, SPAM and PROBABLY_SPAM
SPAM gets usually directly rejected and needs no further handling.
HAM is good message and usually gets passed unmodified.
PROBABLY_SPAM gets an additional header to allow further processing.
This change addes processing capabilities for such headers and marks
new posts created as hidden when received via email.
2018-07-05 11:07:46 +02:00
Joe
dc04892a2d
FIX: mobile /admin/users page adjustments 2018-07-05 16:18:51 +08:00
Guo Xiang Tan
af5cd7e548 Unregister old service workers when Discourse.ServiceWorkerURL changes. 2018-07-05 14:57:32 +08:00
Joe
b5d29f7d88
FIX: responsive admin adjustments 2018-07-05 14:32:27 +08:00
Sam
7b26f5086b PERF: we have no use for topic percent rank
Prepare to remove this column
2018-07-05 15:10:19 +10:00
Christoph Holtermann
68bfe0260a Fix typo (#6043)
typo: state instead of status
2018-07-05 09:26:48 +08:00
Sam
b54ba4c952 FIX: mentions broken after adding an <abbr> tag
A previous shortcut used was not allowing for <abbr and other tags starting with a

If <abbr> appeared anywhere in the text all mentions would fail to link
2018-07-05 09:27:11 +10:00
Joffrey JAFFEUX
4273e30b9a
fix prettier offense 2018-07-04 17:41:07 +02:00
Joe
d8e51095c9
FIX: mobile topic-timer adjustments 2018-07-04 19:23:09 +08:00
Maja Komel
b02b44c966 prettier formatting 2018-07-04 11:03:48 +02:00
Maja Komel
cb89797e9a FEATURE: shows remaining backup codes in user preferences 2018-07-04 10:45:42 +02:00
Arpit Jalan
b9835cc392 FIX: do not use scheduler for uploading csv file for invite
Since the bulk invite process already happens in a dedicated Sidekiq job
2018-07-04 13:28:11 +05:30
Vinoth Kannan
9cc7df13a4 FIX: Unable to add new webhook if the webhooks list is empty 2018-07-04 09:48:11 +05:30
Sam
e72fd7ae4e FIX: move crawler blocking into anon cache
This refinement of previous fix moves the crawler blocking into
anonymous cache

This ensures we never poison the cache incorrectly when blocking crawlers
2018-07-04 11:14:43 +10:00
Sam
7f98ed69cd FIX: move crawler blocking to app controller
We need access to site settings in multisite, we do not have access
yet if we attempt to get them in request tracker middleware
2018-07-04 10:30:50 +10:00
Leo McArdle
c3129444ea FIX: allow multiple secondary emails 2018-07-03 18:21:35 +08:00
Joe
888a827b93
FIX: removes inline styles applied to "all categories" in category dropdown
"all categories" in the category dropdown gets category-like inline styles when category mode is set to "box"
2018-07-03 12:02:50 +08:00
Joe
2bfe700bd6
FEATURE: responsive admin pages 2018-07-03 11:14:53 +08:00
Jeff Wong
2b240e74b5 fix typo 2018-07-02 15:35:24 -07:00
Jeff Wong
42b11fc2c5 Fix: Add pan direction data, do not activate pan when event is not vertical 2018-07-02 15:26:01 -07:00
Joffrey JAFFEUX
b4cb31d999
FIX: disabled topic timeline panning on desktop 2018-07-02 14:52:02 +02:00
Joffrey JAFFEUX
c754ece8f5
FEATURE: drops with-email-link and replaces it by with-email-button 2018-07-02 14:35:50 +02:00
Misaka 0x4e21
cb86c5ae1e FIX: Fix badge count of other users. (#6016)
Don't count the current user in "Others with this badge".
2018-07-02 15:34:09 +08:00
Guo Xiang Tan
969e79d7c6 PERF: Do not calculate gaps for TopicViewPostsSerializer.
The client doesn't use the gaps results when loading new posts.
2018-07-02 14:01:50 +08:00
Maja Komel
3ddfc12307 unify user preferences views 2018-07-02 15:38:36 +10:00
Guo Xiang Tan
f7322c05ad FIX: Avoid destroy_all in Jobs::CleanUpUploads.
`destroy_all` loads all the relation into memory as once.

See https://github.com/rails/rails/issues/22510
2018-07-02 12:44:36 +08:00
Joe
f3a1b3829a
FIX: composer popup close link overlaps with text 2018-06-30 13:02:10 +08:00
Joffrey JAFFEUX
405998b3fe
FIX: ensures correct icon is displayed on mobile upload shortcut button 2018-06-30 02:26:55 +02:00
Jeff Wong
f4d77037d0 prettierjs formatting 2018-06-29 10:02:52 -07:00
Jeff Wong
d79b54de6c make linter happy 2018-06-29 09:53:07 -07:00
Jeff Wong
8bdb62ca01 FEATURE: add swipe detection for dismissing mobile topic scroller 2018-06-29 09:44:18 -07:00
Joffrey JAFFEUX
1772b56cda
FIX: minor micro data fixes 2018-06-29 13:41:04 +02:00
Arpit Jalan
7550e9ff95 FIX: purge unactivated users with a message from non-human users 2018-06-29 13:03:04 +05:30
Joe
15bb8954de
FIX: low contrast issues for dark themes in edit history modal 2018-06-29 14:42:26 +08:00
OsamaSayegh
f4369fa99e FIX: use logo_url settign when present for mobile layout instead of site name 2018-06-29 15:07:10 +10:00
Guo Xiang Tan
d1c3eb6bfa FIX: Recovering a post does not insert it back into the stream correctly. 2018-06-29 11:41:44 +08:00
hellekin
25cfc98b67 Fix 'asscoiated' typo
I know that **Naming is CRITICAL** and that **Refactoring only NOT welcome**.

But since I spotted this (consistent) typo and the change does not affect any
functionality -- I checked the presence of "asscoiated" in the code base, I
guess the first rule trumps the second one.

It also gave me a false pretext to bypass my reluctance to use Google forms and
sign de CLA. Typos hurt the eye.
2018-06-29 11:10:05 +10:00
Sam
6a54da0902 FIX: raise invalid params for bad callback
Corrects it so we raise a 400 instead of logged 500 error
2018-06-29 10:43:33 +10:00
Sam
e0bc6590fd minor cleanup 2018-06-29 10:30:22 +10:00
Sam
982df3c17b FIX: return status 400 for invalid member params
previously error returned was a 500 which is not ideal
and is logged
2018-06-29 10:15:17 +10:00
Robin Ward
5350429870 FIX: Don't replace the wiki button if the user can't edit 2018-06-28 14:48:28 -04:00
Robin Ward
5d1d7e0e7d PERF: Scanning the id for this is signficantly slower in production 2018-06-28 11:04:40 -04:00
Robin Ward
fd7bb8e656 FIX: Scope the cn to the subfolder 2018-06-28 11:03:36 -04:00
Arpit Jalan
2c971c41f6 FIX: post deletions rate limit per day was not working 2018-06-28 19:21:27 +05:30
Arpit Jalan
a6d50d1ff7 FEATURE: new settings to control posts deletions rate limit 2018-06-28 17:03:37 +05:30
Arpit Jalan
c352f8eb15 FEATURE: rate limit post deletions to 50 per day 2018-06-28 16:38:58 +05:30
Maja Komel
4ca09599af Add prettier preferences-second-factor-backup.js.es6 2018-06-28 18:32:20 +10:00
Sam
db14e10943 SECURITY: category badges should HTML escape names 2018-06-28 18:15:07 +10:00
Maja Komel
ec3e6a81a4 FEATURE: Second factor backup 2018-06-28 10:12:32 +02:00
Arpit Jalan
c738f92234
Merge pull request #6046 from jjaffeux/tooltip-xss-1
SECURITY: prevents XSS when showing tooltip
2018-06-27 18:10:55 +05:30
Joffrey JAFFEUX
b5b847f6d6 SECURITY: prevents XSS when showing tooltip 2018-06-27 14:35:47 +02:00
Guo Xiang Tan
cfa7898c2d Rename TopicView#last_read_post_id to TopicView#filtered_post_id. 2018-06-27 12:33:57 +08:00
Guo Xiang Tan
cb69888758 PERF: Don't pluck all the columns just to retrieve a single value. 2018-06-27 11:41:35 +08:00
misaka4e21
47cb46671a FEATURE: Support disabling tag creation for non-staff users. 2018-06-27 07:15:02 +08:00
Arpit Jalan
6bcdc3ba4b FEATURE: allow author to delete posts irrespective of post_edit_time_limit 2018-06-26 21:43:06 +05:30
OsamaSayegh
d81f8ea378
fix prettier 2018-06-26 15:31:43 +03:00
OsamaSayegh
bfe0178270 FIX: use the correct notification levels titles for PMs 2018-06-26 14:01:52 +02:00
Arpit Jalan
7efdccdbc5 FIX: allow staff to remove tags from queued topics 2018-06-26 17:08:40 +05:30
OsamaSayegh
a603660ba5 FIX: scroll to top when accessing admin dashboard 2018-06-26 12:19:58 +02:00
Joffrey JAFFEUX
eb9b99e519
FIX: makes select-kit match searches with accents (filter and content) 2018-06-26 12:19:14 +02:00
Guo Xiang Tan
49ffc1eb61 Revert "PERF: Send down gaps as the relevant posts load instead of front loading."
This reverts commit 4c3352528e.
2018-06-26 12:54:14 +08:00
Guo Xiang Tan
4c3352528e PERF: Send down gaps as the relevant posts load instead of front loading. 2018-06-26 12:49:06 +08:00
Guo Xiang Tan
0b6a2e9d1f Remove force summary mode for megatopics for now.
The logic is too hairy and we can't reliably determine
when to force summary mode. Work is underway to improve
perf for megatopics so this will not be required
eventually.
2018-06-26 12:49:06 +08:00
Maja Komel
24dfa1b657 Rename s3 vars, change condition when displaying s3 uploads 2018-06-25 17:16:01 +02:00
Kris
a0b799810b post-info glyph margin fix 2018-06-25 10:50:16 -04:00
Joffrey JAFFEUX
803968147c
FIX: ListItem can’t have itemprop=url and itemprop=item together 2018-06-25 14:12:55 +02:00