github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2024-12-16 07:01:00 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity
30,009 Commits 214 Branches 500 Tags 960 MiB
b8aec7777c
Commit Graph

17835 Commits

Author SHA1 Message Date
David Taylor
d4d5088324 FIX: Don't require device capabilities when calculating login methods 2018-08-08 10:37:25 +01:00
David Taylor
575d9e0b1a FIX: Include parameters in function call 2018-08-08 10:09:22 +01:00
Guo Xiang Tan
ba6f11c521 PERF: Only log the first skipped email when user exceeds daily limit. 
https://meta.discourse.org/t/cleaning-up-e-mail-logs/39132
 2018-08-08 16:25:00 +08:00
Osama Sayegh
0d45826d22
fix theme previewing (#6245) 2018-08-08 10:58:45 +03:00
Osama Sayegh
0b7ed8ffaf FEATURE: backend support for user-selectable components 
* FEATURE: backend support for user-selectable components

* fix problems with previewing default theme

* rename preview_key => preview_theme_id

* omit default theme from child themes dropdown and try a different fix

* cache & freeze stylesheets arrays
 2018-08-08 14:46:34 +10:00
Sam
3f6ad65aec FEATURE: include excerpt in HTML view for pinned topics 2018-08-08 11:15:49 +10:00
Neil Lalonde
4e6e4a83df FIX: subfolder digest emails have incorrect URLs 2018-08-07 16:38:17 -04:00
Kris
17d8fea796 Markdown tables should have vertical margin 2018-08-07 16:15:28 -04:00
Kris
48ecad53f2 additional hamburger alignment fix 2018-08-07 09:47:01 -04:00
Joffrey JAFFEUX
67ec81babf
FIX: fixes last backup/last_update dates (#6242) 2018-08-07 08:19:52 -04:00
David Taylor
aa9a9a5a72 FIX: Include auth_providers for anonymous users when login_required 2018-08-07 09:24:16 +01:00
Guo Xiang Tan
d5a7b818ba FIX: Move Jobs::CreateAvatarThumbnails to low priority queue. 2018-08-07 16:05:54 +08:00
Guo Xiang Tan
2b57239389 FIX: Upload's content is the only source of truth for the file type. 2018-08-07 13:15:00 +08:00
Sam
6797395bd0 FIX: staff should be allowed to agree and keep post 2018-08-07 10:05:43 +10:00
Joffrey JAFFEUX
8477501e83
FIX: imrpoves alert-error styles in counters reports (#6240) 2018-08-06 16:59:45 -04:00
Joffrey JAFFEUX
7f2f3b8b22
FIX: improves reports resilience (#6239) 
This commit makes most of the reports now lazy loaded, and making them benefits from graceful failures.
 2018-08-06 16:57:40 -04:00
Joffrey JAFFEUX
c301111461
FIX: display select kit body if no choices (#6237) 2018-08-06 11:22:48 -04:00
Kris
74269ad585 FIX: hamburger menu category alignment 2018-08-06 11:11:29 -04:00
Leo McArdle
9b04921616 FIX: don't require auth providers to set full_screen_login_setting 2018-08-06 10:24:39 +01:00
David Taylor
812add18bd REFACTOR: Serve auth provider information in the site serializer. 
At the moment core providers are hard-coded in Javascript, and plugin providers get added to the JS payload at compile time. This refactor means that we only ship enabled providers to the client.
 2018-08-06 09:25:48 +01:00
Guo Xiang Tan
4e11811321 FIX: UserAvatar#update_gravatar! does not update User#uploaded_avatar. 
https://meta.discourse.org/t/missing-user-profile-pictures/93844/4
 2018-08-06 13:29:44 +08:00
Osama Sayegh
18b396ad56 FEATURE: add link to see new commits when updates are available for themes (#6233) 
* FEATURE: add link to see new commits when updates are available for themes

* shorten regexp
 2018-08-06 15:29:15 +10:00
Joe
cc77a285ee
UX: improves edit reason contrast in dark themes 2018-08-06 10:53:46 +08:00
Régis Hanol
0cd9e2acb9 fix build 2018-08-04 01:56:26 +02:00
Régis Hanol
bf4d98e89d FIX: always store topic links using the upload url 2018-08-04 01:29:32 +02:00
Kris
84d822959a Reducing some specificity, color fix 2018-08-03 17:44:22 -04:00
Joffrey JAFFEUX
066010db7d
FEATURE: introduces list/compact_list components 2018-08-03 16:41:37 -04:00
Kris
072f5ce825 Increase ruby character size 2018-08-03 13:37:08 -04:00
Régis Hanol
535732bdc1 FIX: ensure the 'email_revoked' PM template is customizable 2018-08-03 17:10:20 +02:00
Sam
280c318c49 FEATURE: allow ruby tags in Markdown 2018-08-03 11:47:36 +10:00
Osama Sayegh
880462a41c FEATURE: display out of date themes on admin dashboard 
* FEATURE: disaply out of date themes on admin dashboard

* Update copy
 2018-08-03 09:53:48 +10:00
Neil Lalonde
864e279aaf FIX: wrong links to subcategories in top categories section of user summary 2018-08-02 17:38:42 -04:00
Joffrey JAFFEUX
1ca999fdb5
FIX: formats topic report only if we have one (#6231) 2018-08-02 08:01:17 -04:00
Sam
0b3d51a8bc FEATURE: whitelist lang attribute 2018-08-02 16:53:08 +10:00
Kris
9499693baa Layout works better with auto columns 2018-08-01 22:37:21 -04:00
Joffrey JAFFEUX
60f62f6f36
FIX: improves report-show mobile UI (#6229) 2018-08-01 19:54:27 -04:00
Joffrey JAFFEUX
859c98743f
FIX: removes ellipsis from activity-metrics report cells 2018-08-01 19:08:53 -04:00
Joffrey JAFFEUX
8cbe3cbe26
this file shouldn’t have been comitted 2018-08-01 19:01:47 -04:00
Joffrey JAFFEUX
9073e11943
FIX: improves number/percent support in reports 2018-08-01 18:40:59 -04:00
Penar Musaraj
4a872823e7 Improvements to user drafts (#6226) 
* drafts in user profile: only show to user herself (not to admins), use avatar replying to (instead of topic OP), add keyboard shortcut for drafts, simplify display labels

* use JSON when testing Draft.stream
 2018-08-02 07:41:27 +10:00
Kris
8147130412 Group icon misalignment 2018-08-01 17:30:17 -04:00
Kris
d678ef2653 group icon needs margin 2018-08-01 17:05:35 -04:00
Kris
04255d1dce removing unneeded styles 2018-08-01 16:38:47 -04:00
Kris
f0bea4ae55 Improve PM participant list 2018-08-01 16:20:14 -04:00
Robin Ward
4eef41ea1b FIX: Error with debouncing mentions 2018-08-01 15:57:24 -04:00
Gerhard Schlager
2ec1aec2be FIX: Clicking admin wrench in topic footer didn't hide post select box 2018-08-01 21:29:35 +02:00
Dan Ungureanu
1a0ffc5ace FEATURE: Added method to get multiple values at once from PluginStore. (#6225) 2018-08-01 18:42:40 +02:00
Gerhard Schlager
f4ca105498 FIX: Moving posts to existing topic didn't update topic metadata 2018-08-01 18:05:43 +02:00
Robin Ward
d7b463a03d FIX: Remove unused import 2018-08-01 11:54:47 -04:00
Robin Ward
7c950321d1 FIX: Allow non-english usernames in autocomplete 
Also add support for username formatters
 2018-08-01 11:53:20 -04:00
Neil Lalonde
b829452c75
Merge pull request #6209 from discourse/mini_scheduler 
REFACTOR: extract scheduler to the mini_scheduler gem
 2018-08-01 10:28:24 -04:00
Joffrey JAFFEUX
0b9437cee7
FIX: more resilient/consistent dashboard caching (#6223) 2018-08-01 09:45:50 -04:00
Joffrey JAFFEUX
7c7dfa4e5e
FIX: wraps any query with the slow query guard (#6222) 2018-08-01 07:39:57 -04:00
Vinoth Kannan
8178444382 Make prettier happy 2018-08-01 15:13:54 +05:30
Vinoth Kannan
8556288397 DEV: Export Tag class to modify methods in plugin 2018-08-01 15:10:15 +05:30
Gerhard Schlager
a115aae45f Use rchardet instead of charlock_holmes gem 2018-08-01 10:41:20 +02:00
Gerhard Schlager
5d421fb946 FIX: Try respecting charset in HTTP header of RSS feed 2018-08-01 10:41:20 +02:00
Gerhard Schlager
ff942ed2f3 FIX: Try detecting encoding of RSS feed 2018-08-01 10:41:20 +02:00
Penar Musaraj
1f45215537 FEATURE: Drafts view in user profile 
* add drafts.json endpoint, user profile tab with drafts stream

* improve drafts stream display in user profile

* truncate excerpts in drafts list, better handling for resume draft action

* improve draft stream SQL query, add rspec tests

* if composer is open, quietly close it when user opens another draft from drafts stream; load PM draft only when user is in /u/username/messages (instead of /u/username)

* cleanup

* linting fixes

* apply prettier styling to modified files

* add client tests for drafts, includes a fixture for drafts.json

* improvements to code following review

* refresh drafts route when user deletes a draft open in the composer while being in the drafts route; minor prettier scss fix

* added more spec tests, deleted an acceptance test for removing drafts that was too finicky, formatting and code style fixes, added appEvent for draft:destroyed

* prettier, eslint fixes

* use "username_lower" from users table, added error handling for rejected promises

* adds guardian spec for can_see_drafts, adds improvements following code review

* move DraftsController spec to its own file

* fix failing drafts qunit test, use getOwner instead of deprecated this.container

* limit test fixture for draft.json testing to new_topic request only
 2018-08-01 16:34:54 +10:00
Guo Xiang Tan
70ea153dce Fix lint. 2018-08-01 12:23:36 +08:00
Guo Xiang Tan
53adbf70f3 FIX: Nav item missing for plugins that don't include a custom filter. 2018-08-01 11:50:14 +08:00
Joffrey JAFFEUX
5febe71baa
FIX: prevents crash if flagger doesn’t exist (#6219) 2018-07-31 23:48:54 -04:00
Joffrey JAFFEUX
849f0d00f6
FEATURE: adds revision_count to moderators_activity (#6218) 
Co-Authored-By: Simon Cossar <scossar@users.noreply.github.com>
 2018-07-31 23:40:45 -04:00
Guo Xiang Tan
919e8db686 FIX: Check for group name availability should skip reserved usernames. 2018-08-01 11:09:33 +08:00
Kris
129268ddc6 Highlighted titles too wide on mobile 2018-07-31 21:24:43 -04:00
Joffrey JAFFEUX
2b2a506a7b
FIX: makes dashboard more resilient to errors (#6217) 
This commit is an attempt to limit cases where the dashboard will generate a full exception page and also make it easier to track the error.
 2018-07-31 21:23:28 -04:00
Joffrey JAFFEUX
0715aa18da
UI: uses tiny avatars for reports (#6215) 2018-07-31 18:57:00 -04:00
Joffrey JAFFEUX
37252c1a5e
UI: improves dashboard table reports 
- support for avatars
- support for topic/post/user type in reports
- improved totals row UI
- minor css tweaks
 2018-07-31 17:35:13 -04:00
Neil Lalonde
4ad7ce70ce REFACTOR: extract scheduler to the mini_scheduler gem 2018-07-31 17:12:55 -04:00
Robin Ward
4b166cccc1 FIX: Linting error 2018-07-31 14:19:45 -04:00
Robin Ward
b6bb8df622 FIX: We loosened username restrictions some time ago 
Additionally, remove `Discourse.User` constant
 2018-07-31 13:53:31 -04:00
Vinoth Kannan
ece3cb73df Rename humburger_menu_categories_count site setting to header_dropdown_category_count 2018-07-31 09:12:30 +05:30
Neil Lalonde
fd29ecb91a UX: include a flag reason in the post-deleted-by-staff-because-of-flags message 2018-07-30 16:45:46 -04:00
Neil Lalonde
c12a9279f6 post deleted notification regression because controller was agreeing with all flags too early 2018-07-30 16:45:46 -04:00
Vinoth Kannan
c1e62808ed FIX: Top site categories are displayed in random order 2018-07-31 01:01:03 +05:30
Kris
7368dd8e7d Prevent activity-metrics stats from wrapping 2018-07-30 14:40:26 -04:00
Joffrey JAFFEUX
c6fd506a15
fix eslint 2018-07-30 13:10:20 -04:00
Joffrey JAFFEUX
2c90a2e5c2
FIX: prevents mini-tag-chooser to catch unwanted focus 2018-07-30 13:03:40 -04:00
Joffrey JAFFEUX
a327393651
fix 1.14.0 prettier offenses 2018-07-30 11:56:48 -04:00
Joffrey JAFFEUX
536f88b95b Revert "DEV: prettier 1.14.0" 
This reverts commit 1f899bec21.
 2018-07-30 11:52:05 -04:00
Joffrey JAFFEUX
1f899bec21
DEV: prettier 1.14.0 2018-07-30 11:09:08 -04:00
Vinoth Kannan
c54b5824d4 REFACTOR: Prioritize unread categories in hamburger menu 2018-07-30 20:20:10 +05:30
David Taylor
6566b2f11a FEATURE: Allow revoke and connect for Instagram logins 2018-07-30 14:38:53 +01:00
Joffrey JAFFEUX
d494feaa32
FIX: should not be needed as we have itemprop='url' 2018-07-30 09:31:27 -04:00
Arpit Jalan
dfcb2a0d42 FEATURE: include published_time in metadata 2018-07-30 17:09:56 +05:30
Vinoth Kannan
50df2d7241 FIX: Should not include regular categories in top_category_ids array 2018-07-30 16:06:36 +05:30
Maja Komel
04baddf731 DEV: migrate tests to async/await 2018-07-30 12:21:05 +02:00
Vinoth Kannan
176d8ca78d
FIX: Hide muted categories from hamburger menu top categories block 2018-07-30 15:39:37 +05:30
Vinoth Kannan
249b16e8e3 FIX: Hide muted categories from hamburger menu top categories block 2018-07-30 15:37:41 +05:30
Guo Xiang Tan
581cf62bcf UX: Allow emojis to be displayed in nav-item. 2018-07-30 18:02:34 +08:00
Guo Xiang Tan
ef78268c01 Give ExtraNavItem more control over when it can be displayed. 2018-07-30 17:30:13 +08:00
Arpit Jalan
ba64ebbf10 FIX: preserve whitespace between uploads when the process is complete 2018-07-30 14:49:33 +05:30
Vinoth Kannan
78d91b1daf
UX: Changes in top categories of hamburger menu (#6200) 2018-07-30 14:13:00 +05:30
Guo Xiang Tan
acde8d4323 Fix the build. 2018-07-30 15:07:03 +08:00
Guo Xiang Tan
96a0448c52 FIX: Add onceoff job to fix incorrect extension for gravatar uploads. 2018-07-30 14:44:02 +08:00
Guo Xiang Tan
87537b679c Drop reply_key, skipped and skipped_reason from email_logs. 2018-07-30 11:39:28 +08:00
Guo Xiang Tan
b94633e844 FIX: FileHelper should prioritize response content-type. 
Request to a URL with `.png` extension may return a jpg
instead causing us to attach the wrong extension to an
upload.
 2018-07-30 10:54:36 +08:00
Arpit Jalan
fc3b904e1f remove "track external right clicks" feature 2018-07-29 15:01:33 +05:30
Joe
3dbaaf0d74
UX: gives wizard language selector more room to expand 2018-07-28 11:51:53 +08:00
Kris
7a1a1eb4c0 improve header scaling with font size 2018-07-27 16:49:28 -04:00
Joffrey JAFFEUX
a8f1b07686
FIX: prevents exception when loading old dashboard (#6196) 2018-07-27 16:29:30 -04:00
Kris
3159c46613 Making dataless sections stand out less 2018-07-27 14:55:51 -04:00
Kris
60b2c3207e larger mobile topic list badges 2018-07-27 13:10:13 -04:00
David Taylor
5f1fd0019b FEATURE: Allow revoke and connect for GitHub logins 2018-07-27 17:18:53 +01:00
David Taylor
6296f63804 FEATURE: Revoke and connect for Yahoo logins 2018-07-27 16:20:47 +01:00
Vinoth Kannan
a9c959e3e2 Make prettier happy 2018-07-27 20:39:44 +05:30
Vinoth Kannan
bc501038cb FIX: Remove null value from categories list 2018-07-27 20:00:39 +05:30
Joe
85291e53f1
UX: more categories link alignment 2018-07-27 22:17:29 +08:00
David Taylor
9c72c00206 FEATURE: Revoke and reconnect for Twitter logins 2018-07-27 12:28:51 +01:00
Vinoth Kannan
5b4e13bfcc Make prettier happy 2018-07-27 13:20:21 +05:30
Vinoth Kannan
c0f7d95bb8 Include subcategories in hamburger menu top categories 2018-07-27 13:05:18 +05:30
Vinoth Kannan
dac29b5ebc
UX: Display only top categories in hamburger menu (#6146) 2018-07-27 12:11:07 +05:30
Joffrey JAFFEUX
b7d1864d0a
FIX: simplify filters on admin-report component (#6193) 2018-07-27 01:22:00 -04:00
Guo Xiang Tan
6f9a91cbd5
Merge pull request #6175 from vinothkannans/post_approval_webhook 
FEATURE: Webhook for post approval events
 2018-07-27 10:50:49 +08:00
Guo Xiang Tan
ccf76d45f2 FIX: Missing variable outside of begin block. 2018-07-27 08:19:11 +08:00
Joffrey JAFFEUX
262beed1cf
FIX: fixes regression with category filtering (#6190) 2018-07-26 19:08:06 -04:00
Joffrey JAFFEUX
59684adc43
FIX: shows disk usage even if no backups taken (#6189) 2018-07-26 18:38:55 -04:00
Neil Lalonde
1708ff1808 UX: add a route /rules as an alias for /faq and /guidelines 2018-07-26 15:38:08 -04:00
Joffrey JAFFEUX
56ae826efb
UI: improves no data notice in reports (#6187) 2018-07-26 15:26:53 -04:00
Joffrey JAFFEUX
330cf78c83
FIX: don’t break browser history on dashboard visit (#6186) 2018-07-26 14:59:28 -04:00
Kris
8d67b20d37 z-index fix 2018-07-26 12:11:40 -04:00
David Taylor
88241f57a3
FEATURE: allow auth plugins to have a site setting for full screen login 2018-07-26 11:11:16 +01:00
David Taylor
63e15aa41a Add missing semicolon 2018-07-26 10:30:10 +01:00
Maja Komel
e8d82f48bc add maxlength attribute for 2FA input fields 2018-07-26 10:31:20 +02:00
Vinoth Kannan
af5b88f8e2 Rename approval web hook event type to queued post 2018-07-26 10:29:38 +05:30
Kris
67b6539d98 rounder topic-list badges in iOS 2018-07-25 23:58:23 -04:00
Kris
998b7fb87a Rounder topic-list badges on mobile 2018-07-25 22:30:30 -04:00
Guo Xiang Tan
f8b367cc9c Fix the build. 2018-07-26 10:17:51 +08:00
Kris
c5e7c60a37 Fixing profile avatar flair poisition on mobile 2018-07-25 22:00:56 -04:00
Kyle Zhao
1ed3a89ac9 UX: clear topic timer text when manually closing/opening (#6123) 
* UX: clear topic timer text when manually closing/opening

* added test for clearing topic timer status text
 2018-07-26 11:48:38 +10:00
Guo Xiang Tan
30242972d3 Add spec for 4bf3bf6786. 2018-07-26 09:16:14 +08:00
Nick Shearer
def2c977ce allow auth plugins to have a site setting for if they should be full screen vs popup window 2018-07-25 19:20:11 -05:00
Régis Hanol
aeaf6b5a7c SECURITY: force IM decoder based on file extension - part 3 2018-07-25 23:55:41 +02:00
Régis Hanol
f94aeaf6cf SECURITY: force IM decoder based on file extension - part 3 2018-07-25 23:55:06 +02:00
Régis Hanol
01714e40f4 SECURITY: force IM decoder based on file extension - part 2 2018-07-25 23:08:38 +02:00
Régis Hanol
800c57c6ab SECURITY: force IM decoder based on file extension - part 2 2018-07-25 23:08:02 +02:00
Régis Hanol
b04b7c366c SECURITY: force IM decoder based on file extension 2018-07-25 22:01:08 +02:00
Régis Hanol
4bf3bf6786 SECURITY: force IM decoder based on file extension 2018-07-25 22:00:04 +02:00
Kris
0e84024958
Updating style of theme options in wizard (#6177) 2018-07-25 15:32:14 -04:00
Kris
3fd2571abc Fix typo in color scheme 2018-07-25 15:12:01 -04:00
Joffrey JAFFEUX
ad95c24307
FEATURE: displays a notice if report has no data (#6178) 2018-07-25 14:28:41 -04:00
Vinoth Kannan
5059dad8f0 FEATURE: Webhook for post approval events 2018-07-25 23:43:19 +05:30
Joffrey JAFFEUX
6ee1ea96ef
fixes tests (#6176) 2018-07-25 14:02:21 -04:00
Joffrey JAFFEUX
01d1f850e9
FEATURE: uses category-chooser for report filtering (#6174) 2018-07-25 13:16:35 -04:00
David Taylor
6520697b5c FIX: Remove plugin.enabled? checks at initialization time (#6166) 
Checking `plugin.enabled?` while initializing plugins causes issues in two ways:
- An application restart is required for changes to take effect. A load-balanced multi-server environment could behave very weirdly if containers restart at different times.
- In a multisite environment, it takes the `enabled?` setting from the default site. Changes on that site affect all other sites in the cluster.

Instead, `plugin.enabled?` should be checked at runtime, in the context of a request. This commit removes `plugin.enabled?` from many `instance.rb` methods.

I have added a working `plugin.enabled?` implementation for methods that actually affect security/functionality:
- `post_custom_fields_whitelist`
- `whitelist_staff_user_custom_field`
- `add_permitted_post_create_param`
 2018-07-25 16:51:45 +01:00
Joffrey JAFFEUX
fa6b7f6b8c
DEV: adds Object.entries and Object.assign polyfills (#6173) 2018-07-25 11:45:29 -04:00
David Taylor
0d0d78841b
FIX: Remove plugin.enabled? checks at initialization time (#6166) 
Checking `plugin.enabled?` while initializing plugins causes issues in two ways:
  - An application restart is required for changes to take effect. A load-balanced multi-server environment could behave very weirdly if containers restart at different times.
  - In a multisite environment, it takes the `enabled?` setting from the default site. Changes on that site affect all other sites in the cluster.

Instead, `plugin.enabled?` should be checked at runtime, in the context of a request. This commit removes `plugin.enabled?` from many `instance.rb` methods.

I have added a working `plugin.enabled?` implementation for methods that actually affect security/functionality:
  - `post_custom_fields_whitelist`
  - `whitelist_staff_user_custom_field`
  - `add_permitted_post_create_param`
 2018-07-25 16:44:09 +01:00
Joffrey JAFFEUX
796639a797
FIX: makes disk_space computation more resilient (#6172) 2018-07-25 11:04:01 -04:00
David Taylor
fa399ce1c5 FEATURE: Add revoke and reconnect functionality for google logins 2018-07-25 16:03:14 +01:00
Joffrey JAFFEUX
578c8e861b
FIX: refreshes disk_space on backup create/destroy (#6169) 2018-07-25 08:26:30 -04:00
Régis Hanol
637850d867 REFACTOR: new 'show-avatar-select' app event to trigger the avatar selector modal 2018-07-25 12:38:15 +02:00
Gerhard Schlager
9989c8179d FIX: Translation for default (light) color scheme was missing 2018-07-25 11:28:14 +02:00
Dan Ungureanu
44a5c29d42 Clear old text and URL when showing up the "Insert Hyperink" modal. (#6138) 2018-07-25 17:12:49 +10:00
Dan Ungureanu
f540020d1d Add different trigger for the emoji popup of French users. (#6140) 2018-07-25 16:39:06 +10:00
Gerhard Schlager
1ac643d71c FIX: Email template for "Queued Posts Reminder" was not found 2018-07-24 17:26:52 +02:00
Régis Hanol
8ca25f5aed UX: open the change avatar modal when clicking the profile picture 2018-07-24 15:13:21 +02:00
Joffrey JAFFEUX
7a3c541077
UX: Preview multiple color schemes in wizard (#6151) 
It was a dropdown to provide choices of color schemes,
and only one scheme could be shown.
With this commit, multiple color scheme previews can be displayed on
one page at the same time, making admins choose color schemes more
easily.

Theme preview windows are shrinked.

Imported default color schemes.

Co-Authored-By: Misaka 0x4e21 <misaka4e21@gmail.com>
 2018-07-24 09:00:20 -04:00
Gerhard Schlager
c3b6811651 PERF: Split loading of posts to speed up user renames 2018-07-24 11:57:04 +02:00
Guo Xiang Tan
fa19d3a53c
Merge pull request #6108 from discourse/transaction-sidekiq-fix 
Fix notifications for topics moved between categories
 2018-07-24 17:44:03 +08:00
David Taylor
20a21b1240 Move into MiniSQLMultisiteConnection, and add test for rollback 2018-07-24 09:41:55 +01:00
Guo Xiang Tan
98f84d1a4e Update annotations. 2018-07-24 15:49:55 +08:00
Guo Xiang Tan
7a2bf8e368 Fix invalid query syntax when CategoryCustomField#value is blank. 2018-07-24 14:48:27 +08:00
Guo Xiang Tan
663d78414b
Merge pull request #6104 from tgxworld/split_up_reply_key_from_email_logs 
PERF: Move `EmailLog#reply_key` into new `post_reply_keys` table.
 2018-07-24 14:33:48 +08:00
Guo Xiang Tan
fad9c2b971 PERF: Move EmailLog#reply_key into new post_reply_keys table. 2018-07-24 13:51:53 +08:00
Guo Xiang Tan
5760873580 Fix linting. 2018-07-24 13:43:52 +08:00
Guo Xiang Tan
ae8b0a517f PERF: Split skipped email logs into a seperate table. 2018-07-24 13:14:37 +08:00
Guo Xiang Tan
9b84e78fdf Update annotations. 2018-07-24 11:14:19 +08:00
Sam
95720e3873 lint files 2018-07-24 10:57:16 +10:00
Kyle Zhao
c9d4288214 UX: auto fix order when reordering categories (#6149) 
* set correct position number when moving up/down

* UX: drop 'fix order' and auto re-order subcategory

- auto "fix position" on save
- place subcategories after parent category and maintain the relative
positions on save
 2018-07-24 10:25:40 +10:00
Neil Lalonde
f4b5eccad3 FIX: categories page crawler view had incorrect URLs 2018-07-23 14:54:41 -04:00
Joffrey JAFFEUX
568276fe40
FEATURE: allows tag editing on mobile (#6148) 2018-07-23 14:25:21 -04:00
Joffrey JAFFEUX
73d736c8c3
FIX: popup-menu instantly closing (#6147) 2018-07-23 14:19:36 -04:00
Joffrey JAFFEUX
78419f677d
FIX: multiple select-kit fixes on mobile 2018-07-23 12:19:40 -04:00
David Taylor
eda1462b3b
FEATURE: List, revoke and reconnect associated accounts. Phase 1 (#6099) 
Listing connections is supported for all built-in auth providers. Revoke and reconnect is currently only implemented for Facebook.
 2018-07-23 16:51:57 +01:00
Joffrey JAFFEUX
32062864d3
FIX: removes system from user to user report (#6144) 2018-07-23 10:33:12 -04:00
Régis Hanol
9b2d6053da UX: don't show the avatar section when overriden by SSO 2018-07-23 12:03:43 +02:00
David Taylor
d7b5a374c2 Fix indentation 2018-07-23 10:42:15 +01:00
Vinoth Kannan
84ab825e41
FEATURE: Webhook for user destroyed event (#6124) 2018-07-23 13:19:49 +05:30
Sam
caa669cf29 FIX: if exclude_category_ids is specified pass it through 
This allows us to optionally show all topics on latest even if stuff is
suppressed via a plugin
 2018-07-23 17:23:00 +10:00
Dan Ungureanu
ba73d91e3b FIX: Display tag related actions only if tagging is enabled. (#6136) 
The affected buttons are "Replace Tags" and "Append Tags".
 2018-07-23 12:35:08 +10:00
Vinoth Kannan
f8e9190617 FEATURE: Retry web hook when it is failed 2018-07-23 10:12:04 +08:00
Neil Lalonde
8e5e7c6b43 add links to Top Categories on user summary page 2018-07-22 22:00:41 -04:00
Kris
31a597797c Raising z-index of bulk select button 2018-07-22 21:40:50 -04:00
Sam
35bc72ef30 lint file 2018-07-23 10:58:24 +10:00
Dan Ungureanu
b14cd2f179 FEATURE: Make the login error message more informative if cookies are disabled 2018-07-23 10:50:41 +10:00
Blake Erickson
37b726982d Fix silence and unsilenced response bodies 
Both response bodies had a typo that included suspended_at, so I renamed
it to silenced_at.
 2018-07-22 16:08:36 -06:00
Joffrey JAFFEUX
06323f9c89
FIX: takes old dashboard out of caching job 2018-07-21 12:42:03 -04:00
Joffrey JAFFEUX
0972dd2552
FIX: takes dashboard-next out of caching job 2018-07-21 11:13:15 -04:00
Joffrey JAFFEUX
9ed4071713
fixes dashboard next spec (#6132) 2018-07-21 10:29:58 -04:00
Guo Xiang Tan
5c1bd38d84
Merge pull request #6131 from jjaffeux/lazy-load-reports 
FIX: lazy load more reports in dashboard
 2018-07-21 17:24:17 +08:00
Maja Komel
368d4e8eae FIX: notify staff about whispers in watched categories (#6128) 2018-07-21 11:20:21 +02:00
Simon Cossar
d705f859db Exclude System user from post_edits report (#6130) 2018-07-21 11:17:25 +02:00
Guo Xiang Tan
9afc4cf8c1 Revert "add links to Top Categories on user summary page" 
This reverts commit 1e37395517.
 2018-07-21 15:50:09 +08:00
Joffrey JAFFEUX
1d5096eb46 FIX: lazy load more reports in dashboard 2018-07-20 23:35:53 -04:00
Kris
c6fe6a8820 Improving mutli-post select styling 2018-07-20 16:37:43 -04:00
Joffrey JAFFEUX
5e521f8ce6 Revert "FIX: various select-kit corrections on mobile" 
This reverts commit 78a2324c89.
 2018-07-20 15:28:12 -04:00
Neil Lalonde
1e37395517 add links to Top Categories on user summary page 2018-07-20 15:27:03 -04:00
Joffrey JAFFEUX
78a2324c89
FIX: various select-kit corrections on mobile 2018-07-20 14:46:25 -04:00
Joffrey JAFFEUX
3fdc4f2df1
FIX: do not automatically infere date type (#6127) 2018-07-20 09:35:14 -04:00
Joffrey JAFFEUX
9d919406c4
FIX: improves trending-search and top-referred on mobile 2018-07-20 09:15:25 -04:00
Joffrey JAFFEUX
3741dd6b59
removes report logging (#6125) 2018-07-20 08:16:29 -04:00
Arpit Jalan
7d9c97d661 FEATURE: land on specified category page when creating topic via URL 2018-07-20 15:55:05 +05:30
Guo Xiang Tan
7cf6c2825e
Merge pull request #6106 from OsamaSayegh/watch-when-splitting 
FIX: topic owner should watch the new topic when moving posts to a new topic
 2018-07-20 15:18:59 +08:00
OsamaSayegh
69450750d1 shorter method name and better specs 2018-07-20 10:13:27 +03:00
Joffrey JAFFEUX
d75d1f0b51
FIX: improves moderation tab on mobile (#6122) 2018-07-19 23:59:52 -04:00
Joffrey JAFFEUX
4698cccbcf
FIX: improves moderation tab reports alignments 2018-07-19 22:01:48 -04:00
Joffrey JAFFEUX
711df31a9d
FIX: makes top dash titles clickable (#6120) 2018-07-19 19:30:26 -04:00
Joffrey JAFFEUX
64f0cf425b
FIX: removes uncessary reports loading (#6119) 2018-07-19 19:30:13 -04:00
Joffrey JAFFEUX
2bf971c09f
FIX: makes reports take full width (#6118) 2018-07-19 19:29:58 -04:00
Joffrey JAFFEUX
a0793387cf
FEATURE: differentiates pms in moderators activity report (#6117) 
Co-Authored-By: Simon Cossar <scossar@users.noreply.github.com>
 2018-07-19 19:29:42 -04:00
Régis Hanol
f83a687551 UX: skip the modal and refresh the app when selecting an avatar 2018-07-20 00:37:57 +02:00
Neil Lalonde
dbcf4e2474 FIX: exceptions raised when editing replies were not displaying their error messages 2018-07-19 18:14:08 -04:00
Joffrey JAFFEUX
8893ca6238
FIX: smaller sort buttons 2018-07-19 16:00:45 -04:00
Joffrey JAFFEUX
1a78e12f4e
FEATURE: part 2 of dashboard improvements 
- moderation tab
- sorting/pagination
- improved third party reports support
- trending charts
- better perf
- many fixes
- refactoring
- new reports

Co-Authored-By: Simon Cossar <scossar@users.noreply.github.com>
 2018-07-19 14:33:11 -04:00
Joffrey JAFFEUX
a2281fbb19
FEATURE: allows to jump to a date in a topic 2018-07-19 16:00:13 +02:00
Guo Xiang Tan
a0a520db26 Fix lint. 2018-07-19 17:55:40 +08:00
Simon Cossar
4bee7fb458 When the dir is set on a list, add padding to both sides (#6097) 2018-07-19 17:32:36 +08:00
OsamaSayegh
fa02df9985 FIX: don't suggest groups when inviting to a topic (#6105) 2018-07-19 17:02:34 +08:00
Guo Xiang Tan
4765507585 Remove code that is no longer required. 2018-07-19 16:56:53 +08:00
Sam
a755ff7b35 FIX: not checking for 0 correctly 
0.blank? == false
 2018-07-19 07:45:26 +10:00
Maja Komel
fa38891a98 FEATURE: show modal when user without permissions tries to delete their own topic (#6086) 2018-07-18 23:31:37 +02:00
David Taylor
5b4b632358 Correct typo 2018-07-18 22:27:55 +01:00
Maja Komel
af1d1db3da UX: use future date input instead of date picker on feature topic modal (#6096) 2018-07-18 23:27:12 +02:00
Maja Komel
a9ebad3f6c FIX: do not add a moderator post when post is flagged via direct message (#6100) 2018-07-18 23:18:14 +02:00
Régis Hanol
c1249d9e1d make linter happy 2018-07-18 23:07:17 +02:00
David Taylor
32db976156 FIX: Stop race condition when topic notification jobs are scheduled during a database transaction 
This was not picked up by tests because scheduled jobs are run immediately
and in the current thread (and therefore the current database transaction).

This particular case sometimes occurs inside multiple nested transactions,
so simply moving the offending line outside of the transaction is not enough.

Implemented TransactionHelper, which allows us to use `TransactionHelper.after_commit`
to define code to be run after the current transaction has been committed.
 2018-07-18 22:04:43 +01:00
Régis Hanol
af98ab9337 UX: use the pointer cursor when hovering over a selectable avatar 2018-07-18 22:54:35 +02:00
Régis Hanol
facef06d60 UX: reload the page when changing avatar 2018-07-18 22:50:50 +02:00
Neil Lalonde
afc94ac9e4 FEATURE: add a Top Categories section to the user summary page, showing the categories in which a user has the most activity 2018-07-18 16:39:16 -04:00
OsamaSayegh
547b571d84 FIX: topic owner should watch the new topic when moving posts to a new topic 2018-07-18 15:23:32 +03:00
Régis Hanol
f55ac892e4 make code prettier 🎀 2018-07-18 13:09:16 +02:00
Régis Hanol
6d6e026e3c FEATURE: selectable avatars 2018-07-18 12:57:43 +02:00
Sam
a24b9981c6 UX: adjust positioning of auto complete vertical 
On iPad portrait autocomplete would render off screen
 2018-07-18 16:41:31 +10:00
Guo Xiang Tan
487ef9773f Better logging when optimizing image fails. 2018-07-18 14:11:23 +08:00
Guo Xiang Tan
b068a8a771 Fix the build. 2018-07-18 14:03:27 +08:00
Guo Xiang Tan
be71f9ff82 REFACTOR: Don't load entire AR object just to get a column. 2018-07-18 13:53:57 +08:00
Arpit Jalan
7da22e395b FIX: do not show links with 0 click on topic map 2018-07-18 10:50:01 +05:30
OsamaSayegh
281538ae61 FIX: theme JS should only run when needed global objects exist (#6098) 2018-07-18 15:13:47 +10:00
Guo Xiang Tan
3874d40910 Prepare to drop EmailLog#topic_id. 2018-07-18 10:22:24 +08:00
Sam
a66d812b92 pick a better icon for auto bump 2018-07-18 11:15:01 +10:00
Sam
5adf5b527d FEATURE: support filter_auto_bump_topics event 
Use this event to filter the list of auto bumped topics.

EG:

  on(:filter_auto_bump_topics) do |_category, filters|
    filters.push(->(r) { r.where(<<~SQL)
        NOT EXISTS(
          SELECT 1 FROM topic_custom_fields
          WHERE topic_id = topics.id
          AND name = 'accepted_answer_post_id'
        )
      SQL
    })
  end
 2018-07-18 10:56:09 +10:00
Sam
02628883d2 FEATURE: adjust autobump system 
- We spread out bumping through the day, if you are bumping
 4 topics then a topic will be bumped every 6 hours

- We add a small, bumping action at the bottom of the post to
 denote a topic got bumped
 2018-07-18 10:17:33 +10:00
Robin Ward
bec53426c4 Remove pointless method 2018-07-17 12:34:20 -04:00
Philipp Rudloff
79b08b2679 Set result.target for update (matching _saveNew) (#6094) 
* Set result.target for update (matching _saveNew)

* Add tests for update result including a target property
 2018-07-17 11:56:32 -04:00
Guo Xiang Tan
3553375dd2 PERF: Store EmailLog#reply_key as uuid data type. 2018-07-17 17:05:42 +08:00
Guo Xiang Tan
1d74ccaaf8 Add compatibility for ImageMagick7. 2018-07-17 15:50:58 +08:00
Arpit Jalan
7c7509e1bd FEATURE: update TwitterApi for prettifying like/retweet count 2018-07-17 12:59:40 +05:30
Sam
9f1e8d4f58 FIX: inaccurate tracking of current topic 
Under some cases we would trigger the "you are replying on a different
topic" when in fact, your were not
 2018-07-17 17:24:23 +10:00
Guo Xiang Tan
fe230f29cd Update annotations. 2018-07-17 13:11:45 +08:00
Evg
b6fba9ecc6 Add plug-in (in search results) (#6090) 
* Add to plugin

Add the ability to use the plugin...

* Edit name
 2018-07-17 14:44:39 +10:00
Sam
818bc10107 FIX: count subcategories in breadcrumbs 2018-07-17 12:06:48 +10:00
Sam
292e8a3756 FIX: category list should set category on topic 2018-07-17 10:38:42 +10:00
Sam
91266cdabb correct auto bump topic logic 2018-07-17 09:33:33 +10:00
Kris
331296e851 Fix for JK highlighting, typo 2018-07-16 14:52:00 -04:00
Kris
35e8d489de Fixing JK highlighting for Edge 2018-07-16 14:51:05 -04:00
Kris
bd51cd52cd Hide edit category tabs with display: none; 2018-07-16 12:37:06 -04:00
Gerhard Schlager
d3e04daa95 Add Swahili language 2018-07-16 18:11:38 +02:00
Guo Xiang Tan
c0c263405a
PERF: Store EmailLog#bounce_key as uuid data type. (#6093) 
PERF: Store `EmailLog#bounce_key` as `uuid` data type.
 2018-07-16 20:05:54 +08:00
Vinoth Kannan
b7ebb0268f FIX: returns provider_not_enabled error even if enabled 2018-07-16 11:08:48 +01:00
Vinoth Kannan
f3868fd646 FIX: Create empty user_avatar row if not exist 2018-07-16 14:06:49 +05:30
Sam
ac0053f491 FEATURE: navigate to first post and auto bump category settings 
### navigate_to_first_post_after_read setting for categories

When enabled on categories logged on users will return to OP after
reading the entire category. (useful for documentation categories)

### num_auto_bump_daily

Set a number of topics that will automatically bump daily on a category.

- Every 15 minutes we will check if any category has this setting
- Categories with the setting are shuffled
- We exclude pinned, closed, category description and archived topics
- Maximum of 1 topic for the list of categories is bumped till limit reached per category
- We always try to bump oldest first
- Limit is elastic using a RateLimiter that ensures that we only bump N per day

Also some minor organisation on category settings

Froze strings on category.rb
 2018-07-16 18:10:35 +10:00
Sam
259d16a781 we already have another .invisible no need to have 2 2018-07-16 18:10:35 +10:00
Guo Xiang Tan
6761f8ecbf PERF: Add missing index on user_id for user_second_factors table. 2018-07-16 14:21:07 +08:00
Guo Xiang Tan
214dac05de Update annotations. 2018-07-16 14:19:07 +08:00
Rishabh
a6c589d882 FEATURE: Add custom S3 Endpoint and DigitalOcean Spaces/Minio support for Backups (#6045) 
- Add custom S3 Endpoints and DigitalOcean Spaces support
- Add Minio support using 'force_path_style' option and fix uploads to custom endpoint
 2018-07-16 14:44:55 +10:00
Leo McArdle
21ebb1cd54 FEATURE: Secondary emails support. 2018-07-16 11:09:49 +08:00
Guo Xiang Tan
50e59fb9bd Fix the build. 2018-07-16 10:12:19 +08:00
Jay Pfaffman
0ed2834c2d FEATURE: Add users:disable_2factor rake task 
https://meta.discourse.org/t/admin-locked-out-of-2fa/92156/2?u=pfaffman
 2018-07-16 09:56:55 +08:00
Jeff Wong
f3b17b92b7 Fix: delay panning until we can determine direction 2018-07-14 15:57:58 -07:00
Kris
e6d4a09b55 Image was too wide on invite acceptance form 2018-07-13 16:13:13 -04:00
Kris
1ad358fa0a improving screened email and url section of admin on mobile 2018-07-13 15:25:04 -04:00
Neil Lalonde
7331b0ac07 prettier is offended 2018-07-13 14:57:55 -04:00
Neil Lalonde
8ceed642cb FIX: wrong url for default logos in header on subfolder installs 2018-07-13 14:21:15 -04:00
Vinoth Kannan
06deffc9da FIX: returns provider_not_enabled error even if enabled 2018-07-13 22:49:30 +05:30
Guo Xiang Tan
b459a589ab FIX: jumpToPost no working on megatopics. 2018-07-13 16:16:39 +08:00
Guo Xiang Tan
9647a0a4bc Remove unnecessary complex method. 2018-07-13 15:34:28 +08:00
Guo Xiang Tan
711371e8c8 FIX: Select+below will ask server for post ids on megatopics. 2018-07-13 15:10:39 +08:00
Kris
c2cfb6ebae mobile admin cleanup 2018-07-13 01:43:40 -04:00
Guo Xiang Tan
409a30ce1c FIX: Selecting & moving posts not working on megatopics. 2018-07-13 11:16:43 +08:00
Guo Xiang Tan
18e281606a UX: Clicking admin menu does not hide select posts box. 2018-07-13 10:56:14 +08:00
Kyle Zhao
2901691e87 FEATURE: per-category approval settings (#5778) 
- disallow moving topics to a category that requires topic approval
 2018-07-13 12:51:08 +10:00
Arpit Jalan
db67c87916 fix purge unactivated users subquery 2018-07-13 07:58:58 +05:30
Kris
01fe42d5e2 prettier fix 2018-07-12 16:41:44 -04:00
Kris
b79fedd540 Streamlining some breakpoint mixins 2018-07-12 16:39:16 -04:00
Maja Komel
a611db666b
Merge pull request #6088 from majakomel/edit-category-fix 
FIX: hidden tooltip was preventing clicks on category settings input field
 2018-07-12 21:42:11 +02:00
Maja Komel
967736caf2 FIX: hidden tooltip was preventing clicks on category settings input field 2018-07-12 18:30:32 +02:00
Sam
6bc0f97668 FEATURE: add data-username on user-info blocks 
This makes it easier to target in CSS
 2018-07-12 18:16:05 +10:00
Sam
1f0bbca87e FIX: on initial load category subcategories were not mapped correctly 2018-07-12 17:59:56 +10:00
Arpit Jalan
ea0498ae93 make prettier happy 2018-07-12 12:42:11 +05:30
Sam
67bc972d74 UX: make sure autocomplete does not render off screen 2018-07-12 17:07:25 +10:00
Arpit Jalan
bd760e98af FIX: display error message when upload fails in wizard 2018-07-12 12:08:09 +05:30
Sam
87a5cb982c correct action typo 2018-07-12 16:24:28 +10:00
Guo Xiang Tan
7c8cd9cfdd Fix the build. 2018-07-12 14:11:42 +08:00
Sam
29eb9dda59 DEV: add deprecation for currentThemeKey 
This ensures that theme components will not explode when attempting to access this
 2018-07-12 15:36:38 +10:00
Kris
a201103127 removing some old styles 2018-07-12 00:53:24 -04:00
Guo Xiang Tan
258e9e35ca PERF: Make mega topics work without a stream. 
There are tradeoffs that we took here. For the complete
story see
https://meta.discourse.org/t/performance-improvements-on-long-topics/30187/27?u=tgxworld.
 2018-07-12 12:46:12 +08:00
Misaka 0x4e21
de4d4747c4 UX: Focus on new topic link that appears on the page via keyboard. (#6081) 
- Add an <a> tag to handle keypress events on new topic indicator.
 2018-07-12 14:36:19 +10:00
OsamaSayegh
decf1f27cf FEATURE: Groundwork for user-selectable theme components 
* Phase 0 for user-selectable theme components

- Drops `key` column from the `themes` table
- Drops `theme_key` column from the `user_options` table
- Adds `theme_ids` (array of ints default []) column to the `user_options` table and migrates data from `theme_key` to the new column.
- Removes the `default_theme_key` site setting and adds `default_theme_id` instead.
- Replaces `theme_key` cookie with a new one called `theme_ids`
- no longer need Theme.settings_for_client
 2018-07-12 14:18:21 +10:00
OsamaSayegh
f13a7226db FIX: display tables in posts history diff (#6032) 2018-07-12 14:13:52 +10:00
Joffrey JAFFEUX
1ed4f0ee8a
FIX: datepicker will now default to monday as first day 
This will be regardless of the user locale. Many users use english forums even if not from the US and would end up having sunday as the first day of the week in the calendar. This commit follows the international standard.
 2018-07-11 23:49:52 +02:00