dependabot[bot]
c5e61aef48
Build(deps): Bump net-imap from 0.5.0 to 0.5.1 ( #29681 )
...
Bumps [net-imap](https://github.com/ruby/net-imap ) from 0.5.0 to 0.5.1.
- [Release notes](https://github.com/ruby/net-imap/releases )
- [Commits](https://github.com/ruby/net-imap/compare/v0.5.0...v0.5.1 )
---
updated-dependencies:
- dependency-name: net-imap
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-11-11 12:09:26 +01:00
Jarek Radosz
2272b1340b
DEV: Use qunit-dom instead of raw href/title comparisons ( #29678 )
2024-11-11 11:44:54 +01:00
Jarek Radosz
429b6a4e4e
DEV: Use qunit-dom instead of classList/activeElement ( #29676 )
2024-11-11 11:44:42 +01:00
Joffrey JAFFEUX
c4de8565ec
FIX: flakey due to 0 width/height images ( #29700 )
...
https://github.com/mainmatter/qunit-dom/blob/master/API.md#isvisible will return true if offsetWidth or offsetHeight are zero which could happen in this case as the test could run before the image has loaded. By forcing a minimum height in the test we ensure it will be consistent.
2024-11-11 17:23:19 +09:00
Ted Johansson
189d98f3ca
DEV: Convert admin emojis UI to new layout ( #29615 )
...
This PR converts the custom emoji UI in the admin pages to follow the new admin UI guidelines.
2024-11-11 15:04:15 +08:00
Krzysztof Kotlarek
4ad83a98a1
FIX: migrations must be finished to reset flags cache ( #29693 )
...
Bug introduced here: https://github.com/discourse/discourse/pull/29609
It was checking if `flags` table existed before resetting the cache. However, `require_message` flag was added in further migration:
https://github.com/discourse/discourse/blob/main/db/migrate/20240714231226_duplicate_flags_custom_type_to_require_message.rb#L5
When the admin tried to update Discourse which already has `flags` table but no `require_message` column, it was causing the error.
Therefore, we should ensure that all migrations are finished before resetting flags cache.
Meta: https://meta.discourse.org/t/update-failing-column-require-message-does-not-exist/335030
2024-11-11 12:14:14 +11:00
dependabot[bot]
8c52345b55
Build(deps-dev): Bump qunit-dom from 3.2.1 to 3.3.0 ( #29690 )
2024-11-11 00:04:38 +01:00
Jarek Radosz
78ed0bb711
DEV: Use selectors instead of query() where possible ( #29677 )
2024-11-10 13:53:12 +01:00
Jarek Radosz
16a9663557
DEV: Use qunit-dom's isDisabled/isEnabled ( #29675 )
2024-11-10 02:24:58 +01:00
Jarek Radosz
d67a6002eb
DEV: Replace count with qunit-dom ( #29674 )
2024-11-10 02:06:03 +01:00
Jarek Radosz
f9e58938ce
DEV: Update visible/invisible uses to qunit-dom ( #29672 )
2024-11-10 01:41:50 +01:00
Jarek Radosz
de6d575d40
DEV: Convert all uses of exists to qunit-dom ( #29667 )
2024-11-10 01:30:33 +01:00
Joffrey JAFFEUX
b24c8a41ac
FIX: remove header-icons from styleguide ( #29670 )
...
Recent changes in header makes it complicated to show multiple standalone headers with different state.
2024-11-09 21:58:48 +09:00
Joffrey JAFFEUX
0669830a5b
FIX: broken post in styleguide ( #29669 )
...
The base `transformedPost` in dummy-data was missing the topic object.
2024-11-09 21:46:56 +09:00
Penar Musaraj
20effebd51
DEV: Fix updating header background in webview ( #29668 )
...
This regressed in https://github.com/discourse/discourse/pull/28912 for media query changes.
2024-11-08 22:18:09 -05:00
Penar Musaraj
6912a1e3ca
UX: Change the authorize button color to primary ( #29666 )
...
Primary is a more appropriate color here than "danger". Authorizing is
important, but we usually use "danger" for destructive actions and
nothing is being destroyed here.
2024-11-08 17:33:50 -05:00
Jarek Radosz
c1916f7984
DEV: Convert assert.true(exists()) to qunit-dom ( #29638 )
2024-11-08 20:27:32 +01:00
David Taylor
3a23ff98bc
DEV: Fix passing translatedTitle as argument to flat-button ( #29663 )
...
Overriding computed properties with arguments is no longer supported by Ember, so we need to rename this computed property and add fallback logic manually.
This fixes the styleguide 'buttons' page. Ref https://meta.discourse.org/t/styleguide-bugs/335211?u=david
2024-11-08 18:46:05 +00:00
David Taylor
698571e24b
DEV: Add --ignore-workspace immediately after 'pnpm' in arguments ( #29662 )
...
Adding it to the end means it may get passed to some other tool (e.g. `pnpm eslint` would end up as `pnpm eslint --ignore-workspace`, but we want `pnpm --ignore-workspace eslint`)
2024-11-08 17:54:22 +00:00
Angus McLeod
cb4b8146a3
Add dedicated user_api_key_clients table to allow for 1:many use cases ( #28119 )
2024-11-08 12:05:03 -05:00
David Battersby
534e8c1628
UX: update chat channel sorting to include unread threads ( #29617 )
...
Adds channels with unread threads (watching/tracking) to the sorting logic for both public and direct message channels.
Previously channels with unread threads could easily be missed as we didn't bump them to the top when new thread replies were created.
We are also adding a blue unread badge next to DM channels when there is an unread thread, as previously they weren't appearing as unread within the DMs tab (they only showed within the My Threads section).
2024-11-08 12:31:03 +04:00
Ted Johansson
f573fd8f5e
FEATURE: Add more bulk dismiss buttons with confirmation ( #29331 )
...
When performing bulk dismissal in Unread and New views, the dismiss button stays at the top of the UI. Because of this we want to provide the dismiss action also in the "sticky" menu that's always in view, even when scrolling a long list of topics.
2024-11-08 15:59:12 +08:00
Joffrey JAFFEUX
467ecbabf5
FIX: supports escape sequence in chat ( #29659 )
...
Writing `\*test\*` will now correctly cook `*test*`, and not `<em>test</em>`.
2024-11-08 15:28:50 +09:00
Joffrey JAFFEUX
032b1f871b
DEV: cook grid bbcode in chat ( #29658 )
...
This change will only prevent a cooked message with [grid] to show [grid] instead the content will be wrapped in `div class="d-image-grid"`. This is only enabled on messages made by bot, as regular users could use grid but have no reason to use it ATM. It will also not apply the decoration which shouldn't change the behavior more than just remove grid markup from the message
2024-11-08 14:43:28 +09:00
Alan Guo Xiang Tan
af642d0d69
Revert "FEATURE: Mark bad uploads with :invalid_url ( #29640 )" ( #29657 )
...
This reverts commit 5a00a041f1
2024-11-08 13:04:52 +08:00
Osama Sayegh
4bc030f76f
FIX: Add back the option to create invite without emailing ( #29641 )
...
Follow-up to a5497b74be
2024-11-08 07:59:24 +03:00
Natalie Tay
6c36af9f62
DEV: Add verbose logging for google oauth ( #29459 )
Tests / core frontend (${{ matrix.browser }}) (Chrome) (push) Has been cancelled
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (system, plugins) (push) Has been cancelled
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (system, themes) (push) Has been cancelled
Licenses / run (push) Has been cancelled
Linting / run (push) Has been cancelled
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (annotations, core) (push) Has been cancelled
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (backend, core) (push) Has been cancelled
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (backend, plugins) (push) Has been cancelled
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (frontend, plugins) (push) Has been cancelled
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (frontend, themes) (push) Has been cancelled
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (system, chat) (push) Has been cancelled
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (system, core) (push) Has been cancelled
Tests / core frontend (${{ matrix.browser }}) (Firefox ESR) (push) Has been cancelled
Tests / core frontend (${{ matrix.browser }}) (Firefox Evergreen) (push) Has been cancelled
2024-11-08 11:03:17 +08:00
Joffrey JAFFEUX
1d9f064d83
FIX: correctly account for composer height in PWA ( #29656 )
2024-11-08 11:16:15 +09:00
Martin Brennan
97cf069a06
FIX: S3 custom endpoint incompatible with dualstack ( #29654 )
...
Followup 0568d36133
2024-11-08 11:12:49 +10:00
Kris
64291fedf8
UX: lower min_post_count to show bottom topic map ( #29649 )
2024-11-07 20:10:18 -05:00
Joffrey JAFFEUX
79254c59f9
FIX: correctly render unicode in channel page title ( #29653 )
...
Before this fix we would render the emoji as text, eg: `🐱 `
2024-11-08 09:41:14 +09:00
Keegan George
5a23a74bbc
DEV: Show confirmation dialog when admins disable 2FA ( #29652 )
...
This PR ensures that admins are shown a confirmation dialog when clicking to disable 2FA for a user. The 2FA button is right below the "Grant Badge" button and as such it can easily be clicked accidentally. It's also good practice to ask for confirmation before removing important functionality.
2024-11-07 16:39:42 -08:00
Joffrey JAFFEUX
fc5c0270f7
FIX: ensures thread panel closes on escape ( #29651 )
...
`chatThreadPane.isOpened` was returning `false` when it should return `true` due to an incorrect matching on the route.
Note that visiting a thread will focus the composer and the first escape will blur the input, only the second will close the panel.
2024-11-08 09:19:24 +09:00
Bianca Nenciu
5a00a041f1
FEATURE: Mark bad uploads with :invalid_url ( #29640 )
...
A "bad upload" in this context is a upload with a mismatched URL. This can happen when changing the S3 bucket used for uploads and the upload records in the database have not been remapped correctly.
2024-11-08 08:05:14 +08:00
dependabot[bot]
81e171070d
Build(deps): Bump excon from 1.1.1 to 1.2.0 ( #29646 )
...
Bumps [excon](https://github.com/excon/excon ) from 1.1.1 to 1.2.0.
- [Changelog](https://github.com/excon/excon/blob/master/changelog.txt )
- [Commits](https://github.com/excon/excon/compare/v1.1.1...v1.2.0 )
---
updated-dependencies:
- dependency-name: excon
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-11-08 07:45:25 +08:00
dependabot[bot]
4f3423ab35
Build(deps): Bump net-http from 0.4.1 to 0.5.0 ( #29647 )
...
Bumps [net-http](https://github.com/ruby/net-http ) from 0.4.1 to 0.5.0.
- [Release notes](https://github.com/ruby/net-http/releases )
- [Commits](https://github.com/ruby/net-http/compare/v0.4.1...v0.5.0 )
---
updated-dependencies:
- dependency-name: net-http
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-11-08 00:14:56 +01:00
dependabot[bot]
5f44839928
Build(deps): Bump uri from 0.13.1 to 1.0.0 ( #29645 )
...
Bumps [uri](https://github.com/ruby/uri ) from 0.13.1 to 1.0.0.
- [Release notes](https://github.com/ruby/uri/releases )
- [Commits](https://github.com/ruby/uri/compare/v0.13.1...v1.0.0 )
---
updated-dependencies:
- dependency-name: uri
dependency-type: indirect
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-11-08 00:14:28 +01:00
dependabot[bot]
dd82da8939
Build(deps): Bump psych from 5.1.2 to 5.2.0 ( #29642 )
...
Bumps [psych](https://github.com/ruby/psych ) from 5.1.2 to 5.2.0.
- [Release notes](https://github.com/ruby/psych/releases )
- [Commits](https://github.com/ruby/psych/compare/v5.1.2...v5.2.0 )
---
updated-dependencies:
- dependency-name: psych
dependency-type: indirect
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-11-08 00:12:43 +01:00
dependabot[bot]
353f6cdf09
Build(deps-dev): Bump rubocop-ast from 1.34.0 to 1.34.1 ( #29643 )
...
Bumps [rubocop-ast](https://github.com/rubocop/rubocop-ast ) from 1.34.0 to 1.34.1.
- [Release notes](https://github.com/rubocop/rubocop-ast/releases )
- [Changelog](https://github.com/rubocop/rubocop-ast/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop/rubocop-ast/compare/v1.34.0...v1.34.1 )
---
updated-dependencies:
- dependency-name: rubocop-ast
dependency-type: indirect
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-11-08 00:11:30 +01:00
dependabot[bot]
322e2a218d
Build(deps-dev): Bump puppeteer-core from 23.7.0 to 23.7.1 ( #29648 )
...
Bumps [puppeteer-core](https://github.com/puppeteer/puppeteer ) from 23.7.0 to 23.7.1.
- [Release notes](https://github.com/puppeteer/puppeteer/releases )
- [Changelog](https://github.com/puppeteer/puppeteer/blob/main/release-please-config.json )
- [Commits](https://github.com/puppeteer/puppeteer/compare/puppeteer-core-v23.7.0...puppeteer-core-v23.7.1 )
---
updated-dependencies:
- dependency-name: puppeteer-core
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-11-08 00:11:11 +01:00
dependabot[bot]
94cf3bafc3
Build(deps): Bump stringio from 3.1.1 to 3.1.2 ( #29644 )
...
Bumps [stringio](https://github.com/ruby/stringio ) from 3.1.1 to 3.1.2.
- [Release notes](https://github.com/ruby/stringio/releases )
- [Changelog](https://github.com/ruby/stringio/blob/master/NEWS.md )
- [Commits](https://github.com/ruby/stringio/compare/v3.1.1...v3.1.2 )
---
updated-dependencies:
- dependency-name: stringio
dependency-type: indirect
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-11-08 00:10:28 +01:00
Renato Atilio
7568e732cc
FIX: resume editing when through /new-message ( #29637 )
...
"Resume editing" would do nothing when going through the `/new-message` flow.
This seems to be broken since [this commit](b0f6d074be
2024-11-07 17:39:58 -03:00
Joffrey JAFFEUX
4840060568
DEV: fix flakey by duplicating constant ( #29636 )
...
Tests / core frontend (${{ matrix.browser }}) (Firefox ESR) (push) Waiting to run
Tests / core frontend (${{ matrix.browser }}) (Firefox Evergreen) (push) Waiting to run
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (annotations, core) (push) Waiting to run
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (backend, core) (push) Waiting to run
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (backend, plugins) (push) Waiting to run
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (frontend, plugins) (push) Waiting to run
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (frontend, themes) (push) Waiting to run
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (system, chat) (push) Waiting to run
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (system, core) (push) Waiting to run
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (system, plugins) (push) Waiting to run
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (system, themes) (push) Waiting to run
Licenses / run (push) Waiting to run
Linting / run (push) Waiting to run
Tests / core frontend (${{ matrix.browser }}) (Chrome) (push) Waiting to run
This is because rules is pointing to the same array MARKDOWN_IT_RULES, which is modified directly. Modifying rules with << changes the original MARKDOWN_IT_RULES array, so every call to something works with the altered array state from previous calls.
2024-11-07 23:51:17 +09:00
Joffrey JAFFEUX
5010fced92
DEV: only supports headings in messages for bots ( #29585 )
...
The markdown it rule "heading" will only be used when the message is done by a bot, which means an id < 0.
This commit also adds a is-bot css class on messages made by a bot, for finer control.
---------
Co-authored-by: Martin Brennan <mjrbrennan@gmail.com>
2024-11-07 22:27:35 +09:00
dependabot[bot]
193d25df00
Build(deps): Bump webrick from 1.8.2 to 1.9.0
...
Licenses / run (push) Waiting to run
Linting / run (push) Waiting to run
Tests / core frontend (${{ matrix.browser }}) (Chrome) (push) Waiting to run
Tests / core frontend (${{ matrix.browser }}) (Firefox ESR) (push) Waiting to run
Tests / core frontend (${{ matrix.browser }}) (Firefox Evergreen) (push) Waiting to run
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (annotations, core) (push) Waiting to run
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (backend, core) (push) Waiting to run
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (backend, plugins) (push) Waiting to run
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (frontend, plugins) (push) Waiting to run
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (frontend, themes) (push) Waiting to run
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (system, chat) (push) Waiting to run
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (system, core) (push) Waiting to run
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (system, plugins) (push) Waiting to run
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (system, themes) (push) Waiting to run
Bumps [webrick](https://github.com/ruby/webrick ) from 1.8.2 to 1.9.0.
- [Release notes](https://github.com/ruby/webrick/releases )
- [Commits](https://github.com/ruby/webrick/compare/v1.8.2...v1.9.0 )
---
updated-dependencies:
- dependency-name: webrick
dependency-type: indirect
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
2024-11-07 10:51:54 +01:00
chapoi
75ee73f969
UX: remove icons indicating time in userstatus, bookmarks, topic timer ( #29635 )
2024-11-07 06:54:40 +01:00
Joffrey JAFFEUX
3d1571a852
UX: do not hide topic composer in mobile chat ( #29633 )
2024-11-07 14:49:59 +09:00
Ella E.
b4f7a1b761
UX: Apply admin table classes for consistent mobile styling on the API keys page ( #29630 )
...
Licenses / run (push) Waiting to run
Linting / run (push) Waiting to run
Tests / core frontend (${{ matrix.browser }}) (Chrome) (push) Waiting to run
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (annotations, core) (push) Waiting to run
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (backend, core) (push) Waiting to run
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (backend, plugins) (push) Waiting to run
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (frontend, plugins) (push) Waiting to run
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (frontend, themes) (push) Waiting to run
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (system, chat) (push) Waiting to run
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (system, core) (push) Waiting to run
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (system, plugins) (push) Waiting to run
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (system, themes) (push) Waiting to run
Tests / core frontend (${{ matrix.browser }}) (Firefox ESR) (push) Waiting to run
Tests / core frontend (${{ matrix.browser }}) (Firefox Evergreen) (push) Waiting to run
* UX: Apply admin table classes for consistent mobile styling on the API keys page
* apply prettier
2024-11-06 18:38:25 -07:00
Martin Brennan
0568d36133
FIX: Use dualstack S3 endpoint for direct uploads ( #29611 )
...
When we added direct S3 uploads to Discourse, which use
presigned URLs, we never took into account the dualstack
endpoints for IPv6 on S3.
This commit fixes the issue by using the dualstack endpoints
for presigned URLs and requests, which are used in the
get-presigned-put and batch-presign-urls endpoints used when
directly uploading to S3.
It also makes regular S3 requests for `put` and so on use
dualstack URLs. It doesn't seem like there is a downside to
doing this, but a bunch of specs needed to be updated to reflect this.
2024-11-07 11:06:39 +10:00
dependabot[bot]
cc01555fce
Build(deps-dev): Bump @embroider/compat in the embroider group ( #29626 )
...
Bumps the embroider group with 1 update: [@embroider/compat](https://github.com/embroider-build/embroider/tree/HEAD/packages/compat ).
Updates `@embroider/compat` from 3.6.5 to 3.7.0
- [Release notes](https://github.com/embroider-build/embroider/releases )
- [Changelog](https://github.com/embroider-build/embroider/blob/main/CHANGELOG.md )
- [Commits](https://github.com/embroider-build/embroider/commits/HEAD/packages/compat )
---
updated-dependencies:
- dependency-name: "@embroider/compat"
dependency-type: direct:development
update-type: version-update:semver-minor
dependency-group: embroider
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-11-07 00:38:09 +01:00
