Daniel Waterworth
50911b2579
add tests
2024-01-08 08:02:18 -07:00
Daniel Waterworth
4494d62531
SECURITY: Run custom field validations with save_custom_fields
2024-01-08 08:02:16 -07:00
Daniel Waterworth
d7a09fb08d
DEV: Add true_fields method for CustomFields ( #24876 )
...
This is useful for plugins that might otherwise rely on the
CUSTOM_FIELD_TRUE constant.
2023-12-14 11:06:21 -06:00
Daniel Waterworth
434ae5bbe7
FIX: Allow setting an array custom field to a singleton value ( #24636 )
...
Also, validation happens per item in an array field.
2023-11-29 14:18:47 -06:00
Daniel Waterworth
6aa69bdaea
DEV: Allow setting different custom field length limits by key ( #24505 )
2023-11-22 12:00:42 -06:00
David Taylor
cb932d6ee1
DEV: Apply syntax_tree formatting to spec/*
2023-01-09 11:49:28 +00:00
Loïc Guitaut
3eaac56797
DEV: Use proper wording for contexts in specs
2022-08-04 11:05:02 +02:00
Phil Pirozhkov
493d437e79
Add RSpec 4 compatibility ( #17652 )
...
* Remove outdated option
04078317bahttps://github.com/rspec/rspec-core/pull/2803
* Use the non-globally exposed RSpec syntax, cont
https://github.com/rspec/rspec-core/pull/2803
* Comply to strict predicate matchers
See:
- https://github.com/rspec/rspec-expectations/pull/1195
- https://github.com/rspec/rspec-expectations/pull/1196
- https://github.com/rspec/rspec-expectations/pull/1277
2022-07-28 10:27:38 +08:00
David Taylor
922fbe82da
DEV: Ensure custom_fields_clean? returns false when values change ( #16552 )
...
We were calling `dup` on the hash and using that to check for changes. However, we were not duplicating the values, so changes to arrays or nested hashes would not be detected.
2022-04-25 17:19:39 +01:00
David Taylor
c9dab6fd08
DEV: Automatically require 'rails_helper' in all specs ( #16077 )
...
It's very easy to forget to add `require 'rails_helper'` at the top of every core/plugin spec file, and omissions can cause some very confusing/sporadic errors.
By setting this flag in `.rspec`, we can remove the need for `require 'rails_helper'` entirely.
2022-03-01 17:50:50 +00:00
Jarek Radosz
45cc16098d
DEV: Move spec/components to spec/lib ( #15987 )
...
Lib specs were inexplicably split into two directories (`lib` and `components`)
This moves them all into `lib`.
2022-02-18 19:41:54 +01:00
