github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2024-12-15 12:33:45 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity
31,827 Commits 214 Branches 500 Tags 960 MiB
bbb4b6ccef
Commit Graph

1657 Commits

Author SHA1 Message Date
Joffrey JAFFEUX
1071aa21ab
FIX: slightly safer rounding 2018-06-07 10:59:17 +02:00
Joffrey JAFFEUX
ab089cd68b
FIX: makes format number round the value before using parseInt 2018-06-07 10:44:21 +02:00
Guo Xiang Tan
bc7d9c61e6 Revert smoke test accidentally default to non headless mode. 2018-06-05 19:21:46 +08:00
Guo Xiang Tan
a276ffc7b3 Run smoke test without sandbox for now. 2018-06-05 19:08:36 +08:00
Guo Xiang Tan
478c86e0a4 DEV: Update preview step to be more reliable. 2018-06-05 16:58:15 +08:00
Guo Xiang Tan
c27863aad2 DEV: Better output when assertion fails in smoke test. 2018-06-05 10:54:56 +08:00
Joffrey JAFFEUX
43b1768987
UX: ceil dahsboard values 2018-05-30 16:32:43 +02:00
Guo Xiang Tan
db4af262dc DEV: Create smoke test screenshot directory in rake task. 2018-05-30 16:20:18 +08:00
Guo Xiang Tan
fe5a48997c DEV: Store smoke tests failure image in a dedicated tmp folder. 2018-05-30 15:59:07 +08:00
Guo Xiang Tan
30279a4843 DEV: Allow smoke test failure screenshot path to be configured. 2018-05-30 15:42:46 +08:00
Joffrey JAFFEUX
82e5727287
UX: -2/+2% change in stats should be no-change in dashboard 2018-05-28 10:55:42 +02:00
Guo Xiang Tan
9788ea9cb7 DEV: Write into Rails's tmp instead of system tmp for somke test screenshot. 2018-05-28 16:14:22 +08:00
Guo Xiang Tan
9d6d161628 DEV: Take screenshot when smoke test fails. 2018-05-28 14:19:43 +08:00
Guo Xiang Tan
0b55416742 UX: Don't display all groups option if group directory is disabled.a 
https://meta.discourse.org/t/all-groups-option-leads-to-access-denied-page/88464
 2018-05-28 11:32:55 +08:00
Guo Xiang Tan
857a4e0006 FIX: Viewport in smoke test configured incorrectly. 2018-05-28 10:58:36 +08:00
Joffrey JAFFEUX
1be76d066c
FIX: forces boolean when content is only "true" && "false" 2018-05-24 23:41:39 +02:00
Sam
70179290f3 clean up callbacks during acceptance tests 2018-05-24 15:28:54 +10:00
Sam
4194886b62 correct failing test 2018-05-24 13:02:20 +10:00
Joffrey JAFFEUX
db91d71bf1
fix category chooser spec 2018-05-23 21:07:39 +02:00
Joffrey JAFFEUX
ae004d8b2b
attempts of making composer actions test more resilient 2018-05-23 19:57:12 +02:00
Joffrey JAFFEUX
7232a6e5a9
FIX: do not show composer actions if irrelevant 2018-05-23 18:25:58 +02:00
Joffrey JAFFEUX
d2efd338e6
rewrites all composer actions tests using await 2018-05-23 15:52:15 +02:00
Joffrey JAFFEUX
dd76ba90b3
FIX: bbcode regex was greedy and preventing quotes 2018-05-23 11:55:02 +02:00
Sam
930ebb5684 skip failing test 2018-05-23 13:26:42 +10:00
Sam
41d37fd498 improve erratic test 2018-05-23 10:16:52 +10:00
Sam
8e9531657a skip erratic test 2018-05-23 08:28:00 +10:00
Joffrey JAFFEUX
a0c5b48558
fix failing spec 2018-05-22 10:50:54 +02:00
Sam
9e2131ace8 improve erratic test 2018-05-22 13:58:12 +10:00
Sam
99088f4d77 skip slow erratic test 2018-05-22 13:03:26 +10:00
Jeff Atwood
4329b484e8 minor copyedit on dashboard chart title 2018-05-18 16:04:33 -07:00
Joffrey JAFFEUX
af548c23c4
new dashboard quality pass (code, tests and UI) 2018-05-17 22:44:33 +02:00
Guo Xiang Tan
3f8e3a6f73 Don't intercept requests in smoke tests. 2018-05-17 16:56:39 +08:00
Sam
17a7bb8e23 use async test 2018-05-17 17:18:22 +10:00
Sam
441a52ad17 DEV: add more information about failed smoke test 
log the http status code and path that failed
 2018-05-17 16:43:00 +10:00
Régis Hanol
674318e127 UX: don't show 'auto delete' option for TL4 2018-05-17 00:42:48 +02:00
Régis Hanol
938934f5e9 FIX: keep '<kbd>' formatting when quoting posts 2018-05-16 17:40:45 +02:00
Joffrey JAFFEUX
9554d9c56a
UX: tooltips and improvements to new dashboard 
- tooltips
- revert chart title UI
- reduce period chooser font-size
- localize dates of data points
- fix a bug where multiple reports were loaded at the same time
- fix a bug where % was not showing anymore
- remove spacing at the top
- remove loadingTitle feature (Loading...%report name%) incompatible with new hijack design
 2018-05-16 16:45:21 +02:00
Joe Buhlig
3cd4c82c49 Allow parameters for group and username filters on directory (#5815) 2018-05-16 16:20:17 +02:00
Sam
f08ff84c5c missing a fixture for acceptance test 2018-05-15 15:34:40 +10:00
Joffrey JAFFEUX
e474351ae4
inactive users report is not used anymore 2018-05-14 21:31:14 +02:00
Régis Hanol
b004503c62 fix the build 2018-05-14 20:07:00 +02:00
Sam
e1d7f3bb94 correct fixture 2018-05-14 15:46:58 +10:00
Sam
a6aa986d3b correct spec 2018-05-14 15:41:19 +10:00
Régis Hanol
81f4da7dd2 FIX: remove unneeded escape when building a Quote 2018-05-12 01:16:05 +02:00
Sam
8a783412b7 UX: improvements to new dashboard 
- remove inactive user report and replace with posts
- clean up internals so grouping by week happens on client
- when switching periods old report was not destroyed leading to bugs
- calculate trend based on previous interval ... not previous 30 days
- show percentages for mau/dau
- be more careful about utc date usage
- show uniqu and click through rate on search panel
- publish key of report with report so we only load the correct one
- subscribe earlier in channel in case of concurrency issues
 2018-05-11 13:30:32 +10:00
Régis Hanol
deaf3682e9 FIX: clicking a group mention on mobile was 404ing 
(cc @featheredtoast)
 2018-05-09 17:27:59 +02:00
Régis Hanol
3483c7bc58 FIX: supports user/group mentions and category hashtags when quoting posts 2018-05-09 12:42:12 +02:00
Guo Xiang Tan
32147d4ff9 FIX: Search term scoped to topic should be highlighted in widget dom era. 
https://meta.discourse.org/t/highlight-the-search-results/10322/4?u=tgxworld
 2018-05-07 15:17:34 +08:00
Neil Lalonde
3a145b7551 fix group-test.js 2018-05-03 16:00:56 -04:00
Joffrey JAFFEUX
980972182f
dashboard next: caching, mobile support and new charts 2018-05-03 15:41:41 +02:00
Joffrey JAFFEUX
37a0ceb4e7
Adds fixture for new contributors 2018-04-26 17:39:00 +02:00
Joffrey JAFFEUX
a9c3437d51
dashboard next: adds basic spec 2018-04-25 10:28:41 +02:00
Joffrey JAFFEUX
59d4123316
PERFORMANCE: disables jquery animations during testing 2018-04-24 18:29:26 +02:00
Joffrey JAFFEUX
7466769b67
PERF: disables composer transitions in tests 2018-04-23 10:23:11 +02:00
Sam
54d153068a DEV: remove qunit rails fork and add a couple of async tests 2018-04-23 16:42:40 +10:00
Jeff Wong
252dd32895 show card on preview panel. 
refactor user and group cards

refactor userLoading to loading

add logic to display cards above mentions for fixed placements
 2018-04-20 12:28:24 -07:00
Guo Xiang Tan
6cce839f0a FIX: Missing action to trigger add group members modal for group owners. 
https://meta.discourse.org/t/unable-to-add-members-to-a-group-as-group-owner-who-is-not-staff/85346?u=tgxworld
 2018-04-16 09:09:47 +08:00
Neil Lalonde
0e2584b841 fix cursor on disabled composer 2018-04-12 11:32:13 -04:00
Guo Xiang Tan
a389baeb07 FIX: Group pages should work when group name contains periods. 
https://meta.discourse.org/t/group-name-cant-have-dot-inside/48658
 2018-04-12 17:11:36 +08:00
Guo Xiang Tan
c0595ebe99 FIX: Disable save button when new group form is empty. 
https://meta.discourse.org/t/adding-owners-members-ux-is-inconsistent-and-misleading/58084/26?u=tgxworld
 2018-04-12 10:29:36 +08:00
Guo Xiang Tan
66abd340db Fix randomly failing JS build. 
For some reason, the test rack server would block on
a `/letter_avatar_proxy` route causing ajax requests to
stack up.
 2018-04-11 22:23:49 +08:00
Neil Lalonde
6e6892c88e FEATURE: when uncategorized topics are not allowed, disable the post input until a category is chosen 2018-04-10 19:31:28 -04:00
Joffrey JAFFEUX
d9ac0152e4
fixes search-full-test for revamped search page 2018-04-10 09:59:24 +02:00
Neil Lalonde
d7ea6f93e7 FIX: preference page error when badges are disabled 2018-04-09 14:27:00 -04:00
Régis Hanol
1b351a3355 disable full page search acceptance tests (cc @jjaffeux) 2018-04-09 20:14:57 +02:00
Guo Xiang Tan
c82b2dcc24 Remove admin group management pages. 2018-04-09 15:14:50 +08:00
Guo Xiang Tan
4319273cf5 UX: Split up group form into smaller sections. 2018-04-09 15:14:50 +08:00
Claas Augner
ba905b24ca FIX: differentiate one/other select-kit maximumLabel/minimumLabel 2018-04-09 09:12:01 +02:00
Joffrey JAFFEUX
f0fe16d824
FEATURE: implements minimum selection for select-kit 2018-04-05 16:45:19 +02:00
Guo Xiang Tan
e36e9de28a Allow admin to view logs of automatic groups. 2018-04-05 16:31:55 +08:00
Robin Ward
895bca5f5b FIX: Broken JS tests 2018-04-02 14:18:10 -04:00
Joffrey JAFFEUX
3287ac77e0
FIX: reverts combobox placeholder and introduces noneLabel 
noneLabels works almost like none but instead of actually adding a row in the list, it will only change the text displayed in the header, when there's no selection.
 2018-03-29 13:42:00 +02:00
Guo Xiang Tan
52e75eaee9 UX: Tweaks to group pages. 2018-03-29 17:04:48 +08:00
Guo Xiang Tan
baa383b7f1 Fix the build. 2018-03-28 09:42:12 +08:00
Joffrey JAFFEUX
15aa712227
fix category-row regressions 2018-03-27 14:11:05 +02:00
Guo Xiang Tan
f6b6ddd73c REFACTOR: Extract group form into a component. 2018-03-27 19:26:05 +08:00
Guo Xiang Tan
bc4de7b5ec Make eslint happy. 2018-03-27 17:44:04 +08:00
Guo Xiang Tan
7edab1c0b9 UX: Add groups/custom/new route for admins to create a new group. 2018-03-27 17:39:05 +08:00
Guo Xiang Tan
2ecd234e27 UX: Consolidation group manangement into a single tab. 2018-03-27 13:34:46 +08:00
Guo Xiang Tan
dcd1d422d1 UX: Allow admins to set users as owners while adding users. 
https://meta.discourse.org/t/adding-owners-members-ux-is-inconsistent-and-misleading/58084/9
 2018-03-26 17:33:50 +08:00
Guo Xiang Tan
27e60c78d4 Remove obsolete JS tests. 2018-03-26 16:26:42 +08:00
Guo Xiang Tan
35745166b5 UX: New group membership management workflow. 
https://meta.discourse.org/t/adding-owners-members-ux-is-inconsistent-and-misleading/58084
 2018-03-26 16:15:02 +08:00
Joffrey JAFFEUX
d48542796e
FIX: select-kit refactoring 
- improve mini-tag-chooser keyboard behavior
- all multil select now respond to select all and left/right arrows
- improve events handling
- many minor tweaks
 2018-03-22 11:29:55 +01:00
Guo Xiang Tan
f3b402ffd5 UX: Allow users to filter members on group page. 
* Only admins are allowed to filter users by email.
 2018-03-22 14:02:41 +08:00
Guo Xiang Tan
be866dbe6e UX: Allow group owners to manage members from group members page. 2018-03-21 18:22:55 +08:00
Robin Ward
b9abd7dc9e FEATURE: Shared Drafts 
This feature can be enabled by choosing a destination for the
`shared drafts category` site setting.

* Staff members can create shared drafts, choosing a destination
category for the topic when it is published.

* Shared Drafts can be viewed in their category, or above the
topic list for the destination category where it will end up.

* When the shared draft is ready, it can be published to the
appropriate category by clicking a button on the topic view.

* When published, Drafts change their timestamps to the current
time, and any edits to the original post are removed.
 2018-03-20 17:15:26 -04:00
Neil Lalonde
a9de712eed FIX: not found message when trying to log in with a link, even though the email with the link was successfully sent 2018-03-19 16:08:10 -04:00
Guo Xiang Tan
2b7fb43d84 Fix the build. 2018-03-19 18:47:17 +08:00
Guo Xiang Tan
fe96ef6ed2 UX: Use topic list for displaying group messages on group page. 
https://meta.discourse.org/t/group-inbox-on-a-groups-page-mockup/71319
 2018-03-16 11:56:40 +08:00
Guo Xiang Tan
a35227918f UX: Display group topics in a topic list. 2018-03-15 11:37:55 +08:00
Gerhard Schlager
243ee565dc Reset widget decorators after each test 2018-03-12 14:22:50 +01:00
Sam
b57d4c87a4 FEATURE: update CommonMark to version 0.28 2018-03-08 12:19:53 +11:00
Gerhard Schlager
8e48b339fa Drop unused tables (#5630) 2018-03-05 17:27:30 -05:00
Joffrey JAFFEUX
6d4ff05cf0
FIX: makes sure [999500..999999] is correctly shown as 999k 2018-03-02 11:00:48 +01:00
Guo Xiang Tan
b9ff6d60b9 Fix the build. 2018-03-02 14:43:02 +08:00
Guo Xiang Tan
d9b4b12694 UX: Display warning message about social logins disabled when 2FA is enabled. 2018-03-02 14:22:52 +08:00
Arpit Jalan
841e58fc46 delete extra blank lines 2018-02-27 15:51:50 +05:30
Arpit Jalan
ec8cc833c6 fix the build 2018-02-27 15:48:36 +05:30
Arpit Jalan
4010d8d9f9 FEATURE: show "edit message" button on message footer for staff 
Show "Edit Message" button on personal message footer for staff if PM tagging is enabled.
 2018-02-27 14:22:03 +05:30
Guo Xiang Tan
24bd310d7b Fix the build. 2018-02-27 10:15:13 +08:00
Neil Lalonde
3313072957 Remove censored_pattern site setting, which is replaced by watched words 2018-02-26 16:29:27 -05:00
Joffrey JAFFEUX
ac701696b3
FEATURE: replaces tag-chooser/tag-group-chooser with select-kit component 
These component were also the last using select2. As a consequence select2 is removed from Discourse in this commit.
 2018-02-26 11:42:57 +01:00
Joffrey JAFFEUX
6f5acfe783 Login with email/forget password UI refactoring 
* move button into login modal with social buttons
* adds email link next to login field when filling it
* adds proper validation messages
* improves forgot password flash clearing
* more tests
 2018-02-22 08:06:15 +08:00
Guo Xiang Tan
14f3594f9f Review Changes for f4f8a293e7. 2018-02-21 14:55:49 +08:00
Jeff Wong
f4f8a293e7 FEATURE: Implement 2factor login TOTP 
implemented review items.

Blocking previous codes - valid 2-factor auth tokens can only be authenticated once/30 seconds.
I played with updating the “last used” any time the token was attempted but that seemed to be overkill, and frustrating as to why a token would fail.
Translatable texts.
Move second factor logic to a helper class.
Move second factor specific controller endpoints to its own controller.
Move serialization logic for 2-factor details in admin user views.
Add a login ember component for de-duplication
Fix up code formatting
Change verbiage of google authenticator

add controller tests:
second factor controller tests
change email tests
change password tests
admin login tests

add qunit tests - password reset, preferences

fix: check for 2factor on change email controller
fix: email controller - only show second factor errors on attempt
fix: check against 'true' to enable second factor.

Add modal for explaining what 2fa with links to Google Authenticator/FreeOTP

add two factor to email signin link

rate limit if second factor token present

add rate limiter test for second factor attempts
 2018-02-21 09:04:07 +08:00
OsamaSayegh
f3815cd785 FEATURE: New site setting for additional allowed filetypes for staff (#5364) 
* FEATURE: New site setting for additional allowed filetypes for staff

* Problematic variable name

* feedback

* small issues

* fix indentation

* failing tests

* Remove message bus and fix minor issues

* Missed this message bus
 2018-02-19 10:44:24 +01:00
Joffrey JAFFEUX
25dd8ff62a
FIX: broken composer-actions spec 2018-02-14 11:32:20 +01:00
Erick Guan
03b3e57a44 FEATURE: login by a link from email 
Co-authored-by: tgxworld <tgx@discourse.org>
 2018-02-13 16:14:39 +08:00
Sam
b34b1b6fe3 FIX: invite to message was not allowing groups 
Previously we were incorrectly checking mentionable instead of messageable

Also fix edge case where multiple groups sharing a name mean that exact match override is not working

Also cleans up params sent to user selector
 2018-02-13 13:28:46 +11:00
Vinoth Kannan
91beedd0ca FEATURE: Composer HTML pasting ul tag support for MS Word 2018-02-10 01:18:56 +05:30
Joffrey JAFFEUX
190d208631
FEATURE: improves composer-actions toggle menu 
* only toggles
* fix a bug with presence
* more tests
* do not duplicate `continuing discussion...` text
* persist state to allow switching between toggles
 2018-02-08 11:46:55 +01:00
Robin Ward
80ea2e5107 FIX: Enable personal messages in tests 2018-02-02 17:06:02 -05:00
Robin Ward
8ff4104555 Many enhancements to the flagging / suspending interface. 2018-02-01 17:13:02 -05:00
Joffrey JAFFEUX
f7df68c9a3
FIX: makes composer-actions toggling whisper instead of replying 2018-02-01 23:07:37 +01:00
Joffrey JAFFEUX
97ddaeeae8
FIX: use css instead of js to fix select-kit-collection max-height 2018-02-01 16:56:07 +01:00
Joffrey JAFFEUX
9923829402
FEATURE: Menu toggle for different reply modes 
Allow users to access different reply modes from the composer.

Actions introduced:

- reply_as_new_topic
- reply_as_private_message
- reply_to_topic
- reply_as_whisper/not
 2018-02-01 16:42:56 +01:00
Robin Ward
96710754d9
Merge pull request #5540 from discourse/mixed-text-direction-support 
FEATURE: Mixed text direction support
 2018-02-01 07:29:15 -08:00
Arpit Jalan
49424fd798 rename private to personal 2018-02-01 13:25:29 +05:30
Arpit Jalan
ff0376a80b rename 'enable_private_messages' to 'enable_personal_messages' 2018-02-01 13:25:29 +05:30
Arpit Jalan
25ec077eca rename 'min_private_message_{post/title}_length' to 'min_personal_message_{post/title}_length' 2018-02-01 13:25:29 +05:30
Sam
187b0031c5 correct specs 2018-02-01 16:16:14 +11:00
Vinoth Kannan
10ed4c0078 FEATURE: Composer HTML pasting support for complex table formats 2018-01-31 01:39:11 +05:30
scossar
843d88c5d0 Remove unused imports 2018-01-29 20:11:12 -08:00
scossar
5d18f72b8c Add tests for text-direction functions 2018-01-29 19:16:35 -08:00
scossar
41f1e7430c Refactor code; add tests 2018-01-29 17:42:19 -08:00
Gerhard Schlager
eb52c5469e FEATURE: Allow plugins to register a new locale 2018-01-25 14:57:41 +01:00
Neil Lalonde
dc97239040 FIX: censored regex words were replacing other text that shouldn't be censored 2018-01-24 12:33:47 -05:00
Sam
3b083ca0bd correct spec 2018-01-24 13:23:27 +11:00
Vinoth Kannan
86e142b39f UX: Copy selected text to the link building modal 2018-01-24 02:02:12 +05:30
Régis Hanol
c425a2d335 fix js suite 2018-01-22 17:48:03 +01:00
Kyle Zhao
83c549bd31 FEATURE: grant badges in post admin wrench (#5498) 
* FEATURE: grant badges in post admin wrench

* only grant manually grantable badges

* extract GrantBadgeController mixin
 2018-01-22 14:10:53 +11:00
Régis Hanol
f674b9e86e FIX: encode image filename so '[', ']' and '|' doesn't break the markdown 2018-01-19 19:52:03 +01:00
Jeff Atwood
7ed41fae2b
Merge pull request #5493 from notriddle/home_logo_h1 
Change the text-only home logo to an H1
 2018-01-18 16:14:36 -08:00
Arpit Jalan
79eb9d7086 FEATURE: show header search results on search log term details page 2018-01-17 12:47:16 +05:30
Arpit Jalan
bd7e21fa99 fix the build 2018-01-15 14:35:11 +05:30
Arpit Jalan
785d063a6b
Merge pull request #5496 from techAPJ/admin-graphs 
FIX: graphs should go to zero for missing dates
 2018-01-15 11:10:29 +05:30
Arpit Jalan
b7ba490df7 FIX: graphs should go to zero for missing dates 2018-01-15 10:16:34 +05:30
Michael Howell
f29d233287 Fix test case for site logo as <h2> 2018-01-12 23:34:31 +00:00
Neil Lalonde
2493648f9c PERF: calculate topic_counts for tags in an async job so tag queries that include counts are much faster 2018-01-12 11:03:03 -05:00
Joffrey JAFFEUX
e9fd4f271a
FIX: fix category-link spec failure 2018-01-11 13:43:05 +01:00
Joffrey JAFFEUX
3ee7b18886
FIX: disable by default limitMatches 2018-01-11 09:54:39 +01:00
Joffrey JAFFEUX
3ec2024466
select-kit refactoring 
* improve events naming/handling
* do not explicitly check for true/Fasle
* make sure header is re-computed on toggle
 2018-01-11 09:39:51 +01:00
Neil Lalonde
edb3a7f646 FIX: support for watched_words_regular_expressions when censoring words 2018-01-10 14:11:23 -05:00
Neil Lalonde
ad62f1099c FIX: censored words should support * as wildcard 2018-01-09 15:53:40 -05:00
Joffrey JAFFEUX
c9921869f1
FIX: adds select-kit api to modify header computed content (#5476) 
This api would allow to simply modify header text or icons, eg:

```
      api.modifySelectKit("select-kit")
        .modifyHeaderComputedContent((context, computedContent) => {
          computedContent.title = "Not so evil";
          return computedContent;
        });
```
 2018-01-09 10:52:32 +01:00
Robin Ward
fb863e18ec FIX: Broken test 2018-01-08 17:22:53 -05:00
Guo Xiang Tan
6cab53abd4 Puppeteer page.authenticate messes up CSRF tokens in forms. 2018-01-04 21:30:04 +08:00
Guo Xiang Tan
af1e2865f7 Re-introduce ability to handle basic authentication in smoke tests. 2018-01-03 14:24:06 +08:00
Vinoth Kannan
d18c42abd5 FIX: Ignore if the default localization node is not an object (#5439) 2017-12-27 16:53:53 +11:00
Vinoth Kannan
035f96d25f Allow linked images inside table cells in HTML to Markdown conversion 2017-12-23 22:48:39 +05:30
Guo Xiang Tan
47585202cb Handle promise in smoke test. 2017-12-23 09:29:22 +08:00
Vinoth Kannan
3ae9d91d86 UX: Use tight list by default in HTML to Markdown conversion 2017-12-22 21:34:55 +05:30
Vinoth Kannan
ac1e93e82a Minor fix to correctly trim spaces in HTML to Markdown conversion 2017-12-22 19:05:40 +05:30
Joffrey JAFFEUX
315b9d796d
select-kit refactoring 
* better test helper
* more reliable tests
* more consistent use of data-value/data-name/title/aria-label everywhere: header and rows
 2017-12-22 13:08:12 +01:00
Vinoth Kannan
4935ae4338 Remove unwanted spaces between HTML tags and support Word documents 2017-12-22 09:28:24 +05:30
Sam
ab2215e629 fix broken test 2017-12-21 20:19:15 +11:00
Vinoth Kannan
129d924c0d Dont support single row or column tables in HTML to Markdown conversion 2017-12-21 12:58:57 +05:30
Guo Xiang Tan
8f6e2b7186 Fix unhandled promise in smoke test. 2017-12-21 10:32:43 +08:00
Vinoth Kannan
ac1d3a761e Support for table & ol tags for HTML pasting in composer 2017-12-20 19:24:55 +05:30
Gerhard Schlager
e49c7147ce Use default timeout (30s) for smoke tests 2017-12-20 14:41:49 +01:00
Gerhard Schlager
e6fc543aef Use higher timeouts for smoke_test 2017-12-20 12:47:22 +01:00
Guo Xiang Tan
6e0b2a9f37 Bump timeout when logging in in smoke_test. 2017-12-20 17:08:57 +08:00
Guo Xiang Tan
87c334c063 Fix randomly failing JS acceptance tests. 2017-12-20 11:04:47 +08:00
Arpit Jalan
eab66065d1 FEATURE: search log term details page (#5445) 2017-12-20 13:41:31 +11:00
Vinoth Kannan
6272f35eec blockquote tag support for HTML pasting in composer 2017-12-19 20:59:55 +05:30
Guo Xiang Tan
dfed56cb57 Disable JS test that fails in headless mode. 2017-12-19 20:50:39 +08:00
Guo Xiang Tan
6a4f391e38 Switch to chrome headless mode instead of phantomjs. 2017-12-19 16:00:43 +08:00
Vinoth Kannan
ad41523895 FEATURE: Converting code tags to Markdown while pasting 2017-12-18 22:12:05 +05:30
Guo Xiang Tan
8d44642b97 Add smoke test script that runs in chrome headless. 2017-12-18 16:39:01 +08:00
Vinoth Kannan
0588edbc96 FEATURE: Keep supported HTML tags in HTML to Markdown conversion 2017-12-18 12:48:17 +05:30
Vinoth Kannan
4f2f42d710 PERF: Better handling of headings in HTML inline pasting 2017-12-17 00:45:21 +05:30
Vinoth Kannan
dc159d7fa6 Grab dimention of the clipboard images 2017-12-15 17:28:38 +05:30
Guo Xiang Tan
0f011e1c1c Update fixtures to fix JS test. 2017-12-15 13:42:17 +08:00
Vinoth Kannan
f0497ee9c4
FEATURE: HTML to Markdown conversion using native JavaScript ES6 classes (#5425) 2017-12-15 10:28:20 +05:30
Régis Hanol
2f792bc59f FIX: a topic should be visited when you've read everything and there's deleted posts at the end 2017-12-15 00:00:48 +01:00
Régis Hanol
cad122993a eslint 😲 🔫 2017-12-13 22:24:02 +01:00
Régis Hanol
1b4483c942 FEATURE: Added 'select +below' and 'select +all replies' options to selecting posts 2017-12-13 22:12:06 +01:00
Joffrey JAFFEUX
c1c31b99ce
Replaces toolbar popup-menu with select-kit 2017-12-13 10:49:32 +01:00
Robin Ward
74b9828731 FIX: Remove mentions filters from user and groups 
Additionally return no data if disabled
 2017-12-07 16:29:02 -05:00
Joffrey JAFFEUX
fd99e1ef56 FEATURE: site setting enable_mentions to turn on/off mentions 2017-12-07 16:27:58 -05:00
Neil Lalonde
23ea4b6739 FIX: don't create featured link if title includes more than a url 2017-12-04 14:21:08 -05:00
Neil Lalonde
fb08441802 Revert "FIX: don't create featured link if title includes more than a url" 2017-12-04 12:53:12 -05:00
Neil Lalonde
cde42c3f69 FIX: don't create featured link if title includes more than a url 2017-12-04 12:03:41 -05:00
Joffrey JAFFEUX
dbadebacd1
FIX: allows select-kit to search by null value 2017-12-01 20:02:00 +01:00
Arpit Jalan
496cd3b4df
Merge pull request #5385 from techAPJ/search-logs-improvements 
FEATURE: support search click through tracking for user, category and tags
 2017-12-01 12:08:38 +05:30
Arpit Jalan
e3925278e2 FEATURE: support search click through tracking for user, category and tags 
https://meta.discourse.org/t/search-logs-page/73281/11?u=techapj

This commit adds following features:

- support for tracking click through to user, tag and category
- new filter for search type (header, full page)

This commit also removes "most viewed topic" field from search logs page because we are now tracking multiple click through entities, so topic is not a special entity anymore. This also improves query perf. The query now takes `20.5ms` to runs, as opposed to `655.9ms` previously.
 2017-12-01 12:04:55 +05:30
Arpit Jalan
fb735d78ef fix the build 2017-11-30 17:28:36 +05:30
Sam
610d7a9412 teach acceptance test to work on the last day of the month 2017-11-30 13:20:04 +11:00
Gerhard Schlager
41e70c410c
FEATURE: replace GUID in image name uploaded from iOS (#5370) 2017-11-28 11:05:34 +01:00
Joffrey JAFFEUX
49b1df40fc
FIX: various issues when editing category permissions 
This commit also adds multiple tests
 2017-11-27 19:50:04 +01:00
Joffrey JAFFEUX
87ada55e67
FIX: avoids test failing at some times of the day 2017-11-27 10:49:35 +01:00
Joffrey JAFFEUX
96cdc4e66e
FIX: makes allowInitialValueMutation more restrictive 2017-11-24 13:15:02 +01:00
Joffrey JAFFEUX
63307c303a
FIX: regression preventing to set number of hours before closing 
This commit also adds a full test suite for editing topic timer.
 2017-11-24 02:48:45 +01:00
Joffrey JAFFEUX
9208909b26 tweak icon-library generation 2017-11-23 18:24:26 +01:00
Neil Lalonde
ac4b4e30dc remove the test that only works in a browser 2017-11-22 15:23:06 -05:00
Neil Lalonde
6c86e0c94a FEATURE: remove the featured link by editing the topic 2017-11-22 14:53:35 -05:00
Joffrey JAFFEUX
b14d9529b8
FIX: adds support for name changes tracking 2017-11-22 13:49:45 +01:00
Joffrey JAFFEUX
b2b565c2fb
select-kit initial plugin api implementation (0.8.13) 
```
api.modifySelectKit("identifier-of-the-select-targeted")
  .modifyContent((context, existingContent) => {})
  .appendContent(() => {})
  .prependContent(() => {})
  .onSelect((context, val) => {});
```
 2017-11-22 10:34:12 +01:00
Neil Lalonde
33feb62673 FIX: times showing as < 1m instead of blank 2017-11-21 14:33:49 -05:00
Robin Ward
7533e5b541 UX: Use date picker on full page search 2017-11-21 12:52:23 -05:00
Joffrey JAFFEUX
39f3dbd945
Introduces select-kit 
* renames `select-box-kit` into `select-kit`
* introduces `single-select` and `multi-select` as base components
* introduces {{search-advanced-category-chooser}} as a better component for selecting category in advanced search
* improves events handling in select-kit
* recreates color selection inputs using {{multi-select}} and a custom {{selected-color}} component
* replaces category-selector by a component using select-kit and based on multi-select
* improves positioning of wrapper
* removes the need for offscreen, and instead use `select-kit-header` as a base focus point for all select-kit based components
* introduces a formal plugin api for select-kit based components
* introduces a formal pattern for loading and updating select-kit based components:

```
computeValue()
computeContent()
mutateValue()
```
 2017-11-21 11:53:09 +01:00
Guo Xiang Tan
edc4b30f82 Remove tests that are no longer being used. 2017-11-21 18:07:23 +08:00
Robin Ward
b9595966d4 FIX: Error applying quotes with blank lines in front 2017-11-20 13:46:19 -05:00
Neil Lalonde
b37e40eea9 FEATURE: show read time in last 60 days 2017-11-16 15:46:51 -05:00
Arpit Jalan
3831663fea FEATURE: search logs page (#5313) 2017-11-15 11:13:50 +11:00
Joffrey JAFFEUX
680696fc04
Replaces delete flag modal by a dropdown 2017-11-14 07:55:08 -08:00
Sam
38c103c75e correct spec 2017-11-13 18:09:24 +11:00
Robin Ward
1f14350220 Rename "Blocked" to "Silenced" 2017-11-10 14:10:27 -05:00
Joffrey JAFFEUX
6d3ed966cd
FEATURE: replace admin flags modal by a select-box 2017-11-09 12:33:36 -08:00
Michael Howell
38b8d68c68 FEATURE: Allow the user to select a custom home page (#5268) 
* Add user_home configuration option

* Use the new user_home preference to actually show the right home page

* Fix trailing whitespace

* Update user_option_serializer.rb

* Fix JavaScript default homepage tests

* Use an object instead of a giant switch

* Remove trailing whitespace

* Make the default `user_home` set to `null` instead of `0`

* Rename user_home to homepage_id
 2017-11-10 06:45:19 +11:00
Joffrey JAFFEUX
0da529010a
FEATURE: support for multi-combo-box 2017-11-09 10:57:53 -08:00
Robin Ward
3093074398 UX: Include the flagged person's username on the flagged post 2017-11-09 13:18:33 -05:00
Neil Lalonde
814502f7bb FEATURE: add a Dismiss link to user menu that dismisses all notifications 2017-11-07 10:41:21 -05:00
Guo Xiang Tan
abdfac9cb5 FIX: Allow group members to freely exit group option incorrectly disabled. 
https://meta.discourse.org/t/cannot-check-allow-members-to-leave-group-freely-when-group-is-configured-to-allow-users-to-send-membership-requests-to-group-owners/73400
 2017-11-06 10:30:58 +08:00
ckeboss
93633865d9 Adds primary user group as a class to quote (#5285) 
* Adds primary user group as a class to quote

This feature addition will add the class `group-PRIMARY_USER_GROUP` to
the quote `aside`. `PRIMARY_USER_GROUP` will be the primary user group
of the user being quoted. This is similar to the class that is added to
a `topic-post`.

* Remove trailing whitespace

* Fix avatar in test

* Address PR comments

* Fix trailing whitespace
 2017-11-03 09:51:40 -04:00
Gerhard Schlager
c107e99138 clear localStorage after each test 2017-11-02 23:39:24 +01:00
Robin Ward
05a61fa8e1 FIX: CSS class names changed on group posts 2017-11-02 15:05:41 -04:00
Robin Ward
0a69f2bc77 REFACTOR: Remove many Discourse.Category.list() calls 2017-11-01 15:25:35 -04:00
Neil Lalonde
7dc3671490 FEATURE: remove obsolete settings ga_tracking_code and ga_domain_name. Use ga_universal_tracking_code and ga_universal_domain_name instead. 2017-11-01 11:41:51 -04:00
OsamaSayegh
55095bc44e FEATURE: Use ACE for badge queries (#5269) 
* FEATURE: Use ACE for badge queries

* Forgot disabled

* When disabled, cursor should be `not-allowed`

* Tests + prefix custom attribute with `data-`
 2017-10-30 18:07:49 +11:00
Robin Ward
fbd5f1e411 REFACTOR: Rename store:main to service:store so we can inject it 2017-10-27 13:59:45 -04:00
Joffrey JAFFEUX
ae1e4de286 [FIX] better control on value mutation 2017-10-20 13:40:56 -07:00
Régis Hanol
62156885ec UX: remove 🔥heading and ruler button from composer toolbar 2017-10-20 10:59:31 +02:00
Joffrey JAFFEUX
4d041d5b87 [FIX] Fix wizard spec 
This commit introduces a mutation on input value given to select-box-kit when value is empty. The refactoring required to avoid this would be too heavy atm, but ultimately we would want to avoid this.
 2017-10-19 17:34:56 -07:00
Joffrey JAFFEUX
d77ef05ee1 Fix broken tests 2017-10-19 14:32:37 -07:00
Joffrey JAFFEUX
ae1743c61f [WIP] select-box-kit refactoring 2017-10-19 12:51:08 -07:00
Robin Ward
fb2e581b26 FIX: Headings must begin with heading-- to avoid some griefing 2017-10-16 11:53:47 -04:00
Robin Ward
5572d1d5f7 Refactor user summary page to use more components 2017-10-13 16:05:40 -04:00
Robin Ward
f4decf9193 The quote-other-topic class has been removed 2017-10-06 15:16:06 -04:00
Guo Xiang Tan
91c5f928c2 FIX: Group#mentionable and Group#messageable not fully working. 2017-10-02 16:50:58 +08:00
Guo Xiang Tan
a370d7c7fd FIX: Compatibility between Client and Server routing. 
mend
 2017-09-29 10:34:50 -04:00
Robin Ward
df81d109e5 The ability to attach attrs when embedding widgets 2017-09-28 16:08:43 -04:00
Guo Xiang Tan
793ccd144e Fix broken JS tests. 2017-09-26 16:15:25 +08:00
Robin Ward
b3ffa19f95 FIX: Make sure Post records have access to Site 2017-09-25 13:18:26 -04:00
Robin Ward
09ed2ed749 Add Suspend User to flags page 2017-09-25 12:28:00 -04:00
Robin Ward
079f108ceb UX: Improve interface for flagging with many flaggers 2017-09-25 12:28:00 -04:00
Robin Ward
6bce3004d9 UX: Nicer selection of suspend duration 2017-09-25 12:28:00 -04:00
Robin Ward
2a56cf8bb6 Tests + Refactoring for Suspension Modal 2017-09-25 12:26:06 -04:00
Robin Ward
6e48884274 Extract out common "cancel" link functionality from modals 2017-09-25 12:25:15 -04:00
Robin Ward
4020409bbf Add support for suspension message 2017-09-25 12:25:14 -04:00
Robin Ward
daceeb9700 Refactor user suspension modal 2017-09-25 12:25:14 -04:00
Robin Ward
d7c37d9369 Add front end service for staff controls 2017-09-25 12:25:14 -04:00
Robin Ward
5cf50f0034 Adjust flagged posts to use the store 2017-09-25 12:25:14 -04:00
Robin Ward
cc1a461254 Convert flags admin to flexbox 2017-09-25 12:25:14 -04:00
Robin Ward
1af4acbb3d Add tests to flagged topics 2017-09-25 12:25:14 -04:00
Robin Ward
40eba8cd93 FEATURE: View flags grouped by topic 2017-09-25 12:25:14 -04:00
Régis Hanol
8ed318c4fe display 'similar to' earlier when composing a post 2017-09-16 01:03:29 +02:00
Joffrey JAFFEUX
e6385e4527 attempts to fix broken spec only on CI 2017-09-14 20:34:37 +02:00
Joffrey JAFFEUX
562e48dfb7 adds a dsl to simplify testing of the select-box 2017-09-14 19:50:32 +02:00
Robin Ward
8c2d6118ff Remove some of the last few fa-icon helpers 2017-09-14 11:20:36 -04:00
Robin Ward
4f9ba874a9 API so that you don't have to use a global variable for pretender 2017-09-13 11:55:58 -04:00
Joffrey JAFFEUX
c06c88b479 cleaner title attribute for select-box 2017-09-12 01:36:58 +02:00
Joffrey JAFFEUX
e924920bec uses select-box for pinned-button 
This commit also moves more logic in dropdown-select-box instead of
duplicating it for notifications-options and pinned-options
 2017-09-11 19:14:22 +02:00
Joffrey JAFFEUX
7f9220a2cd minor select-box fixes 
- select row when using tab
- makes sure tab order is correct
- highlight first row when filtering
 2017-09-11 00:38:32 +02:00
Joffrey JAFFEUX
a0f36a0401 fix broken spec 2017-09-10 21:07:13 +02:00
Joffrey JAFFEUX
4b558638c8 FEATURE: improves keyboard handling of select-box 
- arrow keys
- escape key
 2017-09-10 19:12:03 +02:00
Joffrey JAFFEUX
950b9e9eaf FIX: keeps as much as possible the same api for select-box components 2017-09-09 20:29:07 +02:00
Joffrey JAFFEUX
cf6fb7622e Replaces all notification-options like dropdowns with select-box 2017-09-08 20:47:39 +02:00
Joffrey JAFFEUX
dd27c0c80e FIX: supports emojis in pinned topic excerpt 2017-09-07 11:06:04 +02:00
Joffrey JAFFEUX
ccf5005feb FEATURE: uses select-box for topic-notifications-button component 
- Introduces ComponentConnector to use a component inside a widget
- Use css to set size of components instead of properties
- Smarted positionning
- Style tweaks
 2017-09-06 16:58:00 +02:00
Sam Saffron
46ebd0ee40 correct spec and allow for zero allowed iframes 2017-09-01 12:08:55 -04:00
Robin Ward
dffb1fc4ee FEATURE: Use Glimmer compiler for widget templates 
Widgets can now specify a template which is precompiled using Glimmer's
AST and then converted into our virtual dom code.

Example:

```javascript
createWidget('post-link-arrow', {
  template: hbs`
    {{#if attrs.above}}
      <a class="post-info arrow" title={{i18n "topic.jump_reply_up"}}>
        {{fa-icon "arrow-up"}}
      </a>
    {{else}}
      <a class="post-info arrow" title={{i18n "topic.jump_reply_down"}}>
        {{fa-icon "arrow-down"}}
      </a>
    {{/if}}
  `,

  click() {
    DiscourseURL.routeTo(this.attrs.shareUrl);
  }
});
```
 2017-09-01 09:28:16 -04:00
Robin Ward
70706897f4 FIX: Test was failing on high DPI monitor 2017-08-30 15:32:58 -04:00
Robin Ward
3d95bac3fb Migrate away from #discourse-modal to .d-modal 2017-08-30 15:29:51 -04:00
Robin Ward
b100ea1baa FIX: Broken acceptance test 2017-08-30 12:35:02 -04:00
Robin Ward
b210c801a4 FIX: Linting error 2017-08-30 11:30:57 -04:00
Joffrey JAFFEUX
746c5927e1 Replaces remaining {{category-chooser}} by {{category-select-box}} 
To achieve replacement, this commit also adds support for:
- clearSelectionLabel which will allows to unselect any chosen category
- select-box inside a modal
- fixes minor css positioning issues

Note: {{category-chooser}} will be removed in the next weeks.
 2017-08-30 17:04:17 +02:00
Guo Xiang Tan
0a53c589c4 Fix linting. 2017-08-30 15:36:45 +08:00
Joffrey JAFFEUX
1ea5205022 FIX: tests helper do not use es6 2017-08-29 16:16:51 +02:00
Joffrey JAFFEUX
1bcfa87d18 FIX: select-box broken spec 
Introduces a test helper for selectBox to simplify these cases.
 2017-08-29 15:51:25 +02:00
Joffrey JAFFEUX
f101fec19c FIX: improves uncategorized support for category-select-box 2017-08-29 12:48:26 +02:00
Joffrey JAFFEUX
861dbe3b51 select-box refactoring 
- more flexibility (allows custom title)
- less re-render
- more robustness
 2017-08-29 12:25:54 +02:00
Joffrey JAFFEUX
b83c0747d9 FIX: select-box improvments 
- more tests for category-select-box
- allows to clear selection
- fix positioning on safari
- focus on click
- do not display uncategorized if not allowed in settings
- fix component state impacting other specs
- better texts
- higher category-select-box on mobile
 2017-08-28 14:34:04 +02:00
Joffrey JAFFEUX
14f06c2740 select-box minor fixes 2017-08-25 19:56:57 +02:00
Neil Lalonde
2c56f8df7c FEATURE: show tags in search results 2017-08-25 11:52:59 -04:00
Joffrey JAFFEUX
d05df4a337 FIX: better headerText handling on select-box 2017-08-24 18:31:33 +02:00
Joffrey JAFFEUX
d52048ad34 Revert "Revert "FEATURE: improves select-box to support category selection on new topic"" 
This reverts commit 1d90f6016a.
 2017-08-24 16:04:47 +02:00
Robin Ward
16b67745d8 FIX: store:main error when running QUnit tests checking disabled plugins 2017-08-23 19:34:31 -04:00
Joffrey JAFFEUX
1d90f6016a Revert "FEATURE: improves select-box to support category selection on new topic" 
This reverts commit 7b4e302677.
 2017-08-23 16:33:03 +02:00
Joffrey JAFFEUX
7b4e302677 FEATURE: improves select-box to support category selection on new topic 2017-08-23 15:08:19 +02:00
Guo Xiang Tan
93fe76fc02 Make eslint happy. 2017-08-21 21:56:22 +09:00
Guo Xiang Tan
9f11223250 Fix select-box Qunit tests to use the proper Ember test helpers. 2017-08-16 09:35:56 +09:00
Joffrey JAFFEUX
cad6107624 refactors select-box 
Note: this commit also now uses select-box for mobile topics controls
 2017-08-16 00:41:56 +02:00
Neil Lalonde
d506e577a5 FEATURE: if full search returns no results, show google search form 2017-08-15 16:46:41 -04:00
Kyle Zhao
c3249f6e93 FEATURE: add full editing access to queued posts (#5047) 
For pending new topics: the body of the post, title, categories
and the tags are editable.

For pending new replies: only the body is applicable and thus
editable

DISCUSSION: https://meta.discourse.org/t/66754
 2017-08-15 12:44:05 -04:00
Joffrey JAFFEUX
482924b161 FEATURE: initial implementation of an ember native select 2017-08-13 14:34:50 +02:00
Régis Hanol
05a74d2534 FIX: navigation item counters weren't updating properly 2017-08-10 12:22:15 +02:00
Guo Xiang Tan
705f75dd8c Merge pull request #5032 from xrav3nz/ux-hide-options-in-adv-search 
UX: exclude irrelevant search filters for anonymous users
 2017-08-09 18:21:44 +09:00
Kyle Zhao
9c6c4a7705 restructure search-test to test all filters w/ variable visibiltiy 2017-08-09 04:42:50 -04:00
Guo Xiang Tan
a9613163b5 FEATURE: Force user to enter reason when requesting for group membership. 2017-08-09 15:45:28 +09:00
Kyle Zhao
cea2a9fe53 UX: exclude irrelevant search filters for anonymous users 
On the advanced search page, filters like "I've read", "I'm watch
-ing", etc, are irrelevant to anonymous users and should be hidden
 2017-08-08 15:25:40 -04:00
Robin Ward
8dd7c0c984 UX: Convert buttons to d-button 2017-08-01 17:24:06 -04:00
Robin Ward
75d10a4098 UX: Add consistent classes to buttons 2017-08-01 17:24:06 -04:00
Neil Lalonde
ec85b41078 UX: Move watched words to the Logs section of admin 2017-07-31 17:06:50 -04:00
Sam
a13d146251 Correct post deletion spec so it is async 2017-07-28 10:50:18 -04:00
Guo Xiang Tan
4620dfe92d FEATURE: Add group settngs to allow users to leave a group freely. 
https://meta.discourse.org/t/split-join-leave-freely-setting-on-groups/65565
 2017-07-28 15:00:25 +09:00
Robin Ward
5b590b9637 REFACTOR: Replace some fa-* uses with helpers 2017-07-27 14:55:41 -04:00
Guo Xiang Tan
75374c76b3 UX: Display button to message group on group page. 
https://meta.discourse.org/t/make-it-easier-to-send-a-message-to-groups/65065
 2017-07-27 17:51:25 +09:00
Guo Xiang Tan
9c93a20cf1 Fix incorrect assertion in JS tests. 2017-07-27 17:05:08 +09:00
Neil Lalonde
24cb950432 FEATURE: Watched Words: when posts contain words, do one of flag, require approval, censor, or block 2017-07-26 11:01:09 -04:00