Commit Graph

10908 Commits

Author SHA1 Message Date
Robin Ward
d09f109b2c FIX: Re-enable filtering on user expansions on topics 2014-09-02 12:08:02 -04:00
Robin Ward
ce745b737e Renamed poster-expansion to user-expansion because it's not specific
to a poster anymore.
2014-09-02 12:08:02 -04:00
Robin Ward
2b0e11dad8 Merge pull request from hydrarulz/localize_romanian
Add translation for Romanian.
2014-09-02 10:48:38 -04:00
Robin Ward
ab02ef4221 Merge pull request from riking/plugin-events
FEATURE: Add a plugin callback when editing a post
2014-09-02 10:46:08 -04:00
Robin Ward
e39caa7eaf Merge pull request from Elberet/fix-parser
FIX: Markdown parser: empty links and bbcode parsed as link refs
2014-09-02 10:43:39 -04:00
Robin Ward
065101afac Merge pull request from cpradio/readd-dismiss-bindings
FIX: Readd the dismiss keybindings
2014-09-02 10:42:53 -04:00
Robin Ward
9c1e3553d0 Merge pull request from meinac/contributing
wrong syntax of ruby on contributing.md fixed
2014-09-02 10:40:48 -04:00
Arpit Jalan
8955bf02d8 hide poster avatars when only two posts 2014-09-02 20:10:36 +05:30
Jeff Atwood
cfb92b6e5b UX: clarify notify user flag option is just a PM 2014-09-02 03:37:21 -07:00
Jeff Atwood
3ebc67244a copyedits on Welcome to Lounge 2014-09-02 02:31:24 -07:00
Jeff Atwood
e3f8706bc0 improvements to admin quick start guide 2014-09-02 02:16:02 -07:00
Mehmet Emin İNAÇ
84a075ccf4 wrong syntax of ruby on contributing.md fixed 2014-09-02 10:09:41 +03:00
Jeff Atwood
c984cf0bcc Merge pull request from techAPJ/patch-3
correct copy for db_shared_buffers
2014-09-01 22:50:38 -07:00
Arpit Jalan
bea28929cf correct copy for db_shared_buffers 2014-09-02 11:17:32 +05:30
Régis Hanol
61db6c95d2 FIX: couldn't start a 4-spaces block on the first line of a post 2014-09-02 01:18:06 +02:00
Sam
22fbae8556 Merge pull request from akshaymohite/optimization-fixes
renamed unused variables properly
2014-09-02 08:22:43 +10:00
Sam
e0c8abc911 Merge pull request from riking/badge-solid
Admin badge interface improvements
2014-09-02 08:21:06 +10:00
Sam
202656a679 Merge pull request from cpradio/german-keyboard-support
FIX: Support J/K bindings on German Keyboards
2014-09-02 08:02:10 +10:00
Sam
208dd7848d Merge pull request from cpradio/fix-duplicate-badge-titles
FIX: Duplicate badge titles can still occur
2014-09-02 06:52:09 +10:00
cpradio
02a7a579f4 FIX: Duplicate badge titles can still occur
Send false instead of true to .uniq as the badges are not sorted.
https://meta.discourse.org/t/set-title-dialog-shows-multiple-instances-of-the-same-badge-2/19495
2014-09-01 13:56:19 -04:00
Jeff Atwood
03a7b01e4b Merge pull request from techAPJ/patch-3
suppress post count on avatar for single post
2014-09-01 08:11:32 -07:00
Arpit Jalan
eba3f6b408 suppress post count on avatar for single post 2014-09-01 14:23:34 +05:30
Sam
68cc4fb285 we need more height 2014-09-01 17:42:27 +10:00
Sam
60559b42be got to move inidicator a bit 2014-09-01 17:17:50 +10:00
Sam
12f417a378 fix broken spec 2014-09-01 17:07:09 +10:00
Sam
69e418facf FEATURE: wider search with more context 2014-09-01 17:04:57 +10:00
Jeff Atwood
7ef056810c minor copy update 2014-08-31 23:32:41 -07:00
riking
808460a28f Fix magic numbers, extra param references 2014-08-31 19:36:31 -07:00
cpradio
42c052d21b FIX: Readd the dismiss keybindings
https://meta.discourse.org/t/new-updated-bar-and-dismiss-new-button-unreachable-by-keyboard/18946/10?u=cpradio
2014-08-31 21:56:38 -04:00
cpradio
6234284243 FIX: Remove the old keyboard bindings for next/prev section, update client.en.yml to reflect the new bindings 2014-08-31 21:42:03 -04:00
Sam
f5f0971286 Merge pull request from gschlager/fix01
FIX: Reset changed site settings after import is complete
2014-09-01 11:20:31 +10:00
Sam
a2d4347573 Merge pull request from kamilbielawski/destroy_category_group_when_category_is_destroyed
FIX: destroy CategoryGroup when Category or Group is destroyed
2014-09-01 11:19:03 +10:00
Kamil Bielawski
bf679f1626 FIX: destroy CategoryGroup when Category or Group is destroyed 2014-08-31 22:10:38 +02:00
riking
1833b43ae2 FEATURE: Badge query validation, preview results, and EXPLAIN
Upon saving a badge or requesting a badge result preview,
BadgeGranter.contract_checks! will examine the provided badge SQL for
some contractual obligations - namely, the returned columns and use of
trigger parameters.

Saving the badge is wrapped in a transaction to make this easier, by
raising ActiveRecord::Rollback on a detected violation.

On the client, a modal view is added for the badge query sample run
results, named admin-badge-preview.
The preview action is moved up to the route.
The save action, on failure, triggers a 'saveError' action (also in the
route).

The preview action gains a new parameter, 'explain', which will give the
output of an EXPLAIN query for the badge sql, which can be used by forum
admins to estimate the cost of their badge queries.
The preview link is replaced by two links, one which omits (false) and
includes (true) the EXPLAIN query.

The Badge.save() method is amended to propogate errors.

Badge::Trigger gets some utility methods for use in the
BadgeGranter.contract_checks! method.

Additionally, extra checks outside of BadgeGranter.contract_checks! are
added in the preview() method, to cover cases of null granted_at
columns.

An uninitialized variable path is removed in the backfill() method.

TODO - it would be nice to be able to get the actual names of all
columns the provided query returns, so we could give more errors
2014-08-31 11:25:44 -07:00
Gerhard Schlager
5a769c7c48 FIX: Reset changed site settings after import is complete
After an import has finished the site settings should be reset to their
previous values. For example, since 'disable_emails' was set to false
before any import, it wasn't possible to login after the import
(sending email for password reset didn't work).
2014-08-31 18:09:21 +02:00
Sam
5c244c6f8f FIX: autocomplete username failing to pop up
Janky autocomplete behavior due to debounce not being accounted for
correctly when dealing with promises

This also fixes a promise leak
2014-09-01 01:48:17 +10:00
Jeff Atwood
9aac004c0a minor copy update, Omit Needless Words 2014-08-31 04:47:27 -07:00
Jeff Atwood
6221a84ce8 minor copy updates 2014-08-31 04:46:20 -07:00
Jeff Atwood
bdd3dd8a5b add 1GB memory change notes 2014-08-31 01:13:20 -07:00
Jens Maier
9be5c98c8c FIX: Markdown parser: empty links and bbcode parsed as link refs 2014-08-31 02:55:43 +02:00
Jeff Atwood
6d1be665a1 Merge pull request from cpradio/firefox-kbd-post-navigation
FIX: j/k navigation for posts using Firefox
2014-08-30 13:32:15 -07:00
Jeff Atwood
a0e47dae63 Merge pull request from techAPJ/patch-3
UX: add line break before time for post navigator
2014-08-30 13:26:28 -07:00
cpradio
37639308c0 FIX: Firefox j/k post navigation is inconsistent
https://meta.discourse.org/t/j-k-navigation-in-lengthy-topics/18945
2014-08-30 08:59:08 -04:00
cpradio
4aec030cb6 Merge branch 'master' of http://github.com/discourse/discourse 2014-08-30 08:20:57 -04:00
cpradio
3f5d530553 Change SHIFT+J and SHIFT+K to move up/down sections instead of posts. 2014-08-30 07:31:38 -04:00
Arpit Jalan
82d4c29c88 TRIVIAL: add line break before time for post navigator 2014-08-30 16:14:00 +05:30
Jeff Atwood
fb33081c36 Merge pull request from techAPJ/patch-4
FIX: use short date format for topic summary
2014-08-29 23:41:16 -07:00
Arpit Jalan
289d9e4fe1 FIX: use short date format for topic summary 2014-08-30 12:07:43 +05:30
Jeff Atwood
7a50ba600a Merge pull request from techAPJ/patch-4
FIX: use short date format for post navigator
2014-08-29 23:11:31 -07:00
Arpit Jalan
3c005557e6 FIX: use short date format for post navigator 2014-08-30 11:34:33 +05:30