Kris
80b3560050
IE11: Login form needs full flex shorthand
2019-05-16 14:07:49 -04:00
Robin Ward
225593d445
FIX: Small tweak to percentiles based on feedback
2019-05-16 13:45:36 -04:00
Joffrey JAFFEUX
f41aa5cb98
EXPERIMENTAL: attempts to gather info if chrome runner crashed ( #7562 )
2019-05-16 18:00:57 +02:00
Joffrey JAFFEUX
77b78968c9
DEV: adds findIndex to lodash ( #7561 )
2019-05-16 17:00:25 +02:00
David Taylor
b5dd4478e5
FIX: Blocked watched words should apply to staff ( #7547 )
...
Having different behavior for staff and regular users can make it confusing for admins to understand how their configuration changes affect regular users
2019-05-16 15:19:41 +01:00
Joffrey JAFFEUX
ad4d01233b
DEV: attempts to make d-editor tests more resilient ( #7556 )
2019-05-16 14:42:01 +02:00
Joffrey JAFFEUX
244c03573a
FIX: btn class was duplicated on admin-menu-buttons ( #7555 )
2019-05-16 14:37:53 +02:00
Joffrey JAFFEUX
0c6ebe66ce
EXPERIMENTAL: clicks outside seem unreliable with absolute nodes ( #7557 )
2019-05-16 14:37:37 +02:00
Joffrey JAFFEUX
1afe6d0aee
FIX: share-and-invite modal was too narrow ( #7559 )
2019-05-16 14:37:19 +02:00
Joffrey JAFFEUX
9ce9d72e71
DEV: makes hidepassed default when running qunit ( #7558 )
...
Mostly useful when not running headless, but I endup doing it a lot when debugging, one less thing to check.
2019-05-16 14:37:01 +02:00
Vinoth Kannan
0e677daaee
FIX: include posts with data-orig-src attribute in have_uploads scope query.
2019-05-16 16:39:38 +05:30
Vinoth Kannan
3172172b52
remove unused local variable
...
ec84c87ddb
2019-05-16 15:39:13 +05:30
Vinoth Kannan
ec84c87ddb
FIX: skip validation while recovering uploads from s3
...
TODO: add tests
2019-05-16 15:37:11 +05:30
Vinoth Kannan
56ada8374f
DEV: wrap find_missing_uploads method in distributed mutex
...
And skip posts with deleted topics.\ne8fafbc123170dd1f7d2a8adea4e7810585d3e76
2019-05-16 15:17:53 +05:30
Régis Hanol
a5a4f9dc1a
DEV: make prettier happy
...
(cc @jjaffeux)
2019-05-16 11:38:47 +02:00
Régis Hanol
d51a495dad
COPY: improve 'private_email' site setting description
2019-05-16 11:35:33 +02:00
Régis Hanol
5dd97d6d38
DEV: prevent already defined global warning
2019-05-16 11:32:10 +02:00
Joffrey JAFFEUX
4a9756ff3f
DEV: sets rack server to test env when using rake qunit:test ( #7554 )
2019-05-16 10:44:29 +02:00
Joffrey JAFFEUX
d47bf8b6c4
SECURITY: updates lodash from 1.3.0 to 4.17.5 ( #7546 )
2019-05-16 10:34:19 +02:00
Sam Saffron
cabc203885
Followup to a8fbb19e
...
Correct edge condition where no available names are found
- increase search space
- search for 10 extra names
2019-05-16 18:15:56 +10:00
Sam Saffron
a8fbb19e7c
FEATURE: allow a huge number of users to share common prefix
...
Previously username suggester would give up after 100 attempts at getting
a username and fallback to random string.
This amends the logic so we do all the work of figuring out a good username
in SQL and avoids a large amount of queries in cases where a lot of usernames
were used up.
This corrects an issue on sites with large numbers of anon users
2019-05-16 17:15:16 +10:00
Joffrey JAFFEUX
ea214b2b0c
DEV: logs tests exception when running qunit on headless chrome ( #7553 )
2019-05-16 08:48:08 +02:00
Guo Xiang Tan
a36fe019bb
DEV: Fix race condition when enqueuing edit wiki-ed notification.
2019-05-16 13:48:46 +08:00
Vinoth Kannan
636b75fa16
REFACTOR: remove duplicate reject loop and implicit return
...
e8fafbc123
2019-05-16 10:04:04 +05:30
Vinoth Kannan
40328f055e
FIX: retrieve original filename from s3 object's content disposition header
2019-05-16 09:47:22 +05:30
Guo Xiang Tan
227bedebf7
DEV: Fix modifying a frozen string.
2019-05-16 11:30:31 +08:00
Guo Xiang Tan
dd49be27d3
DEV: Fix undefined variable.
...
Follow up to e8fafbc123
.
2019-05-16 11:28:48 +08:00
Sam Saffron
76173dea87
DEV: ensure we never fork v8 contexts from unicorn
...
v8 forking is not supported and can lead to memory leaks.
This commit handles the most common case which is the unicorn master forking
There are still some cases related to backup where we fork, however those
forks are usually short lived so the memory leak is not severe, burning
the contexts in the master process could break sidekiq or web process that
do the actual forking
2019-05-16 09:50:34 +10:00
Kris
7cd1067f3d
FIX: Select-kit too narrow in topic timer
2019-05-15 17:58:40 -04:00
Orlando Del Aguila
2932b0e757
chore: bump ruby version in .ruby-version ( #7552 )
2019-05-15 23:47:51 +02:00
Régis Hanol
501bee56b7
Make prettier happy
2019-05-15 23:46:50 +02:00
Neil Lalonde
7eea55d564
PERF: remove "new posts" stat from summary email
...
It performs horribly and isn't a personalized stat like the others.
2019-05-15 16:28:21 -04:00
Régis Hanol
db89722a98
UX: ignore leading/trailing whitespaces in site settings search
2019-05-15 22:22:20 +02:00
Bianca Nenciu
b9fcb2bcdf
DEV: Add before button hook in post-menu. ( #7550 )
2019-05-15 22:48:23 +03:00
Kris
0ef25f7a66
prettier
2019-05-15 13:35:58 -04:00
Kris
a3f6c7d6af
REFACTOR: Remove table layout from modals, clean up styles ( #7549 )
2019-05-15 13:26:25 -04:00
Maja Komel
9a17b19636
FIX: don't hide back button at the bottom of timeline ( #7544 )
2019-05-15 19:02:48 +02:00
Penar Musaraj
fc5bb39096
FIX: Do not send duplicate alerts for the same post ( #7476 )
2019-05-15 18:47:36 +02:00
Régis Hanol
fd5c5e326f
FIX: remove full quote on direct replies when "typographed"
...
Use the cooked version of the post and the quote to compare their content in
order to take into account the "typographer" option of the markdown pipeline.
2019-05-15 17:49:29 +02:00
David Taylor
1299c94a52
FIX: Make serverside and clientside omniauth origin redirects consistent
...
Previously external domains were allowed in the client-side redirects, but not the server-side redirects. Now the behavior is to only allow local origins.
2019-05-15 12:40:51 +01:00
Régis Hanol
64e81f0549
FIX: ensure get_a_room
link starts with 'base_path translation
2019-05-15 12:41:38 +02:00
Régis Hanol
a0df676194
COPY: improve 'dominating_topic' and 'get_a_room' warnings
...
cf. https://meta.discourse.org/t/how-to-suppress-the-warning-that-a-user-is-contributing-too-much-to-a-topic/63249/9
2019-05-15 12:21:44 +02:00
Vinoth Kannan
be0555cc17
FIX: Add bucket folder path only if not exists
2019-05-15 15:37:40 +05:30
Bianca Nenciu
1d3375b176
FEATURE: Preserve notifications levels when splitting topics. ( #7494 )
2019-05-15 17:29:29 +10:00
Guo Xiang Tan
ab1684999c
DEV: Improve specs to use upload_s3
fabricator.
2019-05-15 08:42:17 +08:00
Vinoth Kannan
42b10a646d
FIX: return 404 only if upload url also not internal.
2019-05-15 02:06:54 +05:30
Maja Komel
e0fe01925e
FIX: make frozen string mutable in incoming_domain
2019-05-14 17:44:53 +02:00
David Taylor
33bd47164f
DEV: Re-enable uglifier for non-precompiled assets
...
Keep `harmony` disabled
2019-05-14 10:28:18 +01:00
David Taylor
f12709e24c
DEV: Temporarily disable uglifier for non-precompiled assets
...
This is causing performance issues which require further investigation
2019-05-14 09:34:38 +01:00
Sam Saffron
bbcc39e66c
FEATURE: update mini_racer to version including heap dump support
...
We recently noticed a leak, this introduces a new method on MiniRacer::Context
```
context.write_heap_snapshot(path)
```
To dump current memory in v8 context to a file, this can then be analyzed
in chrome and other similar tools
Can be triggered in production using rbtrace
2019-05-14 18:01:15 +10:00