4 Commits

Author	SHA1	Message	Date
Martin Brennan	df4197c8b8	FIX: Show deleted bookmark reminders in user bookmarks menu (#25905) ... When we send a bookmark reminder, there is an option to delete the underlying bookmark. The Notification record stays around. However, if you want to filter your notifications user menu to only bookmark-based notifications, we were not showing unread bookmark notifications for deleted bookmarks. This commit fixes the issue _going forward_ by adding the bookmarkable_id and bookmarkable_type to the Notification data, so we can look up the underlying Post/Topic/Chat::Message for a deleted bookmark and check user access in this way. Then, it doesn't matter if the bookmark was deleted.	2024-02-29 09:03:49 +10:00
David Taylor	cb932d6ee1	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
Phil Pirozhkov	493d437e79	Add RSpec 4 compatibility (#17652) ... * Remove outdated option 04078317ba * Use the non-globally exposed RSpec syntax https://github.com/rspec/rspec-core/pull/2803 * Use the non-globally exposed RSpec syntax, cont https://github.com/rspec/rspec-core/pull/2803 * Comply to strict predicate matchers See: - https://github.com/rspec/rspec-expectations/pull/1195 - https://github.com/rspec/rspec-expectations/pull/1196 - https://github.com/rspec/rspec-expectations/pull/1277	2022-07-28 10:27:38 +08:00
Martin Brennan	0ca1152c1c	DEV: Add bookmark_id to bookmark reminder_handler notifications (#17547) ... This is so we can join the Notification table onto the Bookmark table. A slight refactor was needed to ensure that the required values are always included and the consumer does not need to think about this. The discourse-chat and discourse-data-explorer plugins will be updated to take advantage of this commit.	2022-07-18 12:51:57 +10:00