Robin Ward
c2e58b6b85
FIX: Don't remove the topic image if posts don't have them
2020-02-13 14:00:30 -05:00
dependabot-preview[bot]
4b46db6ea8
Build(deps-dev): Bump webmock from 3.8.1 to 3.8.2 ( #8951 )
...
Bumps [webmock](https://github.com/bblimke/webmock ) from 3.8.1 to 3.8.2.
- [Release notes](https://github.com/bblimke/webmock/releases )
- [Changelog](https://github.com/bblimke/webmock/blob/master/CHANGELOG.md )
- [Commits](https://github.com/bblimke/webmock/compare/v3.8.1...v3.8.2 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-02-13 12:32:02 -05:00
Gerhard Schlager
a7efca1fa9
DEV: Remove unused "search help"
2020-02-13 18:31:21 +01:00
David Taylor
8d50f092b5
DEV: Use classes for styling user and group cards ( #8913 )
...
Styling based on element-ids, it is impossible for themes/plugins to display multiple cards on a single page. Using classes is a more flexible approach. The element-ids are maintained for backwards compatibility with existing plugins/themes.
2020-02-13 09:58:17 +00:00
Joffrey JAFFEUX
3875785dcc
FIX: ensures shortcuts work correctly with topic-notifications-button ( #8956 )
2020-02-13 10:01:28 +01:00
Joffrey JAFFEUX
42bda52486
FIX: ensures select-kit can select a row with 0 as value ( #8955 )
2020-02-13 09:04:32 +01:00
Martin Brennan
e1e74abd4f
FEATURE: Improving bookmarks part 2 -- Topic Bookmarking ( #8954 )
...
### UI Changes
If `SiteSetting.enable_bookmarks_with_reminders` is enabled:
* Clicking "Bookmark" on a topic will create a new Bookmark record instead of a post + user action
* Clicking "Clear Bookmarks" on a topic will delete all the new Bookmark records on a topic
* The topic bookmark buttons control the post bookmark flags correctly and vice-versa
Disabled selecting the "reminder type" for bookmarks in the UI because the backend functionality is not done yet (of sending users notifications etc.)
### Other Changes
* Added delete bookmark route (but no UI yet)
* Added a rake task to sync the old PostAction bookmarks to the new Bookmark table, which can be run as many times as we want for a site (it will not create duplicates).
2020-02-13 16:26:02 +10:00
Kris
e7c4ebc6d5
Fix styling for topic count in category chooser
2020-02-12 22:19:00 -05:00
Dan Dascalescu
b2ac80593e
Fix run-on sentence ( #8953 )
2020-02-12 18:13:38 -08:00
Blake Erickson
965ac3567b
FIX: Handle SSO Provider Parse exception
...
Prevent unnecessary 500 errors from appearing in the logs and return a
422 response instead.
2020-02-12 16:08:04 -07:00
Michael Brown
904bbdb307
DOCS: Clarify what a DNS "A record" is with a link
...
* context: https://meta.discourse.org/t/-/141250/6
2020-02-12 16:50:56 -05:00
Gerhard Schlager
33728035c7
DEV: Add configuration file for Crowdin
2020-02-12 22:45:17 +01:00
Penar Musaraj
efa9ba4975
UX: Prevent category-drop topic count from wrapping to new line ( #8943 )
2020-02-12 14:34:16 -05:00
Artem Vasiliev
c36ae17260
FEATURE: export defaultRenderTag function ( #8941 )
...
* FEATURE: export defaultRenderTag function
This can be helpful for plugins e.g. when combined with replaceTagRenderer: a plugin may want to customize rendering for some tags and let others be rendered with default code
* refactor: don't change version
..as per review comment, https://github.com/discourse/discourse/pull/8941#discussion_r378406809
2020-02-12 14:26:04 -05:00
Robin Ward
726d97b29d
FIX: Linking to a category via hashtag had a broken URL.
2020-02-12 14:23:09 -05:00
Penar Musaraj
a791b67e66
UX: Use border-box sizing on SK2 dropdowns
2020-02-12 14:14:36 -05:00
Arpit Jalan
3bcd1485f7
UX: show all parent categories for destination topic
2020-02-13 00:34:02 +05:30
dependabot-preview[bot]
08f1866152
Build(deps-dev): Bump simplecov from 0.18.1 to 0.18.2 ( #8945 )
...
Bumps [simplecov](https://github.com/colszowka/simplecov ) from 0.18.1 to 0.18.2.
- [Release notes](https://github.com/colszowka/simplecov/releases )
- [Changelog](https://github.com/colszowka/simplecov/blob/master/CHANGELOG.md )
- [Commits](https://github.com/colszowka/simplecov/compare/v0.18.1...v0.18.2 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-02-12 13:51:21 -05:00
Mark VanLandingham
c0ccfdb45e
FIX: Correctly compile theme template overrides ( #8946 )
2020-02-12 10:45:53 -08:00
Dan Ungureanu
82c84c5141
PERF: Memoize PostRevisor#diff_size ( #8939 )
...
Although this method is usually called twice, its execution can take
about 1s.
2020-02-12 19:47:48 +02:00
Vinoth Kannan
9c96511ec4
FIX: use plain text if available instead of image upload.
...
Previously, while pasting from Excel 365 it uploaded a table image instead of markdown table.
2020-02-12 23:13:51 +05:30
Penar Musaraj
52fe5b938c
FIX: Regression with wizard canvas elements
2020-02-12 12:31:15 -05:00
Gerhard Schlager
453bec9394
FEATURE: Add small action post to indicate forwarded email
...
This happens only when the sender of the email didn't write anything in their email.
2020-02-12 16:23:17 +01:00
Gerhard Schlager
0adab26e45
FIX: Don't count ignored, missing uploads in migration to S3
2020-02-12 16:18:52 +01:00
dependabot-preview[bot]
fb2fad4811
Build(deps): Bump concurrent-ruby from 1.1.5 to 1.1.6 ( #8930 )
...
Bumps [concurrent-ruby](https://github.com/ruby-concurrency/concurrent-ruby ) from 1.1.5 to 1.1.6.
- [Release notes](https://github.com/ruby-concurrency/concurrent-ruby/releases )
- [Changelog](https://github.com/ruby-concurrency/concurrent-ruby/blob/master/CHANGELOG.md )
- [Commits](https://github.com/ruby-concurrency/concurrent-ruby/compare/v1.1.5...v1.1.6 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Co-authored-by: Robin Ward <robin.ward@gmail.com>
2020-02-12 10:11:31 -05:00
Mark VanLandingham
0772a4338b
FIX: Remove pie draw animation ( #8940 )
2020-02-12 07:09:40 -08:00
dependabot-preview[bot]
86bbc844fa
Build(deps-dev): Bump test-prof from 0.11.2 to 0.11.3 ( #8931 )
...
Bumps [test-prof](https://github.com/palkan/test-prof ) from 0.11.2 to 0.11.3.
- [Release notes](https://github.com/palkan/test-prof/releases )
- [Changelog](https://github.com/palkan/test-prof/blob/master/CHANGELOG.md )
- [Commits](https://github.com/palkan/test-prof/compare/v0.11.2...v0.11.3 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Co-authored-by: Régis Hanol <regis@hanol.fr>
2020-02-12 09:38:32 -05:00
Dan Ungureanu
8e27fa1bd8
PERF: Optimize post editing
...
Reordering the conditions reduced the execution time by a factor of 5.
2020-02-12 15:53:28 +02:00
Dan Ungureanu
67c9940d72
FIX: Avoid highlight mention to groups that are not public.
...
Follow-up to 3f50481188
.
2020-02-12 13:04:40 +02:00
Dan Ungureanu
ec40242b5c
FIX: Make inline oneboxes work with secured topics in secured contexts ( #8895 )
2020-02-12 12:11:28 +02:00
David Taylor
d7d4612b2d
FIX: Subfolder sites rewriting URLs to root domain on initial load ( #8932 )
...
The `DiscourseLocation.initState` function was accidently renamed in 0431942f
(select-kit-2) to `initOptions`. This means that the ember router does not automatically call the function after the router is initialized.
For a long time, we have been calling the `initState` function in the `init` function of discourse-location, which caused an imperceptible URL change to the the root domain, before switching back to the correct subfolder URL when ember called `initState`. This commit removes that call from the initializer, so `initState` is only called once (by ember).
Relevant ember code: https://github.com/emberjs/ember.js/blob/v3.12.2/packages/@ember/-internals/routing/lib/system/router.ts#L695-L699
2020-02-12 09:36:46 +00:00
Joffrey JAFFEUX
47f255f62c
FIX: date was not mutated when changing it in change-timestamp modal ( #8935 )
2020-02-12 09:12:36 +01:00
Dan Ungureanu
3f50481188
Improvements to group mentions ( #8927 )
...
* FIX: Avoid highlight mention to groups that are not public
* UX: Composer autocomplete will suggest all visible group names
2020-02-12 10:11:10 +02:00
Joffrey JAFFEUX
fc3d547268
UX: do not enlarge emojis in polls ( #8934 )
2020-02-12 08:37:32 +01:00
Arpit Jalan
7ef754759e
UX: show destination topic status when moving post(s) to an existing topic
2020-02-12 11:32:40 +05:30
Kris
e69ffa86b3
Fix test another way
2020-02-11 17:07:18 -05:00
Kris
5e6f0d9f1c
Fix test
2020-02-11 16:09:41 -05:00
Kris
e6e5ce3c54
FIX: Don't use theme colors for digest unsubscribe footer links
2020-02-11 15:52:38 -05:00
dependabot-preview[bot]
747fa94853
Build(deps-dev): Bump test-prof from 0.11.1 to 0.11.2 ( #8929 )
...
Bumps [test-prof](https://github.com/palkan/test-prof ) from 0.11.1 to 0.11.2.
- [Release notes](https://github.com/palkan/test-prof/releases )
- [Changelog](https://github.com/palkan/test-prof/blob/master/CHANGELOG.md )
- [Commits](https://github.com/palkan/test-prof/compare/v0.11.1...v0.11.2 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-02-11 15:43:21 -05:00
Kris
d73e94bbeb
UX: Update mobile site setting slide-out nav for RTL
2020-02-11 15:23:12 -05:00
Joffrey JAFFEUX
adbff5835d
FIX: correctly excludes current user in user-chooser ( #8928 )
2020-02-11 20:41:18 +01:00
Mark VanLandingham
3e89774908
DEV: Use .hbr for raw template file extension ( #8883 )
2020-02-11 13:38:12 -06:00
Joffrey JAFFEUX
78a0ca53bf
FIX: makes user-selector use real booleans ( #8909 )
2020-02-11 20:20:12 +01:00
Kris
567b7263fd
UX: mobile layout fix for claimable reviewables
2020-02-11 14:18:42 -05:00
Penar Musaraj
30b7006ca2
DEV: Eliminate "post bounce" after creating a post
...
Fix has two parts:
a) skips jumping to post if post is in view
b) debounces layout calculation when composer changes state
2020-02-11 14:04:46 -05:00
Roman Rizzi
3413ec0a5c
FEATURE: Pending queued posts are included even if they don't pass the minimum priority threshold ( #8925 )
2020-02-11 15:29:22 -03:00
David Taylor
e32833cf1a
DEV: Make badge test resilient to disabled badges
...
This can happen when plugins seed disabled badges in the database
2020-02-11 18:01:33 +00:00
Vinoth Kannan
b0f72ca1d6
DEV: improve the code readability.
...
a0e0b1ef4b
2020-02-11 23:11:59 +05:30
Joffrey JAFFEUX
6a7e82c44c
DEV: Apply rubocop ( #8926 )
2020-02-11 16:21:03 +00:00
Mark VanLandingham
daaa0a657f
FIX: Render HTML for pie chart options ( #8912 )
2020-02-11 10:02:54 -06:00