Joffrey JAFFEUX
c6bf552ca3
FIX: title should attempt to fallback to label before name ( #9739 )
2020-05-11 18:42:18 +02:00
Jarek Radosz
7d3c4a5f13
FIX: Show category name in badge preview on edit ( #9726 )
2020-05-11 17:05:40 +02:00
Jarek Radosz
a2bb33b6d7
REFACTOR: Remove an unused Topic model observer ( #9723 )
...
As far I can tell nothing sets categoryName on the Topic model. Didn't find anything in all-the-plugins/all-the-themes either.
2020-05-11 17:05:05 +02:00
Mark VanLandingham
89c6f697b8
DEV: Plugin outlet after save or cancel composer buttons ( #9725 )
2020-05-11 09:23:36 -05:00
Sam Saffron
77f5bb1419
FIX: stop clearing title by mistake
...
b180e6e737
2020-05-11 19:07:32 +10:00
Guo Xiang Tan
a3a464b838
DEV: Improve description of addPosterIcon plugin api.
2020-05-11 16:44:47 +08:00
Sam Saffron
b180e6e737
FIX: default to blank title on open
...
In production `title` was set to undefined causing a
discrepancy between originalTitle and title
This attempts to work around the issue in the production bundle
2020-05-11 18:36:09 +10:00
Martin Brennan
29842e682b
FIX: Resolve issues with Next Monday for bookmarks not working in certain locales ( #9737 )
...
In moment.js the .day() function can accept a day string but this is locale based, so e.g. in Finnish locale the string "Monday" means nothing and will parse incorrectly to Sunday. To resolve this we always use the moment.js number for the day of the week we want.
2020-05-11 13:59:14 +10:00
Martin Brennan
12d4d51d81
FIX: CurrentUser now must be passed to resolveTimezone and user card local time issues ( #9734 )
...
* This is to prevent user's timezones being changed accidentally
e.g. by admin looking at a user
* This problem only occurred via the user card, however the user card
was still calling userTimezone even if the setting to display user
time in card was disabled
2020-05-11 11:01:47 +10:00
Sam Saffron
44712c5f98
FIX: ESC to dismiss empty draft topic composer
...
Previously originalTitle was set to undefined leading to
titleDirty being unconditionally undefined for new topics
That mean you could not dismiss the composer via ESC
2020-05-11 10:04:38 +10:00
Bianca Nenciu
8149bfbaf1
FEATURE: Filter settings by plugin ( #9692 )
2020-05-10 14:07:45 +03:00
Joffrey JAFFEUX
3b2b635e9b
DEV: removes setInterval as it might cause issues ( #9722 )
2020-05-10 08:57:48 +02:00
Joffrey JAFFEUX
862d153f54
REFACTOR: removes dead code ( #9721 )
2020-05-09 11:50:47 +02:00
Joffrey JAFFEUX
9bf11a8c68
DEV: allows select-kit to prevent autofocus of header after onChange ( #9718 )
2020-05-09 10:26:23 +02:00
Penar Musaraj
d653d2f5d9
UX: Prevent timeline overlapping topic footer buttons
2020-05-08 16:20:27 -04:00
Robin Ward
34e5f807ec
DEV: User UPPER_CASE for constants
2020-05-08 15:50:55 -04:00
Mark VanLandingham
da561a430d
DEV: Add data-name to popular-theme-item rows ( #9714 )
2020-05-08 14:38:41 -05:00
Joffrey JAFFEUX
5bac2828ee
DEV: 25ms was too short and causing test failures ( #9712 )
2020-05-08 21:10:52 +02:00
Robin Ward
7f373e8b93
DEV: Don't use js.erb for constants
...
Adds a new rake task to auto generate a constants.js file with the
constants present. This makes migrating to Ember CLI easier, but also
slightly speeds up asset compilation by having to do less work.
If the constants change you need to run:
`rake javascripts:update_constants`
2020-05-08 14:14:01 -04:00
Jordan Vidrine
47788da706
FIX: Bookmark Modal Input ( #9707 )
2020-05-08 17:47:01 +02:00
Joffrey JAFFEUX
350fe932ca
DEV: removes setTimeout and reduces timer in tests ( #9701 )
2020-05-08 16:46:24 +02:00
Joffrey JAFFEUX
646bee2efe
DEV: removes a setTimeout and ensure shorcut is not propagated ( #9702 )
2020-05-08 16:46:13 +02:00
Dax74
e46bf15407
FIX: some adjustment for the UI of the table
2020-05-08 16:39:31 +02:00
Joffrey JAFFEUX
8d3900c6da
DEV: gear icon is deprecated in favor of cog ( #9704 )
2020-05-08 10:35:29 +02:00
Joffrey JAFFEUX
00a038d646
REFACTOR: removes various assignments and superfluous params ( #9699 )
2020-05-08 09:19:48 +02:00
Joffrey JAFFEUX
9d172eeaa5
REFACTOR: removes implicit operand conversion ( #9700 )
2020-05-08 09:19:36 +02:00
Kris
1840023c28
UX: Improve banner & alert close button alignment and consistency
2020-05-07 22:57:52 -04:00
Robin Ward
ef94b0f1a7
FIX: Incorrect CSS class
2020-05-07 16:29:09 -04:00
Kris
94d10b46ca
Admin popup menu needs a higher z-index than the bg cloak on mobile
2020-05-07 16:24:47 -04:00
Robin Ward
f9608c0af5
DEV: Remove INLINE_ONEBOX_* constants
...
There were two constants here, `INLINE_ONEBOX_LOADING_CSS_CLASS` and
`INLINE_ONEBOX_CSS_CLASS` that were both longer than the strings they
were DRYing up: `inline-onebox-loading` and `inline-onebox`
I normally appreciate constants, but in this case it meant that we had
a lot of JS imports resulting in many more lines of code (and CPU cycles
spent figuring them out.)
It also meant we had an `.erb` file and had to invoke Ruby to create the
JS file, which meant the app was harder to port to Ember CLI.
I removed the constants. It's less DRY but faster and simpler, and
arguably the loss of DRYness is not significant as you can still search
for the `inline-onebox-loading` and `inline-onebox` strings easily if
you are refactoring.
2020-05-07 16:14:38 -04:00
Robin Ward
3567a90661
DEV: Ember Addon needs a vendor dir
2020-05-07 15:45:35 -04:00
Dax74
4891276742
Reduce the width of the input field on desktop
2020-05-07 20:36:36 +02:00
Joffrey JAFFEUX
788e305469
FIX: parenthesis were wrong, resulting in an always true expression ( #9690 )
2020-05-07 19:56:35 +02:00
Robin Ward
79c64eaeff
DEV: Move pretty-text into an ember-addon format ( #9689 )
2020-05-07 12:37:47 -04:00
Joffrey JAFFEUX
3cd412ae02
REFACTOR: removes useless variable assignment ( #9666 )
2020-05-07 16:41:26 +02:00
Joffrey JAFFEUX
1dd9df9cd0
REFACTOR: removes overwritten properties and duplicates fn ( #9686 )
2020-05-07 16:39:53 +02:00
Joffrey JAFFEUX
265baa40c6
REFACTOR: useless conditional as 'data' always evaluates to true ( #9685 )
2020-05-07 16:38:38 +02:00
Joffrey JAFFEUX
99c3ce03cb
REFACTOR: removes superfluous argument ( #9684 )
...
hideTooltip doesnt accept any argument
2020-05-07 16:38:23 +02:00
Joffrey JAFFEUX
206d45fd96
REFACTOR: removes superfluous argument ( #9683 )
2020-05-07 16:38:09 +02:00
Joffrey JAFFEUX
9846c43d93
REFACTOR: removes use of undeclared variable ( #9682 )
2020-05-07 16:37:56 +02:00
Joffrey JAFFEUX
af78d188b8
REFACTOR: removes useless self assignment ( #9681 )
2020-05-07 16:37:20 +02:00
Joffrey JAFFEUX
8be0ba3aa4
REFACTOR: function was incorrectly called as a constructor ( #9679 )
2020-05-07 16:36:29 +02:00
Joffrey JAFFEUX
e74170cd9e
REFACTOR: Superfluous arguments passed to function resolveSize ( #9678 )
...
resolveSize accepts only one param
2020-05-07 16:36:15 +02:00
Joffrey JAFFEUX
affc79bb68
REFACTOR: removes useless assignment to local variable ( #9676 )
2020-05-07 16:35:54 +02:00
Joffrey JAFFEUX
08e8ae82cc
REFACTOR: removes useless conditional ( #9677 )
2020-05-07 16:34:49 +02:00
Joffrey JAFFEUX
a078b086ba
REFACToR: removes useless assignment to local variable ( #9675 )
2020-05-07 16:34:36 +02:00
Joffrey JAFFEUX
a04b226c2b
REFACTOR: removes useless conditional ( #9674 )
...
We already check if there's a post in the line before.
2020-05-07 16:34:25 +02:00
Joffrey JAFFEUX
d5fe1279bd
REFACTOR: value assigned to precision here is unused ( #9673 )
2020-05-07 16:34:14 +02:00
Joffrey JAFFEUX
a2109bd9b2
REFACTOR: value assigned to cp here is unused. ( #9672 )
2020-05-07 16:30:51 +02:00
Joffrey JAFFEUX
930989d462
REFACTOR: variable '_postSnapshot' always evaluates to true ( #9671 )
2020-05-07 16:28:28 +02:00
