Joffrey JAFFEUX
9d172eeaa5
REFACTOR: removes implicit operand conversion ( #9700 )
2020-05-08 09:19:36 +02:00
Joffrey JAFFEUX
3cd412ae02
REFACTOR: removes useless variable assignment ( #9666 )
2020-05-07 16:41:26 +02:00
Joffrey JAFFEUX
930989d462
REFACTOR: variable '_postSnapshot' always evaluates to true ( #9671 )
2020-05-07 16:28:28 +02:00
Joffrey JAFFEUX
5a201082c7
REFACTOR: removes useless conditional ( #9667 )
...
This use of variable 'content' always evaluates to true.
2020-05-07 16:25:44 +02:00
Joffrey JAFFEUX
87b1d435d2
FIX: improves positioning of sk in mobile when inside a modal ( #9657 )
2020-05-07 09:10:29 +02:00
Joffrey JAFFEUX
c99ecba68f
DEV: improves sk api ( #9653 )
...
- reduces the API to 3 actions for now: appendContent/prependContent/onChange
- well tested
- removes all previous APIS which were only half supported or too dangerous as they could collide with other plugins or core behaviors
- this plugins also puts every sk test helpers in one file
2020-05-06 17:16:20 +02:00
Joffrey JAFFEUX
6b14a0f352
FIX: apply sameWidth from 450px screen width
2020-05-05 13:01:02 +02:00
Joffrey JAFFEUX
bd0abddf6f
UX: attempts to have a better use of available space with sk ( #9639 )
2020-05-05 12:59:47 +02:00
Joffrey JAFFEUX
5e9c96dfed
REFACTOR: minor tweaks to user's notifications-filter ( #9623 )
2020-05-04 09:09:13 +02:00
Ahmed Gagan
99abdf51cd
FEATURE: adds a filter for all/unread/read on user's notifications page ( #9535 )
2020-05-04 08:36:59 +02:00
Joffrey JAFFEUX
07e6452759
FIX: makes tracking shortcuts working when tracking button is not visible ( #9575 )
2020-04-28 20:12:16 +02:00
Joffrey JAFFEUX
a8308e73e7
FIX: improves tag-list setting ( #9574 )
...
- Prevents setting to display an empty tag
- Updates dropdown when selecting/removing tag
2020-04-28 20:05:30 +02:00
Joffrey JAFFEUX
d83f39be73
DEV: replaces jquery scrollTop by vanilla js code ( #9543 )
2020-04-24 12:45:47 +02:00
Joffrey JAFFEUX
b871e79c5b
FIX: removes rounding correction as it can be in either direction ( #9538 )
2020-04-23 23:10:40 +02:00
Joffrey JAFFEUX
3bbd8b1258
UX: rework date time input range ( #9524 )
2020-04-22 22:17:53 +02:00
Joffrey JAFFEUX
00f632fb0d
REFACTOR: s/translatedfilterPlaceholder/translatedFilterPlaceholder ( #9521 )
2020-04-22 20:39:55 +02:00
Joffrey JAFFEUX
4c248fc5c4
UX: do not attempt to full width sk on mobile ( #9520 )
2020-04-22 20:39:45 +02:00
Joffrey JAFFEUX
4889dbde49
FIX: differentiate sk outline handling on single/multi ( #9512 )
2020-04-22 13:02:20 +02:00
Joffrey JAFFEUX
5c45363e67
UX: better outline support in sk components ( #9510 )
2020-04-22 10:54:02 +02:00
Joffrey JAFFEUX
62459c845f
DEV: allows a sk component to stop click propagation ( #9495 )
2020-04-21 17:11:40 +02:00
Joffrey JAFFEUX
79058a6d99
DEV: makes sk scroll to current selection ( #9492 )
2020-04-21 16:48:49 +02:00
Joffrey JAFFEUX
4f834f0008
DEV: allows click to propagate outside of header but not outside of sk ( #9491 )
2020-04-21 16:20:05 +02:00
Roman Rizzi
35f51100e1
FEATURE: Users can be ignored for six months. ( #9446 )
2020-04-17 10:27:11 -03:00
Joffrey JAFFEUX
5a8a844e4e
FIX: attempts to listen more reliably to scopedCategoryId changes ( #9431 )
2020-04-15 19:59:27 +02:00
Joffrey JAFFEUX
c4644c61d9
DEV: enforces double quotes ember-template-lint ( #9416 )
2020-04-14 08:18:49 +02:00
Joffrey JAFFEUX
b66b277dc4
DEV: enforces block-indentation of ember-template-lint rules ( #9408 )
2020-04-13 17:17:20 +02:00
Joffrey JAFFEUX
a947b7b839
FIX: prevents registering multiple topic-notifications-button:changed ( #9356 )
...
A large topic page will always have the bottom tracking button, and will also have the timeline, meaning we already had 2 tracking events.
But it gets even worse when you know that the timeline button is a component connector which will trigger `didInsertElement` very frequently, meaning we were constantly adding more and more appEvents handlers.
2020-04-06 15:06:26 +02:00
Joffrey JAFFEUX
883901e4c0
FIX: do not attempt to deselect tags if filter is not empty ( #9345 )
2020-04-03 16:27:56 +02:00
Sam Saffron
cade4957ae
DEV: don't use _ cause property is observed
...
Followup on fcc5ef96
2020-04-02 10:22:13 +11:00
Sam Saffron
b8d2261db9
FIX: correctly load drafts based of id
...
Previously we relied on race conditions to correctly open a draft, so this
broke.
New code is deliberate.
Also corrects missing observers on composer action
2020-04-01 14:23:26 +11:00
Sam Saffron
fcc5ef9625
FIX: when switching reply type update options
...
Previously we were not correctly updating reply types leading to inconsistent
behavior when using drop down in composer (for reply type)
2020-03-31 14:40:57 +11:00
Joffrey JAFFEUX
fa5ba6beb8
FIX: ensures mini-tag-chooser display min tags req if no selection ( #9303 )
2020-03-30 19:34:53 +02:00
Vinoth Kannan
dbc323e12a
Fix the typo.
2020-03-25 23:32:32 +05:30
Robin Ward
07813c4a91
Convert select-kit from es6 to js ( #9246 )
...
* Convert select-kit from es6 to js
* Hide more git blames
2020-03-20 12:40:32 -04:00
Vinoth Kannan
aad12822b7
FEATURE: automatically delete replies on a topic after N days. ( #9209 )
2020-03-19 21:06:31 +05:30
Joffrey JAFFEUX
b727e39a42
DEV: gives sk components a way to trigger a search manually ( #9199 )
2020-03-13 12:41:08 +01:00
Joffrey JAFFEUX
683cb28099
DEV: enforces ember-template-lint: no-triple-curlies ( #9165 )
...
This pr replaces `{{{ }}}` usage by a {{html-safe}} helper. While it doesn't solve the underlying issue, it gives us a path forward without risking breaking too much existing behavior.
Also introduces an htmlSafe computed macro:
```
import { htmlSafe } from "discourse/lib/computed";
htmlDescription: htmlSafe("description")
```
Overtime {{html-safe}} usage should be removed and moved to components properties or specialized components/helpers.
2020-03-11 09:23:10 +01:00
Joffrey JAFFEUX
e848d98782
FIX: ensures category exists for hideParent in categoryBadgeHTML ( #9161 )
2020-03-11 00:58:46 +01:00
romanrizzi
f795c1b8e8
Revert "DEV: enforces ember-template-lint: no-triple-curlies ( #9150 )"
...
This reverts commit d436b600fb
2020-03-10 15:00:12 -03:00
Joffrey JAFFEUX
3f2c0b42fe
FIX: throttles topic tracking shortcut and enforces topic id ( #9159 )
2020-03-10 17:17:54 +01:00
Joffrey JAFFEUX
d436b600fb
DEV: enforces ember-template-lint: no-triple-curlies ( #9150 )
...
This pr replaces `{{{ }}}` usage by a {{html-safe}} helper. While it doesn't solve the underlying issue, it gives us a path forward without risking breaking too much existing behavior.
Also introduces an htmlSafe computed macro:
```
import { htmlSafe } from "discourse/lib/computed";
htmlDescription: htmlSafe("description")
```
Overtime {{html-safe}} usage should be removed and moved to components properties or specialized components/helpers.
2020-03-10 16:46:57 +01:00
Joffrey JAFFEUX
020c1b9cf3
FIX: correctly checks if component is in modal ( #9157 )
2020-03-10 12:22:56 +01:00
Joffrey JAFFEUX
78a6b76310
FIX: ensures pinned-options header is showing correct state ( #9156 )
2020-03-10 09:56:55 +01:00
Jarek Radosz
5037b80c9c
Merge imports from the same module ( #9144 )
2020-03-09 17:38:37 +01:00
Joffrey JAFFEUX
4f37233208
DEV: enforces ember-template-lint: simple-unless ( #9146 )
2020-03-09 13:44:34 +01:00
Jarek Radosz
48ba65f406
DEV: Clean up Ember imports ( #8979 )
...
Includes:
* Import `computed` helpers
* Import `@ember/application`
* Import `isBlank` from `@ember/utils`
* Import `A` from `@ember/array`
* Import `EmberArray` from `@ember/array`
* Import `ArrayProxy` from `@ember/array/proxy`
* Import `warn` from `@ember/debug`
* Import `EmberObject` from `@ember/object`
* Import `Application` from `@ember/application`
* Import `EmberRouter` from `@ember/routing/router`
* Import `isPresent` from `@ember/utils`
* Import `computed` from `@ember/object`
* Import `guidFor` from `@ember/object`
* Import `isArray` from `@ember/array`
* Import `TextField` from `@ember/component`
* Import `TextArea` from `@ember/component`
* Import `Promise` from `rsvp`
* Import `Evented` from `@ember/object/evented`
* Replace deprecated `ember-addons/ember-computed-decorators` imports
2020-03-06 23:49:28 +01:00
Joffrey JAFFEUX
bb5990781e
FIX: allows to define placement strategy of select-kit body ( #9109 )
2020-03-06 20:27:33 +01:00
Joffrey JAFFEUX
29c9d8a133
FIX: uses only global allow_uncategorized_topics for category drop ( #9130 )
2020-03-06 20:11:21 +01:00
Joffrey JAFFEUX
ed85cfe141
FIX: prevents click on sk header to bubble ( #9084 )
2020-03-02 20:06:02 +01:00
Joffrey JAFFEUX
2db8ada222
FIX: ensures category url of category drop is built using slug and id ( #9069 )
2020-02-28 17:58:22 +01:00
Joffrey JAFFEUX
501936f0da
FIX: prevents loading to show during debouncing ( #9060 )
...
This will also fix a bug in IE11 where click event would not be triggered on row
2020-02-27 15:20:04 +01:00
Joffrey JAFFEUX
56345faf9a
FIX: prevents row click event to be caught by filter input event ( #9059 )
...
This was causing some dropdowns to not work under IE11
2020-02-27 14:04:23 +01:00
Penar Musaraj
d6a603cc50
FIX: Translate none-tag and all-tags labels in tag filter ( #9030 )
...
* FIX: Translate none-tag and all-tags labels in tag filter
* Add test
2020-02-25 07:57:24 +11:00
Joffrey JAFFEUX
f336aeee6f
FIX: ensures scoped search category is searching in all categories ( #9031 )
2020-02-24 19:19:53 +01:00
Joffrey JAFFEUX
0b0290cddb
FIX: muted was not working in topic timeline ( #9021 )
2020-02-21 21:32:58 +01:00
Joffrey JAFFEUX
e807dff6fc
FIX: ensures mini-tag-chooser is respecting max_tags_per_topic ( #9018 )
2020-02-21 12:16:05 +01:00
Jarek Radosz
9f8a27a132
DEV: Import makeArray from discourse-common instead using Ember global ( #8977 )
2020-02-19 00:57:58 +01:00
Joffrey JAFFEUX
25ebfd5998
DEV: allows to import isPresent ( #8993 )
2020-02-18 23:41:15 +01:00
Joffrey JAFFEUX
67ee79f023
FIX: group members dropdown was broken on mobile ( #8994 )
2020-02-18 23:23:38 +01:00
Vinoth Kannan
2e397c78c4
FIX: use separate site attribute for single category "top tags" list.
...
And use it only in the single category pages.
38dd184a16
2020-02-17 21:09:27 +05:30
David Taylor
f1f9648e88
Revert "FIX: sk body should follow wrapper width ( #8984 )"
...
This was causing very narrow dropdowns in the composer and notification level dropdowns.
This reverts commit d33aaa0292
2020-02-17 13:10:26 +00:00
Joffrey JAFFEUX
d33aaa0292
FIX: sk body should follow wrapper width ( #8984 )
2020-02-17 10:39:20 +01:00
Joffrey JAFFEUX
9feace3388
FIX: prevents error when loading tag groups ( #8983 )
2020-02-17 10:39:04 +01:00
Joffrey JAFFEUX
7d94de6439
FIX: brings back castInteger as a safer migration path for sk2 ( #8966 )
2020-02-14 10:00:39 +01:00
Joffrey JAFFEUX
3875785dcc
FIX: ensures shortcuts work correctly with topic-notifications-button ( #8956 )
2020-02-13 10:01:28 +01:00
Joffrey JAFFEUX
42bda52486
FIX: ensures select-kit can select a row with 0 as value ( #8955 )
2020-02-13 09:04:32 +01:00
Penar Musaraj
efa9ba4975
UX: Prevent category-drop topic count from wrapping to new line ( #8943 )
2020-02-12 14:34:16 -05:00
Joffrey JAFFEUX
adbff5835d
FIX: correctly excludes current user in user-chooser ( #8928 )
2020-02-11 20:41:18 +01:00
Joffrey JAFFEUX
9d50e1b40f
DEV: introducing user-chooser ( #8910 )
2020-02-11 15:54:56 +01:00
Joffrey JAFFEUX
99ad2e408a
DEV: enforces style-concatenation linting rule ( #8888 )
2020-02-10 08:13:50 +01:00
Joffrey JAFFEUX
252989e261
DEV: better detection of new item ( #8889 )
2020-02-07 14:12:17 +01:00
Joffrey JAFFEUX
a0bf2ac313
DEV: applies valueAttribute deprecation when null ( #8887 )
2020-02-07 10:39:39 +01:00
Joffrey JAFFEUX
d86ed028c7
FIX: ensure s2 is working with wizard ( #8886 )
2020-02-07 10:00:39 +01:00
Joffrey JAFFEUX
6bee972a5c
FIX: corrects min/max logic for mini-tag-chooser ( #8871 )
2020-02-05 17:47:20 +01:00
Penar Musaraj
6253ddc74e
DEV: Do not trigger missing icon warning in icon picker
2020-02-05 11:39:46 -05:00
Mark VanLandingham
499b57a9ed
DEV: Ember linting - disallow Ember.* variable usage ( #8782 )
2020-02-05 10:14:42 -06:00
Joffrey JAFFEUX
98303ee645
FIX: simplify maximum/minimum logic in sk2 to avoid chicken/egg ( #8868 )
2020-02-05 16:01:58 +01:00
Joffrey JAFFEUX
d7dffbb13c
UX: caches icon picker full icon's list ( #8862 )
2020-02-05 09:22:11 +01:00
Joffrey JAFFEUX
f0fe2ba9ac
UX: introduces icon-picker component for badges ( #8844 )
2020-02-05 00:41:10 +01:00
Joffrey JAFFEUX
7fd5a8db72
UX: adds arrow navigation support to mini-tag-chooser ( #8857 )
2020-02-04 23:54:59 +01:00
Joffrey JAFFEUX
9252bbbd7d
FIX: prevents firefox to generate a click event on space ( #8856 )
2020-02-04 23:41:40 +01:00
Joffrey JAFFEUX
2c2ab474a4
FIX: ensures tags-admin-dropdown is working correctly with sk2 ( #8852 )
2020-02-04 19:23:44 +01:00
Penar Musaraj
095e3d8946
DEV: Autofilter combo boxes on 10+ dropdown items by default
2020-02-04 11:23:15 -05:00
Mark VanLandingham
c8a02161dd
FIX: Warn users of overwriting new topic draft ( #8841 )
2020-02-04 09:59:56 -06:00
Joffrey JAFFEUX
14126e9a38
UX: do not display pinned option description on mobile ( #8846 )
2020-02-04 15:34:56 +01:00
Joffrey JAFFEUX
ca63502ce6
UX: ensures pinned options icon is not on a new line ( #8845 )
2020-02-04 15:34:37 +01:00
Penar Musaraj
375f4c09ce
FIX: Restore up/down icons in period-chooser
2020-02-03 13:56:58 -05:00
Joffrey JAFFEUX
0431942f3d
DEV: select-kit 2 ( #7998 )
...
This new iteration of select-kit focuses on following best principales and disallowing mutations inside select-kit components. A best effort has been made to avoid breaking changes, however if you content was a flat array, eg: ["foo", "bar"] You will need to set valueProperty=null and nameProperty=null on the component.
Also almost every component should have an `onChange` handler now to decide what to do with the updated data. **select-kit will not mutate your data by itself anymore**
2020-02-03 14:22:14 +01:00
Dan Ungureanu
89bd7ba45f
FIX: Use new tag routes ( #8683 )
...
Commit 1fb7a62
2020-01-21 19:23:08 +02:00
Dan Ungureanu
eeefa1177f
FIX: Make category-chooser show all parent categories ( #8706 )
2020-01-19 13:07:54 +02:00
Jarek Radosz
fe588cc7f8
DEV: Fix function prototype deprecations ( #8681 )
...
* DEV: Fix the function prototype observers deprecation
DEPRECATION: Function prototype extensions have been deprecated, please migrate from function(){}.observes('foo') to observer('foo', function() {}). [deprecation id: function-prototype-extensions.observes] See https://deprecations.emberjs.com/v3.x/#toc_function-prototype-extensions-observes for more details.
* DEV: Fix the function prototype event listeners deprecation
DEPRECATION: Function prototype extensions have been deprecated, please migrate from function(){}.on('foo') to on('foo', function() {}). [deprecation id: function-prototype-extensions.on] See https://deprecations.emberjs.com/v3.x/#toc_function-prototype-extensions-on for more details.
* DEV: Simplify `default as` imports
Co-authored-by: Joffrey JAFFEUX <j.jaffeux@gmail.com>
2020-01-16 18:56:53 +01:00
Jarek Radosz
ff5a82b614
FIX: Change rootNone behavior in category-chooser ( #8692 )
...
This breaking change was originally a deprecation fix for overriding a computed property `none`.
There are 4 uses of `rootNone` in core and "all-the-plugins":
1. in discourse-chat-integration, admin-plugins-chat-edit-rule.hbs - changed behavior, that I'd consider a fix - `rootNoneLabel` is now used regardless of `siteSettings.allow_uncategorized_topics` value, which I believe was an originally intended behavior (i.e. it most likely hasn't been tested with disabled uncategorized topics)
2. in discourse-slack-official, plugins-slack.hbs - the same as 1.
3. in core, edit-category-general.hbs (in this PR) - no change in behavior
4. in discourse-googlebooks, edit-category-general.hbs - no change in behavior (since `allowUncategorized="true"` is also passed as an argument)
2020-01-16 18:51:29 +01:00
Penar Musaraj
93a556d9a2
DEV: replace "eye-slash" icons with "far-eye-slash"
2020-01-06 12:27:20 -05:00
Penar Musaraj
f62c9def33
Revert "FIX: prevents focus of input on mobile ( #6251 )"
...
This reverts commit bfcf8ed61b
2019-12-12 11:17:40 -05:00
Penar Musaraj
ba8d8a4f93
FIX: alphabetical tag sorting in mini-tag-chooser
2019-12-10 12:36:49 -05:00
Neil Lalonde
875f0d8fd8
FEATURE: Tag synonyms
...
This feature adds the ability to define synonyms for tags, and the ability to merge one tag into another while keeping it as a synonym. For example, tags named "js" and "java-script" can be synonyms of "javascript". When searching and creating topics using synonyms, they will be mapped to the base tag.
Along with this change is a new UI found on each tag's page (for example, `/tags/javascript`) where more information about the tag can be shown. It will list the synonyms, which categories it's restricted to (if any), and which tag groups it belongs to (if tag group names are public on the `/tags` page by enabling the "tags listed by group" setting). Staff users will be able to manage tags in this UI, merge tags, and add/remove synonyms.
2019-12-04 13:33:51 -05:00
Daniel Waterworth
712e171b34
DEV: Don't pass multiple categories to tag-drop
...
The tag-drop component uses the passed in categories to calculate paths,
but only the last category is relevant, since, from a category we can
calculate its ancestors.
2019-12-02 12:27:19 +00:00
Daniel Waterworth
374534f00e
DEV: Use category ids in URLs preferentially
2019-12-02 09:28:15 +00:00
Daniel Waterworth
9251065768
FIX: Generate redirect URL correctly when using a subdirectory
...
The url property of a category contains the base_uri and so it shouldn't
be concatated into a larger URL unless it is the prefix.
2019-12-02 09:28:15 +00:00
Angus McLeod
2c335efd1e
FIX: method names incorrect ( #8393 )
2019-11-22 15:16:14 +01:00
Penar Musaraj
6e74350f18
Fix Prettier again
...
Not sure how I missed a few files in the last commit
2019-11-15 10:52:06 -05:00
Penar Musaraj
cc8baa1a7c
Fix Prettier using correct version (1.19.1)
2019-11-15 10:34:26 -05:00
Mark VanLandingham
3c5df82590
DEV: Remove Discourse.Site in favor of import ( #8344 )
...
* DEV: Remove Discourse.Site in favor of importing Site
* Ran prettier
2019-11-13 12:13:47 -05:00
Robin Ward
f518065654
FIX: computed is part of @ember/object not @ember/object/computed
2019-11-13 11:58:09 -05:00
Jarek Radosz
9b841ea83f
DEV: Run prettier
2019-11-12 11:49:31 +01:00
Jarek Radosz
5d4b240453
DEV: Provide radix argument to parseInt ( #8281 )
...
* DEV: Provide radix 10 argument to parseInt
* DEV: Provide radix 16 argument to parseInt
* DEV: Remove unnecessary parseInt calls
* Fix year formatting
parseInt was used here to convert decimals to ints
2019-11-12 10:47:42 +01:00
Mark VanLandingham
1bbb9b30fc
DEV: Import isNone for @ember/utils
2019-11-11 10:37:21 -05:00
Robin Ward
7ac2a55588
REFACTOR: Remove Discourse.Category constants
2019-11-08 13:31:00 -05:00
Mark VanLandingham
e51efce356
DEV: Remove all instances of Ember.computed ( #8324 )
2019-11-08 12:28:11 -06:00
Mark VanLandingham
562acb21ca
FIX: Ran prettier to fix build ( #8323 )
2019-11-08 10:50:03 -06:00
Mark VanLandingham
7f3812b90a
DEV: Removed all Ember.computed. in select-kit ( #8322 )
2019-11-08 10:32:20 -06:00
Mark VanLandingham
6275c05c0d
DEV: Move computed to discourseComputed ( #8312 )
2019-11-07 15:38:28 -06:00
Mark VanLandingham
edc135d9c5
DEV: Import set, setProperties, helper, and string functions ( #8297 )
2019-11-05 12:43:49 -06:00
Jarek Radosz
d43e7354ec
DEV: Convert <button> tags to {{d-button}} components ( #8224 )
...
* DEV: Convert <button> tags to {{d-button}}
* Fixes
2019-11-04 11:23:54 +01:00
Robin Ward
dceb72bc69
FIX: Move makeArray to discourse-common
2019-11-01 13:50:15 -04:00
Robin Ward
6300ac699a
FIX: Missing run import
2019-11-01 13:50:15 -04:00
Robin Ward
640a05c4ee
REFACTOR: Remove Ember.get
2019-11-01 13:50:15 -04:00
Robin Ward
89f602f66b
REFACTOR: Ember.makeArray was removed from the public API
2019-11-01 13:50:15 -04:00
Robin Ward
90f934a660
REFACTOR: Use a module for Ember.isEmpty
2019-11-01 13:50:15 -04:00
Mark VanLandingham
ced3807b23
FIX: Prettier on importing mixin ( #8270 )
2019-10-30 15:13:48 -05:00
Mark VanLandingham
ba4b557114
DEV: Remove Ember.Mixin to import @ember/object/mixin ( #8269 )
2019-10-30 15:03:08 -04:00
Robin Ward
8d34f4bbd9
Revert "Revert Ember.run refactors"
...
This reverts commit fcb1ca52f9
2019-10-30 09:48:24 -04:00
Robin Ward
fcb1ca52f9
Revert Ember.run refactors
...
This reverts commit 5ca60fcb6b
2019-10-29 17:10:47 -04:00
Robin Ward
5ca60fcb6b
REFACTOR: Use imports for Ember.run
2019-10-29 15:31:56 -04:00
Mark VanLandingham
c7475ee03b
DEV: Import EmberObject rather than global variable ( #8256 )
...
* DEV: Import ember/object rather than Ember.Object globally
* fixed broken object proxy import
* prettier on js
* added @ember/object/proxy to loader
* added unstaged file
* Fixed objet proxy reference is loader
* Linting!
2019-10-29 14:23:50 -05:00
Robin Ward
a8a76198b1
REFACTOR: Remove Ember.Component global variable
...
Use imports instead.
2019-10-23 12:30:52 -04:00
Sam Saffron
98d6cee7c7
FIX: various fixes to draft system
...
- destroyDraft which is called when we cancel a draft is now async,
removing race conditions when you click "reply" to a post and are
already editing. We used to trigger double dialogs for cancelling
drafts which was confusing.
- Remove reply as new topic / reply as pm keys, they are no longer
used and only caused confustion. For example we used to pop up a
warning when you are composing a reply and flick to reply as
new topic
- Remove createTopic key, this was a bug that proliferated. Whenever
creating a topic via the C shortcut or clicking on new topic on full
screen search the correct new topic draft key will be used
consistently
- When abandoning an edit we now say "Are you sure you want to discard
your changes" (instead of abandon your post which is confusing)
2019-10-21 17:24:06 +11:00
Jarek Radosz
d407bcab36
FIX: Correctly escape category description text ( #8107 )
...
* FIX: Correctly escape category description text
This bug has been introduced in db14e109437ad338e3e6/app/models/theme.rb (L237-L242)
2019-10-01 12:04:39 -04:00
Joffrey JAFFEUX
171618e7d6
FIX: allows mini-tag-chooser to fetch tags in background ( #8033 )
...
This is useful when changing the category in the composer for example. When opening mini-tag-chooser after, tags will be correctly updated for the selected category.
2019-08-23 06:45:29 -06:00
Dan Ungureanu
0b1146add4
UX: Hide "Create Tag" option if user cannot create tag. ( #7723 )
2019-08-19 11:40:56 +03:00
David Taylor
a49b7bb84a
FIX: Prevent user-notifications-dropdown from causing unintended changes
...
It was setting the `onClose` property of the singleton modal controller, which would then persist until the next full page reload
2019-07-31 15:38:47 +01:00
Joffrey JAFFEUX
fe7f0982af
DEV: attemps to limit Discourse.User.current() usage ( #7943 )
2019-07-26 11:20:11 +02:00
Penar Musaraj
a571efba35
FIX: Rename deprecated icons, allow custom icons in badges
...
- adds a migration renaming FA4 icon names in badges
- allows all icons to be used in badges (previously was limited to icons prefixed with fa-)
- renames remaining FA 4.7 icons equivalents
2019-07-16 11:13:44 -04:00
Joffrey JAFFEUX
b3eb67976d
DEV: Upgrades to Ember 3.10 ( #7871 )
...
Co-Authored-By: majakomel <maja.komel@gmail.com>
2019-07-16 12:45:15 +02:00
Kris
b848bd4ddc
True should be a string to display properly in aria-haspopup
2019-07-10 22:02:21 -04:00
Joffrey JAFFEUX
c63268467e
DEV: prettier 1.18.2 ( #7810 )
2019-06-26 17:09:52 +02:00
Joffrey JAFFEUX
cea3a027f3
FIX: category-chooser search should be scoped to category ( #7794 )
2019-06-24 10:45:30 +02:00
Joffrey JAFFEUX
c407e32368
DEV: should check on object and not length ( #7742 )
2019-06-11 09:45:45 +02:00
Joffrey JAFFEUX
df01249db4
FIX: removes leaking handler in select-kit ( #7729 )
2019-06-07 16:12:22 +02:00
Joffrey JAFFEUX
fca90106b9
FIX: select-kit events were sometimes not cleaned up ( #7728 )
2019-06-07 15:20:01 +02:00
Joffrey JAFFEUX
bc14452585
FIX: ensures events have access to correct context ( #7621 )
2019-05-28 19:40:28 +02:00
Joffrey JAFFEUX
6decdfce5c
DEV: reduces memory footprint of tests - step 1 ( #7591 )
2019-05-28 12:15:12 +02:00
Joffrey JAFFEUX
d93f753b17
apply prettier on gigantic find and replace ( #7604 )
2019-05-27 10:42:53 +02:00
Joffrey JAFFEUX
bfea922167
DEV: global s/this.get\("(\w+)"\)/this.$1 ( #7592 )
2019-05-27 10:15:39 +02:00
Joffrey JAFFEUX
6398ded798
Revert "FIX: ensures selection is lookedup into async content ( #7586 )"
...
This reverts commit c238f0d223
2019-05-25 15:50:41 +02:00
Joffrey JAFFEUX
049561ac49
FIX: introduces onSelectAny (regroup onSelect and onSelectNone) ( #7594 )
2019-05-24 13:11:33 +02:00
Joffrey JAFFEUX
cf63a9bb53
FIX: exception when pressing backspace on empty selection ( #7587 )
2019-05-22 17:18:46 +02:00
Joffrey JAFFEUX
c238f0d223
FIX: ensures selection is lookedup into async content ( #7586 )
2019-05-22 17:11:19 +02:00
Joffrey JAFFEUX
7326ddea6d
REFACTOR: tags mixin ( #7533 )
2019-05-13 17:05:21 +02:00
Joffrey JAFFEUX
c093fa0376
PERF: reduces cpu/memory consumption of sk in some cases ( #7525 )
2019-05-10 17:12:10 +02:00
Joffrey JAFFEUX
7cbc4c1e46
FIX: uses no tags label for tag-drop header ( #7438 )
2019-04-25 13:16:06 +02:00
Joffrey JAFFEUX
c99faa6b25
FIX: improves locale support in tag-drop ( #7418 )
2019-04-23 17:53:59 +02:00
Joffrey JAFFEUX
7226240df3
UX: full revamp of local-dates form ( #7357 )
2019-04-11 11:14:34 +02:00
Joffrey JAFFEUX
d8dd130477
UX: gives aria-label to topics count in category-row ( #7307 )
2019-04-02 17:38:21 +02:00
Tarek Khalil
b1cb95fc23
FEATURE: Introduce ignore duration selection ( #7266 )
...
* FEATURE: Introducing new UI for tracking User's ignored or muted states
2019-03-29 10:14:53 +00:00
Robin Ward
b58867b6e9
FEATURE: New 'Reviewable' model to make reviewable items generic
...
Includes support for flags, reviewable users and queued posts, with REST API
backwards compatibility.
Co-Authored-By: romanrizzi <romanalejandro@gmail.com>
Co-Authored-By: jjaffeux <j.jaffeux@gmail.com>
2019-03-28 12:45:10 -04:00
Tim Lange
1b0267b077
FIX: Switching composer action shouldn't trigger abandon popup ( #7261 )
2019-03-27 21:55:09 +01:00
Tarek Khalil
ef2362a30f
FEATURE: Introducing new UI for changing User's notification levels ( #7248 )
...
* FEATURE: Introducing new UI for tracking User's ignored or muted states
2019-03-27 09:41:50 +00:00
Joffrey JAFFEUX
b2cacc5b0e
FIX: check can_create_tags on mini-tag-chooser as tag-chooser ( #7260 )
2019-03-26 16:45:38 +01:00
Maja Komel
3aa32c3170
FIX: send only one post request when changing topic notification level ( #7254 )
2019-03-26 12:04:33 +01:00
Maja Komel
f3d0d8fe7d
Upgrade to Ember 3.7.0
2019-03-20 14:43:25 +01:00
Roman Rizzi
77931b70c3
Revert "DEV: Upgrade to Ember 3.7.0 ( #6977 )" ( #7165 )
...
This reverts commit 3eebf8be73
2019-03-13 15:49:47 -03:00
Maja Komel
3eebf8be73
DEV: Upgrade to Ember 3.7.0 ( #6977 )
...
* Upgrade to Ember 3.7.0
* use ember source 3.7.0.2
* fix mobile header
* fix navigation
2019-03-13 12:16:06 +01:00
Joffrey JAFFEUX
2e881adb6e
FIX: select-kit perf and positioning improvements ( #7093 )
2019-03-04 10:30:22 +01:00
Guo Xiang Tan
46e62c0d22
UX: Default user facing routes to /g instead of /groups. ( #7042 )
2019-02-21 13:44:25 +08:00
Joffrey JAFFEUX
560cc4e73e
FIX: sets categoryId but do not scope when replying as new topic ( #7002 )
2019-02-13 15:19:58 +01:00
Joffrey JAFFEUX
44d9bc12c9
FEATURE: color-palettes component ( #6992 )
2019-02-08 14:01:14 +01:00
Joffrey JAFFEUX
c0ccf21970
FIX: hides topic-footer-mobile-dropdown when no content ( #6985 )
2019-02-07 18:37:20 +01:00
Joffrey JAFFEUX
6c195640b9
FEATURE: adds an API to register topic footer buttons
2019-02-07 14:43:33 +01:00
Penar Musaraj
9886934ef5
DEV: fix some deprecated SVG icon refs
2019-01-22 14:42:00 -05:00
Robin Ward
a834245683
FIX: Keep tags when switching to shared draft
2019-01-22 11:26:52 -05:00
Joffrey JAFFEUX
80d42b4ea2
icons deprecations fixes ( #6920 )
2019-01-22 12:02:02 +01:00
Joffrey JAFFEUX
502b1316d0
DEV: s/this._super()/this._super(...arguments) ( #6908 )
2019-01-19 10:05:51 +01:00
Joffrey JAFFEUX
486df57a23
FIX: tweaking topic footer dropdowns ( #6882 )
...
- no description on mobile for notifications
- better reason text positioning
2019-01-16 10:27:27 +01:00
Vinoth Kannan
a8ff4a8a78
UX: search all categories even if category-chooser is scoped to particular category
2019-01-10 21:19:53 +05:30
Joffrey JAFFEUX
f9648de897
DEV: upgrades from Ember 2.13 to Ember 3.5.1 ( #6808 )
...
Co-Authored-By: Bianca Nenciu <nbianca@users.noreply.github.com>
Co-Authored-By: David Taylor <david@taylorhq.com>
2019-01-10 11:06:01 +01:00
Joffrey JAFFEUX
25269a37aa
FIX: do not show #uncategorized in category drop if setting is disabled ( #6856 )
2019-01-09 09:44:24 +08:00
Vinoth Kannan
385829d7be
FEATURE: Display error message when category restriction is applied for tags
2019-01-04 00:29:13 +05:30
Gerhard Schlager
dc477d1228
FIX: "Toggle topic bump" wasn't visible for TL4 users
2019-01-02 20:16:55 +01:00
Joffrey JAFFEUX
7b15b87cf5
FIX: better left/right positioning in select-kit components ( #6824 )
2018-12-28 19:46:31 +01:00
Joffrey JAFFEUX
942114b34c
FIX: optimize collapse/expand select-kit codepath ( #6818 )
2018-12-27 23:38:01 +01:00
Vinoth Kannan
dc292d4598
FIX: Use one-way binding to prevent unnecessary updates in site.periods
2018-12-20 03:39:05 +05:30
Bianca Nenciu
7050ce4638
FIX: Bypass draft check when switching to shared draft. ( #6782 )
2018-12-19 10:25:33 +01:00
Joffrey JAFFEUX
22cea9ce90
FIX: adusts select-kit position even if not expanded ( #6785 )
2018-12-17 12:29:51 +01:00
Joffrey JAFFEUX
6ee3900791
FIX: ensures nothing is triggering rendering loop in after render ( #6784 )
2018-12-17 12:15:03 +01:00
Joffrey JAFFEUX
d803dfc14a
FIX: makes more resilient select-kit positioning ( #6776 )
2018-12-15 16:23:23 +01:00
Joffrey JAFFEUX
bcf4a17751
FIX: apply original margin-bottom to fix position placeholder ( #6764 )
2018-12-13 18:21:12 +01:00
Joffrey JAFFEUX
e06a8980fb
FIX: category-drop initial state was incorrect ( #6743 )
2018-12-10 14:05:00 +01:00
Joffrey JAFFEUX
8da8f5d0f7
FIX: call onSelect plugin callbacks for noop rows ( #6682 )
2018-11-29 15:56:19 +01:00
Joffrey JAFFEUX
4c7dfed32e
FIX: error with tags enabled and no tags created ( #6701 )
2018-11-29 10:39:09 +01:00
Penar Musaraj
03deda2147
Upgrade to FontAwesome 5 (take two) ( #6673 )
...
* Add missing icons to set
* Revert FA5 revert
This reverts commit 42572ff
2018-11-26 16:49:57 -05:00
Joffrey JAFFEUX
9911a41f4c
FIX: improves category/tag drops header shortcuts ( #6610 )
...
- wont appear when filtering
- can now be selected with keyboard
- fix bugs on click with safari/firefox
2018-11-15 15:21:40 +01:00
Joffrey JAFFEUX
c1e82e7442
FIX: category row title ( #6597 )
2018-11-13 13:35:45 +01:00
Sam
42572ff138
Revert font awesome 5 changes
...
We are still pushing ahead on this 100% just need a bit longer to prepare
all plugins
2018-11-08 16:12:18 +11:00
Penar Musaraj
005e1ecb9b
FEATURE: Update Font Awesome to v5.4.1 and SVGs ( #6557 )
...
* First take on subsetting svg icons
* FontAwesome 5 svg subset WIP
* Include icons from plugins/badges into svg sprite subset
* add svg icon support to themes
* Add spec for SvgSprite
* Misc. SVG icon fixes
* Use FA5 svgs in local-dates plugin
* CSS adjustments, fix SVG icons in group flair
* Use SVG icons in poll plugin
* Add SVG icons to /wizard
2018-11-07 13:05:43 -05:00
Joffrey JAFFEUX
fdad24e2e4
FIX: edit category tags select-kit inputs width were wrong ( #6568 )
2018-11-06 11:30:12 +01:00
Vinoth Kannan
28cf4d535e
UX: Include subcategories in search result of all categories drop down
2018-10-31 23:03:24 +05:30
Penar Musaraj
3c92202654
Set individual future-date-input components as clearable, fixes admin Safari bug ( #6522 )
2018-10-26 11:34:55 +11:00
Kris
c219a5fb1e
Add btn-default class to all default buttons ( #6521 )
2018-10-24 16:09:36 -04:00
David Taylor
37b7afa522
FIX: Sanitize tags before creation
2018-10-22 10:53:42 +01:00
David Taylor
0dd717e641
Revert "FIX: Sanitize tags before creation"
...
This reverts commit 18ae8de9e5
2018-10-19 15:49:05 +01:00
David Taylor
18ae8de9e5
FIX: Sanitize tags before creation
2018-10-19 15:43:31 +01:00
David Taylor
7166d7de9a
FIX: Prevent duplicate tags in tag-choosers ( #6512 )
...
* FIX: Prevent duplicate tags in tag-choosers
This reverts 5685b455685b45
2018-10-19 13:44:43 +01:00
David Taylor
9bf522f227
FEATURE: Mixed case tagging ( #6454 )
...
- By default, behaviour is not changed: tags are made lowercase upon creation and edit.
- If force_lowercase_tags is disabled, then mixed case tags are allowed.
- Tags must remain case-insensitively unique. This is enforced by ActiveRecord and Postgres.
- A migration is added to provide a `UNIQUE` index on `lower(name)`. Migration includes a safety to correct any current tags that do not meet the criteria.
- A `where_name` scope is added to `models/tag.rb`, to allow easy case-insensitive lookups. This is used instead of `Tag.where(name: "blah")`.
- URLs remain lowercase. Mixed case URLs are functional, but have the lowercase equivalent as the canonical.
2018-10-05 10:23:52 +01:00
Kris
07be8e5447
caret icon is redundant on hamburger menu button
2018-10-02 15:06:50 -04:00
Bianca Nenciu
719a433c03
FIX: Sync client & server rules regarding tag names. ( #6400 )
2018-10-01 21:45:44 -07:00
Kyle Zhao
d9bea66365
UX: confirmation before changing group membership in admin ( #6426 )
2018-10-01 21:34:08 -07:00
Maja Komel
1add11d8c9
FIX: don't send multiple requests when changing category notification ( #6435 )
2018-10-01 23:41:23 +08:00
Kris
5f042a2c8d
Prevent move to new topic tag input from becoming too wide on click
2018-09-20 16:12:08 -04:00
Kris
e95d6a12c5
prettier
2018-09-18 13:39:58 -04:00
Kris
8bfb016386
remove trailing spaces
2018-09-18 13:25:50 -04:00
Kris
d20a174a6b
UX: Lighter style for category and tag dropdown nav
2018-09-18 13:11:00 -04:00
Joffrey JAFFEUX
a713c0d366
FIX: ensures onSelect/onDeselect are called
...
This commit also add a FIX and a test for toolbar-popup-menu-options which had a behavior slightly specific.
2018-09-18 11:31:23 +02:00
Joffrey JAFFEUX
2ff2c49908
Revert "FIX: ensures onSelect/onDeselect are called"
...
This reverts commit 52eed73294
2018-09-17 22:14:41 +02:00
Joffrey JAFFEUX
52eed73294
FIX: ensures onSelect/onDeselect are called
2018-09-17 10:36:14 +02:00
Sam
b63630d70b
use Mixin postfix when importing tags mixin
2018-09-17 10:46:57 +10:00
pmusaraj
0a2efd8ff1
Add async search to tags dropdown, always show selected tag
2018-09-17 10:40:47 +10:00
Joffrey JAFFEUX
38668818a5
FIX: allows forcing unsafe string in select-kit ( #6386 )
...
forceEscape will be defaulted to true before next release.
2018-09-12 12:19:04 +02:00
Joffrey JAFFEUX
17087eff2a
FIX: Reset tags on category change ( #6363 )
2018-09-05 17:18:52 +02:00
Joffrey JAFFEUX
07e11a223c
FIX: prefills username for new message on first post ( #6305 )
2018-08-23 11:09:35 +02:00
Kris
8c46ecf7f3
UX: Improving tag topic list navigation consistency
2018-08-16 00:02:26 -04:00
Joffrey JAFFEUX
7290765a62
FIX: uses touchstart/mousedown for selected tags ( #6268 )
...
It seems to be way more reliable on firefox and safari in the case of hot replaced content not using ember.
2018-08-14 16:16:13 +02:00
Gerhard Schlager
ef4b9f98c1
FEATURE: Allow admins to reply without topic bump
2018-08-10 10:48:30 +10:00
Joffrey JAFFEUX
6a2ca60b48
FIX: ember click event not reliably working on fx ( #6256 )
2018-08-09 22:41:35 +02:00
Joffrey JAFFEUX
da1d520d4c
FIX: simplifies mini tag chooser events handling ( #6252 )
2018-08-09 14:23:28 +02:00
Joffrey JAFFEUX
bfcf8ed61b
FIX: prevents focus of input on mobile ( #6251 )
2018-08-09 14:23:09 +02:00
Joffrey JAFFEUX
523acfcea4
FIX: checks on parent visibility instead of filter itself ( #6250 )
2018-08-09 10:45:53 +02:00
Joffrey JAFFEUX
c301111461
FIX: display select kit body if no choices ( #6237 )
2018-08-06 11:22:48 -04:00
Joffrey JAFFEUX
066010db7d
FEATURE: introduces list/compact_list components
2018-08-03 16:41:37 -04:00
Joffrey JAFFEUX
c6fd506a15
fix eslint
2018-07-30 13:10:20 -04:00
Joffrey JAFFEUX
2c90a2e5c2
FIX: prevents mini-tag-chooser to catch unwanted focus
2018-07-30 13:03:40 -04:00
Joffrey JAFFEUX
73d736c8c3
FIX: popup-menu instantly closing ( #6147 )
2018-07-23 14:19:36 -04:00
Joffrey JAFFEUX
78419f677d
FIX: multiple select-kit fixes on mobile
2018-07-23 12:19:40 -04:00
Joffrey JAFFEUX
5e521f8ce6
Revert "FIX: various select-kit corrections on mobile"
...
This reverts commit 78a2324c89
2018-07-20 15:28:12 -04:00
Joffrey JAFFEUX
78a2324c89
FIX: various select-kit corrections on mobile
2018-07-20 14:46:25 -04:00
Joffrey JAFFEUX
1a78e12f4e
FEATURE: part 2 of dashboard improvements
...
- moderation tab
- sorting/pagination
- improved third party reports support
- trending charts
- better perf
- many fixes
- refactoring
- new reports
Co-Authored-By: Simon Cossar <scossar@users.noreply.github.com>
2018-07-19 14:33:11 -04:00
Sam
818bc10107
FIX: count subcategories in breadcrumbs
2018-07-17 12:06:48 +10:00
Joe
d8e51095c9
FIX: mobile topic-timer adjustments
2018-07-04 19:23:09 +08:00
Joe
888a827b93
FIX: removes inline styles applied to "all categories" in category dropdown
...
"all categories" in the category dropdown gets category-like inline styles when category mode is set to "box"
2018-07-03 12:02:50 +08:00
OsamaSayegh
d81f8ea378
fix prettier
2018-06-26 15:31:43 +03:00
OsamaSayegh
bfe0178270
FIX: use the correct notification levels titles for PMs
2018-06-26 14:01:52 +02:00
Joffrey JAFFEUX
eb9b99e519
FIX: makes select-kit match searches with accents (filter and content)
2018-06-26 12:19:14 +02:00
Joffrey JAFFEUX
666386d4b7
FIX: allows more chars than a-z in select-kit
2018-06-25 12:52:20 +02:00
Joffrey JAFFEUX
c722fc5164
FIX: makes sure category and tag drop headers have a title
2018-06-24 22:23:31 +02:00
Joffrey JAFFEUX
2f7960bd2a
DEV: updates prettier and displays linters/prettifiers version in CI
2018-06-20 18:34:49 +02:00
Joffrey JAFFEUX
3fc82bf200
FIX: adds a title to composer actions header
2018-06-18 19:01:37 +02:00
Joffrey JAFFEUX
60ff0e9b8c
missing prettified files
2018-06-15 18:42:20 +02:00
Joffrey JAFFEUX
03a7d532cf
DEV: introduces prettier for es6 files
2018-06-15 17:03:24 +02:00
OsamaSayegh
06777aa47d
FIX: use the correct notification levels descriptions for PMs
2018-06-15 14:04:14 +10:00
Joffrey JAFFEUX
ee8cda691d
FIX: simplifies and corrects new collection header tag/drop behaviour
2018-05-29 17:34:34 +02:00
