David Taylor
c9b9463ee3
DEV: Resolve decorator import deprecations ( #25616 )
2024-02-08 19:02:26 +00:00
Bianca Nenciu
95555b9a97
FIX: Do not async already loaded categories ( #25607 )
...
Use sync findByIds to return the category list if all of them have been
previously loaded.
2024-02-08 18:36:31 +02:00
David Taylor
a3ef9e92eb
DEV: Update topic and post models to native class syntax ( #25612 )
...
This commit was created with a combination of the ember-native-class-codemod and manual cleanup
2024-02-08 15:09:50 +00:00
David Taylor
6c597b648b
DEV: Convert most JS models to native class syntax ( #25608 )
...
This commit was created with a combination of the ember-native-class-codemod and manual cleanup
2024-02-08 13:17:36 +00:00
David Taylor
234795c70e
FIX: Service worker push notifications when cache disabled ( #25610 )
2024-02-08 11:55:32 +00:00
Martin Brennan
adb4eee153
DEV: Make more group-based settings client: false ( #25585 )
...
Affects the following settings:
* whispers_allowed_groups
* anonymous_posting_allowed_groups
* personal_message_enabled_groups
* shared_drafts_allowed_groups
* here_mention_allowed_groups
* uploaded_avatars_allowed_groups
* ignore_allowed_groups
This turns off `client: true` for these group-based settings,
because there is no guarantee that the current user gets all
their group memberships serialized to the client. Better to check
server-side first.
2024-02-08 09:43:34 +10:00
Daniel Waterworth
57c53b0ead
DEV: Do lazy_load_categories check inside asyncFindByIds ( #25600 )
...
This way, we can use asyncFindByIds indiscriminately.
2024-02-07 17:33:59 -06:00
Daniel Waterworth
8058fd5b80
FIX: Add id to warn ( #25597 )
2024-02-07 17:20:08 -06:00
Daniel Waterworth
3da302716c
DEV: Coalesce category ids to numbers ( #25598 )
...
Otherwise, if you pass in strings, strange things happen.
2024-02-07 17:19:58 -06:00
Daniel Waterworth
67229a7739
DEV: switch to asyncFindByIds in category-list site-setting component ( #25592 )
...
We no longer want to rely on preloading every single category, which
means we need to do http requests for categories when we need them.
2024-02-07 12:07:32 -06:00
David Taylor
225db41bfc
DEV: Remove service-worker fetch handler entirely when cache disabled ( #25591 )
...
Followup to c4559ae575
2024-02-07 14:57:40 +00:00
David Taylor
c4559ae575
DEV: Add disable_service_worker_cache global setting ( #25589 )
...
When enabled, the workbox caching logic in the service worker will be replaced with a very simple offline error page. We plan to use this as an experiment to see how it affects performance and stability of Discourse.
2024-02-07 10:44:12 +00:00
Isaac Janzen
32ee0e3c0a
FIX: Similar topics relying on widget search menu ( #25586 )
2024-02-07 18:15:54 +11:00
Jarek Radosz
21a830b53d
FIX: Clicking a notification was triggering an error ( #25583 )
2024-02-07 00:21:44 +01:00
Mark VanLandingham
13186e6790
FIX: Correct className for notification avatars using system avatar ( #25578 )
2024-02-06 14:47:35 -06:00
Sam
090252bc39
FIX: Visits for TL3 actually means "Posts Read: unique days" ( #25468 )
...
This fixes a quirk in the TL3 report where we were calling the column "visits" but it actually meant "Posts Read: unique days"
2024-02-07 07:46:42 +11:00
Jan Cernik
8abc7baf7c
FIX: Save previous chat state when navigating with the sidebar ( #25537 )
2024-02-06 13:11:12 -03:00
Isaac Janzen
5c43fd5054
DEV: Remove widget search menu ( #25545 )
2024-02-06 08:52:24 -07:00
Kris
2caaadea4a
UX: grant names some more space on /u ( #25576 )
2024-02-06 09:32:07 -05:00
David Taylor
7fcd7d53f9
DEV: Update RestModel and RestAdapter to native class syntax ( #25544 )
...
This commit also updates a handful of simple adapters which overrode the jsonMode or primaryKey options. These updates are necessary because class fields cannot be overwritten via `EmberObject`'s `.extend()` syntax. These options do not appear to be widely used by themes/plugins.
2024-02-06 12:22:08 +00:00
dependabot[bot]
fba894d049
Build(deps): Bump ember-template-imports from 4.0.0 to 4.1.0 in /app/assets/javascripts ( #25572 )
...
* Build(deps): Bump ember-template-imports in /app/assets/javascripts
Bumps [ember-template-imports](https://github.com/ember-template-imports/ember-template-imports ) from 4.0.0 to 4.1.0.
- [Release notes](https://github.com/ember-template-imports/ember-template-imports/releases )
- [Changelog](https://github.com/ember-template-imports/ember-template-imports/blob/master/CHANGELOG.md )
- [Commits](https://github.com/ember-template-imports/ember-template-imports/compare/v4.0.0...v4.1.0 )
---
updated-dependencies:
- dependency-name: ember-template-imports
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
* Update lockfiles for ember version flag
---------
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: discoursebuild <build@discourse.org>
2024-02-06 00:11:40 +01:00
Daniel Waterworth
8561fd78d8
DEV: Convert site-settings/category-list to glimmer component ( #25571 )
2024-02-05 14:23:08 -06:00
Daniel Waterworth
a20bf843fc
DEV: Switch site-settings category-list component to gjs ( #25569 )
2024-02-05 12:03:35 -06:00
Gerhard Schlager
dd5ca6cc4c
FEATURE: Permalinks for users ( #25552 )
2024-02-05 17:31:31 +01:00
Jarek Radosz
4b2be8c6b3
FIX: Correctly save group invites ( #25566 )
...
regressed in 19b86e7ea2
2024-02-05 10:27:23 +01:00
Arpit Jalan
badc390ebe
FEATURE: allow disabling user activity tab for non admin users ( #25540 )
...
* FEATURE: allow disabling user activity tab for non admin users
* add another test case
2024-02-05 14:30:36 +05:30
Penar Musaraj
ac53e5a962
FIX: Handle old Firefox versions that do not support isConditionalMediationAvailable ( #25549 )
...
Some versions of Firefox will throw a TypeError when calling
PublicKeyCredential.isConditionalMediationAvailable() because the
method does not exist. That would previously lead to a "Sorry, an error
has occurred." modal when trying to login.
This commit fixes the issue by properly checking if the method exists.
Since it only affects older Firefox versions, no tests are added.
2024-02-02 16:39:37 -05:00
Daniel Waterworth
5f06d6490d
PERF: Add cache for Category.asyncFindByIds ( #25531 )
...
This way, we don't fetch the same category multiple times.
2024-02-02 14:13:12 -06:00
Mark VanLandingham
a239e8f27f
DEV: Add classNames to user menu icon avatar wrapper ( #25548 )
2024-02-02 14:07:03 -06:00
Jarek Radosz
bb57b31a4d
DEV: Bump content-tag to 2.0.1 ( #25541 )
2024-02-02 13:33:29 +01:00
Sam
140b2118af
FEATURE: improvements to hot feature ( #25533 )
...
1. Don't show visited line for hot filter, it is in random order
2. Don't count likes on non regular posts (eg: whispers / small actions)
3. Don't count participants in non regular posts
2024-02-02 10:53:27 +11:00
Martin Brennan
9563d02054
FIX: Serialize uploaded_avatars_allowed_groups check on current user ( #25515 )
...
Checking group permissions on the client does not work,
since not all groups are serialized to the client all
the time. We can check `uploaded_avatars_allowed_groups`
on the server side and serialize to the current user
instead.
2024-02-02 09:32:45 +10:00
dependabot[bot]
7c8a56e116
Build(deps-dev): Bump the embroider group in /app/assets/javascripts with 3 updates ( #25528 )
...
* Build(deps-dev): Bump the embroider group
Bumps the embroider group in /app/assets/javascripts with 3 updates: [@embroider/compat](https://github.com/embroider-build/embroider/tree/HEAD/packages/compat ), [@embroider/core](https://github.com/embroider-build/embroider/tree/HEAD/packages/core ) and [@embroider/webpack](https://github.com/embroider-build/embroider/tree/HEAD/packages/webpack ).
Updates `@embroider/compat` from 3.4.3 to 3.4.4
- [Release notes](https://github.com/embroider-build/embroider/releases )
- [Changelog](https://github.com/embroider-build/embroider/blob/main/CHANGELOG.md )
- [Commits](https://github.com/embroider-build/embroider/commits/HEAD/packages/compat )
Updates `@embroider/core` from 3.4.3 to 3.4.4
- [Release notes](https://github.com/embroider-build/embroider/releases )
- [Changelog](https://github.com/embroider-build/embroider/blob/main/CHANGELOG.md )
- [Commits](https://github.com/embroider-build/embroider/commits/HEAD/packages/core )
Updates `@embroider/webpack` from 3.2.1 to 3.2.2
- [Release notes](https://github.com/embroider-build/embroider/releases )
- [Changelog](https://github.com/embroider-build/embroider/blob/main/CHANGELOG.md )
- [Commits](https://github.com/embroider-build/embroider/commits/HEAD/packages/webpack )
---
updated-dependencies:
- dependency-name: "@embroider/compat"
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: embroider
- dependency-name: "@embroider/core"
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: embroider
- dependency-name: "@embroider/webpack"
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: embroider
...
Signed-off-by: dependabot[bot] <support@github.com>
* Update lockfiles for ember version flag
---------
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: discoursebuild <build@discourse.org>
2024-02-01 23:08:33 +01:00
dependabot[bot]
859473aecb
Build(deps-dev): Bump webpack from 5.90.0 to 5.90.1 in /app/assets/javascripts ( #25529 )
...
* Build(deps-dev): Bump webpack in /app/assets/javascripts
Bumps [webpack](https://github.com/webpack/webpack ) from 5.90.0 to 5.90.1.
- [Release notes](https://github.com/webpack/webpack/releases )
- [Commits](https://github.com/webpack/webpack/compare/v5.90.0...v5.90.1 )
---
updated-dependencies:
- dependency-name: webpack
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
* Update lockfiles for ember version flag
---------
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: discoursebuild <build@discourse.org>
2024-02-01 23:08:03 +01:00
Isaac Janzen
34a83fe1c8
DEV: Soft load topic results after closing then opening search menu ( #25504 )
...
# Context
Meta report: https://meta.discourse.org/t/dropdown-search-box-results-now-cleared-after-clicking-on-1-result/291240/1
# Demo
https://github.com/discourse/discourse/assets/50783505/3b258b2c-b346-4c81-a7b9-0c1bb6bd4b28
# Plugin Test Fix
- https://github.com/discourse/discourse-encrypt/pull/304
2024-02-01 09:44:40 -07:00
Jarek Radosz
f72ba754f1
DEV: Rework reorder-categories modal ( #25475 )
2024-02-01 13:13:38 +01:00
Jarek Radosz
dbc00d113f
DEV: Update content-tag to 2.0.0 ( #25520 )
2024-02-01 13:00:32 +01:00
Joffrey JAFFEUX
4c25266cf7
FIX: better supports ipad and hub footer nav ( #25518 )
...
Since https://github.com/discourse/discourse/pull/25501 this behavior was broken. This PR attempts to fix it by being more fine grain.
Also note that this PR is moving `footer-nav-ipad` and `footer-nav-visible` to the `html` element and not the `body`. It makes more sense as we are already adding most of other global state class like `keyboard-visible` to the `html` element.
Tested on:
- chrome desktop
- safari ios - iphone
- PWA ios - iphone
- PWA ios - ipad
- DiscourseHub iphone
2024-02-01 10:24:44 +01:00
Blake Erickson
969ab0fd6e
FIX: Video playback on iOS ( #25513 )
2024-01-31 20:09:57 -07:00
Jordan Vidrine
f2ac9e4c12
UX: Refactor Do Not Disturb indicator ( #25508 )
2024-01-31 16:56:07 -06:00
dependabot[bot]
f9c944ceb8
Build(deps): Bump the babel group in /app/assets/javascripts with 1 update ( #25511 )
...
* Build(deps): Bump the babel group
Bumps the babel group in /app/assets/javascripts with 1 update: [@babel/standalone](https://github.com/babel/babel/tree/HEAD/packages/babel-standalone ).
Updates `@babel/standalone` from 7.23.9 to 7.23.10
- [Release notes](https://github.com/babel/babel/releases )
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md )
- [Commits](https://github.com/babel/babel/commits/v7.23.10/packages/babel-standalone )
---
updated-dependencies:
- dependency-name: "@babel/standalone"
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: babel
...
Signed-off-by: dependabot[bot] <support@github.com>
* Update lockfiles for ember version flag
---------
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: discoursebuild <build@discourse.org>
2024-01-31 23:45:17 +01:00
Kelv
bfa3e056f1
DEV: refactor topic-summary widget to topic-map-summary component ( #25447 )
...
* shift topic-summary widget to topic-map-summary component
* remove relativeDate memoization which was causing bug where displayed date never updated
2024-01-31 22:09:39 +08:00
David Battersby
52249fad11
FIX: remove fast-edit regex and string replacement ( #25496 )
...
This change removes the regex we used previously, which only allowed ASCII characters in fast-edit. Now multi-language content can be used with fast-edit.
It also removes the string replacement we relied on in the past to catch various forms of punctuation marks, as this no longer appears necessary (possibly since this component was updated to use Glimmer).
2024-01-31 18:26:43 +08:00
Jarek Radosz
58be138e75
FIX: Site-setting integer input type ( #25485 )
...
Regressed in f2e1363f67
2024-01-30 20:25:48 +01:00
David Taylor
283fe48243
DEV: Update confirm-email flows to use central 2fa and ember rendering ( #25404 )
...
These routes were previously rendered using Rails, and had a fairly fragile 2fa implementation in vanilla-js. This commit refactors the routes to be handled in the Ember app, removes the custom vanilla-js bundles, and leans on our centralized 2fa implementation. It also introduces a set of system specs for the behavior.
2024-01-30 10:32:42 +00:00
Martin Brennan
304a7f3e1a
FIX: Do not show quote copy button to anon ( #25471 )
...
This was an oversight in 51016e56dd
2024-01-30 13:19:35 +10:00
Mark VanLandingham
f6becaa0b6
DEV: Wrap user summary category rows in plugin outlet ( #25466 )
2024-01-29 15:48:36 -06:00
Penar Musaraj
2558543794
DEV: Add general pretender for passkey challenge ( #25432 )
...
* DEV: Add general pretender for passkey challenge
* Limit a test to Chrome because of Firefox ESR flakiness
2024-01-30 08:13:59 +11:00
Mark VanLandingham
2665752732
DEV: PluginOutlet addition in user/notifications-index & summary class names ( #25463 )
2024-01-29 12:56:42 -06:00
David Taylor
ed2802eeb5
DEV: Fix alternative output directories in ember-cli proxy ( #25291 )
...
Specifying alternatives to `dist/` is useful when running multiple servers locally (e.g. for performance testing)
2024-01-29 14:09:41 +00:00
