github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2024-11-24 13:38:49 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity
24,107 Commits 190 Branches 500 Tags 938 MiB
ca1609c821
Commit Graph

14367 Commits

Author SHA1 Message Date
Neil Lalonde
951fd1219d FIX: set a max height for the tag input field 2017-07-14 12:00:35 -04:00
Guo Xiang Tan
9792e03c63 FIX: Group name was being reverted to non-localized version. 
https://meta.discourse.org/t/localized-staff-group-names-changed/65360/16
 2017-07-14 14:15:33 +09:00
Neil Lalonde
3ebd8838af FEATURE: cross-domain tracking for Google universal analytics 2017-07-13 15:21:44 -04:00
Sam
79a084dd58 Revert "remove old markdown engine work-in-progress" 
This reverts commit ee470b5317.
 2017-07-12 18:10:51 -04:00
Sam
bcbb9f208d Revert "Integrate new engine, correct old specs" 
This reverts commit f1b38ba4fb.
 2017-07-12 18:10:07 -04:00
Sam
d609f8a53c Revert "correct more specs" 
This reverts commit 40bcc6bbdc.
 2017-07-12 18:10:05 -04:00
Sam
40bcc6bbdc correct more specs 2017-07-12 17:44:40 -04:00
Sam
f1b38ba4fb Integrate new engine, correct old specs 
corrects edge cases with

- full quotes
- [url] with nested tags
- engine overrides
- onebox applying to non http srcs
 2017-07-12 17:44:40 -04:00
Sam Saffron
ee470b5317 remove old markdown engine work-in-progress 2017-07-12 17:44:40 -04:00
Neil Lalonde
24db001bfa FIX: user card contents can go up out of the bounds of the card when user has a title and full name 2017-07-12 16:16:59 -04:00
Arpit Jalan
76981605fa FIX: don't raise error when inviting existing user to private topic via email 
https://meta.discourse.org/t/inviting-existing-user-to-a-private-topic-message-via-email-shows-error-message/65994
 2017-07-12 21:51:21 +05:30
Jakub Macina
677267ae78 Add onceoff job for uploads migration of column extension. Simplify filetype search and related rspec tests. 2017-07-12 17:19:27 +02:00
Régis Hanol
a6dff79c2c change log level to info when failing to download a hotlinked image 2017-07-12 11:06:28 +02:00
Sam
98e03b04b5 Don't depend on imports for md extensions 2017-07-11 16:48:25 -04:00
Sam
5d139e461c FIX: multi option poll not working (new engine) 2017-07-11 14:43:34 -04:00
Sam
3f950a756a FEATURE: support image dimensions via Markdown image 2017-07-11 12:13:03 -04:00
Robin Ward
1163c086a3 FIX: Missing model binding 2017-07-11 11:19:49 -04:00
Arpit Jalan
3fb1c21dd5 Fix the build. 2017-07-11 19:26:33 +05:30
Sam
9840e4285d Merge pull request #4962 from nbianca/add_composer_events 
Added events to show and hide the preview pane.
 2017-07-11 08:26:25 -04:00
Arpit Jalan
35fb45749d FIX: remove unneeded code 2017-07-11 13:21:41 +05:30
Guo Xiang Tan
31932813b7 FIX: Wait for CSS transition to end before attempting to focus. 
https://meta.discourse.org/t/tab-should-work-after-edit-title-or-using-hotkeys/65792
 2017-07-11 15:26:57 +09:00
Guo Xiang Tan
3ff9133f85 FIX: Only trigger callback for parent transition events. 
* This fixes a bug where multiple requests were being
  made to the server whenever the composer is opened.
 2017-07-11 15:09:22 +09:00
Guo Xiang Tan
f529cb1674 Remove validation for invalid interpolation keys. 
* Our codebase currently supports custom interpolations keys that are
  not present in the original translation. The proper fix should
  be to make `TranslateOverride` aware of such keys.
 2017-07-11 11:12:11 +09:00
Guo Xiang Tan
c5b1317a15 Remove code that is no longer being used. 2017-07-11 11:11:51 +09:00
Bianca Nenciu
375eb290b9 Made changes as per review. 2017-07-10 23:28:35 +01:00
Bianca Nenciu
1e7f0fd8f1 Added events to show and hide the preview pane. 2017-07-10 20:23:56 +01:00
Robin Ward
31f7640335 FIX: Allow discourse app to link directly to wizard 2017-07-10 14:31:58 -04:00
Robin Ward
dcdd5baf54 FIX: Only show search if there are more total posts than the chunk size 2017-07-10 13:46:50 -04:00
Sam
ba9898c5a9 FIX: smarter newline handling for <img> tags on line alone 
Run all of pretty text spec on new engine
 2017-07-10 12:22:15 -04:00
Régis Hanol
c66b9dcdbd add 'us-east-2' S3 region 2017-07-10 15:36:38 +02:00
Arpit Jalan
3b1b00a869 FIX: invited user should not be able to redeem invite as admin 2017-07-10 07:47:37 +05:30
Robin Ward
f1a6449e4b SECURITY: Remove disposable invite feature 2017-07-07 20:24:39 -04:00
Sam
9fb180f839 we don't want that console.log 2017-07-07 16:38:52 -04:00
Sam
6f09df0deb FIX: don't create tags autolinks inside links (new engine) 2017-07-07 13:04:25 -04:00
Sam
436b894f7a FIX: mention not working after a newline (new engine) 2017-07-07 11:06:50 -04:00
Robin Ward
fa2eb8dab1 UX: Reply button was offset improperly when anonymous 2017-07-06 15:05:45 -04:00
Jakub Macina
8c445e9f17 Fix backend code for searching by a filetype as a combination of uploads and topic links. Add rspec test for extracting file extension in upload. 2017-07-06 19:19:31 +02:00
Jakub Macina
f0a674d620 Add extraction of upload extension. Add rspec test for search of post 
with upload by extension.
 2017-07-06 19:16:07 +02:00
Guo Xiang Tan
e92acb4c40 FIX: Jobs::PullHotlinkedImages#is_valid_image_src returns true for a generic string. 2017-07-06 18:31:15 +09:00
Régis Hanol
405672f8e6 Merge pull request #4957 from jjaffeux/google-classic 
FIX: s/google_blob/google_classic
 2017-07-06 10:29:40 +02:00
Guo Xiang Tan
b49579d9a7 FIX: Disable topic status info when no category has been selected. 2017-07-06 17:08:29 +09:00
Joffrey JAFFEUX
6fd44b1efd FIX: s/google_blob/google_classic 2017-07-06 09:05:15 +02:00
Guo Xiang Tan
f6491ee125 FIX: Select topic timer's category by default in edit modal. 2017-07-06 16:01:57 +09:00
Robin Ward
c53eeaaa68 REFACTOR: Remove requirejs calls 2017-07-05 17:24:27 -04:00
Robin Ward
754c1e5438 Upgrade to Babel 6 2017-07-05 15:25:23 -04:00
Joffrey JAFFEUX
fcc50edeef FIX: do not override 🦗 with :cricket_bat_and_ball: 2017-07-05 18:51:25 +02:00
Joffrey JAFFEUX
76a55fd138 FIX: adds new emojis into correct groups 2017-07-05 16:24:53 +02:00
Guo Xiang Tan
061aa261da Log site name when logging to Logster in Jobs::PullHotlinkedImages. 2017-07-05 10:34:24 +09:00
Guo Xiang Tan
4e8b80c157 Remove unnecessary ensure block. 2017-07-05 10:21:42 +09:00
Neil Lalonde
fcb2f68565 FIX: duplicate topics and posts in summary email because user has muted tags and topics contain multiple tags 2017-07-04 16:12:10 -04:00
Robin Ward
df213639f1 UX: Allow CTRL+ENTER to save topic title edits 2017-07-04 14:23:57 -04:00
Neil Lalonde
3964929c75 FIX: summary email excludes all untagged topics if user has muted some tags 2017-07-04 12:52:25 -04:00
Robin Ward
35ff5d6796 FIX: Naving to root URL was broken 2017-07-04 12:44:53 -04:00
Sam
43ecfb016a Merge pull request #4950 from jjaffeux/use-emoji-db 
FEATURE: emoji generation now uses emoji-db
 2017-07-04 09:01:13 -04:00
Joffrey JAFFEUX
a71c75367e FEATURE: emoji generation now use emoji-db 
- unicode 10
- emoji 5.0
- support for google_blob and facebook_messenger sets
 2017-07-04 14:08:47 +02:00
Arpit Jalan
c243861b17 FIX: do not show "Send Activation Email" button if must_approve_users setting is enabled 
https://meta.discourse.org/t/error-when-pressing-send-activitation-email-when-must-approve-users-setting-is-enabled/65408
 2017-07-04 14:00:50 +05:30
Sam
d2ba543ed3 correct case where %20 decoded as space in auto link 
correct case where onebox is not applied when url is decoded
 2017-07-03 16:32:53 -04:00
Sam
340a3ee5cb correct spec to handle not null visibility_level 2017-07-03 16:03:26 -04:00
Sam
45c3ad5f91 FIX: stop highlighting single l which is used for sorting 2017-07-03 15:45:15 -04:00
Sam
845170bd6b FEATURE: add support for group visibility level 
There are 4 visibility levels

- public (default)
- members only
- staff
- owners

Note, admins and group owners ALWAYS have visibility to groups

Migration treated old "non public" as "members only"
 2017-07-03 15:26:57 -04:00
Sam
c79418d334 DEV: Move RTL into lib where it belongs 2017-07-03 15:26:57 -04:00
Arpit Jalan
984778d3ac FIX: handle moving first post to a closed/archived topic 2017-07-03 21:21:20 +05:30
Arpit Jalan
72c92b0f4e FIX: include canonical meta tag on category pages 2017-07-03 13:25:22 +05:30
Arpit Jalan
d3ee5752b8 remove unneeded condition from invite model 2017-07-01 21:50:34 +05:30
Arpit Jalan
4fb9269642 FEATURE: optimize invite js code 2017-07-01 19:11:39 +05:30
Robin Ward
566cf31c66 UX: Always show topic progress on mobile 2017-06-30 16:19:19 -04:00
Sam
0650c8dbab optimize rule lookup 
we have tons of bbcode rules, might as well speed them up
 2017-06-30 15:19:16 -04:00
Robin Ward
0ba39109a0 FIX: Make omit_default_port the global default 2017-06-30 12:43:26 -04:00
Robin Ward
46a3b30021 FIX: omit the default port in the Host header 2017-06-30 12:36:02 -04:00
Sam
a55e679563 support wrap function in bbcode rules 2017-06-30 12:21:01 -04:00
Sam
5c89a37ceb FIX: log when push notifications fail 2017-06-30 10:45:53 -04:00
Arpit Jalan
16d356ab4e FEATURE: resending invite should include original custom message 
https://meta.discourse.org/t/will-resent-invite-include-original-custom-message/64699
 2017-06-30 18:13:33 +05:30
Sam
c1580b9d36 attempt to fix push notifications 2017-06-30 08:40:43 -04:00
Sam
ca40c1725c add support for a wrap function in bbcode replace 2017-06-29 16:43:57 -04:00
Sam
d941ed90d6 support for bbcode [code] blocks 2017-06-29 16:04:10 -04:00
Sam
de50d8cd35 Support for [email] [url] [img] bbcodes 2017-06-29 14:00:09 -04:00
Arpit Jalan
e7b9b1312e FEATURE: remove all invites 
https://meta.discourse.org/t/remove-all-invitations-button-for-the-admin-panel/65207
 2017-06-29 22:30:10 +05:30
Sam
c6b83f4714 Correct logic so hashtags are properly ignored in links 2017-06-29 12:48:20 -04:00
Robin Ward
6ff7bf7505 REFACTOR: Use component for cook-text to improve async workflow 2017-06-29 12:14:27 -04:00
Arpit Jalan
aa1a68b979 UX: do not show "Message" button on user's own profile page/card 2017-06-29 14:27:00 +05:30
Guo Xiang Tan
5e156fbe85 FIX: Group.search should look up Group#full_name too. 
https://meta.discourse.org/t/mentioning-group-by-full-name-doesnt-work/63437/3
 2017-06-29 16:37:59 +09:00
Guo Xiang Tan
7b35c55a1e FIX: Display Google search form when 404 page is rendered by Ember. 2017-06-29 14:37:24 +09:00
Régis Hanol
e12601b850 Merge pull request #4946 from jjaffeux/emoji-picker-fixes 
Emoji picker fixes
 2017-06-29 00:30:55 +02:00
Joffrey JAFFEUX
65fd92b991 Fixes glitch on iOS safari 2017-06-29 00:27:16 +02:00
Joffrey JAFFEUX
6e1a06d07f Uses es6 object literal shorthand 2017-06-29 00:27:02 +02:00
Robin Ward
25cecd5d25 FIX: Topic Entrance wasn't showing up on some suggested topics 2017-06-28 17:38:01 -04:00
Guo Xiang Tan
ad4694cdcd Revert "FIX: Can't cook queued posts when markdown-it is enabled." 
This reverts commit 5ff563cddd.
 2017-06-29 06:14:36 +09:00
Robin Ward
284570a5ae FIX: Don't show the admin menu if the progress bar is hidden 2017-06-28 16:31:55 -04:00
Sam
0e391a72a1 use custom whitelister for tables 2017-06-28 16:08:29 -04:00
Robin Ward
f7b686117b UX: Add a span to d-button so text can be hidden via CSS 2017-06-28 15:46:09 -04:00
Robin Ward
f6222ff225 FIX: Populate the Email Digest preview with the current username 2017-06-28 15:38:57 -04:00
Sam
6200d7d6ab correct bug where only a single poll per topic worked 2017-06-28 15:36:19 -04:00
Sam
cfbda863e8 implement unicode emoji replacements 2017-06-28 13:47:30 -04:00
Sam
301731ef24 make cook-text async friendly 2017-06-28 11:29:34 -04:00
Joffrey JAFFEUX
560dfe74af Adds support for skin tones in emoji picker 2017-06-28 15:07:05 +02:00
Guo Xiang Tan
a2349b99b6 FIX: Plugin outlet should be wrapped under d-editor-preview-wrapper. 2017-06-28 17:52:38 +09:00
Régis Hanol
173307de10 Merge pull request #4944 from nbianca/preview_plugin_outlet 
Removed useless element (div).
 2017-06-28 10:14:38 +02:00
Bianca Nenciu
2bf8b5706f Removed useless element (div). 
{{plugin-outlet}} already wraps everything.
 2017-06-28 11:04:41 +03:00
Sam
d4dbcca91b Merge pull request #4942 from nbianca/preview_plugin_outlet 
Added plugin outlet near editor's preview.
 2017-06-27 17:34:31 -04:00
Sam
fed57be9ed style table in preview as well 2017-06-27 17:26:33 -04:00
Sam
4c5109ff5b FEATURE: site setting for Markdown typographer 
It ships anyway with markdown.it so we might as well expose it
 2017-06-27 16:50:13 -04:00
Sam
0d62420cbe Space prior to onebox stops onebox resolution 2017-06-27 16:16:17 -04:00
Sam
232de90607 explicit autolink should not be oneboxed 2017-06-27 15:34:16 -04:00
Sam
91a91d57f0 FIX: when quoting always ensure we are on a new line 2017-06-27 13:59:17 -04:00
Sam
e2f57a154b FIX: blockquote button implementation 
Previously clicking on blockquote in the middle of sentence
would result in incorrect formatting
 2017-06-27 13:32:20 -04:00
Neil Lalonde
bca678ee5a FIX: mentions in category boxes are too big 2017-06-27 10:54:43 -04:00
Sam
0e0092d738 corrected a parsing edge cases for bbcode blocks 2017-06-27 10:07:06 -04:00
Jeff Atwood
38950cdc10 add missing span tags to new topic btn 2017-06-27 02:47:10 -07:00
Arpit Jalan
70781749cd UX: add unique class to "most liked" section on user summary page 2017-06-27 14:49:52 +05:30
Guo Xiang Tan
5ff563cddd FIX: Can't cook queued posts when markdown-it is enabled. 2017-06-27 12:24:52 +09:00
Robin Ward
10358811a1 UX: Don't hide the reply button by default 2017-06-26 17:35:28 -04:00
Régis Hanol
aa69f78fed let's not use progressing rendering on images 2017-06-26 23:19:48 +02:00
Sam
21f7ac1f25 correct spec, require closing tag for bbcode blocks 2017-06-26 16:51:55 -04:00
Rafael dos Santos Silva
43ecbc86d4 FEATURE: Use current table styles for markdown-it tables 2017-06-26 16:56:46 -03:00
Sam
8967d50dc2 Clean up sanitization code 
- remove html table test, this is soon to be deprecated
- move sanitization tests into pretty text.rb
- fix up whitelister so it makes a copy of options
 2017-06-26 15:21:47 -04:00
Robin Ward
4f27259e27 UX: Make the edit wiki button more prominent 2017-06-26 14:34:59 -04:00
Sam
e9f55adb3a FEATURE: add table support 2017-06-26 13:25:05 -04:00
Robin Ward
bf592c0ee7 FIX: Wrench would incorrectly on wide browsers with composer up 2017-06-26 13:17:58 -04:00
Sam
df5ee0cfc1 correct onebox rendering so it fills in cached 
the onebox plugin needs to pull in the actual cached onebox
and bypass the whitelister for onebox content
 2017-06-26 13:09:58 -04:00
Robin Ward
c6408550cd Add a little contrast between the wrench and progress bar 2017-06-26 12:32:20 -04:00
Neil Lalonde
eee00b5bb5 UX: include a link to change email preferences at the bottom of summary emails as an alternative to unsubscribing 2017-06-26 12:27:22 -04:00
Sam
81eb3218b2 FEATURE: used strict sanitizer by default 
This amends it so sanitize always uses the most strict sanitizer
by default, if it needs to be "widened" to use more options then
you need to pass it more options.
 2017-06-26 11:27:30 -04:00
Bianca Nenciu
81dc1f039d Added plugin outlet near editor's preview. 2017-06-26 12:13:27 +03:00
Guo Xiang Tan
7ed9fbb415 FIX: Use default parameter in method. 2017-06-26 11:14:13 +09:00
Guo Xiang Tan
1ab60d83df PERF: Terminate scheduled job earlier if badge is not enabled. 2017-06-26 10:13:58 +09:00
Neil Lalonde
69b2d64334 FIX: letter avatars in quotes on subfolders installs are broken 2017-06-23 17:12:13 -04:00
Sam
da5ccd2000 correctly hunt for console.log 2017-06-23 15:24:20 -04:00
Robin Ward
34867a6e07 UX: Support for displaying wrench alongside progress bar 2017-06-23 14:39:18 -04:00
Sam
814c8804d4 correct text highlighting for no highlight 2017-06-23 14:35:46 -04:00
Sam
05e5a740a6 FEATURE: consistent bbcode inline and block rulers 2017-06-23 12:01:33 -04:00
Sam
234694b50f Feature: CommonMark support 
This adds the markdown.it engine to Discourse.
https://github.com/markdown-it/markdown-it

As the migration is going to take a while the new engine is default
disabled. To enable it you must change the hidden site setting:
enable_experimental_markdown_it.

This commit is a squash of many other commits, it also includes some
improvements to autospec (ability to run plugins), and a dev dependency
on the og gem for html normalization.
 2017-06-23 12:01:33 -04:00
Sam
6048ca2b7d Merge pull request #4941 from jjaffeux/emoji-ordering 
Emoji ordering
 2017-06-23 12:00:16 -04:00
Joffrey JAFFEUX
7c68949e04 Emoji ordering 
This commit uses
http://www.unicode.org/emoji/charts/emoji-ordering.html to generate an
automatic ordering of emojis. We also don't have to maintain a full
emoji list for groups but only sub sections.
 2017-06-23 17:51:13 +02:00
Régis Hanol
a682ef5266 calendar should overflow in the 'Feature this topic' modal 2017-06-23 17:51:04 +02:00
Régis Hanol
73a4a05c5b make eslint happy again 2017-06-23 16:06:32 +02:00
Régis Hanol
a9c0df0b58 FIX: always try to convert PNG to JPG when pasting an image 2017-06-23 12:13:48 +02:00
Jeff Atwood
bfd892bbbc better responsive layout for new topic btn 2017-06-23 01:52:09 -07:00
Jeff Atwood
8c9e24e9b0 override desktop styles for mobile topic admin 2017-06-23 00:59:53 -07:00
Guo Xiang Tan
6cc174ca82 PERF: Fetch users in batches in grant anniversary badge job. 2017-06-23 16:54:35 +09:00
Jeff Atwood
c1c778f1e5 move mobile topic admin button to bottom 2017-06-23 00:36:50 -07:00
Guo Xiang Tan
cbedc1a2ca FIX: Notification backdrop does not display when user menu has been toggled. 
https://meta.discourse.org/t/first-pm-spotlight-does-not-work-with-welcome-message-delay/64927/16?u=tgxworld
 2017-06-23 11:35:06 +09:00
Robin Ward
5fda2b84e1 FIX: If the progress bar is docked, set the progress to 100% 2017-06-22 14:43:15 -04:00
Robin Ward
b22df9f166 FIX: Double header rendering issues, redux 2017-06-22 12:50:46 -04:00
Régis Hanol
6e5c59e5ec FIX: image orientation wasn't properly working 2017-06-22 16:53:49 +02:00
Régis Hanol
a916f6b0c8 remove some warnings with already declared constants 2017-06-22 12:55:58 +02:00
Régis Hanol
2e7753c27f User 'FileHelper.is_image?' to check wether a link is poiting to an image 2017-06-22 12:54:42 +02:00
Guo Xiang Tan
80e348d226 PERF: Speed up slow tests in our test suite. 
Before

```
Finished in 7 minutes 23 seconds (files took 4.15 seconds to load)
7145 examples, 0 failures, 10 pending
```

After

```
Finished in 6 minutes 12 seconds (files took 4.41 seconds to load)
7145 examples, 0 failures, 10 pending
```
 2017-06-22 11:23:31 +09:00
Robin Ward
1a02f5154f FIX: Dirty keys should become to a widget, not global 2017-06-21 14:27:08 -04:00
Robin Ward
287cb4bfc5 FEATURE: Allow truncated group posts to be expanded 2017-06-21 12:56:38 -04:00
Robin Ward
32756060bb REFACTOR: Remove unused component 2017-06-21 12:32:56 -04:00
Robin Ward
d09bed0d76 FIX: Some stream items don't have post_id, so expand by topic id / post number 2017-06-21 12:27:39 -04:00
Guo Xiang Tan
4c98bd9d5f FIX: Can't update status_type of topic timers. 
https://meta.discourse.org/t/topic-timers-internal-error-500/64805
 2017-06-21 15:31:15 +09:00
Guo Xiang Tan
dd85c1098b Remove comment that is no longer valid. 2017-06-21 14:10:30 +09:00
Jeff Atwood
0dd1d736c8 user stream UI should match time color 2017-06-20 17:19:53 -07:00
Robin Ward
a289ae67e1 FEATURE: Expand truncated posts in the user stream 2017-06-20 15:45:41 -04:00
Robin Ward
ae7734707e REFACTOR: Merge different templates from rendering user stream items 2017-06-20 15:45:41 -04:00
Guo Xiang Tan
fa35137d3a PERF: Reduce allocations in Emoji.unicode_replacements. 
```
MemoryProfiler.report { Emoji.unicode_replacements }.pretty_print
```

Before:

```
Total allocated: 2032131 bytes (30219 objects)
Total retained:  798059 bytes (10734 objects)

allocated memory by gem
-----------------------------------
   1270762  discourse/app
    690149  2.4.1/lib
     48764  activesupport-4.2.8
     11405  bootsnap-1.0.0
      5266  logster-1.2.7
      2473  hiredis-0.6.1
      2056  redis-3.3.3
       840  discourse/lib
       240  activerecord-4.2.8
       176  thread_safe-0.3.6
```

After:

```
Total allocated: 1715713 bytes (22449 objects)
Total retained:  797985 bytes (10737 objects)

allocated memory by gem
-----------------------------------
    957250  discourse/app
    690028  2.4.1/lib
     48764  activesupport-4.2.8
     11445  bootsnap-1.0.0
      2745  hiredis-0.6.1
      2624  redis-3.3.3
      1473  logster-1.2.7
       928  discourse/lib
       280  activerecord-4.2.8
       176  thread_safe-0.3.6
```
 2017-06-20 13:50:37 +09:00
Guo Xiang Tan
40ef5c4f14 PERF: Reduce memory allocation by Emoji.unicode_replacements. 
Calling `Emoji.tonable_emojis` fetches from the cache but creates
a giant array each time it is called.

```
MemoryProfiler.report { Emoji.unicode_replacements }.pretty_print
```

Before:

```
Total allocated: 16560770 bytes (246364 objects)
Total retained:  784793 bytes (10624 objects)

allocated memory by gem
-----------------------------------
  10224581  activesupport-4.2.8
   3504241  hiredis-0.6.1
   1449466  discourse/app
    679314  2.4.1/lib
    419592  discourse/lib
    226720  redis-3.3.3
     56680  activerecord-4.2.8
       176  thread_safe-0.3.6
```

After:

```
Total allocated: 2127703 bytes (30556 objects)
Total retained:  798099 bytes (10735 objects)

allocated memory by gem
-----------------------------------
   1270762  discourse/app
    690149  2.4.1/lib
    106977  bootsnap-1.0.0
     48764  activesupport-4.2.8
      5266  logster-1.2.7
      2473  hiredis-0.6.1
      2056  redis-3.3.3
       840  discourse/lib
       240  activerecord-4.2.8
       176  thread_safe-0.3.6
```
 2017-06-20 13:10:44 +09:00
Robin Ward
394efb3290 FIX: Docking of progress component on iOS was a bit off 2017-06-19 15:53:51 -04:00
Neil Lalonde
14256e11e7 FIX: topic list wrapping under category list on some screens 2017-06-19 15:23:32 -04:00
Arpit Jalan
34126eb9e0 optimize 'hide help button' code 2017-06-19 22:20:09 +05:30
Jakub Macina
eaf46431d4 Add extraction of file extension in TopicLink and related rspec tests. 2017-06-19 17:09:54 +02:00
Jakub Macina
bf002e0873 Add extraction of image_url for oneboxed images. Fix search by images filter name. 2017-06-19 15:18:02 +02:00
Arpit Jalan
2bf2d506bf UX: hide help button after click 2017-06-19 16:27:31 +05:30
Arpit Jalan
ee1f3a4b25 UX: make font size consistent on password reset modal 2017-06-19 16:09:29 +05:30
Arpit Jalan
74e6717b40 FEATURE: offer help on forgot password modal 2017-06-19 14:05:45 +05:30
hosnas
4d62f41fbc RTL digest emails 
Allows RTL digest emails. 
For this to work, I have done the following major additions:
1- adding appropriate direction to body and tables
2- making text-direction compatible with rtl
3- making float, padding, and margin tags compatible with rtl
 2017-06-16 15:20:20 +04:30
Arpit Jalan
77e886ec90 UX: move optional to the description text for the password field 2017-06-16 15:32:15 +05:30
Guo Xiang Tan
d82dbd565b FIX: Remove dependency on rest-client. 2017-06-16 09:42:41 +09:00
Guo Xiang Tan
b5ec241716 FIX: Validate interpolation keys used in translation overrides. 
https://meta.discourse.org/t/discobot-translation-missing-error/64429/6?u=tgxworld
 2017-06-16 08:54:48 +09:00
Robin Ward
6ab4692431 FEATURE: Add a user's primary group class name to the body tag 2017-06-15 14:25:39 -04:00
Robin Ward
cc525b1a8d Upgrade QUnit to latest version 2017-06-15 10:12:07 -04:00
Robin Ward
8ae445766f Upgrade Ember to 2.13 2017-06-15 10:12:07 -04:00
Guo Xiang Tan
b5249fb4ca FIX: Send request membership PM to last 5 active group owner. 2017-06-15 11:37:09 +08:00
Neil Lalonde
b98a930364 Merge pull request #4896 from dmacjam/multiple-tags-logical-and-search 
FEATURE: Advanced search supports logical AND of multiple tags
 2017-06-14 14:39:23 -04:00
Régis Hanol
d6c63cc5b2 FIX: user's default group should only be set once 
Setting a user's default groups based on their email address should only be done once, ie. when they confirm their email address.
Previously we were doing this everytime we'd save a user record 🤷
 2017-06-14 19:20:18 +02:00
Joffrey JAFFEUX
353d059133 Explains sort/reverse of emoji replacements 2017-06-14 17:54:52 +02:00
Sam
93778500c3 Merge pull request #4929 from jjaffeux/fixes-emojits-not-getting-converted 
Improves native emoji conversion
 2017-06-14 11:44:32 -04:00
Joffrey JAFFEUX
95e1843d33 Improves native emoji conversion 2017-06-14 17:42:52 +02:00
Régis Hanol
31b8477d8b use obj.prop syntax rather than obj[prop] syntax 2017-06-14 17:08:42 +02:00
Régis Hanol
f77e6c8fc6 Merge pull request #4928 from jjaffeux/transform-native-emojis-to-names 
Transforms native emojis to valid names
 2017-06-14 15:43:09 +02:00
Joffrey JAFFEUX
ab6086bce9 Transforms native skin toned emojis to valid names 2017-06-14 15:35:37 +02:00
Régis Hanol
04e175bc06 Merge pull request #4925 from jjaffeux/adds-tones-to-clear-cache 
Makes sure we clear tonable_emojis cache
 2017-06-14 14:56:41 +02:00
Régis Hanol
1ceb64500f Merge pull request #4926 from jjaffeux/fixes-mouse-three 
Uses computer_mouse as base name
 2017-06-14 14:55:48 +02:00
Joffrey JAFFEUX
df75df7169 missing semicolon 2017-06-14 14:47:53 +02:00
Joffrey JAFFEUX
fa508042ff Makes sure we clear tonable_emojis cache 2017-06-14 11:11:02 +02:00
Joffrey JAFFEUX
252c811dae Uses computer_mouse as base name 2017-06-14 11:10:09 +02:00
Régis Hanol
f943efe1a9 remove use of soon-to-be-deprecated 'Discourse.SiteSettings' (cc @eviltrout) 2017-06-14 10:02:13 +02:00
Régis Hanol
493ab9d10e Merge pull request #4923 from jjaffeux/fixes-automobile-emoji-not-displayed 
Fixes automobile being an alias now
 2017-06-14 09:25:10 +02:00
Guo Xiang Tan
2fdf9068eb FIX: Create notification for group users when group has been invited. 
https://meta.discourse.org/t/inviting-a-group-to-a-message-does-not-trigger-a-notification-mail/50509
 2017-06-14 14:53:49 +09:00
Joffrey JAFFEUX
03f3612884 Fixes automobile being an alias now 2017-06-14 07:50:36 +02:00
Robin Ward
867cefc492 Ember.K was deprecated, so let's remove it. 2017-06-13 15:59:48 -04:00
Robin Ward
74858fd450 FIX: Don't show emoji selector when ending a line with a colon 2017-06-13 14:25:31 -04:00
Joffrey JAFFEUX
299339a373 Fixes emoji name to code missing tones 2017-06-13 14:10:26 -04:00
Robin Ward
13f89a53a3 FIX: Autocomplete wasn't showing up for PM user selection 2017-06-13 13:23:27 -04:00
Arpit Jalan
34996b4eff FIX: show invite validation error message in response 2017-06-13 22:41:53 +05:30
Sam
826f332766 Merge pull request #4901 from jjaffeux/emoji-5.0 
Emoji next
 2017-06-13 11:12:41 -04:00
Régis Hanol
5d63a7f4a6 FIX: pull hotlinked images even when they have no extension 2017-06-13 13:27:05 +02:00
Guo Xiang Tan
a5d3abc9b6 FIX: Create group membership request on behalf of user. 2017-06-13 17:49:21 +09:00
Guo Xiang Tan
c5caa9cf71 Revert "FIX: Disable request membership button if user does not have sufficient trust level." 
This reverts commit 5f441a2614.
 2017-06-13 17:49:21 +09:00
Arpit Jalan
baf635c06e UX: better accept invite page on mobile 2017-06-13 07:27:22 +05:30
Régis Hanol
5f6c859744 missing semicolon 2017-06-12 23:01:38 +02:00
Régis Hanol
54e8fb0d89 FEATURE: new 'allow_staff_to_upload_any_file_in_pm' site setting 2017-06-12 22:41:29 +02:00
Neil Lalonde
16475bae89 padding below suggested topics on mobile 2017-06-12 15:46:10 -04:00
Robin Ward
2ff850d446 FIX: If forcing a refresh, don't return a onebox preview 2017-06-12 14:05:59 -04:00
Neil Lalonde
0b41046238 don't force SiteSetting.title into meta title tag 2017-06-12 13:50:50 -04:00
Robin Ward
bd70656b90 FIX: Oneboxing root domains could stop previewing 2017-06-12 12:13:29 -04:00
Arpit Jalan
b9c94aa234 FEATURE: add required user fields to invite accept form 
UX: make "accept invitation" page consistent with sign up modal
 2017-06-12 20:43:07 +05:30
Blake Erickson
9b8bf9c18c reverting add readonly to site settings 
see this commit for more details:

2ffddfb32c (commitcomment-22480952)
 2017-06-12 06:53:57 -06:00
Guo Xiang Tan
eab3562864 Merge pull request #4905 from tgxworld/strip-zero-width-chars-from-search-term 
FIX: Strip zero-width characters from search terms.
 2017-06-12 18:01:02 +09:00
Guo Xiang Tan
5994c85ea9 FIX: Raise the right error when email params is missing. 2017-06-12 17:48:32 +09:00
Guo Xiang Tan
e888369f51 UX: Don't send emails for discobot notifications. 2017-06-12 17:00:27 +09:00
Arpit Jalan
6e37f09b19 UX: add email to '/email/unsubscribed' page 2017-06-10 09:51:12 +05:30
Blake Erickson
2ffddfb32c add Enable read-only to Settings page 2017-06-09 16:07:02 -06:00
Jeff Atwood
5ff986129a copyedit to unsubscribe email 2017-06-09 00:27:24 -07:00
Arpit Jalan
1c0bbcd580 UX: show user email when unsubscribing 2017-06-09 09:20:24 +05:30
Robin Ward
8e2e962b1a FIX: Replace /my/ URLs before fixing the prefix 2017-06-08 16:21:54 -04:00
Robin Ward
d92c938491 FIX: Don't raise an error cleaning up uploads if a path is nil 2017-06-08 14:31:58 -04:00
Régis Hanol
038454bde2 FIX: always confirm emails when SSO says so 2017-06-08 01:05:33 +02:00
Régis Hanol
e8f0771dc9 FIX: the 'clean_up_uploads' jobs would delete images used in site settings 
when they were entered using absolute URLs, with the CDN or simple a different format than the one used in the database
 2017-06-07 22:53:15 +02:00
Robin Ward
54bb2a6bc2 FIX: Don't redirect to wizard when resetting password 2017-06-07 12:36:52 -04:00
Guo Xiang Tan
5794ff53a1 FIX: Copy custom fields when moving first post of a topic. 
https://meta.discourse.org/t/transfer-poll-votes-when-moving-a-topic-into-an-existing-one/63678
 2017-06-07 19:04:48 +09:00
Guo Xiang Tan
684b05f510 FIX: Strip zero-width characters from search terms. 2017-06-07 18:19:47 +09:00
Guo Xiang Tan
2cad739262 FIX: Better error message when username change fails. 
https://meta.discourse.org/t/500-error-on-username-edit/64064
 2017-06-07 10:45:53 +09:00
Guo Xiang Tan
da736f70a4 Merge pull request #4845 from vinothkannans/download-onebox-images 
FEATURE: pull onebox images
 2017-06-07 09:55:04 +09:00
Neil Lalonde
7dfbb5a395 UX: don't hide the subcategory filters when subcategories are listed below 2017-06-06 17:38:59 -04:00
Neil Lalonde
6aa0823bf4 FIX: lounge category security settings won't be reset after an upgrade 2017-06-06 16:57:21 -04:00
Robin Ward
00f06b8086 UX: Show column headers on user topic lists 2017-06-06 16:07:47 -04:00
Vinoth Kannan
209383faab FEATURE: pull onebox images 2017-06-06 18:51:58 +05:30
Robin Ward
63c32b6b21 FIX: Don't animate the progress bar unless scrolling 2017-06-05 15:38:40 -04:00
Robin Ward
02ab2706df FIX: Timeline was wrong sometimes on iPad 2017-06-05 15:23:37 -04:00
Robin Ward
79763a6b97 FIX: If a topic is really long, show the timeline 2017-06-05 13:11:25 -04:00
Joffrey JAFFEUX
2aae6cfdbe look for aliases in Emoji.lookup_unicode 2017-06-05 18:53:11 +02:00
Neil Lalonde
a922db6158 FIX: set max width and prevent wrapping on composer submit button on mobile 2017-06-05 12:25:20 -04:00
Jakub Macina
23d67d2100 Add includes image choice to advanced search ui. 2017-06-05 18:00:15 +02:00
Neil Lalonde
d78956c0c5 FIX: topic flagged message squeezed into a small column 2017-06-05 11:23:23 -04:00
Joffrey JAFFEUX
ab8a1a377c fixes eslint errors 2017-06-05 15:50:15 +02:00
Joffrey JAFFEUX
05f8b5b72e white_sun_small_cloud is an alias 2017-06-05 15:31:24 +02:00
Joffrey JAFFEUX
ba07ae67fb prefer const over let 2017-06-05 14:35:27 +02:00
Joffrey JAFFEUX
f8e5cbd81a prefer const when not reasigned 2017-06-05 14:33:52 +02:00
Joffrey JAFFEUX
64336a8c75 Emoji 5.0 support 2017-06-05 14:06:23 +02:00
Guo Xiang Tan
ac6c1acbed FIX: Groups that do not have any owners should not allow membership requests. 2017-06-05 10:02:37 +09:00
Arpit Jalan
a10c939775 FIX: do not show website name on TL0 profile 2017-06-04 18:30:28 +05:30
Arpit Jalan
2518c6156d UX: add more glyphs on /about page 2017-06-03 08:03:25 +05:30
Arpit Jalan
44cf0bdf9e UX: add admin/moderator icon on /about page 2017-06-03 01:05:26 +05:30
Sam
b4060778d9 FIX: you should always be allowed to see actions you created 2017-06-02 14:24:06 -04:00
Robin Ward
007873af3c FIX: Don't run in testing mode 2017-06-02 12:42:00 -04:00
Robin Ward
62e6108756 FIX: Improper error message 2017-06-02 12:37:03 -04:00
Jakub Macina
eaec35d230 Fix tag related advanced search tests into one context. Fix dynamic locale and select clause in search by all tags. Fix separator for all tags to plus sign. 2017-06-02 12:39:07 +02:00
Guo Xiang Tan
af3dc4e537 FIX: Publish group's categories to user when adding user to group. 
https://meta.discourse.org/t/joining-a-group-doesnt-take-effect-unless-the-browser-is-hard-refreshed/57357/11?u=tgxworld
 2017-06-02 17:38:14 +09:00
Guo Xiang Tan
5f441a2614 FIX: Disable request membership button if user does not have sufficient trust level. 2017-06-02 16:06:25 +09:00
Sam
a7fc93acac FIX: post mover not clearing reply_to_user_id 2017-06-01 18:00:14 -04:00
Sam
e050308f36 FIX: don't allow moderators to save category tracking settings 2017-06-01 15:26:05 -04:00
Guo Xiang Tan
2ee144c27f FEATURE: Add DiscourseEvent trigger when a user logs in. 
* Also adds a event trigger when user logs in for the first time.
 2017-06-01 17:44:49 +09:00
Robin Ward
e66fa82f3a FIX: Don't load JS via SCRIPT tag in QUnit mode 2017-05-31 15:31:24 -04:00
Robin Ward
f8fa25a042 FIX: Be smart about refreshing the topic title when editing the OP 2017-05-31 11:13:16 -04:00
Guo Xiang Tan
b0dd05fdc6 FIX: Inherit topic auto close when changing topic's category. 2017-05-31 17:40:21 +09:00
Guo Xiang Tan
2302493c64 PERF: N+1 query in search when plugin loads custom fields in TopicListItemSerializer. 2017-05-31 09:54:10 +09:00
Robin Ward
76aa651ad4 FIX: Posts weren't cloaking properly 2017-05-30 15:34:00 -04:00
Neil Lalonde
872928bbc1 add loading arg for plugin outlet discovery-list-container-top 2017-05-30 14:30:47 -04:00
Robin Ward
9be782acf6 FIX: Rerender posts when selecting replies 2017-05-30 12:50:31 -04:00
Sam
607998af33 FEATURE: dropdown to filter staff action logs 2017-05-30 11:25:42 -04:00
Neil Lalonde
75c3e7b63c css tweaks to admin user page on mobile 2017-05-29 14:13:33 -04:00
Jakub Macina
2927b45ff2 Add checkbox to contain all tags in advanced search and change separators according its state. 2017-05-29 19:12:07 +02:00
Arpit Jalan
a0acce174c Merge pull request #4888 from techAPJ/invite-full-name 
FEATURE: require name when accepting invite if 'full name required' setting is enabled
 2017-05-29 22:21:32 +05:30
Arpit Jalan
d2c2139da8 FEATURE: require name when accepting invite if 'full name required' setting is enabled 2017-05-29 21:46:43 +05:30
Neil Lalonde
847d831555 FIX: docking position of topic progress at bottom of topic on mobile 2017-05-29 12:14:45 -04:00
Sam
a7e65d98a9 FIX: mutex to avoid race condition with double notify 2017-05-26 17:04:40 -04:00
Robin Ward
81c18fc0bd UX: Add link to the user's preferences page next to the avatar 2017-05-26 15:00:49 -04:00
Sam
aa24bcbcc9 correct annotation 2017-05-26 09:04:54 -04:00
Sam
0aed2533ac Revert unread optimisation, has too many edge cases 2017-05-26 09:04:13 -04:00
Guo Xiang Tan
e57d2f5cb8 FIX: Don't do anything if avatar url returns an invalid status code. 2017-05-26 13:02:40 +08:00
Sam Saffron
7d59ff67b8 adjust qurey to include messages, once everything is read 
then mark first_topic_unread_at to be current time
 2017-05-25 18:40:32 -04:00
Robin Ward
39e1948174 FIX: If the error is 401 unauthorized or such, just do nothing 2017-05-25 15:42:05 -04:00
Robin Ward
b584264d82 FIX: Don't show "resend email" option when user approval is on 2017-05-25 15:29:05 -04:00
Sam
29fac1ac18 PERF: improve performance of unread queries 
Figuring out what unread topics a user has is a very expensive
operation over time.

Users can easily accumulate 10s of thousands of tracking state rows
(1 for every topic they ever visit)

When figuring out what a user has that is unread we need to join
the tracking state records to the topic table. This can very quickly
lead to cases where you need to scan through the entire topic table.

This commit optimises it so we always keep track of the "first" date
a user has unread topics. Then we can easily filter out all earlier
topics from the join.

We use pg functions, instead of nested queries here to assist the
planner.
 2017-05-25 15:07:30 -04:00
Robin Ward
6eb6c25816 FIX: Keep the flash when redirecting for login_required 2017-05-25 14:10:15 -04:00
Robin Ward
ca965f83c3 Revert "FIX: If login is required, redirect to the /login route instead of root" 
This reverts commit 8a8dec550b.
 2017-05-25 14:04:28 -04:00
Robin Ward
8a8dec550b FIX: If login is required, redirect to the /login route instead of root 2017-05-25 13:35:15 -04:00
Neil Lalonde
f8584e28d7 UX: improved layout of flag handling UI on mobile 2017-05-24 15:52:29 -04:00
Robin Ward
f481708348 FIX: Sometimes the duplicate link text made no sense 2017-05-24 14:07:29 -04:00
Robin Ward
0a08c18a14 FIX: Don't rate limit gravatar downloads 2017-05-24 13:54:26 -04:00
Robin Ward
cdbe027c1c Refactor FileHelper to use keyword arguments. 2017-05-24 13:54:26 -04:00
Robin Ward
87ac758f05 FIX: Don't raise an error when the upload can't be retrieved 2017-05-24 13:54:26 -04:00
Sam
e8c89b4535 Merge pull request #4865 from chrisgavin/login-button-fix 
Fix the padding on the login and register buttons.
 2017-05-24 12:41:07 -04:00
Neil Lalonde
4266828c62 FIX: incorrect margins on buttons in modals on mobile 2017-05-24 11:57:26 -04:00
Sam
d0f84aa14e FIX: missing to_i which breaks selector component for anon 2017-05-24 11:39:10 -04:00
Robin Ward
b78b010757 FIX: Fixes to grant new user of the month badge 2017-05-24 11:36:24 -04:00
Neil Lalonde
0756602dfa UX: h1, h2, etc css reset should give them a bottom margin 2017-05-24 10:38:25 -04:00
Neil Lalonde
c9028f517a UX: headings in banners had no margins 2017-05-23 11:25:40 -04:00
Neil Lalonde
9edc490d3f FIX: remove memoized values in jobs 2017-05-22 16:26:30 -04:00
Robin Ward
b23fc2bf84 Helper to find the final destination for a URL 2017-05-22 15:52:41 -04:00
Neil Lalonde
f350dd4fd1 FIX: possible data leaking from one site to another in multisite in PendingFlagsReminder 2017-05-22 15:18:13 -04:00
Arpit Jalan
decb432740 FIX: fill date input with default date range 2017-05-22 21:54:28 +05:30
Robin Ward
773445b8df FIX: Topic Crawling should only crawl HTTP/S urls 2017-05-22 11:57:20 -04:00
Guo Xiang Tan
08c36fa968 REFACTOR: Clean up some code associated with topic timers. 2017-05-22 18:10:29 +08:00
Guo Xiang Tan
604aaf8686 FIX: N+1 query in suggested topics list. 2017-05-22 18:05:38 +08:00
Guo Xiang Tan
238a156300 FIX: TopicTimestampChanger should not allow timestamps in the future. 2017-05-22 16:03:49 +08:00
Guo Xiang Tan
4382a0bb07 Rename PostTimestampChanger -> TopicTimestampChanger. 2017-05-22 15:01:33 +08:00
Jeff Atwood
393c060047 use moon glyph to denote "later today" 2017-05-19 17:02:00 -07:00