Commit Graph

56871 Commits

Author SHA1 Message Date
dependabot[bot]
2d9e0e39e8
Build(deps-dev): Bump webmock from 3.23.1 to 3.24.0 (#29035)
Bumps [webmock](https://github.com/bblimke/webmock) from 3.23.1 to 3.24.0.
- [Changelog](https://github.com/bblimke/webmock/blob/master/CHANGELOG.md)
- [Commits](https://github.com/bblimke/webmock/compare/v3.23.1...v3.24.0)

---
updated-dependencies:
- dependency-name: webmock
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-10-01 11:33:11 +08:00
dependabot[bot]
fd20c1358a
Build(deps-dev): Bump lefthook from 1.7.17 to 1.7.18 (#29036)
Bumps [lefthook](https://github.com/evilmartians/lefthook) from 1.7.17 to 1.7.18.
- [Release notes](https://github.com/evilmartians/lefthook/releases)
- [Changelog](https://github.com/evilmartians/lefthook/blob/master/CHANGELOG.md)
- [Commits](https://github.com/evilmartians/lefthook/compare/v1.7.17...v1.7.18)

---
updated-dependencies:
- dependency-name: lefthook
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-10-01 11:32:58 +08:00
Daniel Waterworth
c544686540
DEV: Add expires flag to enable_readonly (#29033)
... to control whether readonly mode expires or not.
2024-09-30 13:59:51 -05:00
Kris
8cef93a45d
UX: prevent user stream title from overflowing page (#29032) 2024-09-30 13:10:23 -04:00
Régis Hanol
252dcfbfa6
FIX: create an automation with forced_triggerable enabled (#29030)
When trying to create a new automation based on a scriptable that has "force_triggerable" enable, it would break because of a typo in the code.

This fixes the typo and add a spec to ensure this code path is tested.
2024-09-30 17:42:00 +02:00
dependabot[bot]
edcc581d43
Build(deps-dev): Bump ember-load-initializers from 2.1.2 to 3.0.1 (#29016)
Bumps [ember-load-initializers](https://github.com/ember-cli/ember-load-initializers) from 2.1.2 to 3.0.1.
- [Release notes](https://github.com/ember-cli/ember-load-initializers/releases)
- [Changelog](https://github.com/ember-cli/ember-load-initializers/blob/master/CHANGELOG.md)
- [Commits](https://github.com/ember-cli/ember-load-initializers/compare/v2.1.2...v3.0.1)

---
updated-dependencies:
- dependency-name: ember-load-initializers
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-09-30 16:51:34 +02:00
Kris
cd220299cf
UX: Add label for delete own post button in review queue (#28991) 2024-09-30 10:35:16 -04:00
dependabot[bot]
4cc2cd4de4
Build(deps-dev): Bump puppeteer-core from 23.4.0 to 23.4.1 (#29010)
Bumps [puppeteer-core](https://github.com/puppeteer/puppeteer) from 23.4.0 to 23.4.1.
- [Release notes](https://github.com/puppeteer/puppeteer/releases)
- [Changelog](https://github.com/puppeteer/puppeteer/blob/main/release-please-config.json)
- [Commits](https://github.com/puppeteer/puppeteer/compare/puppeteer-core-v23.4.0...puppeteer-core-v23.4.1)

---
updated-dependencies:
- dependency-name: puppeteer-core
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-09-30 16:22:00 +02:00
dependabot[bot]
3f6789cc99
Build(deps): Bump terser from 5.33.0 to 5.34.1 (#29021)
Bumps [terser](https://github.com/terser/terser) from 5.33.0 to 5.34.1.
- [Changelog](https://github.com/terser/terser/blob/master/CHANGELOG.md)
- [Commits](https://github.com/terser/terser/compare/v5.33.0...v5.34.1)

---
updated-dependencies:
- dependency-name: terser
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-09-30 15:18:03 +02:00
dependabot[bot]
859f4a5601
Build(deps): Bump @faker-js/faker from 9.0.1 to 9.0.3 (#29014)
Bumps [@faker-js/faker](https://github.com/faker-js/faker) from 9.0.1 to 9.0.3.
- [Release notes](https://github.com/faker-js/faker/releases)
- [Changelog](https://github.com/faker-js/faker/blob/next/CHANGELOG.md)
- [Commits](https://github.com/faker-js/faker/compare/v9.0.1...v9.0.3)

---
updated-dependencies:
- dependency-name: "@faker-js/faker"
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-09-30 14:51:09 +02:00
dependabot[bot]
55cd10baff
Build(deps-dev): Bump webpack from 5.94.0 to 5.95.0 (#29007)
Bumps [webpack](https://github.com/webpack/webpack) from 5.94.0 to 5.95.0.
- [Release notes](https://github.com/webpack/webpack/releases)
- [Commits](https://github.com/webpack/webpack/compare/v5.94.0...v5.95.0)

---
updated-dependencies:
- dependency-name: webpack
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-09-30 14:50:21 +02:00
dependabot[bot]
949a9b2bd6
Build(deps-dev): Bump selenium-devtools from 0.128.0 to 0.129.0 (#28988)
Bumps [selenium-devtools](https://github.com/SeleniumHQ/selenium) from 0.128.0 to 0.129.0.
- [Release notes](https://github.com/SeleniumHQ/selenium/releases)
- [Changelog](https://github.com/SeleniumHQ/selenium/blob/trunk/rb/CHANGES)
- [Commits](https://github.com/SeleniumHQ/selenium/commits)

---
updated-dependencies:
- dependency-name: selenium-devtools
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-09-30 14:12:55 +02:00
dependabot[bot]
b2505bbe11
Build(deps): Bump ember-auto-import from 2.8.0 to 2.8.1 (#28982)
Bumps [ember-auto-import](https://github.com/embroider-build/ember-auto-import/tree/HEAD/packages/ember-auto-import) from 2.8.0 to 2.8.1.
- [Release notes](https://github.com/embroider-build/ember-auto-import/releases)
- [Changelog](https://github.com/embroider-build/ember-auto-import/blob/main/packages/ember-auto-import/CHANGELOG.md)
- [Commits](https://github.com/embroider-build/ember-auto-import/commits/HEAD/packages/ember-auto-import)

---
updated-dependencies:
- dependency-name: ember-auto-import
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-09-30 14:06:20 +02:00
dependabot[bot]
cda4120065
Build(deps): Bump ember-template-imports from 4.1.1 to 4.1.2 (#29003)
Bumps [ember-template-imports](https://github.com/ember-template-imports/ember-template-imports) from 4.1.1 to 4.1.2.
- [Release notes](https://github.com/ember-template-imports/ember-template-imports/releases)
- [Changelog](https://github.com/ember-template-imports/ember-template-imports/blob/master/CHANGELOG.md)
- [Commits](https://github.com/ember-template-imports/ember-template-imports/commits)

---
updated-dependencies:
- dependency-name: ember-template-imports
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-09-30 14:05:25 +02:00
dependabot[bot]
00652244f7
Build(deps-dev): Bump esbuild from 0.23.1 to 0.24.0 (#28983)
Bumps [esbuild](https://github.com/evanw/esbuild) from 0.23.1 to 0.24.0.
- [Release notes](https://github.com/evanw/esbuild/releases)
- [Changelog](https://github.com/evanw/esbuild/blob/main/CHANGELOG.md)
- [Commits](https://github.com/evanw/esbuild/compare/v0.23.1...v0.24.0)

---
updated-dependencies:
- dependency-name: esbuild
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-09-30 13:46:28 +02:00
dependabot[bot]
bc852bc2a2
Build(deps-dev): Bump uglifier from 4.2.0 to 4.2.1 (#28990)
Bumps [uglifier](https://github.com/lautis/uglifier) from 4.2.0 to 4.2.1.
- [Changelog](https://github.com/lautis/uglifier/blob/master/CHANGELOG.md)
- [Commits](https://github.com/lautis/uglifier/compare/v4.2.0...v4.2.1)

---
updated-dependencies:
- dependency-name: uglifier
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-09-30 16:08:10 +08:00
dependabot[bot]
6d05e12d4e
Build(deps-dev): Bump qunit-dom from 3.2.0 to 3.2.1 (#28995)
Bumps [qunit-dom](https://github.com/mainmatter/qunit-dom) from 3.2.0 to 3.2.1.
- [Release notes](https://github.com/mainmatter/qunit-dom/releases)
- [Changelog](https://github.com/mainmatter/qunit-dom/blob/master/CHANGELOG.md)
- [Commits](https://github.com/mainmatter/qunit-dom/commits)

---
updated-dependencies:
- dependency-name: qunit-dom
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-09-30 16:07:45 +08:00
dependabot[bot]
a18faa08ba
Build(deps-dev): Bump rubocop-rails from 2.26.1 to 2.26.2 (#28989)
Bumps [rubocop-rails](https://github.com/rubocop/rubocop-rails) from 2.26.1 to 2.26.2.
- [Release notes](https://github.com/rubocop/rubocop-rails/releases)
- [Changelog](https://github.com/rubocop/rubocop-rails/blob/master/CHANGELOG.md)
- [Commits](https://github.com/rubocop/rubocop-rails/compare/v2.26.1...v2.26.2)

---
updated-dependencies:
- dependency-name: rubocop-rails
  dependency-type: indirect
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-09-30 16:05:59 +08:00
dependabot[bot]
8ad4f58751
Build(deps-dev): Bump selenium-webdriver from 4.24.0 to 4.25.0 (#28987)
Bumps [selenium-webdriver](https://github.com/SeleniumHQ/selenium) from 4.24.0 to 4.25.0.
- [Release notes](https://github.com/SeleniumHQ/selenium/releases)
- [Changelog](https://github.com/SeleniumHQ/selenium/blob/trunk/rb/CHANGES)
- [Commits](https://github.com/SeleniumHQ/selenium/compare/selenium-4.24.0...selenium-4.25.0)

---
updated-dependencies:
- dependency-name: selenium-webdriver
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-09-30 16:03:42 +08:00
GeckoLinux
d99b73d489
UX: Proper description of the allowed_iframes setting (#28997)
https://meta.discourse.org/t/regression-iframe-embedding-broken-with-allowed-src-domain/327852/13

The `allowed_iframes` isn't a list of simple domain names; it requires a full or partial URL with `https://` at the beginning and a trailing slash at the end.
2024-09-30 16:45:06 +10:00
Martin Brennan
5432d9bafe
UX: Minor admin mobile fixes (#29028)
* Fixes big gap at the left of the plugins list.
* Fixes plugin settings list padding, the yellow overridden
  dot was cut off on mobile.
* Also increased settings filter input size and settings
  sidebar button margin.
2024-09-30 16:04:46 +10:00
Ted Johansson
e0a0a13a91
FIX: Fix broken client-side review actions (#29025)
After #28603, the options "agree and suspend" and "agree and silence" in the review queue weren't working. This was happening because the optionalService, when used as a decorator, needs a name argument to work properly. We were also lacking tests for this.
2024-09-30 13:27:25 +08:00
Martin Brennan
73f42e110a
FIX: Unscoped plugin config page actions outlet (#29026)
In 61c1d35f17 I added a
PluginOutlet to AdminPluginConfigPage. This was intended to be
used as a way to render actions buttons inside the header of
a plugin that has a custom admin UI page. This worked, but
since the outlet was generically named, as soon as one plugin
used it the button would show on all plugins.

This fixes the immediate issue by naming the outlet based
on the plugin, then having each plugin specify their own
outlet to render into. There may be a nicer way to do this,
but for now this stops the bleeding.
2024-09-30 14:35:23 +10:00
Sam
f6df0f8789
Revert "DEV: upgrade mini_racer (#29023)" (#29027)
This reverts commit 042bfeac66.

as expected still segfaulting
2024-09-30 14:34:04 +10:00
Alan Guo Xiang Tan
c8bec538c3
DEV: Only enable our self hosted runners on the discourse/discourse repo (#29024)
Our self hosted runners does not work for forked repositories.
2024-09-30 11:18:20 +08:00
dependabot[bot]
20a3f976a2
Build(deps): Bump ember-resolver from 13.0.1 to 13.0.2 (#29004)
Bumps [ember-resolver](https://github.com/ember-cli/ember-resolver) from 13.0.1 to 13.0.2.
- [Release notes](https://github.com/ember-cli/ember-resolver/releases)
- [Changelog](https://github.com/ember-cli/ember-resolver/blob/main/CHANGELOG.md)
- [Commits](https://github.com/ember-cli/ember-resolver/compare/v13.0.1...v13.0.2)

---
updated-dependencies:
- dependency-name: ember-resolver
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-09-30 04:20:42 +02:00
Alan Guo Xiang Tan
37abd93564
DEV: Remove unused file (#28980)
This was added 11 years ago and I don't see us using this anywhere.
2024-09-30 10:18:51 +08:00
dependabot[bot]
2dae20c054
Build(deps-dev): Bump sqlite3 from 2.0.4 to 2.1.0 (#29001)
Bumps [sqlite3](https://github.com/sparklemotion/sqlite3-ruby) from 2.0.4 to 2.1.0.
- [Release notes](https://github.com/sparklemotion/sqlite3-ruby/releases)
- [Changelog](https://github.com/sparklemotion/sqlite3-ruby/blob/main/CHANGELOG.md)
- [Commits](https://github.com/sparklemotion/sqlite3-ruby/compare/v2.0.4...v2.1.0)

---
updated-dependencies:
- dependency-name: sqlite3
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-09-30 02:08:32 +02:00
dependabot[bot]
32f330515c
Build(deps): Bump irb from 1.14.0 to 1.14.1 (#29012)
Bumps [irb](https://github.com/ruby/irb) from 1.14.0 to 1.14.1.
- [Release notes](https://github.com/ruby/irb/releases)
- [Commits](https://github.com/ruby/irb/compare/v1.14.0...v1.14.1)

---
updated-dependencies:
- dependency-name: irb
  dependency-type: indirect
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-09-30 02:06:11 +02:00
dependabot[bot]
19c83ddf3a
Build(deps): Bump rexml from 3.3.7 to 3.3.8 (#29019)
Bumps [rexml](https://github.com/ruby/rexml) from 3.3.7 to 3.3.8.
- [Release notes](https://github.com/ruby/rexml/releases)
- [Changelog](https://github.com/ruby/rexml/blob/master/NEWS.md)
- [Commits](https://github.com/ruby/rexml/compare/v3.3.7...v3.3.8)

---
updated-dependencies:
- dependency-name: rexml
  dependency-type: indirect
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-09-30 02:05:16 +02:00
dependabot[bot]
40ce25c2a0
Build(deps-dev): Bump lefthook from 1.7.15 to 1.7.17 (#29015)
Bumps [lefthook](https://github.com/evilmartians/lefthook) from 1.7.15 to 1.7.17.
- [Release notes](https://github.com/evilmartians/lefthook/releases)
- [Changelog](https://github.com/evilmartians/lefthook/blob/master/CHANGELOG.md)
- [Commits](https://github.com/evilmartians/lefthook/compare/v1.7.15...v1.7.17)

---
updated-dependencies:
- dependency-name: lefthook
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-09-30 02:04:56 +02:00
dependabot[bot]
2d849e2809
Build(deps-dev): Bump jsuites from 5.6.2 to 5.6.4 (#29017)
Bumps [jsuites](https://github.com/jsuites/jsuites) from 5.6.2 to 5.6.4.
- [Release notes](https://github.com/jsuites/jsuites/releases)
- [Changelog](https://github.com/jsuites/jsuites/blob/master/changelog.md)
- [Commits](https://github.com/jsuites/jsuites/commits)

---
updated-dependencies:
- dependency-name: jsuites
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-09-30 02:04:00 +02:00
dependabot[bot]
df8f8cfa0a
Build(deps-dev): Bump @embroider/core in the embroider group (#28981)
Bumps the embroider group with 1 update: [@embroider/core](https://github.com/embroider-build/embroider/tree/HEAD/packages/core).


Updates `@embroider/core` from 3.4.15 to 3.4.16
- [Release notes](https://github.com/embroider-build/embroider/releases)
- [Changelog](https://github.com/embroider-build/embroider/blob/main/CHANGELOG.md)
- [Commits](https://github.com/embroider-build/embroider/commits/HEAD/packages/core)

---
updated-dependencies:
- dependency-name: "@embroider/core"
  dependency-type: direct:development
  update-type: version-update:semver-patch
  dependency-group: embroider
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-09-30 02:02:51 +02:00
dependabot[bot]
47f44b40f4
Build(deps-dev): Bump @types/jquery in the types group (#29006)
Bumps the types group with 1 update: [@types/jquery](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/jquery).


Updates `@types/jquery` from 3.5.30 to 3.5.31
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/jquery)

---
updated-dependencies:
- dependency-name: "@types/jquery"
  dependency-type: direct:development
  update-type: version-update:semver-patch
  dependency-group: types
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-09-30 01:59:32 +02:00
Krzysztof Kotlarek
c5a024f8df
FIX: custom flag name should be unique (#28869)
Validation to ensure that the custom flag name is unique.
2024-09-30 09:17:19 +10:00
Sam
042bfeac66
DEV: upgrade mini_racer (#29023)
This is attempt 5 at upgrading mini racer, fixes some edge conditions in
mini_racer that can lead to segfaults.
2024-09-30 09:12:14 +10:00
Linca
a1e5796ba1
FEAT: Allow admin delete user's associated accounts (#29018)
This commit introduces a feature that allows an admin to delete a user's
associated account. After deletion, a log will be recorded in staff
actions.

ref=t/136675
2024-09-27 20:08:05 +08:00
Bianca Nenciu
e2f3474bc3
FIX: permanent delete of posts by deleted users (#28992)
Permanently deleting posts that no longer have a user associated was not
working as expected because of UserAction.log which expected user_id to
be present.
2024-09-24 12:26:31 +03:00
dependabot[bot]
ed4791d0b0
Build(deps): Bump sprockets from 3.7.4 to 3.7.5 (#28977)
Bumps [sprockets](https://github.com/rails/sprockets) from 3.7.4 to 3.7.5.
- [Release notes](https://github.com/rails/sprockets/releases)
- [Changelog](https://github.com/rails/sprockets/blob/v3.7.5/CHANGELOG.md)
- [Commits](https://github.com/rails/sprockets/compare/v3.7.4...v3.7.5)

---
updated-dependencies:
- dependency-name: sprockets
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-09-20 14:35:56 +02:00
Loïc Guitaut
78d9f9fa40 DEV: Rename ServiceRunner to Service::Runner for consistency 2024-09-20 10:04:42 +02:00
dependabot[bot]
a4ccdeccb3
Build(deps): Bump puma from 6.4.2 to 6.4.3 (#28978)
Bumps [puma](https://github.com/puma/puma) from 6.4.2 to 6.4.3.
- [Release notes](https://github.com/puma/puma/releases)
- [Changelog](https://github.com/puma/puma/blob/master/History.md)
- [Commits](https://github.com/puma/puma/compare/v6.4.2...v6.4.3)

---
updated-dependencies:
- dependency-name: puma
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-09-20 09:45:21 +08:00
Loïc Guitaut
afdb1ac0a0 DEV: Disallow default params in service steps
With the current implementation, a service step can be written as:
```ruby
def my_step(a_default_value: 2)
  …
end
```
That’s a pattern we want to avoid as default values (if needed) should
be probably defined in a contract.

This patch makes a service raise an exception if a default value is
encountered.
2024-09-19 14:47:55 +02:00
Loïc Guitaut
fe1098ebac FIX: Don’t raise on some search terms
Currently, when certain search terms are provided, this can lead to
`Search.need_segmenting?` raising an error because it makes `URI#path`
to return `nil` instead of a string.

This patch forces a cast to string so it won’t raise anymore.
2024-09-19 11:35:10 +02:00
Ted Johansson
e68748318e
DEV: Remove FileStore#download deprecation warning (#28971)
At a point we split FileStore#download into two methods, one which returns nil (#download) and one which raises an exception (#download!) if there's a download error.

When we did this we added a deprecation warning to the #download method.

It has now been over a year and I have checked all relevant internal cases, so I think it's about time we remove this warning.
2024-09-19 11:08:26 +08:00
Alan Guo Xiang Tan
848af05537
DEV: Fix failing system tests (#28970)
We are seeing the following error on CI:

```
Errno::EADDRNOTAVAIL:
  Failed to open TCP connection to localhost:31337 (Cannot assign requested address - connect(2) for "localhost" port 31337)
```

This is because the job being enqueued makes a HTTP request to the Rails
server but Capybara doesn't start the Rails server until a session is
actually required. Therefore, we need to enqueue the job after we are
sure that a session has been started.
2024-09-19 10:12:38 +08:00
Sam Saffron
f22316d0cd Revert "DEV: attempt another upgrade on mini_racer (#28951)"
This reverts commit 68e017c324.

Still seeing faults ... we had 1 segfault in 7 hours.
2024-09-19 09:48:01 +10:00
dependabot[bot]
68ff66dda3
Build(deps): Bump faraday from 2.11.0 to 2.12.0 (#28967)
Bumps [faraday](https://github.com/lostisland/faraday) from 2.11.0 to 2.12.0.
- [Release notes](https://github.com/lostisland/faraday/releases)
- [Changelog](https://github.com/lostisland/faraday/blob/main/CHANGELOG.md)
- [Commits](https://github.com/lostisland/faraday/compare/v2.11.0...v2.12.0)

---
updated-dependencies:
- dependency-name: faraday
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-09-19 01:19:03 +02:00
dependabot[bot]
705b49f0a2
Build(deps): Bump google-protobuf from 4.28.1 to 4.28.2 (#28968)
Bumps [google-protobuf](https://github.com/protocolbuffers/protobuf) from 4.28.1 to 4.28.2.
- [Release notes](https://github.com/protocolbuffers/protobuf/releases)
- [Changelog](https://github.com/protocolbuffers/protobuf/blob/main/protobuf_release.bzl)
- [Commits](https://github.com/protocolbuffers/protobuf/commits)

---
updated-dependencies:
- dependency-name: google-protobuf
  dependency-type: indirect
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-09-19 01:18:56 +02:00
dependabot[bot]
c690412642
Build(deps-dev): Bump puppeteer-core from 23.3.1 to 23.4.0 (#28964)
Bumps [puppeteer-core](https://github.com/puppeteer/puppeteer) from 23.3.1 to 23.4.0.
- [Release notes](https://github.com/puppeteer/puppeteer/releases)
- [Changelog](https://github.com/puppeteer/puppeteer/blob/main/release-please-config.json)
- [Commits](https://github.com/puppeteer/puppeteer/compare/puppeteer-core-v23.3.1...puppeteer-core-v23.4.0)

---
updated-dependencies:
- dependency-name: puppeteer-core
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-09-19 00:55:25 +02:00
Kris
5628b640db
DEV: add topic-list-after-columns outlet to mobile (#28963) 2024-09-18 17:29:42 -04:00