discourse

github-mirror/discourse

Fork 0

mirror of https://github.com/discourse/discourse.git synced 2025-03-03 01:27:23 +08:00

Commit Graph

Author SHA1 Message Date

Author	SHA1	Message	Date
Jarek Radosz	cd69891b14	DEV: Fix `no-unnecessary-curly-parens` lint rule (#24581 )	2023-11-28 10:35:36 +01:00
Martin Brennan	68a912952c	FIX: min/max not passed to NumberField for site settings (#24402 ) When we started using NumberField for integer site settings in e113eff6634c9b398b0541ea6a0d1626f6732dcc, we did not end up passing down a min/max value for the integer to the field, which meant that for some fields where negative numbers were allowed we were not accepting that as valid input. This commit passes down the min/max options from the server for integer settings then in turn passes them down to NumberField. c.f. https://meta.discourse.org/t/delete-user-self-max-post-count-not-accepting-1-to-disable/285162	2023-11-16 12:37:05 +10:00
Ted Johansson	e113eff663	DEV: Sanitize integer site settings in front- and back-end (#23816 ) Currently, if you set an integer site setting in the admin interface and include thousands separators, you will silently configure the wrong value. This PR replaces TextField inputs for integer site settings with NumberField. It also cleans the numeric input of any non-digits in the backend in case any separators make it through.	2023-10-06 19:21:01 +02:00

Jarek Radosz

cd69891b14

DEV: Fix no-unnecessary-curly-parens lint rule (#24581 )

2023-11-28 10:35:36 +01:00

Martin Brennan

68a912952c

FIX: min/max not passed to NumberField for site settings (#24402 )

When we started using NumberField for integer site settings
in e113eff6634c9b398b0541ea6a0d1626f6732dcc, we did not end up
passing down a min/max value for the integer to the field, which
meant that for some fields where negative numbers were allowed
we were not accepting that as valid input.

This commit passes down the min/max options from the server for
integer settings then in turn passes them down to NumberField.

c.f. https://meta.discourse.org/t/delete-user-self-max-post-count-not-accepting-1-to-disable/285162

2023-11-16 12:37:05 +10:00

Ted Johansson

e113eff663

DEV: Sanitize integer site settings in front- and back-end (#23816 )

Currently, if you set an integer site setting in the admin interface and include thousands separators, you will silently configure the wrong value.

This PR replaces TextField inputs for integer site settings with NumberField. It also cleans the numeric input of any non-digits in the backend in case any separators make it through.

2023-10-06 19:21:01 +02:00

3 Commits