github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2024-12-02 06:33:55 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity
40,381 Commits 214 Branches 500 Tags 960 MiB
d6aadf60bd
Commit Graph

40381 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
dependabot[bot]
e527741577
Build(deps): Bump rubocop-ast from 1.1.1 to 1.2.0 (#11343) 
Bumps [rubocop-ast](https://github.com/rubocop-hq/rubocop-ast) from 1.1.1 to 1.2.0.
- [Release notes](https://github.com/rubocop-hq/rubocop-ast/releases)
- [Changelog](https://github.com/rubocop-hq/rubocop-ast/blob/master/CHANGELOG.md)
- [Commits](https://github.com/rubocop-hq/rubocop-ast/compare/v1.1.1...v1.2.0)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2020-11-25 09:17:55 +11:00
Joffrey JAFFEUX
ad1a10e6e9
FIX: hides votes from regular users when poll is staff only (#11342) 2020-11-24 22:19:06 +01:00
Rafael dos Santos Silva
a6613d15f4
Adds discourse-gifs to suggested components (#11339) 2020-11-24 14:58:45 -03:00
Discourse Translator Bot
9c901ee978
Update translations (#11336) 2020-11-24 17:25:37 +01:00
Robin Ward
0e0c70019b FIX: Suggested Topics was being set inside a computed property 
This is bad because changing the `suggested_topics` proeprty could cause
a `set` on `suggested_topics`.
 2020-11-24 11:08:11 -05:00
Penar Musaraj
67979b2b21
Remove "Alternative Logos" from popular themes list (#11337) 
Core has had support for dark theme logos for a while now.
 2020-11-24 10:13:16 -05:00
David Taylor
0c685a46de
FEATURE: Add user update, anonymize and delete API scopes (#11335) 2020-11-24 12:54:24 +00:00
Roman Rizzi
7ad2c2bdd8
FIX: Exclude muted results when suggested related topics at random. (#11290) 
We already do this for new and unread results, but not for randomly suggested topics.
 2020-11-24 09:16:10 -03:00
Dan Ungureanu
123107c28f
UX: Add group name to error message (#11333) 
The group name used to be part of the error message, but was removed
in a past commit.
 2020-11-24 13:06:52 +02:00
Dan Ungureanu
2742595b00
FIX: Checkbox value should not leak between themes (#11327) 
This commit includes a hack to ensure didInsertElement is called only
once.
 2020-11-24 12:10:28 +02:00
Penar Musaraj
4b538e7cb9
DEV: Skip missing icon warnings in production (#11334) 
The list of SVG icons is unavailable in production, and the previous
refactor here was causing incorrect and noisy console warnings.

This also parses the `svgIconList` string in a dev environment, icons
should now match more accurately.
 2020-11-23 21:41:54 -05:00
dependabot[bot]
0d8d568654
Build(deps-dev): Bump parallel_tests from 3.3.0 to 3.4.0 (#11331) 
Bumps [parallel_tests](https://github.com/grosser/parallel_tests) from 3.3.0 to 3.4.0.
- [Release notes](https://github.com/grosser/parallel_tests/releases)
- [Changelog](https://github.com/grosser/parallel_tests/blob/master/CHANGELOG.md)
- [Commits](https://github.com/grosser/parallel_tests/compare/v3.3.0...v3.4.0)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2020-11-23 22:27:27 +01:00
dependabot[bot]
5a4811ede8
Build(deps): Bump rubocop from 1.3.1 to 1.4.1 (#11332) 
Bumps [rubocop](https://github.com/rubocop-hq/rubocop) from 1.3.1 to 1.4.1.
- [Release notes](https://github.com/rubocop-hq/rubocop/releases)
- [Changelog](https://github.com/rubocop-hq/rubocop/blob/master/CHANGELOG.md)
- [Commits](https://github.com/rubocop-hq/rubocop/compare/v1.3.1...v1.4.1)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2020-11-23 22:24:48 +01:00
Jarek Radosz
de2d323ccf
UX: Slightly adjust onebox alignment (#11326) 
* fixed header/favicon's vertical alignment
* slightly increased header margin
* made the onebox padding symmetrical
* increased the right margin on small image elements
* removed extraneous pre bottom margin
 2020-11-23 22:16:50 +01:00
chenyxuan
defbae4007
FIX: Force string conversions to UTF-8 "bytes" (#11315) 
https://meta.discourse.org/t/cant-create-poll-with-some-chinese-options/170836
 2020-11-23 17:51:05 +01:00
Robin Ward
3394d994e9 FIX: Tests were using jQuery selectors 
For the most part `querySelectorAll` will work with jQuery selectors,
but the big exception is `:eq(0)` and similar. Those needed to be
replaced.
 2020-11-23 11:36:07 -05:00
Bianca Nenciu
60bc38e6a8
FIX: Gracefully handle force pushes for remote themes (#11325) 
Force pushing a commit to a theme repository used to break the updater,
because the system was not able to count the commits behind the old and
new version. This operation failed because a force push deleted the old
commits.

The user was prompted with a simple "500 server error" message.
 2020-11-23 15:29:22 +02:00
Vinoth Kannan
139c5dc356
FIX: use tag model instead of tagId property. (#11298) 
In a recent commit 866fa008d4 support for tagId property is removed.

And added a test case. Follow-up for 2d5bb516a6.
 2020-11-23 16:40:15 +05:30
David Taylor
20c0da8516
FIX: Improve email validation error handling for external logins (#11307) 
- Display reason for validation error when logging in via an authenticator
- Fix email validation handling for 'Discourse SSO', and add a spec

Previously, validation errors (e.g. blocked or already-taken emails) would raise a generic error with no useful information.
 2020-11-23 11:06:08 +00:00
Dan Ungureanu
4638c6fc8d
FEATURE: Add 'all subcategories' option in category-selector (#11099) 2020-11-23 10:55:32 +02:00
Sam
c540bf5e2b
FIX: correct cdn path (#11324) 
This was a typo in a118ec13
 2020-11-23 13:03:49 +11:00
Sam
a118ec13bc
FIX: stop including GlobalPath in default context (#11323) 
We do not want these method names to clash, instead encapsulate the helpers
so we do not add methods to Kernel

Correct a but exposed by Ruby 2.7
 2020-11-23 12:59:45 +11:00
Kris
855026eea1
UX: PM title glyph alignment and consistency improvement (#11314) 
* UX: PM title glyph alignment should match public topic-status style

* minor fixes
 2020-11-23 12:16:41 +11:00
Martin Brennan
28db835c4c
FIX: Calculate email attachment size limit correctly (#11321) 
When calculating whether the attached uploads went over the SiteSetting.email_total_attachment_size_limit_kb.kilobytes limit, we were using the original_upload for the calculation instead of the actually attached_upload, which will be smaller in most cases because it can be an optimized image.
 2020-11-23 11:16:08 +10:00
Jarek Radosz
790b9856af
FIX: Onebox image alignment (#11319) 
It was overlapping with elements after it and was unnecessarily indented relative to the text before it.
 2020-11-23 10:49:02 +11:00
David Taylor
a9eb1163e1
UX: Do not include current user in group-filtered directory results (#11310) 
At the moment, when filtering by group, the directory will unconditionally return the current user at the top of the list. This is quite unexpected, given that the user is deliberately trying to filter the list. This commit makes sure the 'include current user' logic only triggers for unfiltered directories
 2020-11-23 10:22:14 +11:00
dependabot[bot]
153997f13a
Build(deps): Bump parallel from 1.20.0 to 1.20.1 (#11316) 
Bumps [parallel](https://github.com/grosser/parallel) from 1.20.0 to 1.20.1.
- [Release notes](https://github.com/grosser/parallel/releases)
- [Commits](https://github.com/grosser/parallel/compare/v1.20.0...v1.20.1)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2020-11-22 22:48:25 +01:00
Robin Ward
66ecefba52 FIX: Upload events happened outside of the runloop 
This could cause test failures when checking for the result of the
events if Ember hasn't applied them yet.
 2020-11-20 15:35:00 -05:00
Joffrey JAFFEUX
8aa912c885
FIX: iconList is an array in production (#11308) 
This should be investigated further, but hopefully the comment will prevent anyone else to fall in this trap.
 2020-11-20 20:00:51 +01:00
tshenry
0ec62358d9
FEATURE: Add site setting to restrict ignore feature to trust level (#11297) 
This adds a new min_trust_level_to_allow_ignore site setting that enables admins to control the point at which a user is allowed to ignore other users.
 2020-11-20 10:05:20 -08:00
Robin Ward
1ea6bbab34 FIX: We shouldn't debounce this in testing 
Eventually we should add a helper to prevent all debouncing in test, but
for now this will really speed up Ember-CLI tests.
 2020-11-20 12:39:49 -05:00
Robin Ward
d6f2a63efe FIX: Tests were performing data[] queries but without quotes 
This works in jQuery but not querySelectorAll
 2020-11-20 12:39:07 -05:00
Joffrey JAFFEUX
8a90a5610f
DEV: allows to check if an icon is in the set (#11303) 2020-11-20 17:34:55 +01:00
Penar Musaraj
7539c2ed7f
UX: Revamp category security tab (#11273) 2020-11-20 10:44:34 -05:00
Jarek Radosz
dbcf722ab9
DEV: Modulize component tests (#11300) 
It's like the new tests, but still old underneath!
 2020-11-20 15:54:09 +01:00
dependabot[bot]
ca9abb4f90
Build(deps): Bump rails_failover from 0.6.0 to 0.6.1 (#11302) 
Bumps rails_failover from 0.6.0 to 0.6.1.

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2020-11-20 14:35:36 +00:00
dependabot[bot]
8b83373bec
Build(deps): Bump redis from 4.2.4 to 4.2.5 (#11301) 
Bumps [redis](https://github.com/redis/redis-rb) from 4.2.4 to 4.2.5.
- [Release notes](https://github.com/redis/redis-rb/releases)
- [Changelog](https://github.com/redis/redis-rb/blob/master/CHANGELOG.md)
- [Commits](https://github.com/redis/redis-rb/compare/v4.2.4...v4.2.5)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2020-11-20 14:33:18 +00:00
dependabot[bot]
96ceea8ec2 Build(deps): Bump redis from 4.2.2 to 4.2.4 
Bumps [redis](https://github.com/redis/redis-rb) from 4.2.2 to 4.2.4.
- [Release notes](https://github.com/redis/redis-rb/releases)
- [Changelog](https://github.com/redis/redis-rb/blob/master/CHANGELOG.md)
- [Commits](https://github.com/redis/redis-rb/compare/v4.2.2...v4.2.4)

Signed-off-by: dependabot[bot] <support@github.com>
 2020-11-20 09:15:20 -05:00
Dan Ungureanu
9b7525bb03
FIX: Handle uncaught exception (#11263) 
After the search term is parsed for advanced search filters, the term may
become empty. Later, the same term will be passed to Discourse.route_for
which will raise an ArgumentError.

> URI(nil)
ArgumentError: bad argument (expected URI object or URI string)
 2020-11-20 11:28:14 +02:00
Arpit Jalan
c244214fe5
UX: update "Rebuild-HTML" icon (#11296) 2020-11-19 19:39:18 -08:00
Robin Ward
1157ff8116 FIX: There are two elements with a suspend-reason class 
We only want to fill in the text one. (This is an Ember CLI fix)
 2020-11-19 14:16:35 -05:00
Neil Lalonde
bd3b1cb9ac
Version bump to v2.6.0.beta6 (#11288) 2020-11-19 13:56:05 -05:00
David Taylor
0c878ef304
FIX: Remove error for PostCreator in a transaction without skip_jobs (#11291) 
Partial revert of b143412be4 (the refactoring is not reverted)

This broke a few things, so we need to investigate and make some changes before reinstating the error
 2020-11-19 17:26:21 +00:00
Roman Rizzi
d815b95935
FEATURE: Search filter for searching all PMs on a site for admin. (#11280) 
Admins can search all PMS on a site by using the `in:all-pms` advanced filter.
 2020-11-19 13:56:19 -03:00
Dan Ungureanu
5202380a04
DEV: Move browser-update.js.erb out of vendored scripts (#11234) 
This script has been adopted and modified.
 2020-11-19 18:48:24 +02:00
Régis Hanol
b143412be4
DEV: skip_jobs when seeding topics (#11289) 
Don't raise an exception when creating a post inside a transaction in import_mode.
 2020-11-19 17:31:21 +01:00
Régis Hanol
7af061fafa
DEV: raise an exception when trying to create a post within a transaction (#11287) 
Hopefully this will prevent fellow developers from spending a morning
trying to figure out why the jobs that are run after a post is created
are not finding the post in the database.

That's because if you're inside a transaction when creating a post, the jobs
will likely run before the transaction is being commited to the database.

There was a "warning" in the comments of the PostCreator class but raising an
exception should hopefully help catch those issue much faster :fingers_crossed:.

This is hard to test since all the tests are run in a transaction...
 2020-11-19 14:09:56 +01:00
David Taylor
02278109d6
DEV: Maintain github_user_info primary key values during migration (#11286) 
This will only happen if the user_associated_accounts table is currently empty. It's useful for people that may be depending on primary key values in data explorer queries. This change will only have an effect on sites which have not already run this migration.
 2020-11-19 10:30:18 +00:00
Martin Brennan
a6f700d4ef
FIX: Show better error if no bookmarks found from search (#11284) 
See https://meta.discourse.org/t/no-results-for-bookmarks-search-confusing-message/169763
 2020-11-19 09:10:28 +10:00
Gerhard Schlager
333f0af0ec
FIX: Cached badge_count isn't updated after backfilling badges (#11281) 2020-11-18 22:01:56 +01:00