4377 Commits

Author	SHA1	Message	Date
Sam	6f09df0deb	FIX: don't create tags autolinks inside links (new engine)	2017-07-07 13:04:25 -04:00
Sam	74f6894606	oops checked in a broken test	2017-07-07 11:08:04 -04:00
Sam	436b894f7a	FIX: mention not working after a newline (new engine)	2017-07-07 11:06:50 -04:00
Guo Xiang Tan	13f3de4bf6	Nuke all SiteSetting.stubs from our codebase.	2017-07-07 15:09:14 +09:00
Guo Xiang Tan	e7e16de3e0	Remove use of stubs in specs.	2017-07-07 13:18:53 +09:00
Guo Xiang Tan	a4399c2eab	FIX: Translation overrides were not cached by locale properly.	2017-07-07 12:28:00 +09:00
Arpit Jalan	5b67cd1937	Merge pull request #4956 from techAPJ/pm-recipients ... FEATURE: new site setting to limit message recipients	2017-07-06 22:57:33 +05:30
Arpit Jalan	7cffbc8ba8	FEATURE: new site setting to limit message recipients ... New site setting `max_allowed_message_recipients` to limit message recipients https://meta.discourse.org/t/one-of-my-users-just-group-messaged-100-other-user-with-a-spam-offer/65612/7?u=techapj	2017-07-06 22:52:49 +05:30
Jakub Macina	8c445e9f17	Fix backend code for searching by a filetype as a combination of uploads and topic links. Add rspec test for extracting file extension in upload.	2017-07-06 19:19:31 +02:00
Jakub Macina	f0a674d620	Add extraction of upload extension. Add rspec test for search of post ... with upload by extension.	2017-07-06 19:16:07 +02:00
Guo Xiang Tan	e92acb4c40	FIX: Jobs::PullHotlinkedImages#is_valid_image_src returns true for a generic string.	2017-07-06 18:31:15 +09:00
Neil Lalonde	fcb2f68565	FIX: duplicate topics and posts in summary email because user has muted tags and topics contain multiple tags	2017-07-04 16:12:10 -04:00
Neil Lalonde	3964929c75	FIX: summary email excludes all untagged topics if user has muted some tags	2017-07-04 12:52:25 -04:00
Guo Xiang Tan	a7a8ccb100	Merge pull request #4948 from tgxworld/fix_translation_fallback_not_using_overrides ... FIX: Translation fallback was not using fallback's translation override.	2017-07-04 09:08:22 +09:00
Sam	d2ba543ed3	correct case where %20 decoded as space in auto link ... correct case where onebox is not applied when url is decoded	2017-07-03 16:32:53 -04:00
Sam	340a3ee5cb	correct spec to handle not null visibility_level	2017-07-03 16:03:26 -04:00
Sam	845170bd6b	FEATURE: add support for group visibility level ... There are 4 visibility levels - public (default) - members only - staff - owners Note, admins and group owners ALWAYS have visibility to groups Migration treated old "non public" as "members only"	2017-07-03 15:26:57 -04:00
Sam	c79418d334	DEV: Move RTL into lib where it belongs	2017-07-03 15:26:57 -04:00
Arpit Jalan	984778d3ac	FIX: handle moving first post to a closed/archived topic	2017-07-03 21:21:20 +05:30
Arpit Jalan	72c92b0f4e	FIX: include canonical meta tag on category pages	2017-07-03 13:25:22 +05:30
Guo Xiang Tan	52e654b3ac	FIX: Translation fallback was not using fallback's translation override. ... https://meta.discourse.org/t/discobot-falling-back-to-site-locale-is-not-using-customized-copies/65140	2017-07-03 14:52:27 +09:00
Arpit Jalan	16d356ab4e	FEATURE: resending invite should include original custom message ... https://meta.discourse.org/t/will-resent-invite-include-original-custom-message/64699	2017-06-30 18:13:33 +05:30
Sam	d941ed90d6	support for bbcode [code] blocks	2017-06-29 16:04:10 -04:00
Sam	de50d8cd35	Support for [email] [url] [img] bbcodes	2017-06-29 14:00:09 -04:00
Arpit Jalan	e7b9b1312e	FEATURE: remove all invites ... https://meta.discourse.org/t/remove-all-invitations-button-for-the-admin-panel/65207	2017-06-29 22:30:10 +05:30
Sam	c6b83f4714	Correct logic so hashtags are properly ignored in links	2017-06-29 12:48:20 -04:00
Guo Xiang Tan	5e156fbe85	FIX: Group.search should look up Group#full_name too. ... https://meta.discourse.org/t/mentioning-group-by-full-name-doesnt-work/63437/3	2017-06-29 16:37:59 +09:00
David Taylor	9294826f31	Allow inclusion of elided text from emails when sending to a category… (#4844) ... * Allow inclusion of elided text from emails when sending to a category address	2017-06-29 13:03:14 +09:00
Sam	0e391a72a1	use custom whitelister for tables	2017-06-28 16:08:29 -04:00
Sam	cfbda863e8	implement unicode emoji replacements	2017-06-28 13:47:30 -04:00
Robin Ward	b93edc9945	FIX: Make sure censored words are on boundaries in topic titles	2017-06-28 13:13:40 -04:00
Sam	4c5109ff5b	FEATURE: site setting for Markdown typographer ... It ships anyway with markdown.it so we might as well expose it	2017-06-27 16:50:13 -04:00
Sam	0d62420cbe	Space prior to onebox stops onebox resolution	2017-06-27 16:16:17 -04:00
Sam	232de90607	explicit autolink should not be oneboxed	2017-06-27 15:34:16 -04:00
Sam	5897ae945a	FIX: stop using inline quote for local onebox	2017-06-27 10:57:38 -04:00
Sam	0e0092d738	corrected a parsing edge cases for bbcode blocks	2017-06-27 10:07:06 -04:00
Régis Hanol	cdf8baac3b	fix specs due to new default emoji set	2017-06-26 23:36:30 +02:00
Sam	21f7ac1f25	correct spec, require closing tag for bbcode blocks	2017-06-26 16:51:55 -04:00
Robin Ward	db485ae0da	FIX: Support for skipping redirects on certain domains (like steam)	2017-06-26 15:38:43 -04:00
Sam	8967d50dc2	Clean up sanitization code ... - remove html table test, this is soon to be deprecated - move sanitization tests into pretty text.rb - fix up whitelister so it makes a copy of options	2017-06-26 15:21:47 -04:00
Neil Lalonde	69b2d64334	FIX: letter avatars in quotes on subfolders installs are broken	2017-06-23 17:12:13 -04:00
Sam	814c8804d4	correct text highlighting for no highlight	2017-06-23 14:35:46 -04:00
Sam	b7386958ed	don't leak state into other tests	2017-06-23 12:01:33 -04:00
Sam	234694b50f	Feature: CommonMark support ... This adds the markdown.it engine to Discourse. https://github.com/markdown-it/markdown-it As the migration is going to take a while the new engine is default disabled. To enable it you must change the hidden site setting: enable_experimental_markdown_it. This commit is a squash of many other commits, it also includes some improvements to autospec (ability to run plugins), and a dev dependency on the og gem for html normalization.	2017-06-23 12:01:33 -04:00
Régis Hanol	a9c0df0b58	FIX: always try to convert PNG to JPG when pasting an image	2017-06-23 12:13:48 +02:00
Guo Xiang Tan	80e348d226	PERF: Speed up slow tests in our test suite. ... Before ``` Finished in 7 minutes 23 seconds (files took 4.15 seconds to load) 7145 examples, 0 failures, 10 pending ``` After ``` Finished in 6 minutes 12 seconds (files took 4.41 seconds to load) 7145 examples, 0 failures, 10 pending ```	2017-06-22 11:23:31 +09:00
Neil Lalonde	8fd915a11a	Revert "FIX: add path to cookies so sessions on the same domain but different subfolders don't log each other out"	2017-06-21 16:18:24 -04:00
Robin Ward	aaaa93c216	FIX: Full page search was removing advanced search terms	2017-06-21 15:51:15 -04:00
Arpit Jalan	6796de8bf2	FIX: replace site_name with email_prefix in subject when use_site_subject is true	2017-06-21 21:15:49 +05:30
Guo Xiang Tan	4c98bd9d5f	FIX: Can't update status_type of topic timers. ... https://meta.discourse.org/t/topic-timers-internal-error-500/64805	2017-06-21 15:31:15 +09:00
Jakub Macina	aad1c9bef2	Add rspec tests for searching by a filetype.	2017-06-20 21:21:56 +02:00
Neil Lalonde	1716747810	FIX: add path to cookies so sessions on the same domain but different subfolders don't log each other out	2017-06-20 13:30:36 -04:00
Jakub Macina	eaf46431d4	Add extraction of file extension in TopicLink and related rspec tests.	2017-06-19 17:09:54 +02:00
Jakub Macina	bf002e0873	Add extraction of image_url for oneboxed images. Fix search by images filter name.	2017-06-19 15:18:02 +02:00
Guo Xiang Tan	b9fbc95ef4	Add spec to notify us when translations have invalid interpolation keys.	2017-06-19 12:39:30 +09:00
Alberto Aguirre	b24bdc5b20	FIX: discourse_hub_spec stub_request should include query params	2017-06-18 14:40:28 -05:00
Neil Lalonde	c5f42f0e97	fix discourse_hub_spec	2017-06-16 15:31:13 -04:00
Guo Xiang Tan	a6450f7377	REFACTOR: Allow delete_removed_posts_after SiteSetting to be bypassed.	2017-06-16 12:27:51 +09:00
Guo Xiang Tan	d82dbd565b	FIX: Remove dependency on rest-client.	2017-06-16 09:42:41 +09:00
Guo Xiang Tan	cae09ee4c8	Fix failing specs.	2017-06-16 09:39:54 +09:00
Guo Xiang Tan	b5ec241716	FIX: Validate interpolation keys used in translation overrides. ... https://meta.discourse.org/t/discobot-translation-missing-error/64429/6?u=tgxworld	2017-06-16 08:54:48 +09:00
Neil Lalonde	eb9f306e64	FIX: fail to send email notification if post has img tag with no src attribute	2017-06-15 10:36:19 -04:00
Sam	ac1f84d3e1	SECURITY: theme key should be an anon cache breaker	2017-06-15 09:36:27 -04:00
Joffrey JAFFEUX	f1750be2be	Fixes woman_shrugging name conversion	2017-06-15 08:26:29 +02:00
Guo Xiang Tan	b5249fb4ca	FIX: Send request membership PM to last 5 active group owner.	2017-06-15 11:37:09 +08:00
Neil Lalonde	b98a930364	Merge pull request #4896 from dmacjam/multiple-tags-logical-and-search ... FEATURE: Advanced search supports logical AND of multiple tags	2017-06-14 14:39:23 -04:00
Régis Hanol	d6c63cc5b2	FIX: user's default group should only be set once ... Setting a user's default groups based on their email address should only be done once, ie. when they confirm their email address. Previously we were doing this everytime we'd save a user record 🤷	2017-06-14 19:20:18 +02:00
Joffrey JAFFEUX	95e1843d33	Improves native emoji conversion	2017-06-14 17:42:52 +02:00
Joffrey JAFFEUX	ab6086bce9	Transforms native skin toned emojis to valid names	2017-06-14 15:35:37 +02:00
Guo Xiang Tan	2fdf9068eb	FIX: Create notification for group users when group has been invited. ... https://meta.discourse.org/t/inviting-a-group-to-a-message-does-not-trigger-a-notification-mail/50509	2017-06-14 14:53:49 +09:00
Joffrey JAFFEUX	299339a373	Fixes emoji name to code missing tones	2017-06-13 14:10:26 -04:00
Arpit Jalan	34996b4eff	FIX: show invite validation error message in response	2017-06-13 22:41:53 +05:30
Robin Ward	009f0921dc	FEATURE: Whitelist hosts for internal crawling	2017-06-13 12:59:54 -04:00
Sam	826f332766	Merge pull request #4901 from jjaffeux/emoji-5.0 ... Emoji next	2017-06-13 11:12:41 -04:00
Régis Hanol	5d63a7f4a6	FIX: pull hotlinked images even when they have no extension	2017-06-13 13:27:05 +02:00
Guo Xiang Tan	a5d3abc9b6	FIX: Create group membership request on behalf of user.	2017-06-13 17:49:21 +09:00
Régis Hanol	54e8fb0d89	FEATURE: new 'allow_staff_to_upload_any_file_in_pm' site setting	2017-06-12 22:41:29 +02:00
Robin Ward	a3729b51eb	FIX: Always allow the host the forum is hosted on	2017-06-12 13:22:51 -04:00
Arpit Jalan	b9c94aa234	FEATURE: add required user fields to invite accept form ... UX: make "accept invitation" page consistent with sign up modal	2017-06-12 20:43:07 +05:30
Guo Xiang Tan	eab3562864	Merge pull request #4905 from tgxworld/strip-zero-width-chars-from-search-term ... FIX: Strip zero-width characters from search terms.	2017-06-12 18:01:02 +09:00
Guo Xiang Tan	5994c85ea9	FIX: Raise the right error when email params is missing.	2017-06-12 17:48:32 +09:00
Guo Xiang Tan	e888369f51	UX: Don't send emails for discobot notifications.	2017-06-12 17:00:27 +09:00
Robin Ward	b5bead1fe3	FIX: Don't use target=_blank for local oneboxes	2017-06-09 12:15:36 -04:00
Jakub Macina	76712da166	Add backend code for searching posts with images.	2017-06-09 10:30:21 +02:00
Robin Ward	602e4d0da4	FIX: Return nil when the reply_key is missing	2017-06-08 14:28:48 -04:00
Régis Hanol	038454bde2	FIX: always confirm emails when SSO says so	2017-06-08 01:05:33 +02:00
Régis Hanol	e8f0771dc9	FIX: the 'clean_up_uploads' jobs would delete images used in site settings ... when they were entered using absolute URLs, with the CDN or simple a different format than the one used in the database	2017-06-07 22:53:15 +02:00
Robin Ward	54bb2a6bc2	FIX: Don't redirect to wizard when resetting password	2017-06-07 12:36:52 -04:00
Guo Xiang Tan	5794ff53a1	FIX: Copy custom fields when moving first post of a topic. ... https://meta.discourse.org/t/transfer-poll-votes-when-moving-a-topic-into-an-existing-one/63678	2017-06-07 19:04:48 +09:00
Guo Xiang Tan	684b05f510	FIX: Strip zero-width characters from search terms.	2017-06-07 18:19:47 +09:00
Guo Xiang Tan	2cad739262	FIX: Better error message when username change fails. ... https://meta.discourse.org/t/500-error-on-username-edit/64064	2017-06-07 10:45:53 +09:00
Guo Xiang Tan	da736f70a4	Merge pull request #4845 from vinothkannans/download-onebox-images ... FEATURE: pull onebox images	2017-06-07 09:55:04 +09:00
Robin Ward	53b95f009f	FIX: If HEAD is not supported, try GET. Also set cookies	2017-06-06 13:53:49 -04:00
Vinoth Kannan	209383faab	FEATURE: pull onebox images	2017-06-06 18:51:58 +05:30
Jakub Macina	8f7d81fde6	Add rspec test for searching posts with images.	2017-06-06 14:39:53 +02:00
Joffrey JAFFEUX	09d34b7642	emoji images are now v5 not v3 ... TODO: we should not hardcode this	2017-06-05 16:10:36 +02:00
Guo Xiang Tan	ac6c1acbed	FIX: Groups that do not have any owners should not allow membership requests.	2017-06-05 10:02:37 +09:00
Arpit Jalan	a10c939775	FIX: do not show website name on TL0 profile	2017-06-04 18:30:28 +05:30
Arpit Jalan	a1ebd67237	Revert "FEATURE: new setting to prioritize open topics in search"	2017-06-03 01:54:35 +05:30
Arpit Jalan	b8a87a0996	FEATURE: new setting to prioritize open topics in search	2017-06-03 00:33:53 +05:30
Sam	b4060778d9	FIX: you should always be allowed to see actions you created	2017-06-02 14:24:06 -04:00
Sam	096177d0d5	confirm we notify on the destination, not source	2017-06-02 11:20:40 -04:00
Jakub Macina	eaec35d230	Fix tag related advanced search tests into one context. Fix dynamic locale and select clause in search by all tags. Fix separator for all tags to plus sign.	2017-06-02 12:39:07 +02:00
Guo Xiang Tan	af3dc4e537	FIX: Publish group's categories to user when adding user to group. ... https://meta.discourse.org/t/joining-a-group-doesnt-take-effect-unless-the-browser-is-hard-refreshed/57357/11?u=tgxworld	2017-06-02 17:38:14 +09:00
Sam	a7fc93acac	FIX: post mover not clearing reply_to_user_id	2017-06-01 18:00:14 -04:00
Guo Xiang Tan	2ee144c27f	FEATURE: Add DiscourseEvent trigger when a user logs in. ... * Also adds a event trigger when user logs in for the first time.	2017-06-01 17:44:49 +09:00
Guo Xiang Tan	bd486100c0	Remove stubs on DiscourseEvent in tests.	2017-06-01 16:21:00 +09:00
Guo Xiang Tan	b0dd05fdc6	FIX: Inherit topic auto close when changing topic's category.	2017-05-31 17:40:21 +09:00
Sam	607998af33	FEATURE: dropdown to filter staff action logs	2017-05-30 11:25:42 -04:00
Jakub Macina	6d1fafaff6	Add rspec tests for advanced search by tags.	2017-05-30 13:01:17 +02:00
Sam	0aed2533ac	Revert unread optimisation, has too many edge cases	2017-05-26 09:04:13 -04:00
Guo Xiang Tan	4d9481bf47	Fix build.	2017-05-26 16:04:59 +08:00
Guo Xiang Tan	56f98de7b2	Use webmock to stub external web requests.	2017-05-26 15:19:09 +08:00
Guo Xiang Tan	f8f1548fd4	Revert "FIX: Use Excon to do its own stubbing" ... This reverts commit 80af54460a.	2017-05-26 13:04:25 +08:00
Guo Xiang Tan	e57d2f5cb8	FIX: Don't do anything if avatar url returns an invalid status code.	2017-05-26 13:02:40 +08:00
Robin Ward	b584264d82	FIX: Don't show "resend email" option when user approval is on	2017-05-25 15:29:05 -04:00
Sam	29fac1ac18	PERF: improve performance of unread queries ... Figuring out what unread topics a user has is a very expensive operation over time. Users can easily accumulate 10s of thousands of tracking state rows (1 for every topic they ever visit) When figuring out what a user has that is unread we need to join the tracking state records to the topic table. This can very quickly lead to cases where you need to scan through the entire topic table. This commit optimises it so we always keep track of the "first" date a user has unread topics. Then we can easily filter out all earlier topics from the join. We use pg functions, instead of nested queries here to assist the planner.	2017-05-25 15:07:30 -04:00
Robin Ward	cdbe027c1c	Refactor FileHelper to use keyword arguments.	2017-05-24 13:54:26 -04:00
Sam	f12490eae0	FIX: order:latest not working for search within topic ... FEATURE: use 'l' as a shorthand for order:latest	2017-05-24 11:24:41 -04:00
Robin Ward	3b0cbf7013	FIX: Always allow downloads from CDN	2017-05-23 16:32:54 -04:00
Robin Ward	d2121ca272	FIX: Missing HTTP stub	2017-05-23 15:08:19 -04:00
Robin Ward	b81e7be9a1	FEATURE: Rate limit how often we'll crawl a destination IP	2017-05-23 15:03:04 -04:00
Robin Ward	36e477750c	FIX: Use same code path for downloading images	2017-05-23 14:51:30 -04:00
Robin Ward	e5e7a15a85	SECURITY: Never crawl by IP	2017-05-23 13:07:18 -04:00
Robin Ward	93a5fc62bf	FEATURE: A site setting to prevent crawling on private IP blocks	2017-05-23 11:56:06 -04:00
Robin Ward	80af54460a	FIX: Use Excon to do its own stubbing	2017-05-22 18:19:20 -04:00
Robin Ward	b51126dd5e	FIX: Reset the WebMock after before every test	2017-05-22 17:52:31 -04:00
Régis Hanol	9dddb81cf6	FIX: remove memoization on class method used in a job	2017-05-22 23:35:41 +02:00
Blake Erickson	4e8beda332	Merge pull request #4866 from JaredReisinger/admin-user-pagination ... Add pagination to /admin/users/list API	2017-05-22 15:12:59 -06:00
Robin Ward	d4b16b487e	FIX: Another onebox head request	2017-05-22 17:00:19 -04:00
Robin Ward	a8d1e44943	FIX: Onebox will do a HEAD request first for redirects	2017-05-22 16:52:26 -04:00
Robin Ward	4c690f7089	Use FinalDestination to ensure public redirects for onebox	2017-05-22 16:42:49 -04:00
Robin Ward	b23fc2bf84	Helper to find the final destination for a URL	2017-05-22 15:52:41 -04:00
Sam	6231318462	Merge pull request #4877 from rimian/plugin_helper ... FEATURE: Require spec helpers for plugins	2017-05-22 15:22:55 -04:00
Régis Hanol	a7f337fa93	FIX: CDN wasn't properly applied to category background images when using S3	2017-05-22 18:37:01 +02:00
Guo Xiang Tan	76229535ac	Remove old test case.	2017-05-22 18:23:09 +08:00
Guo Xiang Tan	08c36fa968	REFACTOR: Clean up some code associated with topic timers.	2017-05-22 18:10:29 +08:00
Guo Xiang Tan	238a156300	FIX: TopicTimestampChanger should not allow timestamps in the future.	2017-05-22 16:03:49 +08:00
Guo Xiang Tan	4382a0bb07	Rename PostTimestampChanger -> TopicTimestampChanger.	2017-05-22 15:01:33 +08:00
Rimian Perkins	2b5dfb6e8e	avoid double lookup for plugin helpers	2017-05-22 14:50:53 +10:00
Guo Xiang Tan	330338af3a	FIX: Don't hardcode text in smoke test.	2017-05-22 08:01:33 +08:00
Robin Ward	908433a7a0	SECURITY: Validate the entity when downloading a CSV	2017-05-19 16:00:51 -04:00
Robin Ward	28f486cb7a	FIX: Regular users shouldn't be able to invite to PMs if disabled	2017-05-19 12:57:21 -04:00
Guo Xiang Tan	2b66918199	Wrong function call.	2017-05-19 22:33:06 +08:00
Guo Xiang Tan	130e7f214b	Account for sites using text site logo in smoke test.	2017-05-19 22:25:08 +08:00
Guo Xiang Tan	8ab9f30bbd	FIX: User can't remove bookmark from a deleted post.	2017-05-19 12:25:12 +08:00
Rimian Perkins	8febaa8be7	FEATURE: Require spec helpers for plugins ... * Follows any symlinked plugins	2017-05-19 12:38:36 +10:00
Régis Hanol	4fb335f1f0	FIX: don't process the same incoming email more than once	2017-05-18 16:43:07 +02:00
Régis Hanol	13e489b4ca	replace the upload type whitelist with a sanitizer	2017-05-18 12:13:13 +02:00
Guo Xiang Tan	f4cc71d643	Allow username and password to be passed via ENV for smoke test.	2017-05-18 12:17:31 +08:00
Neil Lalonde	cbe8e05f79	disable test that fails randomly	2017-05-17 12:46:50 -04:00
Neil Lalonde	a0f03936ff	FIX: saving invisible primary group field that you don't belong to	2017-05-17 12:46:50 -04:00
Régis Hanol	a1b8a3b52b	FIX: supports bare <li> when converting html to markdown	2017-05-17 15:05:11 +02:00
Guo Xiang Tan	92036616db	Make test less vulnerable to changes.	2017-05-17 19:30:13 +08:00
Guo Xiang Tan	b0e4555a86	Allow Basic Authentication to be set in smoke test.	2017-05-17 19:24:43 +08:00
Guo Xiang Tan	3df46833b3	Fix the build.	2017-05-17 16:14:06 +08:00
Sam	6a1f579c6e	FIX: don't search for plugins in nested subdirectories	2017-05-16 17:28:56 -04:00
Jared Reisinger	645f648ea7	Merge remote-tracking branch 'upstream/master' into admin-user-pagination	2017-05-16 13:36:47 -07:00
Sam	763f156d91	FIX: require re-activation if SSO changes email and updates it	2017-05-16 16:18:18 -04:00
Sam	4b449914b8	FIX: admins could never remove self from messages	2017-05-16 16:06:24 -04:00
Neil Lalonde	7821400141	FEATURE: staff can set a timer to remind them about a topic	2017-05-16 14:49:50 -04:00
Robin Ward	dd0cb6a117	FIX: Add missing test	2017-05-15 16:57:09 -04:00
Robin Ward	bd0bb879e5	FIX: Don't count likes from system users in the new user of the month	2017-05-15 13:14:32 -04:00
Sam	e1dd543a93	FEATURE: allow users to select theme on single device	2017-05-15 12:48:16 -04:00
Sam	44d7fe89ed	FIX: unescape emoji in pretty title ... This makes emoji in title consistent, it is later escaped back when needed	2017-05-15 10:28:05 -04:00
Sam	8491f8c48b	add smoke test for visiting categories	2017-05-12 17:42:38 -04:00
Robin Ward	62d245dde3	Try bumping the timeout for the smoke test	2017-05-12 16:40:38 -04:00
Jared Reisinger	1dcd61fa34	Add pagination to /admin/users/list API ... Prior to this, only the first 100 active/new/etc. users were available via the `/admin/users/list` API. This change adds support for a `page=#` querystring parameter so that *all* of the users can be retrieved. Requests for pages past the last user result in an empty-list response; requests for negative pages (or zero) just return the first page. Added tests to cover pagination.	2017-05-12 13:28:35 -07:00
Robin Ward	1fb08d24d9	FIX: Latest onebox adds more attributes to links for security	2017-05-12 15:49:56 -04:00
Neil Lalonde	8b9799507c	fix deploy problems due to renamed table	2017-05-12 15:17:25 -04:00
Sam	2d96a0785d	FEATURE: theme selection is now global per-user	2017-05-12 12:41:34 -04:00
Sam	47ce674798	PERF: bypass wizard check after 15 topics are created	2017-05-12 10:18:43 -04:00
Guo Xiang Tan	b479aa0598	Set custom fields before saving in fabricator.	2017-05-12 14:01:31 +08:00
Guo Xiang Tan	41711e53b7	Fix typo.	2017-05-12 10:31:31 +08:00
Guo Xiang Tan	8eecd42856	FIX: Delete topic timer after completion.	2017-05-12 10:28:51 +08:00
Neil Lalonde	55b61e9bea	rename topic_status_update to topic_timer	2017-05-11 18:27:53 -04:00
Sam	52ae63d5d7	FIX: when searching PMs also search group PMs ... Users belonging to a group could not search for PMs unless explicitly added to the PM unless admin	2017-05-11 15:59:03 -04:00
Pat David	10f2db67ba	Add test for class_name in EmbedController	2017-05-11 15:16:16 -04:00
Sam	9b84cd832c	confirm in:private works for non staff	2017-05-11 15:06:45 -04:00
Neil Lalonde	1019bbda46	FEATURE: set a timer to delete a topic	2017-05-11 12:52:29 -04:00
Robin Ward	3ade46de0b	FIX: Don't send system message for new user of the month if disabled	2017-05-11 11:33:16 -04:00
Régis Hanol	9641d2413d	REFACTOR: upload workflow creation into UploadCreator ... - Automatically convert large-ish PNG/BMP to JPEG - Updated fast_image to latest version	2017-05-11 00:16:57 +02:00
Sam	7d9b5514ba	FIX: correctly invalidate theme css cache on scheme change	2017-05-10 15:47:11 -04:00
Sam	04b5516bf2	improve upload functionality	2017-05-10 15:47:11 -04:00
Sam	27362c5a4b	improve spec	2017-05-10 15:47:11 -04:00
Sam	bc0b9af576	FEATURE: support uploads for themes ... This allows themes to bundle various assets	2017-05-10 15:47:11 -04:00
Sam	f709899a1d	Allow theme field object model to support uploads	2017-05-10 15:46:42 -04:00
Robin Ward	4db76796b9	FEATURE: Setting to poll feeds more frequently	2017-05-10 14:30:12 -04:00
Robin Ward	b57b635d30	FIX: Extract div tags within spans	2017-05-09 12:33:54 -04:00
Sam Saffron	c2829dce22	FIX: base sql vanishes after badge creation	2017-05-09 09:25:57 -04:00
Guo Xiang Tan	55d3547540	Fix random test failure.	2017-05-09 11:27:05 +08:00
Robin Ward	fc00032ec8	Check for 404 from spec rather than failure	2017-05-08 16:33:43 -04:00
Robin Ward	addc85cd08	FIX: Don't let users edit wiki posts unless they can reply	2017-05-08 16:23:11 -04:00
Robin Ward	009e120e13	FIX: Don't raise an error when the img attribute cannot be found	2017-05-08 15:35:31 -04:00
Robin Ward	afe04b8bbb	FIX: Possible 500 error if category saved incorrectly	2017-05-08 15:17:58 -04:00
Robin Ward	4f6e5fed2a	We don't need to raise an error when no post is present. Just noop.	2017-05-08 15:08:29 -04:00
Robin Ward	96c59c5b82	FIX: Don't notify or return flags on system users	2017-05-08 13:13:35 -04:00
Sam	257c0dea70	Merge pull request #4852 from tgxworld/pull_the_plug_on_daily_mailing_list ... Remove daily mailing mode option as it doesn't scale.	2017-05-08 09:10:46 -04:00
Arpit Jalan	e89d0a6b20	FIX: importing a theme via file was broken	2017-05-08 12:03:24 +05:30
Guo Xiang Tan	e61959e6a8	FIX: CustomEmoji may contain an invalid upload_id. ... https://meta.discourse.org/t/white-screen-after-deleting-custom-emoji/61608	2017-05-05 14:53:38 +08:00
Guo Xiang Tan	2b21e5ea7e	UX: Display translated group name for automatic groups.	2017-05-05 14:34:47 +08:00
Guo Xiang Tan	71a266b673	Remove daily mailing mode option as it doesn't scale. ... https://meta.discourse.org/t/daily-updates-option-for-mailing-list-mode/45029/14?u=tgxworld	2017-05-05 12:21:50 +08:00
Guo Xiang Tan	441e0059af	Fix tests that was testing the wrong class.	2017-05-05 10:59:07 +08:00
Robin Ward	777f1f0f47	FIX: Return a 404 if the auth session is not present	2017-05-04 15:35:24 -04:00
Sam	4ebbad991e	FIX: properly clean up related color schemes on delete	2017-05-04 14:03:17 -04:00
Sam	7a15b44ac3	rename on_remove, on_drop	2017-05-04 14:03:17 -04:00
Sam	6a6eed4ed2	DEV: column dropper class for cleaner removal of superflous columns ... Also fixes issues during deploy cause target column was renamed in theme_fields	2017-05-04 10:15:41 -04:00
Guo Xiang Tan	4101db8b36	FIX: Invalid creation of Theme in wizard builder.	2017-05-04 11:44:23 +08:00
Régis Hanol	bf322281e3	Improve handling of inlined images in incoming emails	2017-05-03 23:02:02 +02:00
Régis Hanol	768c63c103	Add 'keep_cid_imgs' option to HTML to Markdown converter to improve incoming email parsing	2017-05-03 23:01:55 +02:00
Guo Xiang Tan	3eb920e2b0	Merge pull request #4841 from fantasticfears/webhook-ping ... add event name for ping webhooks in the header	2017-05-04 04:54:40 +08:00
Neil Lalonde	389a0e1a1c	FIX: emails should use default theme colors	2017-05-03 14:35:13 -04:00
Régis Hanol	e38014772b	FIX: skip hidden <img> (no tracking for you)	2017-05-03 19:40:34 +02:00
Régis Hanol	c8044c6956	FIX: skip hidden nodes when converting from HTML to Markdown	2017-05-03 19:34:03 +02:00
Régis Hanol	bff36de130	FIX: HtmlToMarkdown should not convert empty/bad <img> tags	2017-05-03 18:29:25 +02:00
Régis Hanol	c880af8120	FIX: properly trim whitespaces (including those pesky &nbsp; html entities)	2017-05-03 18:04:31 +02:00
Sam	342ef5f81a	FEATURE: out-of-the-box dark/light user selectable themes	2017-05-03 11:31:33 -04:00
Robin Ward	81190f5d66	FIX: Redirect away from account-created if you're logged in	2017-05-03 11:18:01 -04:00
Robin Ward	12fb20fe1b	FEATURE: Allow users to resend/update email from confirmation page	2017-05-03 11:18:01 -04:00
Régis Hanol	edbf12622b	FIX: HtmlToMarkdown should not convert empty/bad <a> tags	2017-05-03 16:42:37 +02:00
Arpit Jalan	75300b6356	improve specs	2017-05-03 17:48:33 +05:30
Arpit Jalan	86f1cc8c92	FIX: don't apply max_emails_per_day_per_user on critical emails	2017-05-03 17:07:39 +05:30
Arpit Jalan	cdce060a38	FIX: don't apply max emails per day per user to forgot password	2017-05-03 14:02:37 +05:30
Sam	946f25098f	Refactor theme fields so they support custom theme defined vars ... This paves the way to allowing themes to specify uploads and so on.	2017-05-02 16:02:14 -04:00
Arpit Jalan	77a8cae094	FIX: rescue specific errors on invite failure	2017-05-02 15:13:33 +05:30
Erick Guan	9f8a917d65	add event name for ping webhooks in the header	2017-05-02 08:13:23 +02:00
Sam	ba9339b8d7	FIX: missing image-url helper	2017-05-01 15:32:02 -04:00
Neil Lalonde	0722ffadf1	Remove site settings enforce_global_nicknames and discourse_org_access_key	2017-05-01 14:53:16 -04:00
Robin Ward	b99aedeccc	Merge pull request #4838 from vinothkannans/fix/read ... FIX: 'read' filter in top menu showing new topics	2017-05-01 11:21:13 -04:00
Claus Strasburger	e9bb9a167b	Fix reply-by-mail for 8-bit transfer encodings ... The mail class seems to handle mails sent with Content-Transfer-Encoding: 8bit somewhat weirdly: It decodes them (to utf-8), changes the raw source to base64, and does not modify the Content-Type:charset= header. This leads to Discourse trying the message encoding (in my example ISO-8859-1) first, and if that does not contain any unparseable characters, it uses that. Sadly, in ISO-8859-1, every byte sequence is valid. Fix this by always trying to decode as UTF-8 first. The probability of someone using another encoding that cleanly (but wrongly) decodes as UTF-8 should be fairly low.	2017-04-30 23:30:40 +02:00
Vinoth Kannan	1241660c2c	FIX: 'read' filter in top menu showing new topics	2017-04-29 14:37:45 +05:30
Régis Hanol	aba76bace6	add support to keep img tags when converting to html	2017-04-28 22:14:46 +02:00
Régis Hanol	51ee49aad2	FIX: properly support HTML document when converting to markdown	2017-04-28 22:02:20 +02:00
Robin Ward	f05f1a24d3	Change Anniversary badge to be multiple grant, once per year	2017-04-28 14:22:54 -04:00
Régis Hanol	0ec15af970	restore the 'incoming_email_prefer_html' site setting	2017-04-27 14:31:11 +02:00
Guo Xiang Tan	304ace926e	FIX: Raise right response when post_action does not exist.	2017-04-27 17:29:53 +08:00
Guo Xiang Tan	7873a2efb7	Merge pull request #4843 from tgxworld/disable_post_min_length_for_pm ... FEATURE: Disable minimum post length check when in PM with non human …	2017-04-27 16:35:19 +08:00
Guo Xiang Tan	59b906ab0d	FEATURE: Disable minimum post length check when in PM with non human users. ... https://meta.discourse.org/t/discourse-narrative-bot-beta-feedback/58621/65?u=tgxworld	2017-04-27 16:00:22 +08:00
Guo Xiang Tan	85d9342ff0	Merge pull request #4836 from tgxworld/fix_clean_up_staged_users_job ... FIX: Clean up unused staged users job not completing.	2017-04-27 15:41:46 +08:00
Arpit Jalan	9b0ecdaf7e	Merge pull request #4839 from techAPJ/bulk-add-group ... FEATURE: provide more details when performing a bulk add to group	2017-04-27 02:39:57 +05:30
Arpit Jalan	285c167fae	FEATURE: provide more details when performing a bulk add to group	2017-04-27 01:37:51 +05:30
Robin Ward	bf9c4a7828	FEATURE: secure_email site setting to prevent data going out in email	2017-04-26 13:05:56 -04:00
Régis Hanol	b76674f640	FEATURE: convert incoming emails in HTML to markdown ... - remove incoming_email_prefer_html site setting - remove HtmlCleaner class	2017-04-26 16:49:06 +02:00
Guo Xiang Tan	daa97c40ce	FIX: Clean up unused staged users job not completing.	2017-04-26 10:51:36 +08:00
Arpit Jalan	aeead60036	FIX: make TopicEmbed trashable	2017-04-25 18:40:39 +05:30
Guo Xiang Tan	aef89c4850	REFACTOR: Load Post records in batches when destroying stubs.	2017-04-25 10:19:21 +08:00
Guo Xiang Tan	6f7c6b0fd0	FIX: Incorrect error raised.	2017-04-25 09:59:01 +08:00
Régis Hanol	d5630d6160	HtmlToMarkdown library ... Small library to transform HTML to Discourse-flavored markdown (mostly used for imports)	2017-04-24 22:01:41 +02:00
Guo Xiang Tan	423f2ab228	FIX: Processing incoming email should be done in a background job.	2017-04-24 13:57:28 +08:00
Arpit Jalan	dad2024094	FIX: do not impose default min/max validation on hidden site setting	2017-04-22 12:08:39 +05:30
Sam	b077335a30	make stat socket much more robust	2017-04-21 17:12:29 -04:00
Arpit Jalan	b0151ab66a	Merge pull request #4826 from techAPJ/site-setting-max-value ... FIX: all basic integer settings should have min & max value validation	2017-04-21 20:21:10 +05:30
Sam	52306c393a	FEATURE: basic implementation of stats socket	2017-04-21 10:24:43 -04:00
cpradio	20c2c66dd4	FEATURE: Add normal as a preference for topic subscription state when replying to a topic	2017-04-20 22:33:10 -04:00
Guo Xiang Tan	8b2e3bf5f1	FIX: Topic title should be included in post webhook payload.	2017-04-21 10:04:21 +08:00
Arpit Jalan	9eff4f0807	FIX: all basic integer settings should have max value validation	2017-04-21 07:09:41 +05:30
Sam	aec73d4003	correct the spec again	2017-04-20 17:41:35 -04:00
Sam	47b99e0922	group is now default watched	2017-04-20 17:38:46 -04:00
Sam	d4111c8676	correct spec	2017-04-20 17:24:21 -04:00
Sam	5365973c0a	FIX: detection of error changed, so you can clear errors	2017-04-20 16:55:18 -04:00
Sam	7a9eee1b71	FEATURE: default notification level for group messages ... also fixes it so staff can amend other user's group notification level	2017-04-20 15:47:35 -04:00
Sam	e119c6e01e	FIX: embedded comments not working when theme is missing	2017-04-20 10:31:33 -04:00
Arpit Jalan	ea26c56631	FIX: redirect to login page for anonymous user when profiles are hidden	2017-04-20 13:00:45 +05:30
Sam	7eabb90b71	FEATURE: added error messages for bad theme CSS / JS	2017-04-19 16:46:46 -04:00
Neil Lalonde	3835e16cf7	FIX: New implementation of the "notify about flag after" setting. Only notify about new flags since the last notification. Send a private message to staff. Mention the 3 most active moderators in the message so they get notification emails.	2017-04-19 16:17:45 -04:00
cpradio	2dccaff25d	FIX: Correct behavior of auto-notification state updating to exclude when the topic already has a state of normal/muted	2017-04-19 06:29:35 -04:00
Sam	2bc3aa7ed4	remove no digest refs ... the digestless special dev behavior is no longer needed	2017-04-18 17:05:33 -04:00
Arpit Jalan	f968b4e662	Fix the build	2017-04-18 16:34:58 +05:30
Arpit Jalan	1c23aedccf	FIX: always send password reset email when accepting invite if password is not set	2017-04-18 14:37:06 +05:30
Arpit Jalan	8dea70d354	Revert "FIX: User website allows new TLDs"	2017-04-18 13:18:51 +05:30
Rafael dos Santos Silva	4289dbe3e5	FIX: User website allows new TLDs	2017-04-18 00:30:37 -03:00
Robin Ward	1363988cd7	Support for an HTML builder that can create dynamic HTML	2017-04-17 17:32:55 -04:00
Sam	5e3a0846f7	FEATURE: allow themes to share color schemes	2017-04-17 15:56:24 -04:00
Arpit Jalan	7389831961	Fix the build	2017-04-15 15:52:35 +05:30
Arpit Jalan	0954367bf4	FIX: send activation email when accepting invite if password is set	2017-04-15 14:59:50 +05:30
Guo Xiang Tan	04016f0dec	Support Ruby 2.4.	2017-04-15 12:29:00 +08:00
Jeff Atwood	d12ba0548c	Merge pull request #4812 from cpradio/spec-auto-notification-update ... Add spec for auto notification update	2017-04-14 16:01:38 -07:00
cpradio	e3ad50de05	Add spec for auto notification update ... It should update the topic subscription so long as what is being requested is higher than what is currently set for the user and the given topic It should not update the topic subscription if the requested subscription is less than what is currently set for the user and given topic	2017-04-14 18:30:01 -04:00
Sam	4b6c49b13f	correct specs	2017-04-14 15:25:34 -04:00
Sam	def7348777	FIX: display custom sections with default theme ... also cleans up mechanism for previewing themes, cleans up naming, gets rid of old janky "preview_style", secures local theme key	2017-04-14 13:35:12 -04:00
Sam	809fbb25ce	FIX: blanking theme field was not properly removing it	2017-04-13 17:24:15 -04:00
Guo Xiang Tan	3d76fb9c2c	FIX: Don't show category options for reports that can't be scoped to a category.	2017-04-13 17:10:55 +08:00
Guo Xiang Tan	bda20cc44a	FIX: Don't enqueue topic status update job if topic is deleted.	2017-04-13 12:02:35 +08:00
Guo Xiang Tan	57788200ec	REFACTOR: Add User.reserved_username?.	2017-04-13 10:44:26 +08:00
Sam	a7ed8a0310	correct theme importer to support embedded.scss	2017-04-12 11:30:16 -04:00
Sam	95d095c97d	test should be configuring git info	2017-04-12 11:19:47 -04:00
Sam	a3e8c3cd7b	FEATURE: Native theme support ... This feature introduces the concept of themes. Themes are an evolution of site customizations. Themes introduce two very big conceptual changes: - A theme may include other "child themes", children can include grand children and so on. - A theme may specify a color scheme The change does away with the idea of "enabled" color schemes. It also adds a bunch of big niceties like - You can source a theme from a git repo - History for themes is much improved - You can only have a single enabled theme. Themes can be selected by users, if you opt for it. On a technical level this change comes with a whole bunch of goodies - All CSS is now compiled using a custom pipeline that uses libsass see /lib/stylesheet - There is a single pipeline for css compilation (in the past we used one for customizations and another one for the rest of the app - The stylesheet pipeline is now divorced of sprockets, there is no reliance on sprockets for CSS bundling - CSS is generated with source maps everywhere (including themes) this makes debugging much easier - Our "live reloader" is smarter and avoid a flash of unstyled content we run a file watcher in "puma" in dev so you no longer need to run rake autospec to watch for CSS changes	2017-04-12 10:53:49 -04:00
Dean Taylor	1a9afa976d	FEATURE: Add AWS S3 EU (London) "eu-west-2" region	2017-04-12 10:38:17 -04:00
Guo Xiang Tan	24d3c77d19	Fix the build.	2017-04-12 10:38:17 -04:00
Guo Xiang Tan	7cb389a235	Add DiscourseEvent trigger when user's topic notification level changes.	2017-04-12 11:56:50 +08:00
Arpit Jalan	8fb41bf5fb	FIX: update timestamp when resending invite	2017-04-11 20:02:32 +05:30
Guo Xiang Tan	5a57278a8e	Fix build.	2017-04-11 21:37:57 +08:00
Guo Xiang Tan	73180c8a19	FIX: Private message can be set to publish in the future.	2017-04-11 20:44:25 +08:00
Guo Xiang Tan	3861bd2793	FIX: Quotes should be ignored when parsing for onebox source.	2017-04-11 15:22:21 +08:00
Guo Xiang Tan	0a4c30bce3	FIX: Handle cases where alt and title tag is blank when parsing excerpt.	2017-04-11 14:18:27 +08:00
Guo Xiang Tan	c076f7b1aa	Fix broken specs.	2017-04-11 10:43:34 +08:00
Guo Xiang Tan	aadf4805a5	FIX: Topic status update not being deleted once it has been executed.	2017-04-11 10:32:13 +08:00
Guo Xiang Tan	e49f3a408e	FEATURE: Add option for ExcerptParser to keep onebox source.	2017-04-10 16:11:58 +08:00
Robin Ward	e2ff06ce02	FIX: rounding error in spec	2017-04-07 17:44:02 -04:00
Robin Ward	40cee37bcc	FIX: Don't insert topic status messages unless the status changes	2017-04-07 17:10:43 -04:00
Guo Xiang Tan	9663a74445	FIX: Ensure username param is valid in NotificationsController.	2017-04-07 17:32:52 +08:00
Guo Xiang Tan	71501feaf3	Improve validation for TopicStatusUpdate.	2017-04-07 15:32:00 +08:00
Guo Xiang Tan	690d2f4bd3	UX: Publish topic changes when topic is published.	2017-04-07 15:32:00 +08:00
Guo Xiang Tan	48a9860f07	FIX: Publish topic to a category should unlist it as well.	2017-04-07 13:58:52 +08:00
David Rodríguez	934bff43d9	FIX: Copy post actions when moving a topic.	2017-04-06 12:16:22 +08:00
Robin Ward	40ab2e5667	FEATURE: Let users update their emails before confirming ... This allows users who entered a typo or invalid email address when signing up an opportunity to fix it and resending the confirmation email to that address.	2017-04-05 16:44:49 -04:00
Sam Saffron	48d9c69117	remove confusing comment	2017-04-05 08:46:35 -04:00
Sam Saffron	cd39049262	SECURITY: do not send push notifications to suspended users	2017-04-05 08:28:24 -04:00
Robin Ward	17f2974d0a	SECURITY: Confirm new administrator accounts via email	2017-04-04 15:59:01 -04:00
Robin Ward	a649014adf	Add spec for validation on group mention updater	2017-04-04 11:22:39 -04:00
Guo Xiang Tan	ad44d2a400	Merge pull request #4790 from tgxworld/add_publish_to_topic_status_update ... FEATURE: Allow admins to schedule a topic to be published in the future.	2017-04-04 11:18:53 +08:00
Guo Xiang Tan	f4758a4c4d	FEATURE: Allow admins to schedule a topic to be published in the future.	2017-04-04 11:16:05 +08:00
Robin Ward	ebe232da47	Weigh staff votes more for New User of the Month badges	2017-04-03 16:52:31 -04:00
Robin Ward	a13a8dc96c	FIX: Safeguard to not award NewUserOfTheMonth if it hasn't been a month	2017-04-03 13:26:51 -04:00
Arpit Jalan	5ff29ce321	add test case for topic status update based on last post	2017-04-03 22:35:56 +05:30
Robin Ward	3d64f33d40	Require at least two likes to get the "New User of the Month" badge	2017-04-03 13:03:28 -04:00
Robin Ward	b189486fc0	We can do a lot less work in the test since we eased the criteria	2017-04-03 12:15:24 -04:00
Guo Xiang Tan	dc5a6e7cda	Remove empty test.	2017-04-03 21:12:20 +08:00
Guo Xiang Tan	5cf75c67df	FIX: Callback undefined error when topic has been deleted.	2017-04-03 09:06:15 +08:00
Robin Ward	e4b1376146	Change New User of the Month Badge to use trust level rather than age	2017-03-31 16:56:58 -04:00
Robin Ward	a8d3779f0b	Update New User of the Month badge to require 4 posts in 2 topics	2017-03-31 16:52:00 -04:00
Robin Ward	fc7fa4c0ad	Rename "Rookie of the Month" to "New User of the Month"	2017-03-31 16:30:30 -04:00
Robin Ward	893e93dfbe	New badge, Rookie of the Month, for two new high quality users.	2017-03-31 15:06:31 -04:00
Guo Xiang Tan	0bbad5040a	topic-status-info component wasn't updated when topic is closed/opened.	2017-03-31 15:58:26 +08:00
Guo Xiang Tan	b6e9871b4b	Update Topic#closed client side when closing/opening a topic temporarily.	2017-03-31 15:05:00 +08:00
Guo Xiang Tan	ed577fbff8	FEATURE: Pause a topic instead of permanently closing when flag threshold is reached.	2017-03-31 14:35:05 +08:00
Guo Xiang Tan	34b7bee568	FEATURE: Allow admin to auto reopen at topic. ... * This commit also introduces a `TopicStatusUpdate` model to support other forms of deferred topic status update in the future.	2017-03-31 11:14:18 +08:00
Robin Ward	7b6242bfbb	Minor cleanup of /users/ rename	2017-03-30 10:23:24 -04:00
Robin Ward	14410b71fb	Convert server side paths to use /u/	2017-03-30 10:23:24 -04:00
Robin Ward	45a257815a	Convert front end paths from /users/ to /u/	2017-03-30 10:23:24 -04:00
Robin Ward	6b976433c9	Support for both /users/ and /u/ paths	2017-03-30 10:23:24 -04:00
Yana Agun Siswanto	cd2d2f16e5	Allow to order search results by the topic creation date ... based on: https://meta.discourse.org/t/allow-to-order-search-results-by-the-topic-creation-date/38544	2017-03-30 01:18:38 +07:00
Guo Xiang Tan	7cf0f39066	Require Sidekiq::Testing in rails helper.	2017-03-29 11:10:25 +08:00
Arpit Jalan	4812417192	FIX: do not add user to group based on email domain unless email is confirmed	2017-03-28 15:02:40 +05:30
Arpit Jalan	8bf12502bd	Merge pull request #4780 from techAPJ/send-statistics ... FEATURE: Send anonymized usage statistics to Discourse if "Discourse Hub" can't reach the site	2017-03-28 10:02:05 +05:30
Arpit Jalan	f3cd5f61c5	FEATURE: Send anonymized usage statistics to Discourse if Discourse Hub can't reach the site	2017-03-28 09:07:23 +05:30
Régis Hanol	dd1cc23caf	fix randomly failing specs	2017-03-27 22:47:41 +02:00
Arpit Jalan	3378e2d49f	FIX: update topic fancy title when updating category name	2017-03-26 12:29:53 +05:30
Régis Hanol	dfe1d3adfd	Merge pull request #4778 from techAPJ/admin-message-format ... FIX: admin locales were not getting converted to message format	2017-03-25 11:59:56 +01:00
Guo Xiang Tan	7c17966171	FEATURE: Include email in User webhook. ... https://meta.discourse.org/t/should-the-email-address-of-a-new-user-be-included-in-the-webhook/59255	2017-03-25 08:23:01 +08:00
Arpit Jalan	3449339fea	FIX: admin locales were not getting converted to message format	2017-03-25 01:12:23 +05:30
Guo Xiang Tan	b87c5eb1b6	Fix randomly failing spec.	2017-03-24 15:46:42 +08:00
Guo Xiang Tan	3ef82bb32c	SECURITY: CSRF vulnerabilities in Admin::BackupsController.	2017-03-23 10:29:35 +08:00
Neil Lalonde	11ce73b8ed	FEATURE: category setting for default top period	2017-03-22 16:54:18 -04:00
Arpit Jalan	786fd6bbd2	Merge pull request #4774 from techAPJ/email-prefix ... FIX: use email prefix only in subject	2017-03-22 14:18:50 +05:30
Arpit Jalan	295cf8839e	FIX: better error message when invited user already exists	2017-03-22 13:55:28 +05:30
Arpit Jalan	1853a4852c	FIX: use email prefix only in subject	2017-03-21 20:29:57 +05:30
Arpit Jalan	df246c79b6	FEATURE: add user profile fields in user list export	2017-03-21 15:51:52 +05:30
Arpit Jalan	82c0f5f587	Merge pull request #4767 from techAPJ/activate-account ... FIX: send activation email if user have unconfirmed email address	2017-03-21 09:44:23 +05:30
Arpit Jalan	7c3ae50dcd	FIX: send activation email if user have unconfirmed email	2017-03-21 09:41:50 +05:30
Sam	74dbe877d8	test for side effect without mock	2017-03-20 16:15:23 -04:00
Sam	c106ca6778	FEATURE: fallback asset path for multi host setups	2017-03-20 15:59:17 -04:00
Arpit Jalan	8cbfa24ca2	Fix failing test	2017-03-20 20:14:25 +05:30
Arpit Jalan	521c88fe58	FIX: enqueue activation email for invited user that has password set	2017-03-20 17:13:21 +05:30
Guo Xiang Tan	a1d04a7a9a	Fix rspec tests.	2017-03-20 12:35:08 +08:00
Guo Xiang Tan	6057e17ae7	Fix weird test failure.	2017-03-20 12:06:37 +08:00
Robin Ward	fd591257a8	Merge pull request #4759 from kennym/support-ports-for-ip-addresses-in-embedding ... FIX: Allow ports for embed host IPs	2017-03-16 11:23:42 -04:00
Guo Xiang Tan	5169ef8814	Fix broken specs.	2017-03-16 15:05:28 +08:00
Guo Xiang Tan	bf78c228f4	FIX: User created web hook being enqueued before record has been saved. ... * Improve web hook tests as well.	2017-03-16 14:44:09 +08:00
Erick Guan	cfbfea0596	FEATURE: Allow easier customization to the web hook event serialization.	2017-03-16 10:09:05 +08:00
Guo Xiang Tan	bbc85e1e29	Merge pull request #4750 from discourse/group_login_registration_flow ... FEATURE: Redirect to groups page and apply group actions upon login/s…	2017-03-16 09:50:56 +08:00
Guo Xiang Tan	ca965bb455	FEATURE: Redirect to groups page after login/registration flow.	2017-03-16 09:48:51 +08:00
Kenny Meyer	ae957bca25	Allow ports for embed host IPs	2017-03-15 18:16:34 -03:00
Guo Xiang Tan	685c26961f	Fix randomly failing specs.	2017-03-14 16:28:05 +08:00
Guo Xiang Tan	6312b8b7e4	Fix failing specs.	2017-03-14 14:58:22 +08:00
Guo Xiang Tan	d173473509	Fix randomly failing specs.	2017-03-14 14:43:48 +08:00
Guo Xiang Tan	1a7e954e09	FIX: Store custom emojis as uploads. ... * Depending on a hardcoded directory was a flawed design which made it impossible to debug when custom emojis go missing.	2017-03-14 13:07:18 +08:00
Sam	64680286f4	correct logic, so revalidation is reset ... correct test so it can run at any point	2017-03-13 10:47:43 -04:00
Sam	a690121805	SECURITY: always allow staff to resend activation mails	2017-03-13 10:32:24 -04:00
Sam	ef24fd54ba	FEATUE: automatically validate token is stored in redis ... This ensures we have some handling for redis flushall We attempt to recover our in-memory session token once every 30 seconds Code is careful to only set the token if it is nil, to allow for manual cycling to remain safe if needed	2017-03-13 10:19:02 -04:00
Sam	82ca0e368e	FEATURE: stop escaping special chars in title prettify ... This feature is confusting and just leads to inconsistency	2017-03-13 10:02:20 -04:00
Guo Xiang Tan	9364d8ce71	FIX: Store user's id instead for sending activation email. ... * Email and username are both allowed to be used for logging in. Therefore, it is easier to just store the user's id rather than to store the username and email in the session.	2017-03-13 20:24:55 +08:00
Guo Xiang Tan	7ebfa3c901	SECURITY: Only allow users to resend activation email with a valid session. ... * Improve error when an active user tries to request for an activation email.	2017-03-13 19:35:29 +08:00
Arpit Jalan	848120c098	FEATURE: RSS feed for top page period filters	2017-03-13 15:23:46 +05:30
Guo Xiang Tan	4d4a1a1552	Add scope for human users.	2017-03-11 14:25:09 +08:00
Sam	6ebddc42d1	FIX: include children categories when searching a category	2017-03-10 15:58:47 -05:00
Neil Lalonde	402ddb810c	FIX: email customizations now apply to both html and text parts	2017-03-10 14:08:03 -05:00
Sam	bc1a6ccb90	Merge pull request #4741 from tgxworld/allow_bookmark_removal ... FIX: Allow user to remove bookmark from posts as long as bookmark is …	2017-03-10 12:49:20 -05:00
Arpit Jalan	f7e7ca3937	FEATURE: anonymized site statistics	2017-03-10 18:50:26 +05:30
Guo Xiang Tan	9cc79363e0	Merge pull request #4744 from tgxworld/feature_seen_unseen_search ... FEATURE: Search can be scoped to posts that the current user has seen…	2017-03-09 07:11:19 +08:00
Régis Hanol	23b06d2895	FIX: should not try to send digest to users who reached the bounce threshold	2017-03-08 19:19:11 +01:00
Guo Xiang Tan	c623951306	FEATURE: Search can be scoped to posts that the current user has seen/unseen. ... https://meta.discourse.org/t/advanced-search-posts-that-i-have-seen/57966	2017-03-09 01:01:33 +08:00
Arpit Jalan	801b5838e1	FIX: do not show faq/guidelines page to anonymous users for private forums	2017-03-08 16:00:49 +05:30
Régis Hanol	cf8bc4483f	FIX: always send critical emails even when bounce score threshold has been reached	2017-03-08 10:06:16 +01:00
Arpit Jalan	090236b15b	FIX: do not show about page to anonymous users for private forums	2017-03-08 13:15:44 +05:30
Guo Xiang Tan	689dd16be0	FIX: Allow user to remove bookmark from posts as long as bookmark is present. ... https://meta.discourse.org/t/bookmark-issue-when-access-to-topic-is-lost-pms/51993	2017-03-08 13:53:49 +08:00
Régis Hanol	ee9d621d9c	FIX: surround the FROM alias with " in order to support the @ character	2017-03-07 23:37:21 +01:00
Sam	99f4d5082b	FIX: Improve token rotation and increase logging ... - avoid access denied on bad cookie, instead just nuke it - avoid marking a token unseen for first minute post rotation - log path in user auth token logs	2017-03-07 13:27:43 -05:00
Neil Lalonde	0661cebbcf	fix intermittent failing spec	2017-03-07 11:59:05 -05:00
Neil Lalonde	d95e4102c1	FIX: tags created in secured categories should not be forbidden outside those categories	2017-03-07 11:46:46 -05:00
Robin Ward	dad57fa033	FIX: More errors with non-ascii URLs	2017-03-07 11:21:41 -05:00
Guo Xiang Tan	d1e587c10a	Merge pull request #4737 from oblakeerickson/approve_invited_user ... FIX: approve invited user	2017-03-07 21:14:34 +08:00
Régis Hanol	0abe433495	Merge pull request #4736 from techAPJ/group-bulk-add ... FIX: grant trust level when bulk adding users to group	2017-03-06 12:43:26 +01:00
Guo Xiang Tan	7d82a53dfe	FIX: Group#name is case insensitive.	2017-03-06 17:24:03 +08:00
Arpit Jalan	d5bcc70e9c	FIX: grant trust level when bulk adding users to group	2017-03-06 14:39:53 +05:30
Guo Xiang Tan	66b5f97743	Merge pull request #4739 from tgxworld/fix_cant_recover_a_topic_that_belongs_to_a_deleted_user ... Fix cant recover a topic that belongs to a deleted user	2017-03-06 15:12:54 +08:00
Guo Xiang Tan	8aea3caf00	FIX: Ensure that we only move posts that belong to the original topic.	2017-03-06 15:04:10 +08:00
Guo Xiang Tan	477eb0591e	FIX: Posts in a deleted topic couldn't be moved. ... https://meta.discourse.org/t/moving-posts-to-new-topic/58436/4	2017-03-06 14:56:20 +08:00
Guo Xiang Tan	a28704bcee	FIX: Can't recover a post when its user has been deleted. ... https://meta.discourse.org/t/moving-posts-to-new-topic/58436	2017-03-06 14:29:06 +08:00
Blake Erickson	dbb3ddc7a6	FIX: approve invited user ... This commit fixes the case where invited users who typed in a password would not be approved by default. Because we moved the user create logic for an invited user there was a clash with the `save` in the user model and the `save` in the invite_redeemer class. - added approve logic into invite_redeemer class. - added tests to verify that the user is approved - added a check to see if must_approve_users is on - added a check to see if the inviter is staff - go ahead and approve the user if must_approve_users is off - keep existing User.approve workflow if user exists - improve if/else logic to remove duplicate code - use `Time.zone.now`	2017-03-05 06:58:23 -07:00
Sam	c99f4260c0	Merge pull request #4729 from tgxworld/dont_mark_user_as_valid ... FIX: Don't mark user as `active` if verified email is different.	2017-03-03 15:57:30 -05:00
Neil Lalonde	6aab8cb331	FEATURE: new category setting for whether to show latest topics or top topics by default	2017-03-03 11:30:44 -05:00
Guo Xiang Tan	bcf634ca85	Merge pull request #4728 from nbianca/username-regex ... Add support for username regex.	2017-03-03 22:59:23 +08:00
Bianca Nenciu	30909ec54e	Add support for username regex.	2017-03-02 13:53:45 +02:00
Guo Xiang Tan	3d347fb9c4	FIX: Don't mark user as active if verified email is different.	2017-03-02 14:24:30 +08:00
Neil Lalonde	51d7dc4355	switch contents of embeddable_host_fabricator.rb and category_fabricator.rb	2017-03-01 15:13:31 -05:00
Neil Lalonde	262016604d	FEATURE: each category can control how many topics to show on categories page	2017-03-01 15:12:57 -05:00
Blake Erickson	80858bae2c	FEATURE: further restrict downloading of backups ... - send email to logged in admin when they press the "download" button - show pop-up that email was sent - create email template - require a valid token to download backup	2017-03-01 08:28:34 -07:00
Arpit Jalan	e27b1b98d1	FIX: handle new user when logging name change	2017-03-01 13:43:57 +05:30
Guo Xiang Tan	107d6783a9	Remove use of stubs in tests.	2017-03-01 10:53:03 +08:00
Guo Xiang Tan	76dd6933d2	Revert "Revert "Revert "SECURITY: Ensure oAuth authenticated email is the same as created user's email.""" ... This reverts commit e6d75f6844. This is why we should not be pushing directly to master.	2017-03-01 10:16:59 +08:00
Robin Ward	d27575176a	Enforce a minimum amount of posters in a topic for get_a_room	2017-02-28 16:47:16 -05:00
Sam	122fb8025d	FIX: last seen date erroneously updated when browser in background ... In some cases user may be "last seen" even though browser tab is in the background or computer is locked	2017-02-28 12:35:10 -05:00
Neil Lalonde	292dd8623c	Merge pull request #4622 from dmacjam/master ... FEATURE: Append tags bulk action for topics	2017-02-28 11:36:58 -05:00
Sam	3ac4709903	FIX: on initial token issue stop unmarking token as unseen ... prev and current are the same so we need special logic to bypass	2017-02-28 10:38:22 -05:00
Guo Xiang Tan	e6d75f6844	Revert "Revert "SECURITY: Ensure oAuth authenticated email is the same as created user's email."" ... This reverts commit 0e3def7d2b.	2017-02-28 11:27:14 +08:00
Sam	1e980ad4e6	Merge pull request #4721 from oblakeerickson/sort_admin_users_api ... FEATURE: Add order logic to admin users controller	2017-02-27 16:13:42 -05:00
Arpit Jalan	6661cebff8	FIX: do not log duplicate username changes	2017-02-28 01:32:00 +05:30
Neil Lalonde	e634b37f9a	FIX: from field of emails should be including email_site_title or site title settings	2017-02-27 14:23:07 -05:00
Arpit Jalan	b32d3d66e5	FEATURE: log all username and name changes	2017-02-28 00:23:27 +05:30
Robin Ward	0e3def7d2b	Revert "SECURITY: Ensure oAuth authenticated email is the same as created user's email." ... This reverts commit 1060239e2d.	2017-02-27 13:19:26 -05:00
Robin Ward	bf9626d031	FIX: Embedding was broken with non-english URLs and ports	2017-02-27 12:17:52 -05:00
Arpit Jalan	877957ae88	Merge pull request #4715 from techAPJ/login-per-ip ... FEATURE: new site setting for max logins per ip per hour/minute	2017-02-27 18:24:53 +05:30
Arpit Jalan	cba51e1c38	FEATURE: new site setting for max logins per ip per hour/minute	2017-02-27 16:58:03 +05:30
jomaxro	f5673fbd47	Remove references to elder ... The use of the TL4 name Elder was changed in 2014 to Leader. The spec function was changed to `:trust_level_4`, but the it statement was not changed.	2017-02-26 17:40:42 -07:00
Sam Saffron	7e8f0dc967	FIX: attempt to handle ios edge case where token is seen but unsaved ... This relaxes our security in the following way - prev auth token is always accepted as long as rotation date is within our window of SiteSetting.maximum_session_age.hours (previously old token expired within a minute of new one being seen) - new auth token is marked unseen if we are presented with an old token after we already saw new one This attempts to fix an issue where ios webkit is not committing new cookies	2017-02-26 17:09:57 -05:00
Blake Erickson	0e6cb752da	Clean up valid order names ... Add a sortable mappings list to match other endpoints and so that you don't have to use database column names. Example: 'created' => 'created_at' Also cleaned up some of the logic since a lot of it got moved into the SORTABLE_MAPPING hash.	2017-02-25 11:51:40 -07:00
Blake Erickson	e9d5c3265c	Change param asc to ascending ... For consistency, change param asc to ascending: https://meta.discourse.org/t/make-admin-users-list-sortable-suggestion/47649/17?u=oblakeerickson	2017-02-25 09:13:31 -07:00
Blake Erickson	0a41da6bad	FEATURE: Add order logic to admin users controller ... Added order and direction parameters for sorting admin user pages. This commit only includes backend api changes. https://meta.discourse.org/t/make-admin-users-list-sortable-suggestion/47649 Now you can pass in `order` and `asc` parameters to the `/admin/users/list/<query>.json` endpoint. Example: `/admin/users/list/active.json?&order=post_count` which defaults to desc and `/admin/users/list/active.json?order=post_count&asc=true`	2017-02-24 17:11:17 -07:00
Régis Hanol	ecdae9f863	FIX: i18n integrity specs ... FIX: check all .yml files in the project for integrity FIX: ensure localized yamls are compatible with english	2017-02-24 11:35:33 +01:00
Régis Hanol	a2c04be718	FIX: eradicate I18n fallback issues 💣 ... FIX: client's translation overrides were not working when the current locale was missing a key FIX: ExtraLocalesController.show was not properly handling multiple translations FIX: JsLocaleHelper#output_locale was not properly handling multiple translations FIX: ExtraLocalesController.show's spec which was randomly failing FIX: JsLocaleHelper#output_locale was muting cached translations hashes REFACTOR: move 'enableVerboseLocalization' to the 'localization' initializer REFACTOR: remove unused I18n.js methods (getFallbacks, localize, parseDate, toTime, strftime, toCurrency, toPercentage) REFACTOR: remove all I18n.pluralizationRules and instead use MessageFormat's pluralization rules TEST: add tests for localization initializer TEST: add tests for I18n.js	2017-02-24 11:31:21 +01:00
Guo Xiang Tan	1060239e2d	SECURITY: Ensure oAuth authenticated email is the same as created user's email.	2017-02-24 13:13:10 +08:00
Guo Xiang Tan	0847b4258a	Revert "SECURITY: Ensure that user has been authenticated." ... This reverts commit fbe51d68a7. Changing the commit message to correctly reflect what we're actually fixing.	2017-02-24 13:12:29 +08:00
Guo Xiang Tan	fbe51d68a7	SECURITY: Ensure that user has been authenticated.	2017-02-24 10:47:48 +08:00
Sam	f15f61da0a	FEATURE: add immutable caching to rails site of things	2017-02-23 13:05:00 -05:00
Sam	ea1007e954	FEATURE: add support for same site cookies ... Defaults to Lax, can be disabled or set to Strict. Strict will only work if you require login and use SSO. Otherwise when clicking on links to your site you will appear logged out till you refresh the page.	2017-02-23 12:01:28 -05:00
Neil Lalonde	0551b3f5ee	FEATURE: replace emoji with unicode in title and description meta tags	2017-02-22 16:24:13 -05:00
Sam Saffron	b7d2edc7dc	FIX: allow some auth token misses prior to clearing cookie ... It appears that in some cases ios queues up requests up front and "releases" them when tab gets focus, this allows for a certain number of cookie misses for this case. Otherwise you get logged off.	2017-02-22 12:37:11 -05:00
Arpit Jalan	213a496203	FIX: show all staff events related to the target user	2017-02-22 13:31:40 +05:30
Arpit Jalan	b32f33b3f0	FIX: allow staff members to send PMs when enable_private_messages is disabled	2017-02-22 11:32:09 +05:30
Neil Lalonde	c94fdcea38	FIX: admin dashboard posts count should not include system posts and whispers	2017-02-21 14:45:41 -05:00
Arpit Jalan	046cbad10b	FEATURE: add a button on admin user page that links to action log	2017-02-21 21:38:37 +05:30
Jakub Macina	4a2f13348a	ADD: Append tags bulk action for topics	2017-02-20 18:14:32 +01:00
Régis Hanol	f51e3b2131	FIX: should not be able to rename a system badge	2017-02-20 14:35:05 +01:00
Régis Hanol	cb99f59ec3	reset bounce score when email is successfully changed	2017-02-20 10:37:01 +01:00
Robin Ward	e62c0a42fa	FIX: Support multiple embeddable host records with the same host	2017-02-17 12:41:34 -05:00
Sam	7a85469c4c	SECURITY: inactive/suspended accounts should be banned from api ... Also fixes edge cases around users presenting multiple credentials	2017-02-17 11:03:09 -05:00
Neil Lalonde	c0e1722ca6	fix intermittent spec failure due to Time comparison with TimeWithZone	2017-02-17 10:30:29 -05:00
Neil Lalonde	3fb50d587d	FIX: invited users and new TL1 users will see their first notification highlighted	2017-02-17 10:30:29 -05:00
Jeff Atwood	9b263a0559	increase req min unique pw chars from 5 to 6	2017-02-16 17:06:19 -08:00