Loïc Guitaut
d991378218
DEV: Add comments in flags specs
...
Followup to https://github.com/discourse/discourse/pull/29325 .
This patch adds comments to tell why we need to destroy created flags in
specs once the examples have run.
2024-10-22 10:54:26 +02:00
Krzysztof Kotlarek
44c8470813
FIX: flaky flags spec after refactoring ( #29325 )
...
The bug was introduced here https://github.com/discourse/discourse/pull/29258
It is very important for flags to reset to their original state because they are cached and shared between specs.
2024-10-22 13:18:57 +11:00
Loïc Guitaut
64605519da
DEV: Fix flaky specs related to flag services
...
Creating or updating flags generates global side effects. Sometimes it
seems the state can leak from the flag specs.
This is probably related to the use of `fab!`. This patch replaces those
calls with standard `let`s. While the overall performances of these
tests will be a little less good, their state should not leak anymore.
2024-10-18 17:47:09 +02:00
Loïc Guitaut
7f607699b8
DEV: Refactor flag related services a bit
...
Extracted from https://github.com/discourse/discourse/pull/29129 .
This patch makes the code more compliant with the upcoming service docs
best practices.
2024-10-18 10:10:28 +02:00
Loïc Guitaut
d26d45540e
DEV: Use run_successfully matcher in service specs
2024-08-28 16:30:09 +02:00
Krzysztof Kotlarek
c3fadc7330
FEATURE: created edit and delete flags ( #27484 )
...
Allow admins to create edit and delete flags.
2024-07-03 08:45:37 +10:00
