github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2024-12-18 19:16:10 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity
31,875 Commits 214 Branches 500 Tags 960 MiB
db08b59eb2
Commit Graph

12787 Commits

Author SHA1 Message Date
Jeff Wong
9de906ddab
FIX: Register pan events for touch only 
* touch events - only register touch, not pointer events
* immediately request redraw frame, do not wait for after render to fire.
 2019-02-04 08:27:40 -08:00
Bianca Nenciu
e0e91fad87 FIX: Fix delete button for Tag Groups. (#6965) 2019-02-04 12:46:39 +01:00
Kris
2a2be093ca UX: checkboxes were too close to other inputs 2019-02-01 21:07:57 -05:00
Kris
37c28cf0b7 UX: Header icon color fix 2019-02-01 09:51:12 -05:00
David Taylor
eb617dea4b DEV: Run prettier on report.js.es6 
The prettier version I was running was different to the CI pipeline
 2019-02-01 13:22:31 +00:00
David Taylor
5c9426be48 SECURITY: Escape HTML in dashboard report tables 2019-02-01 13:10:59 +00:00
David Taylor
925606f8b1 FIX: Login button icons should be white 2019-02-01 11:01:59 +00:00
Kris
bbaa3e9166 Header icon focus color fix 2019-01-31 19:31:09 -05:00
Kris
95e16ab0a6 UX: Badge checkmarks should be round 2019-01-31 15:27:46 -05:00
Kris
6141290399 FIX: Mobile button colors 2019-01-31 15:13:54 -05:00
Penar Musaraj
3500acf2f6 FIX: refresh admin/customize/themes route after import 
Fixes an issue where the imported color schemes of a theme were not available immediately in the UI.
 2019-01-31 14:29:09 -05:00
Kris
0dfcbdeb54 ok/cancel button fix 2019-01-31 14:20:27 -05:00
Kris
3d394a6144 prettier 2019-01-31 14:06:32 -05:00
Kris
3eb000a968 UX: Overflow hidden was causing some icons to be cropped 2019-01-31 14:03:11 -05:00
Kris
94f16ba931 UX: Make button icons use lighter color instead of opacity 2019-01-31 13:59:49 -05:00
Arpit Jalan
4786b7ff81 FEATURE: when only option is "existing topic", autofocus input field 2019-01-31 11:23:04 +05:30
Jeff Wong
4763d6c9d7 FEATURE: add the show user action to the user-card-after-username plugin outlet 2019-01-30 14:56:14 -08:00
Robin Ward
bb8808985a REFACTOR: Remove a couple more self uses 2019-01-30 14:41:49 -05:00
Robin Ward
dca5486b78 REFACTOR: Prefer this over self 2019-01-30 14:29:45 -05:00
Penar Musaraj
c02e81fe01 FIX: regression with composer warnings 
Fixes composer warnings when: a) mentioning groups ("By mentioning @group, you are about to notify x people...") and b) mentioning users in a PM ("You mentioned @user but they won`t be notified...")
 2019-01-30 11:37:16 -05:00
Vinoth Kannan
096974d178 FIX: user_id attribute not found in posters array 2019-01-30 15:28:03 +05:30
Jeff Wong
fc5b2de85d FEATURE: add topic list before status plugin outlet for mobile 2019-01-29 17:15:31 -08:00
Joffrey JAFFEUX
0d0303e7ea
FIX: more resilient lookup in plugin-api (#6961) 
Ember3 is more picky about having a container being destroyed and it's easier to cause exceptions, especially in tests.

This fix has been initially created for an exception occuring in tests when running discourse-code-review and discourse-polls tests at the same time. `getCurrentUser` method body was failing as the container was destroyed.

Original  stacktrace:

```
"Error: Assertion Failed: expected container not to be destroyed
    at new EmberError (ember:2929:31)
    at assert (ember:1793:23)
    at Container.lookup (ember:17736:64)
    at PluginApi.getCurrentUser (discourse/lib/plugin-api:56:31)
    at allowUser (javascripts/discourse/initializers/init-code-review:38:29)
    at eval (javascripts/discourse/initializers/init-code-review:78:11)
    at eval (select-kit/mixins/plugin-api:86:19)
    at Array.forEach (<anonymous>)
    at eval (select-kit/mixins/plugin-api:85:44)
    at Array.forEach (<anonymous>)"
```
 2019-01-29 16:54:04 +01:00
Sam Saffron
32f9fd1e51 FIX: add autocomplete=off to composer textarea 
Somehow a plugin or some new Chrome bug is causing its heuristic to detect
our textarea for the composer as a target for address autocomplete

This is likely a chrome bug but this change is very safe regardless.
 2019-01-29 15:05:29 +02:00
Kris
f7deb52c90 FIX: Class name for external-link on customize page 2019-01-28 17:15:36 -05:00
Vinoth Kannan
62a0f88e97 FIX: More link in topic page search shouldn't navigate to full page result 2019-01-29 02:26:55 +05:30
David Taylor
aca0b32fda
FEATURE: Allow overriding text size from a different device (#6955) 
This brings the feature in line with the theme selection system
 2019-01-28 11:19:50 +00:00
Vinoth Kannan
7e4edcfae8 FIX: Convert lightbox html into proper image markdown 2019-01-27 01:21:56 +05:30
Neil Lalonde
cd3a167c63 FIX: javascript error when opening rename tag modal 2019-01-25 17:34:05 -05:00
Kris
94e2b77c5f Fix theme component name's color when theme is selected 2019-01-25 17:25:12 -05:00
Penar Musaraj
84a3da4b18 FIX: match drafts using key when deleting 
Using "sequence" when removing drafts was buggy, it would remove more than one draft from the stream sometimes.
 2019-01-25 13:55:40 -05:00
Joffrey JAFFEUX
0e1862013a
FIX: prevents race condition where the same report is loaded multiple times (#6953) 2019-01-25 19:29:45 +01:00
Joffrey JAFFEUX
7caa28cf45
FIX: ensures ordering set in tags-show queryString works at first load (#6951) 2019-01-25 16:48:20 +01:00
David Taylor
d338e54f59
FEATURE: Allow setting font size per-device using a cookie (#6947) 2019-01-25 15:06:06 +00:00
Vinoth Kannan
65caf04ddc clean up unused code 
Unused PM topic list column 'Users' is removed
 2019-01-25 20:13:54 +05:30
David Taylor
a48731e359
FEATURE: Support additional metadata in theme about.json (#6944) 
New `about.json` fields (all optional):
 - `authors`: An arbitrary string describing the theme authors
 - `theme_version`: An arbitrary string describing the theme version
 - `minimum_discourse_version`: Theme will be auto-disabled for lower versions. Must be a valid version descriptor.
 - `maximum_discourse_version`: Theme will be auto-disabled for lower versions. Must be a valid version descriptor.

A localized description for a theme can be provided in the language files under the `theme_metadata.description` key

The admin UI has been re-arranged to display this new information, and give more prominence to the remote theme options.
 2019-01-25 14:19:01 +00:00
Vinoth Kannan
2d6aa2aea2 FEATURE: Add recipient avatars in PM topic list even if they not yet replied 2019-01-25 19:41:49 +05:30
Kris
868528f862 Slight shadow adjustment to hide overflow 2019-01-24 14:49:39 -05:00
Robin Ward
a518950e52 FIX: Use context sensitive "create topic" via keyboard if possible 2019-01-24 13:20:33 -05:00
Kris
8e795d82f9 UX: Bump up notification panel width to accommodate larger text 2019-01-24 12:48:48 -05:00
Penar Musaraj
755b47b4bc UX: change topic reminder notification icon 2019-01-24 10:07:24 -05:00
Joffrey JAFFEUX
e5765fe1f5
FIX: ensures correct scroll position of textarea after autocomplete (#6942) 2019-01-24 15:19:19 +01:00
Vinoth Kannan
c88fd49591 DEV: refactor user preferences path method 2019-01-24 18:39:13 +05:30
Vinoth Kannan
b9bf751b88 FIX: link to the user preferences page is incorrect in user admin page 2019-01-24 18:31:00 +05:30
Joe
dda918f862
UX: removes width constraint in user-card badge section 2019-01-24 20:53:14 +08:00
Angus McLeod
b1297a5f5a FIX: replaces inline button message with d-button 2019-01-24 13:19:52 +01:00
Joffrey JAFFEUX
1f8ff85ff9
FIX: displays user-card when clicking on avatar of post small action (#6941) 2019-01-24 10:46:06 +01:00
Joe
22f43abb0e
UX: protection for very wide category-logo images on narrow screens 2019-01-24 17:16:18 +08:00
Kris
12df8c5c82 General style cleanup, removing unused styles 2019-01-23 21:37:39 -05:00
Kris
7d92fa3a5e Mobile SCSS cleanup and removing unused styles 2019-01-23 14:36:53 -05:00
Daniel
48c9234545 FIX: Lazy Loading: copy only present srcset 
When showing a lazy-loaded image, copy the `srcset` property only when
it is actually set. `copyImg.srcset = copyImg.srcset` is not actually a
noop but creates an empty `srcset`, changing content security rules on
the image.
 2019-01-23 14:04:43 -05:00
Joe
a9734eef81
UX: removes margins from categories in suggested topics message 2019-01-24 02:12:16 +08:00
Joffrey JAFFEUX
bd31423137
DEV: refactoring admin-logs-screened-ip-addresses (#6932) 2019-01-23 17:40:37 +01:00
Joffrey JAFFEUX
0aa049791e
DEV: refactoring admin-backups-index (#6933) 2019-01-23 17:40:24 +01:00
Joffrey JAFFEUX
60974932c4
DEV: refactoring api-keys (#6931) 2019-01-23 17:40:05 +01:00
Kris
9a594fed01 Removing unused bootstrap.scss file 2019-01-23 11:22:23 -05:00
Kris
5feeac221e Groups on user profile missing margin 2019-01-23 10:10:17 -05:00
David Taylor
afd449089f
FEATURE: Import and export themes in a .tar.gz format (#6916) 2019-01-23 14:40:21 +00:00
Joffrey JAFFEUX
d0129b85f4
FIX: stop propagating keyboard event when replying to topic/post (#6930) 2019-01-23 14:38:20 +01:00
Joe
d720215183 UX: admin badge page improvements 2019-01-23 11:29:51 +01:00
David Taylor
2e59a37687
FEATURE: List unused theme components (#6924) 2019-01-23 09:20:13 +00:00
Joe
b21266ed6f
FIX: corrects selector for move-to modal styles 2019-01-23 16:18:38 +08:00
Penar Musaraj
9886934ef5 DEV: fix some deprecated SVG icon refs 2019-01-22 14:42:00 -05:00
Kris
62adc2eb98 User admin page button height fix 2019-01-22 14:00:38 -05:00
Kris
66f6382090 FIX: Icon missing due to typo 2019-01-22 13:01:21 -05:00
Kris
f0fd875918 UX: Improving aligment within topic timer modal 2019-01-22 12:33:46 -05:00
Robin Ward
a834245683 FIX: Keep tags when switching to shared draft 2019-01-22 11:26:52 -05:00
Joffrey JAFFEUX
fc710de3ab
DEV: refactoring admin user index (#6927) 2019-01-22 16:44:55 +01:00
Joffrey JAFFEUX
31a700daf8
DEV: refactoring emoji-uploader (#6926) 2019-01-22 16:44:40 +01:00
Joffrey JAFFEUX
bce9c37f15
DEV: refactoring permalink-form (#6925) 2019-01-22 15:09:21 +01:00
Joffrey JAFFEUX
ea8373351b
DEV: refactoring ip-lookup (#6923) 2019-01-22 15:09:04 +01:00
Joffrey JAFFEUX
80d42b4ea2
icons deprecations fixes (#6920) 2019-01-22 12:02:02 +01:00
Joffrey JAFFEUX
ea0e188c8f
FIX: improves stacked-chart layout on ie11 (#6922) 2019-01-22 11:47:54 +01:00
Joffrey JAFFEUX
9148f7675b
FIX: better handling of resizing in stacked charts (#6921) 2019-01-22 11:20:50 +01:00
Joffrey JAFFEUX
7161304842
minor cosmetic improvements to charts (#6919) 2019-01-22 10:22:41 +01:00
Joffrey JAFFEUX
b1b27d9f7b
FEATURE: add total on stacked-chart tooltip (#6917) 2019-01-22 09:57:34 +01:00
Kris
fe6d571021 FIX: Alignment for small-actions, gap, removing unneeded clearfix 2019-01-21 17:57:47 -05:00
Kris
4ddc28f194 FIX: Whitespace breaks activity column in Firefox 2019-01-21 16:26:34 -05:00
Kris
8546f0020e UX: Invert pikaday png for dark themes 2019-01-21 13:47:46 -05:00
Penar Musaraj
ba5e17a7a9 FIX: IE11 layout glitches 
IE11 requires a unit on the third parameter (flex-basis) of the flex property
 2019-01-21 13:40:55 -05:00
Kris
ec71091216 FIX: Don't override user flair styles in topic map 2019-01-21 12:37:49 -05:00
Penar Musaraj
916219f48e Remove "Users" heading in wizard homepage preview 2019-01-21 11:31:00 -05:00
Joffrey JAFFEUX
3e1e9fce7e
FIX: better legend labels for stacked-charts (#6914) 2019-01-21 17:10:10 +01:00
Joffrey JAFFEUX
a9edcb2e10
fixes few icons deprecations warnings (#6915) 2019-01-21 16:56:05 +01:00
Joffrey JAFFEUX
b95165b838
FEATURE: adds a new chart report to track pageviews (#6913) 2019-01-21 15:17:04 +01:00
Joffrey JAFFEUX
52f2e0d6b9
SECURITY: fix possible XSS with badges (#6912) 2019-01-21 13:08:26 +01:00
Joffrey JAFFEUX
502b1316d0
DEV: s/this._super()/this._super(...arguments) (#6908) 2019-01-19 10:05:51 +01:00
Kris
61fff098ed minor email/whisper icon alignment fix 2019-01-18 20:59:52 -05:00
Kris
3b7ac3f6eb UX: We don't have bulk select on mobile, so we should hide the button 2019-01-18 20:26:58 -05:00
Kris
df0303c912 UX: Improve button alignment, fix invite header 2019-01-18 20:08:52 -05:00
Kris
e6e4a073a5 alignment fix due to font-size bump 2019-01-18 16:24:27 -05:00
Kris
4f897dde50 UX: Improve alignment of new post badge on mobile 2019-01-18 16:17:24 -05:00
Kris
247ab4a830 Align notification in unread education message 2019-01-18 15:40:07 -05:00
Joffrey JAFFEUX
7908a522a0
FIX: postLabel was not working for totals (#6904) 2019-01-18 17:06:43 +01:00
Penar Musaraj
f8f281cdad UI: update "latest" canvas layout in wizard 2019-01-18 09:56:39 -05:00
Joffrey JAFFEUX
b20ad9d684
FIX: since Ember 3 interceptClick was not working on buffered links (#6898) 2019-01-18 11:01:19 +01:00
Bianca Nenciu
cf6223226d DEV: Do the draft conflict check async. (#6895) 2019-01-18 15:51:56 +11:00
Penar Musaraj
2274d6d7ac FIX: refresh "/categories" on logo click (#6891) 
* FIX: refresh discovery categories on logo click

* Fix prettier offence
 2019-01-18 12:08:42 +08:00
Kris
9f52306861 Keep avatar image at native size for normal font-size, remove unneeded clearfix 2019-01-17 21:54:22 -05:00
Kris
8c5c4200ec prettier 2019-01-17 21:13:52 -05:00
Kris
5307e9337f HACK: Reduce icon jitter while scrolling with composer open in iOS 2019-01-17 21:04:05 -05:00
Kris
d5d994e24a UX: Improving user stream alignment and spacing 2019-01-17 17:29:27 -05:00
Kris
43bb16de27 Prevent header icons from overflowing with long title present 2019-01-17 16:11:40 -05:00
Kris
7401901939 UX: Badge alignment adjustments 2019-01-17 15:46:55 -05:00
Kris
3c987132cb Prevent placeholder text from being cut-off 2019-01-17 14:39:28 -05:00
Penar Musaraj
3501533a2b DEV: unpin Prettier version, apply to YAML files 
We had Prettier pinned because of https://github.com/prettier/prettier/issues/5529. Since that bug is fixed, unpinning.

Prettier now supports YAML, so this applies Prettier to all .yml except for translations, which should not be edited directly anyway.
 2019-01-17 13:05:39 -05:00
Kris
b664674d2b make smaller text size bigger 2019-01-17 12:11:31 -05:00
Vinoth Kannan
b9215ddaea FIX: Navigate to full page search when enter key used in topic 2019-01-17 22:34:23 +05:30
Kris
b9355f316a Minor size/alignment fixes for font size increase 2019-01-17 11:42:03 -05:00
Kris
675bf94133 UX: Bump up base font size 1px, add smaller text size option 2019-01-17 10:30:34 -05:00
David Taylor
880311dd4d
FEATURE: Support for localized themes (#6848) 
- Themes can supply translation files in a format like `/locales/{locale}.yml`. These files should be valid YAML, with a single top level key equal to the locale being defined. For now these can only be defined using the `discourse_theme` CLI, importing a `.tar.gz`, or from a GIT repository.

- Fallback is handled on a global level (if the locale is not defined in the theme), as well as on individual keys (if some keys are missing from the selected interface language).

- Administrators can override individual keys on a per-theme basis in the /admin/customize/themes user interface.

- Theme developers should access defined translations using the new theme prefix variables:
  JavaScript: `I18n.t(themePrefix("my_translation_key"))`
  Handlebars: `{{theme-i18n "my_translation_key"}}` or `{{i18n (theme-prefix "my_translation_key")}}`

- To design for backwards compatibility, theme developers can check for the presence of the `themePrefix` variable in JavaScript

- As part of this, the old `{{themeSetting.setting_name}}` syntax is deprecated in favour of `{{theme-setting "setting_name"}}`
 2019-01-17 11:46:11 +00:00
Joffrey JAFFEUX
740d047365
FIX: regression lead to a 404 when trying to filter user posts (#6893) 2019-01-17 11:31:23 +01:00
Kris
e7d2a0d42f UX: Larger/Largest font-sizes should be 1px larger on mobile 2019-01-16 20:59:31 -05:00
Jeff Atwood
1d4d4b81e6 remove stray chars 2019-01-16 15:05:43 -08:00
Jeff Atwood
f0999f27a7 UX: soften the "problems" alert on dashboard 2019-01-16 14:58:19 -08:00
Robin Ward
16a7102dad FIX: Ember.warn needs an id 
This way errors can be customized/silenced in the console.
 2019-01-16 14:53:13 -05:00
David Taylor
98f26bcaf5 Revert "FIX: makes click-interceptor working with touchstart (#6890)" 
This reverts commit fd2dd8d67d.
 2019-01-16 17:47:40 +00:00
Joffrey JAFFEUX
fd2dd8d67d
FIX: makes click-interceptor working with touchstart (#6890) 
Probable regression due to the removal of Modernizr.
 2019-01-16 17:56:43 +01:00
Penar Musaraj
18055f5e37 DEV: show remote theme repository URL 2019-01-16 11:09:16 -05:00
Joffrey JAFFEUX
1ac4dc5b73
FIX: makes whisper state more resilient (#6889) 
This commit also moves some logic from model to controller.
 2019-01-16 15:23:06 +01:00
Angus McLeod
54f95bb335 rm period (#6886) 2019-01-16 10:58:43 +01:00
Joffrey JAFFEUX
486df57a23
FIX: tweaking topic footer dropdowns (#6882) 
- no description on mobile for notifications
- better reason text positioning
 2019-01-16 10:27:27 +01:00
Guo Xiang Tan
f8db93df5f FIX: Consolidated like notifications links to wrong user on user page. 2019-01-16 15:55:18 +08:00
Penar Musaraj
71a69c1976 Revert "FIX: refresh topic list on logo click" 
This reverts commit 037776881b.
 2019-01-15 22:54:53 -05:00
Arpit Jalan
1591c42a06 FIX: profile picture not showing up on user admin page 2019-01-16 09:21:11 +05:30
Guo Xiang Tan
40533bc570 REFACTOR: filterBy in UserStream. 
Follow up to ebe65577ed.
 2019-01-16 10:53:44 +08:00
Guo Xiang Tan
ebe65577ed
FEATURE: Consolidate likes notifications. (#6879) 2019-01-16 10:40:16 +08:00
Penar Musaraj
037776881b FIX: refresh topic list on logo click 
Fixes a regression where, when homepage is set to "categories", clicking on logo would no longer reload topic list.
 2019-01-15 17:01:09 -05:00
David Taylor
b69e57e2f3 FIX: Prevent layout changes while images are lazy-loading 
This commit moves the temporary image to be adjacent to the original image in the DOM. Previously the temporary image was appended to the parent element. Normally this makes no difference because the temporary element has position:absolute. However, if the `:last-child` selector is being used on the parent, it can cause layout changes during loading.
 2019-01-15 17:35:55 +00:00
Gerhard Schlager
70cdb42173 FIX: Tooltip for unlisted topics wasn't shown in topic list 
The locale key had to be renamed, because this key is also used as CSS class.
The "invisible" CSS class makes the icon invisible. "unlisted" doesn't have that effect.
 2019-01-15 16:13:06 +01:00
Arpit Jalan
c4422fdc13 UX: sort admins and moderators by last seen date on /about page 
UX: only show active admins and moderators on /about page
 2019-01-15 17:26:11 +05:30
Robin Ward
f75915efa4 FIX: expandAllPinned was not resetting after visiting a category 
This resulted in a bug where if you saw a pinned topic in a category,
then went back to latest, the same topic would show an excerpt even
though it shouldn't on the latest view.

See:
https://meta.discourse.org/t/pinned-post-excerpt-no-longer-appears-after-refreshing-the-page/106222
 2019-01-14 13:02:25 -05:00
David Taylor
1ebd3dbbd0
FEATURE: Allow the base font size to be changed on a per-user basis (#6859) 2019-01-14 13:21:46 +00:00
Arpit Jalan
59e3eecfa6 FEATURE: allow staff to select existing message via ID or URL 2019-01-14 15:29:05 +05:30
Arpit Jalan
a121d40771
FIX: do not show PM topics when moving posts to an existing public topic (#6876) 2019-01-14 15:00:45 +05:30
David Taylor
49593d1a00 FIX: Fix registration dialog popup for 'full screen' social logins 
Regression following the ember3 upgrade. In addition to fixing, this commit consolidates our social registration logic into one place, and adds tests for the behaviour.
 2019-01-12 12:08:13 +00:00
Joffrey JAFFEUX
dcdcaebd0f
FIX: checkEmail was calling itself (#6878) 2019-01-12 11:12:17 +01:00
Kris
8176d26dbd UX: Reducing usage of btn-small, simplifying styles 2019-01-11 19:41:09 -05:00
Kris
e4c593f1e7 removing some dupe styles, adding button class 2019-01-11 15:41:51 -05:00
Kris
83f0afbec9 Usercards sometimes not wrapping correctly in Safari 2019-01-11 12:50:16 -05:00
Joffrey JAFFEUX
1a3655b787
DEV: s/Em/Ember (#6874) 2019-01-11 17:54:23 +01:00
Guo Xiang Tan
0fa92699e2 UX: Don't save automatically when resetting site settings in admin page. 2019-01-11 16:39:21 +08:00
Guo Xiang Tan
2956c52e57 FIX: Show title as home logo if title has been set and logo is blank. 
https://meta.discourse.org/t/default-text-logo-not-working/103936
 2019-01-11 15:46:58 +08:00
Kris
29ff184508 d60b9df fix, was too broad 2019-01-10 21:50:00 -05:00
Kris
d60b9dfba4 UX: Close button shouldn't get :visited color 2019-01-10 21:47:38 -05:00
Joffrey JAFFEUX
9f39ac8366
FIX: ember3 regression, uses model as bufferedProperty for badges (#6875) 2019-01-11 00:46:03 +01:00
Penar Musaraj
49e3a83062 FIX: minor regression when acting on queued post 2019-01-10 15:32:33 -05:00
Vinoth Kannan
0744e84604 UX: always scope the composer categories dropdown to current category 2019-01-11 01:07:23 +05:30
Vinoth Kannan
a8ff4a8a78 UX: search all categories even if category-chooser is scoped to particular category 2019-01-10 21:19:53 +05:30
Joffrey JAFFEUX
f9648de897
DEV: upgrades from Ember 2.13 to Ember 3.5.1 (#6808) 
Co-Authored-By: Bianca Nenciu <nbianca@users.noreply.github.com>
Co-Authored-By: David Taylor <david@taylorhq.com>
 2019-01-10 11:06:01 +01:00
Angus McLeod
798e98a7cc remove safari check from isAppleDevice (#6869) 2019-01-10 13:02:55 +11:00
Maja Komel
51b13ec86f FIX: show lock glyph to a user without permissions to see quote (#6854) 2019-01-10 09:48:05 +08:00
Robin Ward
312e282b6a FIX: Apply classes when lazily loading images 
If an image had extra classes (for example oneboxes), then while loading
the copy of the image would lose those classes and look differently
until the image had loaded fully.

This fix copies the classes while loading.
 2019-01-09 12:56:25 -05:00
Jeff Wong
439eff4709 revert null checking around interceptClick 2019-01-09 09:44:30 -08:00
David Taylor
2d3e50ae7c FIX: Match default <code> padding to highlightjs padding 
Without this, the height of posts changes once highlightjs is lazy-loaded, potentially causing scrolling issues
 2019-01-09 17:36:51 +00:00
Robin Ward
8b3ddcf646 FIX: Add topic status to flagged topics list 
Previously at a glance it was impossible to tell if a topic was closed
before digging deeper.
 2019-01-09 10:59:35 -05:00
Vinoth Kannan
1f12a377fa minor refactoring of card-contents-base mixin 2019-01-09 19:32:30 +05:30
Vinoth Kannan
b7c501bf52 FIX: full page search results are unclickable 
data-ember-action can have empty value in favor of data-ember-action-ID attribute
 2019-01-09 10:59:37 +05:30
Zach Whitehead
2748822576 FEATURE: Remove option for Google Plus sharing (#6864) 
* Remove option for Google Plus sharing

* remove google+ share translations
 2019-01-09 10:17:50 +08:00
Joffrey JAFFEUX
25269a37aa FIX: do not show #uncategorized in category drop if setting is disabled (#6856) 2019-01-09 09:44:24 +08:00
Jeff Wong
09cbd08c64 FIX: ensure ember transitions do not get hijacked by discourse intercept-click 
explicit null checks as a blank string evaluates to false
 2019-01-08 15:38:13 -08:00
Jeff Wong
d75262046d Revert "FIX: ensure ember transitions do not get hijacked by discourse intercept-click" 
This reverts commit a2cb2f2366.
 2019-01-08 15:37:10 -08:00
Jeff Wong
a2cb2f2366 FIX: ensure ember transitions do not get hijacked by discourse intercept-click 
explicit null checks as a blank string evaluates to false
 2019-01-08 15:09:50 -08:00
Kris
cfb8e157a2 Fixing tag alignment 2019-01-08 16:25:11 -05:00
Kris
4a01fee41b UX: use default H2 and H3 sizes on user profiles for better hierarchy 2019-01-08 13:07:29 -05:00
David Taylor
fe20cb4b56 FIX: Enforce a fixed height on generic oneboxed videos 
This prevents 'jumping' as the video loads. This change will require posts to be rebaked before it takes effect.
 2019-01-08 16:22:03 +00:00
Joe
a2d1babac6
UX: tag container should wrap if there's a large number of tags 2019-01-08 23:33:47 +08:00
Joe
3457395f75
UX: moves topic-list excerpts out of category / tag div 2019-01-08 14:55:15 +08:00
Arpit Jalan
4ebf170fe4 DEV: no need for conditional redirect in invites 2019-01-08 11:34:26 +05:30
Guo Xiang Tan
ef72a9a1fe UX: Default search log index to yearly. 2019-01-08 13:40:38 +08:00
Arpit Jalan
e0bc82657b FIX: better accept invite flow when user is invited via a link 2019-01-07 14:22:08 +05:30
Joe
effb3262a1
UX: no need for margin if participants is first-child 2019-01-06 00:11:53 +08:00
Joe
3a9fea4409
align and truncate header tags and participants 2019-01-05 23:09:44 +08:00
Vinoth Kannan
046e4ab413 FIX: Improve topic small header alignment in mobile 
Force topic-header-extra height to 20px
 2019-01-05 14:06:06 +05:30
Vinoth Kannan
3589f3e023 UX: Display user and group cards over the small PM header 2019-01-05 04:58:56 +05:30
Vinoth Kannan
aba18a42a7 UX: Improve PM small header alignment with recipient avatars 2019-01-05 03:51:15 +05:30
Régis Hanol
5ac1e3d4cd FIX: emojis are hard 🤷 2019-01-04 17:21:16 +01:00
Penar Musaraj
f400830575 DEV: Remove old _firefoxPastingHack 2019-01-04 11:14:35 -05:00
Régis Hanol
95e5f8380d FEATURE: Allow plugins to add custom emoji translations 
FIX: buildTranslationTree was erroring when translations overlapped (ie. ":-)" and ":-))")
FIX: emoji translations wasn't working properly when translations overlapped
 2019-01-04 15:27:46 +01:00
David Taylor
5bf16d7d10 FEATURE: Topic timer for bumping a topic in the future 2019-01-04 13:08:04 +00:00
Joe
3a04e04ccb UX: excerpts don't wrap on IE11 (#6847) 2019-01-04 15:11:42 +11:00
Kris
a2f1d47506 Slightly better alignment of PM participants in header 2019-01-03 22:47:56 -05:00
Sam
d0f38dbb07 FIX: image rendered temporarily in wrong position while loading 
Previously non lightboxed images would render in the wrong spot while loading.

We assumed the image we were rendering while loading was at 0,0 position.
This is not the case on non-lightboxed images cause they have no surrounding
DIV.
 2019-01-04 11:50:44 +11:00
Vinoth Kannan
385829d7be FEATURE: Display error message when category restriction is applied for tags 2019-01-04 00:29:13 +05:30
Penar Musaraj
a953b71797 FEATURE: allow custom HighlightJS languages 
Adds pluginApi function that allows themes and plugins to register languages for HighlightJS.
 2019-01-02 19:07:36 -05:00
Kris
4af7471ead Better contrast ratio match between dark and light themes 2019-01-02 17:54:22 -05:00
Jeff Wong
49fbedc445
FIX: make full height menu and cloak respect custom headers (#6845) 2019-01-02 14:18:14 -08:00
Sam
0c11caf796 UX: remove gray background from lighbox 
This avoids a 3 way transition when loading images

- grey
- ultra low res
- full image

Instead we go

- ultra low res
- full image
 2019-01-03 08:16:33 +11:00
Jeff Wong
e8a75628fd Revert "FIX: make full height menu and cloak respect custom headers" 
This reverts commit a61d9deba1.
 2019-01-02 11:51:03 -08:00
Gerhard Schlager
dc477d1228 FIX: "Toggle topic bump" wasn't visible for TL4 users 2019-01-02 20:16:55 +01:00
Jeff Wong
a61d9deba1 FIX: make full height menu and cloak respect custom headers 2019-01-02 11:05:44 -08:00
Gerhard Schlager
c30996129f FEATURE: Allow TL4 users to reset bump date 2019-01-02 16:57:05 +01:00
Vinoth Kannan
0884cd218d UX: Add group name next to PM recipient avatar 
Also changed group icon color and did minor refactoring
 2019-01-02 15:26:42 +05:30
David Taylor
27ed60bad0 FIX: Quote selection in IE11 2018-12-31 13:54:05 +00:00
Arpit Jalan
70fdc10365
FEATURE: move posts to new/existing PM (#6802) 2018-12-31 17:17:22 +05:30
Saurabh Patel
0fca3205b5 FIX: show error msg on grant badge if message available from backend (#6801) 2018-12-31 10:46:39 +01:00
Arpit Jalan
1381dc603d UX: show generic message when reloading 'activation email resent' page 2018-12-31 13:12:37 +05:30
Joe
6fb421312e
UX: aligns categories and tags in topic lists 
History:

https://meta.discourse.org/t/minor-visual-weirdness-on-topic-listing-category-and-tags/105268
 2018-12-31 14:38:33 +08:00
Joe
55d745f03b
UX: header needs a bit of padding on narrow screens 
A bit of history

https://meta.discourse.org/t/header-on-responsive-window/105204
 2018-12-31 14:33:02 +08:00
Vinoth Kannan
021f11b68e FEATURE: Display avatars of PM recepients in small topic header when scrolling down 2018-12-30 20:10:40 +05:30
Joffrey JAFFEUX
e7cf642b1f
FIX: reports issues with ie11 (#6828) 2018-12-28 21:32:07 +01:00
Joffrey JAFFEUX
9a8db2748a
FIX: composer css fixes for ie11 (#6827) 2018-12-28 20:52:21 +01:00
Joffrey JAFFEUX
f1269fa807
FEATURE: Add Top Uploads report (#6825) 
Co-Authored-By: I am very Pro-Grammer. <khalilovcmded@users.noreply.github.com>
 2018-12-28 20:48:54 +01:00
Joffrey JAFFEUX
608abd4c08
FIX: uses flex: 1 0 0; instead of flex: 1; for better browser compat (#6826) 2018-12-28 20:21:32 +01:00
Joffrey JAFFEUX
7b15b87cf5
FIX: better left/right positioning in select-kit components (#6824) 2018-12-28 19:46:31 +01:00
Joffrey JAFFEUX
0f09cb50e9
FIX: less fancy pages computation for browser compatibility (#6823) 2018-12-28 19:07:29 +01:00
Penar Musaraj
4f6ca66df5 FIX: routeToTag mini-fix for IE11 
skip "a.host" for IE11 since IE11 does not support URL interface
 2018-12-28 11:49:51 -05:00
Penar Musaraj
fdfb7ed764 FIX: Limit previous IE SVG click event fix 
Fixes issues with clicking SVG icons in Safari, IE11, Edge
 2018-12-28 10:18:53 -05:00
Joe
74f0bd08c0
UX: removes unnecessary margin in header tag wrapper 
This margin is not needed and doesn't exist in the mobile view. 

It causes a bit of a problem in desktop topics with no categories and more prominently in PMs in the desktop view.

There's a small TODO here where the rest of the extra-info-wrapper styles should all be moved to header sylesheets.
 2018-12-28 21:31:41 +08:00
Joffrey JAFFEUX
942114b34c
FIX: optimize collapse/expand select-kit codepath (#6818) 2018-12-27 23:38:01 +01:00
Joffrey JAFFEUX
695894d458 FIX: delete dataset doesn’t work on safari 2018-12-27 06:49:49 +02:00
Vinoth Kannan
2076f371b3 FIX: Hashtags should work for non-english characters 2018-12-26 22:12:40 +05:30
Joffrey JAFFEUX
0402f0f357
UX: new site setting to define activity metrics displayed on dashboard 2018-12-26 10:29:07 +01:00
Sam Saffron
69aa8f18c2 FEATURE: allow for custom excerpt BBCODE 
This allows fidelity in controlling excerpt (text that shows up when you pin a topic or link to it externally):

```
I am some text

[excerpt]
This is some **custom** markdown that should be the excerpt
[/excerpt]

More text
```

Previous solution relied on DIVs, unfortunately DIVs do not play well,
by design with mixing markdown unless you have a preceding newline eg:

```
<div class='hello'>

this will be treated properly as markdown

</div>
```

This extra newline is not desirable.

I am also considering adding

```
[div class=excerpt]
[/div]
```

This would offer lots of flexibility to themes and plugins that do not want the extra annoying newline.
 2018-12-25 17:02:28 +02:00
Arpit Jalan
1e2b81991f fix the build 2018-12-25 10:27:51 +05:30
Jeff Atwood
a74e49c87c use proper typographical × instead of x 2018-12-24 20:33:17 -08:00
Vinoth Kannan
b3df4bee9c FIX: Hide group membership request button for existing members 2018-12-24 13:49:05 +05:30
Saurabh Patel
f4d8a330c3 Merge pull request #6761 from mrfinch/saurabh/show-popup 
FIX:show popup before bulk invite
 2018-12-21 21:36:17 +01:00
Robin Ward
0e710dc573 Improvements to Lazy Loading 
- Now applied to all images over 150x150px

- Stores the width and height in the WeakMap rather than using
percentages for accuracy

- When oneboxed images are hidden, they are given a subtle border for better
visibility.

- Don't apply when in the composer. Causes flickering.
 2018-12-21 11:31:27 -05:00
Robin Ward
a2ae67509d Don't use getAttribute if we don't need to 2018-12-20 16:41:04 -05:00
Kris
816acc6984 Improving color contrast of $danger-low for dark themes 2018-12-20 14:46:13 -05:00
Penar Musaraj
28283c2396 FIX: Workaround for Edge issue with clicks on SVGs 
- Related Edge issue at https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/10583086/
 2018-12-20 11:13:55 -05:00
Sam Saffron
400eea4d13 UX: show lazy loaded images while they are downloading 
Also shows fuzzy image right away prior to it being downloaded
 2018-12-20 22:04:30 +08:00
Joe
d7466156ae UX: adds missing wizard icons 
With our recent move to SVG icons, the font file does not work in the wizard. I've opted for path2D, which accepts an SVG path

Path2D is not supported by IE11 but the chances of admins running the wizard on IE11 are practically none. 

https://caniuse.com/#feat=path2d
 2018-12-20 14:55:40 +02:00
Rishabh
3d2c72dd33 UX: Switch placeholder to an SSH url if importing a private theme 2018-12-20 17:01:50 +05:30
Vinoth Kannan
dc292d4598 FIX: Use one-way binding to prevent unnecessary updates in site.periods 2018-12-20 03:39:05 +05:30
Joffrey JAFFEUX
e655e1863f
UX: Adding reports dashboard tab, new layout, report descriptions (#6790) 
Co-Authored-By: Kris  <shout@k-ris.com>
 2018-12-19 14:44:43 +01:00
Penar Musaraj
f5c4ab0573 Add category link renderer to plugin API (#6787) 
* Add category link renderer to plugin API

- lets themes/plugins override the category link display

- planning to use this in a "category icons" theme component

* small code review fix

* Code review refactor
 2018-12-19 10:26:09 +01:00
Bianca Nenciu
7050ce4638 FIX: Bypass draft check when switching to shared draft. (#6782) 2018-12-19 10:25:33 +01:00
Maja Komel
0ce5f05b2a FIX: hide emails on admin user list for moderators (#6781) 2018-12-19 10:24:57 +01:00
Kris
41e06efb94 Adding padding to mobile that was removed in 3710b016 2018-12-18 22:20:02 -05:00
Kris
3710b01660 Header was 16px too narrow due to border-box and padding 2018-12-18 20:38:43 -05:00
Kris
5b9c1bcf59 User page button style fix 2018-12-18 20:36:42 -05:00
Neil Lalonde
6774b64aef FEATURE: add /conduct as an alias for /guidelines 2018-12-18 16:40:24 -05:00
Robin Ward
662cfc416b FEATURE: Show a blurry preview when lazy loading images 
This generates a 10x10 PNG thumbnail for each lightboxed image.
If Image Lazy Loading is enabled (IntersectionObserver API) then
we'll load the low res version when offscreen. As the image scrolls
in we'll swap it for the high res version.

We use a WeakMap to track the old image attributes. It's much less
memory than storing them as `data-*` attributes and swapping them
back and forth all the time.
 2018-12-19 01:57:30 +08:00
Gerhard Schlager
32784ad11a FIX: Disable multipart backup uploads to S3 
Multipart upload from within the browser result in corrupt files on S3.
 2018-12-18 16:01:15 +01:00
Gerhard Schlager
081aa6ad2b UX: Use new FA5 icons on Backups tab 2018-12-18 16:01:14 +01:00
Vinoth Kannan
341a6bd78a
REFACTOR: Calculate CTR in SearchLog model and hide unique column (#6791) 2018-12-18 19:13:46 +05:30
Maja Komel
98d09c90ac Current user serializer groups (ef7f84b follow-up) 2018-12-18 09:05:45 +01:00
Kris
2a518c88d0 Prevent bullet badge from shrinking/growing as flex item 2018-12-17 21:05:32 -05:00
Kris
7d7b6baab9 Topic-list category width restriction no longer needed 2018-12-17 21:01:04 -05:00
Vinoth Kannan
ece44a44f8 UX: Change default date range of dashboard trending search report to a month 2018-12-18 03:00:30 +05:30
Bianca Nenciu
f0027961c7 FIX: Properly reset controller of admin-user-index. (#6760) 2018-12-17 15:28:29 +01:00
Joffrey JAFFEUX
22cea9ce90
FIX: adusts select-kit position even if not expanded (#6785) 2018-12-17 12:29:51 +01:00
Joffrey JAFFEUX
6ee3900791
FIX: ensures nothing is triggering rendering loop in after render (#6784) 2018-12-17 12:15:03 +01:00
Gerhard Schlager
1a8ca68ea3 FEATURE: Improve backup stats on admin dashboard 
* Dashboard doesn't timeout anymore when Amazon S3 is used for backups
* Storage stats are now a proper report with the same caching rules
* Changing the backup_location, s3_backup_bucket or creating and deleting backups removes the report from the cache
* It shows the number of backups and the backup location
* It shows the used space for the correct backup location instead of always showing used space on local storage
* It shows the date of the last backup as relative date
 2018-12-17 11:35:11 +01:00
Maja Komel
040ddec63d Fix avatar flair styles 2018-12-17 10:44:34 +01:00
Saurabh Patel
ed1a309fe4 FIX: use new key for delete topic to make it lowercased as all other buttons label around it (#6778) 2018-12-17 10:55:19 +08:00
Joffrey JAFFEUX
d803dfc14a
FIX: makes more resilient select-kit positioning (#6776) 2018-12-15 16:23:23 +01:00
Kris
6213e020e6 Improving usercard badge alignment 2018-12-14 22:16:18 -05:00