github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2024-12-14 15:38:31 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity
38,782 Commits 214 Branches 500 Tags 960 MiB
db8b8742c4
Commit Graph

22987 Commits

Author SHA1 Message Date
Joffrey JAFFEUX
3e161e372a
FEATURE: allows to have header/footer in publshed pages (#10067) 
Usage: fill Header/Footer sections of your theme.
 2020-06-19 09:51:03 +02:00
Martin Brennan
b5495b8e9c
FIX: Do not incorrectly add topic bookmark on Escape (#10088) 
* The first post was showing as bookmarked incorrectly after pressing f to open the topic modal then pressing escape to cancel without saving, because the closeWithoutSaving option was not being respected.
* Also re-introduce the enter shortcut when the name input is focused to saveAndClose the bookmark modal by pressing enter.
 2020-06-19 11:17:18 +10:00
Kris
5faf074e61 minor fix to post admin menu button class 2020-06-18 19:18:00 -04:00
Vinoth Kannan
ae47bcb269
DEV: move user references deletion code to before_destroy. (#10085) 
Moving the `delete_source_user_references` method code from user merger service to user model.
 2020-06-18 17:42:39 -04:00
Bianca Nenciu
a1df68d4c4
FIX: Do not change tracked categories for staged users (#10076) 2020-06-18 21:09:54 +03:00
Cassius
d13d5e2b99
FIX: Allow multiple hyphens in host (#10078) 
* FIX: Allow multiple hyphens in host

* FIX: added spec for multiple hyphens
 2020-06-18 13:58:47 -04:00
Robin Ward
494a27dc27 FIX: A much nicer error message if you can't ignore/mute a user 2020-06-18 13:41:27 -04:00
Robin Ward
6cb6faff29 UX: Ignore modal margin was too tight 2020-06-18 13:26:25 -04:00
Joffrey JAFFEUX
b8c676e727
FEATURE: allows to ignore a user forever (#10074) 2020-06-18 11:24:07 -04:00
Bernhard Suttner
e31471585a
DEV: allow to have duplicate topic titles if categegory is different (#10034) 
Co-authored-by: Robin Ward <robin.ward@gmail.com>

Co-authored-by: Robin Ward <robin.ward@gmail.com>
 2020-06-18 11:19:47 -04:00
Mark VanLandingham
ec794c7f29
DEV: Plugin outlet after user-info (#10072) 2020-06-18 10:18:34 -05:00
Dan Ungureanu
d21a08c284
DEV: Deprecate Category#url_with_id in favor of Category#url (#9972) 2020-06-18 11:32:14 +03:00
Dan Ungureanu
62faa0f5fe
FIX: Do not show Add or Change buttons if email is not editable (#10068) 2020-06-18 11:15:44 +03:00
Penar Musaraj
d72ed8c5a8
UX: Include category name in hyperlink modal results on mobile 2020-06-17 14:46:01 -04:00
Dan Ungureanu
a60a67c431
FIX: Show unconfirmed emails too when checking emails (#10062) 
When checking emails through user preferences, it did not display the
unconfirmed emails.
 2020-06-17 21:41:01 +03:00
Jeff Wong
81a3129ffb
ARIA - add aria-label on topic input and post textarea (#10057) 
Add reply form role with label as create/reply, and aria-labels on text inputs
 2020-06-17 08:55:19 -07:00
Penar Musaraj
76b05ef8ad
DEV: Use short_date helper for email post template (#10063) 2020-06-17 11:29:37 -04:00
David Taylor
6caad5c083
FIX: Do not send staff welcome message if user already has role 2020-06-17 12:12:55 +01:00
Joffrey JAFFEUX
9da3a7f436
FEATURE: allows published pages to be public (#10053) 2020-06-17 12:42:20 +02:00
Jarek Radosz
7d289a4f3e
UX: Style video elements, show descriptions (#10040) 
It's a stop gap – ideally we would generate a thumbnail for uploaded videos. For now, a bit of intentionality in the style and a pinch of context should do.
 2020-06-17 12:38:00 +02:00
Jarek Radosz
a859d507e7
FIX: Prevent producing "undefined" strings (#10042) 
Fixes a bug in search-menu-results (type: "group"), where:

```javascript
const fullName = escapeExpression(group.fullName);
const name = escapeExpression(group.name);
const groupNames = [h("span.name", fullName || name)];
```

`groupNames` could end up having value "undefined" if a group doesn't have a `fullName`.
 2020-06-17 12:37:06 +02:00
Faizaan Gagan
d66ccabdb1
DEV: Added topic-list-after-title outlet in the mobile template (#10059) 2020-06-17 10:05:37 +01:00
Guo Xiang Tan
52580605d8 FIX: select-kit components not being hidden. 2020-06-17 09:39:51 +08:00
tshenry
a3e812453e
FEATURE: new category-list-above-each-category plugin outlet (#10037) 2020-06-16 11:53:36 -07:00
Jarek Radosz
df0e3b4ed4
FIX: Allow opening FAQ in a new tab (#10039) 2020-06-16 17:35:04 +02:00
Samuel Carvalho Santos
ce37561e10
UX: Improve revert label in post history modal (#10038) 2020-06-16 11:31:25 -04:00
spirobel
4b4f568ec0
add showPreview to composer fields plugin outlet (#10019) 
showPreview is necessary because we need to add 50% width class similar to: class="title-and-category with-preview" on the category and title div if the preview is shown.
 2020-06-16 10:50:55 -04:00
Dan Ungureanu
f1b97202d4
FIX: Ensure users can confirm new emails using security keys 2020-06-16 14:19:21 +03:00
Dan Ungureanu
84dfaad137
FIX: Fill acting_user field instead of target_user in history 2020-06-16 13:30:58 +03:00
Dan Ungureanu
219bb0b6a7
DEV: Fix build 
Follow-up to 6258406419.
 2020-06-16 13:00:09 +03:00
Krzysztof Kotlarek
6258406419
FIX: secondary_emails, unconfirmed_emails, group_users are private fields 
Those fields should be only visible to the user.
 2020-06-16 12:46:27 +03:00
David Taylor
a2f80670e1
FIX: Do not count youtube thumbnail when counting post images (#10049) 2020-06-15 20:25:30 +01:00
Penar Musaraj
298393a5bc
FIX: Keep onebox styling in edit history 2020-06-15 15:23:14 -04:00
Arpit Jalan
a94387c088 FIX: check for inviter group permissions at the time of redeeming invite 2020-06-15 14:44:35 +05:30
Guo Xiang Tan
402b80f306
DEV: Make rails_failover compatible with SKIP_DB_AND_REDIS env. 2020-06-15 16:23:24 +08:00
Guo Xiang Tan
58e52c0e4f
DEV: Use rails_failover gem for ActiveRecord and Redis failover handling 2020-06-15 15:47:07 +08:00
Arpit Jalan
6780d4d70c FIX: process /invites/ route from server side only 2020-06-15 12:31:27 +05:30
Guo Xiang Tan
d8cd912769
DEV: Switch to db config to disable advisory locks. 2020-06-15 14:33:41 +08:00
Martin Brennan
35a157619a
FEATURE: Add "Now" as an option (default hidden) to the future date input selector (#10047) 
Sometimes you need to schedule things from now onward. "Now" in this case is now + 1 minute. this option is hidden by default.
 2020-06-15 14:06:03 +10:00
Kris
7429512ced FIX: Get correct right/left offset for topic progress bar on compose 2020-06-12 18:44:42 -04:00
Kris
16b41aa485 Save button alignment fixes for admin badge page 2020-06-12 17:15:59 -04:00
Kris
2adad96d05 Center align items in select kit headers 2020-06-12 17:07:50 -04:00
Kris
d0a7f15764 Usercard buttons on mobile should utilize full width 2020-06-12 16:24:25 -04:00
Bianca Nenciu
ff6811ceb8
Allow multiple groups which can vote when creating a poll (#10015) 
* FEATURE: Allow multiple groups which can vote when creating a poll

* DEV: Fix select-kit deprecations

* DEV: Fix lint
 2020-06-12 14:52:32 +03:00
Dan Ungureanu
111877db1f
FIX: Load I18n first in show_confirm_new_email page 2020-06-12 14:49:16 +03:00
Bianca Nenciu
60196cc192
FIX: Hide bootbox after a negative answer (#10028) 
Starting to reply and then editing a post was not possible because of a
bootbox which kept showing up.
 2020-06-12 13:48:45 +02:00
Sam Saffron
7211394e4d
FEATURE: include tags in unread/new messages 
We need this information to maintain counts on tracked/watched
tags.
 2020-06-12 16:20:30 +10:00
Penar Musaraj
f57ecf22e0
UX: Send background color to iPad app too 
Previously, we were only updating mobile devices.
 2020-06-11 23:20:25 -04:00
Guo Xiang Tan
2fbd4eb11f
DEV: Remove double query in Group#remove_review_group. 
Probably a mistake during commit.
 2020-06-12 10:14:45 +08:00
Guo Xiang Tan
62ad473716
FIX: Preload readonly mode attribute seperately. 
There are two problems I'm trying to tackle here.

1. The site json is cached for anonymous users so readonly mode can be
cached for up to 30 minutes which makes it confusing.

2. We've already checked for readonly mode in the controller so having
to check for readonly mode again in `SiteSerializer` is adding an extra
Redis query on every request.
 2020-06-12 09:54:05 +08:00
Dan Ungureanu
b7e70850e4
FIX: Allow users to add emails which were deleted before 2020-06-11 14:54:11 +03:00
Bianca Nenciu
dd85d44dda
FIX: Show tag count for existing tags (#9892) 
* FIX: Show tag count for existing tags

* Add test
 2020-06-11 14:13:48 +03:00
Joffrey JAFFEUX
6fa990f05d
FIX: prevents emoji in links to appear as large emojis (#10027) 2020-06-11 12:27:48 +02:00
Sam Saffron
a26b490047
FIX: present correct new/unread counts when filtered by tag 
Previously we would incorrectly ignore tags.

This ensures tracking state is properly shipped to client if
show_filter_by_tag is enabled.
 2020-06-11 16:47:57 +10:00
Mark VanLandingham
b8acb36532
DEV: Plugin outlet at top of user preference interface (#10020) 2020-06-10 13:36:50 -05:00
Blake Erickson
1ce6ff0a55 DEV: Include raw in post webhook serializer 
This came in as a request on meta to include the raw field in the post
webhook serializer.

 https://meta.discourse.org/t/-/49045/55?u=blake

 Including this field can prevent needing to make a 2nd API request to
 get the raw field of a post.

 It would be handy down the road if we updated the webhook ui to specify
 fields or arguments that you wanted to be included in the serialized
 data, but most requests I've seen to update the serializers have been
 valid requests that are good to add anyways, so I don't think we have
 reached that point yet.
 2020-06-10 11:56:39 -06:00
Dan Ungureanu
5bfe1ee4f1
FEATURE: Improve UX support for multiple email addresses (#9691) 2020-06-10 19:11:49 +03:00
Dan Ungureanu
3a7ca97c36
FIX: Use include-subcategories filter in report export (#10007) 
Some filters were renamed and the conversion of the filter names and arguments
was removed.
 2020-06-10 18:57:39 +03:00
Joffrey JAFFEUX
8fe074430b
REVERT: partly revert change to ensure context is the same (#10012) 2020-06-10 11:10:39 +02:00
Guo Xiang Tan
31a527a293
FIX: Return 400 when invalid topic_id is provided when creating invite. 2020-06-10 09:29:28 +08:00
Guo Xiang Tan
45fd668dc5
DEV: Render a proper response that can be handled on the client side. 2020-06-10 09:25:58 +08:00
Krzysztof Kotlarek
f993d8a197
FIX: flaky post_alerter_spec.rb because of missing order (#10000) 2020-06-10 08:28:54 +10:00
David Taylor
9e98c02dd7
FIX: Don't call cooked decorators in composer if cooked is unchanged 
If cooked is unchanged, ember will not re-render the preview area, so we should not re-run the post-processing decorators. This can cause issues when decorateCooked functions are not idempotent.
 2020-06-09 23:01:07 +01:00
Vinoth Kannan
f67e7d2fad FIX: add attributes of params to topic findOpts. 
If `params` is ignored then `findTopicList` won't get the `no_subcategories` attribute.

d27b877a40
 2020-06-10 01:33:58 +05:30
Joffrey JAFFEUX
43e17f92e0
DEV: allows to call a widget function without re-rendering the widget (#10004) 2020-06-09 19:58:17 +02:00
Joffrey JAFFEUX
84d767716f
linting (#10008) 2020-06-09 19:54:06 +02:00
David Taylor
ae6c4cd237
FIX: Allow merging users when email domains are restricted 2020-06-09 18:51:59 +01:00
Joffrey JAFFEUX
a3cf1cf6ff
DEV: allows to prepend widgets to post nav controls (#10005) 
Co-authored-by: Régis Hanol <regis@hanol.fr>
 2020-06-09 19:37:06 +02:00
Joffrey JAFFEUX
23ed16339f
DEV: adds mouse{Over,Out} and touch{Start,End} to widgets (#10003) 2020-06-09 19:36:28 +02:00
Joe
415c1bb9e1 FIX: don't show create topic suggestion to users who can't 
Users with TL below the "min trust to create topic" setting used to see a prompt to create new topics in the footer message below the topic list. Those topics would never be submitted because those users don't meet the TL requirements to create a new topic (based on that site setting). This PR removes that prompt for those users.
 2020-06-10 00:02:11 +08:00
Arpit Jalan
3094459cd9
FEATURE: multiple use invite links (#9813) 2020-06-09 20:49:32 +05:30
David Taylor
f1fc6cd40d
DEV: Add user-card-additional-buttons plugin outlet 
The user-card-additional-controls outlet is outside the `<li>` element, which makes styling difficult. Placing an outlet inside the button list means that themes/plugins can easily reuse core styling.
 2020-06-09 14:33:24 +01:00
Guo Xiang Tan
edc940ce3e
DEV: Fix incorrect messagebus redis config for rails_failover. 2020-06-09 17:05:14 +08:00
Sam Saffron
08044b4f94
FIX: emoji autocomplete triggering incorrectly 
Previous to this fix the we were checking for non letters.

This was mismatching what pretty-text/addon/emoji.js was doing.

`ù:su`

and

`1:su`

Would lead to an emoji autocomplete popup in the composer.
 2020-06-09 17:22:51 +10:00
Martin Brennan
3e210b76d9 FIX: Change bookmark name "name" attr to disable autocomplete 2020-06-09 14:47:30 +10:00
Kris
d09bf892c7 UX: Improve layout of topic pin admin modal 2020-06-08 23:58:53 -04:00
Penar Musaraj
c5b1f028ed
FIX: update minimum required tag when switching categories in composer 2020-06-08 17:10:26 -04:00
Kris
fbeaba4acf FIX: don't override category text color in dropdown 2020-06-08 16:45:30 -04:00
Penar Musaraj
bdba17cdf7
FIX: Restore stream position in safari (#9993) 
Safari uses an aggressive back/forward cache, which means the app loads
very quickly when hitting Back. But, in topics with > 30 posts, hitting
Back runs post stream calculations too early, which means that users
get taken back to an earlier point in the stream, consistently.

Using `onpageshow`, we can restore the correct location before the post
stream calculations take place.
 2020-06-08 10:13:46 -04:00
Bianca Nenciu
052c91770f
FIX: Reply notifications should not appear as edited (#9965) 2020-06-08 15:23:33 +02:00
Joffrey JAFFEUX
cb13152a43
FIX: ensures edit-category-setting is correctly casting boolean (#9999) 2020-06-08 15:16:42 +02:00
David Taylor
833b5d89e0
PERF: Cache PrettyText instance for rendering composer preview (#9987) 
Previously we were building pretty-text from scratch on every keypress
 2020-06-08 10:42:59 +01:00
Gerhard Schlager
0bf753a739 DEV: Remove unused routes 2020-06-08 10:26:29 +02:00
Gerhard Schlager
8c6a42c589 FIX: Redirects containing Unicode usernames didn't work 2020-06-08 10:26:29 +02:00
David Taylor
293467a37a
REFACTOR: Remove jquery usage from resolveAllShortUrls, and fix debounce 
- This function now requires an explicit scope. It will never run on the entire document.

- Previously debounce was being used with an anonymous function, which means it was having no effect.
 2020-06-05 17:15:14 +01:00
David Taylor
0f09fd22f3
DEV: Remove attachment css handling from resolveAllShortUrls 
This was moved inside the markdown processor in 65481858, so there is no longer any need to run this logic after cooking
 2020-06-05 15:12:30 +01:00
Robin Ward
a9def011d0 FIX: (getURL "") was not working with the i18n helper 2020-06-05 09:53:43 -04:00
David Taylor
be5974734d
PERF: Pass element to resolveAllShortUrl function, not text selector (#9988) 
We already have a reference to the preview element, so there is no need to look it up again. This saves about 1ms per keypress in my testing.
 2020-06-05 13:37:07 +01:00
David Taylor
731263b81c
PERF: Correctly memoize baseUri value in javascript app (#9986) 
An empty string is a falsey value in javascript, so we were looking for the meta tag every time getURL was called, which took approximately 1.5ms every time.
 2020-06-05 13:36:48 +01:00
Vinoth Kannan
0f20a6f0aa FIX: use short_path of flair upload to get signed url for secure media. 
If we use `upload.url` for secure urls then the images won't render.
 2020-06-05 07:43:15 +05:30
Penar Musaraj
2de2537595
UX: add bottom padding to user lists on mobile 
In some cases, when lists had a handful of items, the last item would be covered by the footer-nav eoverlay on PWAs and DiscourseHub.
 2020-06-04 21:42:01 -04:00
Penar Musaraj
f6c3962e3c
UX: Change collapsed draft z-index on mobile 2020-06-04 21:24:14 -04:00
Kris
5cea4a6cc2 icon color fix, follow-up to 5cc0369 2020-06-04 17:29:28 -04:00
Kris
5cc0369898 Minor dropdown icon width fix 2020-06-04 17:26:57 -04:00
Rafael dos Santos Silva
f00e5515e4
FIX: Service Worker URL was broken 
Behavior was changed in #9966, which made the URL be relative.

If the user landed in a topic, for example, the browser was given a
service worker URL under that specific topic URL, which was a 404.

Fixes broken PWA install and broken push notifications
 2020-06-04 14:49:39 -03:00
Joffrey JAFFEUX
a23d31e4d6
DEV: removes unecessary casting (#9982) 2020-06-04 19:07:34 +02:00
Jeff Wong
de29b4a511
PERF: rate limit search, and add anon cache for search results (#9969) 
Adds new hidden site settings for rate limits:
30 for logged in users, 15 for anon

Adds an anon cache for searching, caches results of searches for 1 minute
 2020-06-04 09:26:08 -07:00
Penar Musaraj
2d880b42a3
UX: Add simple-list setting type (#9970) 2020-06-04 10:44:54 -04:00
Arpit Jalan
40dfac176f FIX: client side /my/ redirects were appending extra slash 2020-06-04 17:32:34 +05:30
Guo Xiang Tan
2188ccccd5 DEV: Remove initiating_user keyword arg from EmailUpdater. 
The guardian contains the acting user.
 2020-06-04 13:21:56 +08:00