Joffrey JAFFEUX
ad8c5e7f80
FIX: use CheckboxGroup for admin badges form ( #28239 )
...
A recent change in FormKit has changed the syntax of this specific component. It's also better to use `<CheckboxGroup />` for this use case too.
Im mixed on writing tests for labels, it's a lot of tests to write for a rather low value.
This commit also slightly tweaks the width of the icon picker, from medium to small.
2024-08-06 10:45:09 +02:00
Robert
e145735c1d
DEV: poll flakey spec
2024-08-06 08:39:03 +02:00
Krzysztof Kotlarek
2b6c754779
Revert "FIX: Cache all flags multisite-safe ( #28204 )" ( #28236 )
...
This reverts commit 2225c03455
2024-08-06 10:59:10 +10:00
Krzysztof Kotlarek
fc2259d1c8
FIX: limit the number of custom flags to 50 ( #28221 )
...
Admin can create up to 50 custom flags. It is limited for performance reasons.
When the limit is reached "Add button" is disabled and backend is protected by guardian.
2024-08-06 10:50:12 +10:00
Jay Pfaffman
2e8273dcb4
FIX: backup_restore.rb wants db user from user, not username ( #28229 )
...
ActiveRecord::Base.connection_pool.db_config.configuration_hash has the username in `user`, not `username`.
2024-08-06 08:49:20 +08:00
dependabot[bot]
0514044cf2
Build(deps-dev): Bump @floating-ui/dom from 1.6.8 to 1.6.9 ( #28235 )
...
Bumps [@floating-ui/dom](https://github.com/floating-ui/floating-ui/tree/HEAD/packages/dom ) from 1.6.8 to 1.6.9.
- [Release notes](https://github.com/floating-ui/floating-ui/releases )
- [Changelog](https://github.com/floating-ui/floating-ui/blob/master/packages/dom/CHANGELOG.md )
- [Commits](https://github.com/floating-ui/floating-ui/commits/@floating-ui/dom@1.6.9/packages/dom )
---
updated-dependencies:
- dependency-name: "@floating-ui/dom"
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-08-06 08:48:17 +08:00
dependabot[bot]
05b6ae38cb
Build(deps-dev): Bump rubocop-rspec from 3.0.3 to 3.0.4 ( #28233 )
...
Bumps [rubocop-rspec](https://github.com/rubocop/rubocop-rspec ) from 3.0.3 to 3.0.4.
- [Release notes](https://github.com/rubocop/rubocop-rspec/releases )
- [Changelog](https://github.com/rubocop/rubocop-rspec/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop/rubocop-rspec/compare/v3.0.3...v3.0.4 )
---
updated-dependencies:
- dependency-name: rubocop-rspec
dependency-type: indirect
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-08-06 08:48:00 +08:00
dependabot[bot]
a42f039e89
Build(deps-dev): Bump rubocop-ast from 1.31.3 to 1.32.0 ( #28232 )
...
Bumps [rubocop-ast](https://github.com/rubocop/rubocop-ast ) from 1.31.3 to 1.32.0.
- [Release notes](https://github.com/rubocop/rubocop-ast/releases )
- [Changelog](https://github.com/rubocop/rubocop-ast/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop/rubocop-ast/compare/v1.31.3...v1.32.0 )
---
updated-dependencies:
- dependency-name: rubocop-ast
dependency-type: indirect
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-08-06 08:47:51 +08:00
Martin Brennan
2225c03455
FIX: Cache all flags multisite-safe ( #28204 )
...
This fixes an N1 in topics when loading all flags
and also makes the cache multisite-safe, followup
to fb7cc2d375
2024-08-06 09:59:49 +10:00
dependabot[bot]
3b39c798bf
Build(deps): Bump bootsnap from 1.18.3 to 1.18.4 ( #28234 )
...
Bumps [bootsnap](https://github.com/Shopify/bootsnap ) from 1.18.3 to 1.18.4.
- [Changelog](https://github.com/Shopify/bootsnap/blob/main/CHANGELOG.md )
- [Commits](https://github.com/Shopify/bootsnap/compare/v1.18.3...v1.18.4 )
---
updated-dependencies:
- dependency-name: bootsnap
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-08-06 07:32:23 +08:00
Alan Guo Xiang Tan
2492fe7715
FIX: Set sane default for Net::HTTP when processing a request ( #28141 )
...
This commit patches `Net::HTTP` to reduce the default timeouts of 60
seconds when we are processing a request. There are certain routes in
Discourse which makes external requests and if the proper timeouts are
not set, we risk having the Unicorn master process force restarting the
Unicorn workers once the `30` seconds timeout is reached. This can
potentially become a vector for DoS attacks and this commit is aimed at
reducing the risk here.
2024-08-06 07:12:42 +08:00
Joffrey JAFFEUX
a333d71d4c
FIX: ensures tags/categories are present ( #28230 )
...
Prior to this fix the query in stalled_topic_finder would assume that tags/categories would be nil or an array of ids. However it can be an empty array, in this case the query will not return results.
2024-08-05 22:26:12 +02:00
Renato Atilio
48ac62dfef
UX: respect current locale on topic map views date format ( #28199 )
...
* UX: respect current locale on topic map views date format
* DEV: linting
2024-08-05 13:18:48 -03:00
marstall
e7f976a106
DEV: add description parameter to discourse-tag component ( #28213 )
...
* DEV: add description parameter to discourse-tag component
* prettier
2024-08-05 12:04:54 -04:00
dependabot[bot]
f9b44361b2
Build(deps-dev): Bump @swc/core from 1.7.4 to 1.7.6 ( #28216 )
...
Bumps [@swc/core](https://github.com/swc-project/swc ) from 1.7.4 to 1.7.6.
- [Release notes](https://github.com/swc-project/swc/releases )
- [Changelog](https://github.com/swc-project/swc/blob/main/CHANGELOG.md )
- [Commits](https://github.com/swc-project/swc/compare/v1.7.4...v1.7.6 )
---
updated-dependencies:
- dependency-name: "@swc/core"
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-08-05 13:57:26 +02:00
David Taylor
595c43c5e5
DEV: Enable glimmer header by default ( #28222 )
...
https://meta.discourse.org/t/316549
2024-08-05 12:08:52 +01:00
dependabot[bot]
a966934038
Build(deps): Bump rss from 0.3.0 to 0.3.1 ( #28218 )
...
Bumps [rss](https://github.com/ruby/rss ) from 0.3.0 to 0.3.1.
- [Release notes](https://github.com/ruby/rss/releases )
- [Changelog](https://github.com/ruby/rss/blob/master/NEWS.md )
- [Commits](https://github.com/ruby/rss/compare/0.3.0...0.3.1 )
---
updated-dependencies:
- dependency-name: rss
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-08-05 13:08:12 +02:00
dependabot[bot]
5749ee3c3d
Build(deps-dev): Bump rubocop from 1.65.0 to 1.65.1 ( #28201 )
...
Bumps [rubocop](https://github.com/rubocop/rubocop ) from 1.65.0 to 1.65.1.
- [Release notes](https://github.com/rubocop/rubocop/releases )
- [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop/rubocop/compare/v1.65.0...v1.65.1 )
---
updated-dependencies:
- dependency-name: rubocop
dependency-type: indirect
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-08-05 13:07:54 +02:00
dependabot[bot]
7809ef56a7
Build(deps): Bump rexml from 3.3.2 to 3.3.4 ( #28202 )
...
Bumps [rexml](https://github.com/ruby/rexml ) from 3.3.2 to 3.3.4.
- [Release notes](https://github.com/ruby/rexml/releases )
- [Changelog](https://github.com/ruby/rexml/blob/master/NEWS.md )
- [Commits](https://github.com/ruby/rexml/compare/v3.3.2...v3.3.4 )
---
updated-dependencies:
- dependency-name: rexml
dependency-type: indirect
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-08-05 13:07:39 +02:00
dependabot[bot]
98fb177f8e
Build(deps-dev): Bump hashdiff from 1.1.0 to 1.1.1 ( #28219 )
...
Bumps [hashdiff](https://github.com/liufengyun/hashdiff ) from 1.1.0 to 1.1.1.
- [Changelog](https://github.com/liufengyun/hashdiff/blob/master/changelog.md )
- [Commits](https://github.com/liufengyun/hashdiff/compare/v1.1.0...v1.1.1 )
---
updated-dependencies:
- dependency-name: hashdiff
dependency-type: indirect
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-08-05 13:04:33 +02:00
David Taylor
1b28b8e169
DEV: Upgrade babel & remove vendored safari-bugfix transformation ( #28208 )
...
The Safari 15 bugfix has been rolled into @babel/preset-env in the most recent version, so we no longer need to carry our vendored copy.
This commit updates @babel/preset-env, runs npx yarn-deduplicate yarn.lock, and removes the vendored transform.
This commit also refactors our theme transpiler to use @babel/preset-env, with the same list of target browsers as our ember-cli build uses. This means we no longer need to maintain a separate list of babel transforms for themes.
2024-08-05 10:35:26 +01:00
Ted Johansson
6d1c2a3d5a
FIX: Don't clear inline problems when loading admin dashboard ( #28220 )
...
We support a low-level construct called "inline checks", which you can use to register a problem ad-hoc from within application code.
Problems registered by inline checks never show up in the admin dashboard, this is because when loading the dashboard, we run all realtime checks and look for problems. Because of an oversight, we considered inline checks to be "realtime", causing them to be run and clear their problem status.
To fix this, we don't consider inline checks to be realtime, to prevent them from running when loading the admin dashboard.
2024-08-05 11:45:55 +08:00
Krzysztof Kotlarek
300ef67481
UX: move admin flag form to form-kit ( #28187 )
...
Rewrite the admin flag form to use FormKit. This is a draft because waiting for Checkbox improvements.
2024-08-05 11:01:25 +10:00
Gabriel Grubba
2b577950af
FIX: make the check better for drawer router ( #28212 )
...
* FIX: make the check better for drawer rerouter
* adds a redirect method to chat-drawer-routes
---------
Co-authored-by: Joffrey JAFFEUX <j.jaffeux@gmail.com>
2024-08-02 17:53:43 -03:00
Sérgio Saquetim
4167862a05
DEV: Catch transformer errors and improve warnings ( #28205 )
2024-08-02 15:58:13 -03:00
David Taylor
1b2e0e86f8
FIX: Further improvements to // handling ( #28211 )
...
Followup to f70a65ea02
2024-08-02 18:11:11 +01:00
Keegan George
18ac600352
DEV: Add stacked line chart mode ( #28203 )
2024-08-02 09:40:27 -07:00
David Taylor
f70a65ea02
FIX: Do not strip // from the middle of URLs in discourse-url ( #28210 )
...
Protocol/domain should only be stripped when they occur at the beginning of a URL
2024-08-02 16:23:54 +01:00
Natalie Tay
624dc87321
DEV: Avoid initializing max_image_size_kb in initializer ( #28209 )
...
Since this might initialize to the default db's values
rather than that of the site.
2024-08-02 23:15:14 +08:00
David Battersby
6ec8728ebf
DEV: refactor live notifications setting in user preferences ( #28145 )
...
This change is mainly a refactor of the desktop notifications service to improve readability and have standardised values for tracking state for current user in regards to the Notification API and Push API.
Also improves readability when handling push notification jobs, especially in scenarios where the push_notification_time_window_mins site setting is set to 0, which will allow sending push notifications instantly.
2024-08-02 17:25:15 +04:00
Gabriel Grubba
ec46487870
FEATURE: Added trigger for topic tags changed ( #28176 )
...
* FEATURE: Added trigger for topic tags changed
* DEV: register new file in plugin.rb
* DEV: update to use already existing `:topic_tags_changed` event
* DEV: Add tests to topic_tags_changed trigger
remove `watching_user` field
* DEV: add more tests to topic_tags_changed_spec.rb
* DEV: update tests and implementation for topic tags changed automation trigger
* DEV: update checking for tags changed automation
* DEV: Update argument application for `handle_topic_tags_changed`
2024-08-02 09:58:51 -03:00
David Taylor
7977ae61f7
FIX: Update do-not-disturb icon in real-time on glimmer header ( #28200 )
...
To achieve this, a new notifications service is set up with an `isInDoNotDisturb` tracked property. While a user is in do-not-disturb mode, it runs a regular timer until do-not-disturb is over.
2024-08-02 08:55:51 +01:00
Robert
183ef2024c
FIX: poll ranked choice result algo majority check ( #28191 )
2024-08-02 08:51:26 +02:00
Robert
26c4d1398a
FIX: update voter information upon remote change ( #28168 )
...
Fixes issue with polls not being fully updated by remote vote contributions in (semi-) real-time.
This was down to too great a focus on tracking local state and not accommodating a more data down approach with responsive getters.
This is now implemented.
I've tried hard to minimise the changes whilst making sure the paradigm is properly followed through.
2024-08-02 08:50:33 +02:00
David Taylor
11369018b6
DEV: Stop storing theme-transpiler on filesystem in development ( #28198 )
...
We were writing theme-transpiler JS files to the filesystem on a per-process basis, and then immediately reading them back in. Plus, there was no cleanup mechanism, so the tmp directory would grow indefinitely.
This commit refactors things so that the `build.js` script outputs the theme-transpiler source to stdout. That way, we can read it directly into the process, and then into mini-racer, without needing to go via the filesystem. No cleanup required!
In production, the theme-transpiler is still cached in a file during `assets:precompile`
2024-08-01 17:59:34 +01:00
David Taylor
87450f677b
DEV: Resolve observes deprecation in full-page-search ( #28196 )
2024-08-01 15:47:33 +01:00
Joffrey JAFFEUX
8b61aafe74
FIX: correct return isForever value ( #28194 )
...
Following a refactor we forgot to return the value.
2024-08-01 16:06:26 +02:00
Joffrey JAFFEUX
a6eba4b203
DEV: prevents chrome to ask for fav search engine ( #28192 )
2024-08-01 15:49:07 +02:00
Joffrey JAFFEUX
4998c7be50
DEV: typo in variable name ( #28193 )
...
Note this had no behavior impact, as the computed property was correct.
2024-08-01 15:47:02 +02:00
Martin Brennan
77081de027
FIX: Badge image uploader ( #28188 )
...
In the formkit conversion in 2ca06ba236
2024-08-01 15:36:17 +02:00
Blake Erickson
6ee6b1f1d1
DEV: Add validation for allowed iframes setting ( #28178 )
...
- Adds a validator for the allowed iframes site setting
- Adds a migration to update any values that don't pass the validator
Follow up to: 188cb58daa
2024-08-01 06:51:02 -06:00
David Taylor
492a45da37
DEV: Introduce home-logo-image-url value transformer ( #28189 )
...
Co-authored-by: Joffrey JAFFEUX <j.jaffeux@gmail.com>
2024-08-01 13:43:18 +01:00
Joffrey JAFFEUX
5357f0175e
DEV: moves version to the top ( #28190 )
...
The version is a very important info of the file and it's currently lost in the middle of the file. I think it makes sense to have it at the top.
2024-08-01 14:29:45 +02:00
dependabot[bot]
4c13ad5f60
Build(deps-dev): Bump @swc/core from 1.7.3 to 1.7.4 ( #28182 )
...
Bumps [@swc/core](https://github.com/swc-project/swc ) from 1.7.3 to 1.7.4.
- [Release notes](https://github.com/swc-project/swc/releases )
- [Changelog](https://github.com/swc-project/swc/blob/main/CHANGELOG.md )
- [Commits](https://github.com/swc-project/swc/compare/v1.7.3...v1.7.4 )
---
updated-dependencies:
- dependency-name: "@swc/core"
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-08-01 12:06:12 +01:00
dependabot[bot]
8638bb4787
Build(deps): Bump faraday from 2.10.0 to 2.10.1 ( #28184 )
...
Bumps [faraday](https://github.com/lostisland/faraday ) from 2.10.0 to 2.10.1.
- [Release notes](https://github.com/lostisland/faraday/releases )
- [Changelog](https://github.com/lostisland/faraday/blob/main/CHANGELOG.md )
- [Commits](https://github.com/lostisland/faraday/compare/v2.10.0...v2.10.1 )
---
updated-dependencies:
- dependency-name: faraday
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-08-01 12:05:29 +01:00
dependabot[bot]
420e7a848d
Build(deps): Bump google-protobuf from 4.27.2 to 4.27.3 ( #28185 )
...
Bumps [google-protobuf](https://github.com/protocolbuffers/protobuf ) from 4.27.2 to 4.27.3.
- [Release notes](https://github.com/protocolbuffers/protobuf/releases )
- [Changelog](https://github.com/protocolbuffers/protobuf/blob/main/protobuf_release.bzl )
- [Commits](https://github.com/protocolbuffers/protobuf/commits )
---
updated-dependencies:
- dependency-name: google-protobuf
dependency-type: indirect
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-08-01 12:05:11 +01:00
dependabot[bot]
ba0a01551d
Build(deps): Bump sprockets-rails from 3.5.1 to 3.5.2 in the rails group ( #28183 )
...
Bumps the rails group with 1 update: [sprockets-rails](https://github.com/rails/sprockets-rails ).
Updates `sprockets-rails` from 3.5.1 to 3.5.2
- [Release notes](https://github.com/rails/sprockets-rails/releases )
- [Commits](https://github.com/rails/sprockets-rails/compare/v3.5.1...v3.5.2 )
---
updated-dependencies:
- dependency-name: sprockets-rails
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: rails
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-08-01 12:04:51 +01:00
dependabot[bot]
1f88019421
Build(deps-dev): Bump puppeteer-core from 22.14.0 to 22.15.0 ( #28181 )
...
Bumps [puppeteer-core](https://github.com/puppeteer/puppeteer ) from 22.14.0 to 22.15.0.
- [Release notes](https://github.com/puppeteer/puppeteer/releases )
- [Changelog](https://github.com/puppeteer/puppeteer/blob/main/release-please-config.json )
- [Commits](https://github.com/puppeteer/puppeteer/compare/puppeteer-core-v22.14.0...puppeteer-core-v22.15.0 )
---
updated-dependencies:
- dependency-name: puppeteer-core
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-08-01 12:03:38 +01:00
David Taylor
fc02b4904d
DEV: Convert core controllers to native class syntax (batch 2) ( #28179 )
...
Changes made using the ember-native-class-codemod, plus some manual tweaks
2024-08-01 12:03:17 +01:00
David Taylor
608e5682e2
DEV: Drop unused legacy modal controller/mixin ( #28175 )
2024-08-01 10:18:50 +01:00
