Commit Graph

19085 Commits

Author SHA1 Message Date
Guo Xiang Tan
dae0bb4c67 FIX: Post blurb incorrect when search contains a phrase match.
If the blurb generated is not around the search term, we will not be
able to highlight it on the client side.
2019-03-26 17:01:52 +08:00
Guo Xiang Tan
161a3c3870 DEV: Don't optimize image when migrating to new scheme.
The image has already been uploaded, the migrate to new scheme job's is
just to correct the scheme and not the content of the upload.
2019-03-26 15:12:10 +08:00
Sam Saffron
5a8451bf89 PERF: no need to select entire group just to find name
Note, this is a very good candidate for some cache longer term to cut
the query out
2019-03-26 17:59:05 +11:00
Sam Saffron
3cfedc6c71 PERF: no need to select the full theme just to get color scheme 2019-03-26 17:53:18 +11:00
Guo Xiang Tan
b58c965aad FIX: Destroy optimized image if attempting to migrate to new scheme fails. 2019-03-26 14:37:34 +08:00
Guo Xiang Tan
0ac6a58b09 FIX: Skip validation when saving in Upload#migrate_to_new_scheme. 2019-03-26 14:28:39 +08:00
Kris
b1d707b3bb FIX: More explicit grid layout 2019-03-25 16:41:38 -04:00
Kris
fc81358714 prettier 2019-03-25 14:48:14 -04:00
Penar Musaraj
47a0e4b906 UX: improve mobile search
Improves usability of header search icon while user is already in full page search in mobile.

Currently, hitting search icon a second time empties input and does not scroll up to show search form.

This commit scrolls up to show form and sets focus on input.
2019-03-25 14:42:54 -04:00
Kris
df279251b7 REFACTOR: More consistent user/group page layouts 2019-03-25 14:40:22 -04:00
Gerhard Schlager
60e6070c27 UX: Show spinner during text replacement 2019-03-25 16:47:55 +01:00
Penar Musaraj
8d098df289 UX: Inherit badge icon color
Fixes issue with icon color differing from text color in select-kit box category style
2019-03-25 09:29:38 -04:00
Joe
ec2123809f FEATURE: user and group cards on mobile (#7246) 2019-03-25 13:37:17 +01:00
Bianca Nenciu
f072da1bfe
FEATURE: Add every month / 6 months options to email digest. (#7247) 2019-03-25 12:45:01 +02:00
Tim Lange
dcd56cf593 FIX: Fixed changing composer mode escaping title (#7191) 2019-03-25 13:14:26 +05:30
Guo Xiang Tan
ac661e856a
FEATURE: Allow categories to be prioritized/deprioritized in search. (#7209) 2019-03-25 10:59:55 +08:00
Guo Xiang Tan
ce75e30bf5 UX: Indent category badges to indicate sub-categories. 2019-03-25 10:36:29 +08:00
Vinoth Kannan
b8bd031648 FIX: Always include custom fields in CategorySerializer
even if it is empty
2019-03-25 07:59:56 +05:30
Sam Saffron
40ac895ef7 SECURITY: properly validate return URL for SSO
Previously carefully crafted URLs could redirect off site
2019-03-25 09:02:42 +11:00
Neil Lalonde
399e937a38 FIX: prevent sending multiple summary emails due to Sidekiq delays 2019-03-22 12:34:34 -04:00
Penar Musaraj
51e08feb7e DEV: Refactor icons used in lightbox HTML
Uses <svg> elements instead of hacky CSS pseudoelements

Adds a migration to mark posts with lightboxes as needing a rebake
2019-03-22 11:52:06 -04:00
Tim Lange
da187f0967 FIX: Clear unsaved groups when switching user (#7236) 2019-03-22 12:46:36 +01:00
David Taylor
a9d5ffbe3d FIX: Prevent critical emails bypassing disable, and improve email test logic
- The test_email job is removed, because it was always being run synchronously (not in sidekiq)
- 34b29f62 added a bypass for critical emails, to match the spec. This removes the bypass, and removes the spec.
- This adapts the specs for 72ffabf6, so that they check for emails being sent
- This reimplements c2797921, allowing test emails to be sent even when emails are disabled
2019-03-22 17:28:43 +08:00
tshenry
48d0465f72 FEATURE: Improve avatar education link (#7240)
* Make profile_path more direct to setting

* Add id to profile picture setting for easy linking
2019-03-22 02:20:48 -07:00
Guo Xiang Tan
839a54b97b FIX: Destroy OptimizedImage record even if Upload record is invalid. 2019-03-22 16:47:06 +08:00
Sam Saffron
68fe6b8d53 FIX: suppress autocomplete on group filter 2019-03-22 17:02:04 +11:00
Guo Xiang Tan
7aab7e9062 Revert "UX: Don't reload page after saving settings when editing category."
This reverts commit dd142eec03.

We need a fully reload when reordering.
2019-03-22 13:10:30 +08:00
Osama Sayegh
67b96ad2ff FIX: discourse client should know about Logster (simpler approach) (#7237)
* Revert "FIX: discourse client should know about Logster (#7232)"

This reverts commit bfcbc4d2d6.

* FIX: discourse client should know about Logster (simpler approach)
2019-03-22 08:48:57 +11:00
David Taylor
3f9e7eb326 FIX: Respect the disable_emails=non-staff site setting correctly
This reverts commit c279792130.

This commit inadvertently removed all of the non-staff email logic, rather than just for the 'test email' button. 

https://meta.discourse.org/t/112231/5
2019-03-21 21:44:14 +00:00
Régis Hanol
e1e46f0dff FIX: topic with no tags 2019-03-21 19:40:10 +01:00
Neil Lalonde
1812a38f0a FIX: upload watched words should use UTF-8 2019-03-21 13:46:16 -04:00
Maja Komel
1f1d3909e5 UX: add more tag classes to topic view (#7228)
adds tag classes where there is already category-* class
2019-03-21 17:49:50 +01:00
Kris
252e17ea1b UX: add padding to hidden content link 2019-03-21 11:50:41 -04:00
Vinoth Kannan
1e3cb7575d DEV: Update webhook event attributes even when an error raised 2019-03-21 20:45:21 +05:30
Maja Komel
34730a0b16 UX: show if webhook is disabled (#7217)
+ show in staff logs when webhook is created/updated/destroyed
2019-03-21 16:13:09 +01:00
Osama Sayegh
bfcbc4d2d6
FIX: discourse client should know about Logster (#7232) 2019-03-21 16:54:55 +03:00
Tarek Khalil
605530a77f FEATURE: Include muted users count within the ignored users report (#7230) 2019-03-21 14:31:45 +01:00
Vinoth Kannan
4c6bfb9b39 DEV: Don't destroy webhook in case of error 2019-03-21 18:34:54 +05:30
Tarek Khalil
a31a35b334 FEATURE: Ignored user notification behaviour should be as a muted user (#7227) 2019-03-21 12:15:34 +01:00
Guo Xiang Tan
100ad15e18 Make prettier happy. 2019-03-21 17:25:05 +08:00
Tim Lange
d16a0db4e1 UX: Enabled sorting for more columns in admin user list (#7208) 2019-03-21 17:16:58 +08:00
Bianca Nenciu
fdd2e7f2e7 FIX: Do not update last seen notification ID when forced to enable 2FA." (#7222) 2019-03-21 09:27:22 +01:00
Tim Lange
f7b156ffbd UX: Better emoji escaping for topic title (#7218)
* FIX: Fixed failing discourse-prometheus-alert-receiver plugin specs
2019-03-21 09:11:33 +01:00
Gerhard Schlager
41c7423985 UX: Use a less technical term ("replace") for reseeding (#7223) 2019-03-21 16:22:07 +11:00
Kris
896204bef7 FIX: Don't override .is-hidden on mobile 2019-03-20 20:40:43 -04:00
Kris
c7c409549b margin fix 2019-03-20 16:04:47 -04:00
Tarek Khalil
1dd0fa0c4e
REFACTOR: Move redundant ignored user check into guardian (#7219)
* REFACTOR: Move redundant ignored user check into guardian
2019-03-20 19:55:46 +00:00
Penar Musaraj
3c7eb74f51 DEV: no delaying topic scroll in tests 2019-03-20 15:24:06 -04:00
Joffrey JAFFEUX
45ef2ec8cd
DEV: do not wait for closed composer event on test (#7221) 2019-03-20 20:13:15 +01:00
Kris
88a3b89990 UX: Improve user profile header layout on mobile 2019-03-20 14:56:34 -04:00