7 Commits

Author	SHA1	Message	Date
Sam Saffron	4ea21fa2d0	DEV: use #frozen_string_literal: true on all spec ... This change both speeds up specs (less strings to allocate) and helps catch cases where methods in Discourse are mutating inputs. Overall we will be migrating everything to use #frozen_string_literal: true it will take a while, but this is the first and safest move in this direction	2019-04-30 10:27:42 +10:00
Guo Xiang Tan	5012d46cbd	Add rubocop to our build. (#5004)	2017-07-28 10:20:09 +09:00
Andy Waite	3e50313fdc	Prepare for separation of RSpec helper files ... Since rspec-rails 3, the default installation creates two helper files: * `spec_helper.rb` * `rails_helper.rb` `spec_helper.rb` is intended as a way of running specs that do not require Rails, whereas `rails_helper.rb` loads Rails (as Discourse's current `spec_helper.rb` does). For more information: https://www.relishapp.com/rspec/rspec-rails/docs/upgrade#default-helper-files In this commit, I've simply replaced all instances of `spec_helper` with `rails_helper`, and renamed the original `spec_helper.rb`. This brings the Discourse project closer to the standard usage of RSpec in a Rails app. At present, every spec relies on loading Rails, but there are likely many that don't need to. In a future pull request, I hope to introduce a separate, minimal `spec_helper.rb` which can be used in tests which don't rely on Rails.	2015-12-01 20:39:42 +00:00
Luciano Sousa	0fd98b56d8	few components with rspec3 syntax	2015-01-09 13:34:37 -03:00
Neil Lalonde	014bfc0512	Use 10k most common passwords instead of 5k	2014-05-02 12:01:21 -04:00
Neil Lalonde	47e1d00f96	Check that common passwords list is greater than 0	2013-12-30 14:26:02 -05:00
Neil Lalonde	ab12695d63	Block passwords that are in the top 5000 most common passwords. Site setting block_common_passwords can disable this feature.	2013-12-27 11:00:21 -05:00