Commit Graph

15412 Commits

Author SHA1 Message Date
Arpit Jalan
c168c5895f
Merge pull request #5407 from techAPJ/show-inactive-accounts
FEATURE: new site setting show_inactive_accounts
2017-12-07 20:52:37 +05:30
Maja Komel
cce077de56 move /tags/ topics list out of footer (#5405) 2017-12-07 15:25:04 +01:00
Arpit Jalan
5003f07b2c FEATURE: new site setting show_inactive_accounts 2017-12-07 19:22:41 +05:30
Joffrey JAFFEUX
f0ef307d2d
FIX: topic timer offset applied two times
timezone offset was calculated and sent from browser to server, it would be applied on utc time generated from '2013-11-22 5:00' format for example and then sent back to browser which would display it thinking it's UTC time using `moment(utc time)` when it's in fact an UTC time we have offseted with the initial user timezone.

This is impossible to automatically test in the current app state. Easiest reproduction is in live browser after setting your timezone to `America/New_York`, when setting a topic timer to later_today, after save, the time under the topic should be off to something roughly equal +1/-1  hour to your timezone offset.
2017-12-07 14:42:58 +01:00
Kyle Zhao
c52f747031 FEATURE: Catalan Translations (#5404) 2017-12-07 10:36:25 +01:00
Guo Xiang Tan
c64774f4f8 Remove debugging code. 2017-12-07 06:48:12 +08:00
Régis Hanol
c08d53f2dd keyValueStore isn't available in test 2017-12-06 23:28:28 +01:00
Kris
4d9f26879b FIX: Composer preview-area plugin layout 2017-12-06 16:12:52 -05:00
Régis Hanol
ae0acfb1df FEATURE: live reply indicators at the bottom of topic 2017-12-06 21:58:59 +01:00
Régis Hanol
ea50f823cb FIX: logging in after an anon ❤️ does not count the ❤️ 2017-12-06 21:58:05 +01:00
Robin Ward
cf3ea4f9bd UX: Use the same 404 page for the unknown route and exception handler 2017-12-06 15:20:24 -05:00
Robin Ward
e8d5d34755 FIX: Don't show trust level if the API didn't return it 2017-12-06 13:13:51 -05:00
ckeboss
7a093ea5d6 Format username for desktop notifications (#5403)
FIX: Desktop notifications weren't formatting the username
2017-12-06 12:52:11 -05:00
Kris
f559275b14 FIX: Adjusted the composer preview to avoid odd scroll issue 2017-12-06 11:31:36 -05:00
Vinoth Kannan
7d88cfde0e Skip paste handling if composer textarea lost focus 2017-12-06 19:36:13 +05:30
Guo Xiang Tan
4531563717 Hide new advanced editor and preview sync behind a hidden site settings. 2017-12-06 12:34:58 +08:00
Kris
da78e75f6f UX: Mobile post control button color was too specific, overriding solved plugin 2017-12-05 21:07:20 -05:00
Joffrey JAFFEUX
75463e5a91
FIX: correctly print html entity when used in a locale for none 2017-12-05 19:09:12 -05:00
Kyle Zhao
5f318a5241 FEATURE: Replace SimpleRSS with Ruby RSS module (#5311)
* SPEC: PollFeedJob parsing atom feed

* add FeedItemAccessor

It is to provide a consistent interface to access a feed item's tag
content.

* add FeedElementInstaller

to install non-standard and non-namespaced feed elements

* FEATURE: replace SimpleRSS with Ruby RSS module

* get FinalDestination and download with Excon

* support namespaced element with FeedElementInstaller
2017-12-06 10:45:09 +11:00
Robin Ward
410994b7f5 FEATURE: Show a button to Staff for "Moderation History" on posts/topics
When clicked, it pops up a modal showing a history of moderation actions
taken on the post or topic.
2017-12-05 15:20:20 -05:00
Vinoth Kannan
94e9be3b88 Make eslint happy 2017-12-06 01:28:22 +05:30
Vinoth Kannan
8cf7152151 FIX: IE compatability issue in clipboard data types array 2017-12-06 01:02:06 +05:30
Vinoth Kannan
6e054b2572 FEATURE: Convert HTML to Markdown while pasting in composer 2017-12-05 12:23:39 -05:00
Arpit Jalan
daeb7694bc update annotations 2017-12-05 21:03:20 +05:30
Vinoth Kannan
37948838be FIX: Global event variable is not compatible with all browsers 2017-12-05 11:27:08 +05:30
Vinoth Kannan
4654f076f5 FIX: Drive spreadsheet table not converting to Markdown table 2017-12-05 11:03:33 +05:30
Kris
a1d880a215 FIX: Broken variable 2017-12-04 20:22:04 -05:00
Kris
4af4081c39
UX: Updating the edit post title layout 2017-12-04 15:29:02 -05:00
Neil Lalonde
b5a967ab43 lint failure 2017-12-04 14:32:01 -05:00
Neil Lalonde
23ea4b6739 FIX: don't create featured link if title includes more than a url 2017-12-04 14:21:08 -05:00
Neil Lalonde
fb08441802 Revert "FIX: don't create featured link if title includes more than a url" 2017-12-04 12:53:12 -05:00
Vinoth Kannan
e14281bdf6
Merge pull request #5393 from vinothkannans/clip-master
FEATURE: Paste plain text table as Markdown table
2017-12-04 22:45:07 +05:30
Neil Lalonde
cde42c3f69 FIX: don't create featured link if title includes more than a url 2017-12-04 12:03:41 -05:00
Kris
b55b7c5356 FIX: Removing horizontal scrollbar in category modal 2017-12-04 12:00:34 -05:00
Kris
8eb7518d2a FIX: Disappearing tag input border on hi-res devices/when scaling 2017-12-04 11:35:02 -05:00
Kris
f1b5227aa6 FIX: Mobile composer layout for PMs 2017-12-04 11:15:10 -05:00
Kris
13840942b9 UX: Fixing code highlighting color issue in dark themes 2017-12-04 10:28:32 -05:00
Vinoth Kannan
ab4c953d82 FEATURE: Paste plain text table as Markdown table 2017-12-04 20:53:42 +05:30
Arpit Jalan
f466791a15 FIX: resolve from URL when using /new-topic route 2017-12-04 17:34:17 +05:30
Arpit Jalan
0e0794dff9 FIX: correct use of invitee vs inviter in email templates 2017-12-04 14:09:48 +05:30
Guo Xiang Tan
e73fbfe265 FIX: Topic#featured_link_root_domain extracts URL before parsing. 2017-12-04 10:00:07 +08:00
Robin Ward
3e83c34785 FIX: Don't include null class when rendering the pinned dropdown 2017-12-03 16:20:35 -05:00
Robin Ward
e80caab247 FIX: Reply to tab was not using the username formatter 2017-12-03 15:49:21 -05:00
Robin Ward
a0da098e6b UX: Add new classes to make user creation more targetable 2017-12-03 15:03:06 -05:00
Kris
c8ad89afd4 UX: Adjustments to composer uploading message 2017-12-01 22:31:40 -05:00
Kris
d615a37eba UX: Hiding composer preview reduces width of composer overlay 2017-12-01 22:23:12 -05:00
Jeff Atwood
bcd57d72a9
Merge pull request #5389 from vinothkannans/clip-master
FIX: Skip pasting files if plain text available in clipboard
2017-12-01 16:41:39 -08:00
Kris
a43c044b1e UX: Removing an old font declaration 2017-12-01 16:17:01 -05:00
Neil Lalonde
b35960fc35 FIX: export admin reports to csv would have 0 rows in the csv file 2017-12-01 15:50:36 -05:00
Vinoth Kannan
e2c60ea4b2 FIX: Skip pasting files if plain text available in clipboard 2017-12-02 02:05:11 +05:30
Joffrey JAFFEUX
dbadebacd1
FIX: allows select-kit to search by null value 2017-12-01 20:02:00 +01:00
Kris
29bdf35977 FIX: Composer not properly centered in IE11 2017-12-01 13:58:04 -05:00
Kris
e7725e23ad FIX: Flexbox composer issue in IE11, bad flex-shrink default 2017-12-01 13:12:25 -05:00
Arpit Jalan
54f5b4d4e0 FEATURE: log clicks on full page search 2017-12-01 23:21:16 +05:30
Kris
af11913314 FIX: Positining of search spinner in tablet-sized viewports 2017-12-01 11:01:03 -05:00
Joffrey JAFFEUX
966dbb9705
FIX: do not give any element focus when creating topic 2017-12-01 13:16:36 +01:00
Guo Xiang Tan
2e860eddc1 Don't sync scroll when input is not scrollable.
https://meta.discourse.org/t/composer-preview-scroll-not-syncing-with-editor/74975/14?u=tgxworld
2017-12-01 17:08:03 +08:00
Jeff Atwood
3e42dceaae "reply to which topic" needs wider buttons 2017-11-30 23:25:32 -08:00
Arpit Jalan
496cd3b4df
Merge pull request #5385 from techAPJ/search-logs-improvements
FEATURE: support search click through tracking for user, category and tags
2017-12-01 12:08:38 +05:30
Arpit Jalan
e3925278e2 FEATURE: support search click through tracking for user, category and tags
https://meta.discourse.org/t/search-logs-page/73281/11?u=techapj

This commit adds following features:

- support for tracking click through to user, tag and category
- new filter for search type (header, full page)

This commit also removes "most viewed topic" field from search logs page because we are now tracking multiple click through entities, so topic is not a special entity anymore. This also improves query perf. The query now takes `20.5ms` to runs, as opposed to `655.9ms` previously.
2017-12-01 12:04:55 +05:30
Vinoth Kannan
7f2eeaf767 FIX: Password required flag should be cleared whenever clearing the raw password (#5384) 2017-12-01 15:19:24 +11:00
Kris
9876f3d0ee FIX: extraneous mobile CSS, flagged badge color in dropdown 2017-11-30 17:29:29 -05:00
Neil Lalonde
3dd67e9c04 replace 'email' with envelope icon on user card for staged users 2017-11-30 16:55:27 -05:00
Neil Lalonde
bca90381cf FIX: save drafts of new topics with titles but no body 2017-11-30 15:16:12 -05:00
Robin Ward
dfd309c64f FIX: The user summary wasn't using the username formatter 2017-11-30 12:17:03 -05:00
Kris
3f8d0c5c94 FIX: Increasing overridden label contrast in settings 2017-11-30 10:13:09 -05:00
Vinoth Kannan
704dbd7cfc FIX: Unable to remove existing user title (#5386) 2017-11-30 15:54:38 +01:00
Vinoth Kannan
1ee48966ca REVERT: FIX: Password required flag should be cleared whenever clearing the raw password 2017-11-30 16:17:14 +05:30
Vinoth Kannan
1776649b4d FIX: Password required flag should be cleared whenever clearing the raw password 2017-11-30 13:40:18 +05:30
Guo Xiang Tan
c128e421c4 FIX: Don't run job if topic timer has already been deleted. 2017-11-30 15:26:26 +08:00
Guo Xiang Tan
853b51b519 Add uniqueness validation for SingleSignOnRecord#external_id. 2017-11-30 15:15:52 +08:00
Guo Xiang Tan
f7f743970b Just use space to prettify SSO verbose error logging. 2017-11-30 15:10:00 +08:00
Guo Xiang Tan
1c2d1682ae
Merge pull request #5328 from tgxworld/reenable_interpolation_keys_check
FIX: Re-enable invalid interpolation keys check and allow default key…
2017-11-30 13:04:54 +08:00
Sam
05f5df69b1 UX: Add tooltips for messages and notifications in header 2017-11-30 12:56:54 +11:00
Sam
772301bc65 woops 2017-11-30 12:32:50 +11:00
Sam
bf1f6c7fe4 UX: better help text for composer collapse / discard
also: warn on collapsed close if you are to discard content
2017-11-30 12:28:00 +11:00
Régis Hanol
0d34caff85 UX: show error message when no gravatar is associated 2017-11-29 18:09:44 +01:00
Régis Hanol
1218ead355 UX: preloaded gravatar was appearing on the right instead of the left 2017-11-29 18:07:09 +01:00
Guo Xiang Tan
9fbe1436b6 UX: Replace heuristic solution root domain extraction for topic featured link. 2017-11-29 21:52:41 +08:00
Guo Xiang Tan
8491c5fba5 UX: Replace heuristic solution for extracting root domain. 2017-11-29 16:26:46 +08:00
Guo Xiang Tan
3e9c3f6f13 Fix JS test.
* `new Array` doesn't seem to be available in phantomJS yet.
2017-11-29 16:03:00 +08:00
Guo Xiang Tan
5b965ab5d0 Sync editor and preview when preview is updated. 2017-11-29 11:19:04 +08:00
Kris
03eb278034
FIX: Increased composer width to match preview, border width fix (#5379) 2017-11-28 21:57:27 -05:00
Guo Xiang Tan
ebc31975e8 Ember.run.schedule -> Ember.run.scheduleOnce. 2017-11-29 10:43:59 +08:00
Guo Xiang Tan
de17a8e856 UX: Sync input and preview when user is typing. 2017-11-29 09:56:15 +08:00
Guo Xiang Tan
4816619ba3 FIX: Editor and preview does not sync when scrolled to the bottom. 2017-11-29 08:38:57 +08:00
Guo Xiang Tan
bb0b7b61d7 FIX: Don't fail silently when updating a record. 2017-11-29 08:01:13 +08:00
Gerhard Schlager
44ee388070 FEATURE: omit images from og and twitter description tags 2017-11-28 21:34:02 +01:00
Robin Ward
04e8b7dffb UX: Remove another plugin outlet container we don't need 2017-11-28 14:46:17 -05:00
Robin Ward
86df5846c8 Don't use a tag for a couple of topic outlets 2017-11-28 14:42:24 -05:00
Robin Ward
823896d698 FIX: Use parseable date format 2017-11-28 14:16:33 -05:00
Kris
fbc4191195 moving inputs outside of label tag 2017-11-28 14:12:01 -05:00
Robin Ward
23ee3047bf FIX: Future date input selector was not respecting timezone 2017-11-28 13:44:24 -05:00
Robin Ward
f4b3306bf4 FIX: Link from flagged topics to user was broken 2017-11-28 13:10:30 -05:00
Gerhard Schlager
41e70c410c
FEATURE: replace GUID in image name uploaded from iOS (#5370) 2017-11-28 11:05:34 +01:00
Arpit Jalan
f37a1d5976 UX: add tooltip to unique on search logs page 2017-11-28 15:29:35 +05:30
Guo Xiang Tan
1d8b834301
Merge pull request #5369 from vinothkannans/queued
FIX: Error if queued post not found while updating
2017-11-28 17:51:05 +08:00
Angus McLeod
8a0d7bb922 Update wizard import to new select-kit style path (#5375) 2017-11-28 10:06:05 +01:00
Guo Xiang Tan
110dfbf42f Uglify doesn't support ES6 yet. 2017-11-28 16:07:27 +08:00
Guo Xiang Tan
7b8699f3be FIX: Can't load service-worker.js in production. 2017-11-28 15:40:57 +08:00
Jeff Wong
b094894c94 Feature: Add service worker registration method to plugin API 2017-11-28 14:01:41 +08:00
Sam
b3b55e18d1 UX: stop warping tiny onebox images 2017-11-28 12:32:35 +11:00
Sam
ceaadf6246 UX: adjustments for topic title editing 2017-11-28 12:00:18 +11:00
Kris
87c83f102d small color fix 2017-11-27 18:30:12 -05:00
Kris
d31c8ffa87
small color adjustment (#5374) 2017-11-27 18:20:07 -05:00
Sam
5a715b7d55 lint it up 2017-11-28 07:39:24 +11:00
Kris
ada1d6b987
Composer restyle
* composer restyle, some input normalization

* style adjustments: spacing, preview background, colors

* small spacing adjustments, removing default iOS input appearance, fixing merge

* small width adjustment

* fixing mobile link modal for small devices

* FIX: more resilient allowInitiatlValueMutation implementation

* Build scrollMap only on scroll.

* FIX: pick date and time was not reseting state

* FIX: removes auto sizing and touchstart support for now

* Revert "FIX: reflects discourse icons naming scheme s/d-icon-*/d-*"

This reverts commit b5ed980235.

* tweak icon-library generation

* FIX: regression preventing to set number of hours before closing

This commit also adds a full test suite for editing topic timer.

* FIX: makes allowInitialValueMutation more restrictive

* FIX: invite-list expects initial value mutation

* fixing tag input spacing

* minor input cleanup

* bump onebox version

* FIX: avoids test failing at some times of the day

* FIX: various issues when editing category permissions

This commit also adds multiple tests
2017-11-27 15:23:18 -05:00
Joffrey JAFFEUX
49b1df40fc
FIX: various issues when editing category permissions
This commit also adds multiple tests
2017-11-27 19:50:04 +01:00
Neil Lalonde
c22f202e10 FIX: missing likes count on top topics in user summary 2017-11-27 13:42:16 -05:00
Robin Ward
36d46df8dc New setting to show the reply title on the post menu on mobile 2017-11-27 13:21:53 -05:00
Arpit Jalan
2c16240b60 fix the build 2017-11-27 23:18:08 +05:30
Arpit Jalan
bf415f2d40 FIX: youtube playlist videos were not functioning properly in fullscreen 2017-11-27 22:56:44 +05:30
Robin Ward
77f90876d3 REFACTOR: Track manual locked user levels separately from groups 2017-11-27 11:23:44 -05:00
Vinoth Kannan
31aa21b5a4 FIX: Error if queued post not found while updating 2017-11-27 19:25:51 +05:30
Sam
608207b2e5 FEATURE: avatar proxy happens in background
This ensures that even if it is slow to download avatars site will
continue to work

Also simplifies hijack pattern
2017-11-27 17:43:24 +11:00
Sam
d5e7691ae9 favicon proxy now uses hijack 2017-11-27 14:51:14 +11:00
Guo Xiang Tan
5805979e88 FIX: Re-enable invalid interpolation keys check and allow default keys to be left out of translation overrides.
https://meta.discourse.org/t/bulk-invite-from-file-resets-the-invite-forum-mailer-customized-text/67606/16
2017-11-27 11:00:08 +08:00
Sam
eb428ef54d FEATURE: uploads are processed a faster
Also cleans up API to always return 422 on upload error. (previously returned 200)

Uploads are processed using new hijack pattern
2017-11-27 12:43:35 +11:00
Sam
a74ac90bf5 FIX: quote dropped when replying as new topic 2017-11-27 10:08:55 +11:00
Angus McLeod
4b919cd735 Move queuedForTyping assignment (#5366) 2017-11-27 09:43:41 +11:00
Joffrey JAFFEUX
329343be06
FIX: various sizing issues on select-kit 2017-11-26 17:21:39 +01:00
Arpit Jalan
abbb2b28eb bump onebox version 2017-11-25 15:53:18 +05:30
Neil Lalonde
39d7745dc5 UX: show staged users' email addresses to staff without requiring a button press 2017-11-24 16:11:34 -05:00
Neil Lalonde
510a2a1e0f remove ancient unused css 2017-11-24 15:42:50 -05:00
Neil Lalonde
6f8f2c494d FIX: admin strings in plugins should fallback to english when untranslated 2017-11-24 14:11:01 -05:00
Kris
c2da25dd5c
Cleaning up the 404 page (#5363) 2017-11-24 12:41:31 -05:00
Guo Xiang Tan
f3f051a344 UX: Composer textarea should always start at the top. 2017-11-24 23:24:37 +08:00
Joffrey JAFFEUX
f2c7f39066
FIX: invite-list expects initial value mutation 2017-11-24 13:32:24 +01:00
Joffrey JAFFEUX
96cdc4e66e
FIX: makes allowInitialValueMutation more restrictive 2017-11-24 13:15:02 +01:00
Gerhard Schlager
b3094e9954 FIX: incoming and outgoing emails got lost when post was moved 2017-11-24 11:45:36 +01:00
Guo Xiang Tan
44333c5de3 REFACTORY: Dry up some composer syncing code. 2017-11-24 14:57:36 +08:00
Sam
e0e99d4bbd PERF: hijack onebox requests so they do not use up a unicorn worker 2017-11-24 15:31:40 +11:00
Joffrey JAFFEUX
63307c303a
FIX: regression preventing to set number of hours before closing
This commit also adds a full test suite for editing topic timer.
2017-11-24 02:48:45 +01:00
Neil Lalonde
3f58b18dab FEATURE: user card shows staff if a user is staged and lets them check the email address 2017-11-23 16:38:11 -05:00
Arpit Jalan
406ad1a1f2
Merge pull request #5357 from techAPJ/invite-trust-level
FIX: invited users were not granted trust level based on their group
2017-11-23 23:42:20 +05:30
Robin Ward
ad07e6e172 FEATURE: group_removes_trust_level setting
By default in Discourse, if a group grants a user a particular trust
level that is locked even if they are removed from the group.

With this new setting, when a user is removed from a group their
trust level is set to either the next highest trust level based on group
membership, or they are unlocked and promoted based on the default
mechanisms.
2017-11-23 13:03:24 -05:00
Joffrey JAFFEUX
9208909b26 tweak icon-library generation 2017-11-23 18:24:26 +01:00
Joffrey JAFFEUX
dd5562322b Revert "FIX: reflects discourse icons naming scheme s/d-icon-*/d-*"
This reverts commit b5ed980235.
2017-11-23 18:24:26 +01:00
Arpit Jalan
3508046e33 FIX: invited users were not granted trust level based on their group
https://meta.discourse.org/t/bulk-invites-and-trust-level/73535

If the user enters password when accepting invite they were not granted
trust level based on their group privileges. It was because `password_required` was set to true when creating user record and when the user was updated again when granting trust level the password validation was raising error saying that the password is empty. This commit fetches fresh user record after the user is created so that the user record can be updated successfully.
2017-11-23 22:19:28 +05:30
Gerhard Schlager
39810e4425 FIX: do not move small post actions 2017-11-23 17:25:53 +01:00
Joffrey JAFFEUX
616a0dae4e
FIX: removes auto sizing and touchstart support for now 2017-11-23 15:34:52 +01:00
Gerhard Schlager
eaa54a5a64 FIX: don't store state of composer's preview in mobile view 2017-11-23 15:22:00 +01:00
Joffrey JAFFEUX
5b3ecffbb2
FIX: pick date and time was not reseting state 2017-11-23 15:18:27 +01:00
Guo Xiang Tan
c5745feac6 Build scrollMap only on scroll. 2017-11-23 21:44:09 +08:00
Joffrey JAFFEUX
fe94e7c453
FIX: more resilient allowInitiatlValueMutation implementation 2017-11-23 14:39:26 +01:00
Guo Xiang Tan
ab839d134b Fix scrollmap included NaN values. 2017-11-23 18:08:43 +08:00
Joffrey JAFFEUX
9f0798682e
FIX: tweak alignment of select-kit in navigation bar 2017-11-23 10:42:39 +01:00
Guo Xiang Tan
486016acea UX: Improve editor and preview scroll syncing. 2017-11-23 17:02:02 +08:00
Sam
49f97d75b7 FIX: make uploads safe for block that can run later 2017-11-23 17:28:18 +11:00
Sam
d43a54e83a FIX: use current_user.id in onebox instead of param 2017-11-23 15:32:19 +11:00