Natalie Tay
18bb6b0871
DEV: Do not attempt to update polls if there are no polls before and after ( #26573 )
2024-04-12 13:16:10 +08:00
David Taylor
055310cea4
DEV: Apply syntax_tree formatting to plugins/*
2023-01-07 11:11:37 +00:00
Phil Pirozhkov
493d437e79
Add RSpec 4 compatibility ( #17652 )
...
* Remove outdated option
04078317bahttps://github.com/rspec/rspec-core/pull/2803
* Use the non-globally exposed RSpec syntax, cont
https://github.com/rspec/rspec-core/pull/2803
* Comply to strict predicate matchers
See:
- https://github.com/rspec/rspec-expectations/pull/1195
- https://github.com/rspec/rspec-expectations/pull/1196
- https://github.com/rspec/rspec-expectations/pull/1277
2022-07-28 10:27:38 +08:00
David Taylor
c9dab6fd08
DEV: Automatically require 'rails_helper' in all specs ( #16077 )
...
It's very easy to forget to add `require 'rails_helper'` at the top of every core/plugin spec file, and omissions can cause some very confusing/sporadic errors.
By setting this flag in `.rspec`, we can remove the need for `require 'rails_helper'` entirely.
2022-03-01 17:50:50 +00:00
Bianca Nenciu
6a143030f8
FEATURE: Allow users to remove their vote ( #14459 )
...
They can use the remove vote button or select the same option again for
single choice polls.
This commit refactor the plugin to properly organize code and make it
easier to follow.
2021-10-05 11:38:49 +03:00
Sam Saffron
3c1fa3910f
DEV: track the correct channel in specs
...
These tests are erratically failing due to distributed cache messages that
can land between tests
Ensure we are only looking for the correct messages
2019-05-20 18:27:09 +10:00
Sam Saffron
30990006a9
DEV: enable frozen string literal on all files
...
This reduces chances of errors where consumers of strings mutate inputs
and reduces memory usage of the app.
Test suite passes now, but there may be some stuff left, so we will run
a few sites on a branch prior to merging
2019-05-13 09:31:32 +08:00
Bianca Nenciu
c928386c3e
FIX: Copy old status to new poll. ( #6788 )
2018-12-19 11:29:13 +01:00
Régis Hanol
4459665dee
REFACTOR: use tables instead of custom fields for polls ( #6359 )
...
Co-authored-by: Guo Xiang Tan <tgx_world@hotmail.com>
2018-11-19 14:50:00 +01:00
Guo Xiang Tan
51657d3426
Allow polls to be added/renamed/removed as long as user can edit posts.
2018-03-14 11:00:57 +08:00
Guo Xiang Tan
b77553a635
FIX: Staff should be able to updates polls when edit window expires.
...
https://meta.discourse.org/t/moderators-cannot-remove-polls-from-posts/81804/7?u=tgxworld
2018-03-08 16:45:06 +08:00
Guo Xiang Tan
e80a1dfa43
FIX: Post with multiple polls containing votes can not be edited.
...
https://meta.discourse.org/t/500-internal-server-error-when-editing-specific-poll-in-a-post-with-votes-editing-other-polls-works-fine/59684
2017-07-14 12:33:22 +09:00
Guo Xiang Tan
8c4dfdfa40
FIX: Votes lost when editing a poll option with votes.
2017-01-16 22:51:57 +08:00
Guo Xiang Tan
8213da20f2
Extract polls edit window to a site settings.
2016-08-10 15:17:16 +08:00
Guo Xiang Tan
ffbfcd7ee2
Fix build.
2016-07-29 14:47:23 +08:00
Guo Xiang Tan
f53494f102
FIX: Polls with votes cannot be made public.
2016-06-09 12:10:27 +08:00
Guo Xiang Tan
8ecde35df3
FEATURE: Add public type to polls.
2016-06-08 16:19:13 +08:00
Guo Xiang Tan
a849fae5ee
Add specs for polls ( #4246 )
...
* Extract validation logic into a service object.
* Extract logic for updating polls custom fields into a service object.
* Use `strip_heredoc` instead.
* FIX: Polls do not update when configuration has been changed.
2016-06-06 17:04:56 +02:00
