Arpit Jalan
1ea0cbece8
FIX: skip adding sso diagnostics if sso object is nil
2018-12-19 20:55:35 +05:30
Joffrey JAFFEUX
e655e1863f
UX: Adding reports dashboard tab, new layout, report descriptions ( #6790 )
...
Co-Authored-By: Kris <shout@k-ris.com>
2018-12-19 14:44:43 +01:00
Arpit Jalan
e5fd018f44
DEV: assign constant to preserve_fragment_url_hosts
2018-12-19 17:37:39 +05:30
Bianca Nenciu
c928386c3e
FIX: Copy old status to new poll. ( #6788 )
2018-12-19 11:29:13 +01:00
Penar Musaraj
f5c4ab0573
Add category link renderer to plugin API ( #6787 )
...
* Add category link renderer to plugin API
- lets themes/plugins override the category link display
- planning to use this in a "category icons" theme component
* small code review fix
* Code review refactor
2018-12-19 10:26:09 +01:00
Bianca Nenciu
7050ce4638
FIX: Bypass draft check when switching to shared draft. ( #6782 )
2018-12-19 10:25:33 +01:00
Maja Komel
0ce5f05b2a
FIX: hide emails on admin user list for moderators ( #6781 )
2018-12-19 10:24:57 +01:00
Maja Komel
2fcbbead45
FIX: move sso provider into its own class so it doesn't interfere with sso client ( #6767 )
2018-12-19 10:22:10 +01:00
Bianca Nenciu
2eefe6d5d6
FIX: Use CDN for logos and icons. ( #6698 )
2018-12-19 10:20:48 +01:00
Arpit Jalan
1ab91f0474
FIX: preserve github fragment URL
2018-12-19 12:34:47 +05:30
Rishabh
cae5ba7356
FIX: Ensure that multisite s3 uploads are tombstoned correctly ( #6769 )
...
* FIX: Ensure that multisite uploads are tombstoned into the correct paths
* Move multisite specs to spec/multisite/s3_store_spec.rb
2018-12-19 13:32:32 +08:00
Kris
41e06efb94
Adding padding to mobile that was removed in 3710b016
2018-12-18 22:20:02 -05:00
Kris
3710b01660
Header was 16px too narrow due to border-box and padding
2018-12-18 20:38:43 -05:00
Kris
5b9c1bcf59
User page button style fix
2018-12-18 20:36:42 -05:00
Neil Lalonde
6774b64aef
FEATURE: add /conduct as an alias for /guidelines
2018-12-18 16:40:24 -05:00
Vinoth Kannan
9c6f77f9da
DEV: Remove the unique_searches column from select query
2018-12-19 02:45:48 +05:30
Robin Ward
6080e3a2c0
FIX: Broken spec
2018-12-18 14:55:09 -05:00
Robin Ward
662cfc416b
FEATURE: Show a blurry preview when lazy loading images
...
This generates a 10x10 PNG thumbnail for each lightboxed image.
If Image Lazy Loading is enabled (IntersectionObserver API) then
we'll load the low res version when offscreen. As the image scrolls
in we'll swap it for the high res version.
We use a WeakMap to track the old image attributes. It's much less
memory than storing them as `data-*` attributes and swapping them
back and forth all the time.
2018-12-19 01:57:30 +08:00
Robin Ward
e593d68beb
Use an options hash instead of boolean parameters
2018-12-19 01:57:30 +08:00
Rishabh
c279792130
FIX: Allow sending test e-mails to any email address when disable_email is set to non-staff ( #6792 )
2018-12-18 16:12:05 +01:00
Gerhard Schlager
32784ad11a
FIX: Disable multipart backup uploads to S3
...
Multipart upload from within the browser result in corrupt files on S3.
2018-12-18 16:01:15 +01:00
Gerhard Schlager
081aa6ad2b
UX: Use new FA5 icons on Backups tab
2018-12-18 16:01:14 +01:00
Gerhard Schlager
86546bb5c6
DEV: Use locale fallback even in development mode
...
Making dev behave differently than prod is a bad idea.
2018-12-18 16:01:14 +01:00
Bianca Nenciu
825ae86857
FEATURE: Remove full quote only if first paragraph. ( #6793 )
2018-12-18 15:46:20 +01:00
Vinoth Kannan
a313b01148
DEV: raise error if search term length is less than required
2018-12-18 20:06:59 +05:30
Vinoth Kannan
341a6bd78a
REFACTOR: Calculate CTR in SearchLog model and hide unique column ( #6791 )
2018-12-18 19:13:46 +05:30
Gerhard Schlager
577af81e76
FIX: Font tag resulted in wrong email trimming
2018-12-18 11:40:54 +01:00
Gerhard Schlager
37461a6398
FIX: Weird mixture of line breaks resulted in wrong email trimming
2018-12-18 11:40:54 +01:00
Maja Komel
98d09c90ac
Current user serializer groups ( ef7f84b
follow-up)
2018-12-18 09:05:45 +01:00
Guo Xiang Tan
1590387bd1
SECURITY: Users can pick non-avatar uploads.
...
https://meta.discourse.org/t/bug-report-idor-on-avatar-pick-function-discussions-udacity-com/103564
2018-12-18 13:57:54 +08:00
Sam
69bc8f526a
SECURITY: only allow picking of avatars created by self ( #6417 )
...
* SECURITY: only allow picking of avatars created by self
Also adds origin tracking to all uploads including de-duplicated uploads
2018-12-18 13:57:49 +08:00
Guo Xiang Tan
5c2e194d01
SECURITY: Users can pick non-avatar uploads.
...
https://meta.discourse.org/t/bug-report-idor-on-avatar-pick-function-discussions-udacity-com/103564
2018-12-18 13:38:25 +08:00
Guo Xiang Tan
899caf35ba
Revert "SECURITY: User could non-avatar uploads."
...
This reverts commit 89581fa301
.
2018-12-18 13:37:31 +08:00
Guo Xiang Tan
89581fa301
SECURITY: User could non-avatar uploads.
...
https://meta.discourse.org/t/bug-report-idor-on-avatar-pick-function-discussions-udacity-com/103564
2018-12-18 13:35:33 +08:00
Guo Xiang Tan
d7660dfe40
FIX: Enabling readonly mode should clear anon cache as well.
2018-12-18 11:56:25 +08:00
Sam Saffron
abbbcb2622
DEV: allow creating users with random passwords via rake
...
Use: `RANDOM_PASSWORD=1 bin/rake admin:create`
Handy in conjunction with dev mode /session/username/become.
2018-12-18 11:43:16 +08:00
Jeff Atwood
f67cc2a540
minor copyedit
2018-12-17 19:31:02 -08:00
Kris
2a518c88d0
Prevent bullet badge from shrinking/growing as flex item
2018-12-17 21:05:32 -05:00
Kris
7d7b6baab9
Topic-list category width restriction no longer needed
2018-12-17 21:01:04 -05:00
Vinoth Kannan
efcea148eb
DEV: Use destroy! method to raise error if any (#0d3c1cde)
2018-12-18 03:05:43 +05:30
Vinoth Kannan
ece44a44f8
UX: Change default date range of dashboard trending search report to a month
2018-12-18 03:00:30 +05:30
Gerhard Schlager
2bdbca3801
DEV: Remove unnecessary to_not raise_error
from specs
...
Follow-up to 01cdbd3a13
2018-12-17 16:10:10 +01:00
Bianca Nenciu
5bda4d26b4
FIX: Rescue errors in job. ( #6745 )
2018-12-17 15:28:57 +01:00
Bianca Nenciu
f0027961c7
FIX: Properly reset controller of admin-user-index. ( #6760 )
2018-12-17 15:28:29 +01:00
Bianca Nenciu
1023003eba
FIX: Strip remote url before import. ( #6762 )
2018-12-17 15:27:49 +01:00
Joffrey JAFFEUX
22cea9ce90
FIX: adusts select-kit position even if not expanded ( #6785 )
2018-12-17 12:29:51 +01:00
Joffrey JAFFEUX
6ee3900791
FIX: ensures nothing is triggering rendering loop in after render ( #6784 )
2018-12-17 12:15:03 +01:00
Gerhard Schlager
01cdbd3a13
FEATURE: Prohibit S3 bucket reusage
...
This validation makes sure that the s3_upload_bucket and the
s3_backup_bucket have different values. The backup bucket is
allowed to be a subfolder of the upload bucket. The other way
around is forbidden because the backup system searches by
prefix and would return all files stored within the backup
bucket and its subfolders.
2018-12-17 11:35:28 +01:00
Gerhard Schlager
1a8ca68ea3
FEATURE: Improve backup stats on admin dashboard
...
* Dashboard doesn't timeout anymore when Amazon S3 is used for backups
* Storage stats are now a proper report with the same caching rules
* Changing the backup_location, s3_backup_bucket or creating and deleting backups removes the report from the cache
* It shows the number of backups and the backup location
* It shows the used space for the correct backup location instead of always showing used space on local storage
* It shows the date of the last backup as relative date
2018-12-17 11:35:11 +01:00
Maja Komel
040ddec63d
Fix avatar flair styles
2018-12-17 10:44:34 +01:00