github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2024-11-28 10:15:48 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity
40,049 Commits 214 Branches 500 Tags 960 MiB
e16b3da04a
Commit Graph

179 Commits

Author SHA1 Message Date
Roman Rizzi
bbe5d8d5cf
DEV: Sort imports alphabetically (#11382) 2020-12-01 15:31:26 -03:00
Roman Rizzi
1c2358ba16
DEV: Tidy up imports. (#11364) 
Only allow one import definition per file and add a new eslint rule to enforce it.
 2020-11-27 11:30:16 -03:00
Robin Ward
3394d994e9 FIX: Tests were using jQuery selectors 
For the most part `querySelectorAll` will work with jQuery selectors,
but the big exception is `:eq(0)` and similar. Those needed to be
replaced.
 2020-11-23 11:36:07 -05:00
Robin Ward
0d0ae5e67f REFACTOR: Add support for currentRouteName in test helpers 
This replaces the global `currentPath`
 2020-11-13 09:31:09 -05:00
Penar Musaraj
0b7f43fba8
REFACTOR: Remove SweetAlert dependency (#11183) 2020-11-10 11:31:54 -05:00
Penar Musaraj
57bd85af31
UX: Minor cosmetic fixes to the wizard (#11172) 
- Does not force users to type a description or a welcome topic
- Adds * marker for required text fields (site title and email)
 2020-11-09 15:14:57 -05:00
Penar Musaraj
707ed01f33
UX: Wider canvas buttons in wizard (#11124) 2020-11-05 09:55:35 -05:00
Jarek Radosz
a17d54d0bf
DEV: De-arrowify tests (#11068) 
Using arrow functions changes `this` context, which is undesired in tests, e.g. it makes it impossible to setup things like pretender (`this.server`) in `beforeEach` hooks.

Ember guides always use classic functions in examples (e.g. https://guides.emberjs.com/release/testing/test-types/), and that's what it uses in its own test suite, as do various addons and ember apps.

It was also already used in Discourse where `this` was required. Moving forward, it will be needed in more places as we migrate toward ember-cli.

(I might later add a custom rule to eslint-discourse-ember to enforce this)
 2020-10-30 17:37:32 +01:00
Robin Ward
435a9913a4 REFACTOR: Replace global find with queryAll 
In newer Embers jQuery is removed. There is a `find` but it only returns
one element and not a jQuery selector. This patch migrates our code to a
new helper `queryAll` which allows us to remove the global.
 2020-10-29 14:45:51 -04:00
Robin Ward
b302321451 REFACTOR: Test assertions should be imported. 
Previously they were global functions.
 2020-10-28 11:39:06 -04:00
Robin Ward
51d10db7f2 REFACTOR: Import visit helper rather than using a global variable 2020-10-15 13:22:05 -04:00
Penar Musaraj
2b5ca8af12
FIX: Wizard theme preview when logo is missing (#10914) 
Fixes empty theme previews in the wizard, a bug introduced by yours
truly in a4356b99af
 2020-10-13 20:06:09 -04:00
Robin Ward
3862036422 REFACTOR: Use imports for sinon and setResolver 
I also took the opportunity with this commit to move some test specific
stuff out of `discourse-loader` which is loaded on the front end of the
application. The test module building now happens in the `test_helper`
bundle.
 2020-10-09 13:54:54 -04:00
Robin Ward
71d37953d5 REFACTOR: Import QUnit and related helpers rather than globals 
We used many global functions to handle tests when they should be
imported like other libraries in our application. This also gets us
closer to the way Ember CLI prefers our tests to be laid out.
 2020-10-07 11:50:49 -04:00
Joffrey JAFFEUX
7b34433fc2
REVERT: revert change from action + mut to mut (#10844) 
* Revert "FIX: fixes regression where wizard dropdown couldn't update (#10838)"

This reverts commit e3b2fc6074.

* Revert "DEV: replaces unecessary (action (mut .*)) by (mut .*) (#10822)"

This reverts commit c0350dc362.
 2020-10-06 23:50:05 +02:00
Joffrey JAFFEUX
e3b2fc6074
FIX: fixes regression where wizard dropdown couldn't update (#10838) 2020-10-06 13:33:37 -04:00
Penar Musaraj
e175c467cc
DEV: Do not render header in wizard preview when logo is missing (#10835) 
This can happen if a plugin skips the logo step of the wizard.
 2020-10-06 12:08:41 -04:00
Joffrey JAFFEUX
c0350dc362
DEV: replaces unecessary (action (mut .*)) by (mut .*) (#10822) 2020-10-06 17:17:45 +02:00
Penar Musaraj
4efbf8dc4f
Remove "further reading" step from wizard (#10825) 
Instead, add link to top themes on meta in wizard's last step.
 2020-10-05 15:06:05 -04:00
Robin Ward
39ad9a4734 REFACTOR: Support importing of Pretender 
We shouldn't be using global variables for libraries.
 2020-10-05 14:33:55 -04:00
Penar Musaraj
a4356b99af
FEATURE: Separate base and heading font site_settings (#10807) 
Allows site administrators to pick different fonts for headings in the wizard and in their site settings. Also correctly displays the header logos in wizard previews.
 2020-10-05 13:40:41 -04:00
Penar Musaraj
b1692422b1
FEATURE: Support using system font in wizard font step (#10742) 
Co-authored-by: Bianca Nenciu <nbianca@users.noreply.github.com>
 2020-09-25 09:39:14 -04:00
Penar Musaraj
8fcfb9586c
FEATURE: Dark-mode-friendly wizard (#10739) 
Co-authored-by: Jordan Vidrine <jordan@jordanvidrine.com>
 2020-09-25 08:56:23 -04:00
Robin Ward
7699b90f1a FIX: Wizard does not include discourse-shims 
This allowed tests to pass even when wizard was broken, which is
obviously very bad.
 2020-09-14 12:34:16 -04:00
Bianca Nenciu
d4471e0316
FIX: Preload bold fonts in wizard 
The bold fonts are used in previews for topic title.
 2020-09-04 19:23:46 +03:00
Bianca Nenciu
58b97ace23
DEV: Use a special import to declare font faces (#10583) 
Update discourse-fonts to v0.0.3.

Follow-up to 7b7357147e.
 2020-09-04 16:25:50 +03:00
Joffrey JAFFEUX
52672b9eab
DEV: apply new coding standards (#10592) 2020-09-04 13:42:47 +02:00
Bianca Nenciu
f2e14a3946
FEATURE: Add site setting and wizard step to set base font (#10250) 
Co-authored-by: Neil Lalonde <neillalonde@gmail.com>
 2020-08-31 13:14:09 +03:00
Robin Ward
aae97457d2
REFACTOR: Don't use layoutName in select-kit (#10556) 
Instead import the templates as modules, the way Ember CLI wants us to.
 2020-08-28 15:30:20 -04:00
Robin Ward
a95826f60c
Remove discourse constants (#9958) 
* DEV: `Discourse.baseUri` does not exist

This never could have worked - should have been `Discourse.BaseUri` if
anything.

* DEV: Remove Discourse.Environment

* DEV: Remove `Discourse.disableMissingIconWarning`

* DEV: A bunch more missing environment checks
 2020-06-01 16:33:43 -04:00
Penar Musaraj
a98182debf
UX: Fix activity column display in wizard homepage step 
Followup to f8f281cdad, thanks @jjafeux
 2020-05-28 11:24:24 -04:00
Robin Ward
2033c3ec9c Revert "Revert "DEV: Import MessageBus from message-bus-client instead of globals"" 
This reverts commit b10e995d9d.
 2020-05-28 08:42:36 -04:00
Blake Erickson
b10e995d9d Revert "DEV: Import MessageBus from message-bus-client instead of globals" 
This reverts commit 9dddbcc00d.
 2020-05-27 16:14:09 -06:00
Robin Ward
9dddbcc00d DEV: Import MessageBus from message-bus-client instead of globals 2020-05-27 16:42:42 -04:00
Robin Ward
0f71d38d3a Revert "DEV: Import MessageBus from message-bus-client instead of globals (#9902)" 
This reverts commit d3bd482142.
 2020-05-27 16:34:30 -04:00
Robin Ward
d3bd482142
DEV: Import MessageBus from message-bus-client instead of globals (#9902) 2020-05-27 15:56:46 -04:00
Mark VanLandingham
7820686f73
FIX: Wizard previews if color step is excluded (#9881) 2020-05-26 12:56:36 -05:00
Robin Ward
eab560fe2a
DEV: import I18n instead of global usage (#9768) 
Co-authored-by: Mark VanLandingham <markvanlan@gmail.com>
Co-authored-by: Robin Ward <robin.ward@gmail.com>

Co-authored-by: Mark VanLandingham <markvanlan@gmail.com>
 2020-05-13 16:23:41 -04:00
Joffrey JAFFEUX
98039e6cc5
FIX: template-lint uses strict rel-noopener rule which requires noreferrer (#9449) 2020-04-16 22:38:10 +02:00
Kane York
0fccea3762
FIX: Keyboard navigation fixes in setup wizard (#9413) 
- Delete a positive tabindex from a reused component
 - Copy :hover styles to :focus
 - Replace an 'outline: 0' rule with a TODO for a custom :focus style

Discovered while fixing the no-positive-tabindex lint.
 2020-04-16 12:01:11 -07:00
Joffrey JAFFEUX
5e24436454
DEV: attempts to fix various leaks (#9428) 
* DEV: attempts to fix various leaks

* scheduleOnce doesnt work with anon function

* removes the I18n change
 2020-04-16 07:58:04 +02:00
Kane York
c670a34013 DEV: Fix and enable the 'require-button-type' lint 2020-04-14 18:32:16 -07:00
Joffrey JAFFEUX
c4644c61d9
DEV: enforces double quotes ember-template-lint (#9416) 2020-04-14 08:18:49 +02:00
Joffrey JAFFEUX
b66b277dc4
DEV: enforces block-indentation of ember-template-lint rules (#9408) 2020-04-13 17:17:20 +02:00
Mark VanLandingham
58bec3b200
DEV: Option for adding an icon in wizard-field-checkboxes component (#9363) 2020-04-06 14:00:55 -05:00
Mark VanLandingham
65d9a9c1ce
DEV: Create wizard-field-checkboxes component (#9333) 2020-04-01 13:30:38 -05:00
Mark VanLandingham
689c61b462
DEV: Allow plugins to add wizard steps after specific steps (#9315) 2020-04-01 08:36:50 -05:00
Kane York
2a2555e598 DEV: Partial 'block-indentation' linting fixes 2020-03-30 14:13:33 -07:00
Robin Ward
7f3bb06ac7 FIX: Wizard tests were missing 2020-03-23 14:25:25 -04:00
Robin Ward
1ac0242201 Convert wizard es6 files to js 2020-03-23 14:15:16 -04:00