Guo Xiang Tan
4f301905b6
Make rubocop happy.
2018-03-02 10:15:53 +08:00
Robin Ward
b3883f5c32
FIX: Don't lock a post on edit unless the raw changes
2018-03-01 20:40:19 -05:00
Sam
75172024ca
SECURITY: ensure users have permission when moving categories
2018-03-02 12:13:27 +11:00
Régis Hanol
b2f18fc98f
FIX: system user edits should not generate notifications
2018-01-30 22:21:07 +01:00
Robin Ward
44e2038b53
Setting to automatically lock posts when edited by staff
2018-01-26 14:01:30 -05:00
Guo Xiang Tan
c872225762
Improve MessageBus.track_publish to allow filter by channel.
2017-10-02 11:34:57 +08:00
Guo Xiang Tan
5012d46cbd
Add rubocop to our build. ( #5004 )
2017-07-28 10:20:09 +09:00
Rafael dos Santos Silva
89ef5d36a9
FIX: Explicit error when category description post is bad
2017-07-21 16:07:29 -03:00
Guo Xiang Tan
13f3de4bf6
Nuke all SiteSetting.stubs from our codebase.
2017-07-07 15:09:14 +09:00
Arpit Jalan
4a2f0e772c
add specs for post ownership change without revision
2016-08-20 01:27:48 +05:30
Neil Lalonde
5047979f96
FIX: cannot remove tags from a topic
2016-06-09 12:04:34 -04:00
Robin Ward
e38f17524b
FIX: Reflected links weren't being cleaned up properly
2016-06-08 16:09:01 -04:00
Neil Lalonde
f13470b96b
Use db schema for tags instead of plugin store and custom fields
2016-05-26 14:29:48 -04:00
Guo Xiang Tan
6aa447816d
UX: Publish changes to TopicView when Topic is updated.
2016-04-07 16:29:01 +02:00
Régis Hanol
cf4cb2126a
FIX: word_count wasn't working with non-latin sentences
2016-01-11 11:16:23 +01:00
Andy Waite
3e50313fdc
Prepare for separation of RSpec helper files
...
Since rspec-rails 3, the default installation creates two helper files:
* `spec_helper.rb`
* `rails_helper.rb`
`spec_helper.rb` is intended as a way of running specs that do not
require Rails, whereas `rails_helper.rb` loads Rails (as Discourse's
current `spec_helper.rb` does).
For more information:
https://www.relishapp.com/rspec/rspec-rails/docs/upgrade#default-helper-files
In this commit, I've simply replaced all instances of `spec_helper` with
`rails_helper`, and renamed the original `spec_helper.rb`.
This brings the Discourse project closer to the standard usage of RSpec
in a Rails app.
At present, every spec relies on loading Rails, but there are likely
many that don't need to. In a future pull request, I hope to introduce a
separate, minimal `spec_helper.rb` which can be used in tests which
don't rely on Rails.
2015-12-01 20:39:42 +00:00
Robin Ward
d65ec1af2e
Rename ninja_edit_window to editing_grace_period :'(
2015-11-24 14:28:42 -05:00
Régis Hanol
477f352e8f
FIX: remove latest empty revision
2015-05-29 20:08:39 +02:00
Arthur Neves
b8cbe51026
Convert specs to RSpec 2.99.2 syntax with Transpec
...
This conversion is done by Transpec 3.1.0 with the following command:
transpec
* 424 conversions
from: obj.should
to: expect(obj).to
* 325 conversions
from: == expected
to: eq(expected)
* 38 conversions
from: obj.should_not
to: expect(obj).not_to
* 15 conversions
from: =~ /pattern/
to: match(/pattern/)
* 9 conversions
from: it { should ... }
to: it { is_expected.to ... }
* 5 conversions
from: lambda { }.should_not
to: expect { }.not_to
* 4 conversions
from: lambda { }.should
to: expect { }.to
* 2 conversions
from: -> { }.should
to: expect { }.to
* 2 conversions
from: -> { }.should_not
to: expect { }.not_to
* 1 conversion
from: === expected
to: be === expected
* 1 conversion
from: =~ [1, 2]
to: match_array([1, 2])
For more details: https://github.com/yujinakayama/transpec#supported-conversions
2015-04-25 11:18:35 -04:00
Régis Hanol
7d8dd9d93b
fix some rspec deprecations
2015-02-26 13:05:20 +01:00
Robin Ward
f15b0d205f
FIX: The "too similar" check happened when trying to make a post a wiki
2015-02-02 12:44:56 -05:00
Robin Ward
d43944b3ed
Extensibility for tracking changes to a topic
2015-01-28 13:37:06 -05:00
Luciano Sousa
0fd98b56d8
few components with rspec3 syntax
2015-01-09 13:34:37 -03:00
Régis Hanol
e7f251c105
LOTS of changes to properly handle post/topic revisions
...
FIX: history revision can now properly be hidden
FIX: PostRevision serializer is now entirely dynamic to properly handle
hidden revisions
FIX: default history modal to "side by side" view on mobile
FIX: properly hiden which revision has been hidden
UX: inline category/user/wiki/post_type changes with the revision
details
FEATURE: new '/posts/:post_id/revisions/latest' endpoint to retrieve
latest revision
UX: do not show the hide/show revision button on mobile (no room for
them)
UX: remove CSS transitions on the buttons in the history modal
FIX: PostRevisor now handles all the changes that might create new
revisions
FIX: PostRevision.ensure_consistency! was wrong due to off by 1
mistake...
refactored topic's callbacks for better readability
extracted 'PostRevisionGuardian'
2014-10-27 22:06:43 +01:00
Régis Hanol
de76b512c1
fix most deprecations in the specs (still some left)
2014-09-25 17:44:48 +02:00
Régis Hanol
61db6c95d2
FIX: couldn't start a 4-spaces block on the first line of a post
2014-09-02 01:18:06 +02:00
Sam Saffron
fbbe9f7a19
collapse tests to improve perf of suite
2014-06-16 12:13:28 +10:00
Neil Lalonde
0b1550f9d4
Add excerpt column to topics table to remove N+1 query in ListableTopicSerializer
2014-03-18 15:24:29 -04:00
Sam
5c26b3dad1
FIX: broken specs after new link alerting code
2014-03-18 15:22:53 +11:00
Robin Ward
e453bfa073
Work in progress: Swap out onebox code for onebox gem
2014-01-29 14:14:07 -05:00
Régis Hanol
06dd7ffe3c
better revision history
2013-12-12 03:41:34 +01:00
Robin Ward
6853f37bee
Show estimated reading time near summarize button.
2013-12-10 13:47:36 -05:00
Régis Hanol
f8e2ecfa94
keep track of the user who revised a post
2013-11-06 11:43:40 +01:00
Sam
cc83b55134
fix incorrect test, that fails if shared test state gets corrupt
2013-10-24 14:55:55 +11:00
Jeff Atwood
b64a4100fa
change "visitor" trust level to "new user"
...
I blame me for this mistake.. visitor means other stuff in practice. New
User is correct meaning.
2013-04-17 16:11:24 -07:00
Robin Ward
af9b27358c
If an admin or moderator edits a visitor's post, the restrictions should be based
...
on the *editors* access rights, not the original poster.
2013-04-05 13:59:00 -04:00
Gosha Arinich
cafc75b238
remove trailing whitespaces ❤️
2013-02-26 07:31:35 +03:00
Robin Ward
532b1f5450
Can edit category descriptions, they show up in a title attribute
2013-02-22 13:43:47 -05:00
Grant Ammons
701ecddac2
factor out @post.revise into its own class. clean up PostRevisor class to be more readable
2013-02-09 10:33:25 -05:00
