github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2024-12-19 03:03:48 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity
7,676 Commits 214 Branches 500 Tags 960 MiB
e4aadf2b1e
Commit Graph

2238 Commits

Author SHA1 Message Date
Régis Hanol
6b8a5d1d78 BUGFIX: bound avatars in revision history UI 2014-03-22 17:39:59 +01:00
Neil Lalonde
c3c5ac3ef7 Some tweaks to sub-category badges 2014-03-21 15:33:44 -04:00
Neil Lalonde
c649959e34 Show parent category on category badges 2014-03-21 14:34:50 -04:00
Robin Ward
539890afdf Let's not show tons of extra information about invites unless you're the 
person who invited them.
 2014-03-21 14:16:11 -04:00
Régis Hanol
88ba80b239 Merge pull request #2160 from borhub/fix-excessive-li-in-category-breadcrumb 
Fix visual bug from excessive LIs being rendered around Category breadcrumbs
 2014-03-21 10:00:04 +01:00
Boris
0a330544b3 Prevent rendering of excessive <li> wrapper around a category breadcrumb which already is a <li>. 
The excessive <li> wrapper coming from the template is automatically closed by the browser during the HTML parsing step, causing an empty <li> being visible in the rendered source (preceding the first breadcrumb). This causes a visual bug when not using the default Discourse stylesheet, because the extra LI element pushes the content to the right and sometimes also renders an extra black pixel.
 2014-03-21 16:58:06 +11:00
Vikhyat Korrapati
0f9ea25010 Interface for granting/revoking badges from admin user page. 2014-03-21 11:09:19 +05:30
Vikhyat Korrapati
8163fcade7 Combobox view: escape name string. 2014-03-21 11:09:19 +05:30
Sam
2dc5e3c81e Merge pull request #2118 from vikhyat/firefox-middle-click 
Fix Firefox middle-click popup blocker issue
 2014-03-21 16:27:02 +11:00
Robin Ward
e8ee490778 Extract breaking up a string into a separate file, include it in 
embedded view.
 2014-03-20 14:34:51 -04:00
Sam
619fa50d4b BUGFIX: twitter auth asking for a password 2014-03-20 14:49:25 +11:00
Régis Hanol
44888f7acc FEATURE: upload button on mobile composer 2014-03-19 18:34:08 +01:00
Robin Ward
51e3d72461 Merge pull request #2141 from riking/correctness 
Lots of JS correctness fixes
 2014-03-19 11:20:15 -04:00
Régis Hanol
80bfdeee82 Merge pull request #2147 from vikhyat/serialize-params 
Route `serialize` hook argument is the model, not params
 2014-03-19 09:30:26 +01:00
Vikhyat Korrapati
28731ea633 Route serialize hook argument is the model, not params. 2014-03-19 12:02:27 +05:30
Sam
eab30d1c28 Merge pull request #2146 from vikhyat/badge-system 
Badge creation UI improvements
 2014-03-19 17:11:00 +11:00
Vikhyat Korrapati
89d3835d64 Badge creation UI improvements. 2014-03-19 10:43:38 +05:30
Vikhyat Korrapati
a4461022a3 Move badges admin tab to after users, show only if enabled. 2014-03-19 09:48:04 +05:30
riking
4699136d83 Fix this/self usage warning 
To clarify the intent of using 'this' inside the closure, it is first assigned to a variable.
 2014-03-18 19:09:49 -07:00
riking
8136468ec7 Fix inefficent jQuery usage 
Some jQueries can be cached and reused. This commit does that.
 2014-03-18 19:09:49 -07:00
riking
a871158c80 Fix some bad HTML 2014-03-18 19:09:49 -07:00
riking
2ade638d79 Remove unused variables 2014-03-18 19:09:44 -07:00
riking
834a721bbe Remove two noop backslashes in regexes 2014-03-18 18:24:36 -07:00
riking
86774fa5c1 Simplify return statements 2014-03-18 18:23:15 -07:00
riking
3f35d1062e Remove trailing commas, add trailing semicolons 2014-03-18 18:21:10 -07:00
riking
593f5df503 Corrections to JSDoc 2014-03-18 18:19:20 -07:00
Régis Hanol
a2483b95df BUGFIX: stabilize the buttons in revision history UI 2014-03-19 00:36:02 +01:00
Robin Ward
d0edfe2179 Better error messages if the "Send Test Email" button fails. 2014-03-18 15:26:36 -04:00
Neil Lalonde
2c725e2779 FEATURE: Trust level 4 abilities: pin/unpin, close, archive, make invisible, split/merge topic 2014-03-17 14:50:28 -04:00
Neil Lalonde
f390c92578 Hide the Invite button in topics in secured categories 2014-03-17 10:59:15 -04:00
Régis Hanol
26578d1b73 Merge pull request #2137 from vikhyat/badge-system 
Fix badge description i18n match
 2014-03-17 14:57:03 +01:00
Vikhyat Korrapati
4f71256542 Fix badge description i18n match. 2014-03-17 18:43:09 +05:30
Benjamin Kampmann
e63b9b362e allow apps to give custom admin javascripts 2014-03-17 13:19:08 +01:00
Régis Hanol
2085c82360 Merge pull request #2132 from vikhyat/firefox-paste-image 
Support image copy-paste for Firefox 24+
 2014-03-17 09:29:31 +01:00
Sam
fe63db7953 Merge pull request #2115 from vikhyat/badge-system 
Initial badge system implementation
 2014-03-17 10:06:37 +11:00
Sam
f4c2fef407 Merge pull request #2121 from LessonPlanet/disable-name-edit-for-sso 
Adding name to the list of uneditable items in preferences UI
 2014-03-17 10:05:11 +11:00
Sam
0f359d3f62 Merge pull request #2122 from riking/extensible-share 
Make Discourse.ShareLink fully extensible
 2014-03-17 10:00:37 +11:00
Vikhyat Korrapati
4f910e1c82 Support image copy-paste for Firefox 24+. 2014-03-16 20:04:05 +05:30
Régis Hanol
2b5e4c3919 BUGFIX: revision numbers were unbound in revision history UI 2014-03-14 17:25:02 +01:00
Vikhyat Korrapati
9b26c8584e Initial badge system implementation. 2014-03-14 21:49:26 +05:30
riking
996e5cf021 Make Discourse.ShareLink easy for plugins 
For example, this javascript code, if added by a plugin, would enable a Tumblr share link:

Discourse.ShareLink.addTarget('tumblr', {
  iconClass: 'fa-tumblr',
  generateUrl: function(link, title) {
    return ("http://www.tumblr.com/share/link?url=" + encodeURIComponent(link) + "&description=" + encodeURIComponent(title));
  },
  shouldOpenInPopup: true
});
 2014-03-13 23:38:57 -07:00
Forest Carlisle
e904b2faad Adding name to the list of uneditable items in preferences UI 
* If enable_names,  enable_sso, and sso_overrides_name settings are true.
  * Added serialization of can_edit_name so the UI has access to the right.
 2014-03-13 13:26:40 -07:00
Régis Hanol
d450c7e0de BUGFIX: only resize revision history UI after it has loaded the revision 2014-03-13 19:19:42 +01:00
Régis Hanol
fd1c824187 Revert "Merge pull request #2116 from LessonPlanet/disable-name-edit-for-sso" 
This reverts commit 91aa21671a, reversing
changes made to f19596af0d.
 2014-03-13 18:17:59 +01:00
Robin Ward
0293eb4a13 FIX: Couldn't unbookmark posts 2014-03-13 11:31:07 -04:00
Neil Lalonde
283dc7dd2d Trust level 4: add ability to edit any post and see edit history 2014-03-13 10:47:49 -04:00
Vikhyat Korrapati
e798705aec Do not call preventDefault on right and middle-click/Ctrl+click. 
This should fix the middle click popup blocker issue on Firefox.
 2014-03-13 11:03:19 +05:30
Forest Carlisle
e8c7c6fab7 Adding name to the list of uneditable items in preferences UI 
* If enable_names,  enable_sso, and sso_overrides_name settings are true.
 2014-03-12 17:09:53 -07:00
Neil Lalonde
3175c85fa6 FIX: pin/unpin button in topic admin menu needs to ignore whether the admin user cleared the pin 2014-03-12 14:47:15 -04:00
Régis Hanol
2735f286c4 UI: add calendar icon to all top buttons 2014-03-12 11:34:01 +01:00
Régis Hanol
5ffcfb1a8c TRIVIAL: remove useless condition 2014-03-11 19:06:36 +01:00
Régis Hanol
aece2b61a9 FIX: revision history UI 2014-03-11 18:51:26 +01:00
Vikhyat Korrapati
2e4a699b30 Set canvas height and width for Firefox image copy-paste. 2014-03-11 15:29:44 +05:30
Nick Schonning
635c0dbf7a JSHint i18n.js 
- Mark the I18n object as an overridable global
- Normalize comma first style rather than turning on lax comma
- Add missing semicolons
- Remove unnecessary semicolons
- Fix options overloading in “lookup”
- Use strict comparison for typeof checks and remove unnecessary parens
 2014-03-11 03:01:12 -04:00
Jeff Atwood
8cf29e1339 add envelope icon to invite friends default btn 2014-03-10 17:10:40 -07:00
Jeff Atwood
258ebaf1a8 add calendar icon to best of 2014-03-10 17:05:53 -07:00
Sam
eb2f04d458 PERF: Don't blur all elements on a page 2014-03-11 09:03:24 +11:00
Robin Ward
9929560c40 FIX: Suggested Topics had a hardcoded 5 and was ignoring the 
SiteSetting
 2014-03-10 15:36:45 -04:00
Robin Ward
f5e6bcc585 Create a cold age helper, make sure the first age column is strictly 
`created_at`, add cold to the second column.
 2014-03-10 15:02:39 -04:00
Robin Ward
c430c6dd30 FIX: Only add home class when there is no badge 2014-03-10 13:31:07 -04:00
Régis Hanol
455ff61626 Merge pull request #2071 from nschonni/autocomplete-js-cleaning 
Autocomplete js cleaning
 2014-03-10 17:06:51 +01:00
Robin Ward
9f67d476ef Add bookmarked class to bookmarks button. Also remove duplicated code, 
use fewer observers.
 2014-03-10 12:03:46 -04:00
Robin Ward
33f483a47e Add home class to dropdown for categories 2014-03-10 11:43:24 -04:00
Robin Ward
6626a6c3ea FIX: Don't increase link counts when they are in the thousands 2014-03-10 11:21:48 -04:00
Régis Hanol
c5beb3852f Merge pull request #2092 from nschonni/jshinting 
Jshinting during CI build
 2014-03-10 09:51:11 +01:00
Vikhyat Korrapati
3b1ed996e7 Firefox: Reuse same contenteditable <div> instead of creating a new one on paste. 
This fixes the issue where every alternate paste from a different source
would not work because the content wasn't getting pasted into the
contenteditable div randomly.
 2014-03-10 10:50:52 +05:30
Sam
e49ad34bfc Revert "Hack for supporting pasting images into the composer in Firefox." 
Reverted cause it broke https://meta.discourse.org/t/when-creating-a-reply-pasting-only-works-once/13587

This reverts commit c8c150dfbe.
 2014-03-10 13:43:28 +11:00
Sam
e68e106be7 UI: we only intended to add the word "new" for new topics 2014-03-10 13:40:49 +11:00
Sam
0de759e734 UI: remove usercard hacks, specify width explictly 2014-03-10 10:27:58 +11:00
Sam
68630af718 Merge pull request #2083 from vikhyat/firefox-paste-image 
Hack for supporting pasting images into the composer in Firefox
 2014-03-10 10:06:31 +11:00
Sam
5e83778fc1 PERF: remove ember renderspeed until we make it optional (disabled by default in prd) 2014-03-10 09:50:23 +11:00
Vikhyat Korrapati
b0d1d7a3e8 i18n of new/unread text next to topics. 2014-03-09 16:31:44 +05:30
Vikhyat Korrapati
c8c150dfbe Hack for supporting pasting images into the composer in Firefox. 2014-03-09 04:24:05 +05:30
Kris Aubuchon
10858d3c87 some incremental style enhancements, as discussed here https://meta.discourse.org/t/discourse-design-experiments/13479 2014-03-08 00:55:02 -05:00
Nick Schonning
96bf38757d Update indexOf polyfill 
Updated from the same source as the original comment. If IE8 isn’t
supported then this can be removed.
 2014-03-08 00:37:28 -05:00
Jeff Atwood
4efabef8f2 add btn-primary class to PM in usercard 2014-03-07 14:27:13 -08:00
Robin Ward
145b2931c6 FIX: Forward button would break on some topics 2014-03-07 16:28:53 -05:00
Robin Ward
055b367e2b Add link counts to alt tags of their badges. 2014-03-07 14:43:29 -05:00
Robin Ward
f5c3199b38 FIX: Do not consider hidden elements when wanting to load more 2014-03-07 14:23:13 -05:00
Régis Hanol
8214536614 BUGFIX: don't show redirect reason if you aren't redirected 
Move the redirect to top page logic server-side and make sure the reason
is not shown when top is not in the navigation menu (top_menu).
 2014-03-07 18:58:53 +01:00
Nick Schonning
8b3f2a8685 Remove unused variable 
It is only set to empty then passed
 2014-03-07 12:23:23 -05:00
Nick Schonning
db5ff5f311 Combine single path conditional 2014-03-07 12:23:22 -05:00
Nick Schonning
8961a2ee28 Simplify characterCode lookup 
Reduce String.fromCharCode that can’t be optimized by the minifier.
 2014-03-07 12:23:16 -05:00
Sam
b19400726f BUGFIX/FEATURE: store topic changes in post revisions 
History + edit notifications for title and category changes
 2014-03-07 19:00:36 +11:00
Robin Ward
49a1733d97 FIX: We should use partials when rendering but keeping the same context. 2014-03-06 15:56:33 -05:00
Robin Ward
102242c9d5 Add Dismiss Read to mobile view 2014-03-06 15:32:49 -05:00
Robin Ward
e2ea148e38 FEATURE: Allow customHTML helper to resolve to a template if it 
exists.
 2014-03-06 13:32:32 -05:00
Régis Hanol
ca12ea42a7 FEATURE: only redirect new users to top page for a limited period 
That period is defined by the `redirect_new_users_to_top_page_duration`
site setting and defaults to 7 days.
 2014-03-05 22:11:01 +01:00
Robin Ward
b0f3061113 It doesn't make sense to redirect when not logged in on a non-GET 
request. We should report a failure then. They likely logged out or
in another tab or timed out.
 2014-03-05 12:12:53 -05:00
Régis Hanol
2a99f1b15e BUGFIX: HOME/END keyboard shortcuts on non-topic pages 
This make sure both HOME/END keyboard shortcuts are only applied when viewing a topic
 2014-03-05 16:08:45 +01:00
Régis Hanol
bce4130d39 Merge pull request #2036 from ArmedGuy/profile-backgrounds 
FEATURE: Profile Backgrounds
 2014-03-05 16:00:49 +01:00
Johan Jatko
98c479c3c4 FEATURE: Profile Backgrounds 
Shares a modified codebase with avatars called "user_image"
 2014-03-05 15:10:44 +01:00
Sam
adb6541635 FEATURE: mailing list mode always available 2014-03-05 14:21:53 +11:00
Sam
eb3a535c38 Merge pull request #2038 from fantasticfears/poster_expansion 
poster_expansion will only slide down now.
 2014-03-05 11:27:03 +11:00
Sam
24356cd807 Merge pull request #2050 from verg/unify_scroll_to_first_post 
Scroll to Top of Topic instead of Reloading
 2014-03-05 11:22:54 +11:00
Robin Ward
15c9c90533 When links have thousands of clicks, display them like 3.3K 2014-03-04 13:44:53 -05:00
Robin Ward
e276045112 TRIVIAL: Change some variables to self 2014-03-04 13:09:11 -05:00
verg
7f440532a7 Jump to First Post instead of Reloading Topic 2014-03-03 19:09:42 -05:00
Robin Ward
28f84ef0e1 TEXT: Change to "Dismiss New" 2014-03-03 17:15:53 -05:00
Robin Ward
f9cd354a2c FEATURE: Button to reset new 2014-03-03 15:47:01 -05:00
Robin Ward
6143753fef Support uppercase bbcode too. 2014-03-03 11:59:57 -05:00
Erick Guan
b5ca30bf56 poster_expansion will only slide down now. 2014-03-03 09:32:45 +00:00
Sam
172e517b31 Merge pull request #2012 from ligthyear/incoming-emails 
Advanced New-Topic via Email Feature
 2014-03-03 10:58:10 +11:00
infogulch
bf21a55571 Explicit button text in abandon dialog in all lang 
The current post abandon dialog displays typical yes/no buttons and should
instead show more informative button text.

This commit updates all `config/locales/client.*.yml` files and *alters the
structure* of the `post.abandon` node, and *adds three new nodes* under it:
`confirm`, `yes_value`, and `no_value`. The current value of the
`post.abandon` node is moved into `post.abandon.confirm` for all languages.
For English language text, the nodes `post.abandon.yes_value` and
`.no_value` are changed to `"Yes, abandon"` and `"No, keep"`, respectively.
For other languages, the standard yes/no values are copied, allowing simple
copyedits to make them more explicit in the future.

I also make the necessary changes to the `composer_controller.js` file so
the new values are used correctly.
 2014-02-28 23:42:14 -06:00
Robin Ward
7d6984a915 Make the back button less awkward when leaving a topic. 2014-02-28 15:35:45 -05:00
Robin Ward
61ff04d68b Upgrade ember-cloaking to not trigger scroll events when the back button 
is hit.
 2014-02-28 15:35:45 -05:00
Régis Hanol
5e1019adba FEATURE: better UX when backing-up the site 
Users won't be prompted whenever the site goes into read-only mode.
Instead, a banner will be shown at the top of every pages.

Also, the browser won't automatically reload whenever read-only mode is
disabled. This really was bad UX.
 2014-02-28 18:09:48 +01:00
Benjamin Kampmann
d32cb55837 Add public-inbox to Email-In-Feature 
- Adds the advanced option to accept email from non-users per category email-address
 - Adds tests covering the new feature
 - Adds UI to configure this feature in the frontend
 2014-02-28 16:53:58 +01:00
Benjamin Kampmann
37cea49459 Add Email-In-Per-Category 
- allow the configuration of an inbox-email-address per category
 - post emails to that email into that category instead of global

 - Adds UI for configuration
 - Adds Documentation for configuration
 - Adds Tests for new feature
 2014-02-28 16:53:58 +01:00
Neil Lalonde
3ddd71ffd1 Don't tell you that you successfully flagged a topic. 2014-02-27 18:31:37 -05:00
Sam
6e0e628ff5 BUGFIX: don't force load drafts when composing. 
It will still be there after post is made.
 2014-02-28 10:30:05 +11:00
Robin Ward
4d798abe50 BUGFIX: this fixes a chrome bug... I would laugh if I wasn't already 
crying.
 2014-02-27 16:56:03 -05:00
Régis Hanol
e5a4dc6eac FEATURE: add a banner when read-only mode is enabled 2014-02-27 19:50:20 +01:00
Robin Ward
fee9870427 FIX: New counts were taking into account muted categories 2014-02-27 12:35:33 -05:00
Neil Lalonde
d15d5e2525 Also put the envelope glyph beside topic title edit form for private messages 2014-02-26 18:01:59 -05:00
Neil Lalonde
7322345039 FIX: when shown 403 error page and logging in, it will take you to the same page 2014-02-26 17:53:53 -05:00
Régis Hanol
9571eb07a4 BUGFIX: you should not be able to edit the category on a PM 2014-02-26 22:45:19 +01:00
Robin Ward
9267c162a1 FIX: Showing Unread(1) when you weren't tracking the topic. Also 
includes performance fix when having MANY new or unread topics.
 2014-02-26 15:39:45 -05:00
Neil Lalonde
1165aa2dae Don't show description text on Create Category modal 2014-02-26 13:45:01 -05:00
Régis Hanol
c6bc324259 CLEANUP: remove unused pseudo locale 2014-02-26 19:03:04 +01:00
Neil Lalonde
8167cefe36 Add envelope glyph to private message topic titles 2014-02-26 12:24:21 -05:00
Robin Ward
cae7af4b07 BUGFIX: Do not scroll to top / show spinner when leaving a topic. 2014-02-26 12:04:55 -05:00
Robin Ward
c668d49822 REFACTOR: Use the ScrollTop mixin instead of custom scrolling code. 2014-02-26 11:54:15 -05:00
Sam
440435f023 FEATURE: SSO to handle return_path automatically 2014-02-26 09:58:30 +11:00
Neil Lalonde
8cbff3672f Fixes on mobile signup form 2014-02-25 16:40:30 -05:00
Neil Lalonde
0b1d1ffcba FIX: problems with mobile login modal 2014-02-25 16:40:30 -05:00
Robin Ward
4e1a628ff9 Hooks for extra nav items. 2014-02-25 16:02:27 -05:00
Robin Ward
d079538a6d Allow the customHTML helper to look up fragments outside of the 
preloadStore, so plugins can stuff HTML in there when overriding a whole
template doesn't make sense.
 2014-02-25 16:02:27 -05:00
Sam
6f31d3f0e5 FEATURE: single sign on support 
Added support for outsourcing auth to a different website, documentation on meta
 2014-02-25 14:31:03 +11:00
Benjamin Kampmann
1e609aac77 Fix: apply excludes for user aliases in user selection view 
- fixes a missing reassignment to the new named variable causing the selection of group aliases to fail in the user selector view of private messages
 - apply the list of excludes when a user selects a group alias to prevent double selection of users already in the list and selection of oneself
 2014-02-24 10:35:47 +01:00
Robin Ward
27d3fae4df BUGFIX: Typo was causing dismiss read to use id = 0 instead of id = 1 2014-02-21 21:14:07 -05:00
Régis Hanol
68a935c36b FEATURE: upload backups 2014-02-22 01:41:01 +01:00
Robin Ward
80176cb4cf TRIVIAL: Move button to the bottom of the topic list 2014-02-21 15:59:28 -05:00
Robin Ward
1aa27ade17 FEATURE: If you don't select any topics to "Dissmiss Read" it does all 
by filter.
 2014-02-21 15:18:45 -05:00
Robin Ward
a07e9f7e71 FEATURE: Bulk reset read status. 2014-02-21 15:18:45 -05:00
Robin Ward
7a07f14dfc FEATURE: Can select topics and hit Dismiss Read on the /unread filter 2014-02-21 15:18:45 -05:00
Neil Lalonde
b696c96a19 Look at the age of a user's first post to determine if the user can be nuked, instead of looking at when the user registered. 2014-02-20 12:29:40 -05:00
Robin Ward
a57ecef253 BUGFIX: Do not allow font tags. 2014-02-20 11:10:56 -05:00
Robin Ward
2d398903c0 Allow jump to top on post 2 or 3. 2014-02-19 14:23:43 -05:00
Robin Ward
0c45cf1ee7 FIX: Allow closing the category dropdown when clicking on the same 
category
 2014-02-19 14:17:38 -05:00
Robin Ward
634b769cda Merge pull request #1903 from vikhyat/poll-plugin 
Add poll plugin
 2014-02-19 13:15:43 -05:00
Robin Ward
40585637fe Merge pull request #1948 from riking/patch-3 
Removing more stuff from the sanitizer whitelist
 2014-02-19 12:30:56 -05:00
Régis Hanol
d443ddd43d Merge pull request #1922 from joallard/language-toggle 
Allow users to toggle interface language in their preferences
 2014-02-19 18:28:00 +01:00
Régis Hanol
a682c8fc91 BUGFIX: do not push read-only signal to ALL sites 2014-02-19 18:21:41 +01:00
Kane York
9f8f0f115c Restore 'article' to whitelist 2014-02-18 16:22:42 -08:00
Neil Lalonde
7f6b2e5563 Show login button on 404 page. Add routes to show login and signup modals when page/route loads. If logged in and showing 404 page, load ember app. 2014-02-18 17:18:53 -05:00
Robin Ward
18e98851e3 Use lower case group names in URLs 2014-02-18 16:43:19 -05:00
Sam
3eec3136d5 Merge pull request #1972 from verg/user_pref_save_btn 
Add Save button to top of user preferences
 2014-02-19 08:30:17 +11:00
Robin Ward
f19b0b5fe0 Include members count on groups page. 2014-02-18 16:17:04 -05:00
Jonathan Allard
0592420e52 Add a site setting to allow users to toggle I18n.locale 
It is false by default.
 2014-02-18 14:54:00 -05:00