riking
1833b43ae2
FEATURE: Badge query validation, preview results, and EXPLAIN
...
Upon saving a badge or requesting a badge result preview,
BadgeGranter.contract_checks! will examine the provided badge SQL for
some contractual obligations - namely, the returned columns and use of
trigger parameters.
Saving the badge is wrapped in a transaction to make this easier, by
raising ActiveRecord::Rollback on a detected violation.
On the client, a modal view is added for the badge query sample run
results, named admin-badge-preview.
The preview action is moved up to the route.
The save action, on failure, triggers a 'saveError' action (also in the
route).
The preview action gains a new parameter, 'explain', which will give the
output of an EXPLAIN query for the badge sql, which can be used by forum
admins to estimate the cost of their badge queries.
The preview link is replaced by two links, one which omits (false) and
includes (true) the EXPLAIN query.
The Badge.save() method is amended to propogate errors.
Badge::Trigger gets some utility methods for use in the
BadgeGranter.contract_checks! method.
Additionally, extra checks outside of BadgeGranter.contract_checks! are
added in the preview() method, to cover cases of null granted_at
columns.
An uninitialized variable path is removed in the backfill() method.
TODO - it would be nice to be able to get the actual names of all
columns the provided query returns, so we could give more errors
2014-08-31 11:25:44 -07:00
Jeff Atwood
4281b16616
UX: dim the new and unread education
2014-08-29 22:54:11 -07:00
Régis Hanol
38f52f0f8e
FIX: banner topic's max-width & max-height on both mobile & desktop
2014-08-28 16:15:48 +02:00
Robin Ward
09ea159afc
UX: Add link to change username on admin page
2014-08-27 13:52:01 -04:00
Jeff Atwood
009dc7ded3
missed a spot in CSS
2014-08-27 02:58:32 -07:00
Jeff Atwood
f557f7eeb9
change fix for [quote] padding
2014-08-27 02:45:57 -07:00
Jeff Atwood
dc6dd26b10
FIX: [quote][/quote] missing top padding
2014-08-27 02:22:58 -07:00
Jeff Atwood
587f7f56c8
FIX: share link pushing viewport on mobile
2014-08-27 00:46:26 -07:00
Jeff Atwood
180430de93
LAYOUT: add more space around topic map links
2014-08-27 00:24:58 -07:00
Sam
64331e2ac1
row style is common, its the way we clear divs
2014-08-26 07:41:29 +10:00
Jeff Atwood
de1e0345df
proper fix for top page bottom buttons on mobile
2014-08-25 12:55:45 -07:00
Jeff Atwood
a11cc46c73
remove global margin right on mobile btn
2014-08-25 12:47:02 -07:00
Jeff Atwood
024c503870
mobile login tweaks
2014-08-25 12:38:27 -07:00
Jeff Atwood
3a010c34cc
smallenate anon drop-down topic counts
2014-08-25 12:14:47 -07:00
Sam
af71307363
Add 10px margin for buttons in mobile
2014-08-23 10:41:48 +10:00
Jeff Atwood
ae9fcf17ef
make period chooser (/top h2) unselectable on touch
2014-08-22 17:01:12 -07:00
Kris Aubuchon
a8e6e1e3d5
adding highlight back to topic-list
2014-08-22 10:45:51 -04:00
Robin Ward
c1aa2458f8
UX: Add drop down for top lists, big refactor of repeated code.
2014-08-21 16:08:47 -04:00
Régis Hanol
b2232b4dcf
FIX: banner on small desktop screen
2014-08-20 22:45:57 +02:00
Régis Hanol
8a20d05ba5
FEATURE: backup without uploads
2014-08-20 18:53:58 +02:00
Jeff Atwood
4c66362dd1
remove right-arrow on cross-topic oneboxes
2014-08-19 15:19:01 -07:00
Robin Ward
b46a373ff9
UX: Show User popup when clicking on a user in the topic list.
2014-08-19 16:22:37 -04:00
Régis Hanol
9f72971d26
FEATURE: add the pencil glyph when the post was edited after the first flag
2014-08-18 18:56:39 +02:00
Jeff Atwood
e9bfb1c89e
make share link input field readonly, with css tweaks
2014-08-17 23:08:53 -07:00
Jeff Atwood
09291fcba0
make entire first/last entry popup unselectable
2014-08-16 23:16:13 -07:00
Jeff Atwood
6d09f53dfc
topic jump buttons shouldn't be selectable
2014-08-16 14:20:20 -07:00
Robin Ward
aa41548e8e
UX: When clicking an activity date, pop up a little menu with options to
...
go to beginning or end of the topic.
2014-08-15 16:39:57 -04:00
Jeff Atwood
c04b7cfe8a
only do two levels of coldmapping
2014-08-14 22:27:10 -07:00
Jeff Atwood
f8cb0b6452
we have two sets of heatmap colors, apparently
2014-08-14 21:55:17 -07:00
Jeff Atwood
c32f64fe94
more betterer heat/coldmap color scheme
2014-08-14 21:36:35 -07:00
Jeff Atwood
e539e6ff21
try grey instead of blue for coldmap range
2014-08-14 16:42:31 -07:00
Kris Aubuchon
56e7ca10fe
swapping around heatmap low/high
2014-08-14 09:33:41 -04:00
Jeff Atwood
7fc2892ef4
curse you misaligned semicolon
2014-08-14 03:25:48 -07:00
Jeff Atwood
a7528c858d
hide sign up button from header on mobile
2014-08-14 03:04:09 -07:00
Jeff Atwood
48051127fc
improve keyboard shortcut help layout
2014-08-14 02:54:53 -07:00
Kris Aubuchon
982b007604
heatmap/coldmap should stay red/blue despite theming
2014-08-13 16:38:49 -04:00
riking
62ed597faa
Also put the shaded background on desktop
2014-08-13 12:43:27 -07:00
riking
6b22776160
Style & structure fixes for mobile user page
2014-08-13 12:38:55 -07:00
Jeff Atwood
c89a354fb1
clean up some flag page styles and alignment
2014-08-12 23:52:43 -07:00
Jeff Atwood
c83a742bec
notification dropdown should not be selectable
2014-08-12 23:32:16 -07:00
Kris Aubuchon
6166e78888
adding hover state to notification menu, and small additional fixes
2014-08-13 00:03:29 -04:00
Robin Ward
532726005b
FIX: Heatmaps for posts not showing up if you're not colourblind :)
2014-08-12 16:35:48 -04:00
Robin Ward
e49ef042f1
UX: Remove icon from sign up button, change button order
2014-08-12 13:51:00 -04:00
Robin Ward
1684ff3015
UX: Add a separate "Sign Up" button
2014-08-12 13:47:23 -04:00
Jeff Atwood
63d71fde80
tighten spacing on flags page
2014-08-12 03:49:19 -07:00
Kris Aubuchon
2ce291c2ab
small fixes for dark themes
2014-08-12 00:11:58 -04:00
Robin Ward
c8767dc505
UX: Tweak about page
2014-08-11 18:15:49 -04:00
Robin Ward
996d14965e
Minor UX tweaks
2014-08-11 17:03:12 -04:00
Robin Ward
c103398e9a
First stab at About page
2014-08-11 16:59:15 -04:00
Régis Hanol
5e41408b55
FEATURE: use less space for flag dispositions
2014-08-11 22:28:11 +02:00
Jeff Atwood
0ee07ae2bb
remove group gutter glyph for private topics / pms
2014-08-11 11:44:22 -07:00
Jeff Atwood
5a1162418d
lightbox size was black on black
2014-08-09 15:21:53 -07:00
Jeff Atwood
70d639c241
fix irritating padding asymmetry on notifications
2014-08-08 12:30:44 -07:00
Régis Hanol
4f60eb6c77
FIX: banner on mobile
2014-08-08 12:31:32 +02:00
Régis Hanol
7e7938e37f
FIX: smaller agree/delete flag modals on mobile
2014-08-08 12:10:32 +02:00
Régis Hanol
5ab571e4b7
FIX: agree/delete flag modals on mobile
2014-08-08 12:07:53 +02:00
Sam
49f738fe27
FEATURE: allow users to dismiss unread posts
2014-08-08 16:29:51 +10:00
Kris Aubuchon
180939d6b2
fixing gutter bug on expanded link list
2014-08-07 15:23:41 -04:00
Jeff Atwood
34acd3ed65
missed a topic-progress size on mobile
2014-08-07 02:01:37 -07:00
Robin Ward
fe04a8d8a3
UX: Clicking the large wiki glyph should edit the post.
2014-08-06 14:33:59 -04:00
Régis Hanol
fb0ee2401e
FIX: alignment in notifications
2014-08-06 19:08:12 +02:00
Kris Aubuchon
38696e5a30
bettering support for dark ez-themes
2014-08-06 09:31:13 -04:00
Kris Aubuchon
c3b96d720f
making menu accessible on mobile when in desktop mode
2014-08-05 23:31:28 -04:00
Régis Hanol
3330f5907c
FEATURE: restructure notification HTML layout
2014-08-05 23:36:37 +02:00
Robin Ward
c2ed765396
FIX: Category logos were improperly sized on mobile
2014-08-05 17:09:18 -04:00
Jeff Atwood
40bcead099
add a better style for anon cat hamburger
2014-08-04 22:01:08 -07:00
Jeff Atwood
a4842dd039
12px is too small on categories page
2014-08-04 21:30:40 -07:00
Jeff Atwood
1efc4e2098
tone down new/unread on hamburger categories
2014-08-04 21:17:38 -07:00
Sam
ef5b18779e
FEATURE: merge new and old unread counts on categories page
...
UI: restyle UI to match counts
2014-08-05 10:44:01 +10:00
Jeff Atwood
6fb683ff9a
tone down new/unread on /categories
2014-08-04 15:41:46 -07:00
Régis Hanol
ec30086dea
FEATURE: agree all the flags
2014-08-04 22:48:04 +02:00
Jeff Atwood
04682335d4
adjust img width to auto ONLY ON REPLY EXPANSIONS
2014-08-02 00:10:40 -07:00
Neil Lalonde
212d580745
FIX: styling of bouncing validation errors in composer was broken
2014-08-01 15:11:55 -04:00
Régis Hanol
46a88e0c70
FIX: helpful/flagged posts styling on mobile
2014-08-01 19:18:31 +02:00
Régis Hanol
b414a3590a
FIX: flag count displayed at wrong position
2014-08-01 19:03:12 +02:00
Jeff Atwood
332e3ca8b6
#topic-progress-expanded needed +width too
2014-08-01 02:15:05 -07:00
Jeff Atwood
05e2f5c4a9
missed a few #topic-progress spots, go 145px
2014-08-01 01:41:06 -07:00
Jeff Atwood
beabdc0809
that max-height was way small for mobile
2014-07-31 23:26:16 -07:00
Jeff Atwood
aa9d1594a0
font colors incorrect on mobile user page bio
2014-07-31 22:41:11 -07:00
Jeff Atwood
2c44ac4454
slightly wider topic-progress bar
2014-07-31 21:53:28 -07:00
Kris Aubuchon
3d41ee5f9a
removing text-transforms (interferes with translation)
2014-07-29 23:48:41 -04:00
Régis Hanol
b196de0821
TRIVIAL: use class instead of id for the 'topic-list'
2014-07-29 23:38:36 +02:00
Kris Aubuchon
467b358659
tiger striping on mobile categories
2014-07-29 02:04:20 -04:00
Régis Hanol
cbe3a72c1f
FIX quote-button style on mobile
2014-07-28 21:22:09 +02:00
Régis Hanol
bddffa7f9a
FEATURE: flag dispositions normalization
...
All flags should end up in one of the three dispositions
- Agree
- Disagree
- Defer
In the administration area, the *active* flags section displays 4 buttons
- Agree (hide post + send PM)
- Disagree
- Defer
- Delete
Clicking "Delete" will open a modal that offer to
- Delete Post & Defer Flags
- Delete Post & Agree with Flags
- Delete Spammer (if available)
When the flag has a list associated, the list will now display 1
response and 1 reply and a "show more..." link if there are more in the
conversation. Replying to the conversation will NOT give a disposition.
Moderators must click the buttons that does that.
If someone clicks one buttons, this will add a default moderator message
from that moderator saying what happened.
The *old* flags section now displays the proper dispositions and is
super duper fast (no more N+9999 queries).
FIX: the old list includes deleted topics
FIX: the lists now properly display the topic states (deleted, closed,
archived, hidden, PM)
FIX: flagging a topic that you've already flagged the first post
2014-07-28 19:28:07 +02:00
Kris Aubuchon
22efc2147b
fixing tiger striping on mobile
2014-07-28 10:33:23 -04:00
Sam
1a6aa07611
FEATURE: editable badge groups
2014-07-27 18:22:01 +10:00
Jeff Atwood
f66c39c63b
Merge pull request #2589 from awesomerobot/master
...
reverting notification style
2014-07-25 20:43:14 -07:00
Kris Aubuchon
1557f07e87
reverting notification style
2014-07-25 23:06:14 -04:00
Robin Ward
f4f46aea48
FIX: No, for real don't show Uploading... for non-admin users when they
...
aren't uploading.
2014-07-25 17:08:54 -04:00
Robin Ward
4101a396ad
FIX: Allow buttons to be hidden. Fixes persistent uploading progress on
...
file uploads for non-admins.
2014-07-25 15:09:15 -04:00
Robin Ward
e6819f8879
FIX: Don't capitalize category names in the breadcrumbs. See:
...
https://meta.discourse.org/t/categories-dropdown-inconsistent-text-formatting/18042
2014-07-25 14:37:31 -04:00
Kris Aubuchon
ab8bade9c6
fixing PM notification badge
2014-07-25 13:37:42 -04:00
Kris Aubuchon
f050d3e917
fixing notification style update
2014-07-25 12:22:55 -04:00
Robin Ward
e940723d99
FIX: Prevent Firefox browser crash with too many nested <kbd> tags
2014-07-25 11:16:01 -04:00
Robin Ward
be408242bc
Merge pull request #2581 from awesomerobot/master
...
new notification style, poster expansion border, changing media screen to media all...
2014-07-25 10:55:43 -04:00
Robin Ward
f2b554be13
FIX: Use placeholder for avatar image size in expansion
2014-07-24 17:17:47 -04:00
Kris Aubuchon
4a1ec20585
adding border to poster expansion, changing media screen to media all, trying new notification style
2014-07-24 12:21:22 -04:00
Jeff Atwood
dc96cf6d4c
Merge pull request #2578 from awesomerobot/master
...
minor alignment fix on embedded posts
2014-07-23 22:15:39 -07:00
Kris Aubuchon
b43e4b05c2
minor alignment fix
2014-07-23 23:45:30 -04:00
