Guo Xiang Tan
626808e100
Fix incorrect condition in groups:grant_badge
rake task.
...
`#find` raises an error if the id given to it is invalid. As a result,
the conditional to check whether a `group` or `badge` is `present?` will
not be executed if any of the ids are invalid.
Follow up to
6ba914033c
.
2019-05-09 14:53:13 +08:00
Guo Xiang Tan
867c1a5ac9
DEV: Add request spec for creating an uncategorized category.
2019-05-09 14:53:13 +08:00
Guo Xiang Tan
742decc2a1
PERF: Avoid looking up the same category twice in TopicCreator
.
2019-05-09 14:53:13 +08:00
Guo Xiang Tan
535c594891
Revert "FIX: Return error if new topic category not found"
...
This reverts commit 9c606dd99a
.
2019-05-09 14:53:13 +08:00
Jeff Atwood
d1860536bc
omit needless words
2019-05-08 23:22:51 -07:00
Guo Xiang Tan
7dc58d62e4
DEV: Clear topic title input each smoke test.
...
There may be pre-filled topic title as a result of a draft.
2019-05-09 14:02:45 +08:00
Arpit Jalan
427979e7e5
FEATURE: use full screen login by default for social login methods ( #7481 )
2019-05-09 10:03:01 +05:30
Sam Saffron
88650a1259
PERF: avoid checking for consecutive replies in test
...
This check can issue up to 2 queries per post created, we have specific
tests for it so we can avoid.
This also rolls back #4da6ca4d
2019-05-09 13:28:53 +10:00
Guo Xiang Tan
8ec1f8cf07
DEV: Correct naming convention for JS file.
2019-05-09 10:18:29 +08:00
Daniel Waterworth
4da6ca4d9f
PERF: Skip post validation by default when fabricating posts ( #7508 )
...
This speeds up tests by 10%
2019-05-09 10:15:38 +10:00
Vinoth Kannan
8c07c272f2
make rubocop happy.
2019-05-09 05:25:44 +05:30
Vinoth Kannan
87cd4701b8
FEATURE: option to skip posts with ignored missing uploads
2019-05-09 05:11:15 +05:30
romanrizzi
7c0cb59741
DEV: Skip new JS flaky tests
2019-05-08 18:17:49 -03:00
Blake Erickson
9c606dd99a
FIX: Return error if new topic category not found
...
If creating a topic via the api as an admin and the category you specify
cannot be found an error will now be returned instead of just creating
the topic with no category. This will prevent accidental public topic
creation originally intended for a private category.
2019-05-08 15:02:00 -06:00
Penar Musaraj
a92c925378
Use faster Brotli compression for non-default locale files
2019-05-08 14:55:24 -04:00
Penar Musaraj
d9ab722d05
Revert "Revert "PERF: Skip compressing locales for faster rebuilds ( #7501 )" ( #7502 )"
...
This reverts commit 6ea811c923
.
2019-05-08 14:55:06 -04:00
Joffrey JAFFEUX
e6cfc584d0
Revert "FIX: frozen string exception ( #7506 )"
...
This reverts commit c4b7fb2754
.
2019-05-08 17:27:09 +02:00
Joffrey JAFFEUX
497c0ba418
Revert "FIX: frozen string exception ( #7505 )"
...
This reverts commit 2938e3f033
.
2019-05-08 17:27:03 +02:00
Maja Komel
24ca074f3f
FIX: short description title on client side when empty description
...
follow-up 77af097c
2019-05-08 17:07:12 +02:00
David Taylor
e84531a6a6
FIX: Correctly clear theme stylesheet cache when changing color scheme
2019-05-08 16:02:55 +01:00
Joffrey JAFFEUX
54c2f24ee9
REFACTOR: composer model ( #7499 )
2019-05-08 16:53:12 +02:00
Joffrey JAFFEUX
2938e3f033
FIX: frozen string exception ( #7505 )
...
Initial backtrace:
```
/var/www/discourse/app/mailers/user_notifications.rb:554:in `send_notification_email'
/var/www/discourse/app/mailers/user_notifications.rb:459:in `notification_email'
/var/www/discourse/app/mailers/user_notifications.rb:318:in `user_private_message'
```
* this might fail too
2019-05-08 16:52:38 +02:00
Penar Musaraj
a4eb523af6
Track Discourse user agent pageviews as crawler
...
Since 5bfe051e
, Discourse user agents are marked as non-crawlers (to avoid accidental blacklisting). This makes sure pageviews for these agents are tracked as crawler hits.
2019-05-08 10:38:55 -04:00
Joffrey JAFFEUX
4aaee7ee35
REFACTOR: change-timestamp controller ( #7498 )
2019-05-08 16:26:51 +02:00
Joffrey JAFFEUX
c4b7fb2754
FIX: frozen string exception ( #7506 )
...
Initial backtrace:
```
/var/www/discourse/app/models/incoming_domain.rb:29:in `to_url'
/var/www/discourse/app/models/incoming_link.rb:83:in `referer'
/var/www/discourse/app/models/incoming_link.rb:106:in `referer_valid'
```
2019-05-08 16:25:54 +02:00
Robin Ward
b409dab77f
Rename flags_default_topics
to reviewable_default_topics
...
This functionality regressed with the reviewable update. I took the
opporunity to rename it when fixing it for clarity.
2019-05-08 10:07:10 -04:00
Penar Musaraj
8f2c442435
Fix tests
2019-05-08 09:58:47 -04:00
Penar Musaraj
5bfe051eb9
Mark discourse user-agent as non-crawler
2019-05-08 09:45:25 -04:00
Maja Komel
77af097ce0
FIX: add short description to title on client side
2019-05-08 15:03:33 +02:00
Arpit Jalan
1569cf85df
UX: better permalink feature description/warning.
2019-05-08 18:31:38 +05:30
Daniel Waterworth
ebc5888c95
Prefabricated trust_level_4
2019-05-08 08:57:07 -04:00
Daniel Waterworth
1d0565eca2
Prefabricated admin at the top level
2019-05-08 08:57:07 -04:00
Daniel Waterworth
cef14d81ac
Prefabricated moderator at the top level
2019-05-08 08:57:07 -04:00
Daniel Waterworth
a473a56dc2
Prefabricated user at the top level
2019-05-08 08:57:07 -04:00
Daniel Waterworth
73f25311fa
Prefabricated post by user
2019-05-08 08:54:37 -04:00
Daniel Waterworth
0578809460
Prefabricate trust_level_4
2019-05-08 08:54:37 -04:00
Daniel Waterworth
f984c1740f
Use prefabricated user
2019-05-08 08:54:37 -04:00
Daniel Waterworth
86372a94d5
Prefabricated moderator at the top level
2019-05-08 08:54:37 -04:00
Daniel Waterworth
e3c09c666b
Prefabricated admin
2019-05-08 08:54:37 -04:00
David Taylor
b717e23ceb
FIX: Dynamically adjust scale when rendering wizard canvases
...
This was a typo in fd0de64
2019-05-08 13:14:28 +01:00
Jeff Atwood
24346e4612
strengthen warning around crawler whitelist
2019-05-08 04:10:02 -07:00
Joffrey JAFFEUX
0edf012dd9
Merge branch 'master' of github.com:discourse/discourse
2019-05-08 11:50:50 +02:00
Bianca Nenciu
6efc5dd202
DEV: Fix lint.
2019-05-08 12:07:52 +03:00
Bianca Nenciu
861023f0d6
FIX: Skip attachments in click track.
2019-05-08 11:55:31 +03:00
Guo Xiang Tan
f530048973
Fix broken spec in 405ba00
take 2.
2019-05-08 16:07:14 +08:00
Guo Xiang Tan
f04518fdf9
DEV: Reduce number of jobs enqueued.
...
Apply code review suggestion from
405ba00c08
.
2019-05-08 15:58:08 +08:00
Guo Xiang Tan
ba6904bb27
Fix broken spec in 405ba00c08
.
2019-05-08 15:45:25 +08:00
Guo Xiang Tan
c72f16d927
Follow up to 329969ea20
.
2019-05-08 15:36:12 +08:00
Guo Xiang Tan
405ba00c08
FEATURE: Create notifications on wiki edits for watching users.
...
* Moves creation of notification into background job.
2019-05-08 15:31:10 +08:00
Guo Xiang Tan
46ea69a73c
UX: Initialize client side category model with right search_priority.
...
This is strictly a UX change since the default value of the column is 0.
2019-05-08 14:16:20 +08:00